]> git.lyx.org Git - lyx.git/blobdiff - src/frontends/qt4/GuiWorkArea.cpp
Do the actual drawing in the paint event
[lyx.git] / src / frontends / qt4 / GuiWorkArea.cpp
index 544798b1aca4d94cb22cd54998c54b32af1c0c80..0013670955294c8eb7094be488e6b36ec05838f2 100644 (file)
 
 #include "ColorCache.h"
 #include "FontLoader.h"
+#include "GuiApplication.h"
+#include "GuiCompleter.h"
+#include "GuiKeySymbol.h"
+#include "GuiPainter.h"
+#include "GuiView.h"
 #include "Menus.h"
 
 #include "Buffer.h"
 #include "Cursor.h"
 #include "Font.h"
 #include "FuncRequest.h"
-#include "GuiApplication.h"
-#include "GuiCompleter.h"
-#include "GuiKeySymbol.h"
-#include "GuiPainter.h"
-#include "GuiView.h"
 #include "KeySymbol.h"
 #include "Language.h"
 #include "LyX.h"
@@ -212,7 +212,7 @@ public:
        int cursorWidth() const { return cursor_width_; }
        void recomputeWidth() {
                cursor_width_ = lyxrc.cursor_width
-                       ? lyxrc.cursor_width 
+                       ? lyxrc.cursor_width
                        : 1 + int((lyxrc.currentZoom + 50) / 200.0);
        }
 
@@ -233,7 +233,7 @@ private:
        QRect rect_;
        /// x position (were the vertical line is drawn)
        int x_;
-       
+
        int cursor_width_;
 };
 
@@ -246,18 +246,18 @@ SyntheticMouseEvent::SyntheticMouseEvent()
 
 
 GuiWorkArea::Private::Private(GuiWorkArea * parent)
-: p(parent), screen_(0), buffer_view_(0), lyx_view_(0),
+: p(parent), buffer_view_(0), lyx_view_(0),
   cursor_visible_(false), cursor_(0),
   need_resize_(false), schedule_redraw_(false), preedit_lines_(1),
   pixel_ratio_(1.0),
-  completer_(new GuiCompleter(p, p)), dialog_mode_(false),
+  completer_(new GuiCompleter(p, p)), dialog_mode_(false), shell_escape_(false),
   read_only_(false), clean_(true), externally_modified_(false)
 {
 }
 
 
 GuiWorkArea::GuiWorkArea(QWidget * /* w */)
-: d(new Private(this)) 
+: d(new Private(this))
 {
 }
 
@@ -297,7 +297,6 @@ void GuiWorkArea::init()
                d->cursor_timeout_.setInterval(500);
        }
 
-       d->resetScreen();
        // With Qt4.5 a mouse event will happen before the first paint event
        // so make sure that the buffer view has an up to date metrics.
        d->buffer_view_->resize(viewport()->width(), viewport()->height());
@@ -311,10 +310,11 @@ void GuiWorkArea::init()
        setFrameStyle(QFrame::NoFrame);
        updateWindowTitle();
 
-       viewport()->setAutoFillBackground(false);
+       //viewport()->setAutoFillBackground(false);
        // We don't need double-buffering nor SystemBackground on
        // the viewport because we have our own backing pixmap.
-       viewport()->setAttribute(Qt::WA_NoSystemBackground);
+       //viewport()->setAttribute(Qt::WA_NoSystemBackground);
+       viewport()->setAttribute(Qt::WA_OpaquePaintEvent);
 
        setFocusPolicy(Qt::StrongFocus);
 
@@ -325,10 +325,6 @@ void GuiWorkArea::init()
                        generateSyntheticMouseEvent();
                });
 
-       // Initialize the vertical Scroll Bar
-       QObject::connect(verticalScrollBar(), SIGNAL(valueChanged(int)),
-               this, SLOT(scrollTo(int)));
-
        LYXERR(Debug::GUI, "viewport width: " << viewport()->width()
                << "  viewport height: " << viewport()->height());
 
@@ -346,7 +342,6 @@ GuiWorkArea::~GuiWorkArea()
        try {
                d->buffer_view_->buffer().workAreaManager().remove(this);
        } catch(...) {}
-       delete d->screen_;
        delete d->buffer_view_;
        delete d->cursor_;
        // Completer has a QObject parent and is thus automatically destroyed.
@@ -370,7 +365,7 @@ void GuiWorkArea::Private::setCursorShape(Qt::CursorShape shape)
 
 void GuiWorkArea::Private::updateCursorShape()
 {
-       setCursorShape(buffer_view_->clickableInset() 
+       setCursorShape(buffer_view_->clickableInset()
                ? Qt::PointingHandCursor : Qt::IBeamCursor);
 }
 
@@ -493,8 +488,7 @@ void GuiWorkArea::redraw(bool update_metrics)
        }
 
        LYXERR(Debug::WORKAREA, "WorkArea::redraw screen");
-       d->updateScreen();
-       update(0, 0, viewport()->width(), viewport()->height());
+       viewport()->update();
 
        /// \warning: scrollbar updating *must* be done after the BufferView is drawn
        /// because \c BufferView::updateScrollbar() is called in \c BufferView::draw().
@@ -593,7 +587,7 @@ void GuiWorkArea::Private::resizeBufferView()
        buffer_view_->resize(p->viewport()->width(), p->viewport()->height());
        if (cursor_in_view)
                buffer_view_->scrollToCursor();
-       updateScreen();
+       p->viewport()->update();
 
        // Update scrollbars which might have changed due different
        // BufferView dimension. This is especially important when the
@@ -675,14 +669,18 @@ void GuiWorkArea::toggleCursor()
 
 void GuiWorkArea::Private::updateScrollbar()
 {
+       // Prevent setRange() and setSliderPosition from causing recursive calls via
+       // the signal valueChanged. (#10311)
+       QObject::disconnect(p->verticalScrollBar(), SIGNAL(valueChanged(int)),
+                           p, SLOT(scrollTo(int)));
        ScrollbarParameters const & scroll_ = buffer_view_->scrollbarParameters();
-       // Block signals to prevent setRange() and setSliderPosition from causing
-       // recursive calls via the signal valueChanged. (#10311)
-       QSignalBlocker blocker(p->verticalScrollBar());
        p->verticalScrollBar()->setRange(scroll_.min, scroll_.max);
        p->verticalScrollBar()->setPageStep(scroll_.page_step);
        p->verticalScrollBar()->setSingleStep(scroll_.single_step);
        p->verticalScrollBar()->setSliderPosition(0);
+       // Connect to the vertical scroll bar
+       QObject::connect(p->verticalScrollBar(), SIGNAL(valueChanged(int)),
+                        p, SLOT(scrollTo(int)));
 }
 
 
@@ -775,9 +773,9 @@ void GuiWorkArea::contextMenuEvent(QContextMenuEvent * e)
                }
                name = d->buffer_view_->contextMenu(pos.x(), pos.y());
        }
-       
+
        if (name.empty()) {
-               QAbstractScrollArea::contextMenuEvent(e);
+               e->accept();
                return;
        }
        // always show mnemonics when the keyboard is used to show the context menu
@@ -785,7 +783,7 @@ void GuiWorkArea::contextMenuEvent(QContextMenuEvent * e)
        bool const keyboard = (e->reason() == QContextMenuEvent::Keyboard);
        QMenu * menu = guiApp->menus().menu(toqstr(name), *d->lyx_view_, keyboard);
        if (!menu) {
-               QAbstractScrollArea::contextMenuEvent(e);
+               e->accept();
                return;
        }
        // Position the menu to the right.
@@ -891,7 +889,7 @@ void GuiWorkArea::mouseMoveEvent(QMouseEvent * e)
                        // in the first place.
                        return;
                }
-               
+
                d->synthetic_mouse_event_.restart_timeout = true;
                d->synthetic_mouse_event_.timeout.start();
                // Fall through to handle this event...
@@ -976,7 +974,7 @@ void GuiWorkArea::generateSyntheticMouseEvent()
                if (up || down) {
                        int dist = up ? -e_y : e_y - wh;
                        time = max(min(200, 250000 / (dist * dist)), 1) ;
-                       
+
                        if (time < 40) {
                                step = 80000 / (time * time);
                                time = 40;
@@ -1158,20 +1156,12 @@ void GuiWorkArea::resizeEvent(QResizeEvent * ev)
 }
 
 
-void GuiWorkArea::Private::update(int x, int y, int w, int h)
-{
-       p->viewport()->update(x, y, w, h);
-}
-
-
 void GuiWorkArea::paintEvent(QPaintEvent * ev)
 {
-       QRectF const rc = ev->rect();
        // LYXERR(Debug::PAINTING, "paintEvent begin: x: " << rc.x()
        //      << " y: " << rc.y() << " w: " << rc.width() << " h: " << rc.height());
 
        if (d->needResize()) {
-               d->resetScreen();
                d->resizeBufferView();
                if (d->cursor_visible_) {
                        d->hideCursor();
@@ -1179,29 +1169,14 @@ void GuiWorkArea::paintEvent(QPaintEvent * ev)
                }
        }
 
-       QPainter pain(viewport());
-       double const pr = pixelRatio();
-       QRectF const rcs = QRectF(rc.x() * pr, rc.y() * pr, rc.width() * pr, rc.height() * pr);
+       GuiPainter pain(viewport(), pixelRatio());
+       d->buffer_view_->draw(pain);
 
-       if (lyxrc.use_qimage) {
-               QImage const & image = static_cast<QImage const &>(*d->screen_);
-               pain.drawImage(rc, image, rcs);
-       } else {
-               QPixmap const & pixmap = static_cast<QPixmap const &>(*d->screen_);
-               pain.drawPixmap(rc, pixmap, rcs);
-       }
        d->cursor_->draw(pain);
        ev->accept();
 }
 
 
-void GuiWorkArea::Private::updateScreen()
-{
-       GuiPainter pain(screen_, p->pixelRatio());
-       buffer_view_->draw(pain);
-}
-
-
 void GuiWorkArea::Private::showCursor(int x, int y, int h,
        bool l_shape, bool rtl, bool completable)
 {
@@ -1211,9 +1186,8 @@ void GuiWorkArea::Private::showCursor(int x, int y, int h,
                // We can't use redraw() here because this would trigger a infinite
                // recursive loop with showCursor().
                buffer_view_->resize(p->viewport()->width(), p->viewport()->height());
-               updateScreen();
+               p->viewport()->update();
                updateScrollbar();
-               p->viewport()->update(QRect(0, 0, p->viewport()->width(), p->viewport()->height()));
                schedule_redraw_ = false;
                // Show the cursor immediately after the update.
                hideCursor();
@@ -1237,6 +1211,10 @@ void GuiWorkArea::Private::removeCursor()
 
 void GuiWorkArea::inputMethodEvent(QInputMethodEvent * e)
 {
+//FIXME Broken Feature !!
+// I do not think that we are supposed to paint inside this event. Shall we
+// just let TextMetrics::breakRow add this to the relevant Row object?
+#if 0
        QString const & commit_string = e->commitString();
        docstring const & preedit_string
                = qstring_to_ucs4(e->preeditString());
@@ -1271,9 +1249,8 @@ void GuiWorkArea::inputMethodEvent(QInputMethodEvent * e)
                return;
        }
 
-       GuiPainter pain(d->screen_, pixelRatio());
        d->buffer_view_->updateMetrics();
-       d->buffer_view_->draw(pain);
+       viewport()->update();
        // FIXME: shall we use real_current_font here? (see #10478)
        FontInfo font = d->buffer_view_->cursor().getFont().fontInfo();
        FontMetrics const & fm = theFontMetrics(font);
@@ -1282,7 +1259,7 @@ void GuiWorkArea::inputMethodEvent(QInputMethodEvent * e)
        int cur_y = d->cursor_->rect().bottom();
 
        // redraw area of preedit string.
-       update(0, cur_y - height, viewport()->width(),
+       viewport()->update(0, cur_y - height, viewport()->width(),
                (height + 1) * d->preedit_lines_);
 
        if (preedit_string.empty()) {
@@ -1365,12 +1342,14 @@ void GuiWorkArea::inputMethodEvent(QInputMethodEvent * e)
                        ps = Painter::preedit_cursor;
 
                // draw one character and update cur_x.
+               GuiPainter pain(d->screen_, pixelRatio());
                cur_x += pain.preeditText(cur_x, cur_y, typed_char, font, ps);
        }
 
        // update the preedit string screen area.
-       update(0, cur_y - d->preedit_lines_*height, viewport()->width(),
+       viewport()->update(0, cur_y - d->preedit_lines_*height, viewport()->width(),
                (height + 1) * d->preedit_lines_);
+#endif
 
        // Don't forget to accept the event!
        e->accept();
@@ -1401,11 +1380,13 @@ void GuiWorkArea::updateWindowTitle()
 {
        Buffer const & buf = bufferView().buffer();
        if (buf.fileName() != d->file_name_
+           || buf.params().shell_escape != d->shell_escape_
            || buf.hasReadonlyFlag() != d->read_only_
            || buf.lyxvc().vcstatus() != d->vc_status_
            || buf.isClean() != d->clean_
            || buf.notifiesExternalModification() != d->externally_modified_) {
                d->file_name_ = buf.fileName();
+               d->shell_escape_ = buf.params().shell_escape;
                d->read_only_ = buf.hasReadonlyFlag();
                d->vc_status_ = buf.lyxvc().vcstatus();
                d->clean_ = buf.isClean();
@@ -1626,7 +1607,7 @@ void TabWorkArea::paintEvent(QPaintEvent * event)
        if (tabBar()->isVisible()) {
                QTabWidget::paintEvent(event);
        } else {
-               // Prevent the selected tab to influence the 
+               // Prevent the selected tab to influence the
                // painting of the frame of the tab widget.
                // This is needed for gtk style in Qt.
                QStylePainter p(this);