]> git.lyx.org Git - lyx.git/blobdiff - src/frontends/qt4/GuiView.cpp
Return ExportStatus from Buffer to GuiView
[lyx.git] / src / frontends / qt4 / GuiView.cpp
index 0579c32ba7fb427fffbbf52decca8d35409e1d35..54cb368f8874ab4e999f32c9e56b7d2968b53f13 100644 (file)
@@ -212,7 +212,7 @@ struct GuiView::GuiViewPrivate
        {
                // hardcode here the platform specific icon size
                smallIconSize = 16;  // scaling problems
-               normalIconSize = 22; // ok, default if iconsize.png is missing
+               normalIconSize = 20; // ok, default if iconsize.png is missing
                bigIconSize = 26;       // better for some math icons
 
                // if it exists, use width of iconsize.png as normal size
@@ -331,7 +331,7 @@ struct GuiView::GuiViewPrivate
        }
 
 #if (QT_VERSION >= 0x040400)
-       void setPreviewFuture(QFuture<docstring> const & f)
+       void setPreviewFuture(QFuture<Buffer::ExportStatus> const & f)
        {
                if (processing_thread_watcher_.isRunning()) {
                        // we prefer to cancel this preview in order to keep a snappy
@@ -382,30 +382,31 @@ public:
 #if (QT_VERSION >= 0x040400)
        ///
        QFutureWatcher<docstring> autosave_watcher_;
-       QFutureWatcher<docstring> processing_thread_watcher_;
+       QFutureWatcher<Buffer::ExportStatus> processing_thread_watcher_;
        ///
        string last_export_format;
+       string processing_format;
 #else
        struct DummyWatcher { bool isRunning(){return false;} };
        DummyWatcher processing_thread_watcher_;
 #endif
 
        static QSet<Buffer const *> busyBuffers;
-       static docstring previewAndDestroy(Buffer const * orig, Buffer * buffer, string const & format);
-       static docstring exportAndDestroy(Buffer const * orig, Buffer * buffer, string const & format);
-       static docstring compileAndDestroy(Buffer const * orig, Buffer * buffer, string const & format);
+       static Buffer::ExportStatus previewAndDestroy(Buffer const * orig, Buffer * buffer, string const & format);
+       static Buffer::ExportStatus exportAndDestroy(Buffer const * orig, Buffer * buffer, string const & format);
+       static Buffer::ExportStatus compileAndDestroy(Buffer const * orig, Buffer * buffer, string const & format);
        static docstring autosaveAndDestroy(Buffer const * orig, Buffer * buffer);
 
        template<class T>
-       static docstring runAndDestroy(const T& func, Buffer const * orig, Buffer * buffer, string const & format, string const & msg);
+       static Buffer::ExportStatus runAndDestroy(const T& func, Buffer const * orig, Buffer * buffer, string const & format, string const & msg);
 
        // TODO syncFunc/previewFunc: use bind
        bool asyncBufferProcessing(string const & argument,
                                   Buffer const * used_buffer,
                                   docstring const & msg,
-                                  docstring (*asyncFunc)(Buffer const *, Buffer *, string const &),
-                                  bool (Buffer::*syncFunc)(string const &, bool, bool) const,
-                                  bool (Buffer::*previewFunc)(string const &, bool) const);
+                                  Buffer::ExportStatus (*asyncFunc)(Buffer const *, Buffer *, string const &),
+                                  Buffer::ExportStatus (Buffer::*syncFunc)(string const &, bool) const,
+                                  Buffer::ExportStatus (Buffer::*previewFunc)(string const &) const);
 
        QVector<GuiWorkArea*> guiWorkAreas();
 };
@@ -537,9 +538,30 @@ void GuiView::processingThreadStarted()
 
 void GuiView::processingThreadFinished(bool show_errors)
 {
-       QFutureWatcher<docstring> const * watcher =
-               static_cast<QFutureWatcher<docstring> const *>(sender());
-       message(watcher->result());
+       QFutureWatcher<Buffer::ExportStatus> const * watcher =
+               static_cast<QFutureWatcher<Buffer::ExportStatus> const *>(sender());
+
+       Buffer::ExportStatus const status = watcher->result();
+       docstring msg;
+       switch (status) {
+       case Buffer::ExportSuccess:
+               msg = _("Successful export to format: %1$s");
+               break;
+       case Buffer::ExportError:
+       case Buffer::ExportNoPathToFormat:
+       case Buffer::ExportTexPathHasSpaces:
+       case Buffer::ExportConverterError:
+               msg = _("Error while exporting format: %1$s");
+               break;
+       case Buffer::PreviewSuccess:
+               msg = _("Successful preview of format: %1$s");
+               break;
+       case Buffer::PreviewError:
+               msg = _("Error while previewing format: %1$s");
+               break;
+       }
+       message(bformat(msg, from_utf8(d.processing_format)));
+       
        updateToolbars();
        if (show_errors) {
                BufferView const * const bv = currentBufferView();
@@ -628,9 +650,9 @@ bool GuiView::restoreLayout()
        //code below is skipped when when ~/.config/LyX is (re)created
        QSize icon_size = settings.value(icon_key).toSize();
        // Check whether session size changed.
-       if (icon_size.width() != d.smallIconSize &&
-           icon_size.width() != d.normalIconSize &&
-           icon_size.width() != d.bigIconSize) {
+       if (icon_size.width() != int(d.smallIconSize) &&
+           icon_size.width() != int(d.normalIconSize) &&
+           icon_size.width() != int(d.bigIconSize)) {
                icon_size.setWidth(d.normalIconSize);
                icon_size.setHeight(d.normalIconSize);
        }
@@ -801,6 +823,7 @@ void GuiView::showEvent(QShowEvent * e)
                // No work area, switch to the background widget.
                d.setBackground();
 
+       updateToolbars();
        QMainWindow::showEvent(e);
 }
 
@@ -897,7 +920,7 @@ void GuiView::dropEvent(QDropEvent * event)
                        = theConverters().importableFormats();
                vector<const Format *>::const_iterator it = import_formats.begin();
                for (; it != import_formats.end(); ++it)
-                       if ((*it)->extension() == ext)
+                       if ((*it)->hasExtension(ext))
                                found_formats.push_back(*it);
 
                FuncRequest cmd;
@@ -993,6 +1016,8 @@ void GuiView::updateWindowTitle(GuiWorkArea * wa)
 
 void GuiView::on_currentWorkAreaChanged(GuiWorkArea * wa)
 {
+       QObject::disconnect(d.current_work_area_, SIGNAL(busy(bool)),
+               this, SLOT(setBusy(bool)));
        disconnectBuffer();
        disconnectBufferView();
        connectBufferView(wa->bufferView());
@@ -1000,6 +1025,7 @@ void GuiView::on_currentWorkAreaChanged(GuiWorkArea * wa)
        d.current_work_area_ = wa;
        QObject::connect(wa, SIGNAL(titleChanged(GuiWorkArea *)),
                this, SLOT(updateWindowTitle(GuiWorkArea *)));
+       QObject::connect(wa, SIGNAL(busy(bool)), this, SLOT(setBusy(bool)));
        updateWindowTitle(wa);
 
        structureChanged();
@@ -1172,20 +1198,12 @@ void GuiView::setBusy(bool busy)
                // busy state didn't change
                return;
 
-       if (d.current_work_area_) {
-               //Why would we want to stop updates only for one workarea and
-               //not for the others ? This leads to problems as in #7314 (vfr).
-               //d.current_work_area_->setUpdatesEnabled(!busy);
-               if (busy)
-                       d.current_work_area_->stopBlinkingCursor();
-               else
-                       d.current_work_area_->startBlinkingCursor();
-       }
-
-       if (busy)
+       if (busy) {
                QApplication::setOverrideCursor(Qt::WaitCursor);
-       else
-               QApplication::restoreOverrideCursor();
+               return;
+       }
+       QApplication::restoreOverrideCursor();
+       updateLayoutList();     
 }
 
 
@@ -1457,7 +1475,7 @@ void GuiView::errors(string const & error_type, bool from_master)
            from_master = true;
        }
 #else
-       ErrorList & el = from_master ?
+       ErrorList const & el = from_master ?
                bv->buffer().masterBuffer()->errorList(error_type) :
                bv->buffer().errorList(error_type);
 #endif
@@ -1616,8 +1634,8 @@ bool GuiView::getStatus(FuncRequest const & cmd, FuncStatus & flag)
                }
                string format = to_utf8(cmd.argument());
                if (cmd.argument().empty())
-                       format = doc_buffer->getDefaultOutputFormat();
-               enable = doc_buffer->isExportableFormat(format);
+                       format = doc_buffer->params().getDefaultOutputFormat();
+               enable = doc_buffer->params().isExportableFormat(format);
                break;
        }
 
@@ -1656,6 +1674,7 @@ bool GuiView::getStatus(FuncRequest const & cmd, FuncStatus & flag)
        }
 
        case LFUN_BUFFER_WRITE_AS:
+       case LFUN_BUFFER_EXPORT_AS:
                enable = doc_buffer;
                break;
 
@@ -1721,7 +1740,7 @@ bool GuiView::getStatus(FuncRequest const & cmd, FuncStatus & flag)
                                || name == "progress"
                                || name == "compare";
                else if (name == "print")
-                       enable = doc_buffer->isExportable("dvi")
+                       enable = doc_buffer->params().isExportable("dvi")
                                && lyxrc.print_command != "none";
                else if (name == "character" || name == "symbols") {
                        if (!buf || buf->isReadonly())
@@ -1895,8 +1914,8 @@ Buffer * GuiView::loadDocument(FileName const & filename, bool tolastfiles)
                return 0;
        }
 
-       newBuffer->errors("Parse");
        setBuffer(newBuffer);
+       newBuffer->errors("Parse");
 
        if (tolastfiles)
                theSession().lastFiles().add(filename);
@@ -2066,10 +2085,10 @@ void GuiView::importDocument(string const & argument)
                        toqstr(addPath(package().system_support().absFileName(), "examples")));
 
                docstring filter = formats.prettyName(format);
-               filter += " (*.";
+               filter += " (*.{";
                // FIXME UNICODE
-               filter += from_utf8(formats.extension(format));
-               filter += ')';
+               filter += from_utf8(formats.extensions(format));
+               filter += "})";
 
                FileDialog::Result result =
                        dlg.open(toqstr(initpath), fileFilters(toqstr(filter)));
@@ -2312,6 +2331,81 @@ bool GuiView::renameBuffer(Buffer & b, docstring const & newname)
 }
 
 
+struct PrettyNameComparator
+{
+       bool operator()(Format const *first, Format const *second) const {
+               return compare_ascii_no_case(first->prettyname(), second->prettyname()) <= 0;
+       }
+};
+
+
+bool GuiView::exportBufferAs(Buffer & b)
+{
+       FileName fname = b.fileName();
+
+       FileDialog dlg(qt_("Choose a filename to export the document as"));
+       dlg.setButton1(qt_("Documents|#o#O"), toqstr(lyxrc.document_path));
+
+       QStringList types;
+       types << "Any supported format (*.*)";
+       Formats::const_iterator it = formats.begin();
+       vector<Format const *> export_formats;
+       for (; it != formats.end(); ++it)
+               if (it->documentFormat() && it->inExportMenu())
+                       export_formats.push_back(&(*it));
+       PrettyNameComparator cmp;
+       sort(export_formats.begin(), export_formats.end(), cmp);
+       vector<Format const *>::const_iterator fit = export_formats.begin();
+       for (; fit != export_formats.end(); ++fit)
+               types << toqstr((*fit)->prettyname() + " (*." + (*fit)->extension() + ")");
+       QString filter;
+       FileDialog::Result result =
+               dlg.save(toqstr(fname.onlyPath().absFileName()),
+                        types,
+                        toqstr(fname.onlyFileName()),
+                        &filter);
+       if (result.first != FileDialog::Chosen)
+               return false;
+
+       string s = fromqstr(filter);
+       size_t pos = s.find(" (*.");
+       LASSERT(pos != string::npos, /**/);
+       string fmt_prettyname = s.substr(0, pos);
+       string fmt_name;
+       fname.set(fromqstr(result.second));
+       if (fmt_prettyname == "Any supported format")
+               fmt_name = formats.getFormatFromExtension(fname.extension());
+       else
+               fmt_name = formats.getFormatFromPrettyName(fmt_prettyname);
+       LYXERR(Debug::FILES, "fmt_prettyname=" << fmt_prettyname
+              << ", fmt_name=" << fmt_name << ", fname=" << fname.absFileName());
+
+       if (fmt_name.empty() || fname.empty())
+               return false;
+
+       // fname is now the new Buffer location.
+       if (FileName(fname).exists()) {
+               docstring const file = makeDisplayPath(fname.absFileName(), 30);
+               docstring text = bformat(_("The document %1$s already "
+                                          "exists.\n\nDo you want to "
+                                          "overwrite that document?"),
+                                        file);
+               int const ret = Alert::prompt(_("Overwrite document?"),
+                       text, 0, 2, _("&Overwrite"), _("&Rename"), _("&Cancel"));
+               switch (ret) {
+               case 0: break;
+               case 1: return exportBufferAs(b);
+               case 2: return false;
+               }
+       }
+
+       FuncRequest cmd(LFUN_BUFFER_EXPORT, fmt_name + " " + fname.absFileName());
+       DispatchResult dr;
+       dispatch(cmd, dr);
+       return dr.dispatched();
+}
+
+
 bool GuiView::saveBuffer(Buffer & b) {
        return saveBuffer(b, FileName());
 }
@@ -2930,6 +3024,13 @@ bool GuiView::goToFileRow(string const & argument)
                        return false;
                }
        }
+       if (!buf) {
+               message(bformat(
+                       _("No buffer for file: %1$s."),
+                       makeDisplayPath(file_name))
+               );
+               return false;
+       }
        setBuffer(buf);
        documentBufferView()->setCursorFromRow(row);
        return true;
@@ -2938,67 +3039,61 @@ bool GuiView::goToFileRow(string const & argument)
 
 #if (QT_VERSION >= 0x040400)
 template<class T>
-docstring GuiView::GuiViewPrivate::runAndDestroy(const T& func, Buffer const * orig, Buffer * buffer, string const & format, string const & msg)
+Buffer::ExportStatus GuiView::GuiViewPrivate::runAndDestroy(const T& func, Buffer const * orig, Buffer * buffer, string const & format, string const & msg)
 {
-       bool const update_unincluded =
-                               buffer->params().maintain_unincluded_children
-                               && !buffer->params().getIncludedChildren().empty();
-       bool const success = func(format, update_unincluded);
-       delete buffer;
+       Buffer::ExportStatus const status = func(format);
+
+       // the cloning operation will have produced a clone of the entire set of
+       // documents, starting from the master. so we must delete those.
+       Buffer * mbuf = const_cast<Buffer *>(buffer->masterBuffer());
+       delete mbuf;
        busyBuffers.remove(orig);
-       if (msg == "preview") {
-               return success
-                       ? bformat(_("Successful preview of format: %1$s"), from_utf8(format))
-                       : bformat(_("Error while previewing format: %1$s"), from_utf8(format));
-       }
-       return success
-               ? bformat(_("Successful export to format: %1$s"), from_utf8(format))
-               : bformat(_("Error while exporting format: %1$s"), from_utf8(format));
+       return status;
 }
 
 
-docstring GuiView::GuiViewPrivate::compileAndDestroy(Buffer const * orig, Buffer * buffer, string const & format)
+Buffer::ExportStatus GuiView::GuiViewPrivate::compileAndDestroy(Buffer const * orig, Buffer * buffer, string const & format)
 {
-       bool (Buffer::* mem_func)(std::string const &, bool, bool) const = &Buffer::doExport;
-       return runAndDestroy(bind(mem_func, buffer, _1, true, _2), orig, buffer, format, "export");
+       Buffer::ExportStatus (Buffer::* mem_func)(std::string const &, bool) const = &Buffer::doExport;
+       return runAndDestroy(bind(mem_func, buffer, _1, true), orig, buffer, format, "export");
 }
 
 
-docstring GuiView::GuiViewPrivate::exportAndDestroy(Buffer const * orig, Buffer * buffer, string const & format)
+Buffer::ExportStatus GuiView::GuiViewPrivate::exportAndDestroy(Buffer const * orig, Buffer * buffer, string const & format)
 {
-       bool (Buffer::* mem_func)(std::string const &, bool, bool) const = &Buffer::doExport;
-       return runAndDestroy(bind(mem_func, buffer, _1, false, _2), orig, buffer, format, "export");
+       Buffer::ExportStatus (Buffer::* mem_func)(std::string const &, bool) const = &Buffer::doExport;
+       return runAndDestroy(bind(mem_func, buffer, _1, false), orig, buffer, format, "export");
 }
 
 
-docstring GuiView::GuiViewPrivate::previewAndDestroy(Buffer const * orig, Buffer * buffer, string const & format)
+Buffer::ExportStatus GuiView::GuiViewPrivate::previewAndDestroy(Buffer const * orig, Buffer * buffer, string const & format)
 {
-       bool(Buffer::* mem_func)(std::string const &, bool) const = &Buffer::preview;
-       return runAndDestroy(bind(mem_func, buffer, _1, _2), orig, buffer, format, "preview");
+       Buffer::ExportStatus (Buffer::* mem_func)(std::string const &) const = &Buffer::preview;
+       return runAndDestroy(bind(mem_func, buffer, _1), orig, buffer, format, "preview");
 }
 
 #else
 
 // not used, but the linker needs them
 
-docstring GuiView::GuiViewPrivate::compileAndDestroy(
+Buffer::ExportStatus GuiView::GuiViewPrivate::compileAndDestroy(
                Buffer const *, Buffer *, string const &)
 {
-       return docstring();
+       return Buffer::ExportSuccess;
 }
 
 
-docstring GuiView::GuiViewPrivate::exportAndDestroy(
+Buffer::ExportStatus GuiView::GuiViewPrivate::exportAndDestroy(
                Buffer const *, Buffer *, string const &)
 {
-       return docstring();
+       return Buffer::ExportSuccess;
 }
 
 
-docstring GuiView::GuiViewPrivate::previewAndDestroy(
+Buffer::ExportStatus GuiView::GuiViewPrivate::previewAndDestroy(
                Buffer const *, Buffer *, string const &)
 {
-       return docstring();
+       return Buffer::ExportSuccess;
 }
 
 #endif
@@ -3008,16 +3103,16 @@ bool GuiView::GuiViewPrivate::asyncBufferProcessing(
                           string const & argument,
                           Buffer const * used_buffer,
                           docstring const & msg,
-                          docstring (*asyncFunc)(Buffer const *, Buffer *, string const &),
-                          bool (Buffer::*syncFunc)(string const &, bool, bool) const,
-                          bool (Buffer::*previewFunc)(string const &, bool) const)
+                          Buffer::ExportStatus (*asyncFunc)(Buffer const *, Buffer *, string const &),
+                          Buffer::ExportStatus (Buffer::*syncFunc)(string const &, bool) const,
+                          Buffer::ExportStatus (Buffer::*previewFunc)(string const &) const)
 {
        if (!used_buffer)
                return false;
 
        string format = argument;
        if (format.empty())
-               format = used_buffer->getDefaultOutputFormat();
+               format = used_buffer->params().getDefaultOutputFormat();
 
 #if EXPORT_in_THREAD && (QT_VERSION >= 0x040400)
        if (!msg.empty()) {
@@ -3025,13 +3120,14 @@ bool GuiView::GuiViewPrivate::asyncBufferProcessing(
                gv_->message(msg);
        }
        GuiViewPrivate::busyBuffers.insert(used_buffer);
-       QFuture<docstring> f = QtConcurrent::run(
+       QFuture<Buffer::ExportStatus> f = QtConcurrent::run(
                                asyncFunc,
                                used_buffer,
                                used_buffer->clone(),
                                format);
        setPreviewFuture(f);
-       last_export_format = used_buffer->bufferFormat();
+       processing_format = format;
+       last_export_format = used_buffer->params().bufferFormat();
        (void) syncFunc;
        (void) previewFunc;
        // We are asynchronous, so we don't know here anything about the success
@@ -3039,10 +3135,7 @@ bool GuiView::GuiViewPrivate::asyncBufferProcessing(
 #else
        if (syncFunc) {
                // TODO check here if it breaks exporting with Qt < 4.4
-               bool const update_unincluded =
-                               used_buffer->params().maintain_unincluded_children &&
-                               !used_buffer->params().getIncludedChildren().empty();
-               return (used_buffer->*syncFunc)(format, true, update_unincluded);
+               return (used_buffer->*syncFunc)(format, true);
        } else if (previewFunc) {
                return (used_buffer->*previewFunc)(format, false);
        }
@@ -3063,7 +3156,7 @@ void GuiView::dispatchToBufferView(FuncRequest const & cmd, DispatchResult & dr)
 
        // Try with the document BufferView dispatch if any.
        BufferView * doc_bv = documentBufferView();
-       if (doc_bv) {
+       if (doc_bv && doc_bv != bv) {
                doc_bv->dispatch(cmd, dr);
                if (dr.dispatched())
                        return;
@@ -3129,7 +3222,7 @@ void GuiView::dispatch(FuncRequest const & cmd, DispatchResult & dr)
 #if QT_VERSION < 0x040400
                        if (!doc_buffer->doExport(argument, false)) {
                                dr.setError(true);
-                               dr.setMessage(bformat(_("Error exporting to format: %1$s."),
+                               dr.setMessage(bformat(_("Error exporting to format: %1$s"),
                                        cmd.argument()));
                        }
 #else
@@ -3146,6 +3239,11 @@ void GuiView::dispatch(FuncRequest const & cmd, DispatchResult & dr)
                        break;
                }
 
+               case LFUN_BUFFER_EXPORT_AS:
+                       LASSERT(doc_buffer, break);
+                       exportBufferAs(*doc_buffer);
+                       break;
+
                case LFUN_BUFFER_UPDATE: {
                        d.asyncBufferProcessing(argument,
                                                doc_buffer,
@@ -3522,14 +3620,16 @@ void GuiView::dispatch(FuncRequest const & cmd, DispatchResult & dr)
                                        addExtension(mastername, "dvi")));
                        FileName const pdfname(addName(path.absFileName(),
                                        addExtension(mastername, "pdf")));
-                       if (!dviname.exists() && !pdfname.exists()) {
+                       bool const have_dvi = dviname.exists();
+                       bool const have_pdf = pdfname.exists();
+                       if (!have_dvi && !have_pdf) {
                                dr.setMessage(_("Please, preview the document first."));
                                break;
                        }
                        string outname = dviname.onlyFileName();
                        string command = lyxrc.forward_search_dvi;
-                       if (!dviname.exists() ||
-                           pdfname.lastModified() > dviname.lastModified()) {
+                       if (!have_dvi || (have_pdf &&
+                           pdfname.lastModified() > dviname.lastModified())) {
                                outname = pdfname.onlyFileName();
                                command = lyxrc.forward_search_pdf;
                        }