]> git.lyx.org Git - lyx.git/blobdiff - src/frontends/qt4/GuiView.cpp
Complete the removal of the embedding stuff. Maybe. It's hard to be sure we got every...
[lyx.git] / src / frontends / qt4 / GuiView.cpp
index f003951cf322e2eacacf6a9d01b0ce64b4f55ead..2ff88433a7735ba35144079ed8067238fc1b6f60 100644 (file)
 #include "BufferView.h"
 #include "Converter.h"
 #include "Cursor.h"
+#include "Encoding.h"
 #include "ErrorList.h"
 #include "Format.h"
+#include "FuncStatus.h"
 #include "FuncRequest.h"
-#include "support/gettext.h"
 #include "Intl.h"
 #include "Layout.h"
 #include "Lexer.h"
 #include "ToolbarBackend.h"
 #include "version.h"
 
+#include "support/assert.h"
 #include "support/debug.h"
 #include "support/FileFilterList.h"
 #include "support/FileName.h"
 #include "support/filetools.h"
+#include "support/gettext.h"
 #include "support/ForkedCalls.h"
 #include "support/lstrings.h"
 #include "support/os.h"
@@ -86,7 +89,6 @@
 #include <QUrl>
 #include <QScrollBar>
 
-#include <boost/assert.hpp>
 #include <boost/bind.hpp>
 
 #ifdef HAVE_SYS_TIME_H
@@ -111,18 +113,19 @@ public:
        {
                LYXERR(Debug::GUI, "show banner: " << lyxrc.show_banner);
                /// The text to be written on top of the pixmap
-               QString const text = lyx_version ? lyx_version : qt_("unknown version");
+               QString const text = lyx_version ?
+                       qt_("version ") + lyx_version : qt_("unknown version");
                splash_ = QPixmap(":/images/banner.png");
 
                QPainter pain(&splash_);
-               pain.setPen(QColor(255, 255, 0));
+               pain.setPen(QColor(0, 0, 0));
                QFont font;
                // The font used to display the version info
                font.setStyleHint(QFont::SansSerif);
                font.setWeight(QFont::Bold);
                font.setPointSize(int(toqstr(lyxrc.font_sizes[FONT_SIZE_LARGE]).toDouble()));
                pain.setFont(font);
-               pain.drawText(260, 270, text);
+               pain.drawText(190, 225, text);
        }
 
        void paintEvent(QPaintEvent *)
@@ -276,8 +279,13 @@ GuiView::GuiView(int id)
        // GuiToolbars *must* be initialised before the menu bar.
        d.toolbars_ = new GuiToolbars(*this);
 
+       // set ourself as the current view. This is needed for the menu bar
+       // filling, at least for the static special menu item on Mac. Otherwise
+       // they are greyed out.
+       theLyXFunc().setLyXView(this);
+       
        // Fill up the menu bar.
-       guiApp->menus().fillMenuBar(this);
+       guiApp->menus().fillMenuBar(menuBar(), this, true);
 
        setCentralWidget(d.stack_widget_);
 
@@ -293,8 +301,8 @@ GuiView::GuiView(int id)
        // We don't want to keep the window in memory if it is closed.
        setAttribute(Qt::WA_DeleteOnClose, true);
 
-#ifndef Q_WS_MACX
-       // assign an icon to main form. We do not do it under Qt/Mac,
+#if (!defined(Q_WS_WIN) && !defined(Q_WS_MACX))
+       // assign an icon to main form. We do not do it under Qt/Win or Qt/Mac,
        // since the icon is provided in the application bundle.
        setWindowIcon(QPixmap(":/images/lyx.png"));
 #endif
@@ -330,6 +338,10 @@ GuiView::GuiView(int id)
 
 GuiView::~GuiView()
 {
+       if (guiApp->currentView() == this)
+               guiApp->setCurrentView(0);
+       theLyXFunc().setLyXView(0);
+       
        delete &d;
 }
 
@@ -365,6 +377,10 @@ void GuiView::showEvent(QShowEvent * e)
 
 void GuiView::closeEvent(QCloseEvent * close_event)
 {
+       // it can happen that this event arrives without selecting the view,
+       // e.g. when clicking the close button on a background window.
+       theLyXFunc().setLyXView(this);
+
        while (Buffer * b = buffer()) {
                if (b->parent()) {
                        // This is a child document, just close the tab after saving
@@ -378,7 +394,7 @@ void GuiView::closeEvent(QCloseEvent * close_event)
                }
 
                std::vector<int> const & ids = guiApp->viewIds();
-               for (int i = 0; i != ids.size(); ++i) {
+               for (size_type i = 0; i != ids.size(); ++i) {
                        if (id_ == ids[i])
                                continue;
                        if (guiApp->view(ids[i]).workArea(*b)) {
@@ -406,8 +422,8 @@ void GuiView::closeEvent(QCloseEvent * close_event)
 
        // Save toolbars configuration
        if (isFullScreen()) {
-        d.toolbars_->toggleFullScreen(!isFullScreen());
-        updateToolbars();
+               d.toolbars_->toggleFullScreen(!isFullScreen());
+               updateToolbars();
        }
 
        // Make sure the timer time out will not trigger a statusbar update.
@@ -533,6 +549,22 @@ void GuiView::on_currentWorkAreaChanged(GuiWorkArea * wa)
 }
 
 
+void GuiView::on_lastWorkAreaRemoved()
+{
+#ifdef Q_WS_MACX
+       // On Mac close the view if there is no Tab open anymore,
+       // but only if no splitter is visible
+       if (!lyxrc.open_buffers_in_tabs && d.splitter_->count() == 1) {
+               TabWorkArea * twa = qobject_cast<TabWorkArea *>(d.splitter_->widget(0));
+               if (twa && twa->count() == 0) {
+                       // close the view, as no tab is open anymore
+                       QTimer::singleShot(0, this, SLOT(close()));
+               }
+       }
+#endif
+}
+
+
 void GuiView::updateStatusBar()
 {
        // let the user see the explicit message
@@ -570,7 +602,11 @@ bool GuiView::event(QEvent * e)
        //      break;
 
        case QEvent::WindowActivate: {
-               guiApp->setCurrentView(*this);
+               if (this == guiApp->currentView()) {
+                       setFocus();
+                       return QMainWindow::event(e);
+               }
+               guiApp->setCurrentView(this);
                if (d.current_work_area_) {
                        BufferView & bv = d.current_work_area_->bufferView();
                        connectBufferView(bv);
@@ -711,6 +747,9 @@ TabWorkArea * GuiView::addTabWorkArea()
        TabWorkArea * twa = new TabWorkArea;
        QObject::connect(twa, SIGNAL(currentWorkAreaChanged(GuiWorkArea *)),
                this, SLOT(on_currentWorkAreaChanged(GuiWorkArea *)));
+       QObject::connect(twa, SIGNAL(lastWorkAreaRemoved()),
+                        this, SLOT(on_lastWorkAreaRemoved()));
+
        d.splitter_->addWidget(twa);
        d.stack_widget_->setCurrentWidget(d.splitter_);
        return twa;
@@ -725,7 +764,7 @@ GuiWorkArea const * GuiView::currentWorkArea() const
 
 void GuiView::setCurrentWorkArea(GuiWorkArea * wa)
 {
-       BOOST_ASSERT(wa);
+       LASSERT(wa, /**/);
 
        // Changing work area can result from opening a file so
        // update the toc in any case.
@@ -741,7 +780,7 @@ void GuiView::setCurrentWorkArea(GuiWorkArea * wa)
 
 void GuiView::removeWorkArea(GuiWorkArea * wa)
 {
-       BOOST_ASSERT(wa);
+       LASSERT(wa, /**/);
        if (wa == d.current_work_area_) {
                disconnectBuffer();
                disconnectBufferView();
@@ -830,7 +869,7 @@ Buffer const * GuiView::buffer() const
 
 void GuiView::setBuffer(Buffer * newBuffer)
 {
-       BOOST_ASSERT(newBuffer);
+       LASSERT(newBuffer, /**/);
        setBusy(true);
 
        GuiWorkArea * wa = workArea(*newBuffer);
@@ -910,12 +949,6 @@ void GuiView::updateToc()
 }
 
 
-void GuiView::updateEmbeddedFiles()
-{
-       updateDialog("embedding", "");
-}
-
-
 void GuiView::autoSave()
 {
        LYXERR(Debug::INFO, "Running autoSave()");
@@ -970,6 +1003,10 @@ FuncStatus GuiView::getStatus(FuncRequest const & cmd)
                flag.setOnOff(d.toolbars_->visible(cmd.getArg(0)));
                break;
 
+       case LFUN_UI_TOGGLE:
+               flag.setOnOff(isFullScreen());
+               break;
+
        case LFUN_DIALOG_TOGGLE:
                flag.setOnOff(isDialogVisible(cmd.getArg(0)));
                // fall through to set "enable"
@@ -1031,7 +1068,7 @@ FuncStatus GuiView::getStatus(FuncRequest const & cmd)
                        FuncStatus fs;
                        if (!inset->getStatus(view()->cursor(), fr, fs)) {
                                // Every inset is supposed to handle this
-                               BOOST_ASSERT(false);
+                               LASSERT(false, /**/);
                        }
                        flag |= fs;
                } else {
@@ -1076,20 +1113,19 @@ FuncStatus GuiView::getStatus(FuncRequest const & cmd)
 
 static FileName selectTemplateFile()
 {
-       FileDialog dlg(_("Select template file"));
-       dlg.setButton1(_("Documents|#o#O"), from_utf8(lyxrc.document_path));
-       dlg.setButton1(_("Templates|#T#t"), from_utf8(lyxrc.template_path));
+       FileDialog dlg(qt_("Select template file"));
+       dlg.setButton1(qt_("Documents|#o#O"), toqstr(lyxrc.document_path));
+       dlg.setButton1(qt_("Templates|#T#t"), toqstr(lyxrc.template_path));
 
        FileDialog::Result result =
-               dlg.open(from_utf8(lyxrc.template_path),
-                            FileFilterList(_("LyX Documents (*.lyx)")),
-                            docstring());
+               dlg.open(toqstr(lyxrc.template_path),
+                            FileFilterList(_("LyX Documents (*.lyx)")));
 
        if (result.first == FileDialog::Later)
                return FileName();
-       if (result.second.empty())
+       if (result.second.isEmpty())
                return FileName();
-       return FileName(to_utf8(result.second));
+       return FileName(fromqstr(result.second));
 }
 
 
@@ -1104,7 +1140,7 @@ Buffer * GuiView::loadDocument(FileName const & filename, bool tolastfiles)
                setBusy(false);
                return 0;
        }
-
+       
        setBuffer(newBuffer);
 
        // scroll to the position when the file was last closed
@@ -1136,20 +1172,18 @@ void GuiView::openDocument(string const & fname)
        string filename;
 
        if (fname.empty()) {
-               FileDialog dlg(_("Select document to open"), LFUN_FILE_OPEN);
-               dlg.setButton1(_("Documents|#o#O"), from_utf8(lyxrc.document_path));
-               dlg.setButton2(_("Examples|#E#e"),
-                               from_utf8(addPath(package().system_support().absFilename(), "examples")));
+               FileDialog dlg(qt_("Select document to open"), LFUN_FILE_OPEN);
+               dlg.setButton1(qt_("Documents|#o#O"), toqstr(lyxrc.document_path));
+               dlg.setButton2(qt_("Examples|#E#e"),
+                               toqstr(addPath(package().system_support().absFilename(), "examples")));
 
                FileDialog::Result result =
-                       dlg.open(from_utf8(initpath),
-                                    FileFilterList(_("LyX Documents (*.lyx)")),
-                                    docstring());
+                       dlg.open(toqstr(initpath), FileFilterList(_("LyX Documents (*.lyx)")));
 
                if (result.first == FileDialog::Later)
                        return;
 
-               filename = to_utf8(result.second);
+               filename = fromqstr(result.second);
 
                // check selected filename
                if (filename.empty()) {
@@ -1182,6 +1216,7 @@ void GuiView::openDocument(string const & fname)
        Buffer * buf = loadDocument(fullname);
        if (buf) {
                updateLabels(*buf);
+               
                setBuffer(buf);
                buf->errors("Parse");
                str2 = bformat(_("Document %1$s opened."), disp_fn);
@@ -1195,7 +1230,7 @@ void GuiView::openDocument(string const & fname)
 static bool import(GuiView * lv, FileName const & filename,
        string const & format, ErrorList & errorList)
 {
-       FileName const lyxfile(changeExtension(filename.absFilename(), ".lyx"));
+       FileName const lyxfile(support::changeExtension(filename.absFilename(), ".lyx"));
 
        string loader_format;
        vector<string> loaders = theConverters().loaders();
@@ -1206,7 +1241,7 @@ static bool import(GuiView * lv, FileName const & filename,
                                continue;
 
                        string const tofile =
-                               changeExtension(filename.absFilename(),
+                               support::changeExtension(filename.absFilename(),
                                formats.extension(*it));
                        if (!theConverters().convert(0, filename, FileName(tofile),
                                filename, format, *it, errorList))
@@ -1237,7 +1272,7 @@ static bool import(GuiView * lv, FileName const & filename,
                lv->setBuffer(b);
                bool as_paragraphs = loader_format == "textparagraph";
                string filename2 = (loader_format == format) ? filename.absFilename()
-                       : changeExtension(filename.absFilename(),
+                       : support::changeExtension(filename.absFilename(),
                                          formats.extension(loader_format));
                lv->view()->insertPlaintextFile(FileName(filename2), as_paragraphs);
                theLyXFunc().setLyXView(lv);
@@ -1270,10 +1305,10 @@ void GuiView::importDocument(string const & argument)
                docstring const text = bformat(_("Select %1$s file to import"),
                        formats.prettyName(format));
 
-               FileDialog dlg(text, LFUN_BUFFER_IMPORT);
-               dlg.setButton1(_("Documents|#o#O"), from_utf8(lyxrc.document_path));
-               dlg.setButton2(_("Examples|#E#e"),
-                       from_utf8(addPath(package().system_support().absFilename(), "examples")));
+               FileDialog dlg(toqstr(text), LFUN_BUFFER_IMPORT);
+               dlg.setButton1(qt_("Documents|#o#O"), toqstr(lyxrc.document_path));
+               dlg.setButton2(qt_("Examples|#E#e"),
+                       toqstr(addPath(package().system_support().absFilename(), "examples")));
 
                docstring filter = formats.prettyName(format);
                filter += " (*.";
@@ -1282,14 +1317,12 @@ void GuiView::importDocument(string const & argument)
                filter += ')';
 
                FileDialog::Result result =
-                       dlg.open(from_utf8(initpath),
-                                    FileFilterList(filter),
-                                    docstring());
+                       dlg.open(toqstr(initpath), FileFilterList(filter));
 
                if (result.first == FileDialog::Later)
                        return;
 
-               filename = to_utf8(result.second);
+               filename = fromqstr(result.second);
 
                // check selected filename
                if (filename.empty())
@@ -1302,7 +1335,7 @@ void GuiView::importDocument(string const & argument)
        // get absolute path of file
        FileName const fullname(makeAbsPath(filename));
 
-       FileName const lyxfile(changeExtension(fullname.absFilename(), ".lyx"));
+       FileName const lyxfile(support::changeExtension(fullname.absFilename(), ".lyx"));
 
        // Check if the document already is open
        Buffer * buf = theBufferList().getBuffer(lyxfile.absFilename());
@@ -1391,22 +1424,21 @@ void GuiView::insertLyXFile(docstring const & fname)
                initpath = trypath;
 
        // FIXME UNICODE
-       FileDialog dlg(_("Select LyX document to insert"), LFUN_FILE_INSERT);
-       dlg.setButton1(_("Documents|#o#O"), from_utf8(lyxrc.document_path));
-       dlg.setButton2(_("Examples|#E#e"),
-               from_utf8(addPath(package().system_support().absFilename(),
+       FileDialog dlg(qt_("Select LyX document to insert"), LFUN_FILE_INSERT);
+       dlg.setButton1(qt_("Documents|#o#O"), toqstr(lyxrc.document_path));
+       dlg.setButton2(qt_("Examples|#E#e"),
+               toqstr(addPath(package().system_support().absFilename(),
                "examples")));
 
        FileDialog::Result result =
-               dlg.open(from_utf8(initpath),
-                            FileFilterList(_("LyX Documents (*.lyx)")),
-                            docstring());
+               dlg.open(toqstr(initpath),
+                            FileFilterList(_("LyX Documents (*.lyx)")));
 
        if (result.first == FileDialog::Later)
                return;
 
        // FIXME UNICODE
-       filename.set(to_utf8(result.second));
+       filename.set(fromqstr(result.second));
 
        // check selected filename
        if (filename.empty()) {
@@ -1434,17 +1466,17 @@ void GuiView::insertPlaintextFile(docstring const & fname,
                return;
        }
 
-       FileDialog dlg(_("Select file to insert"), (asParagraph ?
+       FileDialog dlg(qt_("Select file to insert"), (asParagraph ?
                LFUN_FILE_INSERT_PLAINTEXT_PARA : LFUN_FILE_INSERT_PLAINTEXT));
 
-       FileDialog::Result result = dlg.open(from_utf8(bv->buffer().filePath()),
-               FileFilterList(), docstring());
+       FileDialog::Result result = dlg.open(toqstr(bv->buffer().filePath()),
+               FileFilterList());
 
        if (result.first == FileDialog::Later)
                return;
 
        // FIXME UNICODE
-       filename.set(to_utf8(result.second));
+       filename.set(fromqstr(result.second));
 
        // check selected filename
        if (filename.empty()) {
@@ -1471,10 +1503,10 @@ bool GuiView::renameBuffer(Buffer & b, docstring const & newname)
 
                /// No argument? Ask user through dialog.
                // FIXME UNICODE
-               FileDialog dlg(_("Choose a filename to save document as"),
+               FileDialog dlg(qt_("Choose a filename to save document as"),
                                   LFUN_BUFFER_WRITE_AS);
-               dlg.setButton1(_("Documents|#o#O"), from_utf8(lyxrc.document_path));
-               dlg.setButton2(_("Templates|#T#t"), from_utf8(lyxrc.template_path));
+               dlg.setButton1(qt_("Documents|#o#O"), toqstr(lyxrc.document_path));
+               dlg.setButton2(qt_("Templates|#T#t"), toqstr(lyxrc.template_path));
 
                if (!isLyXFilename(fname.absFilename()))
                        fname.changeExtension(".lyx");
@@ -1482,14 +1514,14 @@ bool GuiView::renameBuffer(Buffer & b, docstring const & newname)
                FileFilterList const filter(_("LyX Documents (*.lyx)"));
 
                FileDialog::Result result =
-                       dlg.save(from_utf8(fname.onlyPath().absFilename()),
+                       dlg.save(toqstr(fname.onlyPath().absFilename()),
                                     filter,
-                                    from_utf8(fname.onlyFileName()));
+                                    toqstr(fname.onlyFileName()));
 
                if (result.first == FileDialog::Later)
                        return false;
 
-               fname.set(to_utf8(result.second));
+               fname.set(fromqstr(result.second));
 
                if (fname.empty())
                        return false;
@@ -1581,6 +1613,8 @@ bool GuiView::closeBuffer(Buffer & buf)
                theLyXFunc().gotoBookmark(i+1, false, false);
 
        if (buf.isClean() || buf.paragraphs().empty()) {
+               if (buf.masterBuffer() == &buf)
+                       LyX::ref().session().lastOpened().add(buf.fileName());
                theBufferList().release(&buf);
                return true;
        }
@@ -1637,10 +1671,6 @@ bool GuiView::dispatch(FuncRequest const & cmd)
                bv->cursor().updateFlags(Update::None);
 
        switch(cmd.action) {
-               case LFUN_FILE_OPEN:
-                       openDocument(to_utf8(cmd.argument()));
-                       break;
-
                case LFUN_BUFFER_IMPORT:
                        importDocument(to_utf8(cmd.argument()));
                        break;
@@ -1668,7 +1698,7 @@ bool GuiView::dispatch(FuncRequest const & cmd)
                        break;
 
                case LFUN_MENU_OPEN:
-                       if (QMenu * menu = guiApp->menus().menu(toqstr(cmd.argument())))
+                       if (QMenu * menu = guiApp->menus().menu(toqstr(cmd.argument()), *this))
                                menu->exec(QCursor::pos());
                        break;
 
@@ -1701,10 +1731,10 @@ bool GuiView::dispatch(FuncRequest const & cmd)
                        // We cannot use a for loop as the buffer list cycles.
                        Buffer * b = first;
                        do {
-                               if (b->isClean())
-                                       continue;
-                               saveBuffer(*b);
-                               LYXERR(Debug::ACTION, "Saved " << b->absFileName());
+                               if (!b->isClean()) {
+                                       saveBuffer(*b);
+                                       LYXERR(Debug::ACTION, "Saved " << b->absFileName());
+                               }
                                b = theBufferList().next(b);
                        } while (b != first); 
                        message(_("All documents saved."));
@@ -1902,18 +1932,17 @@ void GuiView::lfunUiToggle(FuncRequest const & cmd)
                int l, t, r, b;
                getContentsMargins(&l, &t, &r, &b);
                //are the frames in default state?
+               d.current_work_area_->setFrameStyle(QFrame::NoFrame);
                if (l == 0) {
-                       d.current_work_area_->setFrameStyle(QFrame::NoFrame);
                        setContentsMargins(-2, -2, -2, -2);
                } else {
-                       d.current_work_area_->setFrameStyle(QFrame::NoFrame);
                        setContentsMargins(0, 0, 0, 0);
                }
                return;
        }
 #endif
        if (arg != "fullscreen") {
-               message(bformat(_("LFUN_UI_TOGGLE %1$s unknown command!"), from_utf8(arg)));
+               message(bformat("LFUN_UI_TOGGLE " + _("%1$s unknown command!"), from_utf8(arg)));
                return;
        }
 
@@ -1926,7 +1955,7 @@ void GuiView::lfunUiToggle(FuncRequest const & cmd)
 #if QT_VERSION >= 0x040300
                setContentsMargins(0, 0, 0, 0);
 #endif
-               showNormal();
+               setWindowState(windowState() ^ Qt::WindowFullScreen);
                menuBar()->show();
                statusBar()->show();
        } else {
@@ -1935,7 +1964,7 @@ void GuiView::lfunUiToggle(FuncRequest const & cmd)
 #if QT_VERSION >= 0x040300
                setContentsMargins(-2, -2, -2, -2);
 #endif
-               showFullScreen();
+               setWindowState(windowState() ^ Qt::WindowFullScreen);
                statusBar()->hide();
                menuBar()->hide();
        }
@@ -1969,10 +1998,10 @@ void GuiView::restartCursor()
 }
 
 
-void GuiView::updateCompletion(bool start, bool keep)
+void GuiView::updateCompletion(Cursor & cur, bool start, bool keep)
 {
        if (d.current_work_area_)
-               d.current_work_area_->completer().updateVisibility(start, keep);
+               d.current_work_area_->completer().updateVisibility(cur, start, keep);
 }
 
 namespace {
@@ -1983,10 +2012,10 @@ namespace {
 
 char const * const dialognames[] = {
 "aboutlyx", "bibitem", "bibtex", "box", "branch", "changes", "character",
-"citation", "document", "embedding", "errorlist", "ert", "external", "file",
+"citation", "document", "errorlist", "ert", "external", "file",
 "findreplace", "float", "graphics", "include", "index", "nomenclature", "label", "log",
 "mathdelimiter", "mathmatrix", "note", "paragraph", "prefs", "print", 
-"ref", "sendto", "spellchecker", "symbols", "tabular", "tabularcreate",
+"ref", "sendto", "space", "spellchecker", "symbols", "tabular", "tabularcreate",
 
 #ifdef HAVE_LIBAIKSAURUS
 "thesaurus",
@@ -2024,7 +2053,7 @@ void GuiView::resetDialogs()
        // FIXME: the "math panels" toolbar takes an awful lot of time to
        // initialise so we don't do that for the time being.
        //d.toolbars_->init();
-       guiApp->menus().fillMenuBar(this);
+       guiApp->menus().fillMenuBar(menuBar(), this);
        if (d.layout_)
                d.layout_->updateContents(true);
        // Now update controls with current buffer.
@@ -2190,6 +2219,7 @@ Dialog * createGuiERT(GuiView & lv);
 Dialog * createGuiExternal(GuiView & lv);
 Dialog * createGuiFloat(GuiView & lv);
 Dialog * createGuiGraphics(GuiView & lv);
+Dialog * createGuiHSpace(GuiView & lv);
 Dialog * createGuiInclude(GuiView & lv);
 Dialog * createGuiLabel(GuiView & lv);
 Dialog * createGuiListings(GuiView & lv);
@@ -2219,7 +2249,7 @@ Dialog * createGuiWrap(GuiView & lv);
 
 Dialog * GuiView::build(string const & name)
 {
-       BOOST_ASSERT(isValidName(name));
+       LASSERT(isValidName(name), /**/);
 
        if (name == "aboutlyx")
                return createGuiAbout(*this);
@@ -2279,6 +2309,8 @@ Dialog * GuiView::build(string const & name)
                return createGuiRef(*this);
        if (name == "sendto")
                return createGuiSendTo(*this);
+       if (name == "space")
+               return createGuiHSpace(*this);
        if (name == "spellchecker")
                return createGuiSpellchecker(*this);
        if (name == "symbols")