]> git.lyx.org Git - lyx.git/blobdiff - src/frontends/qt4/GuiView.cpp
The Cursor argument here was not being used, so there is no need
[lyx.git] / src / frontends / qt4 / GuiView.cpp
index 755e4b8adfafc50b385e526f90e36944484916f7..24098230088e36fbfb7a36426ee8f9f68065522f 100644 (file)
@@ -331,7 +331,7 @@ struct GuiView::GuiViewPrivate
        }
 
 #if (QT_VERSION >= 0x040400)
-       void setPreviewFuture(QFuture<docstring> const & f)
+       void setPreviewFuture(QFuture<Buffer::ExportStatus> const & f)
        {
                if (processing_thread_watcher_.isRunning()) {
                        // we prefer to cancel this preview in order to keep a snappy
@@ -382,30 +382,31 @@ public:
 #if (QT_VERSION >= 0x040400)
        ///
        QFutureWatcher<docstring> autosave_watcher_;
-       QFutureWatcher<docstring> processing_thread_watcher_;
+       QFutureWatcher<Buffer::ExportStatus> processing_thread_watcher_;
        ///
        string last_export_format;
+       string processing_format;
 #else
        struct DummyWatcher { bool isRunning(){return false;} };
        DummyWatcher processing_thread_watcher_;
 #endif
 
        static QSet<Buffer const *> busyBuffers;
-       static docstring previewAndDestroy(Buffer const * orig, Buffer * buffer, string const & format);
-       static docstring exportAndDestroy(Buffer const * orig, Buffer * buffer, string const & format);
-       static docstring compileAndDestroy(Buffer const * orig, Buffer * buffer, string const & format);
+       static Buffer::ExportStatus previewAndDestroy(Buffer const * orig, Buffer * buffer, string const & format);
+       static Buffer::ExportStatus exportAndDestroy(Buffer const * orig, Buffer * buffer, string const & format);
+       static Buffer::ExportStatus compileAndDestroy(Buffer const * orig, Buffer * buffer, string const & format);
        static docstring autosaveAndDestroy(Buffer const * orig, Buffer * buffer);
 
        template<class T>
-       static docstring runAndDestroy(const T& func, Buffer const * orig, Buffer * buffer, string const & format, string const & msg);
+       static Buffer::ExportStatus runAndDestroy(const T& func, Buffer const * orig, Buffer * buffer, string const & format);
 
        // TODO syncFunc/previewFunc: use bind
        bool asyncBufferProcessing(string const & argument,
                                   Buffer const * used_buffer,
                                   docstring const & msg,
-                                  docstring (*asyncFunc)(Buffer const *, Buffer *, string const &),
-                                  bool (Buffer::*syncFunc)(string const &, bool, bool) const,
-                                  bool (Buffer::*previewFunc)(string const &, bool) const);
+                                  Buffer::ExportStatus (*asyncFunc)(Buffer const *, Buffer *, string const &),
+                                  Buffer::ExportStatus (Buffer::*syncFunc)(string const &, bool) const,
+                                  Buffer::ExportStatus (Buffer::*previewFunc)(string const &) const);
 
        QVector<GuiWorkArea*> guiWorkAreas();
 };
@@ -527,55 +528,75 @@ QVector<GuiWorkArea*> GuiView::GuiViewPrivate::guiWorkAreas()
        return areas;
 }
 
-
-#if QT_VERSION >= 0x040400
-
-void GuiView::processingThreadStarted()
+static void handleExportStatus(GuiView * view, Buffer::ExportStatus status,
+       string const & format)
 {
+       docstring const fmt = formats.prettyName(format);
+       docstring msg;
+       switch (status) {
+       case Buffer::ExportSuccess:
+               msg = bformat(_("Successful export to format: %1$s"), fmt);
+               break;
+       case Buffer::ExportCancel:
+               msg = _("Document export cancelled.");
+               break;
+       case Buffer::ExportError:
+       case Buffer::ExportNoPathToFormat:
+       case Buffer::ExportTexPathHasSpaces:
+       case Buffer::ExportConverterError:
+               msg = bformat(_("Error while exporting format: %1$s"), fmt);
+               break;
+       case Buffer::PreviewSuccess:
+               msg = bformat(_("Successful preview of format: %1$s"), fmt);
+               break;
+       case Buffer::PreviewError:
+               msg = bformat(_("Error while previewing format: %1$s"), fmt);
+               break;
+       }
+       view->message(msg);
 }
 
 
-void GuiView::processingThreadFinished(bool show_errors)
+#if QT_VERSION >= 0x040400
+
+void GuiView::processingThreadStarted()
 {
-       QFutureWatcher<docstring> const * watcher =
-               static_cast<QFutureWatcher<docstring> const *>(sender());
-       message(watcher->result());
-       updateToolbars();
-       if (show_errors) {
-               BufferView const * const bv = currentBufferView();
-               if (bv && !bv->buffer().errorList("Export").empty()) {
-                       errors("Export");
-                       return;
-               }
-               errors(d.last_export_format);
-       }
 }
 
 
 void GuiView::processingThreadFinished()
 {
-       processingThreadFinished(true);
+       QFutureWatcher<Buffer::ExportStatus> const * watcher =
+               static_cast<QFutureWatcher<Buffer::ExportStatus> const *>(sender());
+
+       Buffer::ExportStatus const status = watcher->result();
+       handleExportStatus(this, status, d.processing_format);
+       
+       updateToolbars();
+       BufferView const * const bv = currentBufferView();
+       if (bv && !bv->buffer().errorList("Export").empty()) {
+               errors("Export");
+               return;
+       }
+       errors(d.last_export_format);
 }
 
 
 void GuiView::autoSaveThreadFinished()
 {
-       processingThreadFinished(false);
+       QFutureWatcher<docstring> const * watcher =
+               static_cast<QFutureWatcher<docstring> const *>(sender());
+       message(watcher->result());
+       updateToolbars();
 }
 
 #else
 
-
 void GuiView::processingThreadStarted()
 {
 }
 
 
-void GuiView::processingThreadFinished(bool)
-{
-}
-
-
 void GuiView::processingThreadFinished()
 {
 }
@@ -994,6 +1015,8 @@ void GuiView::updateWindowTitle(GuiWorkArea * wa)
 
 void GuiView::on_currentWorkAreaChanged(GuiWorkArea * wa)
 {
+       QObject::disconnect(d.current_work_area_, SIGNAL(busy(bool)),
+               this, SLOT(setBusy(bool)));
        disconnectBuffer();
        disconnectBufferView();
        connectBufferView(wa->bufferView());
@@ -1001,6 +1024,7 @@ void GuiView::on_currentWorkAreaChanged(GuiWorkArea * wa)
        d.current_work_area_ = wa;
        QObject::connect(wa, SIGNAL(titleChanged(GuiWorkArea *)),
                this, SLOT(updateWindowTitle(GuiWorkArea *)));
+       QObject::connect(wa, SIGNAL(busy(bool)), this, SLOT(setBusy(bool)));
        updateWindowTitle(wa);
 
        structureChanged();
@@ -1173,20 +1197,12 @@ void GuiView::setBusy(bool busy)
                // busy state didn't change
                return;
 
-       if (d.current_work_area_) {
-               //Why would we want to stop updates only for one workarea and
-               //not for the others ? This leads to problems as in #7314 (vfr).
-               //d.current_work_area_->setUpdatesEnabled(!busy);
-               if (busy)
-                       d.current_work_area_->stopBlinkingCursor();
-               else
-                       d.current_work_area_->startBlinkingCursor();
-       }
-
-       if (busy)
+       if (busy) {
                QApplication::setOverrideCursor(Qt::WaitCursor);
-       else
-               QApplication::restoreOverrideCursor();
+               return;
+       }
+       QApplication::restoreOverrideCursor();
+       updateLayoutList();     
 }
 
 
@@ -1533,10 +1549,10 @@ BufferView const * GuiView::currentBufferView() const
 
 #if (QT_VERSION >= 0x040400)
 docstring GuiView::GuiViewPrivate::autosaveAndDestroy(
-       Buffer const * orig, Buffer * buffer)
+       Buffer const * orig, Buffer * clone)
 {
-       bool const success = buffer->autoSave();
-       delete buffer;
+       bool const success = clone->autoSave();
+       delete clone;
        busyBuffers.remove(orig);
        return success
                ? _("Automatic save done.")
@@ -3022,71 +3038,61 @@ bool GuiView::goToFileRow(string const & argument)
 
 #if (QT_VERSION >= 0x040400)
 template<class T>
-docstring GuiView::GuiViewPrivate::runAndDestroy(const T& func, Buffer const * orig, Buffer * buffer, string const & format, string const & msg)
+Buffer::ExportStatus GuiView::GuiViewPrivate::runAndDestroy(const T& func, Buffer const * orig, Buffer * clone, string const & format)
 {
-       bool const update_unincluded =
-                               buffer->params().maintain_unincluded_children
-                               && !buffer->params().getIncludedChildren().empty();
-       bool const success = func(format, update_unincluded);
+       Buffer::ExportStatus const status = func(format);
 
        // the cloning operation will have produced a clone of the entire set of
        // documents, starting from the master. so we must delete those.
-       Buffer * mbuf = const_cast<Buffer *>(buffer->masterBuffer());
+       Buffer * mbuf = const_cast<Buffer *>(clone->masterBuffer());
        delete mbuf;
        busyBuffers.remove(orig);
-       if (msg == "preview") {
-               return success
-                       ? bformat(_("Successful preview of format: %1$s"), from_utf8(format))
-                       : bformat(_("Error while previewing format: %1$s"), from_utf8(format));
-       }
-       return success
-               ? bformat(_("Successful export to format: %1$s"), from_utf8(format))
-               : bformat(_("Error while exporting format: %1$s"), from_utf8(format));
+       return status;
 }
 
 
-docstring GuiView::GuiViewPrivate::compileAndDestroy(Buffer const * orig, Buffer * buffer, string const & format)
+Buffer::ExportStatus GuiView::GuiViewPrivate::compileAndDestroy(Buffer const * orig, Buffer * clone, string const & format)
 {
-       bool (Buffer::* mem_func)(std::string const &, bool, bool) const = &Buffer::doExport;
-       return runAndDestroy(bind(mem_func, buffer, _1, true, _2), orig, buffer, format, "export");
+       Buffer::ExportStatus (Buffer::* mem_func)(std::string const &, bool) const = &Buffer::doExport;
+       return runAndDestroy(bind(mem_func, clone, _1, true), orig, clone, format);
 }
 
 
-docstring GuiView::GuiViewPrivate::exportAndDestroy(Buffer const * orig, Buffer * buffer, string const & format)
+Buffer::ExportStatus GuiView::GuiViewPrivate::exportAndDestroy(Buffer const * orig, Buffer * clone, string const & format)
 {
-       bool (Buffer::* mem_func)(std::string const &, bool, bool) const = &Buffer::doExport;
-       return runAndDestroy(bind(mem_func, buffer, _1, false, _2), orig, buffer, format, "export");
+       Buffer::ExportStatus (Buffer::* mem_func)(std::string const &, bool) const = &Buffer::doExport;
+       return runAndDestroy(bind(mem_func, clone, _1, false), orig, clone, format);
 }
 
 
-docstring GuiView::GuiViewPrivate::previewAndDestroy(Buffer const * orig, Buffer * buffer, string const & format)
+Buffer::ExportStatus GuiView::GuiViewPrivate::previewAndDestroy(Buffer const * orig, Buffer * clone, string const & format)
 {
-       bool(Buffer::* mem_func)(std::string const &, bool) const = &Buffer::preview;
-       return runAndDestroy(bind(mem_func, buffer, _1, _2), orig, buffer, format, "preview");
+       Buffer::ExportStatus (Buffer::* mem_func)(std::string const &) const = &Buffer::preview;
+       return runAndDestroy(bind(mem_func, clone, _1), orig, clone, format);
 }
 
 #else
 
 // not used, but the linker needs them
 
-docstring GuiView::GuiViewPrivate::compileAndDestroy(
+Buffer::ExportStatus GuiView::GuiViewPrivate::compileAndDestroy(
                Buffer const *, Buffer *, string const &)
 {
-       return docstring();
+       return Buffer::ExportSuccess;
 }
 
 
-docstring GuiView::GuiViewPrivate::exportAndDestroy(
+Buffer::ExportStatus GuiView::GuiViewPrivate::exportAndDestroy(
                Buffer const *, Buffer *, string const &)
 {
-       return docstring();
+       return Buffer::ExportSuccess;
 }
 
 
-docstring GuiView::GuiViewPrivate::previewAndDestroy(
+Buffer::ExportStatus GuiView::GuiViewPrivate::previewAndDestroy(
                Buffer const *, Buffer *, string const &)
 {
-       return docstring();
+       return Buffer::ExportSuccess;
 }
 
 #endif
@@ -3096,9 +3102,9 @@ bool GuiView::GuiViewPrivate::asyncBufferProcessing(
                           string const & argument,
                           Buffer const * used_buffer,
                           docstring const & msg,
-                          docstring (*asyncFunc)(Buffer const *, Buffer *, string const &),
-                          bool (Buffer::*syncFunc)(string const &, bool, bool) const,
-                          bool (Buffer::*previewFunc)(string const &, bool) const)
+                          Buffer::ExportStatus (*asyncFunc)(Buffer const *, Buffer *, string const &),
+                          Buffer::ExportStatus (Buffer::*syncFunc)(string const &, bool) const,
+                          Buffer::ExportStatus (Buffer::*previewFunc)(string const &) const)
 {
        if (!used_buffer)
                return false;
@@ -3106,14 +3112,14 @@ bool GuiView::GuiViewPrivate::asyncBufferProcessing(
        string format = argument;
        if (format.empty())
                format = used_buffer->params().getDefaultOutputFormat();
-
+       processing_format = format;
 #if EXPORT_in_THREAD && (QT_VERSION >= 0x040400)
        if (!msg.empty()) {
                progress_->clearMessages();
                gv_->message(msg);
        }
        GuiViewPrivate::busyBuffers.insert(used_buffer);
-       QFuture<docstring> f = QtConcurrent::run(
+       QFuture<Buffer::ExportStatus> f = QtConcurrent::run(
                                asyncFunc,
                                used_buffer,
                                used_buffer->clone(),
@@ -3125,17 +3131,18 @@ bool GuiView::GuiViewPrivate::asyncBufferProcessing(
        // We are asynchronous, so we don't know here anything about the success
        return true;
 #else
+       Buffer::ExportStatus status;
        if (syncFunc) {
                // TODO check here if it breaks exporting with Qt < 4.4
-               bool const update_unincluded =
-                               used_buffer->params().maintain_unincluded_children &&
-                               !used_buffer->params().getIncludedChildren().empty();
-               return (used_buffer->*syncFunc)(format, true, update_unincluded);
+               status = (used_buffer->*syncFunc)(format, true);
        } else if (previewFunc) {
-               return (used_buffer->*previewFunc)(format, false);
-       }
+               status = (used_buffer->*previewFunc)(format); 
+       } else
+               return false;
+       handleExportStatus(gv_, status, format);
        (void) asyncFunc;
-       return false;
+       return (status == Buffer::ExportSuccess 
+                       || status == Buffer::PreviewSuccess);
 #endif
 }