]> git.lyx.org Git - lyx.git/blobdiff - src/frontends/qt4/GuiToolbar.cpp
* fix spelling in comments to please John.
[lyx.git] / src / frontends / qt4 / GuiToolbar.cpp
index cbf50dd65656fd16aab1e30a080a9e8b02e2df96..0469db25151c5542926b60ce49d4b9565da55f57 100644 (file)
@@ -3,10 +3,11 @@
  * This file is part of LyX, the document processor.
  * Licence details can be found in the file COPYING.
  *
- * \author Lars Gullik Bjønnes
+ * \author Lars Gullik Bjønnes
  * \author John Levon
  * \author Jean-Marc Lasgouttes
  * \author Angus Leeming
+ * \author Stefan Schimanski
  * \author Abdelrazak Younes
  *
  * Full author contact details are available in file CREDITS.
 
 #include <config.h>
 
-#include "GuiView.h"
-#include "GuiCommandBuffer.h"
 #include "GuiToolbar.h"
-#include "LyXAction.h"
+
 #include "Action.h"
-#include "qt_helpers.h"
+#include "GuiApplication.h"
+#include "GuiCommandBuffer.h"
+#include "GuiView.h"
+#include "IconPalette.h"
 #include "InsertTableWidget.h"
+#include "LayoutBox.h"
+#include "qt_helpers.h"
+#include "Toolbars.h"
 
-#include "Buffer.h"
-#include "BufferParams.h"
-#include "BufferView.h"
-#include "Cursor.h"
 #include "FuncRequest.h"
 #include "FuncStatus.h"
-#include "IconPalette.h"
-#include "Layout.h"
+#include "KeyMap.h"
 #include "LyXFunc.h"
 #include "LyXRC.h"
-#include "Paragraph.h"
-#include "TextClass.h"
-#include "ToolbarBackend.h"
 
 #include "support/debug.h"
-#include "support/filetools.h"
 #include "support/gettext.h"
 #include "support/lstrings.h"
-#include "support/lyxalgo.h" // sorted
-
-#include <QComboBox>
-#include <QHeaderView>
-#include <QKeyEvent>
-#include <QList>
-#include <QPixmap>
-#include <QSortFilterProxyModel>
-#include <QStandardItem>
-#include <QStandardItemModel>
+
+#include <QSettings>
+#include <QShowEvent>
+#include <QString>
 #include <QToolBar>
 #include <QToolButton>
-#include <QVariant>
 
-#include <boost/assert.hpp>
+#include "support/lassert.h"
 
 using namespace std;
 using namespace lyx::support;
 
-static void initializeResources()
-{
-       static bool initialized = false;
-       if (!initialized) {
-               Q_INIT_RESOURCE(Resources); 
-               initialized = true;
-       }
-}
-
-
 namespace lyx {
 namespace frontend {
 
-namespace {
-
-struct PngMap {
-       char const * key;
-       char const * value;
-};
-
-
-bool operator<(PngMap const & lhs, PngMap const & rhs)
-{
-               return strcmp(lhs.key, rhs.key) < 0;
-}
-
-
-class CompareKey {
-public:
-       CompareKey(string const & name) : name_(name) {}
-       bool operator()(PngMap const & other) const { return other.key == name_; }
-private:
-       string const name_;
-};
-
-
-PngMap sorted_png_map[] = {
-       { "Bumpeq", "bumpeq2" },
-       { "Cap", "cap2" },
-       { "Cup", "cup2" },
-       { "Delta", "delta2" },
-       { "Downarrow", "downarrow2" },
-       { "Gamma", "gamma2" },
-       { "Lambda", "lambda2" },
-       { "Leftarrow", "leftarrow2" },
-       { "Leftrightarrow", "leftrightarrow2" },
-       { "Longleftarrow", "longleftarrow2" },
-       { "Longleftrightarrow", "longleftrightarrow2" },
-       { "Longrightarrow", "longrightarrow2" },
-       { "Omega", "omega2" },
-       { "Phi", "phi2" },
-       { "Pi", "pi2" },
-       { "Psi", "psi2" },
-       { "Rightarrow", "rightarrow2" },
-       { "Sigma", "sigma2" },
-       { "Subset", "subset2" },
-       { "Supset", "supset2" },
-       { "Theta", "theta2" },
-       { "Uparrow", "uparrow2" },
-       { "Updownarrow", "updownarrow2" },
-       { "Upsilon", "upsilon2" },
-       { "Vdash", "vdash3" },
-       { "Xi", "xi2" },
-       { "nLeftarrow", "nleftarrow2" },
-       { "nLeftrightarrow", "nleftrightarrow2" },
-       { "nRightarrow", "nrightarrow2" },
-       { "nVDash", "nvdash3" },
-       { "nvDash", "nvdash2" },
-       { "textrm \\AA", "textrm_AA"},
-       { "textrm \\O", "textrm_O"},
-       { "vDash", "vdash2" }
-};
-
-size_t const nr_sorted_png_map = sizeof(sorted_png_map) / sizeof(PngMap);
-
-
-string const find_png(string const & name)
-{
-       PngMap const * const begin = sorted_png_map;
-       PngMap const * const end = begin + nr_sorted_png_map;
-       BOOST_ASSERT(sorted(begin, end));
-
-       PngMap const * const it = find_if(begin, end, CompareKey(name));
-
-       string png_name;
-       if (it != end)
-               png_name = it->value;
-       else {
-               png_name = subst(name, "_", "underscore");
-               png_name = subst(png_name, ' ', '_');
-
-               // This way we can have "math-delim { }" on the toolbar.
-               png_name = subst(png_name, "(", "lparen");
-               png_name = subst(png_name, ")", "rparen");
-               png_name = subst(png_name, "[", "lbracket");
-               png_name = subst(png_name, "]", "rbracket");
-               png_name = subst(png_name, "{", "lbrace");
-               png_name = subst(png_name, "}", "rbrace");
-               png_name = subst(png_name, "|", "bars");
-               png_name = subst(png_name, ",", "thinspace");
-               png_name = subst(png_name, ":", "mediumspace");
-               png_name = subst(png_name, ";", "thickspace");
-               png_name = subst(png_name, "!", "negthinspace");
-       }
-
-       LYXERR(Debug::GUI, "find_png(" << name << ")\n"
-               << "Looking for math PNG called \"" << png_name << '"');
-       return png_name;
-}
-
-} // namespace anon
-
-
-/// return a icon for the given action
-static QIcon getIcon(FuncRequest const & f, bool unknown)
-{
-       initializeResources();
-       QPixmap pm;
-       string name1;
-       string name2;
-       string path;
-       string fullname;
-
-       switch (f.action) {
-       case LFUN_MATH_INSERT:
-               if (!f.argument().empty()) {
-                       path = "math/";
-                       name1 = find_png(to_utf8(f.argument()).substr(1));
-               }
-               break;
-       case LFUN_MATH_DELIM:
-       case LFUN_MATH_BIGDELIM:
-               path = "math/";
-               name1 = find_png(to_utf8(f.argument()));
-               break;
-       case LFUN_CALL:
-               path = "commands/";
-               name1 = to_utf8(f.argument());
-               break;
-       default:
-               name2 = lyxaction.getActionName(f.action);
-               name1 = name2;
-
-               if (!f.argument().empty())
-                       name1 = subst(name2 + ' ' + to_utf8(f.argument()), ' ', '_');
-       }
-
-       fullname = libFileSearch("images/" + path, name1, "png").absFilename();
-       if (pm.load(toqstr(fullname)))
-               return pm;
-
-       fullname = libFileSearch("images/" + path, name2, "png").absFilename();
-       if (pm.load(toqstr(fullname)))
-               return pm;
-
-       if (pm.load(":/images/" + toqstr(path + name1) + ".png"))
-               return pm;
-
-       if (pm.load(":/images/" + toqstr(path + name2) + ".png"))
-               return pm;
-
-       LYXERR(Debug::GUI, "Cannot find icon for command \""
-                          << lyxaction.getActionName(f.action)
-                          << '(' << to_utf8(f.argument()) << ")\"");
-       if (unknown)
-               pm.load(":/images/unknown.png");
-
-       return pm;
-}
-
-
-/////////////////////////////////////////////////////////////////////
-//
-// GuiLayoutBox
-//
-/////////////////////////////////////////////////////////////////////
-
-class GuiFilterProxyModel : public QSortFilterProxyModel
-{
-public:
-       ///
-       GuiFilterProxyModel(QObject * parent)
-       : QSortFilterProxyModel(parent) {}
-       
-       ///
-       QVariant data(const QModelIndex & index, int role) const
-       {
-               GuiLayoutBox * p = static_cast<GuiLayoutBox *>(parent());
-               QString const & f = p->filter();
-
-               if (!f.isEmpty() && index.isValid() && role == Qt::DisplayRole) {
-                       // step through data item and put "(x)" for every matching character
-                       QString s = QSortFilterProxyModel::data(index, role).toString();
-                       QString r;
-                       int lastp = -1;
-                       p->filter();
-                       for (int i = 0; i < f.length(); ++i) {
-                               int p = s.indexOf(f[i], lastp + 1, Qt::CaseInsensitive);
-                               BOOST_ASSERT(p != -1);
-                               if (lastp == p - 1 && lastp != -1) {
-                                       // remove ")" and append "x)"
-                                       r = r.left(r.length() - 1) + s[p] + ")";
-                               } else {
-                                       // append "(x)"
-                                       r += s.mid(lastp + 1, p - lastp - 1);
-                                       r += "(" + s[p] + ")";
-                               }
-                               lastp = p;
-                       }
-                       r += s.mid(lastp + 1);
-                       return r;
-               }
-               
-               return QSortFilterProxyModel::data(index, role);
-       }
-       
-       ///
-       void setCharFilter(QString const & f)
-       {
-               setFilterRegExp(charFilterRegExp(f));
-               reset();
-       }
-
-private:
-       ///
-       QString charFilterRegExp(QString const & filter)
-       {
-               QString re;
-               for (int i = 0; i < filter.length(); ++i)
-                       re += ".*" + QRegExp::escape(filter[i]);
-               return re;
-       }
-};
-
-
-GuiLayoutBox::GuiLayoutBox(GuiView & owner)
-       : owner_(owner)
-{
-       setSizeAdjustPolicy(QComboBox::AdjustToContents);
-       setFocusPolicy(Qt::ClickFocus);
-       setMinimumWidth(sizeHint().width());
-       setMaxVisibleItems(100);
-
-       // set the layout model with two columns
-       // 1st: translated layout names
-       // 2nd: raw layout names
-       model_ = new QStandardItemModel(0, 2, this);
-       filterModel_ = new GuiFilterProxyModel(this);
-       filterModel_->setSourceModel(model_);
-       filterModel_->setDynamicSortFilter(true);
-       filterModel_->setFilterCaseSensitivity(Qt::CaseInsensitive);
-       setModel(filterModel_);
-
-       // for the filtering we have to intercept characters
-       view()->installEventFilter(this);
-       
-       QObject::connect(this, SIGNAL(activated(int)),
-                        this, SLOT(selected(int)));
-       owner_.setLayoutDialog(this);
-       updateContents(true);
-}
-
-
-void GuiLayoutBox::setFilter(QString const & s)
-{
-       // remember old selection
-       int sel = currentIndex();
-       if (sel != -1)
-               lastSel_ = filterModel_->mapToSource(filterModel_->index(sel, 0)).row();
-
-       filter_ = s;
-       filterModel_->setCharFilter(s);
-       
-       // restore old selection
-       if (lastSel_ != -1) {
-               QModelIndex i = filterModel_->mapFromSource(model_->index(lastSel_, 0));
-               if (i.isValid())
-                       setCurrentIndex(i.row());
-       }
-}
-
-
-void GuiLayoutBox::resetFilter()
-{
-       setFilter(QString());
-}
-
-
-bool GuiLayoutBox::eventFilter(QObject *o, QEvent *e)
-{
-       if (e->type() == QEvent::KeyPress) {
-               QKeyEvent * ke = static_cast<QKeyEvent*>(e);
-               bool modified = (ke->modifiers() == Qt::ControlModifier)
-                       || (ke->modifiers() == Qt::AltModifier)
-                       || (ke->modifiers() == Qt::MetaModifier);
-               
-               switch (ke->key()) {
-               case Qt::Key_Escape:
-                       if (!modified && !filter_.isEmpty()) {
-                               resetFilter();
-                               return true;
-                       }
-                       break;
-               case Qt::Key_Backspace:
-                       if (!modified) {
-                               // cut off one character
-                               setFilter(filter_.left(filter_.length() - 1));
-                       }
-                       break;
-               default:
-                       if (modified || ke->text().isEmpty())
-                               break;
-                       // find chars for the filter string
-                       QString s;
-                       for (int i = 0; i < ke->text().length(); ++i) {
-                               QChar c = ke->text()[i];
-                               if (c.isLetterOrNumber()
-                                   || c.isSymbol()
-                                   || c.isPunct()
-                                   || c.category() == QChar::Separator_Space) {
-                                       s += c;
-                               }
-                       }
-                       if (!s.isEmpty()) {
-                               // append new chars to the filter string
-                               setFilter(filter_ + s);
-                               return true;
-                       }
-                       break;
-               }
-       }
-       return QComboBox::eventFilter(o, e);
-}
-
-
-void GuiLayoutBox::set(docstring const & layout)
-{
-       resetFilter();
-       
-       if (!text_class_)
-               return;
-
-       QString const & name = toqstr((*text_class_)[layout]->name());
-       if (name == currentText())
-               return;
-
-       QList<QStandardItem *> r = model_->findItems(name, Qt::MatchExactly, 1);
-       if (r.empty()) {
-               lyxerr << "Trying to select non existent layout type "
-                       << fromqstr(name) << endl;
-               return;
-       }
-
-       setCurrentIndex(filterModel_->mapFromSource(r.first()->index()).row());
-}
-
-
-void GuiLayoutBox::addItemSort(docstring const & item, bool sorted)
+GuiToolbar::GuiToolbar(ToolbarInfo const & tbinfo, GuiView & owner)
+       : QToolBar(toqstr(tbinfo.gui_name), &owner), visibility_(0),
+         allowauto_(false), owner_(owner), command_buffer_(0),
+         tbinfo_(tbinfo), filled_(false)
 {
-       QString qitem = toqstr(item);
-       QList<QStandardItem *> row;
-       row.append(new QStandardItem(toqstr(translateIfPossible(item))));
-       row.append(new QStandardItem(qitem));
-
-       // the simple unsorted case
-       int const end = model_->rowCount();
-       if (!sorted || end < 2 || qitem[0].category() != QChar::Letter_Uppercase) {
-               model_->appendRow(row);
-               return;
-       }
+       setIconSize(owner.iconSize());
+       connect(&owner, SIGNAL(iconSizeChanged(QSize)), this,
+               SLOT(setIconSize(QSize)));
 
-       // find row to insert the item
-       int i = 1; // skip the Standard layout
-       QString is = model_->item(i, 1)->text();
-       while (is.compare(qitem) < 0) {
-               // e.g. --Separator--
-               if (is[0].category() != QChar::Letter_Uppercase)
-                       break;
-               ++i;
-               if (i == end)
-                       break;
-               QString is = model_->item(i, 1)->text();
-       }
-
-       model_->insertRow(i, row);
+       // Toolbar dragging is allowed.
+       setMovable(true);
+       // This is used by QMainWindow::restoreState for proper main window state
+       // restauration.
+       setObjectName(toqstr(tbinfo.name));
+       restoreSession();
 }
 
 
-void GuiLayoutBox::updateContents(bool reset)
+void GuiToolbar::fill()
 {
-       resetFilter();
-       
-       Buffer const * buffer = owner_.buffer();
-       if (!buffer) {
-               model_->clear();
-               setEnabled(false);
-               text_class_ = 0;
-               inset_ = 0;
+       if (filled_)
                return;
-       }
-
-       // we'll only update the layout list if the text class has changed
-       // or we've moved from one inset to another
-       DocumentClass const * text_class = &buffer->params().documentClass();
-       Inset const * inset = 
-       owner_.view()->cursor().innerParagraph().inInset();
-       if (!reset && text_class_ == text_class && inset_ == inset) {
-               set(owner_.view()->cursor().innerParagraph().layout()->name());
-               return;
-       }
-
-       inset_ = inset;
-       text_class_ = text_class;
-
-       model_->clear();
-       for (size_t i = 0; i != text_class_->layoutCount(); ++i) {
-               Layout const & lt = *text_class_->layout(i);
-               docstring const & name = lt.name();
-               // if this inset requires the empty layout, we skip the default
-               // layout
-               if (name == text_class_->defaultLayoutName() && inset &&
-                   (inset->forceEmptyLayout() || inset->useEmptyLayout()))
-                       continue;
-               // if it doesn't require the empty layout, we skip it
-               if (name == text_class_->emptyLayoutName() && inset &&
-                   !inset->forceEmptyLayout() && !inset->useEmptyLayout())
-                       continue;
-               addItemSort(name, lyxrc.sort_layouts);
-       }
-
-       set(owner_.view()->cursor().innerParagraph().layout()->name());
-
-       // needed to recalculate size hint
-       hide();
-       setMinimumWidth(sizeHint().width());
-       setEnabled(!buffer->isReadonly());
-       show();
+       ToolbarInfo::item_iterator it = tbinfo_.items.begin();
+       ToolbarInfo::item_iterator end = tbinfo_.items.end();
+       for (; it != end; ++it)
+               add(*it);       
+       filled_ = true;
 }
 
 
-void GuiLayoutBox::selected(int index)
+void GuiToolbar::showEvent(QShowEvent * ev)
 {
-       // get selection
-       QModelIndex mindex = filterModel_->mapToSource(filterModel_->index(index, 1));
-       docstring const name = qstring_to_ucs4(model_->itemFromIndex(mindex)->text());
-
-       owner_.setFocus();
-
-       if (!text_class_) {
-               updateContents(false);
-               resetFilter();
-               return;
-       }
-
-       // find corresponding text class
-       for (size_t i = 0; i != text_class_->layoutCount(); ++i) {
-               docstring const & itname = text_class_->layout(i)->name();
-               if (itname == name) {
-                       FuncRequest const func(LFUN_LAYOUT, itname,
-                                              FuncRequest::TOOLBAR);
-                       theLyXFunc().setLyXView(&owner_);
-                       lyx::dispatch(func);
-                       updateContents(false);
-                       resetFilter();
-                       return;
-               }
-       }
-       lyxerr << "ERROR (layoutSelected): layout not found!" << endl;
+       fill();
+       ev->accept();
 }
 
 
-
-/////////////////////////////////////////////////////////////////////
-//
-// GuiToolbar
-//
-/////////////////////////////////////////////////////////////////////
-
-
-GuiToolbar::GuiToolbar(ToolbarInfo const & tbinfo, GuiView & owner)
-       : QToolBar(qt_(tbinfo.gui_name), &owner), owner_(owner),
-         layout_(0), command_buffer_(0)
+void GuiToolbar::setVisibility(int visibility)
 {
-       // give visual separation between adjacent toolbars
-       addSeparator();
-
-       // TODO: save toolbar position
-       setMovable(true);
-
-       ToolbarInfo::item_iterator it = tbinfo.items.begin();
-       ToolbarInfo::item_iterator end = tbinfo.items.end();
-       for (; it != end; ++it)
-               add(*it);
+       visibility_ = visibility;
+       allowauto_ = visibility_ >= Toolbars::MATH;
 }
 
 
 Action * GuiToolbar::addItem(ToolbarItem const & item)
 {
-       Action * act = new Action(owner_,
-               getIcon(item.func_, false),
-         toqstr(item.label_), item.func_, toqstr(item.label_));
+       QString text = toqstr(item.label_);
+       // Get the keys bound to this action, but keep only the
+       // first one later
+       KeyMap::Bindings bindings = theTopLevelKeymap().findBindings(item.func_);
+       if (bindings.size())
+               text += " [" + toqstr(bindings.begin()->print(KeySequence::ForGui)) + "]";
+
+       Action * act = new Action(&owner_, getIcon(item.func_, false),
+               text, item.func_, text, this);
        actions_.append(act);
        return act;
 }
@@ -583,8 +129,7 @@ public:
                connect(bar_, SIGNAL(iconSizeChanged(QSize)),
                        this, SLOT(setIconSize(QSize)));
                setCheckable(true);
-               ToolbarInfo const * tbinfo = 
-                       toolbarbackend.getDefinedToolbarInfo(tbitem_.name_);
+               ToolbarInfo const * tbinfo = guiApp->toolbars().info(tbitem_.name_);
                if (tbinfo)
                        // use the icon of first action for the toolbar button
                        setIcon(getIcon(tbinfo->items.begin()->func_, true));
@@ -599,10 +144,9 @@ public:
 
                initialized_ = true;
 
-               ToolbarInfo const * tbinfo = 
-                       toolbarbackend.getDefinedToolbarInfo(tbitem_.name_);
+               ToolbarInfo const * tbinfo = guiApp->toolbars().info(tbitem_.name_);
                if (!tbinfo) {
-                       lyxerr << "Unknown toolbar " << tbitem_.name_ << endl;
+                       LYXERR0("Unknown toolbar " << tbitem_.name_);
                        return;
                }
                IconPalette * panel = new IconPalette(this);
@@ -620,57 +164,64 @@ public:
        }
 };
 
-class MenuButton : public QToolButton
+}
+
+
+MenuButton::MenuButton(GuiToolbar * bar, ToolbarItem const & item, bool const sticky)
+       : QToolButton(bar), bar_(bar), tbitem_(item), initialized_(false)
 {
-private:
-       GuiToolbar * bar_;
-       ToolbarItem const & tbitem_;
-       bool initialized_;
-public:
-       MenuButton(GuiToolbar * bar, ToolbarItem const & item)
-               : QToolButton(bar), bar_(bar), tbitem_(item), initialized_(false)
-       {
-               setPopupMode(QToolButton::InstantPopup);
-               QString const label = qt_(to_ascii(tbitem_.label_));
-               setToolTip(label);
-               setStatusTip(label);
-               setText(label);
-               setIcon(QPixmap(":images/math/" + toqstr(tbitem_.name_) + ".png"));
-               connect(bar, SIGNAL(iconSizeChanged(QSize)),
-                       this, SLOT(setIconSize(QSize)));
+       setPopupMode(QToolButton::InstantPopup);
+       QString const label = qt_(to_ascii(tbitem_.label_));
+       setToolTip(label);
+       setStatusTip(label);
+       setText(label);
+       QString const name = toqstr(tbitem_.name_);
+       FileName const fname = libFileSearch("images/math/", name, "png");
+       if (fname.exists())
+           setIcon(QIcon(getPixmap("images/math/", name, "png")));
+       else
+           setIcon(QIcon(getPixmap("images/", name, "png")));
+       if (sticky)
+               connect(this, SIGNAL(triggered(QAction *)),
+                       this, SLOT(actionTriggered(QAction *)));
+       connect(bar, SIGNAL(iconSizeChanged(QSize)),
+               this, SLOT(setIconSize(QSize)));
+}
+
+void MenuButton::mousePressEvent(QMouseEvent * e)
+{
+       if (initialized_) {
+               QToolButton::mousePressEvent(e);
+               return;
        }
 
-       void mousePressEvent(QMouseEvent * e)
-       {
-               if (initialized_) {
-                       QToolButton::mousePressEvent(e);
-                       return;
-               }
+       initialized_ = true;
 
-               initialized_ = true;
+       QString const label = qt_(to_ascii(tbitem_.label_));
+       ButtonMenu * m = new ButtonMenu(label, this);
+       m->setWindowTitle(label);
+       m->setTearOffEnabled(true);
+       connect(bar_, SIGNAL(updated()), m, SLOT(updateParent()));
+       ToolbarInfo const * tbinfo = guiApp->toolbars().info(tbitem_.name_);
+       if (!tbinfo) {
+               LYXERR0("Unknown toolbar " << tbitem_.name_);
+               return;
+       }
+       ToolbarInfo::item_iterator it = tbinfo->items.begin();
+       ToolbarInfo::item_iterator const end = tbinfo->items.end();
+       for (; it != end; ++it)
+               if (!getStatus(it->func_).unknown())
+                       m->add(bar_->addItem(*it));
+       setMenu(m);
 
-               QString const label = qt_(to_ascii(tbitem_.label_));
-               ButtonMenu * m = new ButtonMenu(label, this);
-               m->setWindowTitle(label);
-               m->setTearOffEnabled(true);
-               connect(bar_, SIGNAL(updated()), m, SLOT(updateParent()));
-               ToolbarInfo const * tbinfo = 
-                       toolbarbackend.getDefinedToolbarInfo(tbitem_.name_);
-               if (!tbinfo) {
-                       lyxerr << "Unknown toolbar " << tbitem_.name_ << endl;
-                       return;
-               }
-               ToolbarInfo::item_iterator it = tbinfo->items.begin();
-               ToolbarInfo::item_iterator const end = tbinfo->items.end();
-               for (; it != end; ++it)
-                       if (!getStatus(it->func_).unknown())
-                               m->add(bar_->addItem(*it));
-               setMenu(m);
+       QToolButton::mousePressEvent(e);
+}
 
-               QToolButton::mousePressEvent(e);
-       }
-};
 
+void MenuButton::actionTriggered(QAction * action)
+{
+       QToolButton::setDefaultAction(action);
+       setPopupMode(QToolButton::DelayedPopup);
 }
 
 
@@ -680,10 +231,14 @@ void GuiToolbar::add(ToolbarItem const & item)
        case ToolbarItem::SEPARATOR:
                addSeparator();
                break;
-       case ToolbarItem::LAYOUTS:
-               layout_ = new GuiLayoutBox(owner_);
-               addWidget(layout_);
+       case ToolbarItem::LAYOUTS: {
+               LayoutBox * layout = owner_.getLayoutDialog();
+               QObject::connect(this, SIGNAL(iconSizeChanged(QSize)),
+                       layout, SLOT(setIconSize(QSize)));
+               QAction * action = addWidget(layout);
+               action->setVisible(true);
                break;
+       }
        case ToolbarItem::MINIBUFFER:
                command_buffer_ = new GuiCommandBuffer(&owner_);
                addWidget(command_buffer_);
@@ -710,7 +265,11 @@ void GuiToolbar::add(ToolbarItem const & item)
                break;
 
        case ToolbarItem::POPUPMENU: {
-               addWidget(new MenuButton(this, item));
+               addWidget(new MenuButton(this, item, false));
+               break;
+               }
+       case ToolbarItem::STICKYPOPUPMENU: {
+               addWidget(new MenuButton(this, item, true));
                break;
                }
        case ToolbarItem::COMMAND: {
@@ -724,56 +283,88 @@ void GuiToolbar::add(ToolbarItem const & item)
 }
 
 
-void GuiToolbar::saveInfo(ToolbarSection::ToolbarInfo & tbinfo)
+void GuiToolbar::update(bool in_math, bool in_table, bool in_review, 
+       bool in_mathmacrotemplate)
 {
-       // if tbinfo.state == auto *do not* set on/off
-       if (tbinfo.state != ToolbarSection::ToolbarInfo::AUTO) {
-               if (GuiToolbar::isVisible())
-                       tbinfo.state = ToolbarSection::ToolbarInfo::ON;
-               else
-                       tbinfo.state = ToolbarSection::ToolbarInfo::OFF;
+       if (visibility_ & Toolbars::AUTO) {
+               bool show_it = (in_math && (visibility_ & Toolbars::MATH))
+                       || (in_table && (visibility_ & Toolbars::TABLE))
+                       || (in_review && (visibility_ & Toolbars::REVIEW))
+                       || (in_mathmacrotemplate && (visibility_ & Toolbars::MATHMACROTEMPLATE));
+               setVisible(show_it);
        }
-       //
-       // no need to save it here.
-       Qt::ToolBarArea loc = owner_.toolBarArea(this);
-
-       if (loc == Qt::TopToolBarArea)
-               tbinfo.location = ToolbarSection::ToolbarInfo::TOP;
-       else if (loc == Qt::BottomToolBarArea)
-               tbinfo.location = ToolbarSection::ToolbarInfo::BOTTOM;
-       else if (loc == Qt::RightToolBarArea)
-               tbinfo.location = ToolbarSection::ToolbarInfo::RIGHT;
-       else if (loc == Qt::LeftToolBarArea)
-               tbinfo.location = ToolbarSection::ToolbarInfo::LEFT;
-       else
-               tbinfo.location = ToolbarSection::ToolbarInfo::NOTSET;
-
-       // save toolbar position. They are not used to restore toolbar position
-       // now because move(x,y) does not work for toolbar.
-       tbinfo.posx = pos().x();
-       tbinfo.posy = pos().y();
-}
-
 
-void GuiToolbar::updateContents()
-{
        // update visible toolbars only
        if (!isVisible())
                return;
+
        // This is a speed bottleneck because this is called on every keypress
        // and update calls getStatus, which copies the cursor at least two times
        for (int i = 0; i < actions_.size(); ++i)
                actions_[i]->update();
 
-       if (layout_)
-               layout_->setEnabled(lyx::getStatus(FuncRequest(LFUN_LAYOUT)).enabled());
+       LayoutBox * layout = owner_.getLayoutDialog();
+       if (layout)
+               layout->setEnabled(lyx::getStatus(FuncRequest(LFUN_LAYOUT)).enabled());
 
        // emit signal
        updated();
 }
 
 
+QString GuiToolbar::sessionKey() const
+{
+       return "views/" + QString::number(owner_.id()) + "/" + objectName();
+}
+
+
+void GuiToolbar::saveSession() const
+{
+       QSettings settings;
+       settings.setValue(sessionKey() + "/visibility", visibility_);
+}
+
+
+void GuiToolbar::restoreSession()
+{
+       QSettings settings;
+       setVisibility(settings.value(sessionKey() + "/visibility").toInt());
+}
+
+
+void GuiToolbar::toggle()
+{
+       docstring state;
+       if (allowauto_) {
+               if (!(visibility_ & Toolbars::AUTO)) {
+                       visibility_ |= Toolbars::AUTO;
+                       hide();
+                       state = _("auto");
+               } else {
+                       visibility_ &= ~Toolbars::AUTO;
+                       if (isVisible()) {
+                               hide();
+                               state = _("off");
+                       } else {
+                               show();
+                               state = _("on");
+                       }
+               }
+       } else {
+               if (isVisible()) {
+                       hide();
+                       state = _("off");
+               } else {
+                       show();
+                       state = _("on");
+               }
+       }
+
+       owner_.message(bformat(_("Toolbar \"%1$s\" state set to %2$s"),
+               qstring_to_ucs4(windowTitle()), state));
+}
+
 } // namespace frontend
 } // namespace lyx
 
-#include "GuiToolbar_moc.cpp"
+#include "moc_GuiToolbar.cpp"