]> git.lyx.org Git - lyx.git/blobdiff - src/frontends/qt4/GuiPrefs.cpp
* For gcc to know about QStandardItemModel < QAbstractItemModel we need this header.
[lyx.git] / src / frontends / qt4 / GuiPrefs.cpp
index 23eb5a44cc9b6a63388a1fe62af48628cb6f5066..d58c26d23259e3002cc707dce506a35d3fb278c6 100644 (file)
 
 #include "GuiPrefs.h"
 
-#include "qt_helpers.h"
+#include "FileDialog.h"
 #include "GuiApplication.h"
+#include "GuiFontExample.h"
 #include "GuiFontLoader.h"
+#include "GuiKeySymbol.h"
+#include "qt_helpers.h"
 
 #include "BufferList.h"
 #include "Color.h"
 #include "ConverterCache.h"
-#include "FileDialog.h"
 #include "FuncRequest.h"
-#include "GuiFontExample.h"
-#include "GuiKeySymbol.h"
 #include "KeyMap.h"
 #include "KeySequence.h"
+#include "Language.h"
 #include "LyXAction.h"
 #include "PanelStack.h"
 #include "paper.h"
 #include "Session.h"
 
 #include "support/debug.h"
-#include "support/FileFilterList.h"
 #include "support/FileName.h"
 #include "support/filetools.h"
 #include "support/foreach.h"
@@ -54,6 +54,7 @@
 #include <QPixmapCache>
 #include <QPushButton>
 #include <QSpinBox>
+#include <QStandardItemModel.h>
 #include <QString>
 #include <QTreeWidget>
 #include <QTreeWidgetItem>
@@ -86,7 +87,7 @@ namespace frontend {
 */
 QString browseFile(QString const & filename,
        QString const & title,
-       support::FileFilterList const & filters,
+       QStringList const & filters,
        bool save = false,
        QString const & label1 = QString(),
        QString const & dir1 = QString(),
@@ -121,7 +122,7 @@ QString browseLibFile(QString const & dir,
        QString const & name,
        QString const & ext,
        QString const & title,
-       support::FileFilterList const & filters)
+       QStringList const & filters)
 {
        // FIXME UNICODE
        QString const label1 = qt_("System files|#S#s");
@@ -181,13 +182,14 @@ QString browseDir(QString const & pathname,
 
 } // namespace frontend
 
+
 QString browseRelFile(QString const & filename, QString const & refpath,
-       QString const & title, FileFilterList const & filters, bool save,
+       QString const & title, QStringList const & filters, bool save,
        QString const & label1, QString const & dir1,
        QString const & label2, QString const & dir2)
 {
-       QString const fname = toqstr(makeAbsPath(
-               fromqstr(filename), fromqstr(refpath)).absFilename());
+       QString const fname = makeAbsPath(filename, refpath);
+
 
        QString const outname =
                frontend::browseFile(fname, title, filters, save, label1, dir1, label2, dir2);
@@ -202,6 +204,7 @@ QString browseRelFile(QString const & filename, QString const & refpath,
 }
 
 
+
 /////////////////////////////////////////////////////////////////////
 //
 // Helpers
@@ -210,14 +213,11 @@ QString browseRelFile(QString const & filename, QString const & refpath,
 
 namespace frontend {
 
-static int findPos_helper(QStringList const & vec, QString const & val)
-{
-       for (int i = 0; i != vec.size(); ++i)
-               if (vec[i] == val)
-                       return i;
-       return 0;
-}
-
+string const catLookAndFeel = N_("Look & Feel");
+string const catEditing = N_("Editing");
+string const catLanguage = N_("Language Settings");
+string const catOutput = N_("Output");
+string const catFiles = N_("File Handling");
 
 static void parseFontName(QString const & mangled0,
        string & name, string & foundry)
@@ -291,18 +291,18 @@ static void setComboxFont(QComboBox * cb, string const & family,
                font.setStyleHint(QFont::TypeWriter);
                font.setFamily(font_family);
        } else {
-               lyxerr << "FAILED to find the default font: '"
-                      << foundry << "', '" << family << '\''<< endl;
+               LYXERR0("FAILED to find the default font: '"
+                      << foundry << "', '" << family << '\'');
                return;
        }
 
        QFontInfo info(font);
        string default_font_name, dummyfoundry;
        parseFontName(info.family(), default_font_name, dummyfoundry);
-       lyxerr << "Apparent font is " << default_font_name << endl;
+       LYXERR0("Apparent font is " << default_font_name);
 
        for (int i = 0; i < cb->count(); ++i) {
-               lyxerr << "Looking at " << fromqstr(cb->itemText(i)) << endl;
+               LYXERR0("Looking at " << cb->itemText(i));
                if (compare_ascii_no_case(fromqstr(cb->itemText(i)),
                                    default_font_name) == 0) {
                        cb->setCurrentIndex(i);
@@ -310,11 +310,12 @@ static void setComboxFont(QComboBox * cb, string const & family,
                }
        }
 
-       lyxerr << "FAILED to find the font: '"
-              << foundry << "', '" << family << '\'' <<endl;
+       LYXERR0("FAILED to find the font: '"
+              << foundry << "', '" << family << '\'');
 }
 
 
+
 /////////////////////////////////////////////////////////////////////
 //
 // PrefPlaintext
@@ -322,7 +323,7 @@ static void setComboxFont(QComboBox * cb, string const & family,
 /////////////////////////////////////////////////////////////////////
 
 PrefPlaintext::PrefPlaintext(QWidget * parent)
-       : PrefModule(qt_("Plain text"), 0, parent)
+       : PrefModule(qt_(catOutput), qt_("Plain text"), 0, parent)
 {
        setupUi(this);
        connect(plaintextLinelengthSB, SIGNAL(valueChanged(int)),
@@ -353,7 +354,7 @@ void PrefPlaintext::update(LyXRC const & rc)
 /////////////////////////////////////////////////////////////////////
 
 PrefDate::PrefDate(QWidget * parent)
-       : PrefModule(qt_("Date format"), 0, parent)
+       : PrefModule(qt_(catOutput), qt_("Date format"), 0, parent)
 {
        setupUi(this);
        connect(DateED, SIGNAL(textChanged(QString)),
@@ -380,7 +381,7 @@ void PrefDate::update(LyXRC const & rc)
 /////////////////////////////////////////////////////////////////////
 
 PrefInput::PrefInput(GuiPreferences * form, QWidget * parent)
-       : PrefModule(qt_("Keyboard/Mouse"), form, parent)
+       : PrefModule(qt_(catEditing), qt_("Keyboard/Mouse"), form, parent)
 {
        setupUi(this);
 
@@ -390,22 +391,6 @@ PrefInput::PrefInput(GuiPreferences * form, QWidget * parent)
                this, SIGNAL(changed()));
        connect(secondKeymapED, SIGNAL(textChanged(QString)),
                this, SIGNAL(changed()));
-       connect(inlineDelaySB, SIGNAL(valueChanged(double)),
-               this, SIGNAL(changed()));
-       connect(inlineMathCB, SIGNAL(clicked()),
-               this, SIGNAL(changed()));
-       connect(inlineTextCB, SIGNAL(clicked()),
-               this, SIGNAL(changed()));
-       connect(inlineDotsCB, SIGNAL(clicked()),
-               this, SIGNAL(changed()));
-       connect(popupDelaySB, SIGNAL(valueChanged(double)),
-               this, SIGNAL(changed()));
-       connect(popupMathCB, SIGNAL(clicked()),
-               this, SIGNAL(changed()));
-       connect(popupTextCB, SIGNAL(clicked()),
-               this, SIGNAL(changed()));
-       connect(popupAfterCompleteCB, SIGNAL(clicked()),
-               this, SIGNAL(changed()));
        connect(mouseWheelSpeedSB, SIGNAL(valueChanged(double)),
                this, SIGNAL(changed()));
 }
@@ -417,15 +402,6 @@ void PrefInput::apply(LyXRC & rc) const
        rc.use_kbmap = keymapCB->isChecked();
        rc.primary_kbmap = internal_path(fromqstr(firstKeymapED->text()));
        rc.secondary_kbmap = internal_path(fromqstr(secondKeymapED->text()));
-       rc.completion_inline_delay = inlineDelaySB->value();
-       rc.completion_inline_math = inlineMathCB->isChecked();
-       rc.completion_inline_text = inlineTextCB->isChecked();
-       rc.completion_inline_dots = inlineDotsCB->isChecked() ? 13 : -1;
-       rc.completion_popup_delay = popupDelaySB->value();
-       rc.completion_popup_math = popupMathCB->isChecked();
-       rc.completion_popup_text = popupTextCB->isChecked();
-       rc.completion_popup_after_complete
-       = popupAfterCompleteCB->isChecked();
        rc.mouse_wheel_speed = mouseWheelSpeedSB->value();
 }
 
@@ -436,14 +412,6 @@ void PrefInput::update(LyXRC const & rc)
        keymapCB->setChecked(rc.use_kbmap);
        firstKeymapED->setText(toqstr(external_path(rc.primary_kbmap)));
        secondKeymapED->setText(toqstr(external_path(rc.secondary_kbmap)));
-       inlineDelaySB->setValue(rc.completion_inline_delay);
-       inlineMathCB->setChecked(rc.completion_inline_math);
-       inlineTextCB->setChecked(rc.completion_inline_text);
-       inlineDotsCB->setChecked(rc.completion_inline_dots != -1);
-       popupDelaySB->setValue(rc.completion_popup_delay);
-       popupMathCB->setChecked(rc.completion_popup_math);
-       popupTextCB->setChecked(rc.completion_popup_text);
-       popupAfterCompleteCB->setChecked(rc.completion_popup_after_complete);
        mouseWheelSpeedSB->setValue(rc.mouse_wheel_speed);
 }
 
@@ -481,6 +449,68 @@ void PrefInput::on_keymapCB_toggled(bool keymap)
 }
 
 
+/////////////////////////////////////////////////////////////////////
+//
+// PrefCompletion
+//
+/////////////////////////////////////////////////////////////////////
+
+PrefCompletion::PrefCompletion(GuiPreferences * form, QWidget * parent)
+       : PrefModule(qt_(catEditing), qt_("Input Completion"), form, parent)
+{
+       setupUi(this);
+
+       connect(inlineDelaySB, SIGNAL(valueChanged(double)),
+               this, SIGNAL(changed()));
+       connect(inlineMathCB, SIGNAL(clicked()),
+               this, SIGNAL(changed()));
+       connect(inlineTextCB, SIGNAL(clicked()),
+               this, SIGNAL(changed()));
+       connect(inlineDotsCB, SIGNAL(clicked()),
+               this, SIGNAL(changed()));
+       connect(popupDelaySB, SIGNAL(valueChanged(double)),
+               this, SIGNAL(changed()));
+       connect(popupMathCB, SIGNAL(clicked()),
+               this, SIGNAL(changed()));
+       connect(popupTextCB, SIGNAL(clicked()),
+               this, SIGNAL(changed()));
+       connect(popupAfterCompleteCB, SIGNAL(clicked()),
+               this, SIGNAL(changed()));
+       connect(cursorTextCB, SIGNAL(clicked()),
+               this, SIGNAL(changed()));
+}
+
+
+void PrefCompletion::apply(LyXRC & rc) const
+{
+       rc.completion_inline_delay = inlineDelaySB->value();
+       rc.completion_inline_math = inlineMathCB->isChecked();
+       rc.completion_inline_text = inlineTextCB->isChecked();
+       rc.completion_inline_dots = inlineDotsCB->isChecked() ? 13 : -1;
+       rc.completion_popup_delay = popupDelaySB->value();
+       rc.completion_popup_math = popupMathCB->isChecked();
+       rc.completion_popup_text = popupTextCB->isChecked();
+       rc.completion_cursor_text = cursorTextCB->isChecked();
+       rc.completion_popup_after_complete =
+               popupAfterCompleteCB->isChecked();
+}
+
+
+void PrefCompletion::update(LyXRC const & rc)
+{
+       inlineDelaySB->setValue(rc.completion_inline_delay);
+       inlineMathCB->setChecked(rc.completion_inline_math);
+       inlineTextCB->setChecked(rc.completion_inline_text);
+       inlineDotsCB->setChecked(rc.completion_inline_dots != -1);
+       popupDelaySB->setValue(rc.completion_popup_delay);
+       popupMathCB->setChecked(rc.completion_popup_math);
+       popupTextCB->setChecked(rc.completion_popup_text);
+       cursorTextCB->setChecked(rc.completion_cursor_text);
+       popupAfterCompleteCB->setChecked(rc.completion_popup_after_complete);
+}
+
+
+
 /////////////////////////////////////////////////////////////////////
 //
 // PrefLatex
@@ -488,7 +518,7 @@ void PrefInput::on_keymapCB_toggled(bool keymap)
 /////////////////////////////////////////////////////////////////////
 
 PrefLatex::PrefLatex(GuiPreferences * form, QWidget * parent)
-       : PrefModule(qt_("LaTeX"), form, parent)
+       : PrefModule(qt_(catOutput), qt_("LaTeX"), form, parent)
 {
        setupUi(this);
        connect(latexEncodingED, SIGNAL(textChanged(QString)),
@@ -555,7 +585,7 @@ void PrefLatex::update(LyXRC const & rc)
 /////////////////////////////////////////////////////////////////////
 
 PrefScreenFonts::PrefScreenFonts(GuiPreferences * form, QWidget * parent)
-       : PrefModule(qt_("Screen fonts"), form, parent)
+       : PrefModule(qt_(catLookAndFeel), qt_("Screen fonts"), form, parent)
 {
        setupUi(this);
 
@@ -729,7 +759,7 @@ struct ColorSorter
 } // namespace anon
 
 PrefColors::PrefColors(GuiPreferences * form, QWidget * parent)
-       : PrefModule(qt_("Colors"), form, parent)
+       : PrefModule(qt_(catLookAndFeel), qt_("Colors"), form, parent)
 {
        setupUi(this);
 
@@ -828,7 +858,7 @@ void PrefColors::change_lyxObjects_selection()
 /////////////////////////////////////////////////////////////////////
 
 PrefDisplay::PrefDisplay(QWidget * parent)
-       : PrefModule(qt_("Graphics"), 0, parent)
+       : PrefModule(qt_(catLookAndFeel), qt_("Graphics"), 0, parent)
 {
        setupUi(this);
        connect(instantPreviewCO, SIGNAL(activated(int)),
@@ -899,7 +929,7 @@ void PrefDisplay::update(LyXRC const & rc)
 /////////////////////////////////////////////////////////////////////
 
 PrefPaths::PrefPaths(GuiPreferences * form, QWidget * parent)
-       : PrefModule(qt_("Paths"), form, parent)
+       : PrefModule(QString(), qt_("Paths"), form, parent)
 {
        setupUi(this);
        connect(exampleDirPB, SIGNAL(clicked()), this, SLOT(select_exampledir()));
@@ -953,7 +983,7 @@ void PrefPaths::update(LyXRC const & rc)
 
 void PrefPaths::select_exampledir()
 {
-       QString file = form_->browsedir(internalPath(exampleDirED->text()),
+       QString file = browseDir(internalPath(exampleDirED->text()),
                qt_("Select directory for example files"));
        if (!file.isEmpty())
                exampleDirED->setText(file);
@@ -962,7 +992,7 @@ void PrefPaths::select_exampledir()
 
 void PrefPaths::select_templatedir()
 {
-       QString file = form_->browsedir(internalPath(templateDirED->text()),
+       QString file = browseDir(internalPath(templateDirED->text()),
                qt_("Select a document templates directory"));
        if (!file.isEmpty())
                templateDirED->setText(file);
@@ -971,7 +1001,7 @@ void PrefPaths::select_templatedir()
 
 void PrefPaths::select_tempdir()
 {
-       QString file = form_->browsedir(internalPath(tempDirED->text()),
+       QString file = browseDir(internalPath(tempDirED->text()),
                qt_("Select a temporary directory"));
        if (!file.isEmpty())
                tempDirED->setText(file);
@@ -980,7 +1010,7 @@ void PrefPaths::select_tempdir()
 
 void PrefPaths::select_backupdir()
 {
-       QString file = form_->browsedir(internalPath(backupDirED->text()),
+       QString file = browseDir(internalPath(backupDirED->text()),
                qt_("Select a backups directory"));
        if (!file.isEmpty())
                backupDirED->setText(file);
@@ -989,7 +1019,7 @@ void PrefPaths::select_backupdir()
 
 void PrefPaths::select_workingdir()
 {
-       QString file = form_->browsedir(internalPath(workingDirED->text()),
+       QString file = browseDir(internalPath(workingDirED->text()),
                qt_("Select a document directory"));
        if (!file.isEmpty())
                workingDirED->setText(file);
@@ -1012,7 +1042,7 @@ void PrefPaths::select_lyxpipe()
 /////////////////////////////////////////////////////////////////////
 
 PrefSpellchecker::PrefSpellchecker(GuiPreferences * form, QWidget * parent)
-       : PrefModule(qt_("Spellchecker"), form, parent)
+       : PrefModule(qt_(catLanguage), qt_("Spellchecker"), form, parent)
 {
        setupUi(this);
 
@@ -1121,7 +1151,7 @@ void PrefSpellchecker::select_dict()
 
 
 PrefConverters::PrefConverters(GuiPreferences * form, QWidget * parent)
-       : PrefModule(qt_("Converters"), form, parent)
+       : PrefModule(qt_(catFiles), qt_("Converters"), form, parent)
 {
        setupUi(this);
 
@@ -1391,7 +1421,7 @@ string FormatPrettynameValidator::str(Formats::const_iterator it) const
 
 
 PrefFileformats::PrefFileformats(GuiPreferences * form, QWidget * parent)
-       : PrefModule(qt_("File formats"), form, parent)
+       : PrefModule(qt_(catFiles), qt_("File formats"), form, parent)
 {
        setupUi(this);
        formatED->setValidator(new FormatNameValidator(formatsCB, form_->formats()));
@@ -1590,7 +1620,7 @@ void PrefFileformats::on_formatRemovePB_clicked()
 /////////////////////////////////////////////////////////////////////
 
 PrefLanguage::PrefLanguage(QWidget * parent)
-       : PrefModule(qt_("Language"), 0, parent)
+       : PrefModule(qt_(catLanguage), qt_("Language"), 0, parent)
 {
        setupUi(this);
 
@@ -1621,13 +1651,7 @@ PrefLanguage::PrefLanguage(QWidget * parent)
 
        defaultLanguageCO->clear();
 
-       // store the lang identifiers for later
-       //foreach (LanguagePair const & lpair, languageData(false)) {
-       QList<LanguagePair> l = languageData(false);
-       foreach (LanguagePair const & lpair, l) {
-               defaultLanguageCO->addItem(lpair.first);
-               lang_.append(lpair.second);
-       }
+       defaultLanguageCO->setModel(guiApp->languageModel());
 }
 
 
@@ -1644,7 +1668,8 @@ void PrefLanguage::apply(LyXRC & rc) const
        rc.language_package = fromqstr(languagePackageED->text());
        rc.language_command_begin = fromqstr(startCommandED->text());
        rc.language_command_end = fromqstr(endCommandED->text());
-       rc.default_language = fromqstr(lang_[defaultLanguageCO->currentIndex()]);
+       rc.default_language = fromqstr(
+               defaultLanguageCO->itemData(defaultLanguageCO->currentIndex()).toString());
 }
 
 
@@ -1665,7 +1690,7 @@ void PrefLanguage::update(LyXRC const & rc)
        startCommandED->setText(toqstr(rc.language_command_begin));
        endCommandED->setText(toqstr(rc.language_command_end));
 
-       int const pos = findPos_helper(lang_, toqstr(rc.default_language));
+       int const pos = defaultLanguageCO->findData(toqstr(rc.default_language));
        defaultLanguageCO->setCurrentIndex(pos);
 }
 
@@ -1677,7 +1702,7 @@ void PrefLanguage::update(LyXRC const & rc)
 /////////////////////////////////////////////////////////////////////
 
 PrefPrinter::PrefPrinter(QWidget * parent)
-       : PrefModule(qt_("Printer"), 0, parent)
+       : PrefModule(qt_(catOutput), qt_("Printer"), 0, parent)
 {
        setupUi(this);
 
@@ -1775,7 +1800,7 @@ void PrefPrinter::update(LyXRC const & rc)
 /////////////////////////////////////////////////////////////////////
 
 PrefUserInterface::PrefUserInterface(GuiPreferences * form, QWidget * parent)
-       : PrefModule(qt_("User interface"), form, parent)
+       : PrefModule(qt_(catLookAndFeel), qt_("User interface"), form, parent)
 {
        setupUi(this);
 
@@ -1853,7 +1878,7 @@ void PrefUserInterface::select_ui()
 /////////////////////////////////////////////////////////////////////
 
 PrefEdit::PrefEdit(GuiPreferences * form, QWidget * parent)
-       : PrefModule(qt_("Editing"), form, parent)
+       : PrefModule(qt_(catEditing), qt_("Control"), form, parent)
 {
        setupUi(this);
 
@@ -1925,7 +1950,7 @@ GuiShortcutDialog::GuiShortcutDialog(QWidget * parent) : QDialog(parent)
 
 
 PrefShortcuts::PrefShortcuts(GuiPreferences * form, QWidget * parent)
-       : PrefModule(qt_("Shortcuts"), form, parent)
+       : PrefModule(qt_(catEditing), qt_("Shortcuts"), form, parent)
 {
        setupUi(this);
 
@@ -1935,7 +1960,6 @@ PrefShortcuts::PrefShortcuts(GuiPreferences * form, QWidget * parent)
        shortcutsTW->setSortingEnabled(true);
        // Multi-selection can be annoying.
        // shortcutsTW->setSelectionMode(QAbstractItemView::MultiSelection);
-       shortcutsTW->header()->resizeSection(0, 200);
 
        connect(bindFilePB, SIGNAL(clicked()),
                this, SLOT(select_bind()));
@@ -2008,23 +2032,23 @@ void PrefShortcuts::updateShortcutsTW()
        shortcutsTW->clear();
 
        editItem_ = new QTreeWidgetItem(shortcutsTW);
-       editItem_->setText(0, toqstr("Cursor, Mouse and Editing functions"));
+       editItem_->setText(0, qt_("Cursor, Mouse and Editing functions"));
        editItem_->setFlags(editItem_->flags() & ~Qt::ItemIsSelectable);
 
        mathItem_ = new QTreeWidgetItem(shortcutsTW);
-       mathItem_->setText(0, toqstr("Mathematical Symbols"));
+       mathItem_->setText(0, qt_("Mathematical Symbols"));
        mathItem_->setFlags(mathItem_->flags() & ~Qt::ItemIsSelectable);
        
        bufferItem_ = new QTreeWidgetItem(shortcutsTW);
-       bufferItem_->setText(0, toqstr("Buffer and Window"));
+       bufferItem_->setText(0, qt_("Document and Window"));
        bufferItem_->setFlags(bufferItem_->flags() & ~Qt::ItemIsSelectable);
        
        layoutItem_ = new QTreeWidgetItem(shortcutsTW);
-       layoutItem_->setText(0, toqstr("Font, Layouts and Textclasses"));
+       layoutItem_->setText(0, qt_("Font, Layouts and Textclasses"));
        layoutItem_->setFlags(layoutItem_->flags() & ~Qt::ItemIsSelectable);
 
        systemItem_ = new QTreeWidgetItem(shortcutsTW);
-       systemItem_->setText(0, toqstr("System and Miscellaneous"));
+       systemItem_->setText(0, qt_("System and Miscellaneous"));
        systemItem_->setFlags(systemItem_->flags() & ~Qt::ItemIsSelectable);
 
        // listBindings(unbound=true) lists all bound and unbound lfuns
@@ -2048,6 +2072,9 @@ void PrefShortcuts::updateShortcutsTW()
        shortcutsTW->sortItems(0, Qt::AscendingOrder);
        QList<QTreeWidgetItem*> items = shortcutsTW->selectedItems();
        removePB->setEnabled(!items.isEmpty() && !items[0]->text(1).isEmpty());
+       modifyPB->setEnabled(!items.isEmpty());
+
+       shortcutsTW->resizeColumnToContents(0);
 }
 
 
@@ -2081,11 +2108,11 @@ QTreeWidgetItem * PrefShortcuts::insertShortcutItem(FuncRequest const & lfun,
        FuncCode action = lfun.action;
        string const action_name = lyxaction.getActionName(action);
        QString const lfun_name = toqstr(from_utf8(action_name) 
-                       + " " + lfun.argument());
+                       + ' ' + lfun.argument());
        QString const shortcut = toqstr(seq.print(KeySequence::ForGui));
        item_type item_tag = tag;
 
-       QTreeWidgetItem * newItem = NULL;
+       QTreeWidgetItem * newItem = 0;
        // for unbind items, try to find an existing item in the system bind list
        if (tag == UserUnbind) {
                QList<QTreeWidgetItem*> const items = shortcutsTW->findItems(lfun_name, 
@@ -2100,13 +2127,13 @@ QTreeWidgetItem * PrefShortcuts::insertShortcutItem(FuncRequest const & lfun,
                // unmatched removed?).
                if (!newItem) {
                        item_tag = UserExtraUnbind;
-                       return NULL;
+                       return 0;
                }
        }
        if (!newItem) {
                switch(lyxaction.getActionType(action)) {
                case LyXAction::Hidden:
-                       return NULL;
+                       return 0;
                case LyXAction::Edit:
                        newItem = new QTreeWidgetItem(editItem_);
                        break;
@@ -2141,25 +2168,30 @@ void PrefShortcuts::on_shortcutsTW_itemSelectionChanged()
 {
        QList<QTreeWidgetItem*> items = shortcutsTW->selectedItems();
        removePB->setEnabled(!items.isEmpty() && !items[0]->text(1).isEmpty());
+       modifyPB->setEnabled(!items.isEmpty());
        if (items.isEmpty())
                return;
        
        item_type tag = static_cast<item_type>(items[0]->data(0, Qt::UserRole).toInt());
        if (tag == UserUnbind)
-               removePB->setText(toqstr("Restore"));
+               removePB->setText(qt_("Res&tore"));
        else
-               removePB->setText(toqstr("Remove"));
+               removePB->setText(qt_("Remo&ve"));
 }
 
 
 void PrefShortcuts::on_shortcutsTW_itemDoubleClicked()
+{
+       modifyShortcut();
+}
+
+
+void PrefShortcuts::modifyShortcut()
 {
        QTreeWidgetItem * item = shortcutsTW->currentItem();
        if (item->flags() & Qt::ItemIsSelectable) {
                shortcut_->lfunLE->setText(item->text(0));
-               // clear the shortcut because I assume that a user will enter
-               // a new shortcut.
-               shortcut_->shortcutLE->reset();
+               shortcut_->shortcutLE->setText(item->text(1));
                shortcut_->shortcutLE->setFocus();
                shortcut_->exec();
        }
@@ -2178,6 +2210,12 @@ void PrefShortcuts::select_bind()
 }
 
 
+void PrefShortcuts::on_modifyPB_pressed()
+{
+       modifyShortcut();
+}
+
+
 void PrefShortcuts::on_newPB_pressed()
 {
        shortcut_->lfunLE->clear();
@@ -2203,7 +2241,7 @@ void PrefShortcuts::on_removePB_pressed()
                        // but add an user unbind item
                        user_unbind_.bind(shortcut, func);
                        setItemType(items[i], UserUnbind);
-                       removePB->setText(toqstr("Restore"));
+                       removePB->setText(qt_("Res&tore"));
                        break;
                }
                case UserBind: {
@@ -2223,7 +2261,7 @@ void PrefShortcuts::on_removePB_pressed()
                        // become System again.
                        user_unbind_.unbind(shortcut, func);
                        setItemType(items[i], System);
-                       removePB->setText(toqstr("Remove"));
+                       removePB->setText(qt_("Remo&ve"));
                        break;
                }
                case UserExtraUnbind: {
@@ -2318,7 +2356,7 @@ void PrefShortcuts::shortcut_clearPB_pressed()
 /////////////////////////////////////////////////////////////////////
 
 PrefIdentity::PrefIdentity(QWidget * parent)
-       : PrefModule(qt_("Identity"), 0, parent)
+       : PrefModule(QString(), qt_("Identity"), 0, parent)
 {
        setupUi(this);
 
@@ -2369,6 +2407,7 @@ GuiPreferences::GuiPreferences(GuiView & lv)
        add(new PrefColors(this));
        add(new PrefDisplay);
        add(new PrefInput(this));
+       add(new PrefCompletion(this));
 
        add(new PrefPaths(this));
 
@@ -2406,8 +2445,11 @@ GuiPreferences::GuiPreferences(GuiView & lv)
 
 void GuiPreferences::add(PrefModule * module)
 {
-       BOOST_ASSERT(module);
-       prefsPS->addPanel(module, module->title());
+       LASSERT(module, /**/);
+       if (module->category().isEmpty())
+               prefsPS->addPanel(module, module->title());
+       else
+               prefsPS->addPanel(module, module->title(), module->category());
        connect(module, SIGNAL(changed()), this, SLOT(change_adaptor()));
        modules_.push_back(module);
 }
@@ -2510,42 +2552,35 @@ void GuiPreferences::updateScreenFonts()
 QString GuiPreferences::browsebind(QString const & file) const
 {
        return browseLibFile("bind", file, "bind", qt_("Choose bind file"),
-                            FileFilterList(_("LyX bind files (*.bind)")));
+                            QStringList(qt_("LyX bind files (*.bind)")));
 }
 
 
 QString GuiPreferences::browseUI(QString const & file) const
 {
        return browseLibFile("ui", file, "ui", qt_("Choose UI file"),
-                            FileFilterList(_("LyX UI files (*.ui)")));
+                            QStringList(qt_("LyX UI files (*.ui)")));
 }
 
 
 QString GuiPreferences::browsekbmap(QString const & file) const
 {
        return browseLibFile("kbd", file, "kmap", qt_("Choose keyboard map"),
-                            FileFilterList(_("LyX keyboard maps (*.kmap)")));
+                            QStringList(qt_("LyX keyboard maps (*.kmap)")));
 }
 
 
 QString GuiPreferences::browsedict(QString const & file) const
 {
        return browseFile(file, qt_("Choose personal dictionary"),
-               FileFilterList(lyxrc.use_spell_lib ? _("*.pws") : _("*.ispell")));
+               QStringList(lyxrc.use_spell_lib ? qt_("*.pws") : qt_("*.ispell")));
 }
 
 
 QString GuiPreferences::browse(QString const & file,
                                  QString const & title) const
 {
-       return browseFile(file, title, FileFilterList(), true);
-}
-
-
-QString GuiPreferences::browsedir(QString const & path,
-                                    QString const & title) const
-{
-       return browseDir(path, title);
+       return browseFile(file, title, QStringList(), true);
 }