]> git.lyx.org Git - lyx.git/blobdiff - src/frontends/qt4/GuiPrefs.cpp
header cleanup
[lyx.git] / src / frontends / qt4 / GuiPrefs.cpp
index 4a957c7dcc6deb00e68a739e3c3db4e4bf8f0217..290089b3f1bf080d999dfbfe5710e1b5510905e3 100644 (file)
@@ -20,9 +20,9 @@
 #include "BufferList.h"
 #include "Color.h"
 #include "ConverterCache.h"
-#include "debug.h"
+#include "support/debug.h"
 #include "FuncRequest.h"
-#include "gettext.h"
+#include "support/gettext.h"
 #include "GuiFontExample.h"
 #include "GuiKeySymbol.h"
 #include "KeyMap.h"
 #include "support/FileName.h"
 #include "support/filetools.h"
 #include "support/lstrings.h"
-#include "support/lyxlib.h"
 #include "support/os.h"
 #include "support/Package.h"
 #include "support/FileFilterList.h"
 
 #include "graphics/GraphicsTypes.h"
 
-#include "frontend_helpers.h"
-
 #include "frontends/alert.h"
 #include "frontends/Application.h"
 
 #include <QTreeWidget>
 #include <QTreeWidgetItem>
 #include <QValidator>
-#include <QCloseEvent>
 
 #include <iomanip>
 #include <sstream>
 #include <algorithm>
-#include <utility>
 
 using namespace Ui;
 
-using std::endl;
-using std::ostringstream;
-using std::pair;
-using std::string;
-using std::vector;
+using namespace std;
+using namespace lyx::support;
+using namespace lyx::support::os;
 
 namespace lyx {
 namespace frontend {
 
-using support::compare_ascii_no_case;
-using support::os::external_path;
-using support::os::external_path_list;
-using support::os::internal_path;
-using support::os::internal_path_list;
-using support::FileName;
-using support::FileFilterList;
-using support::addPath;
-using support::addName;
-using support::mkdir;
-using support::package;
-
 
 /////////////////////////////////////////////////////////////////////
 //
@@ -97,24 +78,29 @@ using support::package;
 /////////////////////////////////////////////////////////////////////
 
 template<class A>
-static size_t findPos_helper(std::vector<A> const & vec, A const & val)
+static size_t findPos_helper(vector<A> const & vec, A const & val)
 {
-       typedef typename std::vector<A>::const_iterator Cit;
+       typedef typename vector<A>::const_iterator Cit;
 
-       Cit it = std::find(vec.begin(), vec.end(), val);
+       Cit it = find(vec.begin(), vec.end(), val);
        if (it == vec.end())
                return 0;
-       return std::distance(vec.begin(), it);
+       return distance(vec.begin(), it);
 }
 
 
-static std::pair<string, string> parseFontName(string const & name)
+static void parseFontName(QString const & mangled0,
+       string & name, string & foundry)
 {
-       string::size_type const idx = name.find('[');
-       if (idx == string::npos || idx == 0)
-               return make_pair(name, string());
-       return make_pair(name.substr(0, idx - 1),
-                        name.substr(idx + 1, name.size() - idx - 2));
+       string mangled = fromqstr(mangled0);
+       size_t const idx = mangled.find('[');
+       if (idx == string::npos || idx == 0) {
+               name = mangled;
+               foundry.clear();
+       } else {
+               name = mangled.substr(0, idx - 1),
+               foundry = mangled.substr(idx + 1, mangled.size() - idx - 2);
+       }
 }
 
 
@@ -136,20 +122,23 @@ static void setComboxFont(QComboBox * cb, string const & family,
 
        // We count in reverse in order to prefer the Xft foundry
        for (int i = cb->count(); --i >= 0;) {
-               pair<string, string> tmp = parseFontName(fromqstr(cb->itemText(i)));
-               if (compare_ascii_no_case(tmp.first, family) == 0) {
+               string name, foundry;
+               parseFontName(cb->itemText(i), name, foundry);
+               if (compare_ascii_no_case(name, family) == 0) {
                        cb->setCurrentIndex(i);
                        return;
                }
        }
 
        // family alone can contain e.g. "Helvetica [Adobe]"
-       pair<string, string> tmpfam = parseFontName(family);
+       string tmpname, tmpfoundry;
+       parseFontName(toqstr(family), tmpname, tmpfoundry);
 
        // We count in reverse in order to prefer the Xft foundry
-       for (int i = cb->count() - 1; i >= 0; --i) {
-               pair<string, string> tmp = parseFontName(fromqstr(cb->itemText(i)));
-               if (compare_ascii_no_case(tmp.first, tmpfam.first) == 0) {
+       for (int i = cb->count(); --i >= 0; ) {
+               string name, foundry;
+               parseFontName(cb->itemText(i), name, foundry);
+               if (compare_ascii_no_case(name, foundry) == 0) {
                        cb->setCurrentIndex(i);
                        return;
                }
@@ -161,15 +150,16 @@ static void setComboxFont(QComboBox * cb, string const & family,
        QFont font;
        font.setKerning(false);
 
-       if (family == theApp()->romanFontName()) {
+       QString const font_family = toqstr(family);
+       if (font_family == guiApp->romanFontName()) {
                font.setStyleHint(QFont::Serif);
-               font.setFamily(family.c_str());
-       } else if (family == theApp()->sansFontName()) {
+               font.setFamily(font_family);
+       } else if (font_family == guiApp->sansFontName()) {
                font.setStyleHint(QFont::SansSerif);
-               font.setFamily(family.c_str());
-       } else if (family == theApp()->typewriterFontName()) {
+               font.setFamily(font_family);
+       } else if (font_family == guiApp->typewriterFontName()) {
                font.setStyleHint(QFont::TypeWriter);
-               font.setFamily(family.c_str());
+               font.setFamily(font_family);
        } else {
                lyxerr << "FAILED to find the default font: '"
                       << foundry << "', '" << family << '\''<< endl;
@@ -177,8 +167,8 @@ static void setComboxFont(QComboBox * cb, string const & family,
        }
 
        QFontInfo info(font);
-       pair<string, string> tmp = parseFontName(fromqstr(info.family()));
-       string const & default_font_name = tmp.first;
+       string default_font_name, dummyfoundry;
+       parseFontName(info.family(), default_font_name, dummyfoundry);
        lyxerr << "Apparent font is " << default_font_name << endl;
 
        for (int i = 0; i < cb->count(); ++i) {
@@ -255,12 +245,12 @@ void PrefDate::update(LyXRC const & rc)
 
 /////////////////////////////////////////////////////////////////////
 //
-// PrefKeyboard
+// PrefInput
 //
 /////////////////////////////////////////////////////////////////////
 
-PrefKeyboard::PrefKeyboard(GuiPreferences * form, QWidget * parent)
-       : PrefModule(_("Keyboard"), form, parent)
+PrefInput::PrefInput(GuiPreferences * form, QWidget * parent)
+       : PrefModule(_("Keyboard/Mouse"), form, parent)
 {
        setupUi(this);
 
@@ -270,34 +260,38 @@ PrefKeyboard::PrefKeyboard(GuiPreferences * form, QWidget * parent)
                this, SIGNAL(changed()));
        connect(secondKeymapED, SIGNAL(textChanged(QString)),
                this, SIGNAL(changed()));
+       connect(mouseWheelSpeedSB, SIGNAL(valueChanged(double)),
+               this, SIGNAL(changed()));
 }
 
 
-void PrefKeyboard::apply(LyXRC & rc) const
+void PrefInput::apply(LyXRC & rc) const
 {
        // FIXME: can derive CB from the two EDs
        rc.use_kbmap = keymapCB->isChecked();
        rc.primary_kbmap = internal_path(fromqstr(firstKeymapED->text()));
        rc.secondary_kbmap = internal_path(fromqstr(secondKeymapED->text()));
+       rc.mouse_wheel_speed = mouseWheelSpeedSB->value();
 }
 
 
-void PrefKeyboard::update(LyXRC const & rc)
+void PrefInput::update(LyXRC const & rc)
 {
        // FIXME: can derive CB from the two EDs
        keymapCB->setChecked(rc.use_kbmap);
        firstKeymapED->setText(toqstr(external_path(rc.primary_kbmap)));
        secondKeymapED->setText(toqstr(external_path(rc.secondary_kbmap)));
+       mouseWheelSpeedSB->setValue(rc.mouse_wheel_speed);
 }
 
 
-QString PrefKeyboard::testKeymap(QString keymap)
+QString PrefInput::testKeymap(QString keymap)
 {
        return toqstr(form_->browsekbmap(from_utf8(internal_path(fromqstr(keymap)))));
 }
 
 
-void PrefKeyboard::on_firstKeymapPB_clicked(bool)
+void PrefInput::on_firstKeymapPB_clicked(bool)
 {
        QString const file = testKeymap(firstKeymapED->text());
        if (!file.isEmpty())
@@ -305,7 +299,7 @@ void PrefKeyboard::on_firstKeymapPB_clicked(bool)
 }
 
 
-void PrefKeyboard::on_secondKeymapPB_clicked(bool)
+void PrefInput::on_secondKeymapPB_clicked(bool)
 {
        QString const file = testKeymap(secondKeymapED->text());
        if (!file.isEmpty())
@@ -313,7 +307,7 @@ void PrefKeyboard::on_secondKeymapPB_clicked(bool)
 }
 
 
-void PrefKeyboard::on_keymapCB_toggled(bool keymap)
+void PrefInput::on_keymapCB_toggled(bool keymap)
 {
        firstKeymapLA->setEnabled(keymap);
        secondKeymapLA->setEnabled(keymap);
@@ -446,6 +440,8 @@ PrefScreenFonts::PrefScreenFonts(GuiPreferences * form, QWidget * parent)
                this, SIGNAL(changed()));
        connect(screenHugerED, SIGNAL(textChanged(QString)),
                this, SIGNAL(changed()));
+       connect(pixmapCacheCB, SIGNAL(toggled(bool)),
+               this, SIGNAL(changed()));
 
        screenTinyED->setValidator(new QDoubleValidator(screenTinyED));
        screenSmallestED->setValidator(new QDoubleValidator(screenSmallestED));
@@ -464,12 +460,12 @@ void PrefScreenFonts::apply(LyXRC & rc) const
 {
        LyXRC const oldrc = rc;
 
-       boost::tie(rc.roman_font_name, rc.roman_font_foundry)
-               = parseFontName(fromqstr(screenRomanCO->currentText()));
-       boost::tie(rc.sans_font_name, rc.sans_font_foundry) =
-               parseFontName(fromqstr(screenSansCO->currentText()));
-       boost::tie(rc.typewriter_font_name, rc.typewriter_font_foundry) =
-               parseFontName(fromqstr(screenTypewriterCO->currentText()));
+       parseFontName(screenRomanCO->currentText(),
+               rc.roman_font_name, rc.roman_font_foundry);
+       parseFontName(screenSansCO->currentText(),
+               rc.sans_font_name, rc.sans_font_foundry);
+       parseFontName(screenTypewriterCO->currentText(),
+               rc.typewriter_font_name, rc.typewriter_font_foundry);
 
        rc.zoom = screenZoomSB->value();
        rc.dpi = screenDpiSB->value();
@@ -483,6 +479,7 @@ void PrefScreenFonts::apply(LyXRC & rc) const
        rc.font_sizes[FONT_SIZE_LARGEST] = fromqstr(screenLargestED->text());
        rc.font_sizes[FONT_SIZE_HUGE] = fromqstr(screenHugeED->text());
        rc.font_sizes[FONT_SIZE_HUGER] = fromqstr(screenHugerED->text());
+       rc.use_pixmap_cache = pixmapCacheCB->isChecked();
 
        if (rc.font_sizes != oldrc.font_sizes
                || rc.roman_font_name != oldrc.roman_font_name
@@ -524,6 +521,12 @@ void PrefScreenFonts::update(LyXRC const & rc)
        screenLargestED->setText(toqstr(rc.font_sizes[FONT_SIZE_LARGEST]));
        screenHugeED->setText(toqstr(rc.font_sizes[FONT_SIZE_HUGE]));
        screenHugerED->setText(toqstr(rc.font_sizes[FONT_SIZE_HUGER]));
+
+       pixmapCacheCB->setChecked(rc.use_pixmap_cache);
+#if defined(Q_WS_X11)
+       pixmapCacheCB->setEnabled(false);
+#endif
+       
 }
 
 
@@ -587,7 +590,7 @@ PrefColors::PrefColors(GuiPreferences * form, QWidget * parent)
 
                lcolors_.push_back(lc);
        }
-       std::sort(lcolors_.begin(), lcolors_.end(), ColorSorter());
+       sort(lcolors_.begin(), lcolors_.end(), ColorSorter());
        vector<ColorCode>::const_iterator cit = lcolors_.begin();
        vector<ColorCode>::const_iterator const end = lcolors_.end();
        for (; cit != end; ++cit) {
@@ -679,7 +682,7 @@ void PrefDisplay::apply(LyXRC & rc) const
                case 2: rc.preview = LyXRC::PREVIEW_ON; break;
        }
 
-       lyx::graphics::DisplayType dtype;
+       graphics::DisplayType dtype;
        switch (displayGraphicsCO->currentIndex()) {
                case 3: dtype = graphics::NoDisplay; break;
                case 2: dtype = graphics::ColorDisplay; break;
@@ -735,6 +738,7 @@ PrefPaths::PrefPaths(GuiPreferences * form, QWidget * parent)
        : PrefModule(_("Paths"), form, parent)
 {
        setupUi(this);
+       connect(exampleDirPB, SIGNAL(clicked()), this, SLOT(select_exampledir()));
        connect(templateDirPB, SIGNAL(clicked()), this, SLOT(select_templatedir()));
        connect(tempDirPB, SIGNAL(clicked()), this, SLOT(select_tempdir()));
        connect(backupDirPB, SIGNAL(clicked()), this, SLOT(select_backupdir()));
@@ -742,6 +746,8 @@ PrefPaths::PrefPaths(GuiPreferences * form, QWidget * parent)
        connect(lyxserverDirPB, SIGNAL(clicked()), this, SLOT(select_lyxpipe()));
        connect(workingDirED, SIGNAL(textChanged(QString)),
                this, SIGNAL(changed()));
+       connect(exampleDirED, SIGNAL(textChanged(QString)),
+               this, SIGNAL(changed()));
        connect(templateDirED, SIGNAL(textChanged(QString)),
                this, SIGNAL(changed()));
        connect(backupDirED, SIGNAL(textChanged(QString)),
@@ -758,6 +764,7 @@ PrefPaths::PrefPaths(GuiPreferences * form, QWidget * parent)
 void PrefPaths::apply(LyXRC & rc) const
 {
        rc.document_path = internal_path(fromqstr(workingDirED->text()));
+       rc.example_path = internal_path(fromqstr(exampleDirED->text()));
        rc.template_path = internal_path(fromqstr(templateDirED->text()));
        rc.backupdir_path = internal_path(fromqstr(backupDirED->text()));
        rc.tempdir_path = internal_path(fromqstr(tempDirED->text()));
@@ -770,6 +777,7 @@ void PrefPaths::apply(LyXRC & rc) const
 void PrefPaths::update(LyXRC const & rc)
 {
        workingDirED->setText(toqstr(external_path(rc.document_path)));
+       exampleDirED->setText(toqstr(external_path(rc.example_path)));
        templateDirED->setText(toqstr(external_path(rc.template_path)));
        backupDirED->setText(toqstr(external_path(rc.backupdir_path)));
        tempDirED->setText(toqstr(external_path(rc.tempdir_path)));
@@ -779,6 +787,16 @@ void PrefPaths::update(LyXRC const & rc)
 }
 
 
+void PrefPaths::select_exampledir()
+{
+       docstring file(form_->browsedir(
+               from_utf8(internal_path(fromqstr(exampleDirED->text()))),
+               _("Select directory for example files")));
+       if (!file.empty())
+               exampleDirED->setText(toqstr(file));
+}
+
+
 void PrefPaths::select_templatedir()
 {
        docstring file(form_->browsedir(
@@ -1023,7 +1041,7 @@ void PrefConverters::updateGui()
        Converters::const_iterator ccit = form_->converters().begin();
        Converters::const_iterator cend = form_->converters().end();
        for (; ccit != cend; ++ccit) {
-               std::string const name =
+               string const name =
                        ccit->From->prettyname() + " -> " + ccit->To->prettyname();
                int type = form_->converters().getNumber(ccit->From->name(), ccit->To->name());
                new QListWidgetItem(toqstr(name), convertersLW, type);
@@ -1197,7 +1215,7 @@ FormatNameValidator::FormatNameValidator(QWidget * parent, Formats const & f)
 {
 }
 
-std::string FormatNameValidator::str(Formats::const_iterator it) const
+string FormatNameValidator::str(Formats::const_iterator it) const
 {
        return it->name();
 }
@@ -1209,7 +1227,7 @@ FormatPrettynameValidator::FormatPrettynameValidator(QWidget * parent, Formats c
 }
 
 
-std::string FormatPrettynameValidator::str(Formats::const_iterator it) const
+string FormatPrettynameValidator::str(Formats::const_iterator it) const
 {
        return it->prettyname();
 }
@@ -1419,7 +1437,11 @@ PrefLanguage::PrefLanguage(QWidget * parent)
 {
        setupUi(this);
 
-       connect(rtlCB, SIGNAL(clicked()),
+       connect(rtlGB, SIGNAL(clicked()),
+               this, SIGNAL(changed()));
+       connect(visualCursorRB, SIGNAL(clicked()),
+               this, SIGNAL(changed()));
+       connect(logicalCursorRB, SIGNAL(clicked()),
                this, SIGNAL(changed()));
        connect(markForeignCB, SIGNAL(clicked()),
                this, SIGNAL(changed()));
@@ -1443,9 +1465,9 @@ PrefLanguage::PrefLanguage(QWidget * parent)
        defaultLanguageCO->clear();
 
        // store the lang identifiers for later
-       std::vector<LanguagePair> const langs = frontend::getLanguageData(false);
-       std::vector<LanguagePair>::const_iterator lit  = langs.begin();
-       std::vector<LanguagePair>::const_iterator lend = langs.end();
+       vector<LanguagePair> const langs = getLanguageData(false);
+       vector<LanguagePair>::const_iterator lit  = langs.begin();
+       vector<LanguagePair>::const_iterator lend = langs.end();
        lang_.clear();
        for (; lit != lend; ++lit) {
                defaultLanguageCO->addItem(toqstr(lit->first));
@@ -1457,7 +1479,8 @@ PrefLanguage::PrefLanguage(QWidget * parent)
 void PrefLanguage::apply(LyXRC & rc) const
 {
        // FIXME: remove rtl_support bool
-       rc.rtl_support = rtlCB->isChecked();
+       rc.rtl_support = rtlGB->isChecked();
+       rc.visual_cursor = rtlGB->isChecked() && visualCursorRB->isChecked();
        rc.mark_foreign_language = markForeignCB->isChecked();
        rc.language_auto_begin = autoBeginCB->isChecked();
        rc.language_auto_end = autoEndCB->isChecked();
@@ -1473,7 +1496,11 @@ void PrefLanguage::apply(LyXRC & rc) const
 void PrefLanguage::update(LyXRC const & rc)
 {
        // FIXME: remove rtl_support bool
-       rtlCB->setChecked(rc.rtl_support);
+       rtlGB->setChecked(rc.rtl_support);
+       if (rc.visual_cursor)
+               visualCursorRB->setChecked(true);
+       else
+               logicalCursorRB->setChecked(true);
        markForeignCB->setChecked(rc.mark_foreign_language);
        autoBeginCB->setChecked(rc.language_auto_begin);
        autoEndCB->setChecked(rc.language_auto_end);
@@ -1609,15 +1636,13 @@ PrefUserInterface::PrefUserInterface(GuiPreferences * form, QWidget * parent)
                this, SIGNAL(changed()));
        connect(loadSessionCB, SIGNAL(clicked()),
                this, SIGNAL(changed()));
-       connect(loadWindowSizeCB, SIGNAL(clicked()),
-               this, SIGNAL(changed()));
-       connect(loadWindowLocationCB, SIGNAL(clicked()),
+       connect(allowGeometrySessionCB, SIGNAL(clicked()),
                this, SIGNAL(changed()));
-       connect(windowWidthSB, SIGNAL(valueChanged(int)),
+       connect(cursorFollowsCB, SIGNAL(clicked()),
                this, SIGNAL(changed()));
-       connect(windowHeightSB, SIGNAL(valueChanged(int)),
+       connect(sortEnvironmentsCB, SIGNAL(clicked()),
                this, SIGNAL(changed()));
-       connect(cursorFollowsCB, SIGNAL(clicked()),
+       connect(macroEditStyleCO, SIGNAL(activated(int)),
                this, SIGNAL(changed()));
        connect(autoSaveSB, SIGNAL(valueChanged(int)),
                this, SIGNAL(changed()));
@@ -1625,6 +1650,8 @@ PrefUserInterface::PrefUserInterface(GuiPreferences * form, QWidget * parent)
                this, SIGNAL(changed()));
        connect(lastfilesSB, SIGNAL(valueChanged(int)),
                this, SIGNAL(changed()));
+       connect(tooltipCB, SIGNAL(toggled(bool)),
+               this, SIGNAL(changed()));
        lastfilesSB->setMaximum(maxlastfiles);
 }
 
@@ -1634,18 +1661,18 @@ void PrefUserInterface::apply(LyXRC & rc) const
        rc.ui_file = internal_path(fromqstr(uiFileED->text()));
        rc.use_lastfilepos = restoreCursorCB->isChecked();
        rc.load_session = loadSessionCB->isChecked();
-       if (loadWindowSizeCB->isChecked()) {
-               rc.geometry_width = 0;
-               rc.geometry_height = 0;
-       } else {
-               rc.geometry_width = windowWidthSB->value();
-               rc.geometry_height = windowHeightSB->value();
-       }
-       rc.geometry_xysaved = loadWindowLocationCB->isChecked();
+       rc.allow_geometry_session = allowGeometrySessionCB->isChecked();
        rc.cursor_follows_scrollbar = cursorFollowsCB->isChecked();
+       rc.sort_layouts = sortEnvironmentsCB->isChecked();
+       switch (macroEditStyleCO->currentIndex()) {
+               case 0: rc.macro_edit_style = LyXRC::MACRO_EDIT_INLINE_BOX; break;
+               case 1: rc.macro_edit_style = LyXRC::MACRO_EDIT_INLINE; break;
+               case 2: rc.macro_edit_style = LyXRC::MACRO_EDIT_LIST;   break;
+       }
        rc.autosave = autoSaveSB->value() * 60;
        rc.make_backup = autoSaveCB->isChecked();
        rc.num_lastfiles = lastfilesSB->value();
+       rc.use_tooltip = tooltipCB->isChecked();
 }
 
 
@@ -1654,14 +1681,10 @@ void PrefUserInterface::update(LyXRC const & rc)
        uiFileED->setText(toqstr(external_path(rc.ui_file)));
        restoreCursorCB->setChecked(rc.use_lastfilepos);
        loadSessionCB->setChecked(rc.load_session);
-       bool loadWindowSize = rc.geometry_width == 0 && rc.geometry_height == 0;
-       loadWindowSizeCB->setChecked(loadWindowSize);
-       if (!loadWindowSize) {
-               windowWidthSB->setValue(rc.geometry_width);
-               windowHeightSB->setValue(rc.geometry_height);
-       }
-       loadWindowLocationCB->setChecked(rc.geometry_xysaved);
+       allowGeometrySessionCB->setChecked(rc.allow_geometry_session);
        cursorFollowsCB->setChecked(rc.cursor_follows_scrollbar);
+       sortEnvironmentsCB->setChecked(rc.sort_layouts);
+       macroEditStyleCO->setCurrentIndex(rc.macro_edit_style);
        // convert to minutes
        int mins(rc.autosave / 60);
        if (rc.autosave && !mins)
@@ -1669,6 +1692,7 @@ void PrefUserInterface::update(LyXRC const & rc)
        autoSaveSB->setValue(mins);
        autoSaveCB->setChecked(rc.make_backup);
        lastfilesSB->setValue(rc.num_lastfiles);
+       tooltipCB->setChecked(rc.use_tooltip);
 }
 
 
@@ -1682,15 +1706,6 @@ void PrefUserInterface::select_ui()
 }
 
 
-void PrefUserInterface::on_loadWindowSizeCB_toggled(bool loadwindowsize)
-{
-       windowWidthLA->setDisabled(loadwindowsize);
-       windowHeightLA->setDisabled(loadwindowsize);
-       windowWidthSB->setDisabled(loadwindowsize);
-       windowHeightSB->setDisabled(loadwindowsize);
-}
-
-
 /////////////////////////////////////////////////////////////////////
 //
 // PrefShortcuts
@@ -1710,10 +1725,9 @@ PrefShortcuts::PrefShortcuts(GuiPreferences * form, QWidget * parent)
 {
        setupUi(this);
 
-       shortcutsTW->setColumnCount(3);
+       shortcutsTW->setColumnCount(2);
        shortcutsTW->headerItem()->setText(0, qt_("Function"));
        shortcutsTW->headerItem()->setText(1, qt_("Shortcut"));
-       shortcutsTW->headerItem()->setText(2, qt_("Type"));
        shortcutsTW->setSortingEnabled(true);
        // Multi-selection can be annoying.
        // shortcutsTW->setSelectionMode(QAbstractItemView::MultiSelection);
@@ -1748,18 +1762,18 @@ void PrefShortcuts::apply(LyXRC & rc) const
 {
        rc.bind_file = internal_path(fromqstr(bindFileED->text()));
        // write user_bind and user_unbind to .lyx/bind/user.bind
-       string bind_dir = addPath(package().user_support().absFilename(), "bind");
-       if (!FileName(bind_dir).exists() && mkdir(FileName(bind_dir), 0777)) {
+       FileName bind_dir(addPath(package().user_support().absFilename(), "bind"));
+       if (!bind_dir.exists() && !bind_dir.createDirectory(0777)) {
                lyxerr << "LyX could not create the user bind directory '"
                       << bind_dir << "'. All user-defined key bindings will be lost." << endl;
                return;
        }
-       if (!FileName(bind_dir).isDirWritable()) {
+       if (!bind_dir.isDirWritable()) {
                lyxerr << "LyX could not write to the user bind directory '"
                       << bind_dir << "'. All user-defined key bindings will be lost." << endl;
                return;
        }
-       FileName user_bind_file = FileName(addName(bind_dir, "user.bind"));
+       FileName user_bind_file(bind_dir.absFilename() + "/user.bind");
        user_bind_.write(user_bind_file.toFilesystemEncoding(), false, false);
        user_unbind_.write(user_bind_file.toFilesystemEncoding(), true, true);
        // immediately apply the keybindings. Why this is not done before?
@@ -1825,8 +1839,7 @@ void PrefShortcuts::updateShortcutsTW()
        KeyMap::BindingList::const_iterator it = bindinglist.begin();
        KeyMap::BindingList::const_iterator it_end = bindinglist.end();
        for (; it != it_end; ++it)
-               insertShortcutItem(it->get<0>(), it->get<1>(), 
-                       static_cast<item_type>(it->get<2>()));
+               insertShortcutItem(it->request, it->sequence, item_type(it->tag));
 
        shortcutsTW->sortItems(0, Qt::AscendingOrder);
        QList<QTreeWidgetItem*> items = shortcutsTW->selectedItems();
@@ -1837,33 +1850,24 @@ void PrefShortcuts::updateShortcutsTW()
 void PrefShortcuts::setItemType(QTreeWidgetItem * item, item_type tag)
 {
        item->setData(0, Qt::UserRole, QVariant(tag));
-       QString color;
+       QFont font;
 
        switch (tag) {
        case System:
-               color = "black";
-               item->setText(2, "System shortcut");
                break;
        case UserBind:
-               color = "green";
-               item->setText(2, "User defined shortcut");
+               font.setBold(true);
                break;
        case UserUnbind:
-               color = "red";
-               item->setText(2, "Removed system shortcut");
+               font.setStrikeOut(true);
                break;
+       // this item is not displayed now.
        case UserExtraUnbind:
-               color = "purple";
-               item->setText(2, "Unmatched removed system shortcut");
+               font.setStrikeOut(true);
                break;
        }
 
-       for (int col = 0; col < shortcutsTW->columnCount(); ++col) 
-#if QT_VERSION >= 0x040200
-               item->setForeground(col, QBrush(QColor(color)));
-#else
-               item->setTextColor(col, QColor(color));
-#endif
+       item->setFont(1, font);
 }
 
 
@@ -1923,7 +1927,7 @@ QTreeWidgetItem * PrefShortcuts::insertShortcutItem(FuncRequest const & lfun,
        newItem->setText(0, lfun_name);
        newItem->setText(1, shortcut);
        // record BindFile representation to recover KeySequence when needed.
-       newItem->setData(1, Qt::UserRole, QVariant(toqstr(seq.print(KeySequence::BindFile))));
+       newItem->setData(1, Qt::UserRole, toqstr(seq.print(KeySequence::BindFile)));
        setItemType(newItem, item_tag);
        return newItem;
 }
@@ -1997,12 +2001,18 @@ void PrefShortcuts::on_removePB_pressed()
                        // but add an user unbind item
                        user_unbind_.bind(shortcut, func);
                        setItemType(items[i], UserUnbind);
+                       removePB->setText(toqstr("Restore"));
                        break;
                }
                case UserBind: {
                        // for user_bind, we remove this bind
                        QTreeWidgetItem * parent = items[i]->parent();
-                       parent->takeChild(parent->indexOfChild(items[i]));
+                       int itemIdx = parent->indexOfChild(items[i]);
+                       parent->takeChild(itemIdx);
+                       if (itemIdx > 0)
+                               shortcutsTW->scrollToItem(parent->child(itemIdx - 1));
+                       else
+                               shortcutsTW->scrollToItem(parent);
                        user_bind_.unbind(shortcut, func);
                        break;
                }
@@ -2011,6 +2021,7 @@ void PrefShortcuts::on_removePB_pressed()
                        // become System again.
                        user_unbind_.unbind(shortcut, func);
                        setItemType(items[i], System);
+                       removePB->setText(toqstr("Remove"));
                        break;
                }
                case UserExtraUnbind: {
@@ -2073,7 +2084,7 @@ void PrefShortcuts::shortcut_okPB_pressed()
        // if both lfun and shortcut is valid
        if (user_bind_.hasBinding(k, func) || system_bind_.hasBinding(k, func)) {
                Alert::error(_("Failed to create shortcut"),
-                       _("Shortcut is alreay defined"));
+                       _("Shortcut is already defined"));
                return;
        }
                
@@ -2137,11 +2148,10 @@ void PrefIdentity::update(LyXRC const & rc)
 //
 /////////////////////////////////////////////////////////////////////
 
-GuiPreferences::GuiPreferences(LyXView & lv)
-       : GuiDialog(lv, "prefs"), update_screen_font_(false)
+GuiPreferences::GuiPreferences(GuiView & lv)
+       : GuiDialog(lv, "prefs", qt_("Preferences")), update_screen_font_(false)
 {
        setupUi(this);
-       setViewTitle(_("Preferences"));
 
        QDialog::setModal(false);
 
@@ -2155,7 +2165,7 @@ GuiPreferences::GuiPreferences(LyXView & lv)
        add(new PrefScreenFonts(this));
        add(new PrefColors(this));
        add(new PrefDisplay);
-       add(new PrefKeyboard(this));
+       add(new PrefInput(this));
 
        add(new PrefPaths(this));
 
@@ -2200,13 +2210,6 @@ void GuiPreferences::add(PrefModule * module)
 }
 
 
-void GuiPreferences::closeEvent(QCloseEvent * e)
-{
-       slotClose();
-       e->accept();
-}
-
-
 void GuiPreferences::change_adaptor()
 {
        changed();
@@ -2241,7 +2244,7 @@ void GuiPreferences::updateContents()
 }
 
 
-bool GuiPreferences::initialiseParams(std::string const &)
+bool GuiPreferences::initialiseParams(string const &)
 {
        rc_ = lyxrc;
        formats_ = lyx::formats;
@@ -2406,7 +2409,7 @@ int GuiPreferences::fromPaperSize(PAPER_SIZE papersize) const
 }
 
 
-Dialog * createGuiPreferences(LyXView & lv) { return new GuiPreferences(lv); }
+Dialog * createGuiPreferences(GuiView & lv) { return new GuiPreferences(lv); }
 
 
 } // namespace frontend