Some comments wrt log file encoding (#10728)

[features.git] / src / frontends / qt4 / GuiLog.cpp

diff --git a/src/frontends/qt4/GuiLog.cpp b/src/frontends/qt4/GuiLog.cpp
index 97e19e353692c6bc888e226a0c09fb37da3214bd..1f4bb459378dd82d5268fa8f39719489d06e9967 100644 (file)
--- a/src/frontends/qt4/GuiLog.cpp
+++ b/src/frontends/qt4/GuiLog.cpp
@@ -237,9 +237,9 @@ bool GuiLog::initialiseParams(string const & data)
 
        logTypeCO->setEnabled(logtype == "latex");
        logTypeCO->clear();
-       
+
        FileName log(logfile);
-       
+
        if (logtype == "latex") {
                type_ = LatexLog;
                logTypeCO->addItem(qt_("LaTeX"), toqstr(logtype));
@@ -307,6 +307,8 @@ void GuiLog::getContents(ostream & ss) const
        // FIXME UNICODE
        // Our caller interprets the file contents as UTF8, but is that
        // correct?
+       // spitz: No it isn't (generally). The log file encoding depends on the TeX
+       // _output_ encoding (T1 etc.). We should account for that. See #10728.
        if (in) {
                ss << in.rdbuf();
                success = ss.good();