Add clarifying comment

[lyx.git] / src / frontends / qt4 / GuiFontMetrics.cpp

diff --git a/src/frontends/qt4/GuiFontMetrics.cpp b/src/frontends/qt4/GuiFontMetrics.cpp
index a0fa6998ab109070293ce1782ff2ebf965d42187..2ab182ec33aef23aaae29fb47facd24b0d527181 100644 (file)
--- a/src/frontends/qt4/GuiFontMetrics.cpp
+++ b/src/frontends/qt4/GuiFontMetrics.cpp
@@ -182,17 +182,29 @@ int GuiFontMetrics::width(docstring const & s) const
        int * pw = strwidth_cache_[s];
        if (pw)
                return *pw;
-       // For some reason QMetrics::width returns a wrong value with Qt5
-       // int w = metrics_.width(toqstr(s));
        PROFILE_CACHE_MISS(width)
 #endif
-       QTextLayout tl;
-       tl.setText(toqstr(s));
-       tl.setFont(font_);
-       tl.beginLayout();
-       QTextLine line = tl.createLine();
-       tl.endLayout();
-       int w = int(line.naturalTextWidth());
+       /* For some reason QMetrics::width returns a wrong value with Qt5
+        * with some arabic text. OTOH, QTextLayout is broken for single
+        * characters with null width (like \not in mathed). Also, as a
+        * safety measure, always use QMetrics::width with our math fonts.
+       */
+       int w = 0;
+       if (s.length() == 1
+#if QT_VERSION >= 0x040800
+           || font_.styleName() == "LyX"
+#endif
+           )
+               w = metrics_.width(toqstr(s));
+       else {
+               QTextLayout tl;
+               tl.setText(toqstr(s));
+               tl.setFont(font_);
+               tl.beginLayout();
+               QTextLine line = tl.createLine();
+               tl.endLayout();
+               w = int(line.naturalTextWidth());
+       }
 #ifdef CACHE_METRICS_WIDTH
        strwidth_cache_.insert(s, new int(w), s.size() * sizeof(char_type));
 #endif