]> git.lyx.org Git - lyx.git/blobdiff - src/frontends/qt4/GuiDocument.cpp
If we are in a closeEvent, we don't want to close all buffers, because these may...
[lyx.git] / src / frontends / qt4 / GuiDocument.cpp
index 671a1dc5d8e1cd4afd323ca727888183bf88b631..6b3acb422c7569593475a86a00f07a62a09cf558 100644 (file)
@@ -34,6 +34,7 @@
 #include "FloatPlacement.h"
 #include "Format.h"
 #include "FuncRequest.h"
+#include "HSpace.h"
 #include "IndicesList.h"
 #include "Language.h"
 #include "LaTeXFeatures.h"
@@ -57,6 +58,7 @@
 #include "frontends/alert.h"
 
 #include <QAbstractItemModel>
+#include <QHeaderView>
 #include <QColor>
 #include <QColorDialog>
 #include <QCloseEvent>
@@ -190,11 +192,11 @@ public:
                //   2. Description (lexicographic)
                LayoutFile const & tc1 = LayoutFileList::get()[lhs];
                LayoutFile const & tc2 = LayoutFileList::get()[rhs];
-               int const rel = compare_no_case(
+               int const order = compare_no_case(
                        translateIfPossible(from_utf8(tc1.description())),
                        translateIfPossible(from_utf8(tc2.description())));
                return (tc1.isTeXClassAvailable() && !tc2.isTeXClassAvailable()) ||
-                       (tc1.isTeXClassAvailable() == tc2.isTeXClassAvailable() && rel < 0);
+                       (tc1.isTeXClassAvailable() == tc2.isTeXClassAvailable() && order < 0);
        }
 };
 
@@ -205,7 +207,7 @@ namespace {
 
 vector<string> getRequiredList(string const & modName) 
 {
-       LyXModule const * const mod = moduleList[modName];
+       LyXModule const * const mod = theModuleList[modName];
        if (!mod)
                return vector<string>(); //empty such thing
        return mod->getRequiredModules();
@@ -214,7 +216,7 @@ vector<string> getRequiredList(string const & modName)
 
 vector<string> getExcludedList(string const & modName)
 {
-       LyXModule const * const mod = moduleList[modName];
+       LyXModule const * const mod = theModuleList[modName];
        if (!mod)
                return vector<string>(); //empty such thing
        return mod->getExcludedModules();
@@ -223,7 +225,7 @@ vector<string> getExcludedList(string const & modName)
 
 docstring getModuleDescription(string const & modName)
 {
-       LyXModule const * const mod = moduleList[modName];
+       LyXModule const * const mod = theModuleList[modName];
        if (!mod)
                return _("Module not found!");
        // FIXME Unicode
@@ -233,7 +235,7 @@ docstring getModuleDescription(string const & modName)
 
 vector<string> getPackageList(string const & modName)
 {
-       LyXModule const * const mod = moduleList[modName];
+       LyXModule const * const mod = theModuleList[modName];
        if (!mod)
                return vector<string>(); //empty such thing
        return mod->getPackageList();
@@ -242,7 +244,7 @@ vector<string> getPackageList(string const & modName)
 
 bool isModuleAvailable(string const & modName)
 {
-       LyXModule * mod = moduleList[modName];
+       LyXModule const * const mod = theModuleList[modName];
        if (!mod)
                return false;
        return mod->isAvailable();
@@ -263,7 +265,7 @@ class ModuleSelectionManager : public GuiSelectionManager
 public:
        ///
        ModuleSelectionManager(
-               QListView * availableLV, 
+               QTreeView * availableLV,
                QListView * selectedLV,
                QPushButton * addPB, 
                QPushButton * delPB, 
@@ -553,45 +555,56 @@ GuiDocument::GuiDocument(GuiView & lv)
                this, SLOT(setLSpacing(int)));
        connect(textLayoutModule->lspacingLE, SIGNAL(textChanged(const QString &)),
                this, SLOT(change_adaptor()));
-       connect(textLayoutModule->skipRB, SIGNAL(clicked()),
-               this, SLOT(change_adaptor()));
+
        connect(textLayoutModule->indentRB, SIGNAL(clicked()),
                this, SLOT(change_adaptor()));
+       connect(textLayoutModule->indentRB, SIGNAL(toggled(bool)),
+               textLayoutModule->indentCO, SLOT(setEnabled(bool)));
+       connect(textLayoutModule->indentCO, SIGNAL(activated(int)),
+               this, SLOT(change_adaptor()));
+       connect(textLayoutModule->indentCO, SIGNAL(activated(int)),
+               this, SLOT(setIndent(int)));
+       connect(textLayoutModule->indentLE, SIGNAL(textChanged(const QString &)),
+               this, SLOT(change_adaptor()));
+       connect(textLayoutModule->indentLengthCO, SIGNAL(activated(int)),
+               this, SLOT(change_adaptor()));
+
+       connect(textLayoutModule->skipRB, SIGNAL(clicked()),
+               this, SLOT(change_adaptor()));
+       connect(textLayoutModule->skipRB, SIGNAL(toggled(bool)),
+               textLayoutModule->skipCO, SLOT(setEnabled(bool)));
        connect(textLayoutModule->skipCO, SIGNAL(activated(int)),
                this, SLOT(change_adaptor()));
+       connect(textLayoutModule->skipCO, SIGNAL(activated(int)),
+               this, SLOT(setSkip(int)));
        connect(textLayoutModule->skipLE, SIGNAL(textChanged(const QString &)),
                this, SLOT(change_adaptor()));
        connect(textLayoutModule->skipLengthCO, SIGNAL(activated(int)),
                this, SLOT(change_adaptor()));
-       connect(textLayoutModule->skipCO, SIGNAL(activated(int)),
-               this, SLOT(setSkip(int)));
+
+       connect(textLayoutModule->indentRB, SIGNAL(toggled(bool)),
+               this, SLOT(enableIndent(bool)));
        connect(textLayoutModule->skipRB, SIGNAL(toggled(bool)),
                this, SLOT(enableSkip(bool)));
+
        connect(textLayoutModule->twoColumnCB, SIGNAL(clicked()),
                this, SLOT(change_adaptor()));
        connect(textLayoutModule->twoColumnCB, SIGNAL(clicked()),
                this, SLOT(setColSep()));
-       connect(textLayoutModule->listingsED, SIGNAL(textChanged()),
-               this, SLOT(change_adaptor()));
-       connect(textLayoutModule->bypassCB, SIGNAL(clicked()), 
-               this, SLOT(change_adaptor()));
-       connect(textLayoutModule->bypassCB, SIGNAL(clicked()), 
-               this, SLOT(setListingsMessage()));
-       connect(textLayoutModule->listingsED, SIGNAL(textChanged()),
-               this, SLOT(setListingsMessage()));
-       textLayoutModule->listingsTB->setPlainText(
-               qt_("Input listings parameters on the right. Enter ? for a list of parameters."));
+
        textLayoutModule->lspacingLE->setValidator(new QDoubleValidator(
                textLayoutModule->lspacingLE));
-       textLayoutModule->skipLE->setValidator(unsignedLengthValidator(
+       textLayoutModule->indentLE->setValidator(unsignedLengthValidator(
+               textLayoutModule->indentLE));
+       textLayoutModule->skipLE->setValidator(unsignedGlueLengthValidator(
                textLayoutModule->skipLE));
 
+       textLayoutModule->indentCO->addItem(qt_("Default"));
+       textLayoutModule->indentCO->addItem(qt_("Custom"));
        textLayoutModule->skipCO->addItem(qt_("SmallSkip"));
        textLayoutModule->skipCO->addItem(qt_("MedSkip"));
        textLayoutModule->skipCO->addItem(qt_("BigSkip"));
-       textLayoutModule->skipCO->addItem(qt_("Length"));
-       // remove the %-items from the unit choice
-       textLayoutModule->skipLengthCO->noPercents();
+       textLayoutModule->skipCO->addItem(qt_("Custom"));
        textLayoutModule->lspacingCO->insertItem(
                Spacing::Single, qt_("Single"));
        textLayoutModule->lspacingCO->insertItem(
@@ -600,8 +613,8 @@ GuiDocument::GuiDocument(GuiView & lv)
                Spacing::Double, qt_("Double"));
        textLayoutModule->lspacingCO->insertItem(
                Spacing::Other, qt_("Custom"));
-
        // initialize the length validator
+       bc().addCheckedLineEdit(textLayoutModule->indentLE);
        bc().addCheckedLineEdit(textLayoutModule->skipLE);
 
        // output
@@ -658,9 +671,9 @@ GuiDocument::GuiDocument(GuiView & lv)
        pageLayoutModule = new UiWidget<Ui::PageLayoutUi>;
        // page layout
        connect(pageLayoutModule->papersizeCO, SIGNAL(activated(int)),
-               this, SLOT(setCustomPapersize(int)));
+               this, SLOT(papersizeChanged(int)));
        connect(pageLayoutModule->papersizeCO, SIGNAL(activated(int)),
-               this, SLOT(setCustomPapersize(int)));
+               this, SLOT(papersizeChanged(int)));
        connect(pageLayoutModule->portraitRB, SIGNAL(clicked()),
                this, SLOT(portraitChanged()));
        connect(pageLayoutModule->papersizeCO, SIGNAL(activated(int)),
@@ -920,6 +933,8 @@ GuiDocument::GuiDocument(GuiView & lv)
                this, SLOT(change_adaptor()));
        connect(latexModule->childDocPB, SIGNAL(clicked()),
                this, SLOT(browseMaster()));
+       connect(latexModule->suppressDateCB, SIGNAL(clicked()),
+               this, SLOT(change_adaptor()));
 
        // postscript drivers
        for (int n = 0; tex_graphics[n][0]; ++n) {
@@ -962,7 +977,7 @@ GuiDocument::GuiDocument(GuiView & lv)
 
        // Modules
        modulesModule = new UiWidget<Ui::ModulesUi>;
-
+       modulesModule->availableLV->header()->setVisible(false);
        selectionManager =
                new ModuleSelectionManager(modulesModule->availableLV,
                        modulesModule->selectedLV,
@@ -1020,6 +1035,19 @@ GuiDocument::GuiDocument(GuiView & lv)
        connect(floatModule, SIGNAL(changed()),
                this, SLOT(change_adaptor()));
 
+       // listings
+       listingsModule = new UiWidget<Ui::ListingsSettingsUi>;
+       connect(listingsModule->listingsED, SIGNAL(textChanged()),
+               this, SLOT(change_adaptor()));
+       connect(listingsModule->bypassCB, SIGNAL(clicked()), 
+               this, SLOT(change_adaptor()));
+       connect(listingsModule->bypassCB, SIGNAL(clicked()), 
+               this, SLOT(setListingsMessage()));
+       connect(listingsModule->listingsED, SIGNAL(textChanged()),
+               this, SLOT(setListingsMessage()));
+       listingsModule->listingsTB->setPlainText(
+               qt_("Input listings parameters below. Enter ? for a list of parameters."));
+
        docPS->addPanel(latexModule, qt_("Document Class"));
        docPS->addPanel(modulesModule, qt_("Modules"));
        docPS->addPanel(fontModule, qt_("Fonts"));
@@ -1033,6 +1061,7 @@ GuiDocument::GuiDocument(GuiView & lv)
        docPS->addPanel(pdfSupportModule, qt_("PDF Properties"));
        docPS->addPanel(mathsModule, qt_("Math Options"));
        docPS->addPanel(floatModule, qt_("Float Placement"));
+       docPS->addPanel(listingsModule, qt_("Listings"));
        docPS->addPanel(bulletsModule, qt_("Bullets"));
        docPS->addPanel(branchesModule, qt_("Branches"));
        docPS->addPanel(outputModule, qt_("Output"));
@@ -1077,10 +1106,10 @@ QString GuiDocument::validateListingsParameters()
        static string param_cache;
        static QString msg_cache;
        
-       if (textLayoutModule->bypassCB->isChecked())
+       if (listingsModule->bypassCB->isChecked())
                return QString();
 
-       string params = fromqstr(textLayoutModule->listingsED->toPlainText());
+       string params = fromqstr(listingsModule->listingsED->toPlainText());
        if (params != param_cache) {
                param_cache = params;
                msg_cache = toqstr(InsetListingsParams(params).validate());
@@ -1098,13 +1127,13 @@ void GuiDocument::setListingsMessage()
                        return;
                isOK = true;
                // listingsTB->setTextColor("black");
-               textLayoutModule->listingsTB->setPlainText(
-                       qt_("Input listings parameters on the right. "
+               listingsModule->listingsTB->setPlainText(
+                       qt_("Input listings parameters below. "
                 "Enter ? for a list of parameters."));
        } else {
                isOK = false;
                // listingsTB->setTextColor("red");
-               textLayoutModule->listingsTB->setPlainText(msg);
+               listingsModule->listingsTB->setPlainText(msg);
        }
 }
 
@@ -1115,19 +1144,39 @@ void GuiDocument::setLSpacing(int item)
 }
 
 
+void GuiDocument::setIndent(int item)
+{
+       bool const enable = (item == 1);
+       textLayoutModule->indentLE->setEnabled(enable);
+       textLayoutModule->indentLengthCO->setEnabled(enable);
+       textLayoutModule->skipLE->setEnabled(false);
+       textLayoutModule->skipLengthCO->setEnabled(false);
+       isValid();
+}
+
+
+void GuiDocument::enableIndent(bool indent)
+{
+       textLayoutModule->skipLE->setEnabled(!indent);
+       textLayoutModule->skipLengthCO->setEnabled(!indent);
+       if (indent)
+               setIndent(textLayoutModule->indentCO->currentIndex());
+}
+
+
 void GuiDocument::setSkip(int item)
 {
        bool const enable = (item == 3);
        textLayoutModule->skipLE->setEnabled(enable);
        textLayoutModule->skipLengthCO->setEnabled(enable);
+       isValid();
 }
 
 
 void GuiDocument::enableSkip(bool skip)
 {
-       textLayoutModule->skipCO->setEnabled(skip);
-       textLayoutModule->skipLE->setEnabled(skip);
-       textLayoutModule->skipLengthCO->setEnabled(skip);
+       textLayoutModule->indentLE->setEnabled(!skip);
+       textLayoutModule->indentLengthCO->setEnabled(!skip);
        if (skip)
                setSkip(textLayoutModule->skipCO->currentIndex());
 }
@@ -1154,10 +1203,14 @@ void GuiDocument::setMargins(bool custom)
 }
 
 
-void GuiDocument::setCustomPapersize(int papersize)
+void GuiDocument::papersizeChanged(int paper_size)
 {
-       bool const custom = (papersize == 1);
+       setCustomPapersize(paper_size == 1);
+}
+
 
+void GuiDocument::setCustomPapersize(bool custom)
+{
        pageLayoutModule->paperwidthL->setEnabled(custom);
        pageLayoutModule->paperwidthLE->setEnabled(custom);
        pageLayoutModule->paperwidthUnitCO->setEnabled(custom);
@@ -1554,7 +1607,7 @@ namespace {
                vector<string>::const_iterator it  = idList.begin();
                vector<string>::const_iterator end = idList.end();
                for (; it != end; ++it) {
-                       LyXModule const * const mod = moduleList[*it];
+                       LyXModule const * const mod = theModuleList[*it];
                        if (!mod)
                                retval.push_back(*it + " (Unavailable)");
                        else
@@ -1611,8 +1664,11 @@ void GuiDocument::updateModuleInfo()
        
        //Module description
        bool const focus_on_selected = selectionManager->selectedFocused();
-       QListView const * const lv = 
-                       focus_on_selected ? modulesModule->selectedLV : modulesModule->availableLV;
+       QAbstractItemView * lv;
+       if (focus_on_selected)
+               lv = modulesModule->selectedLV;
+       else
+               lv= modulesModule->availableLV;
        if (lv->selectionModel()->selectedIndexes().isEmpty()) {
                modulesModule->infoML->document()->clear();
                return;
@@ -1727,6 +1783,9 @@ void GuiDocument::applyView()
        // preamble
        preambleModule->apply(bp_);
 
+       // date
+       bp_.suppress_date = latexModule->suppressDateCB->isChecked();
+
        // biblio
        bp_.setCiteEngine(ENGINE_BASIC);
 
@@ -1838,6 +1897,7 @@ void GuiDocument::applyView()
        // Modules
        modulesToParams(bp_);
 
+       // Math
        if (mathsModule->amsautoCB->isChecked()) {
                bp_.use_amsmath = BufferParams::package_auto;
        } else {
@@ -1856,6 +1916,7 @@ void GuiDocument::applyView()
                        bp_.use_esint = BufferParams::package_off;
        }
 
+       // Page Layout
        if (pageLayoutModule->pagestyleCO->currentIndex() == 0)
                bp_.pagestyle = "default";
        else {
@@ -1865,6 +1926,7 @@ void GuiDocument::applyView()
                                bp_.pagestyle = pagestyles[i].first;
        }
 
+       // Text Layout
        switch (textLayoutModule->lspacingCO->currentIndex()) {
        case 0:
                bp_.spacing().set(Spacing::Single);
@@ -1877,7 +1939,7 @@ void GuiDocument::applyView()
                break;
        case 3:
                bp_.spacing().set(Spacing::Other,
-                       fromqstr(textLayoutModule->lspacingLE->text()));
+                       widgetToDoubleStr(textLayoutModule->lspacingLE));
                break;
        }
 
@@ -1886,39 +1948,53 @@ void GuiDocument::applyView()
        else
                bp_.columns = 1;
 
-       // text should have passed validation
-       bp_.listings_params =
-               InsetListingsParams(fromqstr(textLayoutModule->listingsED->toPlainText())).params();
-
-       if (textLayoutModule->indentRB->isChecked())
+       if (textLayoutModule->indentRB->isChecked()) {
+               // if paragraphs are separated by an indentation
                bp_.paragraph_separation = BufferParams::ParagraphIndentSeparation;
-       else
+               switch (textLayoutModule->indentCO->currentIndex()) {
+               case 0:
+                       bp_.setIndentation(HSpace(HSpace::DEFAULT));
+                       break;
+               case 1: {
+                       HSpace indent = HSpace(
+                               widgetsToLength(textLayoutModule->indentLE,
+                               textLayoutModule->indentLengthCO)
+                               );
+                       bp_.setIndentation(indent);
+                       break;
+                       }
+               default:
+                       // this should never happen
+                       bp_.setIndentation(HSpace(HSpace::DEFAULT));
+                       break;
+               }
+       } else {
+               // if paragraphs are separated by a skip
                bp_.paragraph_separation = BufferParams::ParagraphSkipSeparation;
-
-       switch (textLayoutModule->skipCO->currentIndex()) {
-       case 0:
-               bp_.setDefSkip(VSpace(VSpace::SMALLSKIP));
-               break;
-       case 1:
-               bp_.setDefSkip(VSpace(VSpace::MEDSKIP));
-               break;
-       case 2:
-               bp_.setDefSkip(VSpace(VSpace::BIGSKIP));
-               break;
-       case 3:
-       {
-               VSpace vs = VSpace(
-                       widgetsToLength(textLayoutModule->skipLE,
+               switch (textLayoutModule->skipCO->currentIndex()) {
+               case 0:
+                       bp_.setDefSkip(VSpace(VSpace::SMALLSKIP));
+                       break;
+               case 1:
+                       bp_.setDefSkip(VSpace(VSpace::MEDSKIP));
+                       break;
+               case 2:
+                       bp_.setDefSkip(VSpace(VSpace::BIGSKIP));
+                       break;
+               case 3:
+                       {
+                       VSpace vs = VSpace(
+                               widgetsToLength(textLayoutModule->skipLE,
                                textLayoutModule->skipLengthCO)
-                       );
-               bp_.setDefSkip(vs);
-               break;
-       }
-       default:
-               // DocumentDefskipCB assures that this never happens
-               // so Assert then !!!  - jbl
-               bp_.setDefSkip(VSpace(VSpace::MEDSKIP));
-               break;
+                               );
+                       bp_.setDefSkip(vs);
+                       break;
+                       }
+               default:
+                       // this should never happen
+                       bp_.setDefSkip(VSpace(VSpace::MEDSKIP));
+                       break;
+               }
        }
 
        bp_.options =
@@ -1933,8 +2009,14 @@ void GuiDocument::applyView()
        else
                bp_.master = string();
 
+       // Float Placement
        bp_.float_placement = floatModule->get();
 
+       // Listings
+       // text should have passed validation
+       bp_.listings_params =
+               InsetListingsParams(fromqstr(listingsModule->listingsED->toPlainText())).params();
+
        // output
        bp_.defaultOutputFormat = fromqstr(outputModule->defaultFormatCO->itemData(
                outputModule->defaultFormatCO->currentIndex()).toString());
@@ -2036,6 +2118,7 @@ void GuiDocument::applyView()
        bp_.footskip = widgetsToLength(m->footskipLE, m->footskipUnit);
        bp_.columnsep = widgetsToLength(m->columnsepLE, m->columnsepUnit);
 
+       // branches
        branchesModule->apply(bp_);
 
        // PDF support
@@ -2074,6 +2157,9 @@ void GuiDocument::paramsToDialog()
        // preamble
        preambleModule->update(bp_, id());
 
+       // date
+       latexModule->suppressDateCB->setChecked(bp_.suppress_date);
+
        // biblio
        biblioModule->citeDefaultRB->setChecked(
                bp_.citeEngine() == ENGINE_BASIC);
@@ -2200,51 +2286,56 @@ void GuiDocument::paramsToDialog()
 
        textLayoutModule->lspacingCO->setCurrentIndex(nitem);
        if (bp_.spacing().getSpace() == Spacing::Other) {
-               textLayoutModule->lspacingLE->setText(
-                       toqstr(bp_.spacing().getValueAsString()));
+               doubleToWidget(textLayoutModule->lspacingLE,
+                       bp_.spacing().getValueAsString());
        }
        setLSpacing(nitem);
 
-       if (bp_.paragraph_separation == BufferParams::ParagraphIndentSeparation)
+       if (bp_.paragraph_separation == BufferParams::ParagraphIndentSeparation) {
                textLayoutModule->indentRB->setChecked(true);
-       else
+               string indentation = bp_.getIndentation().asLyXCommand();
+               int indent = 0;
+               if (indentation != "default") {
+                       lengthToWidgets(textLayoutModule->indentLE,
+                       textLayoutModule->indentLengthCO,
+                       indentation, defaultUnit);
+                       indent = 1;
+               }
+               textLayoutModule->indentCO->setCurrentIndex(indent);
+               setIndent(indent);
+       } else {
                textLayoutModule->skipRB->setChecked(true);
-
-       int skip = 0;
-       switch (bp_.getDefSkip().kind()) {
-       case VSpace::SMALLSKIP:
-               skip = 0;
-               break;
-       case VSpace::MEDSKIP:
-               skip = 1;
-               break;
-       case VSpace::BIGSKIP:
-               skip = 2;
-               break;
-       case VSpace::LENGTH:
-       {
-               skip = 3;
-               string const length = bp_.getDefSkip().asLyXCommand();
-               lengthToWidgets(textLayoutModule->skipLE,
-                       textLayoutModule->skipLengthCO,
-                       length, defaultUnit);
-               break;
-       }
-       default:
-               skip = 0;
-               break;
+               int skip = 0;
+               switch (bp_.getDefSkip().kind()) {
+               case VSpace::SMALLSKIP:
+                       skip = 0;
+                       break;
+               case VSpace::MEDSKIP:
+                       skip = 1;
+                       break;
+               case VSpace::BIGSKIP:
+                       skip = 2;
+                       break;
+               case VSpace::LENGTH:
+                       {
+                       skip = 3;
+                       string const length = bp_.getDefSkip().asLyXCommand();
+                       lengthToWidgets(textLayoutModule->skipLE,
+                               textLayoutModule->skipLengthCO,
+                               length, defaultUnit);
+                       break;
+                       }
+               default:
+                       skip = 0;
+                       break;
+               }
+               textLayoutModule->skipCO->setCurrentIndex(skip);
+               setSkip(skip);
        }
-       textLayoutModule->skipCO->setCurrentIndex(skip);
-       setSkip(skip);
 
        textLayoutModule->twoColumnCB->setChecked(
                bp_.columns == 2);
 
-       // break listings_params to multiple lines
-       string lstparams =
-               InsetListingsParams(bp_.listings_params).separatedParams();
-       textLayoutModule->listingsED->setPlainText(toqstr(lstparams));
-
        if (!bp_.options.empty()) {
                latexModule->optionsLE->setText(
                        toqstr(bp_.options));
@@ -2285,8 +2376,15 @@ void GuiDocument::paramsToDialog()
                latexModule->childDocGB->setChecked(false);
        }
 
+       // Float Settings
        floatModule->set(bp_.float_placement);
 
+       // ListingsSettings
+       // break listings_params to multiple lines
+       string lstparams =
+               InsetListingsParams(bp_.listings_params).separatedParams();
+       listingsModule->listingsED->setPlainText(toqstr(lstparams));
+
        // Output
        // update combobox with formats
        updateDefaultFormat();
@@ -2365,7 +2463,7 @@ void GuiDocument::paramsToDialog()
                documentClass().provides("geometry");
        int const psize = bp_.papersize;
        pageLayoutModule->papersizeCO->setCurrentIndex(psize);
-       setCustomPapersize(!extern_geometry && psize);
+       setCustomPapersize(!extern_geometry && psize == 1);
        pageLayoutModule->papersizeCO->setEnabled(!extern_geometry);
 
        bool const landscape =
@@ -2452,6 +2550,9 @@ void GuiDocument::paramsToDialog()
        // Make sure that the bc is in the INITIAL state
        if (bc().policy().buttonStatus(ButtonPolicy::RESTORE))
                bc().restore();
+
+       // clear changed branches cache
+       changedBranches_.clear();
 }
 
 
@@ -2531,7 +2632,11 @@ bool GuiDocument::isValid()
 {
        return validateListingsParameters().isEmpty()
                && (textLayoutModule->skipCO->currentIndex() != 3
-                       || !textLayoutModule->skipLE->text().isEmpty());
+                       || !textLayoutModule->skipLE->text().isEmpty()
+                       || textLayoutModule->indentRB->isChecked())
+               && (textLayoutModule->indentCO->currentIndex() != 1
+                       || !textLayoutModule->indentLE->text().isEmpty()
+                       || textLayoutModule->skipRB->isChecked());
 }
 
 
@@ -2561,7 +2666,6 @@ bool GuiDocument::initialiseParams(string const &)
        //selected, and that we don't have conflicts. If so, we could
        //at least pop up a warning.
        paramsToDialog();
-       changedBranches_.clear();
        return true;
 }
 
@@ -2594,7 +2698,7 @@ list<GuiDocument::modInfoStruct> const
        for (; it != end; ++it) {
                modInfoStruct m;
                m.id = *it;
-               LyXModule * mod = moduleList[*it];
+               LyXModule const * const mod = theModuleList[*it];
                if (mod)
                        // FIXME Unicode
                        m.name = toqstr(translateIfPossible(from_utf8(mod->getName())));
@@ -2640,9 +2744,6 @@ void GuiDocument::dispatchParams()
        // This must come first so that a language change is correctly noticed
        setLanguage();
 
-       // rename branches in the document
-       executeBranchRenaming();
-
        // Apply the BufferParams. Note that this will set the base class
        // and then update the buffer's layout.
        dispatch_bufferparams(*this, params(), LFUN_BUFFER_PARAMS_APPLY);
@@ -2686,14 +2787,19 @@ void GuiDocument::dispatchParams()
                dispatch(FuncRequest(LFUN_ALL_INSETS_TOGGLE,
                        "assign branch"));
        }
+       // rename branches in the document
+       executeBranchRenaming();
+       // and clear changed branches cache
+       changedBranches_.clear();
+       
        // Generate the colours requested by indices.
        IndicesList & indiceslist = params().indiceslist();
        if (!indiceslist.empty()) {
                IndicesList::const_iterator it = indiceslist.begin();
                IndicesList::const_iterator const end = indiceslist.end();
                for (; it != end; ++it) {
-                       docstring const & current_index = it->index();
-                       Index const * index = indiceslist.find(current_index);
+                       docstring const & current_index = it->shortcut();
+                       Index const * index = indiceslist.findShortcut(current_index);
                        string const x11hexname = X11hexname(index->color());
                        // display the new color
                        docstring const str = current_index + ' ' + from_ascii(x11hexname);
@@ -2784,8 +2890,8 @@ bool GuiDocument::providesScale(string const & font) const
 void GuiDocument::loadModuleInfo()
 {
        moduleNames_.clear();
-       LyXModuleList::const_iterator it  = moduleList.begin();
-       LyXModuleList::const_iterator end = moduleList.end();
+       LyXModuleList::const_iterator it  = theModuleList.begin();
+       LyXModuleList::const_iterator end = theModuleList.end();
        for (; it != end; ++it) {
                modInfoStruct m;
                m.id = it->getID();