]> git.lyx.org Git - lyx.git/blobdiff - src/frontends/qt4/GuiCompleter.cpp
Disable CheckTeX while buffer is processed
[lyx.git] / src / frontends / qt4 / GuiCompleter.cpp
index 11348e5dcb95fc2c0d27b0637cbd39471080d6f6..9858b8d01a88166a51753bc230d3ed3d06c65980 100644 (file)
 
 #include <config.h>
 
-#include "GuiWorkArea.h"
+#include "GuiCompleter.h"
 
 #include "Buffer.h"
 #include "BufferView.h"
+#include "CompletionList.h"
 #include "Cursor.h"
 #include "Dimension.h"
-#include "FuncRequest.h"
+#include "GuiWorkArea.h"
 #include "GuiView.h"
-#include "LyXFunc.h"
+#include "LyX.h"
 #include "LyXRC.h"
 #include "Paragraph.h"
+#include "qt_helpers.h"
 #include "version.h"
 
+#include "support/lassert.h"
+#include "support/lstrings.h"
 #include "support/debug.h"
 
 #include <QApplication>
-#include <QAbstractListModel>
 #include <QHeaderView>
+#include <QKeyEvent>
 #include <QPainter>
 #include <QPixmapCache>
 #include <QScrollBar>
@@ -41,48 +45,28 @@ using namespace lyx::support;
 namespace lyx {
 namespace frontend {
 
-class RtlItemDelegate : public QItemDelegate {
+class CompleterItemDelegate : public QItemDelegate
+{
 public:
-       explicit RtlItemDelegate(QObject * parent = 0)
-               : QItemDelegate(parent) {}
-
-       void setEnabled(bool enabled = true)
-       {
-               enabled_ = enabled;
-       }
-       
-protected:
-       virtual void drawDisplay(QPainter * painter,
-               QStyleOptionViewItem const & option,
-               QRect const & rect, QString const & text) const
-       {
-               if (!enabled_)
-                       return QItemDelegate::drawDisplay(painter, option, rect, text);
+       explicit CompleterItemDelegate(QObject * parent)
+               : QItemDelegate(parent)
+       {}
 
-               // FIXME: do this more elegantly
-               docstring stltext = qstring_to_ucs4(text);
-               reverse(stltext.begin(), stltext.end());
-               QItemDelegate::drawDisplay(painter, option, rect, toqstr(stltext));
-       }
-       
-private:
-       bool enabled_;
-};
-
-
-class PixmapItemDelegate : public QItemDelegate {
-public:
-       explicit PixmapItemDelegate(QObject *parent = 0)
-       : QItemDelegate(parent) {}
+       ~CompleterItemDelegate()
+       {}
 
 protected:
        void paint(QPainter *painter, const QStyleOptionViewItem &option,
                   const QModelIndex &index) const
        {
+               if (index.column() == 0) {
+                       QItemDelegate::paint(painter, option, index);
+                       return;
+               }
                QStyleOptionViewItem opt = setOptions(index, option);
                QVariant value = index.data(Qt::DisplayRole);
                QPixmap pixmap = qvariant_cast<QPixmap>(value);
-               
+
                // draw
                painter->save();
                drawBackground(painter, opt, index);
@@ -97,23 +81,28 @@ protected:
        }
 };
 
-
-class GuiCompletionModel : public QAbstractListModel {
+class GuiCompletionModel : public QAbstractListModel
+{
 public:
        ///
-       GuiCompletionModel(QObject * parent,
-               Inset::CompletionList const * l)
-               : QAbstractListModel(parent), list_(l) {}
+       GuiCompletionModel(QObject * parent, CompletionList const * l)
+               : QAbstractListModel(parent), list_(l)
+       {}
+       ///
+       ~GuiCompletionModel() { delete list_; }
        ///
-       ~GuiCompletionModel()
-               { delete list_; }
+       void setList(CompletionList const * l) {
+               beginResetModel();
+               delete list_;
+               list_ = l;
+               endResetModel();
+       }
        ///
        bool sorted() const
        {
                if (list_)
                        return list_->sorted();
-               else
-                       return false;
+               return false;
        }
        ///
        int columnCount(const QModelIndex & /*parent*/ = QModelIndex()) const
@@ -125,8 +114,7 @@ public:
        {
                if (list_ == 0)
                        return 0;
-               else
-                       return list_->size();
+               return list_->size();
        }
 
        ///
@@ -140,57 +128,62 @@ public:
 
                if (role != Qt::DisplayRole && role != Qt::EditRole)
                    return QVariant();
-                   
+
                if (index.column() == 0)
                        return toqstr(list_->data(index.row()));
-               else if (index.column() == 1) {
-                       // get icon from cache
-                       QPixmap scaled;
-                       QString const name = ":" + toqstr(list_->icon(index.row()));
-                       if (!QPixmapCache::find("completion" + name, scaled)) {
-                               // load icon from disk
-                               QPixmap p = QPixmap(name);
-                               if (!p.isNull()) {
-                                       // scale it to 16x16 or smaller
-                                       scaled = p.scaled(min(16, p.width()), min(16, p.height()), 
-                                               Qt::KeepAspectRatio, Qt::SmoothTransformation);
-                               }
 
-                               QPixmapCache::insert("completion" + name, scaled);
-                       }
+               if (index.column() != 1)
+                       return QVariant();
+
+               // get icon from cache
+               QPixmap scaled;
+               QString const name = ":" + toqstr(list_->icon(index.row()));
+               if (name == ":")
                        return scaled;
+               if (!QPixmapCache::find("completion" + name, scaled)) {
+                       // load icon from disk
+                       QPixmap p = QPixmap(name);
+                       if (!p.isNull()) {
+                               // scale it to 16x16 or smaller
+                               scaled = p.scaled(min(16, p.width()), min(16, p.height()),
+                                       Qt::KeepAspectRatio, Qt::SmoothTransformation);
+                       }
+                       QPixmapCache::insert("completion" + name, scaled);
                }
-               return QVariant();
+               return scaled;
        }
 
 private:
-       ///
-       Inset::CompletionList const * list_;
+       /// owned by us
+       CompletionList const * list_;
 };
 
 
 GuiCompleter::GuiCompleter(GuiWorkArea * gui, QObject * parent)
-       : QCompleter(parent), gui_(gui), updateLock_(0),
-         inlineVisible_(false), popupVisible_(false)
+       : QCompleter(parent), gui_(gui), old_cursor_(0), updateLock_(0),
+         inlineVisible_(false), popupVisible_(false),
+         modelActive_(false)
 {
        // Setup the completion popup
-       setModel(new GuiCompletionModel(this, 0));
+       model_ = new GuiCompletionModel(this, 0);
+       setModel(model_);
        setCompletionMode(QCompleter::PopupCompletion);
+       setCaseSensitivity(Qt::CaseSensitive);
        setWidget(gui_);
-       
+
        // create the popup
        QTreeView *listView = new QTreeView;
-        listView->setEditTriggers(QAbstractItemView::NoEditTriggers);
-        listView->setHorizontalScrollBarPolicy(Qt::ScrollBarAlwaysOff);
-        listView->setSelectionBehavior(QAbstractItemView::SelectRows);
-        listView->setSelectionMode(QAbstractItemView::SingleSelection);
+       listView->setEditTriggers(QAbstractItemView::NoEditTriggers);
+       listView->setHorizontalScrollBarPolicy(Qt::ScrollBarAlwaysOff);
+       listView->setSelectionBehavior(QAbstractItemView::SelectRows);
+       listView->setSelectionMode(QAbstractItemView::SingleSelection);
        listView->header()->hide();
        listView->setIndentation(0);
        listView->setUniformRowHeights(true);
        setPopup(listView);
-       popup()->setItemDelegateForColumn(1, new PixmapItemDelegate(this));
-       rtlItemDelegate_ = new RtlItemDelegate(this);
-       popup()->setItemDelegateForColumn(0, rtlItemDelegate_);
+
+       itemDelegate_ = new CompleterItemDelegate(this);
+       popup()->setItemDelegate(itemDelegate_);
 
        // create timeout timers
        popup_timer_.setSingleShot(true);
@@ -226,7 +219,7 @@ bool GuiCompleter::eventFilter(QObject * watched, QEvent * e)
                default: break;
                }
        }
-       
+
        return QCompleter::eventFilter(watched, e);
 }
 
@@ -245,11 +238,32 @@ bool GuiCompleter::inlinePossible(Cursor const & cur) const
 }
 
 
+bool GuiCompleter::uniqueCompletionAvailable() const
+{
+       if (!modelActive_)
+               return false;
+
+       size_t n = popup()->model()->rowCount();
+       if (n > 1 || n == 0)
+               return false;
+
+       // if there is exactly one, we have to check whether it is a
+       // real completion, i.e. longer than the current prefix.
+       if (completionPrefix() == currentCompletion())
+               return false;
+
+       return true;
+}
+
+
 bool GuiCompleter::completionAvailable() const
 {
+       if (!modelActive_)
+               return false;
+
        size_t n = popup()->model()->rowCount();
 
-       // if there is exactly one, we have to check whether it is a 
+       // if there is exactly one, we have to check whether it is a
        // real completion, i.e. longer than the current prefix.
        if (n == 1 && completionPrefix() == currentCompletion())
            return false;
@@ -276,19 +290,19 @@ bool GuiCompleter::inlineVisible() const
 }
 
 
-void GuiCompleter::updateVisibility(Cursor & cur, bool start, bool keep, bool cursorInView)
+void GuiCompleter::updateVisibility(Cursor & cur, bool start, bool keep)
 {
        // parameters which affect the completion
        bool moved = cur != old_cursor_;
        if (moved)
                old_cursor_ = cur;
 
-       bool possiblePopupState = popupPossible(cur) && cursorInView;
-       bool possibleInlineState = inlinePossible(cur) && cursorInView;
+       bool const possiblePopupState = popupPossible(cur);
+       bool const possibleInlineState = inlinePossible(cur);
 
        // we moved or popup state is not ok for popup?
        if ((moved && !keep) || !possiblePopupState)
-               hidePopup(cur);
+               hidePopup();
 
        // we moved or inline state is not ok for inline completion?
        if ((moved && !keep) || !possibleInlineState)
@@ -303,9 +317,14 @@ void GuiCompleter::updateVisibility(Cursor & cur, bool start, bool keep, bool cu
        if (!inlineVisible() && possibleInlineState && start
                && cur.inset().automaticInlineCompletion())
                inline_timer_.start(int(lyxrc.completion_inline_delay * 1000));
+       else if (cur.inMathed() && !lyxrc.completion_inline_math) {
+               // no inline completion, hence a metrics update is needed
+               if (!(cur.result().screenUpdate() & Update::Force))
+                       cur.screenUpdateFlags(cur.result().screenUpdate() | Update::SinglePar);
+       }
 
        // update prefix if any completion is possible
-       bool modelActive = model()->rowCount() > 0;
+       bool modelActive = modelActive_ && model()->rowCount() > 0;
        if (possiblePopupState || possibleInlineState) {
                if (modelActive)
                        updatePrefix(cur);
@@ -318,27 +337,27 @@ void GuiCompleter::updateVisibility(Cursor & cur, bool start, bool keep, bool cu
 void GuiCompleter::updateVisibility(bool start, bool keep)
 {
        Cursor cur = gui_->bufferView().cursor();
-       cur.updateFlags(Update::None);
-       
+       cur.screenUpdateFlags(Update::None);
+
        updateVisibility(cur, start, keep);
-       
-       if (cur.disp_.update())
-               gui_->bufferView().processUpdateFlags(cur.disp_.update());
+
+       if (cur.result().screenUpdate())
+               gui_->bufferView().processUpdateFlags(cur.result().screenUpdate());
 }
 
 
-void GuiCompleter::updatePrefix(Cursor & cur)
+void GuiCompleter::updatePrefix(Cursor const & cur)
 {
        // get new prefix. Do nothing if unchanged
        QString newPrefix = toqstr(cur.inset().completionPrefix(cur));
        if (newPrefix == completionPrefix())
                return;
-       
+
        // value which should be kept selected
        QString old = currentCompletion();
        if (old.length() == 0)
                old = last_selection_;
-       
+
        // update completer to new prefix
        setCompletionPrefix(newPrefix);
 
@@ -348,7 +367,7 @@ void GuiCompleter::updatePrefix(Cursor & cur)
 
        // restore old selection
        setCurrentCompletion(old);
-       
+
        // if popup is not empty, the new selection will
        // be our last valid one
        QString const & s = currentCompletion();
@@ -366,19 +385,19 @@ void GuiCompleter::updatePrefix(Cursor & cur)
 }
 
 
-void GuiCompleter::updateInline(Cursor & cur, QString const & completion)
+void GuiCompleter::updateInline(Cursor const & cur, QString const & completion)
 {
        if (!cur.inset().inlineCompletionSupported(cur))
                return;
-       
+
        // compute postfix
        docstring prefix = cur.inset().completionPrefix(cur);
-       docstring postfix = from_utf8(fromqstr(completion.mid(prefix.length())));
-       
+       docstring postfix = qstring_to_ucs4(completion.mid(prefix.length()));
+
        // shorten it if necessary
-       if (lyxrc.completion_inline_dots != -1
-           && postfix.size() > unsigned(lyxrc.completion_inline_dots))
-               postfix = postfix.substr(0, lyxrc.completion_inline_dots - 1) + "...";
+       if (lyxrc.completion_inline_dots != -1)
+               support::truncateWithEllipsis(postfix,
+                                                                         unsigned(lyxrc.completion_inline_dots));
 
        // set inline completion at cursor position
        size_t uniqueTo = max(longestUniqueCompletion().size(), prefix.size());
@@ -387,11 +406,11 @@ void GuiCompleter::updateInline(Cursor & cur, QString const & completion)
 }
 
 
-void GuiCompleter::updatePopup(Cursor & cur)
+void GuiCompleter::updatePopup(Cursor const & cur)
 {
        if (!cur.inset().completionSupported(cur))
                return;
-       
+
        popupVisible_ = true;
 
        if (completionCount() == 0) {
@@ -399,17 +418,15 @@ void GuiCompleter::updatePopup(Cursor & cur)
                return;
        }
 
-       // show asynchronously to avoid lookups before the metrics
-       // have been computed. This can happen because we might be in
-       // the middle of a dispatch.
-       QTimer::singleShot(0, this, SLOT(asyncCompletePopup()));
+       QTimer::singleShot(0, this, SLOT(asyncUpdatePopup()));
 }
 
 
-void GuiCompleter::asyncCompletePopup()
+void GuiCompleter::asyncUpdatePopup()
 {
        Cursor cur = gui_->bufferView().cursor();
-       if (!cur.inset().completionSupported(cur)) {
+       if (!cur.inset().completionSupported(cur)
+                 || !cur.bv().paragraphVisible(cur)) {
                popupVisible_ = false;
                return;
        }
@@ -419,23 +436,23 @@ void GuiCompleter::asyncCompletePopup()
        int x;
        int y;
        cur.inset().completionPosAndDim(cur, x, y, dim);
-       
+
        // and calculate the rect of the popup
        QRect rect;
        if (popup()->layoutDirection() == Qt::RightToLeft)
                rect = QRect(x + dim.width() - 200, y - dim.ascent() - 3, 200, dim.height() + 6);
        else
                rect = QRect(x, y - dim.ascent() - 3, 200, dim.height() + 6);
-       
+
        // Resize the columns in the popup.
        // This should really be in the constructor. But somehow the treeview
        // has a bad memory about it and we have to tell him again and again.
        QTreeView * listView = static_cast<QTreeView *>(popup());
        listView->header()->setStretchLastSection(false);
-       listView->header()->setResizeMode(0, QHeaderView::Stretch);
-       listView->header()->setResizeMode(1, QHeaderView::Fixed);
+       setSectionResizeMode(listView->header(), 0, QHeaderView::Stretch);
+       setSectionResizeMode(listView->header(), 1, QHeaderView::Fixed);
        listView->header()->resizeSection(1, 22);
-       
+
        // show/update popup
        complete(rect);
 }
@@ -447,15 +464,15 @@ void GuiCompleter::updateAvailability()
        // visible yet, i.e. especially if automatic completion is disabled.
        if (inlineVisible() || popupVisible())
                return;
-       Cursor & cur = gui_->bufferView().cursor();
+       Cursor const & cur = gui_->bufferView().cursor();
        if (!popupPossible(cur) && !inlinePossible(cur))
                return;
-       
+
        updateModel(cur, false, false);
 }
-       
 
-void GuiCompleter::updateModel(Cursor & cur, bool popupUpdate, bool inlineUpdate)
+
+void GuiCompleter::updateModel(Cursor const & cur, bool popupUpdate, bool inlineUpdate)
 {
        // value which should be kept selected
        QString old = currentCompletion();
@@ -466,19 +483,16 @@ void GuiCompleter::updateModel(Cursor & cur, bool popupUpdate, bool inlineUpdate
        bool rtl = false;
        if (cur.inTexted()) {
                Paragraph const & par = cur.paragraph();
-               Font const font =
-               par.getFontSettings(cur.bv().buffer().params(), cur.pos());
+               Font const font =
+                       par.getFontSettings(cur.bv().buffer().params(), cur.pos());
                rtl = font.isVisibleRightToLeft();
        }
        popup()->setLayoutDirection(rtl ? Qt::RightToLeft : Qt::LeftToRight);
 
-       // turn the direction of the strings in the popup.
-       // Qt does not do that itself.
-       rtlItemDelegate_->setEnabled(rtl);
-
        // set new model
-       Inset::CompletionList const * list = cur.inset().createCompletionList(cur);
-       setModel(new GuiCompletionModel(this, list));
+       CompletionList const * list = cur.inset().createCompletionList(cur);
+       model_->setList(list);
+       modelActive_ = true;
        if (list->sorted())
                setModelSorting(QCompleter::CaseSensitivelySortedModel);
        else
@@ -495,7 +509,7 @@ void GuiCompleter::updateModel(Cursor & cur, bool popupUpdate, bool inlineUpdate
 
        // restore old selection
        setCurrentCompletion(old);
-       
+
        // if popup is not empty, the new selection will
        // be our last valid one
        if (popupVisible() || inlineVisible()) {
@@ -512,114 +526,123 @@ void GuiCompleter::updateModel(Cursor & cur, bool popupUpdate, bool inlineUpdate
 }
 
 
-void GuiCompleter::showPopup(Cursor & cur)
+void GuiCompleter::showPopup(Cursor const & cur)
 {
        if (!popupPossible(cur))
                return;
-       
+
        updateModel(cur, true, inlineVisible());
 }
 
 
-void GuiCompleter::hidePopup(Cursor & cur)
+void GuiCompleter::asyncHidePopup()
 {
-       popupVisible_ = false;
-       
-       // hide popup asynchronously because we might be here inside of
-       // LFUN dispatchers. Hiding a popup can trigger a focus event on the 
-       // workarea which then redisplays the cursor. But the metrics are not
-       // yet up to date such that the coord cache has not all insets yet. The
-       // cursorPos methods would triggers asserts in the coord cache then.
-       QTimer::singleShot(0, popup(), SLOT(hide()));
-       
-       if (popup_timer_.isActive())
-               popup_timer_.stop();
-       
+       popup()->hide();
        if (!inlineVisible())
-               setModel(new GuiCompletionModel(this, 0));
+               model_->setList(0);
 }
 
 
-void GuiCompleter::showInline(Cursor & cur)
+void GuiCompleter::showInline(Cursor const & cur)
 {
        if (!inlinePossible(cur))
                return;
-       
+
        updateModel(cur, popupVisible(), true);
 }
 
 
-void GuiCompleter::hideInline(Cursor & cur)
+void GuiCompleter::hideInline(Cursor const & cur)
 {
-       gui_->bufferView().setInlineCompletion(cur, DocIterator(), docstring());
+       gui_->bufferView().setInlineCompletion(cur, DocIterator(cur.buffer()), docstring());
        inlineVisible_ = false;
-       
+
        if (inline_timer_.isActive())
                inline_timer_.stop();
-       
+
+       // Trigger asynchronous part of hideInline. We might be
+       // in a dispatcher here and the setModel call might
+       // trigger focus events which is are not healthy here.
+       QTimer::singleShot(0, this, SLOT(asyncHideInline()));
+
+       // mark that the asynchronous part will reset the model
+       if (!popupVisible())
+               modelActive_ = false;
+}
+
+
+void GuiCompleter::asyncHideInline()
+{
        if (!popupVisible())
-               setModel(new GuiCompletionModel(this, 0));
+               model_->setList(0);
 }
 
 
 void GuiCompleter::showPopup()
 {
        Cursor cur = gui_->bufferView().cursor();
-       cur.updateFlags(Update::None);
-       
+       cur.screenUpdateFlags(Update::None);
+
        showPopup(cur);
 
        // redraw if needed
-       if (cur.disp_.update())
-               gui_->bufferView().processUpdateFlags(cur.disp_.update());
+       if (cur.result().screenUpdate())
+               gui_->bufferView().processUpdateFlags(cur.result().screenUpdate());
 }
 
 
 void GuiCompleter::showInline()
 {
        Cursor cur = gui_->bufferView().cursor();
-       cur.updateFlags(Update::None);
-       
+       cur.screenUpdateFlags(Update::None);
+
        showInline(cur);
 
        // redraw if needed
-       if (cur.disp_.update())
-               gui_->bufferView().processUpdateFlags(cur.disp_.update());
+       if (cur.result().screenUpdate())
+               gui_->bufferView().processUpdateFlags(cur.result().screenUpdate());
 }
 
 
 void GuiCompleter::hidePopup()
 {
-       Cursor cur = gui_->bufferView().cursor();
-       cur.updateFlags(Update::None);
-       
-       hidePopup(cur);
-       
-       // redraw if needed
-       if (cur.disp_.update())
-               gui_->bufferView().processUpdateFlags(cur.disp_.update());
+       popupVisible_ = false;
+
+       if (popup_timer_.isActive())
+               popup_timer_.stop();
+
+       // hide popup asynchronously because we might be here inside of
+       // LFUN dispatchers. Hiding a popup can trigger a focus event on the
+       // workarea which then redisplays the cursor. But the metrics are not
+       // yet up to date such that the coord cache has not all insets yet. The
+       // cursorPos methods would triggers asserts in the coord cache then.
+       QTimer::singleShot(0, this, SLOT(asyncHidePopup()));
+
+       // mark that the asynchronous part will reset the model
+       if (!inlineVisible())
+               modelActive_ = false;
 }
 
 
 void GuiCompleter::hideInline()
 {
        Cursor cur = gui_->bufferView().cursor();
-       cur.updateFlags(Update::None);
-       
+       cur.screenUpdateFlags(Update::None);
+
        hideInline(cur);
-       
+
        // redraw if needed
-       if (cur.disp_.update())
-               gui_->bufferView().processUpdateFlags(cur.disp_.update());
+       if (cur.result().screenUpdate())
+               gui_->bufferView().processUpdateFlags(cur.result().screenUpdate());
 }
 
 
 void GuiCompleter::activate()
 {
        if (!popupVisible() && !inlineVisible())
-               return;
-
-       popupActivated(currentCompletion());
+               tab();
+       else
+               popupActivated(currentCompletion());
 }
 
 
@@ -627,14 +650,14 @@ void GuiCompleter::tab()
 {
        BufferView * bv = &gui_->bufferView();
        Cursor cur = bv->cursor();
-       cur.updateFlags(Update::None);
-       
+       cur.screenUpdateFlags(Update::None);
+
        // check that inline completion is active
-       if (!inlineVisible()) {
+       if (!inlineVisible() && !uniqueCompletionAvailable()) {
                // try to activate the inline completion
                if (cur.inset().inlineCompletionSupported(cur)) {
                        showInline();
-                       
+
                        // show popup without delay because the completion was not unique
                        if (lyxrc.completion_popup_after_complete
                            && !popupVisible()
@@ -648,26 +671,33 @@ void GuiCompleter::tab()
                        showPopup();
                        return;
                }
-               
+
                return;
        }
-       
+
+       // Make undo possible
+       cur.beginUndoGroup();
+       cur.recordUndo();
+
        // If completion is active, at least complete by one character
        docstring prefix = cur.inset().completionPrefix(cur);
-       docstring completion = from_utf8(fromqstr(currentCompletion()));
+       docstring completion = qstring_to_ucs4(currentCompletion());
        if (completion.size() <= prefix.size()) {
                // finalize completion
                cur.inset().insertCompletion(cur, docstring(), true);
-               
+
                // hide popup and inline completion
-               hidePopup(cur);
+               hidePopup();
                hideInline(cur);
                updateVisibility(false, false);
+               cur.endUndoGroup();
                return;
        }
        docstring nextchar = completion.substr(prefix.size(), 1);
-       if (!cur.inset().insertCompletion(cur, nextchar, false))
+       if (!cur.inset().insertCompletion(cur, nextchar, false)) {
+               cur.endUndoGroup();
                return;
+       }
        updatePrefix(cur);
 
        // try to complete as far as it is unique
@@ -685,8 +715,9 @@ void GuiCompleter::tab()
                popup_timer_.start(0);
 
        // redraw if needed
-       if (cur.disp_.update())
-               gui_->bufferView().processUpdateFlags(cur.disp_.update());
+       if (cur.result().screenUpdate())
+               gui_->bufferView().processUpdateFlags(cur.result().screenUpdate());
+       cur.endUndoGroup();
 }
 
 
@@ -695,7 +726,7 @@ QString GuiCompleter::currentCompletion() const
        if (!popup()->selectionModel()->hasSelection())
                return QString();
 
-       // Not sure if this is bug in Qt: currentIndex() always 
+       // Not sure if this is bug in Qt: currentIndex() always
        // return the first element in the list.
        QModelIndex idx = popup()->currentIndex();
        return popup()->model()->data(idx, Qt::EditRole).toString();
@@ -703,7 +734,7 @@ QString GuiCompleter::currentCompletion() const
 
 
 void GuiCompleter::setCurrentCompletion(QString const & s)
-{      
+{
        QAbstractItemModel const & model = *popup()->model();
        size_t n = model.rowCount();
        if (n == 0)
@@ -760,7 +791,8 @@ void GuiCompleter::setCurrentCompletion(QString const & s)
                        i = n;
                else
                        i = l;
-               BOOST_ASSERT(0 <= i && i <= n);
+               // we can try to recover
+               LASSERT(i <= n, i = 0);
        }
 
        // select the first if none was found
@@ -794,7 +826,7 @@ docstring GuiCompleter::longestUniqueCompletion() const
        if (n == 0)
                return docstring();
        QString s = model.data(model.index(0, 0), Qt::EditRole).toString();
-       
+
        if (modelSorting() == QCompleter::UnsortedModel) {
                // For unsorted model we cannot do more than iteration.
                // Iterate through the completions and cut off where s differs
@@ -816,7 +848,7 @@ docstring GuiCompleter::longestUniqueCompletion() const
                                // get common prefix with the middle string
                                size_t mid = (r + i) / 2;
                                QString const & mids
-                               = model.data(model.index(mid, 0), 
+                               = model.data(model.index(mid, 0),
                                        Qt::EditRole).toString();
                                size_t oldLen = s.length();
                                size_t len = commonPrefix(mids, s);
@@ -834,23 +866,27 @@ docstring GuiCompleter::longestUniqueCompletion() const
                }
        }
 
-       return from_utf8(fromqstr(s));
+       return qstring_to_ucs4(s);
 }
 
 
 void GuiCompleter::popupActivated(const QString & completion)
 {
        Cursor cur = gui_->bufferView().cursor();
-       cur.updateFlags(Update::None);
-       
+       cur.screenUpdateFlags(Update::None);
+
+       cur.beginUndoGroup();
+       cur.recordUndo();
+
        docstring prefix = cur.inset().completionPrefix(cur);
-       docstring postfix = from_utf8(fromqstr(completion.mid(prefix.length())));
+       docstring postfix = qstring_to_ucs4(completion.mid(prefix.length()));
        cur.inset().insertCompletion(cur, postfix, true);
-       hidePopup(cur);
+       hidePopup();
        hideInline(cur);
-       
-       if (cur.disp_.update())
-               gui_->bufferView().processUpdateFlags(cur.disp_.update());
+
+       if (cur.result().screenUpdate())
+               gui_->bufferView().processUpdateFlags(cur.result().screenUpdate());
+       cur.endUndoGroup();
 }
 
 
@@ -860,16 +896,16 @@ void GuiCompleter::popupHighlighted(const QString & completion)
                return;
 
        Cursor cur = gui_->bufferView().cursor();
-       cur.updateFlags(Update::None);
-       
+       cur.screenUpdateFlags(Update::None);
+
        if (inlineVisible())
                updateInline(cur, completion);
-       
-       if (cur.disp_.update())
-               gui_->bufferView().processUpdateFlags(cur.disp_.update());
+
+       if (cur.result().screenUpdate())
+               gui_->bufferView().processUpdateFlags(cur.result().screenUpdate());
 }
 
 } // namespace frontend
 } // namespace lyx
 
-#include "GuiCompleter_moc.cpp"
+#include "moc_GuiCompleter.cpp"