Use <cstdint> instead of <boost/cstdint.hpp>

[lyx.git] / src / frontends / qt4 / GuiCitation.cpp

diff --git a/src/frontends/qt4/GuiCitation.cpp b/src/frontends/qt4/GuiCitation.cpp
index d7d225b5f219f283e9023a60411e40e59120e58c..196ec44d2b7b5bb6c26c022353082e03e62edf61 100644 (file)
--- a/src/frontends/qt4/GuiCitation.cpp
+++ b/src/frontends/qt4/GuiCitation.cpp
@@ -136,9 +136,9 @@ GuiCitation::GuiCitation(GuiView & lv)
        connect(textAfterED, SIGNAL(textChanged(QString)),
                this, SLOT(updateStyles()));
        connect(textBeforeED, SIGNAL(returnPressed()),
-               this, SLOT(on_okPB_clicked()));
+               this, SLOT(on_buttonBox_accepted()));
        connect(textAfterED, SIGNAL(returnPressed()),
-               this, SLOT(on_okPB_clicked()));
+               this, SLOT(on_buttonBox_accepted()));
 
        selectionManager = new GuiSelectionManager(this, availableLV, selectedLV,
                        addPB, deletePB, upPB, downPB, &available_model_, &selected_model_, 1);
@@ -147,7 +147,7 @@ GuiCitation::GuiCitation(GuiView & lv)
        connect(selectionManager, SIGNAL(updateHook()),
                this, SLOT(updateControls()));
        connect(selectionManager, SIGNAL(okHook()),
-               this, SLOT(on_okPB_clicked()));
+               this, SLOT(on_buttonBox_accepted()));
 
        connect(filter_, SIGNAL(rightButtonClicked()),
                this, SLOT(resetFilter()));
@@ -175,6 +175,8 @@ GuiCitation::GuiCitation(GuiView & lv)
        selectedLV->horizontalHeader()->setSectionResizeMode(QHeaderView::Stretch);
 #endif
 
+       selectedLV->setToolTip(qt_("Ordered list of all cited references.\n"
+                                  "You can reorder, add and remove references with the buttons on the left."));
        setFocusProxy(filter_);
 }
 
@@ -202,13 +204,14 @@ void GuiCitation::applyView()
 
 void GuiCitation::showEvent(QShowEvent * e)
 {
-       filter_->clear();
+       if (!filter_->text().isEmpty())
+               filterPressed();
        availableLV->setFocus();
        DialogView::showEvent(e);
 }
 
 
-void GuiCitation::on_okPB_clicked()
+void GuiCitation::on_buttonBox_accepted()
 {
        applyView();
        clearSelection();
@@ -216,23 +219,27 @@ void GuiCitation::on_okPB_clicked()
 }
 
 
-void GuiCitation::on_cancelPB_clicked()
+void GuiCitation::on_buttonBox_rejected()
 {
        clearSelection();
        hide();
 }
 
 
-void GuiCitation::on_applyPB_clicked()
+void GuiCitation::on_buttonBox_clicked(QAbstractButton * button)
 {
-       applyView();
-}
-
-
-void GuiCitation::on_restorePB_clicked()
-{
-       init();
-       updateFilterHint();
+       switch (buttonBox->standardButton(button)) {
+       case QDialogButtonBox::Apply:
+               applyView();
+               break;
+       case QDialogButtonBox::Reset:
+               init();
+               updateFilterHint();
+               filterPressed();
+               break;
+       default:
+               break;
+       }
 }
 
 
@@ -261,7 +268,7 @@ void GuiCitation::updateControls(BiblioInfo const & bi)
        int i = citationStyleCO->currentIndex();
        if (i == -1 || i > int(citeStyles_.size()))
                i = 0;
-       updateFormatting(citeStyles_[i]);
+       updateFormatting(citeStyles_[size_type(i)]);
        selectionManager->update();
 }
 
@@ -280,7 +287,10 @@ void GuiCitation::updateFormatting(CitationStyle const & currentStyle)
        bool const qualified = currentStyle.hasQualifiedList
                && (rows > 1
                    || !params_["pretextlist"].empty()
-                   || !params_["posttextlist"].empty());
+                   || !params_["posttextlist"].empty()
+                   || !getPreTexts().empty()
+                   || !getPostTexts().empty());
+
        selectedLV->horizontalHeader()->setVisible(qualified);
        selectedLV->setColumnHidden(0, !qualified);
        selectedLV->setColumnHidden(2, !qualified);
@@ -352,6 +362,12 @@ void GuiCitation::updateFormatting(CitationStyle const & currentStyle)
                        starredCB->setToolTip(qt_("Always list all authors (rather than using \"et al.\"), "
                                                  "if the current citation style supports this."));
        }
+       if (availableLV->selectionModel()->selectedIndexes().isEmpty())
+               availableLV->setToolTip(qt_("All references available for citing."));
+       else
+               availableLV->setToolTip(qt_("All references available for citing.\n"
+                                           "To add the selected one, hit Add, press Enter or double-click.\n"
+                                           "Hit Ctrl-Enter to add and close the dialog."));
 }
 
 
@@ -451,8 +467,8 @@ bool GuiCitation::isSelected(QModelIndex const & idx)
 void GuiCitation::setButtons()
 {
        int const srows = selectedLV->model()->rowCount();
-       applyPB->setEnabled(srows > 0);
-       okPB->setEnabled(srows > 0);
+       buttonBox->button(QDialogButtonBox::Apply)->setEnabled(srows > 0);
+       buttonBox->button(QDialogButtonBox::Ok)->setEnabled(srows > 0);
 }
 
 
@@ -485,7 +501,7 @@ void GuiCitation::findText(QString const & text, bool reset)
                //either "All Fields" or "Keys" or an invalid value
                field = from_ascii("");
        else
-               field = fields[index];
+               field = fields[size_type(index)];
 
        //Was it "Keys"?
        bool const onlyKeys = index == -1;
@@ -497,7 +513,7 @@ void GuiCitation::findText(QString const & text, bool reset)
        if (index < 0 || index >= int(entries.size()))
                entry_type = from_ascii("");
        else
-               entry_type = entries[index];
+               entry_type = entries[size_type(index)];
 
        bool const case_sentitive = casesense_->isChecked();
        bool const reg_exp = regexp_->isChecked();
@@ -529,7 +545,7 @@ void GuiCitation::on_citationStyleCO_currentIndexChanged(int index)
 {
        if (index >= 0 && index < citationStyleCO->count()) {
                vector<CitationStyle> const & styles = citeStyles_;
-               updateFormatting(styles[index]);
+               updateFormatting(styles[size_type(index)]);
                changed();
        }
 }
@@ -574,9 +590,10 @@ void GuiCitation::regexChanged()
 
 void GuiCitation::updateFilterHint()
 {
-       QString const hint = instant_->isChecked() ?
+       QString hint = instant_->isChecked() ?
                qt_("Enter string to filter the list of available citations") :
                qt_("Enter string to filter the list of available citations and press <Enter>");
+       hint += qt_("\nThe down arrow key will get you into the list of filtered citations.");
        filter_->setToolTip(hint);
 }
 
@@ -604,7 +621,7 @@ void GuiCitation::applyParams(int const choice, bool full, bool force,
 
        vector<CitationStyle> const & styles = citeStyles_;
 
-       CitationStyle cs = styles[choice];
+       CitationStyle cs = styles[size_type(choice)];
 
        if (!cs.textBefore)
                before.clear();
@@ -728,7 +745,7 @@ vector<docstring> GuiCitation::getPostTexts()
        for (int i = 0; i != selected_model_.rowCount(); ++i) {
                QStandardItem const * key = selected_model_.item(i, 1);
                QStandardItem const * post = selected_model_.item(i, 2);
-               if (key && post)
+               if (key && post && !key->text().isEmpty() && !post->text().isEmpty())
                        res.push_back(qstring_to_ucs4(key->text()) + " " + qstring_to_ucs4(post->text()));
        }
        return res;
@@ -797,12 +814,12 @@ void GuiCitation::init()
                citationStyleCO->blockSignals(true);
                citationStyleCO->setCurrentIndex(i);
                citationStyleCO->blockSignals(false);
-               updateFormatting(citeStyles_[i]);
+               updateFormatting(citeStyles_[size_type(i)]);
        } else
                availableLV->setFocus();
 
-       applyPB->setEnabled(false);
-       okPB->setEnabled(false);
+       buttonBox->button(QDialogButtonBox::Apply)->setEnabled(false);
+       buttonBox->button(QDialogButtonBox::Ok)->setEnabled(false);
 }
 
 
@@ -868,7 +885,7 @@ BiblioInfo::CiteStringMap GuiCitation::citationStyles(BiblioInfo const & bi, siz
        int ind = citationStyleCO->currentIndex();
        if (ind == -1)
                ind = 0;
-       CitationStyle cs = styles[ind];
+       CitationStyle cs = styles[size_type(ind)];
        vector<docstring> pretexts = getPreTexts();
        vector<docstring> posttexts = getPostTexts();
        bool const qualified = cs.hasQualifiedList