]> git.lyx.org Git - lyx.git/blobdiff - src/frontends/qt4/GuiApplication.cpp
Fix crash noticed by Bennett:
[lyx.git] / src / frontends / qt4 / GuiApplication.cpp
index ff2028fcb960b687492fb26d17c4c7adec41a9fa..6b0a78adaaa693a76bc20c5eda488552de9cd68b 100644 (file)
@@ -15,6 +15,7 @@
 #include "GuiApplication.h"
 
 #include "ColorCache.h"
+#include "ColorSet.h"
 #include "GuiClipboard.h"
 #include "GuiImage.h"
 #include "GuiKeySymbol.h"
@@ -49,6 +50,7 @@
 #include "support/debug.h"
 #include "support/ExceptionMessage.h"
 #include "support/FileName.h"
+#include "support/filetools.h"
 #include "support/foreach.h"
 #include "support/ForkedCalls.h"
 #include "support/gettext.h"
 #include "support/linkback/LinkBackProxy.h"
 #endif
 
+#include <queue>
+
 #include <QByteArray>
 #include <QClipboard>
+#include <QDateTime>
 #include <QDir>
 #include <QEventLoop>
 #include <QFileOpenEvent>
 
 #ifdef Q_WS_WIN
 #include <QWindowsMime>
-#if defined(Q_CYGWIN_WIN) || defined(Q_CC_MINGW)
+#ifdef Q_CC_GNU
 #include <wtypes.h>
 #endif
 #include <objidl.h>
@@ -130,6 +135,19 @@ namespace lyx {
 
 frontend::Application * createApplication(int & argc, char * argv[])
 {
+#ifndef Q_WS_X11
+       // prune -geometry argument(s) by shifting
+       // the following ones 2 places down.
+       for (int i = 0 ; i < argc ; ++i) {
+               if (strcmp(argv[i], "-geometry") == 0) {
+                       int const remove = (i+1) < argc ? 2 : 1;
+                       argc -= remove;
+                       for (int j = i; j < argc; ++j)
+                               argv[j] = argv[j + remove];
+                       --i;
+               }
+       }
+#endif
        return new frontend::GuiApplication(argc, argv);
 }
 
@@ -162,9 +180,12 @@ vector<string> loadableImageFormats()
 
        return fmts;
 }
-       
+
+
 ////////////////////////////////////////////////////////////////////////
-// Icon loading support code.
+//
+// Icon loading support code
+//
 ////////////////////////////////////////////////////////////////////////
 
 namespace {
@@ -293,6 +314,14 @@ QString iconName(FuncRequest const & f, bool unknown)
                path = "commands/";
                name1 = toqstr(f.argument());
                break;
+       case LFUN_COMMAND_ALTERNATIVES: {
+               // use the first of the alternative commands
+               docstring firstcom;
+               docstring dummy = split(f.argument(), firstcom, ';');
+               name1 = toqstr(firstcom);
+               name1.replace(' ', '_');
+               break;
+       }
        default:
                name2 = toqstr(lyxaction.getActionName(f.action));
                name1 = name2;
@@ -300,6 +329,7 @@ QString iconName(FuncRequest const & f, bool unknown)
                if (!f.argument().empty()) {
                        name1 = name2 + ' ' + toqstr(f.argument());
                        name1.replace(' ', '_');
+                       name1.replace('\\', "backslash");
                }
        }
 
@@ -325,16 +355,44 @@ QString iconName(FuncRequest const & f, bool unknown)
        if (res.exists(name2))
                return path + name2;
 
-       LYXERR(Debug::GUI, "Cannot find icon for command \""
+       LYXERR(Debug::GUI, "Cannot find icon with filename "
+                          << "\"" << name1 << "\""
+                          << " or filename "
+                          << "\"" << name2 << "\"" 
+                          << " for command \""
                           << lyxaction.getActionName(f.action)
                           << '(' << to_utf8(f.argument()) << ")\"");
 
-       if (unknown)
+       if (unknown) {
+               fname = libFileSearch(QString("images/"), "unknown", "png");
+               if (fname.exists())
+                       return toqstr(fname.absFilename());
                return QString(":/images/unknown.png");
+       }
 
        return QString();
 }
 
+QPixmap getPixmap(QString const & path, QString const & name, QString const & ext)
+{
+       QPixmap pixmap;
+       FileName fname = libFileSearch(path, name, ext);
+       QString path1 = toqstr(fname.absFilename());
+       QString path2 = ":/" + path + name + "." + ext;
+
+       if (pixmap.load(path1)) {
+               return pixmap;
+       }
+       else if (pixmap.load(path2)) {
+               return pixmap;
+       }
+
+       LYXERR0("Cannot load pixmap \""
+               << path << name << '.' << ext
+               << "\", please verify resource system!");
+
+       return QPixmap();
+}
 
 QIcon getIcon(FuncRequest const & f, bool unknown)
 {
@@ -354,8 +412,11 @@ QIcon getIcon(FuncRequest const & f, bool unknown)
 
 
 ////////////////////////////////////////////////////////////////////////
+//
 // LyX server support code.
+//
 ////////////////////////////////////////////////////////////////////////
+
 class SocketNotifier : public QSocketNotifier
 {
 public:
@@ -371,7 +432,9 @@ public:
 
 
 ////////////////////////////////////////////////////////////////////////
+//
 // Mac specific stuff goes here...
+//
 ////////////////////////////////////////////////////////////////////////
 
 class MenuTranslator : public QTranslator
@@ -468,8 +531,9 @@ public:
 #endif
 
 ///////////////////////////////////////////////////////////////
-// You can find more platform specific stuff
-// at the end of this file...
+//
+// You can find more platform specific stuff at the end of this file...
+//
 ///////////////////////////////////////////////////////////////
 
 ////////////////////////////////////////////////////////////////////////
@@ -551,11 +615,12 @@ public:
        }
 
 
-       QVector<FORMATETC> formatsForMime(QString const & mimeType,
-               QMimeData const * mimeData) const
+       QVector<FORMATETC> formatsForMime(QString const & mimetype,
+               QMimeData const * mimedata) const
        {
                QVector<FORMATETC> formats;
-               formats += cfFromMime(mimeType);
+               if (mimetype == emfMimeType() || mimetype == wmfMimeType())
+                       formats += cfFromMime(mimetype);
                return formats;
        }
 
@@ -579,14 +644,12 @@ public:
 
 struct GuiApplication::Private
 {
-       Private()
-               : language_model_(0), global_menubar_(0)
+       Private(): language_model_(0), global_menubar_(0) 
        {
-#ifdef Q_WS_MACX
-               // Create the global default menubar which is shown for the dialogs
-               // and if no GuiView is visible.
-               global_menubar_ = new GlobalMenuBar();
-#endif
+       #ifdef Q_WS_WIN
+               /// WMF Mime handler for Windows clipboard.
+               wmf_mime_ = new QWindowsMimeMetafile();
+       #endif
        }
 
        ///
@@ -614,6 +677,9 @@ struct GuiApplication::Private
        /// are done.
        QTimer general_timer_;
 
+       /// delayed FuncRequests
+       std::queue<FuncRequest> func_request_queue_;
+
        /// Multiple views container.
        /**
        * Warning: This must not be a smart pointer as the destruction of the
@@ -632,8 +698,7 @@ struct GuiApplication::Private
 
 #ifdef Q_WS_WIN
        /// WMF Mime handler for Windows clipboard.
-       /// \warning: see comment in ~GuiApplication and in bug 4846.
-       QWindowsMimeMetafile wmf_mime_;
+       QWindowsMimeMetafile * wmf_mime_;
 #endif
 };
 
@@ -645,24 +710,18 @@ GuiApplication::~GuiApplication()
 #ifdef Q_WS_MACX
        closeAllLinkBackLinks();
 #endif
-       // FIXME: Work around bug 4846 for Windows Vista and Qt4
-       // (see http://bugzilla.lyx.org/show_bug.cgi?id=4846)
-       // If the clipboard is not cleared, LyX crashes on exit when it is
-       // compiled in release mode and if there is something in the clipboard.
-       // This is related to QWindowsMimeMetafile which is apparently not 
-       // properly destroyed.
-       qApp->clipboard()->clear(QClipboard::Clipboard);
        delete d;
 }
 
 
 GuiApplication::GuiApplication(int & argc, char ** argv)
-       : QApplication(argc, argv),     current_view_(0), d(new GuiApplication::Private)
+       : QApplication(argc, argv), current_view_(0),
+         d(new GuiApplication::Private)
 {
        QString app_name = "LyX";
        QCoreApplication::setOrganizationName(app_name);
        QCoreApplication::setOrganizationDomain("lyx.org");
-       QCoreApplication::setApplicationName(app_name + "-" + lyx_version);
+       QCoreApplication::setApplicationName(lyx_package);
 
        // Install translator for GUI elements.
        installTranslator(&d->qt_trans_);
@@ -722,6 +781,12 @@ GuiApplication::GuiApplication(int & argc, char ** argv)
 }
 
 
+GuiApplication * theGuiApp()
+{
+       return dynamic_cast<GuiApplication *>(theApp());
+}
+
+
 void GuiApplication::clearSession()
 {
        QSettings settings;
@@ -735,6 +800,20 @@ docstring GuiApplication::iconName(FuncRequest const & f, bool unknown)
 }
 
 
+LyXView * GuiApplication::currentWindow() 
+{
+#ifdef Q_WS_MACX
+       /* In LyX/Mac, when a dialog is open, the menus of the
+          application can still be accessed without giving focus to
+          the main window. In this case, we want to disable the menu
+          entries that are buffer or view-related.
+       */
+       if (current_view_ && activeWindow() != current_view_)
+               return 0;
+#endif
+       return current_view_;
+}
+
 
 bool GuiApplication::getStatus(FuncRequest const & cmd, FuncStatus & flag) const
 {
@@ -749,6 +828,7 @@ bool GuiApplication::getStatus(FuncRequest const & cmd, FuncStatus & flag) const
        case LFUN_BUFFER_NEW:
        case LFUN_BUFFER_NEW_TEMPLATE:
        case LFUN_FILE_OPEN:
+       case LFUN_HELP_OPEN:
        case LFUN_SCREEN_FONT_UPDATE:
        case LFUN_SET_COLOR:
        case LFUN_WINDOW_NEW:
@@ -779,6 +859,9 @@ bool GuiApplication::dispatch(FuncRequest const & cmd)
                // update bookmark pit of the current buffer before window close
                for (size_t i = 0; i < theSession().bookmarks().size(); ++i)
                        theLyXFunc().gotoBookmark(i+1, false, false);
+               // clear the last opened list, because
+               // maybe this will end the session
+               theSession().lastOpened().clear();
                current_view_->close();
                break;
 
@@ -810,7 +893,7 @@ bool GuiApplication::dispatch(FuncRequest const & cmd)
 
        case LFUN_BUFFER_NEW:
                if (d->views_.empty()
-                   || (!lyxrc.open_buffers_in_tabs && current_view_->buffer() != 0)) {
+                   || (!lyxrc.open_buffers_in_tabs && current_view_->documentBufferView() != 0)) {
                        createView(QString(), false); // keep hidden
                        current_view_->newDocument(to_utf8(cmd.argument()), false);
                        current_view_->show();
@@ -822,10 +905,10 @@ bool GuiApplication::dispatch(FuncRequest const & cmd)
 
        case LFUN_BUFFER_NEW_TEMPLATE:
                if (d->views_.empty()
-                   || (!lyxrc.open_buffers_in_tabs && current_view_->buffer() != 0)) {
+                   || (!lyxrc.open_buffers_in_tabs && current_view_->documentBufferView() != 0)) {
                        createView();
                        current_view_->newDocument(to_utf8(cmd.argument()), true);
-                       if (!current_view_->buffer())
+                       if (!current_view_->documentBufferView())
                                current_view_->close();
                } else {
                        current_view_->newDocument(to_utf8(cmd.argument()), true);
@@ -833,8 +916,9 @@ bool GuiApplication::dispatch(FuncRequest const & cmd)
                break;
 
        case LFUN_FILE_OPEN:
+               // FIXME: create a new method shared with LFUN_HELP_OPEN.
                if (d->views_.empty()
-                   || (!lyxrc.open_buffers_in_tabs && current_view_->buffer() != 0)) {
+                   || (!lyxrc.open_buffers_in_tabs && current_view_->documentBufferView() != 0)) {
                        string const fname = to_utf8(cmd.argument());
                        // We want the ui session to be saved per document and not per
                        // window number. The filename crc is a good enough identifier.
@@ -842,12 +926,41 @@ bool GuiApplication::dispatch(FuncRequest const & cmd)
                        crc = for_each(fname.begin(), fname.end(), crc);
                        createView(crc.checksum());
                        current_view_->openDocument(fname);
-                       if (!current_view_->buffer())
+                       if (current_view_ && !current_view_->documentBufferView())
                                current_view_->close();
                } else
                        current_view_->openDocument(to_utf8(cmd.argument()));
                break;
 
+       case LFUN_HELP_OPEN: {
+               // FIXME: create a new method shared with LFUN_FILE_OPEN.
+               if (current_view_ == 0)
+                       createView();
+               string const arg = to_utf8(cmd.argument());
+               if (arg.empty()) {
+                       current_view_->message(_("Missing argument"));
+                       break;
+               }
+               FileName fname = i18nLibFileSearch("doc", arg, "lyx");
+               if (fname.empty()) 
+                       fname = i18nLibFileSearch("examples", arg, "lyx");
+
+               if (fname.empty()) {
+                       lyxerr << "LyX: unable to find documentation file `"
+                               << arg << "'. Bad installation?" << endl;
+                       break;
+               }
+               current_view_->message(bformat(_("Opening help file %1$s..."),
+                       makeDisplayPath(fname.absFilename())));
+               Buffer * buf = current_view_->loadDocument(fname, false);
+               if (buf) {
+                       current_view_->setBuffer(buf);
+                       buf->updateLabels();
+                       buf->errors("Parse");
+               }
+               break;
+       }
+
        case LFUN_SET_COLOR: {
                string lyx_name;
                string const x11_name = split(to_utf8(cmd.argument()), lyx_name, ' ');
@@ -890,6 +1003,13 @@ bool GuiApplication::dispatch(FuncRequest const & cmd)
 }
 
 
+void GuiApplication::dispatchDelayed(FuncRequest const & func)
+{
+       d->func_request_queue_.push(func);
+       QTimer::singleShot(0, this, SLOT(processFuncRequestQueue()));
+}
+
+
 void GuiApplication::resetGui()
 {
        // Set the language defined by the user.
@@ -900,21 +1020,13 @@ void GuiApplication::resetGui()
                // Gives some error box here.
                return;
 
-#ifdef Q_WS_MACX
-       d->global_menubar_->clear();
-       delete d->global_menubar_;
-       // Create the global default menubar which is shown for the dialogs
-       // and if no GuiView is visible.
-       d->global_menubar_ = new GlobalMenuBar();
-
-       // init the global menubar on Mac. This must be done after the session
-       // was recovered to know the "last files".
-       d->menus_.fillMenuBar(d->global_menubar_, 0, true);
-#endif
+       if (d->global_menubar_)
+               d->menus_.fillMenuBar(d->global_menubar_, 0, false);
 
        QHash<int, GuiView *>::iterator it;
        for (it = d->views_.begin(); it != d->views_.end(); ++it) {
                GuiView * gv = *it;
+               setCurrentView(gv);
                gv->setLayoutDirection(layoutDirection());
                gv->resetDialogs();
        }
@@ -939,10 +1051,9 @@ void GuiApplication::createView(QString const & geometry_arg, bool autoShow,
 
        // create new view
        int id = view_id;
-       if (id == 0) {
-               while (d->views_.find(id) != d->views_.end())
-                       id++;
-       }
+       while (d->views_.find(id) != d->views_.end())
+               id++;
+
        LYXERR(Debug::GUI, "About to create new window with ID " << id);
        GuiView * view = new GuiView(id);
        // register view
@@ -967,7 +1078,6 @@ void GuiApplication::createView(QString const & geometry_arg, bool autoShow,
 #endif
        }
        view->setFocus();
-       setCurrentView(view);
 }
 
 
@@ -1027,7 +1137,11 @@ ColorCache & GuiApplication::colorCache()
 
 int GuiApplication::exec()
 {
-       QTimer::singleShot(1, this, SLOT(execBatchCommands()));
+       // asynchronously handle batch commands. This event will be in
+       // the event queue in front of other asynchronous events. Hence,
+       // we can assume in the latter that the gui is setup already.
+       QTimer::singleShot(0, this, SLOT(execBatchCommands()));
+
        return QApplication::exec();
 }
 
@@ -1077,6 +1191,15 @@ void GuiApplication::setGuiLanguage()
 }
 
 
+void GuiApplication::processFuncRequestQueue()
+{
+       while (!d->func_request_queue_.empty()) {
+               lyx::dispatch(d->func_request_queue_.back());
+               d->func_request_queue_.pop();
+       }
+}
+
+
 void GuiApplication::execBatchCommands()
 {
        setGuiLanguage();
@@ -1086,10 +1209,13 @@ void GuiApplication::execBatchCommands()
                // Gives some error box here.
                return;
 
-       // init the global menubar on Mac. This must be done after the session
-       // was recovered to know the "last files".
-       if (d->global_menubar_)
-               d->menus_.fillMenuBar(d->global_menubar_, 0, true);
+#ifdef Q_WS_MACX
+       // Create the global default menubar which is shown for the dialogs
+       // and if no GuiView is visible.
+       // This must be done after the session was recovered to know the "last files".
+       d->global_menubar_ = new GlobalMenuBar();
+       d->menus_.fillMenuBar(d->global_menubar_, 0, true);
+#endif
 
        lyx::execBatchCommands();
 }
@@ -1127,12 +1253,32 @@ void GuiApplication::restoreGuiSession()
                return;
 
        Session & session = theSession();
-       vector<FileName> const & lastopened = session.lastOpened().getfiles();
+       LastOpenedSection::LastOpened const & lastopened = 
+               session.lastOpened().getfiles();
+
+       FileName active_file;
        // do not add to the lastfile list since these files are restored from
        // last session, and should be already there (regular files), or should
        // not be added at all (help files).
-       for_each(lastopened.begin(), lastopened.end(),
-               bind(&GuiView::loadDocument, current_view_, _1, false));
+       for (size_t i = 0; i < lastopened.size(); ++i) {
+               FileName const & file_name = lastopened[i].file_name;
+               if (d->views_.empty() || (!lyxrc.open_buffers_in_tabs
+                         && current_view_->documentBufferView() != 0)) {
+                       boost::crc_32_type crc;
+                       string const & fname = file_name.absFilename();
+                       crc = for_each(fname.begin(), fname.end(), crc);
+                       createView(crc.checksum());
+               }
+               current_view_->loadDocument(file_name, false);
+
+               if (lastopened[i].active)
+                       active_file = file_name;
+       }
+
+       // Restore last active buffer
+       Buffer * buffer = theBufferList().getBuffer(active_file);
+       if (buffer)
+               current_view_->setBuffer(buffer);
 
        // clear this list to save a few bytes of RAM
        session.lastOpened().clear();
@@ -1182,10 +1328,13 @@ bool GuiApplication::event(QEvent * e)
 {
        switch(e->type()) {
        case QEvent::FileOpen: {
-               // Open a file; this happens only on Mac OS X for now
+               // Open a file; this happens only on Mac OS X for now.
+               //
+               // We do this asynchronously because on startup the batch
+               // commands are not executed here yet and the gui is not ready
+               // therefore.
                QFileOpenEvent * foe = static_cast<QFileOpenEvent *>(e);
-               lyx::dispatch(FuncRequest(LFUN_FILE_OPEN,
-                       qstring_to_ucs4(foe->file())));
+               dispatchDelayed(FuncRequest(LFUN_FILE_OPEN, qstring_to_ucs4(foe->file())));
                e->accept();
                return true;
        }
@@ -1215,9 +1364,11 @@ bool GuiApplication::notify(QObject * receiver, QEvent * event)
                        this->exit(1);
 
                case BufferException: {
-                       Buffer * buf = current_view_->buffer();
+                       if (!current_view_->documentBufferView())
+                               return false;
+                       Buffer * buf = &current_view_->documentBufferView()->buffer();
                        docstring details = e.details_ + '\n';
-                       details += theBufferList().emergencyWrite(buf);
+                       details += buf->emergencyWrite();
                        theBufferList().release(buf);
                        details += "\n" + _("The current document was closed.");
                        Alert::error(e.title_, details);
@@ -1307,10 +1458,8 @@ void GuiApplication::unregisterView(GuiView * gv)
 {
        LASSERT(d->views_[gv->id()] == gv, /**/);
        d->views_.remove(gv->id());
-       if (current_view_ == gv) {
+       if (current_view_ == gv)
                current_view_ = 0;
-               theLyXFunc().setLyXView(0);
-       }
 }
 
 
@@ -1319,6 +1468,10 @@ bool GuiApplication::closeAllViews()
        if (d->views_.empty())
                return true;
 
+       // When a view/window was closed before without quitting LyX, there
+       // are already entries in the lastOpened list.
+       theSession().lastOpened().clear();
+
        QList<GuiView *> views = d->views_.values();
        foreach (GuiView * view, views) {
                if (!view->close())
@@ -1366,21 +1519,6 @@ bool GuiApplication::searchMenu(FuncRequest const & func,
 
 bool GuiApplication::readUIFile(QString const & name, bool include)
 {
-       enum {
-               ui_menuset = 1,
-               ui_toolbars,
-               ui_toolbarset,
-               ui_include,
-               ui_last
-       };
-
-       LexerKeyword uitags[] = {
-               { "include", ui_include },
-               { "menuset", ui_menuset },
-               { "toolbars", ui_toolbars },
-               { "toolbarset", ui_toolbarset }
-       };
-
        LYXERR(Debug::INIT, "About to read " << name << "...");
 
        FileName ui_path;
@@ -1393,14 +1531,29 @@ bool GuiApplication::readUIFile(QString const & name, bool include)
        }
 
        if (ui_path.empty()) {
+               static const QString defaultUIFile = "default";
                LYXERR(Debug::INIT, "Could not find " << name);
+               if (include) {
+                       Alert::warning(_("Could not find UI definition file"),
+                               bformat(_("Error while reading the included file\n%1$s\n"
+                                       "Please check your installation."), qstring_to_ucs4(name)));
+                       return false;
+               }
+               if (name == defaultUIFile) {
+                       LYXERR(Debug::INIT, "Could not find default UI file!!");
+                       Alert::warning(_("Could not find default UI file"),
+                               _("LyX could not find the default UI file!\n"
+                                 "Please check your installation."));
+                       return false;
+               }
                Alert::warning(_("Could not find UI definition file"),
-                              bformat(_("Error while reading the configuration file\n%1$s.\n"
-                                  "Please check your installation."), qstring_to_ucs4(name)));
-               return false;
+               bformat(_("Error while reading the configuration file\n%1$s\n"
+                       "Falling back to default.\n"
+                       "Please look under Tools>Preferences>User Interface and\n"
+                       "check which User Interface file you are using."), qstring_to_ucs4(name)));
+               return readUIFile(defaultUIFile, false);
        }
 
-
        // Ensure that a file is read only once (prevents include loops)
        static QStringList uifiles;
        QString const uifile = toqstr(ui_path.absFilename());
@@ -1420,6 +1573,21 @@ bool GuiApplication::readUIFile(QString const & name, bool include)
 
        LYXERR(Debug::INIT, "Found " << name << " in " << ui_path);
 
+       enum {
+               ui_menuset = 1,
+               ui_toolbars,
+               ui_toolbarset,
+               ui_include,
+               ui_last
+       };
+
+       LexerKeyword uitags[] = {
+               { "include", ui_include },
+               { "menuset", ui_menuset },
+               { "toolbars", ui_toolbars },
+               { "toolbarset", ui_toolbarset }
+       };
+
        Lexer lex(uitags);
        lex.setFile(ui_path);
        if (!lex.isOK()) {
@@ -1430,6 +1598,9 @@ bool GuiApplication::readUIFile(QString const & name, bool include)
        if (lyxerr.debugging(Debug::PARSER))
                lex.printTable(lyxerr);
 
+       // store which ui files define Toolbars
+       static QStringList toolbar_uifiles;
+
        while (lex.isOK()) {
                switch (lex.lex()) {
                case ui_include: {
@@ -1449,6 +1620,7 @@ bool GuiApplication::readUIFile(QString const & name, bool include)
 
                case ui_toolbars:
                        d->toolbars_.readToolbarSettings(lex);
+                       toolbar_uifiles.push_back(uifile);
                        break;
 
                default:
@@ -1469,9 +1641,12 @@ bool GuiApplication::readUIFile(QString const & name, bool include)
                QFileInfo fi(uifiles[i]);
                QDateTime const date_value = fi.lastModified();
                QString const name_key = QString::number(i);
-               if (!settings.contains(name_key)
+               // if an ui file which defines Toolbars has changed,
+               // we have to reset the settings
+               if (toolbar_uifiles.contains(uifiles[i])
+                && (!settings.contains(name_key)
                 || settings.value(name_key).toString() != uifiles[i]
-                || settings.value(name_key + "/date").toDateTime() != date_value) {
+                || settings.value(name_key + "/date").toDateTime() != date_value)) {
                        touched = true;
                        settings.setValue(name_key, uifiles[i]);
                        settings.setValue(name_key + "/date", date_value);
@@ -1507,7 +1682,7 @@ bool GuiApplication::x11EventFilter(XEvent * xev)
                if (xev->xselectionrequest.selection != XA_PRIMARY)
                        break;
                LYXERR(Debug::SELECTION, "X requested selection.");
-               BufferView * bv = current_view_->view();
+               BufferView * bv = current_view_->currentBufferView();
                if (bv) {
                        docstring const sel = bv->requestSelection();
                        if (!sel.empty())
@@ -1519,7 +1694,7 @@ bool GuiApplication::x11EventFilter(XEvent * xev)
                if (xev->xselectionclear.selection != XA_PRIMARY)
                        break;
                LYXERR(Debug::SELECTION, "Lost selection.");
-               BufferView * bv = current_view_->view();
+               BufferView * bv = current_view_->currentBufferView();
                if (bv)
                        bv->clearSelection();
                break;
@@ -1584,6 +1759,7 @@ frontend::Selection & theSelection()
        return frontend::guiApp->selection();
 }
 
+
 } // namespace lyx
 
-#include "GuiApplication_moc.cpp"
+#include "moc_GuiApplication.cpp"