]> git.lyx.org Git - lyx.git/blobdiff - src/frontends/qt4/GuiApplication.cpp
If we are in a closeEvent, we don't want to close all buffers, because these may...
[lyx.git] / src / frontends / qt4 / GuiApplication.cpp
index 2a5e318a46538dc61b0270ce8d05278c37370f43..01672acfe60997153bc36583ece93c30d7c3dbcb 100644 (file)
 
 #include "GuiApplication.h"
 
-#include "qt_helpers.h"
+#include "ColorCache.h"
+#include "ColorSet.h"
+#include "GuiClipboard.h"
 #include "GuiImage.h"
 #include "GuiKeySymbol.h"
+#include "GuiSelection.h"
 #include "GuiView.h"
+#include "Menus.h"
+#include "qt_helpers.h"
+#include "Toolbars.h"
 
 #include "frontends/alert.h"
 #include "frontends/Application.h"
 #include "Buffer.h"
 #include "BufferList.h"
 #include "BufferView.h"
+#include "Color.h"
 #include "Font.h"
 #include "FuncRequest.h"
 #include "FuncStatus.h"
 #include "Language.h"
+#include "Lexer.h"
 #include "LyX.h"
+#include "LyXAction.h"
 #include "LyXFunc.h"
 #include "LyXRC.h"
 #include "Session.h"
 #include "support/debug.h"
 #include "support/ExceptionMessage.h"
 #include "support/FileName.h"
+#include "support/foreach.h"
 #include "support/ForkedCalls.h"
 #include "support/gettext.h"
 #include "support/lstrings.h"
+#include "support/lyxalgo.h" // sorted
+#include "support/Messages.h"
 #include "support/os.h"
 #include "support/Package.h"
 
 #include "support/linkback/LinkBackProxy.h"
 #endif
 
+#include <queue>
+
+#include <QByteArray>
 #include <QClipboard>
+#include <QDateTime>
+#include <QDir>
 #include <QEventLoop>
 #include <QFileOpenEvent>
+#include <QFileInfo>
+#include <QHash>
+#include <QIcon>
+#include <QImageReader>
 #include <QLocale>
 #include <QLibraryInfo>
+#include <QList>
 #include <QMacPasteboardMime>
 #include <QMenuBar>
 #include <QMimeData>
+#include <QObject>
+#include <QPixmap>
 #include <QPixmapCache>
 #include <QRegExp>
 #include <QSessionManager>
+#include <QSettings>
 #include <QSocketNotifier>
 #include <QSortFilterProxyModel>
 #include <QStandardItemModel>
 #endif
 
 #ifdef Q_WS_WIN
-#include <QVector>
 #include <QWindowsMime>
-#if defined(Q_CYGWIN_WIN) || defined(Q_CC_MINGW)
+#ifdef Q_CC_GNU
 #include <wtypes.h>
 #endif
 #include <objidl.h>
 #endif // Q_WS_WIN
 
 #include <boost/bind.hpp>
+#include <boost/crc.hpp>
 
 #include <exception>
+#include <vector>
 
 using namespace std;
 using namespace lyx::support;
 
-// FIXME: These strings are also used in GuiClipboard.cpp.
-static char const * const lyx_mime_type = "application/x-lyx";
-static char const * const pdf_mime_type = "application/pdf";
-static char const * const emf_mime_type = "image/x-emf";
-static char const * const wmf_mime_type = "image/x-wmf";
+
+static void initializeResources()
+{
+       static bool initialized = false;
+       if (!initialized) {
+               Q_INIT_RESOURCE(Resources); 
+               initialized = true;
+       }
+}
+
 
 namespace lyx {
 
 frontend::Application * createApplication(int & argc, char * argv[])
 {
+#ifndef Q_WS_X11
+       // prune -geometry argument(s) by shifting
+       // the following ones 2 places down.
+       for (int i = 0 ; i < argc ; ++i) {
+               if (strcmp(argv[i], "-geometry") == 0) {
+                       int const remove = (i+1) < argc ? 2 : 1;
+                       argc -= remove;
+                       for (int j = i; j < argc; ++j)
+                               argv[j] = argv[j + remove];
+                       --i;
+               }
+       }
+#endif
        return new frontend::GuiApplication(argc, argv);
 }
 
-
 namespace frontend {
 
+
+/// Return the list of loadable formats.
+vector<string> loadableImageFormats()
+{
+       vector<string> fmts;
+
+       QList<QByteArray> qt_formats = QImageReader::supportedImageFormats();
+
+       LYXERR(Debug::GRAPHICS,
+               "\nThe image loader can load the following directly:\n");
+
+       if (qt_formats.empty())
+               LYXERR(Debug::GRAPHICS, "\nQt4 Problem: No Format available!");
+
+       for (QList<QByteArray>::const_iterator it = qt_formats.begin(); it != qt_formats.end(); ++it) {
+
+               LYXERR(Debug::GRAPHICS, (const char *) *it << ", ");
+
+               string ext = ascii_lowercase((const char *) *it);
+               // special case
+               if (ext == "jpeg")
+                       ext = "jpg";
+               fmts.push_back(ext);
+       }
+
+       return fmts;
+}
+
+
+////////////////////////////////////////////////////////////////////////
+//
+// Icon loading support code
+//
+////////////////////////////////////////////////////////////////////////
+
+namespace {
+
+struct PngMap {
+       QString key;
+       QString value;
+};
+
+
+bool operator<(PngMap const & lhs, PngMap const & rhs)
+{
+       return lhs.key < rhs.key;
+}
+
+
+class CompareKey {
+public:
+       CompareKey(QString const & name) : name_(name) {}
+       bool operator()(PngMap const & other) const { return other.key == name_; }
+private:
+       QString const name_;
+};
+
+
+// this must be sorted alphabetically
+// Upper case comes before lower case
+PngMap sorted_png_map[] = {
+       { "Bumpeq", "bumpeq2" },
+       { "Cap", "cap2" },
+       { "Cup", "cup2" },
+       { "Delta", "delta2" },
+       { "Downarrow", "downarrow2" },
+       { "Gamma", "gamma2" },
+       { "Lambda", "lambda2" },
+       { "Leftarrow", "leftarrow2" },
+       { "Leftrightarrow", "leftrightarrow2" },
+       { "Longleftarrow", "longleftarrow2" },
+       { "Longleftrightarrow", "longleftrightarrow2" },
+       { "Longrightarrow", "longrightarrow2" },
+       { "Omega", "omega2" },
+       { "Phi", "phi2" },
+       { "Pi", "pi2" },
+       { "Psi", "psi2" },
+       { "Rightarrow", "rightarrow2" },
+       { "Sigma", "sigma2" },
+       { "Subset", "subset2" },
+       { "Supset", "supset2" },
+       { "Theta", "theta2" },
+       { "Uparrow", "uparrow2" },
+       { "Updownarrow", "updownarrow2" },
+       { "Upsilon", "upsilon2" },
+       { "Vdash", "vdash3" },
+       { "Vert", "vert2" },
+       { "Xi", "xi2" },
+       { "nLeftarrow", "nleftarrow2" },
+       { "nLeftrightarrow", "nleftrightarrow2" },
+       { "nRightarrow", "nrightarrow2" },
+       { "nVDash", "nvdash3" },
+       { "nvDash", "nvdash2" },
+       { "textrm \\AA", "textrm_AA"},
+       { "textrm \\O", "textrm_O"},
+       { "vDash", "vdash2" }
+};
+
+size_t const nr_sorted_png_map = sizeof(sorted_png_map) / sizeof(PngMap);
+
+
+QString findPng(QString const & name)
+{
+       PngMap const * const begin = sorted_png_map;
+       PngMap const * const end = begin + nr_sorted_png_map;
+       LASSERT(sorted(begin, end), /**/);
+
+       PngMap const * const it = find_if(begin, end, CompareKey(name));
+
+       QString png_name;
+       if (it != end) {
+               png_name = it->value;
+       } else {
+               png_name = name;
+               png_name.replace('_', "underscore");
+               png_name.replace(' ', '_');
+
+               // This way we can have "math-delim { }" on the toolbar.
+               png_name.replace('(', "lparen");
+               png_name.replace(')', "rparen");
+               png_name.replace('[', "lbracket");
+               png_name.replace(']', "rbracket");
+               png_name.replace('{', "lbrace");
+               png_name.replace('}', "rbrace");
+               png_name.replace('|', "bars");
+               png_name.replace(',', "thinspace");
+               png_name.replace(':', "mediumspace");
+               png_name.replace(';', "thickspace");
+               png_name.replace('!', "negthinspace");
+       }
+
+       LYXERR(Debug::GUI, "findPng(" << name << ")\n"
+               << "Looking for math PNG called \"" << png_name << '"');
+       return png_name;
+}
+
+} // namespace anon
+
+
+QString iconName(FuncRequest const & f, bool unknown)
+{
+       initializeResources();
+       QString name1;
+       QString name2;
+       QString path;
+       switch (f.action) {
+       case LFUN_MATH_INSERT:
+               if (!f.argument().empty()) {
+                       path = "math/";
+                       name1 = findPng(toqstr(f.argument()).mid(1));
+               }
+               break;
+       case LFUN_MATH_DELIM:
+       case LFUN_MATH_BIGDELIM:
+               path = "math/";
+               name1 = findPng(toqstr(f.argument()));
+               break;
+       case LFUN_CALL:
+               path = "commands/";
+               name1 = toqstr(f.argument());
+               break;
+       case LFUN_COMMAND_ALTERNATIVES: {
+               // use the first of the alternative commands
+               docstring firstcom;
+               docstring dummy = split(f.argument(), firstcom, ';');
+               name1 = toqstr(firstcom);
+               name1.replace(' ', '_');
+               break;
+       }
+       default:
+               name2 = toqstr(lyxaction.getActionName(f.action));
+               name1 = name2;
+
+               if (!f.argument().empty()) {
+                       name1 = name2 + ' ' + toqstr(f.argument());
+                       name1.replace(' ', '_');
+                       name1.replace('\\', "backslash");
+               }
+       }
+
+       FileName fname = libFileSearch("images/" + path, name1, "png");
+       if (fname.exists())
+               return toqstr(fname.absFilename());
+
+       fname = libFileSearch("images/" + path, name2, "png");
+       if (fname.exists())
+               return toqstr(fname.absFilename());
+
+       path = ":/images/" + path;
+       QDir res(path);
+       if (!res.exists()) {
+               LYXERR0("Directory " << path << " not found in resource!"); 
+               return QString();
+       }
+       name1 += ".png";
+       if (res.exists(name1))
+               return path + name1;
+
+       name2 += ".png";
+       if (res.exists(name2))
+               return path + name2;
+
+       LYXERR(Debug::GUI, "Cannot find icon with filename "
+                          << "\"" << name1 << "\""
+                          << " or filename "
+                          << "\"" << name2 << "\"" 
+                          << " for command \""
+                          << lyxaction.getActionName(f.action)
+                          << '(' << to_utf8(f.argument()) << ")\"");
+
+       if (unknown) {
+               fname = libFileSearch(QString("images/"), "unknown", "png");
+               if (fname.exists())
+                       return toqstr(fname.absFilename());
+               return QString(":/images/unknown.png");
+       }
+
+       return QString();
+}
+
+QPixmap getPixmap(QString const & path, QString const & name, QString const & ext)
+{
+       QPixmap pixmap;
+       FileName fname = libFileSearch(path, name, ext);
+       QString path1 = toqstr(fname.absFilename());
+       QString path2 = ":/" + path + name + "." + ext;
+
+       if (pixmap.load(path1)) {
+               return pixmap;
+       }
+       else if (pixmap.load(path2)) {
+               return pixmap;
+       }
+
+       LYXERR0("Cannot load pixmap \""
+               << path << name << '.' << ext
+               << "\", please verify resource system!");
+
+       return QPixmap();
+}
+
+QIcon getIcon(FuncRequest const & f, bool unknown)
+{
+       QString icon = iconName(f, unknown);
+       if (icon.isEmpty())
+               return QIcon();
+
+       //LYXERR(Debug::GUI, "Found icon: " << icon);
+       QPixmap pm;
+       if (!pm.load(icon)) {
+               LYXERR0("Cannot load icon " << icon << " please verify resource system!");
+               return QIcon();
+       }
+
+       return QIcon(pm);
+}
+
+
+////////////////////////////////////////////////////////////////////////
+//
+// LyX server support code.
+//
+////////////////////////////////////////////////////////////////////////
+
 class SocketNotifier : public QSocketNotifier
 {
 public:
@@ -124,7 +431,10 @@ public:
 
 
 ////////////////////////////////////////////////////////////////////////
+//
 // Mac specific stuff goes here...
+//
+////////////////////////////////////////////////////////////////////////
 
 class MenuTranslator : public QTranslator
 {
@@ -183,7 +493,7 @@ public:
        QString flavorFor(QString const & mime)
        {
                LYXERR(Debug::ACTION, "flavorFor " << mime);
-               if (mime == QLatin1String(pdf_mime_type))
+               if (mime == pdfMimeType())
                        return QLatin1String("com.adobe.pdf");
                return QString();
        }
@@ -192,21 +502,25 @@ public:
        {
                LYXERR(Debug::ACTION, "mimeFor " << flav);
                if (flav == QLatin1String("com.adobe.pdf"))
-                       return QLatin1String(pdf_mime_type);
+                       return pdfMimeType();
                return QString();
        }
 
        bool canConvert(QString const & mime, QString flav)
-       { return mimeFor(flav) == mime; }
+       {
+               return mimeFor(flav) == mime;
+       }
 
-       QVariant convertToMime(QString const & mime, QList<QByteArray> data, QString flav)
+       QVariant convertToMime(QString const & /*mime*/, QList<QByteArray> data,
+               QString /*flav*/)
        {
                if(data.count() > 1)
                        qWarning("QMacPasteboardMimeGraphics: Cannot handle multiple member data");
                return data.first();
        }
 
-       QList<QByteArray> convertFromMime(QString const & mime, QVariant data, QString flav)
+       QList<QByteArray> convertFromMime(QString const & /*mime*/,
+               QVariant data, QString /*flav*/)
        {
                QList<QByteArray> ret;
                ret.append(data.toByteArray());
@@ -216,8 +530,9 @@ public:
 #endif
 
 ///////////////////////////////////////////////////////////////
-// You can find more platform specific stuff
-// at the end of this file...
+//
+// You can find more platform specific stuff at the end of this file...
+//
 ///////////////////////////////////////////////////////////////
 
 ////////////////////////////////////////////////////////////////////////
@@ -229,10 +544,10 @@ public:
 static FORMATETC cfFromMime(QString const & mimetype)
 {
        FORMATETC formatetc;
-       if (mimetype == emf_mime_type) {
+       if (mimetype == emfMimeType()) {
                formatetc.cfFormat = CF_ENHMETAFILE;
                formatetc.tymed = TYMED_ENHMF;
-       } else if (mimetype == wmf_mime_type) {
+       } else if (mimetype == wmfMimeType()) {
                formatetc.cfFormat = CF_METAFILEPICT;
                formatetc.tymed = TYMED_MFPICT;
        }
@@ -256,7 +571,7 @@ public:
        bool canConvertToMime(QString const & mimetype,
                IDataObject * pDataObj) const
        {
-               if (mimetype != emf_mime_type && mimetype != wmf_mime_type)
+               if (mimetype != emfMimeType() && mimetype != wmfMimeType())
                        return false;
                FORMATETC formatetc = cfFromMime(mimetype);
                return pDataObj->QueryGetData(&formatetc) == S_OK;
@@ -299,11 +614,12 @@ public:
        }
 
 
-       QVector<FORMATETC> formatsForMime(QString const & mimeType,
-               QMimeData const * mimeData) const
+       QVector<FORMATETC> formatsForMime(QString const & mimetype,
+               QMimeData const * mimedata) const
        {
                QVector<FORMATETC> formats;
-               formats += cfFromMime(mimeType);
+               if (mimetype == emfMimeType() || mimetype == wmfMimeType())
+                       formats += cfFromMime(mimetype);
                return formats;
        }
 
@@ -311,9 +627,9 @@ public:
        {
                switch (formatetc.cfFormat) {
                case CF_ENHMETAFILE:
-                       return emf_mime_type
+                       return emfMimeType()
                case CF_METAFILEPICT:
-                       return wmf_mime_type;
+                       return wmfMimeType();
                }
                return QString();
        }
@@ -327,15 +643,50 @@ public:
 
 struct GuiApplication::Private
 {
-       Private(): global_menubar_(0)
+       Private(): language_model_(0), global_menubar_(0) 
        {
-#ifdef Q_WS_MACX
-               // Create the global default menubar which is shown for the dialogs
-               // and if no GuiView is visible.
-               global_menubar_ = new GlobalMenuBar();
-#endif
+       #ifdef Q_WS_WIN
+               /// WMF Mime handler for Windows clipboard.
+               wmf_mime_ = new QWindowsMimeMetafile();
+       #endif
        }
 
+       ///
+       QSortFilterProxyModel * language_model_;
+       ///
+       GuiClipboard clipboard_;
+       ///
+       GuiSelection selection_;
+       ///
+       FontLoader font_loader_;
+       ///
+       ColorCache color_cache_;
+       ///
+       QTranslator qt_trans_;
+       ///
+       QHash<int, SocketNotifier *> socket_notifiers_;
+       ///
+       Menus menus_;
+       ///
+       /// The global instance
+       Toolbars toolbars_;
+
+       /// this timer is used for any regular events one wants to
+       /// perform. at present it is used to check if forked processes
+       /// are done.
+       QTimer general_timer_;
+
+       /// delayed FuncRequests
+       std::queue<FuncRequest> func_request_queue_;
+
+       /// Multiple views container.
+       /**
+       * Warning: This must not be a smart pointer as the destruction of the
+       * object is handled by Qt when the view is closed
+       * \sa Qt::WA_DeleteOnClose attribute.
+       */
+       QHash<int, GuiView *> views_;
+
        /// Only used on mac.
        GlobalMenuBar * global_menubar_;
 
@@ -346,17 +697,13 @@ struct GuiApplication::Private
 
 #ifdef Q_WS_WIN
        /// WMF Mime handler for Windows clipboard.
-       // FIXME for Windows Vista and Qt4 (see http://bugzilla.lyx.org/show_bug.cgi?id=4846)
-       // But this makes LyX crash on exit when LyX is compiled in release mode and if there
-       // is something in the clipboard.
-       QWindowsMimeMetafile wmf_mime_;
+       QWindowsMimeMetafile * wmf_mime_;
 #endif
 };
 
 
 GuiApplication * guiApp;
 
-
 GuiApplication::~GuiApplication()
 {
 #ifdef Q_WS_MACX
@@ -367,13 +714,16 @@ GuiApplication::~GuiApplication()
 
 
 GuiApplication::GuiApplication(int & argc, char ** argv)
-       : QApplication(argc, argv), Application(), language_model_(0),
-       current_view_(0), d(new GuiApplication::Private)
+       : QApplication(argc, argv), current_view_(0),
+         d(new GuiApplication::Private)
 {
        QString app_name = "LyX";
        QCoreApplication::setOrganizationName(app_name);
        QCoreApplication::setOrganizationDomain("lyx.org");
-       QCoreApplication::setApplicationName(app_name + "-" + lyx_version);
+       QCoreApplication::setApplicationName(lyx_package);
+
+       // Install translator for GUI elements.
+       installTranslator(&d->qt_trans_);
 
        // FIXME: quitOnLastWindowClosed is true by default. We should have a
        // lyxrc setting for this in order to let the application stay resident.
@@ -386,6 +736,11 @@ GuiApplication::GuiApplication(int & argc, char ** argv)
        // FIXME: Do we need a lyxrc setting for this on Mac? This behaviour
        // seems to be the default case for applications like LyX.
        setQuitOnLastWindowClosed(false);
+
+       // This allows to translate the strings that appear in the LyX menu.
+       /// A translator suitable for the entries in the LyX menu.
+       /// Only needed with Qt/Mac.
+       installTranslator(new MenuTranslator(this));
 #endif
        
 #ifdef Q_WS_X11
@@ -396,38 +751,8 @@ GuiApplication::GuiApplication(int & argc, char ** argv)
        QApplication::setDoubleClickInterval(300);
 #endif
 
-       // install translation file for Qt built-in dialogs
-       QString language_name = QString("qt_") + QLocale::system().name();
-       
-       // language_name can be short (e.g. qt_zh) or long (e.g. qt_zh_CN). 
-       // Short-named translator can be loaded from a long name, but not the
-       // opposite. Therefore, long name should be used without truncation.
-       // c.f. http://doc.trolltech.com/4.1/qtranslator.html#load
-       if (qt_trans_.load(language_name,
-               QLibraryInfo::location(QLibraryInfo::TranslationsPath)))
-       {
-               installTranslator(&qt_trans_);
-               // even if the language calls for RtL, don't do that
-               setLayoutDirection(Qt::LeftToRight);
-               LYXERR(Debug::GUI, "Successfully installed Qt translations for locale "
-                       << language_name);
-       } else
-               LYXERR(Debug::GUI, "Could not find  Qt translations for locale "
-                       << language_name);
-
-#ifdef Q_WS_MACX
-       // This allows to translate the strings that appear in the LyX menu.
-       /// A translator suitable for the entries in the LyX menu.
-       /// Only needed with Qt/Mac.
-       installTranslator(new MenuTranslator(this));
-#endif
        connect(this, SIGNAL(lastWindowClosed()), this, SLOT(onLastWindowClosed()));
 
-       using namespace lyx::graphics;
-
-       Image::newImage = boost::bind(&GuiImage::newImage);
-       Image::loadableFormats = boost::bind(&GuiImage::loadableFormats);
-
        // needs to be done before reading lyxrc
        QWidget w;
        lyxrc.dpi = (w.logicalDpiX() + w.logicalDpiY()) / 2;
@@ -448,41 +773,67 @@ GuiApplication::GuiApplication(int & argc, char ** argv)
        if (lyxrc.typewriter_font_name.empty())
                lyxrc.typewriter_font_name = fromqstr(typewriterFontName());
 
-       general_timer_.setInterval(500);
-       connect(&general_timer_, SIGNAL(timeout()),
+       d->general_timer_.setInterval(500);
+       connect(&d->general_timer_, SIGNAL(timeout()),
                this, SLOT(handleRegularEvents()));
-       general_timer_.start();
+       d->general_timer_.start();
+}
+
+
+GuiApplication * theGuiApp()
+{
+       return dynamic_cast<GuiApplication *>(theApp());
 }
 
 
-FuncStatus GuiApplication::getStatus(FuncRequest const & cmd)
+void GuiApplication::clearSession()
+{
+       QSettings settings;
+       settings.clear();
+}
+
+
+docstring GuiApplication::iconName(FuncRequest const & f, bool unknown)
+{
+       return qstring_to_ucs4(lyx::frontend::iconName(f, unknown));
+}
+
+
+
+bool GuiApplication::getStatus(FuncRequest const & cmd, FuncStatus & flag) const
 {
-       FuncStatus flag;
        bool enable = true;
 
        switch(cmd.action) {
 
        case LFUN_WINDOW_CLOSE:
-               enable = view_ids_.size() > 0;
+               enable = d->views_.size() > 0;
+               break;
+
+       case LFUN_BUFFER_NEW:
+       case LFUN_BUFFER_NEW_TEMPLATE:
+       case LFUN_FILE_OPEN:
+       case LFUN_SCREEN_FONT_UPDATE:
+       case LFUN_SET_COLOR:
+       case LFUN_WINDOW_NEW:
+       case LFUN_LYX_QUIT:
+               enable = true;
                break;
 
        default:
-               if (!current_view_) {
-                       enable = false;
-                       break;
-               }
+               return false;
        }
 
        if (!enable)
-               flag.enabled(false);
+               flag.setEnabled(false);
 
-       return flag;
+       return true;
 }
 
        
 bool GuiApplication::dispatch(FuncRequest const & cmd)
 {
-       switch(cmd.action) {
+       switch (cmd.action) {
 
        case LFUN_WINDOW_NEW:
                createView(toqstr(cmd.argument()));
@@ -490,7 +841,7 @@ bool GuiApplication::dispatch(FuncRequest const & cmd)
 
        case LFUN_WINDOW_CLOSE:
                // update bookmark pit of the current buffer before window close
-               for (size_t i = 0; i < LyX::ref().session().bookmarks().size(); ++i)
+               for (size_t i = 0; i < theSession().bookmarks().size(); ++i)
                        theLyXFunc().gotoBookmark(i+1, false, false);
                current_view_->close();
                break;
@@ -506,7 +857,7 @@ bool GuiApplication::dispatch(FuncRequest const & cmd)
 
        case LFUN_SCREEN_FONT_UPDATE: {
                // handle the screen font changes.
-               font_loader_.update();
+               d->font_loader_.update();
                // Backup current_view_
                GuiView * view = current_view_;
                // Set current_view_ to zero to forbid GuiWorkArea::redraw()
@@ -522,38 +873,77 @@ bool GuiApplication::dispatch(FuncRequest const & cmd)
        }
 
        case LFUN_BUFFER_NEW:
-               if (viewCount() == 0
+               if (d->views_.empty()
                    || (!lyxrc.open_buffers_in_tabs && current_view_->buffer() != 0)) {
                        createView(QString(), false); // keep hidden
                        current_view_->newDocument(to_utf8(cmd.argument()), false);
                        current_view_->show();
                        setActiveWindow(current_view_);
-               } else
+               } else {
                        current_view_->newDocument(to_utf8(cmd.argument()), false);
+               }
                break;
 
        case LFUN_BUFFER_NEW_TEMPLATE:
-               if (viewCount() == 0 
+               if (d->views_.empty()
                    || (!lyxrc.open_buffers_in_tabs && current_view_->buffer() != 0)) {
                        createView();
                        current_view_->newDocument(to_utf8(cmd.argument()), true);
                        if (!current_view_->buffer())
                                current_view_->close();
-               } else
+               } else {
                        current_view_->newDocument(to_utf8(cmd.argument()), true);
+               }
                break;
 
        case LFUN_FILE_OPEN:
-               if (viewCount() == 0
+               if (d->views_.empty()
                    || (!lyxrc.open_buffers_in_tabs && current_view_->buffer() != 0)) {
-                       createView();
-                       current_view_->openDocument(to_utf8(cmd.argument()));
-                       if (!current_view_->buffer())
+                       string const fname = to_utf8(cmd.argument());
+                       // We want the ui session to be saved per document and not per
+                       // window number. The filename crc is a good enough identifier.
+                       boost::crc_32_type crc;
+                       crc = for_each(fname.begin(), fname.end(), crc);
+                       createView(crc.checksum());
+                       current_view_->openDocument(fname);
+                       if (current_view_ && !current_view_->buffer())
                                current_view_->close();
                } else
                        current_view_->openDocument(to_utf8(cmd.argument()));
                break;
 
+       case LFUN_SET_COLOR: {
+               string lyx_name;
+               string const x11_name = split(to_utf8(cmd.argument()), lyx_name, ' ');
+               if (lyx_name.empty() || x11_name.empty()) {
+                       current_view_->message(
+                               _("Syntax: set-color <lyx_name> <x11_name>"));
+                       break;
+               }
+
+               string const graphicsbg = lcolor.getLyXName(Color_graphicsbg);
+               bool const graphicsbg_changed = lyx_name == graphicsbg
+                       && x11_name != graphicsbg;
+               if (graphicsbg_changed) {
+                       // FIXME: The graphics cache no longer has a changeDisplay method.
+#if 0
+                       graphics::GCache::get().changeDisplay(true);
+#endif
+               }
+
+               if (!lcolor.setColor(lyx_name, x11_name)) {
+                       current_view_->message(
+                                       bformat(_("Set-color \"%1$s\" failed "
+                                                              "- color is undefined or "
+                                                              "may not be redefined"),
+                                                                  from_utf8(lyx_name)));
+                       break;
+               }
+               // Make sure we don't keep old colors in cache.
+               d->color_cache_.clear();
+               break;
+       }
+
        default:
                // Notify the caller that the action has not been dispatched.
                return false;
@@ -564,26 +954,45 @@ bool GuiApplication::dispatch(FuncRequest const & cmd)
 }
 
 
+void GuiApplication::dispatchDelayed(FuncRequest const & func)
+{
+       d->func_request_queue_.push(func);
+       QTimer::singleShot(0, this, SLOT(processFuncRequestQueue()));
+}
+
+
 void GuiApplication::resetGui()
 {
-       map<int, GuiView *>::iterator it;
-       for (it = views_.begin(); it != views_.end(); ++it)
-               it->second->resetDialogs();
+       // Set the language defined by the user.
+       setGuiLanguage();
+
+       // Read menus
+       if (!readUIFile(toqstr(lyxrc.ui_file)))
+               // Gives some error box here.
+               return;
+
+       if (d->global_menubar_)
+               d->menus_.fillMenuBar(d->global_menubar_, 0, false);
+
+       QHash<int, GuiView *>::iterator it;
+       for (it = d->views_.begin(); it != d->views_.end(); ++it) {
+               GuiView * gv = *it;
+               gv->setLayoutDirection(layoutDirection());
+               gv->resetDialogs();
+       }
 
        dispatch(FuncRequest(LFUN_SCREEN_FONT_UPDATE));
 }
 
 
-static void updateIds(map<int, GuiView *> const & stdmap, vector<int> & ids)
+void GuiApplication::createView(int view_id)
 {
-       ids.clear();
-       map<int, GuiView *>::const_iterator it;
-       for (it = stdmap.begin(); it != stdmap.end(); ++it)
-               ids.push_back(it->first);
+       createView(QString(), true, view_id);
 }
 
 
-void GuiApplication::createView(QString const & geometry_arg, bool autoShow)
+void GuiApplication::createView(QString const & geometry_arg, bool autoShow,
+       int view_id)
 {
        // release the keyboard which might have been grabed by the global
        // menubar on Mac to catch shortcuts even without any GuiView.
@@ -591,19 +1000,15 @@ void GuiApplication::createView(QString const & geometry_arg, bool autoShow)
                d->global_menubar_->releaseKeyboard();
 
        // create new view
-       updateIds(views_, view_ids_);
-       int id = 0;
-       while (views_.find(id) != views_.end())
-               id++;
+       int id = view_id;
+       if (id == 0) {
+               while (d->views_.find(id) != d->views_.end())
+                       id++;
+       }
+       LYXERR(Debug::GUI, "About to create new window with ID " << id);
        GuiView * view = new GuiView(id);
-       
-       // copy the icon size from old view
-       if (viewCount() > 0)
-               view->setIconSize(current_view_->iconSize());
-
        // register view
-       views_[id] = view;
-       updateIds(views_, view_ids_);
+       d->views_[id] = view;
 
        if (autoShow) {
                view->show();
@@ -624,27 +1029,70 @@ void GuiApplication::createView(QString const & geometry_arg, bool autoShow)
 #endif
        }
        view->setFocus();
-       setCurrentView(view);
 }
 
 
-
-
 Clipboard & GuiApplication::clipboard()
 {
-       return clipboard_;
+       return d->clipboard_;
 }
 
 
 Selection & GuiApplication::selection()
 {
-       return selection_;
+       return d->selection_;
+}
+
+
+FontLoader & GuiApplication::fontLoader() 
+{
+       return d->font_loader_;
+}
+
+
+Toolbars const & GuiApplication::toolbars() const 
+{
+       return d->toolbars_;
+}
+
+
+Toolbars & GuiApplication::toolbars()
+{
+       return d->toolbars_; 
+}
+
+
+Menus const & GuiApplication::menus() const 
+{
+       return d->menus_;
+}
+
+
+Menus & GuiApplication::menus()
+{
+       return d->menus_; 
+}
+
+
+QList<int> GuiApplication::viewIds() const
+{
+       return d->views_.keys();
+}
+
+
+ColorCache & GuiApplication::colorCache()
+{
+       return d->color_cache_;
 }
 
 
 int GuiApplication::exec()
 {
-       QTimer::singleShot(1, this, SLOT(execBatchCommands()));
+       // asynchronously handle batch commands. This event will be in
+       // the event queue in front of other asynchronous events. Hence,
+       // we can assume in the latter that the gui is setup already.
+       QTimer::singleShot(0, this, SLOT(execBatchCommands()));
+
        return QApplication::exec();
 }
 
@@ -655,15 +1103,79 @@ void GuiApplication::exit(int status)
 }
 
 
+void GuiApplication::setGuiLanguage()
+{
+       // Set the language defined by the user.
+       setRcGuiLanguage();
+
+       QString const default_language = toqstr(Messages::defaultLanguage());
+       LYXERR(Debug::LOCALE, "Tring to set default locale to: " << default_language);
+       QLocale const default_locale(default_language);
+       QLocale::setDefault(default_locale);
+
+       // install translation file for Qt built-in dialogs
+       QString const language_name = QString("qt_") + default_locale.name();
+
+       // language_name can be short (e.g. qt_zh) or long (e.g. qt_zh_CN). 
+       // Short-named translator can be loaded from a long name, but not the
+       // opposite. Therefore, long name should be used without truncation.
+       // c.f. http://doc.trolltech.com/4.1/qtranslator.html#load
+       if (!d->qt_trans_.load(language_name,
+                       QLibraryInfo::location(QLibraryInfo::TranslationsPath))) {
+               LYXERR(Debug::LOCALE, "Could not find  Qt translations for locale "
+                       << language_name);
+       } else {
+               LYXERR(Debug::LOCALE, "Successfully installed Qt translations for locale "
+                       << language_name);
+       }
+
+       switch (default_locale.language()) {
+       case QLocale::Arabic :
+       case QLocale::Hebrew :
+       case QLocale::Persian :
+       case QLocale::Urdu :
+        setLayoutDirection(Qt::RightToLeft);
+               break;
+       default:
+        setLayoutDirection(Qt::LeftToRight);
+       }
+}
+
+
+void GuiApplication::processFuncRequestQueue()
+{
+       while (!d->func_request_queue_.empty()) {
+               lyx::dispatch(d->func_request_queue_.back());
+               d->func_request_queue_.pop();
+       }
+}
+
+
 void GuiApplication::execBatchCommands()
 {
-       LyX::ref().execBatchCommands();
+       setGuiLanguage();
+
+       // Read menus
+       if (!readUIFile(toqstr(lyxrc.ui_file)))
+               // Gives some error box here.
+               return;
+
+#ifdef Q_WS_MACX
+       // Create the global default menubar which is shown for the dialogs
+       // and if no GuiView is visible.
+       // This must be done after the session was recovered to know the "last files".
+       d->global_menubar_ = new GlobalMenuBar();
+       d->menus_.fillMenuBar(d->global_menubar_, 0, true);
+#endif
+
+       lyx::execBatchCommands();
 }
 
+
 QAbstractItemModel * GuiApplication::languageModel()
 {
-       if (language_model_)
-               return language_model_;
+       if (d->language_model_)
+               return d->language_model_;
 
        QStandardItemModel * lang_model = new QStandardItemModel(this);
        lang_model->insertColumns(0, 1);
@@ -677,12 +1189,12 @@ QAbstractItemModel * GuiApplication::languageModel()
                lang_model->setData(item, qt_(it->second.display()), Qt::DisplayRole);
                lang_model->setData(item, toqstr(it->second.lang()), Qt::UserRole);
        }
-       language_model_ = new QSortFilterProxyModel(this);
-       language_model_->setSourceModel(lang_model);
+       d->language_model_ = new QSortFilterProxyModel(this);
+       d->language_model_->setSourceModel(lang_model);
 #if QT_VERSION >= 0x040300
-       language_model_->setSortLocaleAware(true);
+       d->language_model_->setSortLocaleAware(true);
 #endif
-       return language_model_;
+       return d->language_model_;
 }
 
 
@@ -691,13 +1203,35 @@ void GuiApplication::restoreGuiSession()
        if (!lyxrc.load_session)
                return;
 
-       Session & session = LyX::ref().session();
-       vector<FileName> const & lastopened = session.lastOpened().getfiles();
+       Session & session = theSession();
+       LastOpenedSection::LastOpened const & lastopened = 
+               session.lastOpened().getfiles();
+
+       FileName active_file;
        // do not add to the lastfile list since these files are restored from
        // last session, and should be already there (regular files), or should
        // not be added at all (help files).
-       for_each(lastopened.begin(), lastopened.end(),
-               bind(&GuiView::loadDocument, current_view_, _1, false));
+       // Note that we open them in reverse order. This is because we close
+       // buffers also in reverse order (aesthetically motivated).
+       for (size_t i = lastopened.size(); i > 0; --i) {
+               FileName const & file_name = lastopened[i - 1].file_name;
+               if (d->views_.empty() || (!lyxrc.open_buffers_in_tabs
+                         && current_view_->buffer() != 0)) {
+                       boost::crc_32_type crc;
+                       string const & fname = file_name.absFilename();
+                       crc = for_each(fname.begin(), fname.end(), crc);
+                       createView(crc.checksum());
+               }
+               current_view_->loadDocument(file_name, false);
+
+               if (lastopened[i - 1].active)
+                       active_file = file_name;
+       }
+
+       // Restore last active buffer
+       Buffer * buffer = theBufferList().getBuffer(active_file);
+       if (buffer)
+               current_view_->setBuffer(buffer);
 
        // clear this list to save a few bytes of RAM
        session.lastOpened().clear();
@@ -747,19 +1281,13 @@ bool GuiApplication::event(QEvent * e)
 {
        switch(e->type()) {
        case QEvent::FileOpen: {
-               // Open a file; this happens only on Mac OS X for now
+               // Open a file; this happens only on Mac OS X for now.
+               //
+               // We do this asynchronously because on startup the batch
+               // commands are not executed here yet and the gui is not ready
+               // therefore.
                QFileOpenEvent * foe = static_cast<QFileOpenEvent *>(e);
-
-               if (!current_view_ || !current_view_->view())
-                       // The application is not properly initialized yet.
-                       // So we acknowledge the event and delay the file opening
-                       // until LyX is ready.
-                       // FIXME UNICODE: FileName accept an utf8 encoded string.
-                       LyX::ref().addFileToLoad(fromqstr(foe->file()));
-               else
-                       lyx::dispatch(FuncRequest(LFUN_FILE_OPEN,
-                               qstring_to_ucs4(foe->file())));
-
+               dispatchDelayed(FuncRequest(LFUN_FILE_OPEN, qstring_to_ucs4(foe->file())));
                e->accept();
                return true;
        }
@@ -777,7 +1305,7 @@ bool GuiApplication::notify(QObject * receiver, QEvent * event)
        catch (ExceptionMessage const & e) {
                switch(e.type_) { 
                case ErrorException:
-                       LyX::cref().emergencyCleanup();
+                       emergencyCleanup();
                        setQuitOnLastWindowClosed(false);
                        closeAllViews();
                        Alert::error(e.title_, e.details_);
@@ -791,7 +1319,7 @@ bool GuiApplication::notify(QObject * receiver, QEvent * event)
                case BufferException: {
                        Buffer * buf = current_view_->buffer();
                        docstring details = e.details_ + '\n';
-                       details += theBufferList().emergencyWrite(buf);
+                       details += buf->emergencyWrite();
                        theBufferList().release(buf);
                        details += "\n" + _("The current document was closed.");
                        Alert::error(e.title_, details);
@@ -808,13 +1336,13 @@ bool GuiApplication::notify(QObject * receiver, QEvent * event)
                        "\n\nException: ");
                s += from_ascii(e.what());
                Alert::error(_("Software exception Detected"), s);
-               LyX::cref().exit(1);
+               lyx_exit(1);
        }
        catch (...) {
                docstring s = _("LyX has caught some really weird exception, it will "
                        "now attempt to save all unsaved documents and exit.");
                Alert::error(_("Software exception Detected"), s);
-               LyX::cref().exit(1);
+               lyx_exit(1);
        }
 
        return false;
@@ -823,7 +1351,7 @@ bool GuiApplication::notify(QObject * receiver, QEvent * event)
 
 bool GuiApplication::getRgbColor(ColorCode col, RGBColor & rgbcol)
 {
-       QColor const & qcol = color_cache_.get(col);
+       QColor const & qcol = d->color_cache_.get(col);
        if (!qcol.isValid()) {
                rgbcol.r = 0;
                rgbcol.g = 0;
@@ -839,35 +1367,27 @@ bool GuiApplication::getRgbColor(ColorCode col, RGBColor & rgbcol)
 
 string const GuiApplication::hexName(ColorCode col)
 {
-       return ltrim(fromqstr(color_cache_.get(col).name()), "#");
-}
-
-
-void GuiApplication::updateColor(ColorCode)
-{
-       // FIXME: Bleh, can't we just clear them all at once ?
-       color_cache_.clear();
+       return ltrim(fromqstr(d->color_cache_.get(col).name()), "#");
 }
 
 
 void GuiApplication::registerSocketCallback(int fd, SocketCallback func)
 {
        SocketNotifier * sn = new SocketNotifier(this, fd, func);
-       socket_notifiers_[fd] = sn;
+       d->socket_notifiers_[fd] = sn;
        connect(sn, SIGNAL(activated(int)), this, SLOT(socketDataReceived(int)));
 }
 
 
 void GuiApplication::socketDataReceived(int fd)
 {
-       socket_notifiers_[fd]->func_();
+       d->socket_notifiers_[fd]->func_();
 }
 
 
 void GuiApplication::unregisterSocketCallback(int fd)
 {
-       socket_notifiers_[fd]->setEnabled(false);
-       socket_notifiers_.erase(fd);
+       d->socket_notifiers_.take(fd)->setEnabled(false);
 }
 
 
@@ -885,90 +1405,211 @@ void GuiApplication::commitData(QSessionManager & sm)
 }
 
 
-bool GuiApplication::unregisterView(int id)
+void GuiApplication::unregisterView(GuiView * gv)
 {
-       updateIds(views_, view_ids_);
-       LASSERT(views_.find(id) != views_.end(), /**/);
-       LASSERT(views_[id], /**/);
-
-       map<int, GuiView *>::iterator it;
-       for (it = views_.begin(); it != views_.end(); ++it) {
-               if (it->first == id) {
-                       views_.erase(id);
-                       break;
-               }
+       LASSERT(d->views_[gv->id()] == gv, /**/);
+       d->views_.remove(gv->id());
+       if (current_view_ == gv) {
+               current_view_ = 0;
+               theLyXFunc().setLyXView(0);
        }
-       updateIds(views_, view_ids_);
-       return true;
 }
 
 
 bool GuiApplication::closeAllViews()
 {
-       updateIds(views_, view_ids_);
-       if (views_.empty())
+       if (d->views_.empty())
                return true;
 
-       map<int, GuiView*> const cmap = views_;
-       map<int, GuiView*>::const_iterator it;
-       for (it = cmap.begin(); it != cmap.end(); ++it) {
-               if (!it->second->close())
+       // When a view/window was closed before without quitting LyX, there
+       // are already entries in the lastOpened list.
+       theSession().lastOpened().clear();
+
+       QList<GuiView *> views = d->views_.values();
+       foreach (GuiView * view, views) {
+               if (!view->close())
                        return false;
        }
 
-       views_.clear();
-       view_ids_.clear();
+       d->views_.clear();
        return true;
 }
 
 
 GuiView & GuiApplication::view(int id) const
 {
-       LASSERT(views_.find(id) != views_.end(), /**/);
-       return *views_.find(id)->second;
+       LASSERT(d->views_.contains(id), /**/);
+       return *d->views_.value(id);
 }
 
 
 void GuiApplication::hideDialogs(string const & name, Inset * inset) const
 {
-       vector<int>::const_iterator it = view_ids_.begin();
-       vector<int>::const_iterator const end = view_ids_.end();
-       for (; it != end; ++it)
-               view(*it).hideDialog(name, inset);
+       QList<GuiView *> views = d->views_.values();
+       foreach (GuiView * view, views)
+               view->hideDialog(name, inset);
 }
 
 
 Buffer const * GuiApplication::updateInset(Inset const * inset) const
 {
        Buffer const * buffer_ = 0;
-       vector<int>::const_iterator it = view_ids_.begin();
-       vector<int>::const_iterator const end = view_ids_.end();
-       for (; it != end; ++it) {
-               Buffer const * ptr = view(*it).updateInset(inset);
-               if (ptr)
+       QHash<int, GuiView *>::iterator end = d->views_.end();
+       for (QHash<int, GuiView *>::iterator it = d->views_.begin(); it != end; ++it) {
+               if (Buffer const * ptr = (*it)->updateInset(inset))
                        buffer_ = ptr;
        }
        return buffer_;
 }
 
 
-void GuiApplication::readMenus(Lexer & lex)
+bool GuiApplication::searchMenu(FuncRequest const & func,
+       docstring_list & names) const
 {
-       menus().read(lex);
+       return d->menus_.searchMenu(func, names);
 }
 
 
-bool GuiApplication::searchMenu(FuncRequest const & func,
-       vector<docstring> & names) const
+bool GuiApplication::readUIFile(QString const & name, bool include)
 {
-       return menus().searchMenu(func, names);
-}
+       LYXERR(Debug::INIT, "About to read " << name << "...");
+
+       FileName ui_path;
+       if (include) {
+               ui_path = libFileSearch("ui", name, "inc");
+               if (ui_path.empty())
+                       ui_path = libFileSearch("ui", changeExtension(name, "inc"));
+       } else {
+               ui_path = libFileSearch("ui", name, "ui");
+       }
 
+       if (ui_path.empty()) {
+               static const QString defaultUIFile = "default";
+               LYXERR(Debug::INIT, "Could not find " << name);
+               if (include) {
+                       Alert::warning(_("Could not find UI definition file"),
+                               bformat(_("Error while reading the included file\n%1$s\n"
+                                       "Please check your installation."), qstring_to_ucs4(name)));
+                       return false;
+               }
+               if (name == defaultUIFile) {
+                       LYXERR(Debug::INIT, "Could not find default UI file!!");
+                       Alert::warning(_("Could not find default UI file"),
+                               _("LyX could not find the default UI file!\n"
+                                 "Please check your installation."));
+                       return false;
+               }
+               Alert::warning(_("Could not find UI definition file"),
+               bformat(_("Error while reading the configuration file\n%1$s\n"
+                       "Falling back to default.\n"
+                       "Please look under Tools>Preferences>User Interface and\n"
+                       "check which User Interface file you are using."), qstring_to_ucs4(name)));
+               return readUIFile(defaultUIFile, false);
+       }
 
-void GuiApplication::initGlobalMenu()
-{
-       if (d->global_menubar_)
-               menus().fillMenuBar(d->global_menubar_, 0, true);
+       // Ensure that a file is read only once (prevents include loops)
+       static QStringList uifiles;
+       QString const uifile = toqstr(ui_path.absFilename());
+       if (uifiles.contains(uifile)) {
+               if (!include) {
+                       // We are reading again the top uifile so reset the safeguard:
+                       uifiles.clear();
+                       d->menus_.reset();
+                       d->toolbars_.reset();
+               } else {
+                       LYXERR(Debug::INIT, "UI file '" << name << "' has been read already. "
+                               << "Is this an include loop?");
+                       return false;
+               }
+       }
+       uifiles.push_back(uifile);
+
+       LYXERR(Debug::INIT, "Found " << name << " in " << ui_path);
+
+       enum {
+               ui_menuset = 1,
+               ui_toolbars,
+               ui_toolbarset,
+               ui_include,
+               ui_last
+       };
+
+       LexerKeyword uitags[] = {
+               { "include", ui_include },
+               { "menuset", ui_menuset },
+               { "toolbars", ui_toolbars },
+               { "toolbarset", ui_toolbarset }
+       };
+
+       Lexer lex(uitags);
+       lex.setFile(ui_path);
+       if (!lex.isOK()) {
+               lyxerr << "Unable to set LyXLeX for ui file: " << ui_path
+                      << endl;
+       }
+
+       if (lyxerr.debugging(Debug::PARSER))
+               lex.printTable(lyxerr);
+
+       // store which ui files define Toolbars
+       static QStringList toolbar_uifiles;
+
+       while (lex.isOK()) {
+               switch (lex.lex()) {
+               case ui_include: {
+                       lex.next(true);
+                       QString const file = toqstr(lex.getString());
+                       if (!readUIFile(file, true))
+                               return false;
+                       break;
+               }
+               case ui_menuset:
+                       d->menus_.read(lex);
+                       break;
+
+               case ui_toolbarset:
+                       d->toolbars_.readToolbars(lex);
+                       break;
+
+               case ui_toolbars:
+                       d->toolbars_.readToolbarSettings(lex);
+                       toolbar_uifiles.push_back(uifile);
+                       break;
+
+               default:
+                       if (!rtrim(lex.getString()).empty())
+                               lex.printError("LyX::ReadUIFile: "
+                                              "Unknown menu tag: `$$Token'");
+                       break;
+               }
+       }
+
+       if (include)
+               return true;
+
+       QSettings settings;
+       settings.beginGroup("ui_files");
+       bool touched = false;
+       for (int i = 0; i != uifiles.size(); ++i) {
+               QFileInfo fi(uifiles[i]);
+               QDateTime const date_value = fi.lastModified();
+               QString const name_key = QString::number(i);
+               // if an ui file which defines Toolbars has changed,
+               // we have to reset the settings
+               if (toolbar_uifiles.contains(uifiles[i])
+                && (!settings.contains(name_key)
+                || settings.value(name_key).toString() != uifiles[i]
+                || settings.value(name_key + "/date").toDateTime() != date_value)) {
+                       touched = true;
+                       settings.setValue(name_key, uifiles[i]);
+                       settings.setValue(name_key + "/date", date_value);
+               }
+       }
+       settings.endGroup();
+       if (touched)
+               settings.remove("views");
+
+       return true;
 }
 
 
@@ -993,19 +1634,19 @@ bool GuiApplication::x11EventFilter(XEvent * xev)
        case SelectionRequest: {
                if (xev->xselectionrequest.selection != XA_PRIMARY)
                        break;
-               LYXERR(Debug::GUI, "X requested selection.");
+               LYXERR(Debug::SELECTION, "X requested selection.");
                BufferView * bv = current_view_->view();
                if (bv) {
                        docstring const sel = bv->requestSelection();
                        if (!sel.empty())
-                               selection_.put(sel);
+                               d->selection_.put(sel);
                }
                break;
        }
        case SelectionClear: {
                if (xev->xselectionclear.selection != XA_PRIMARY)
                        break;
-               LYXERR(Debug::GUI, "Lost selection.");
+               LYXERR(Debug::SELECTION, "Lost selection.");
                BufferView * bv = current_view_->view();
                if (bv)
                        bv->clearSelection();
@@ -1071,6 +1712,7 @@ frontend::Selection & theSelection()
        return frontend::guiApp->selection();
 }
 
+
 } // namespace lyx
 
-#include "GuiApplication_moc.cpp"
+#include "moc_GuiApplication.cpp"