#include "LyXFileDialog.h"
#include "qt_helpers.h"
+#include "LyXRC.h"
+
#include "support/debug.h"
#include "support/FileName.h"
+#include "support/filetools.h"
#include "support/gettext.h"
#include "support/os.h"
-/** when this is defined, the code will use
+#include <string>
+
+#include <QApplication>
+
+/** when LyXRC::use_native_filedialog is true, we use
* QFileDialog::getOpenFileName and friends to create filedialogs.
* Effects:
* - the dialog does not use the quick directory buttons (Button
* parameters);
* - with Qt/Mac or Qt/Win, the dialogs native to the environment are used.
* - with Qt/Win and Qt <= 4.3.0, there was a number of bugs with our own
- * file dialog (http://bugzilla.lyx.org/show_bug.cgi?id=3907).
+ * file dialog (http://www.lyx.org/trac/ticket/3907).
*
* Therefore there is a tradeoff in enabling or disabling this (JMarc)
*/
-#if defined(Q_WS_MACX) || (defined(Q_WS_WIN) && !defined(Q_CYGWIN_WIN))
-#define USE_NATIVE_FILEDIALOG 1
-#endif
-
-#ifdef USE_NATIVE_FILEDIALOG
-#include <QApplication>
-#endif
namespace lyx {
-using support::os::internal_path;
+using namespace support;
class FileDialog::Private {
};
-FileDialog::FileDialog(QString const & t, FuncCode s)
- : private_(new FileDialog::Private), title_(t), success_(s)
+FileDialog::FileDialog(QString const & t)
+ : private_(new FileDialog::Private), title_(t)
{}
FileDialog::Result FileDialog::save(QString const & path,
- QStringList const & filters, QString const & suggested)
+ QStringList const & filters, QString const & suggested,
+ QString * selectedFilter)
{
LYXERR(Debug::GUI, "Select with path \"" << path
<< "\", mask \"" << filters.join(";;")
FileDialog::Result result;
result.first = FileDialog::Chosen;
-#ifdef USE_NATIVE_FILEDIALOG
- QString const startsWith = makeAbsPath(suggested, path);
- QString const name =
- QFileDialog::getSaveFileName(qApp->focusWidget(),
- title_, startsWith, filters, 0, QFileDialog::DontConfirmOverwrite);
- result.second = toqstr(internal_path(fromqstr(name)));
-#else
- LyXFileDialog dlg(title_, path, filters, private_->b1, private_->b2);
-#if QT_VERSION != 0x040203
- dlg.setFileMode(QFileDialog::AnyFile);
-#endif
- dlg.setAcceptMode(QFileDialog::AcceptSave);
- dlg.setConfirmOverwrite(false);
-
- if (!suggested.isEmpty())
- dlg.selectFile(suggested);
-
- LYXERR(Debug::GUI, "Synchronous FileDialog: ");
- int res = dlg.exec();
- LYXERR(Debug::GUI, "result " << res);
- if (res == QDialog::Accepted)
- result.second = internalPath(dlg.selectedFiles()[0]);
- dlg.hide();
-#endif
+ if (lyxrc.use_native_filedialog) {
+ QString const startsWith = makeAbsPath(suggested, path);
+ QString const name =
+ QFileDialog::getSaveFileName(qApp->focusWidget(),
+ title_, startsWith, filters.join(";;"),
+ selectedFilter, QFileDialog::DontConfirmOverwrite);
+ if (name.isNull())
+ result.first = FileDialog::Later;
+ else
+ result.second = toqstr(os::internal_path(fromqstr(name)));
+ } else {
+ LyXFileDialog dlg(title_, path, filters, private_->b1, private_->b2);
+ dlg.setFileMode(QFileDialog::AnyFile);
+ dlg.setAcceptMode(QFileDialog::AcceptSave);
+ dlg.setConfirmOverwrite(false);
+ if (selectedFilter != 0 && !selectedFilter->isEmpty())
+ dlg.selectNameFilter(*selectedFilter);
+
+ if (!suggested.isEmpty())
+ dlg.selectFile(suggested);
+
+ LYXERR(Debug::GUI, "Synchronous FileDialog: ");
+ int res = dlg.exec();
+ LYXERR(Debug::GUI, "result " << res);
+ if (res == QDialog::Accepted)
+ result.second = internalPath(dlg.selectedFiles()[0]);
+ else
+ result.first = FileDialog::Later;
+ if (selectedFilter != 0)
+ *selectedFilter = dlg.selectedNameFilter();
+ dlg.hide();
+ }
return result;
}
+FileDialog::Result FileDialog::save(QString const & path,
+ QStringList const & filters, QString const & suggested)
+{
+ return save(path, filters, suggested, 0);
+}
+
+
FileDialog::Result FileDialog::open(QString const & path,
QStringList const & filters, QString const & suggested)
{
FileDialog::Result result;
result.first = FileDialog::Chosen;
-#ifdef USE_NATIVE_FILEDIALOG
- QString const startsWith = makeAbsPath(suggested, path);
- result.second = internalPath(
- QFileDialog::getOpenFileName(qApp->focusWidget(),
- title_, startsWith, filters));
-#else
- LyXFileDialog dlg(title_, path, filters, private_->b1, private_->b2);
-
- if (!suggested.isEmpty())
- dlg.selectFile(suggested);
-
- LYXERR(Debug::GUI, "Synchronous FileDialog: ");
- int res = dlg.exec();
- LYXERR(Debug::GUI, "result " << res);
- if (res == QDialog::Accepted)
- result.second = internalPath(dlg.selectedFiles()[0]);
- dlg.hide();
-#endif
+ if (lyxrc.use_native_filedialog) {
+ QString const startsWith = makeAbsPath(suggested, path);
+ QString const file = QFileDialog::getOpenFileName(qApp->focusWidget(),
+ title_, startsWith, filters.join(";;"));
+ if (file.isNull())
+ result.first = FileDialog::Later;
+ else
+ result.second = internalPath(file);
+ } else {
+ LyXFileDialog dlg(title_, path, filters, private_->b1, private_->b2);
+
+ if (!suggested.isEmpty())
+ dlg.selectFile(suggested);
+
+ LYXERR(Debug::GUI, "Synchronous FileDialog: ");
+ int res = dlg.exec();
+ LYXERR(Debug::GUI, "result " << res);
+ if (res == QDialog::Accepted)
+ result.second = internalPath(dlg.selectedFiles()[0]);
+ else
+ result.first = FileDialog::Later;
+ dlg.hide();
+ }
return result;
}
FileDialog::Result result;
result.first = FileDialog::Chosen;
-#ifdef USE_NATIVE_FILEDIALOG
- QString const startsWith = makeAbsPath(suggested, path);
- result.second = toqstr(internal_path(fromqstr(
- QFileDialog::getExistingDirectory(qApp->focusWidget(),
- title_, startsWith))));
-#else
- LyXFileDialog dlg(title_, path, QStringList(qt_("Directories")),
- private_->b1, private_->b2);
-
- dlg.setFileMode(QFileDialog::DirectoryOnly);
-
- if (!suggested.isEmpty())
- dlg.selectFile(suggested);
-
- LYXERR(Debug::GUI, "Synchronous FileDialog: ");
- int res = dlg.exec();
- LYXERR(Debug::GUI, "result " << res);
- if (res == QDialog::Accepted)
- result.second = internalPath(dlg.selectedFiles()[0]);
- dlg.hide();
-#endif
+ if (lyxrc.use_native_filedialog) {
+ QString const startsWith =
+ toqstr(makeAbsPath(fromqstr(suggested), fromqstr(path)).absFileName());
+ QString const dir =
+ QFileDialog::getExistingDirectory(qApp->focusWidget(), title_, startsWith);
+ if (dir.isNull())
+ result.first = FileDialog::Later;
+ else
+ result.second = toqstr(os::internal_path(fromqstr(dir)));
+ } else {
+ LyXFileDialog dlg(title_, path, QStringList(qt_("Directories")),
+ private_->b1, private_->b2);
+
+ dlg.setFileMode(QFileDialog::DirectoryOnly);
+
+ if (!suggested.isEmpty())
+ dlg.selectFile(suggested);
+
+ LYXERR(Debug::GUI, "Synchronous FileDialog: ");
+ int res = dlg.exec();
+ LYXERR(Debug::GUI, "result " << res);
+ if (res == QDialog::Accepted)
+ result.second = internalPath(dlg.selectedFiles()[0]);
+ else
+ result.first = FileDialog::Later;
+ dlg.hide();
+ }
return result;
}
projects / lyx.git / blobdiff