better selection and scrolling behaviour

[lyx.git] / src / frontends / qt2 / QExternal.C

diff --git a/src/frontends/qt2/QExternal.C b/src/frontends/qt2/QExternal.C
index 28c3c3158440d084cc40d305501a9b7dcf566877..69f2a6965f87fd23578895208e0b3eec9d5abb7c 100644 (file)
--- a/src/frontends/qt2/QExternal.C
+++ b/src/frontends/qt2/QExternal.C
@@ -1,30 +1,38 @@
 /**
  * \file QExternal.C
- * Copyright 2001 the LyX Team
- * Read the file COPYING
+ * This file is part of LyX, the document processor.
+ * Licence details can be found in the file COPYING.
  *
- * \author John Levon <moz@compsoc.man.ac.uk>
+ * \author John Levon
+ *
+ * Full author contact details are available in file CREDITS
  */
 
 #include <config.h>
-#include <vector> 
 
-#include "LString.h" 
-#include "QExternalDialog.h"
+#ifdef __GNUG__
+#pragma implementation
+#endif
+
 #include "ControlExternal.h"
-#include "QExternal.h"
-#include "Qt2BC.h"
 #include "gettext.h"
 
 #include <qlineedit.h>
 #include <qpushbutton.h>
-#include <qcombobox.h> 
+#include <qcombobox.h>
 #include <qtextview.h>
 
+#include "QExternalDialog.h"
+#include "QExternal.h"
+#include "Qt2BC.h"
+
+#include <vector>
+
 typedef Qt2CB<ControlExternal, Qt2DB<QExternalDialog> > base_class;
- 
-QExternal::QExternal(ControlExternal & c)
-       : base_class(c, _("External"))
+
+
+QExternal::QExternal()
+       : base_class(_("External"))
 {
 }
 
@@ -41,50 +49,42 @@ void QExternal::build_dialog()
        bc().addReadOnly(dialog_->browsePB);
 
        std::vector<string> templates(controller().getTemplates());
- 
+
        for (std::vector<string>::const_iterator cit = templates.begin();
                cit != templates.end(); ++cit) {
                dialog_->externalCO->insertItem(cit->c_str(), -1);
        }
 }
 
- 
+
 void QExternal::update_contents()
 {
        InsetExternal::Params const & params = controller().params();
 
        dialog_->fileED->setText(params.filename.c_str());
        dialog_->paramsED->setText(params.parameters.c_str());
- 
+
        dialog_->externalCO->setCurrentItem(controller().getTemplateNumber(params.templ.lyxName));
-       dialog_->externalTV->setText(controller().params().templ.helpText.c_str()); 
+       dialog_->externalTV->setText(params.templ.helpText.c_str());
        isValid();
 }
 
 
 string const & QExternal::helpText()
 {
-       controller().params().templ = controller().getTemplate(dialog_->externalCO->currentItem() + 1);
-       return controller().params().templ.helpText; 
+       InsetExternal::Params & params = controller().params();
+
+       params.templ = controller().getTemplate(dialog_->externalCO->currentItem());
+       return params.templ.helpText;
 }
 
- 
+
 void QExternal::apply()
 {
-       controller().params().filename =
-               string(dialog_->fileED->text().latin1());
-       controller().params().parameters =
-               string(dialog_->paramsED->text().latin1());
+       InsetExternal::Params & params = controller().params();
 
-       controller().params().templ = controller().getTemplate(dialog_->externalCO->currentItem() + 1);
-}
+       params.filename = dialog_->fileED->text().latin1();
+       params.parameters = dialog_->paramsED->text().latin1();
 
-
-bool QExternal::isValid()
-{
-       bool const valid = !string(dialog_->fileED->text()).empty();
-       dialog_->viewPB->setEnabled(valid); 
-       dialog_->editPB->setEnabled(valid); 
-       dialog_->updatePB->setEnabled(valid); 
-       return valid;
+       params.templ = controller().getTemplate(dialog_->externalCO->currentItem());
 }