Make code a bit easier to read

[lyx.git] / src / frontends / qt / GuiCitation.h

diff --git a/src/frontends/qt/GuiCitation.h b/src/frontends/qt/GuiCitation.h
index a4784b20ec03b4e24610c9604a203b8fe0f5de1e..948933a8e37c8d804489aa7830acb9e91d7bce7a 100644 (file)
--- a/src/frontends/qt/GuiCitation.h
+++ b/src/frontends/qt/GuiCitation.h
@@ -7,7 +7,7 @@
  * \author Angus Leeming
  * \author Kalle Dalheimer
  * \author Abdelrazak Younes
- * \author Richard Heck
+ * \author Richard Kimberly Heck
  *
  * Full author contact details are available in file CREDITS.
  */
@@ -17,12 +17,10 @@
 
 #include "DialogView.h"
 #include "ui_CitationUi.h"
-#include "FancyLineEdit.h"
 
 #include "insets/InsetCommandParams.h"
 
 #include "BiblioInfo.h"
-#include "Citation.h"
 
 #include <QAbstractListModel>
 #include <QStandardItemModel>
@@ -31,10 +29,11 @@
 
 namespace lyx {
 
-class BiblioInfo;
+class CitationStyle;
 
 namespace frontend {
 
+class FancyLineEdit;
 class GuiSelectionManager;
 
 
@@ -80,16 +79,12 @@ private:
        bool isBufferDependent() const override { return true; }
        void saveSession(QSettings & settings) const override;
        void restoreSession() override;
-       /** Disconnect from the inset when the Apply button is pressed.
-        *  Allows easy insertion of multiple citations.
-        */
-       bool disconnectOnApply() const override { return true; }
        //@}
 
        ///
-       void showEvent(QShowEvent * e);
+       void showEvent(QShowEvent * e) override;
        ///
-       void closeEvent(QCloseEvent * e);
+       void closeEvent(QCloseEvent * e) override;
        /// prepares a call to GuiCitation::searchKeys when we
        /// are ready to search the BibTeX entries
        void findText(QString const & text, bool reset = false);
@@ -151,7 +146,7 @@ private:
 
        ///
        void filterByEntryType(BiblioInfo const & bi,
-               std::vector<docstring> & keyVector, docstring entryType);
+               std::vector<docstring> & keyVector, docstring const & entryType);
 
        /// Search a given string within the passed keys.
        /// \return the vector of matched keys.
@@ -160,7 +155,7 @@ private:
                std::vector<docstring> const & keys_to_search, //< Keys to search.
                bool only_keys, //< whether to search only the keys
                docstring const & search_expression, //< Search expression (regex possible)
-               docstring field, //< field to search, empty for all fields
+               docstring const & field, //< field to search, empty for all fields
                bool case_sensitive = false, //< set to true is the search should be case sensitive
                bool regex = false //< \set to true if \c search_expression is a regex
                ); //