Minipage is no more (long live the box inset)

[lyx.git] / src / frontends / Dialogs.C

diff --git a/src/frontends/Dialogs.C b/src/frontends/Dialogs.C
index 5711d0180360eb921c483f4b51cc5cb41868ef2d..9990de1f41398983ff1b8ff919286bbdf4b0635a 100644 (file)
--- a/src/frontends/Dialogs.C
+++ b/src/frontends/Dialogs.C
@@ -13,11 +13,16 @@
 #include <config.h>
 
 #include "Dialogs.h"
+
 #include "controllers/Dialog.h"
+
 #include <boost/signals/signal2.hpp>
 #include <boost/bind.hpp>
 
 
+using std::string;
+
+
 // Note that static boost signals break some compilers, so this wrapper
 // initialises the signal dynamically when it is first invoked.
 template<typename Signal>
@@ -73,7 +78,7 @@ Dialogs::Dialogs(LyXView & lyxview)
 }
 
 
-Dialog * Dialogs::find(string const & name)
+Dialog * Dialogs::find_or_build(string const & name)
 {
        if (!isValidName(name))
                return 0;
@@ -81,18 +86,17 @@ Dialog * Dialogs::find(string const & name)
        std::map<string, DialogPtr>::iterator it =
                dialogs_.find(name);
 
-       if (it == dialogs_.end()) {
-               dialogs_[name] = DialogPtr(build(name));
-               return dialogs_[name].get();
-       }
+       if (it != dialogs_.end())
+               return it->second.get();
 
-       return it->second.get();
+       dialogs_[name] = DialogPtr(build(name));
+       return dialogs_[name].get();
 }
 
 
 void Dialogs::show(string const & name, string const & data)
 {
-       Dialog * dialog = find(name);
+       Dialog * dialog = find_or_build(name);
        if (!dialog)
                return;
 
@@ -103,7 +107,7 @@ void Dialogs::show(string const & name, string const & data)
 
 void Dialogs::show(string const & name, string const & data, InsetBase * inset)
 {
-       Dialog * dialog = find(name);
+       Dialog * dialog = find_or_build(name);
        if (!dialog)
                return;
 
@@ -125,10 +129,12 @@ bool Dialogs::visible(string const & name) const
 
 void Dialogs::update(string const & name, string const & data)
 {
-       Dialog * dialog = find(name);
-       if (!dialog)
+       std::map<string, DialogPtr>::const_iterator it =
+               dialogs_.find(name);
+       if (it == dialogs_.end())
                return;
 
+       Dialog * const dialog = it->second.get();
        if (dialog->isVisible())
                dialog->update(data);
 }
@@ -136,13 +142,15 @@ void Dialogs::update(string const & name, string const & data)
 
 void Dialogs::hideSlot(string const & name, InsetBase * inset)
 {
-       Dialog * dialog = find(name);
-       if (!dialog)
+       std::map<string, DialogPtr>::const_iterator it =
+               dialogs_.find(name);
+       if (it == dialogs_.end())
                return;
 
        if (inset && inset != getOpenInset(name))
                return;
 
+       Dialog * const dialog = it->second.get();
        if (dialog->isVisible())
                dialog->hide();
        open_insets_[name] = 0;