The "I want this in now" patch.

[lyx.git] / src / format.C

diff --git a/src/format.C b/src/format.C
index b8df07ce3b803993d9ae100f0143f3944d8dcd03..4f85ce34e9f8b669ad07b3d10c9162a8ee2332b0 100644 (file)
--- a/src/format.C
+++ b/src/format.C
@@ -15,7 +15,6 @@
 #include "lyx_cb.h" // for ShowMessage() ... to be removed?
 #include "gettext.h"
 #include "LString.h"
-#include "support/BoostFormat.h"
 
 #include "frontends/Alert.h" //to be removed?
 
@@ -25,7 +24,6 @@
 #include "support/lyxfunctional.h"
 
 
-
 namespace {
 
 string const token_from("$$i");
@@ -158,16 +156,12 @@ bool Formats::view(Buffer const * buffer, string const & filename,
            format->isChildFormat())
                format = getFormat(format->parentFormat());
        if (!format || format->viewer().empty()) {
-#if USE_BOOST_FORMAT
-               Alert::alert(_("Cannot view file"),
-                            boost::io::str(boost::format(_("No information for viewing %1$s"))
-                          % prettyName(format_name)));
-#else
-               Alert::alert(_("Cannot view file"),
-                            _("No information for viewing ")
-                            + prettyName(format_name));
-#endif
-                          return false;
+// I believe this is the wrong place to show alerts, it should be done by
+// the caller (this should be "utility" code
+               Alert::error(_("Cannot view file"),
+                       bformat(_("No information for viewing %1$s"),
+                               prettyName(format_name)));
+               return false;
        }
 
        string command = format->viewer();
@@ -199,9 +193,9 @@ bool Formats::view(Buffer const * buffer, string const & filename,
        int const res = one.startscript(Systemcall::DontWait, command);
 
        if (res) {
-               Alert::alert(_("Cannot view file"),
-                          _("Error while executing"),
-                          command.substr(0, 50));
+               Alert::error(_("Cannot view file"),
+                            bformat(_("An error occurred whilst running %1$s"),
+                              command.substr(0, 50)));
                return false;
        }
        return true;