]> git.lyx.org Git - lyx.git/blobdiff - src/cursor.C
fix two crashes related to dEPM. Some crashes remain
[lyx.git] / src / cursor.C
index a9fd17e47b3a70f975964267243c0d236f251b4f..ff206f532005623129edbbec1758a2ea7194a9f7 100644 (file)
 #include "paragraph_funcs.h"
 #include "pariterator.h"
 
-#include "insets/updatableinset.h"
 #include "insets/insettabular.h"
 #include "insets/insettext.h"
 
 #include "mathed/math_data.h"
 #include "mathed/math_inset.h"
+#include "mathed/math_scriptinset.h"
 #include "mathed/math_macrotable.h"
 
 #include "support/limited_stack.h"
@@ -94,12 +94,10 @@ namespace {
                it.top().pos() = 0;
                DocIterator et = c;
                et.top().pos() = et.top().asMathInset()->cell(et.top().idx()).size();
-               for (int i = 0; ; ++i) {
+               for (size_t i = 0; ; ++i) {
                        int xo;
                        int yo;
-                       LCursor cur = c;
-                       cur.setCursor(it);
-                       cur.inset().getCursorPos(cur.top(), xo, yo);
+                       it.inset().cursorPos(it.top(), c.boundary() && ((i+1) == it.depth()), xo, yo);
                        double d = (x - xo) * (x - xo) + (y - yo) * (y - yo);
                        // '<=' in order to take the last possible position
                        // this is important for clicking behind \sum in e.g. '\sum_i a'
@@ -122,10 +120,10 @@ namespace {
                int x, int y, int xlow, int xhigh, int ylow, int yhigh)
        {
                BOOST_ASSERT(!cursor.empty());
-               CursorSlice bottom = cursor[0];
+               InsetBase & inset = cursor[0].inset();
 
-               DocIterator it = doc_iterator_begin(bottom.inset());
-               DocIterator const et = doc_iterator_end(bottom.inset());
+               DocIterator it = doc_iterator_begin(inset);
+               DocIterator const et = doc_iterator_end(inset);
 
                double best_dist = std::numeric_limits<double>::max();;
                DocIterator best_cursor = et;
@@ -134,16 +132,17 @@ namespace {
                        // avoid invalid nesting when selecting
                        if (bv_funcs::status(&cursor.bv(), it) == bv_funcs::CUR_INSIDE
                            && (!cursor.selection() || positionable(it, cursor.anchor_))) {
-                               Point p = bv_funcs::getPos(it);
+                               Point p = bv_funcs::getPos(it, false);
                                int xo = p.x_;
                                int yo = p.y_;
                                if (xlow <= xo && xo <= xhigh && ylow <= yo && yo <= yhigh) {
-                                       double d = (x - xo) * (x - xo) + (y - yo) * (y - yo);
-                                       //lyxerr << "xo: " << xo << " yo: " << yo << " d: " << d << endl;
+                                       double const dx = xo - x;
+                                       double const dy = yo - y;
+                                       double const d = dx * dx + dy * dy;
                                        // '<=' in order to take the last possible position
                                        // this is important for clicking behind \sum in e.g. '\sum_i a'
                                        if (d <= best_dist) {
-                                               //lyxerr << "*" << endl;
+                                               lyxerr << "*" << endl;
                                                best_dist   = d;
                                                best_cursor = it;
                                        }
@@ -151,7 +150,6 @@ namespace {
                        }
                }
 
-               //lyxerr << "best_dist: " << best_dist << " cur:\n" << best_cursor << endl;
                if (best_cursor != et) {
                        cursor.setCursor(best_cursor);
                        return true;
@@ -160,6 +158,67 @@ namespace {
                return false;
        }
 
+
+       /// moves position closest to (x, y) in given box
+       bool bruteFind3(LCursor & cur, int x, int y, bool up)
+       {
+               BufferView & bv = cur.bv();
+               int ylow  = up ? 0 : y + 1;
+               int yhigh = up ? y - 1 : bv.workHeight();
+               int xlow = 0;
+               int xhigh = bv.workWidth();
+
+// FIXME: bit more work needed to get 'from' and 'to' right.
+               pit_type from = cur.bottom().pit();
+               //pit_type to = cur.bottom().pit();
+               //lyxerr << "Pit start: " << from << endl;
+
+               //lyxerr << "bruteFind3: x: " << x << " y: " << y
+               //      << " xlow: " << xlow << " xhigh: " << xhigh 
+               //      << " ylow: " << ylow << " yhigh: " << yhigh 
+               //      << endl;
+               InsetBase & inset = bv.buffer()->inset();
+               DocIterator it = doc_iterator_begin(inset);
+               it.pit() = from;
+               DocIterator et = doc_iterator_end(inset);
+
+               double best_dist = std::numeric_limits<double>::max();
+               DocIterator best_cursor = et;
+
+               for ( ; it != et; it.forwardPos()) {
+                       // avoid invalid nesting when selecting
+                       if (bv_funcs::status(&bv, it) == bv_funcs::CUR_INSIDE
+                           && (!cur.selection() || positionable(it, cur.anchor_))) {
+                               Point p = bv_funcs::getPos(it, false);
+                               int xo = p.x_;
+                               int yo = p.y_;
+                               if (xlow <= xo && xo <= xhigh && ylow <= yo && yo <= yhigh) {
+                                       double const dx = xo - x;
+                                       double const dy = yo - y;
+                                       double const d = dx * dx + dy * dy;
+                                       //lyxerr << "itx: " << xo << " ity: " << yo << " d: " << d
+                                       //      << " dx: " << dx << " dy: " << dy
+                                       //      << " idx: " << it.idx() << " pos: " << it.pos()
+                                       //      << " it:\n" << it
+                                       //      << endl;
+                                       // '<=' in order to take the last possible position
+                                       // this is important for clicking behind \sum in e.g. '\sum_i a'
+                                       if (d <= best_dist) {
+                                               //lyxerr << "*" << endl;
+                                               best_dist   = d;
+                                               best_cursor = it;
+                                       }
+                               }
+                       }
+               }
+
+               //lyxerr << "best_dist: " << best_dist << " cur:\n" << best_cursor << endl;
+               if (best_cursor == et)
+                       return false;
+               cur.setCursor(best_cursor);
+               return true;
+       }
+
 } // namespace anon
 
 
@@ -167,7 +226,7 @@ namespace {
 // bv functions are not yet available!
 LCursor::LCursor(BufferView & bv)
        : DocIterator(), bv_(&bv), anchor_(), x_target_(-1),
-         selection_(false), mark_(false)
+         selection_(false), mark_(false), logicalpos_(false)
 {}
 
 
@@ -309,7 +368,7 @@ int LCursor::currentMode()
 
 void LCursor::getPos(int & x, int & y) const
 {
-       Point p = bv_funcs::getPos(*this);
+       Point p = bv_funcs::getPos(*this, boundary());
        x = p.x_;
        y = p.y_;
 }
@@ -317,7 +376,8 @@ void LCursor::getPos(int & x, int & y) const
 
 void LCursor::paste(string const & data)
 {
-       dispatch(FuncRequest(LFUN_PASTE, data));
+       if (!data.empty())
+               dispatch(FuncRequest(LFUN_PASTE, data));
 }
 
 
@@ -393,7 +453,7 @@ DocIterator LCursor::selectionEnd() const
 void LCursor::setSelection()
 {
        selection() = true;
-       // a selection with no contents is not a selection
+       // A selection with no contents is not a selection
 #ifdef WITH_WARNINGS
 #warning doesnt look ok
 #endif
@@ -507,13 +567,24 @@ std::ostream & operator<<(std::ostream & os, LCursor const & cur)
 
 bool LCursor::isInside(InsetBase const * p)
 {
-       for (unsigned i = 0; i < depth(); ++i)
+       for (size_t i = 0; i != depth(); ++i)
                if (&operator[](i).inset() == p)
                        return true;
        return false;
 }
 
 
+void LCursor::leaveInset(InsetBase const & inset)
+{
+       for (size_t i = 0; i != depth(); ++i) {
+               if (&operator[](i).inset() == &inset) {
+                       resize(i);
+                       return;
+               }
+       }
+}
+
+
 bool LCursor::openable(MathAtom const & t) const
 {
        if (!t->isActive())
@@ -711,7 +782,7 @@ bool LCursor::erase()
        }
 
        // 'clever' UI hack: only erase large items if previously slected
-       if (pos() != lastpos() && inset().nargs() > 0) {
+       if (pos() != lastpos() && nextAtom()->nargs() > 0) {
                resetAnchor();
                selection() = true;
                ++pos();
@@ -861,12 +932,12 @@ void LCursor::touch()
 
 void LCursor::normalize()
 {
-       if (idx() >= nargs()) {
+       if (idx() > lastidx()) {
                lyxerr << "this should not really happen - 1: "
                       << idx() << ' ' << nargs()
                       << " in: " << &inset() << endl;
+               idx() = lastidx();
        }
-       idx() = min(idx(), lastidx());
 
        if (pos() > lastpos()) {
                lyxerr << "this should not really happen - 2: "
@@ -875,8 +946,8 @@ void LCursor::normalize()
                WriteStream wi(lyxerr, false, true);
                inset().asMathInset()->write(wi);
                lyxerr << endl;
+               pos() = lastpos();
        }
-       pos() = min(pos(), lastpos());
 }
 
 
@@ -904,10 +975,9 @@ bool LCursor::goUpDown(bool up)
                        MathScriptInset const * p = prevAtom()->asScriptInset();
                        if (p && p->has(up)) {
                                --pos();
-                               push(inset());
-                               idx() = up; // the superscript has index 1
+                               push(*const_cast<MathScriptInset*>(p));
+                               idx() = p->idxOfScript(up);
                                pos() = lastpos();
-                               //lyxerr << "updown: handled by scriptinset to the left" << endl;
                                return true;
                        }
                }
@@ -916,15 +986,20 @@ bool LCursor::goUpDown(bool up)
                if (pos() != lastpos()) {
                        MathScriptInset const * p = nextAtom()->asScriptInset();
                        if (p && p->has(up)) {
-                               push(inset());
-                               idx() = up;
+                               push(*const_cast<MathScriptInset*>(p));
+                               idx() = p->idxOfScript(up);
                                pos() = 0;
-                               //lyxerr << "updown: handled by scriptinset to the right" << endl;
                                return true;
                        }
                }
        }
 
+// FIXME: Switch this on for more robust movement
+#if 0
+
+       return bruteFind3(*this, xo, yo, up); 
+
+#else
        //xarray().boundingBox(xlow, xhigh, ylow, yhigh);
        //if (up)
        //      yhigh = yo - 4;
@@ -937,9 +1012,10 @@ bool LCursor::goUpDown(bool up)
 
        // try to find an inset that knows better then we
        while (true) {
-               //lyxerr << "updown: We are in " << &inset() << " idx: " << idx() << endl;
+               lyxerr << "updown: We are in " << &inset() << " idx: " << idx() << endl;
                // ask inset first
                if (inset().idxUpDown(*this, up)) {
+                       lyxerr << "idxUpDown triggered" << endl;
                        // try to find best position within this inset
                        if (!selection())
                                setCursor(bruteFind2(*this, xo, yo));
@@ -947,14 +1023,15 @@ bool LCursor::goUpDown(bool up)
                }
 
                // no such inset found, just take something "above"
-               //lyxerr << "updown: handled by strange case" << endl;
                if (!popLeft()) {
+                       lyxerr << "updown: popleft failed (strange case)" << endl;
                        int ylow  = up ? 0 : yo + 1;
                        int yhigh = up ? yo - 1 : bv().workHeight();
                        return bruteFind(*this, xo, yo, 0, bv().workWidth(), ylow, yhigh);
                }
 
                // any improvement so far?
+               lyxerr << "updown: popLeft succeeded" << endl;
                int xnew;
                int ynew;
                getPos(xnew, ynew);
@@ -964,6 +1041,7 @@ bool LCursor::goUpDown(bool up)
 
        // we should not come here.
        BOOST_ASSERT(false);
+#endif
 }
 
 
@@ -1021,7 +1099,7 @@ string LCursor::selectionAsString(bool label) const
 
        if (inTexted()) {
                Buffer const & buffer = *bv().buffer();
-               ParagraphList & pars = text()->paragraphs();
+               ParagraphList const & pars = text()->paragraphs();
 
                // should be const ...
                pit_type startpit = selBegin().pit();
@@ -1038,7 +1116,7 @@ string LCursor::selectionAsString(bool label) const
 
                // The paragraphs in between (if any)
                for (pit_type pit = startpit + 1; pit != endpit; ++pit) {
-                       Paragraph & par = pars[pit];
+                       Paragraph const & par = pars[pit];
                        result += par.asString(buffer, 0, par.size(), label) + "\n\n";
                }
 
@@ -1048,9 +1126,9 @@ string LCursor::selectionAsString(bool label) const
                return result;
        }
 
-#ifdef WITH_WARNINGS
-#warning and mathed?
-#endif
+       if (inMathed())
+               return lyx::cap::grabSelection(*this);
+
        return string();
 }
 
@@ -1167,7 +1245,7 @@ void LCursor::fixIfBroken()
                               << ". Trying to correct this."  << endl;
                        newdepth = copy.depth() - 1;
                }
-               copy.pop();     
+               copy.pop();
        }
        // shrink cursor to a size where everything is valid, possibly
        // leaving insets