]> git.lyx.org Git - lyx.git/blobdiff - src/converter.C
GTK graphics dialog: Default to scaling 100% when no scaling or size is given
[lyx.git] / src / converter.C
index 7ce839105aa506ca9198d7b5c0ce05ea5d73ff9f..1d5b67c19700e6184a836709c0ff96499763cabf 100644 (file)
@@ -36,6 +36,8 @@ using lyx::support::compare_ascii_no_case;
 using lyx::support::contains;
 using lyx::support::DirList;
 using lyx::support::GetExtension;
+using lyx::support::IsFileReadable;
+using lyx::support::LibFileSearch;
 using lyx::support::LibScriptSearch;
 using lyx::support::MakeRelPath;
 using lyx::support::OnlyFilename;
@@ -75,7 +77,7 @@ string const dvipdfm_options(BufferParams const & bp)
 {
        string result;
 
-       if (bp.papersize2 != VM_PAPER_CUSTOM) {
+       if (bp.papersize != PAPER_CUSTOM) {
                string const paper_size = bp.paperSizeName();
                if (paper_size != "b5" && paper_size != "foolscap")
                        result = "-p "+ paper_size;
@@ -103,10 +105,11 @@ private:
 } // namespace anon
 
 
-Converter::Converter(string const & f, string const & t, string const & c,
-         string const & l): from(f), to(t), command(c), flags(l),
-                            From(0), To(0), latex(false), xml(false),
-                            original_dir(false), need_aux(false)
+Converter::Converter(string const & f, string const & t,
+                    string const & c, string const & l)
+       : from(f), to(t), command(c), flags(l),
+         From(0), To(0), latex(false), xml(false),
+         original_dir(false), need_aux(false)
 {}
 
 
@@ -158,7 +161,7 @@ bool operator<(Converter const & a, Converter const & b)
 Converter const * Converters::getConverter(string const & from,
                                            string const & to) const
 {
-       ConverterList::const_iterator cit =
+       ConverterList::const_iterator const cit =
                find_if(converterlist_.begin(), converterlist_.end(),
                        ConverterEqual(from, to));
        if (cit != converterlist_.end())
@@ -170,7 +173,7 @@ Converter const * Converters::getConverter(string const & from,
 
 int Converters::getNumber(string const & from, string const & to) const
 {
-       ConverterList::const_iterator cit =
+       ConverterList::const_iterator const cit =
                find_if(converterlist_.begin(), converterlist_.end(),
                        ConverterEqual(from, to));
        if (cit != converterlist_.end())
@@ -215,9 +218,10 @@ void Converters::add(string const & from, string const & to,
 
 void Converters::erase(string const & from, string const & to)
 {
-       ConverterList::iterator it = find_if(converterlist_.begin(),
-                                            converterlist_.end(),
-                                            ConverterEqual(from, to));
+       ConverterList::iterator const it =
+               find_if(converterlist_.begin(),
+                       converterlist_.end(),
+                       ConverterEqual(from, to));
        if (it != converterlist_.end())
                converterlist_.erase(it);
 }
@@ -277,16 +281,44 @@ OutputParams::FLAVOR Converters::getFlavor(Graph::EdgePath const & path)
 bool Converters::convert(Buffer const * buffer,
                         string const & from_file, string const & to_file_base,
                         string const & from_format, string const & to_format,
-                        string & to_file)
+                        string & to_file, bool try_default)
 {
-       to_file = ChangeExtension(to_file_base,
-                                 formats.extension(to_format));
+       string const to_ext = formats.extension(to_format);
+       to_file = ChangeExtension(to_file_base, to_ext);
 
        if (from_format == to_format)
                return move(from_format, from_file, to_file, false);
 
        Graph::EdgePath edgepath = getPath(from_format, to_format);
        if (edgepath.empty()) {
+               if (try_default) {
+                       // if no special converter defined, then we take the
+                       // default one from ImageMagic.
+                       string const from_ext = from_format.empty() ?
+                               GetExtension(from_file) :
+                               formats.extension(from_format);
+                       string const command =
+                               "sh " +
+                               QuoteName(LibFileSearch("scripts", "convertDefault.sh")) +
+                               ' ' +
+                               QuoteName(from_ext + ':' + from_file) +
+                               ' ' +
+                               QuoteName(to_ext + ':' + to_file);
+                       lyxerr[Debug::FILES]
+                               << "No converter defined! "
+                                  "I use convertDefault.sh:\n\t"
+                               << command << endl;
+                       Systemcall one;
+                       one.startscript(Systemcall::Wait, command);
+                       if (IsFileReadable(to_file)) {
+                               return true;
+                       }
+               }
+               Alert::error(_("Cannot convert file"),
+                       bformat(_("No information for converting %1$s "
+                               "format files to %2$s.\n"
+                               "Try defining a convertor in the preferences."),
+                       from_format, to_format));
                return false;
        }
        OutputParams runparams;
@@ -324,7 +356,7 @@ bool Converters::convert(Buffer const * buffer,
 
                if (conv.latex) {
                        run_latex = true;
-                       string command = subst(conv.command, token_from, "");
+                       string const command = subst(conv.command, token_from, "");
                        lyxerr[Debug::FILES] << "Running " << command << endl;
                        if (!runLaTeX(*buffer, command, runparams))
                                return false;
@@ -337,9 +369,9 @@ bool Converters::convert(Buffer const * buffer,
                                runLaTeX(*buffer, latex_command_, runparams);
                        }
 
-                       string infile2 = (conv.original_dir)
+                       string const infile2 = (conv.original_dir)
                                ? infile : MakeRelPath(infile, path);
-                       string outfile2 = (conv.original_dir)
+                       string const outfile2 = (conv.original_dir)
                                ? outfile : MakeRelPath(outfile, path);
 
                        string command = conv.command;
@@ -363,7 +395,7 @@ bool Converters::convert(Buffer const * buffer,
                                buffer->message(_("Executing command: ")
                                        + command);
 
-                       Systemcall::Starttype type = (dummy)
+                       Systemcall::Starttype const type = (dummy)
                                ? Systemcall::DontWait : Systemcall::Wait;
                        Systemcall one;
                        int res;
@@ -382,6 +414,9 @@ bool Converters::convert(Buffer const * buffer,
                                                << "renaming file " << outfile
                                                << " to " << real_outfile
                                                << endl;
+                               // Finally, don't forget to tell any future
+                               // converters to use the renamed file...
+                               outfile = real_outfile;
                        }
 
                        if (!conv.parselog.empty()) {
@@ -420,9 +455,9 @@ bool Converters::convert(Buffer const * buffer,
                                  subst(conv.result_file,
                                        token_base, OnlyFilename(to_base)));
                if (from_base != to_base) {
-                       string from = subst(conv.result_dir,
+                       string const from = subst(conv.result_dir,
                                            token_base, from_base);
-                       string to = subst(conv.result_dir,
+                       string const to = subst(conv.result_dir,
                                          token_base, to_base);
                        Mover const & mover = movers(conv.from);
                        if (!mover.rename(from, to)) {
@@ -438,8 +473,6 @@ bool Converters::convert(Buffer const * buffer,
 }
 
 
-// If from = /path/file.ext and to = /path2/file2.ext2 then this method
-// moves each /path/file*.ext file to /path2/file2*.ext2'
 bool Converters::move(string const & fmt,
                      string const & from, string const & to, bool copy)
 {
@@ -468,7 +501,9 @@ bool Converters::move(string const & fmt,
                                : mover.rename(from2, to2);
                        if (!moved && no_errors) {
                                Alert::error(_("Cannot convert file"),
-                                       bformat(_("Could not move a temporary file from %1$s to %2$s."),
+                                       bformat(copy ?
+                                               _("Could not copy a temporary file from %1$s to %2$s.") :
+                                               _("Could not move a temporary file from %1$s to %2$s."),
                                                from2, to2));
                                no_errors = false;
                        }
@@ -479,11 +514,12 @@ bool Converters::move(string const & fmt,
 
 bool Converters::convert(Buffer const * buffer,
                         string const & from_file, string const & to_file_base,
-                        string const & from_format, string const & to_format)
+                        string const & from_format, string const & to_format,
+                         bool try_default)
 {
        string to_file;
        return convert(buffer, from_file, to_file_base, from_format, to_format,
-                      to_file);
+                      to_file, try_default);
 }
 
 
@@ -506,7 +542,7 @@ bool Converters::scanLog(Buffer const & buffer, string const & /*command*/,
        runparams.flavor = OutputParams::LATEX;
        LaTeX latex("", runparams, filename, "");
        TeXErrors terr;
-       int result = latex.scanLogFile(terr);
+       int const result = latex.scanLogFile(terr);
 
        if (result & LaTeX::ERRORS)
                bufferErrors(buffer, terr);
@@ -514,6 +550,7 @@ bool Converters::scanLog(Buffer const & buffer, string const & /*command*/,
        return true;
 }
 
+
 namespace {
 
 class showMessage : public std::unary_function<string, void>, public boost::signals::trackable {
@@ -539,21 +576,22 @@ bool Converters::runLaTeX(Buffer const & buffer, string const & command,
        runparams.document_language = buffer.params().language->babel();
 
        // do the LaTeX run(s)
-       string name = buffer.getLatexName();
+       string const name = buffer.getLatexName();
        LaTeX latex(command, runparams, name, buffer.filePath());
        TeXErrors terr;
        showMessage show(buffer);
        latex.message.connect(show);
-       int result = latex.run(terr);
+       int const result = latex.run(terr);
 
        if (result & LaTeX::ERRORS)
                bufferErrors(buffer, terr);
 
        // check return value from latex.run().
        if ((result & LaTeX::NO_LOGFILE)) {
-               string str = bformat(_("LaTeX did not run successfully. "
-                                      "Additionally, LyX could not locate "
-                                      "the LaTeX log %1$s."), name);
+               string const str =
+                       bformat(_("LaTeX did not run successfully. "
+                                 "Additionally, LyX could not locate "
+                                 "the LaTeX log %1$s."), name);
                Alert::error(_("LaTeX failed"), str);
        } else if (result & LaTeX::NO_OUTPUT) {
                Alert::warning(_("Output is empty"),
@@ -578,7 +616,7 @@ void Converters::buildGraph()
 {
        G_.init(formats.size());
        ConverterList::iterator beg = converterlist_.begin();
-       ConverterList::iterator end = converterlist_.end();
+       ConverterList::iterator const end = converterlist_.end();
        for (ConverterList::iterator it = beg; it != end ; ++it) {
                int const s = formats.getNumber(it->from);
                int const t = formats.getNumber(it->to);
@@ -593,7 +631,7 @@ Converters::intToFormat(std::vector<int> const & input)
        vector<Format const *> result(input.size());
 
        vector<int>::const_iterator it = input.begin();
-       vector<int>::const_iterator end = input.end();
+       vector<int>::const_iterator const end = input.end();
        vector<Format const *>::iterator rit = result.begin();
        for ( ; it != end; ++it, ++rit) {
                *rit = &formats.get(*it);
@@ -601,8 +639,9 @@ Converters::intToFormat(std::vector<int> const & input)
        return result;
 }
 
+
 vector<Format const *> const
-Converters::getReachableTo(string const & target, bool clear_visited)
+Converters::getReachableTo(string const & target, bool const clear_visited)
 {
        vector<int> const & reachablesto =
                G_.getReachableTo(formats.getNumber(target), clear_visited);
@@ -612,8 +651,8 @@ Converters::getReachableTo(string const & target, bool clear_visited)
 
 
 vector<Format const *> const
-Converters::getReachable(string const & from, bool only_viewable,
-                        bool clear_visited)
+Converters::getReachable(string const & from, bool const only_viewable,
+                        bool const clear_visited)
 {
        vector<int> const & reachables =
                G_.getReachable(formats.getNumber(from),