don't pass temporary string objects as parameters

[lyx.git] / src / chset.C

diff --git a/src/chset.C b/src/chset.C
index d0258c51e826a80cd56b9ad4706c7f4b86f033b6..eb1ca5146954e74fdaaf9576b073e3c4f7c86e04 100644 (file)
--- a/src/chset.C
+++ b/src/chset.C
@@ -1,27 +1,43 @@
-#include <config.h>
+/**
+ * \file chset.C
+ * This file is part of LyX, the document processor.
+ * Licence details can be found in the file COPYING.
+ *
+ * \author Lars Gullik Bjønnes
+ * \author Jean-Marc Lasgouttes
+ *
+ * Full author contact details are available in file CREDITS.
+ */
 
-#ifdef __GNUG__
-#pragma implementation
-#endif
+#include <config.h>
 
 #include "chset.h"
-#include "support/filetools.h"
-#include "support/lyxlib.h"
+
 #include "debug.h"
 
+#include "support/convert.h"
+#include "support/filetools.h"
+
 #include <boost/regex.hpp>
 
 #include <fstream>
 
-using std::ifstream;
-using std::getline;
-using std::pair;
-using std::make_pair;
-using std::endl;
+
+namespace lyx {
+
+using support::libFileSearch;
+
 using boost::regex;
-using boost::regex_match;
 using boost::smatch;
 
+using std::endl;
+using std::getline;
+using std::make_pair;
+
+using std::ifstream;
+using std::pair;
+using std::string;
+
 
 bool CharacterSet::loadFile(string const & fname)
 {
@@ -35,7 +51,7 @@ bool CharacterSet::loadFile(string const & fname)
        // open definition file
        lyxerr[Debug::KBMAP]
                << "Reading character set file " << fname << ".cdef" << endl;
-       string const filename = LibFileSearch("kbd", fname, "cdef");
+       string const filename = libFileSearch("kbd", fname, "cdef");
        ifstream ifs(filename.c_str());
        if (!ifs) {
                lyxerr << "Unable to open character set file" << endl;
@@ -52,11 +68,11 @@ bool CharacterSet::loadFile(string const & fname)
        while (getline(ifs, line)) {
                smatch sub;
                if (regex_match(line, sub, reg)) {
-                       int const n = lyx::atoi(sub.str(1));
+                       int const n = convert<int>(sub.str(1));
                        string const str = sub.str(2);
                        if (lyxerr.debugging(Debug::KBMAP))
                                lyxerr << "Chardef: " << n
-                                      << " to [" << str << "]" << endl;
+                                      << " to [" << str << ']' << endl;
                        map_[str] = n;
                }
        }
@@ -67,7 +83,7 @@ bool CharacterSet::loadFile(string const & fname)
 
 pair<bool, int> const CharacterSet::encodeString(string const & str) const
 {
-       lyxerr[Debug::KBMAP] << "Checking if we know [" << str << "]" << endl;
+       lyxerr[Debug::KBMAP] << "Checking if we know [" << str << ']' << endl;
        bool ret = false;
        int val = 0;
        Cdef::const_iterator cit = map_.find(str);
@@ -77,7 +93,7 @@ pair<bool, int> const CharacterSet::encodeString(string const & str) const
        }
        lyxerr[Debug::KBMAP] << "   "
                             << (ret ? "yes we" : "no we don't")
-                            <<  " know [" << str << "]" << endl;
+                            <<  " know [" << str << ']' << endl;
        return make_pair(ret, val);
 }
 
@@ -86,3 +102,6 @@ string const & CharacterSet::getName() const
 {
        return name_;
 }
+
+
+} // namespace lyx