clean code to export between different flavours, output different code for sgml to...

[lyx.git] / src / chset.C

diff --git a/src/chset.C b/src/chset.C
index 66cfb09b1b41f79a68ef10d6eec61fa80a5e610b..e97330e2ff656542af8955fa7b42a7e54dca04d1 100644 (file)
--- a/src/chset.C
+++ b/src/chset.C
@@ -1,54 +1,76 @@
+/**
+ * \file chset.C
+ * This file is part of LyX, the document processor.
+ * Licence details can be found in the file COPYING.
+ *
+ * \author Lars Gullik Bjønnes
+ * \author Jean-Marc Lasgouttes
+ *
+ * Full author contact details are available in file CREDITS.
+ */
+
 #include <config.h>
 
-#ifdef __GNUG__
-#pragma implementation
-#endif
+#include "chset.h"
+
+#include "debug.h"
+
+#include "support/filetools.h"
+#include "support/lyxlib.h"
+
+#include <boost/regex.hpp>
 
 #include <fstream>
+
+using lyx::support::atoi;
+using lyx::support::LibFileSearch;
+
+using boost::regex;
+using boost::smatch;
+
+using std::endl;
+using std::getline;
+using std::make_pair;
+
 using std::ifstream;
+using std::pair;
+using std::string;
 
-#include "chset.h"
-#include "support/filetools.h"
-#include "support/LRegex.h"
-#include "support/LSubstring.h"
-#include "debug.h"
 
 bool CharacterSet::loadFile(string const & fname)
 {
        map_.clear();
-       name_.clear();
-       
-       if (fname.empty() || fname == "ascii") 
-               return true;    // ascii 7-bit
-       
+       name_.erase();
+
+       // ascii 7-bit
+       if (fname.empty() || fname == "ascii")
+               return true;
+
        // open definition file
        lyxerr[Debug::KBMAP]
                << "Reading character set file " << fname << ".cdef" << endl;
-       string filename = LibFileSearch("kbd", fname.c_str(), "cdef");
+       string const filename = LibFileSearch("kbd", fname, "cdef");
        ifstream ifs(filename.c_str());
        if (!ifs) {
                lyxerr << "Unable to open character set file" << endl;
                return true;            // no definition, use 7-bit ascii
        }
        name_ = fname;
-       
-       string str;
-       int n;
+
        string line;
        // Ok, I'll be the first to admit that this is probably not
        // the fastest way to parse the cdef files, but I though it
        // was a bit neat. Anyway it is wrong to use the lyxlex parse
-       // without the use of a keyword table.     
-       LRegex reg("^([12][0-9][0-9])[ \t]+\"([^ ]+)\".*");
-       while(getline(ifs, line)) {
-               if (reg.exact_match(line)) {
-                       LRegex::SubMatches const & sub = reg.exec(line);
-                       n = atoi(line.substr(sub[1].first,
-                                            sub[1].second).c_str());
-                       str = LSubstring(line, sub[2].first, sub[2].second);
+       // without the use of a keyword table.
+       regex reg("^([12][0-9][0-9])[ \t]+\"([^ ]+)\".*");
+       while (getline(ifs, line)) {
+               smatch sub;
+               if (regex_match(line, sub, reg)) {
+                       int const n = atoi(sub.str(1));
+                       string const str = sub.str(2);
                        if (lyxerr.debugging(Debug::KBMAP))
                                lyxerr << "Chardef: " << n
-                                      << " to [" << str << "]" << endl;
+                                      << " to [" << str << ']' << endl;
                        map_[str] = n;
                }
        }
@@ -57,19 +79,19 @@ bool CharacterSet::loadFile(string const & fname)
 }
 
 
-pair<bool, int> CharacterSet::encodeString(string & str) const
+pair<bool, int> const CharacterSet::encodeString(string const & str) const
 {
-       lyxerr[Debug::KBMAP] << "Checking if we know [" << str << "]" << endl;
+       lyxerr[Debug::KBMAP] << "Checking if we know [" << str << ']' << endl;
        bool ret = false;
        int val = 0;
        Cdef::const_iterator cit = map_.find(str);
        if (cit != map_.end()) {
                ret =  true;
-               val = (*cit).second;
+               val = cit->second;
        }
        lyxerr[Debug::KBMAP] << "   "
                             << (ret ? "yes we" : "no we don't")
-                            <<  " know [" << str << "]" << endl;
+                            <<  " know [" << str << ']' << endl;
        return make_pair(ret, val);
 }