]> git.lyx.org Git - lyx.git/blobdiff - src/changes.C
Trivial fixes to some warnings thrown up by MSVS.Net 2003.
[lyx.git] / src / changes.C
index c97ec917031fadf3b460034db3925f0aaa26fda7..fd12f218fd05625e075413bf084a65128668b950 100644 (file)
@@ -1,26 +1,28 @@
 /**
  * \file changes.C
- * Copyright 2002 the LyX Team
- * Read the file COPYING
+ * This file is part of LyX, the document processor.
+ * Licence details can be found in the file COPYING.
  *
- * Record changes in a paragraph.
+ * \author John Levon
+ *
+ * Full author contact details are available in file CREDITS.
  *
- * \author John Levon <levon@movementarian.org>
+ * Record changes in a paragraph.
  */
 
 #include <config.h>
 
 #include "changes.h"
 #include "debug.h"
-#include "author.h"
 
-#include "support/LAssert.h"
-#include "support/LOstream.h"
+#include <boost/assert.hpp>
 
-using std::vector;
-using std::endl;
 using lyx::pos_type;
 
+using std::endl;
+using std::string;
+
+
 bool operator==(Change const & l, Change const & r)
 {
        return l.type == r.type && l.author == r.author
@@ -58,13 +60,13 @@ bool Changes::Range::contained(Range const & r) const
 }
 
 
-bool Changes::Range::contains(pos_type pos) const
+bool Changes::Range::contains(pos_type const pos) const
 {
        return pos >= start && pos < end;
 }
 
 
-bool Changes::Range::loose_contains(pos_type pos) const
+bool Changes::Range::loose_contains(pos_type const pos) const
 {
        return pos >= start && pos <= end;
 }
@@ -77,7 +79,7 @@ bool Changes::Range::intersects(Range const & r) const
 }
 
 
-Changes::Changes(Change::Type type)
+Changes::Changes(Change::Type const type)
        : empty_type_(type)
 {
 }
@@ -94,11 +96,13 @@ Changes::Changes(Changes const & c)
 }
 
 
-void Changes::record(Change change, pos_type pos)
+void Changes::record(Change const change, pos_type const pos)
 {
-       lyxerr[Debug::CHANGES] << "record " << change.type
-               << " at pos " << pos << " with total "
-               << table_.size() << " changes." << endl;
+       if (lyxerr.debugging(Debug::CHANGES)) {
+               lyxerr[Debug::CHANGES] << "record " << change.type
+                       << " at pos " << pos << " with total "
+                       << table_.size() << " changes." << endl;
+       }
 
        switch (change.type) {
                case Change::INSERTED:
@@ -114,39 +118,45 @@ void Changes::record(Change change, pos_type pos)
 }
 
 
-void Changes::set(Change change, pos_type pos)
+void Changes::set(Change const change, pos_type const pos)
 {
        set(change, pos, pos + 1);
 }
 
 
-void Changes::set(Change::Type type, pos_type pos)
+void Changes::set(Change::Type const type, pos_type const pos)
 {
        set(type, pos, pos + 1);
 }
 
 
-void Changes::set(Change::Type type, pos_type start, pos_type end)
+void Changes::set(Change::Type const type,
+                 pos_type const start, pos_type const end)
 {
        set(Change(type), start, end);
 }
 
 
-void Changes::set(Change change, pos_type start, pos_type end)
+void Changes::set(Change const change,
+                 pos_type const start, pos_type const end)
 {
        ChangeTable::iterator it = table_.begin();
 
-       lyxerr[Debug::CHANGES] << "changeset of " << change.type
-               << " author " << change.author << " time " << change.changetime
-               << " in range " << start << "," << end << endl;
+       if (lyxerr.debugging(Debug::CHANGES)) {
+               lyxerr[Debug::CHANGES] << "changeset of " << change.type
+                       << " author " << change.author << " time " << change.changetime
+                       << " in range " << start << "," << end << endl;
+       }
 
        Range const new_range(start, end);
 
        // remove all sub-ranges
        for (; it != table_.end();) {
                if (new_range != it->range && it->range.contained(new_range)) {
-                       lyxerr[Debug::CHANGES] << "Removing subrange "
-                               << it->range.start << "," << it->range.end << endl;
+                       if (lyxerr.debugging(Debug::CHANGES)) {
+                               lyxerr[Debug::CHANGES] << "Removing subrange "
+                                       << it->range.start << "," << it->range.end << endl;
+                       }
                        it = table_.erase(it);
                } else {
                        ++it;
@@ -154,7 +164,7 @@ void Changes::set(Change change, pos_type start, pos_type end)
        }
 
        it = table_.begin();
-       ChangeTable::iterator itend = table_.end();
+       ChangeTable::iterator const itend = table_.end();
 
        // find a super-range
        for (; it != itend; ++it) {
@@ -177,14 +187,18 @@ void Changes::set(Change change, pos_type start, pos_type end)
 
        ChangeRange c(*it);
 
-       lyxerr[Debug::CHANGES] << "Using change of type " << c.change.type
-               << " over " << c.range.start << "," << c.range.end << endl;
+       if (lyxerr.debugging(Debug::CHANGES)) {
+               lyxerr[Debug::CHANGES] << "Using change of type " << c.change.type
+                       << " over " << c.range.start << "," << c.range.end << endl;
+       }
 
        // split head
        if (c.range.start < start) {
                it = table_.insert(it, ChangeRange(c.range.start, start, c.change));
-               lyxerr[Debug::CHANGES] << "Splitting head of type " << c.change.type
-                       << " over " << c.range.start << "," << start << endl;
+               if (lyxerr.debugging(Debug::CHANGES)) {
+                       lyxerr[Debug::CHANGES] << "Splitting head of type " << c.change.type
+                               << " over " << c.range.start << "," << start << endl;
+               }
                ++it;
        }
 
@@ -198,8 +212,10 @@ void Changes::set(Change change, pos_type start, pos_type end)
        if (c.range.end > end) {
                ++it;
                table_.insert(it, ChangeRange(end, c.range.end, c.change));
-               lyxerr[Debug::CHANGES] << "Splitting tail of type " << c.change.type
-                       << " over " << end << "," << c.range.end << endl;
+               if (lyxerr.debugging(Debug::CHANGES)) {
+                       lyxerr[Debug::CHANGES] << "Splitting tail of type " << c.change.type
+                               << " over " << end << "," << c.range.end << endl;
+               }
        }
 
        check();
@@ -207,7 +223,7 @@ void Changes::set(Change change, pos_type start, pos_type end)
 }
 
 
-void Changes::erase(pos_type pos)
+void Changes::erase(pos_type const pos)
 {
        ChangeTable::iterator it = table_.begin();
        ChangeTable::iterator end = table_.end();
@@ -217,8 +233,10 @@ void Changes::erase(pos_type pos)
        for (; it != end; ++it) {
                Range & range(it->range);
 
-               lyxerr[Debug::CHANGES] << "era:Range of type " << it->change.type << " is "
-                       << it->range.start << "," << it->range.end << endl;
+               if (lyxerr.debugging(Debug::CHANGES)) {
+                       lyxerr[Debug::CHANGES] << "era:Range of type " << it->change.type << " is "
+                               << it->range.start << "," << it->range.end << endl;
+               }
 
                if (range.contains(pos)) {
                        found = true;
@@ -236,7 +254,7 @@ void Changes::erase(pos_type pos)
 }
 
 
-void Changes::del(Change change, ChangeTable::size_type pos)
+void Changes::del(Change const change, ChangeTable::size_type const pos)
 {
        // this case happens when building from .lyx
        if (table_.empty()) {
@@ -265,7 +283,7 @@ void Changes::del(Change change, ChangeTable::size_type pos)
 }
 
 
-void Changes::add(Change change, ChangeTable::size_type pos)
+void Changes::add(Change const change, ChangeTable::size_type const pos)
 {
        ChangeTable::iterator it = table_.begin();
        ChangeTable::iterator end = table_.end();
@@ -277,8 +295,10 @@ void Changes::add(Change change, ChangeTable::size_type pos)
 
                if (!found && range.loose_contains(pos)) {
                        found = true;
-                       lyxerr[Debug::CHANGES] << "Found range of "
-                               << range.start << "," << range.end << endl;
+                       if (lyxerr.debugging(Debug::CHANGES)) {
+                               lyxerr[Debug::CHANGES] << "Found range of "
+                                       << range.start << "," << range.end << endl;
+                       }
                        ++range.end;
                        continue;
                }
@@ -292,15 +312,16 @@ void Changes::add(Change change, ChangeTable::size_type pos)
 }
 
 
-Change const Changes::lookupFull(pos_type pos) const
+Change const Changes::lookupFull(pos_type const pos) const
 {
        if (!table_.size()) {
-               lyxerr[Debug::CHANGES] << "Empty, type is " << empty_type_ << endl;
+               if (lyxerr.debugging(Debug::CHANGES))
+                       lyxerr[Debug::CHANGES] << "Empty, type is " << empty_type_ << endl;
                return Change(empty_type_);
        }
 
        ChangeTable::const_iterator it = table_.begin();
-       ChangeTable::const_iterator end = table_.end();
+       ChangeTable::const_iterator const end = table_.end();
 
        for (; it != end; ++it) {
                if (it->range.contains(pos))
@@ -308,15 +329,16 @@ Change const Changes::lookupFull(pos_type pos) const
        }
 
        check();
-       lyx::Assert(0);
+       BOOST_ASSERT(false && "missing changes for pos");
        return Change(Change::UNCHANGED);
 }
 
 
-Change::Type Changes::lookup(pos_type pos) const
+Change::Type Changes::lookup(pos_type const pos) const
 {
        if (!table_.size()) {
-               lyxerr[Debug::CHANGES] << "Empty, type is " << empty_type_ << endl;
+               if (lyxerr.debugging(Debug::CHANGES))
+                       lyxerr[Debug::CHANGES] << "Empty, type is " << empty_type_ << endl;
                return empty_type_;
        }
 
@@ -329,31 +351,37 @@ Change::Type Changes::lookup(pos_type pos) const
        }
 
        check();
-       lyx::Assert(0);
+       BOOST_ASSERT(false && "missing changes for pos");
        return Change::UNCHANGED;
 }
 
 
-bool Changes::isChange(pos_type start, pos_type end) const
+bool Changes::isChange(pos_type const start, pos_type const end) const
 {
        if (!table_.size()) {
-               lyxerr[Debug::CHANGES] << "Empty, type is " << empty_type_ << endl;
+               if (lyxerr.debugging(Debug::CHANGES))
+                       lyxerr[Debug::CHANGES] << "Empty, type is " << empty_type_ << endl;
                return empty_type_ != Change::UNCHANGED;
        }
 
        ChangeTable::const_iterator it = table_.begin();
-       ChangeTable::const_iterator itend = table_.end();
+       ChangeTable::const_iterator const itend = table_.end();
 
        for (; it != itend; ++it) {
-               lyxerr[Debug::CHANGES] << "Looking for " << start << ","
-                       << end << " in " << it->range.start << ","
-                       << it->range.end << "of type " << it->change.type << endl;
+               if (lyxerr.debugging(Debug::CHANGES)) {
+                       lyxerr[Debug::CHANGES] << "Looking for " << start << ","
+                               << end << " in " << it->range.start << ","
+                               << it->range.end << "of type " << it->change.type << endl;
+               }
+
                if (it->range.intersects(Range(start, end))
                        && it->change.type != Change::UNCHANGED) {
-                       lyxerr[Debug::CHANGES] << "Found intersection of "
-                               << start << "," << end << " with "
-                               << it->range.start << "," << it->range.end
-                               << " of type " << it->change.type << endl;
+                       if (lyxerr.debugging(Debug::CHANGES)) {
+                               lyxerr[Debug::CHANGES] << "Found intersection of "
+                                       << start << "," << end << " with "
+                                       << it->range.start << "," << it->range.end
+                                       << " of type " << it->change.type << endl;
+                       }
                        return true;
                }
        }
@@ -362,15 +390,17 @@ bool Changes::isChange(pos_type start, pos_type end) const
 }
 
 
-bool Changes::isChangeEdited(lyx::pos_type start, lyx::pos_type end) const
+bool Changes::isChangeEdited(lyx::pos_type const start,
+                            lyx::pos_type const end) const
 {
        if (!table_.size()) {
-               lyxerr[Debug::CHANGES] << "Empty, type is " << empty_type_ << endl;
+               if (lyxerr.debugging(Debug::CHANGES))
+                       lyxerr[Debug::CHANGES] << "Empty, type is " << empty_type_ << endl;
                return empty_type_ != Change::INSERTED;
        }
 
        ChangeTable::const_iterator it = table_.begin();
-       ChangeTable::const_iterator itend = table_.end();
+       ChangeTable::const_iterator const itend = table_.end();
 
        for (; it != itend; ++it) {
                if (it->range.intersects(Range(start, end ? end - 1 : 0))
@@ -384,16 +414,23 @@ bool Changes::isChangeEdited(lyx::pos_type start, lyx::pos_type end) const
 
 void Changes::merge()
 {
-       lyxerr[Debug::CHANGES] << "Starting merge" << endl;
+       if (lyxerr.debugging(Debug::CHANGES))
+               lyxerr[Debug::CHANGES] << "Starting merge" << endl;
+
        ChangeTable::iterator it = table_.begin();
 
        while (it != table_.end()) {
-               lyxerr[Debug::CHANGES] << "Range of type " << it->change.type << " is "
-                       << it->range.start << "," << it->range.end << endl;
+               if (lyxerr.debugging(Debug::CHANGES)) {
+                       lyxerr[Debug::CHANGES] << "Range of type " << it->change.type << " is "
+                               << it->range.start << "," << it->range.end << endl;
+               }
 
                if (it->range.start == it->range.end) {
-                       lyxerr[Debug::CHANGES] << "Removing empty range for pos "
-                               << it->range.start << endl;
+                       if (lyxerr.debugging(Debug::CHANGES)) {
+                               lyxerr[Debug::CHANGES] << "Removing empty range for pos "
+                                       << it->range.start << endl;
+                       }
+
                        table_.erase(it);
                        // start again
                        it = table_.begin();
@@ -404,10 +441,13 @@ void Changes::merge()
                        break;
 
                if (it->change == (it + 1)->change) {
-                       lyxerr[Debug::CHANGES] << "Merging equal ranges "
-                               << it->range.start << "," << it->range.end
-                               << " and " << (it + 1)->range.start << ","
-                               << (it + 1)->range.end << endl;
+                       if (lyxerr.debugging(Debug::CHANGES)) {
+                               lyxerr[Debug::CHANGES] << "Merging equal ranges "
+                                       << it->range.start << "," << it->range.end
+                                       << " and " << (it + 1)->range.start << ","
+                                       << (it + 1)->range.end << endl;
+                       }
+
                        (it + 1)->range.start = it->range.start;
                        table_.erase(it);
                        // start again
@@ -428,13 +468,16 @@ void Changes::check() const
        ChangeTable::const_iterator it = table_.begin();
        ChangeTable::const_iterator end = table_.end();
 
-       bool dont_assert(true);
+       bool dont_assert = true;
 
        lyxerr[Debug::CHANGES] << "Changelist:" << endl;
        for (; it != end; ++it) {
-               lyxerr[Debug::CHANGES] << "Range of type " << it->change.type << " is "
-                       << it->range.start << "," << it->range.end << " author "
-                       << it->change.author << " time " << it->change.changetime << endl;
+               if (lyxerr.debugging(Debug::CHANGES)) {
+                       lyxerr[Debug::CHANGES] << "Range of type " << it->change.type << " is "
+                               << it->range.start << "," << it->range.end << " author "
+                               << it->change.author << " time " << it->change.changetime << endl;
+               }
+
                if (it + 1 == end)
                        break;
 
@@ -443,14 +486,19 @@ void Changes::check() const
                if (range.end != next.start)
                        dont_assert = false;
        }
-       lyxerr[Debug::CHANGES] << "End" << endl;
-       lyx::Assert(dont_assert);
+
+       if (lyxerr.debugging(Debug::CHANGES))
+               lyxerr[Debug::CHANGES] << "End" << endl;
+
+       BOOST_ASSERT(dont_assert);
 }
 
 
-int Changes::latexMarkChange(std::ostream & os, Change::Type old, Change::Type change)
+int Changes::latexMarkChange(std::ostream & os,
+                            Change::Type const old, Change::Type const change,
+                            bool const & output)
 {
-       if (old == change)
+       if (!output || old == change)
                return 0;
 
        string const start("\\changestart{}");
@@ -492,8 +540,9 @@ int Changes::latexMarkChange(std::ostream & os, Change::Type old, Change::Type c
 }
 
 
-void Changes::lyxMarkChange(std::ostream & os, int & column, lyx::time_type curtime,
-       Change const & old, Change const & change)
+void Changes::lyxMarkChange(std::ostream & os, int & column,
+                           lyx::time_type const curtime,
+                           Change const & old, Change const & change)
 {
        if (old == change)
                return;
@@ -506,7 +555,7 @@ void Changes::lyxMarkChange(std::ostream & os, int & column, lyx::time_type curt
                        break;
 
                case Change::DELETED: {
-                       lyx::time_type t(change.changetime);
+                       lyx::time_type t = change.changetime;
                        if (!t)
                                t = curtime;
                        os << "\n\\change_deleted " << change.author
@@ -515,12 +564,13 @@ void Changes::lyxMarkChange(std::ostream & os, int & column, lyx::time_type curt
                        break;
                }
 
-               case Change::INSERTED:
-                       lyx::time_type t(change.changetime);
+       case Change::INSERTED: {
+                       lyx::time_type t = change.changetime;
                        if (!t)
                                t = curtime;
                        os << "\n\\change_inserted " << change.author
                                << " " << t << "\n";
                        break;
        }
+       }
 }