]> git.lyx.org Git - lyx.git/blobdiff - src/buffer.C
whitespace changes;
[lyx.git] / src / buffer.C
index d9dc5782f5df2c0c078f2f6022b433b5bcb77ee9..d58ef540abba0bab9621b472228b1c90bf14e4af 100644 (file)
@@ -97,8 +97,8 @@
 #include "lyxtext.h"
 #include "gettext.h"
 #include "language.h"
-#include "lyx_gui_misc.h"      // WarnReadonly()
 #include "frontends/Dialogs.h"
+#include "frontends/Alert.h"
 #include "encoding.h"
 #include "exporter.h"
 #include "Lsstream.h"
@@ -123,6 +123,8 @@ using std::set;
 using std::stack;
 using std::list;
 
+using lyx::pos_type;
+
 // all these externs should eventually be removed.
 extern BufferList bufferlist;
 
@@ -234,25 +236,6 @@ void Buffer::setReadonly(bool flag)
                updateTitles();
                users->owner()->getDialogs()->updateBufferDependent(false);
        }
-       if (read_only) {
-               WarnReadonly(filename);
-       }
-}
-
-
-bool Buffer::saveParamsAsDefaults() // const
-{
-       string const fname = AddName(AddPath(user_lyxdir, "templates/"),
-                              "defaults.lyx");
-       Buffer defaults = Buffer(fname);
-       
-       // Use the current buffer's parameters as default
-       defaults.params = params;
-       
-       // add an empty paragraph. Is this enough?
-       defaults.paragraph = new Paragraph;
-
-       return defaults.writeFile(defaults.filename, false);
 }
 
 
@@ -302,6 +285,7 @@ ErtComp ert_comp;
 
 #warning And _why_ is this here? (Lgb)
 int unknown_layouts;
+int unknown_tokens;
 
 } // anon
 
@@ -317,6 +301,7 @@ int unknown_layouts;
 bool Buffer::readLyXformat2(LyXLex & lex, Paragraph * par)
 {
        unknown_layouts = 0;
+       unknown_tokens = 0;
 #ifndef NO_COMPABILITY
        ert_comp.contents.erase();
        ert_comp.active = false;
@@ -379,9 +364,21 @@ bool Buffer::readLyXformat2(LyXLex & lex, Paragraph * par)
                        s += tostr(unknown_layouts);
                        s += _(" paragraphs");
                }
-               WriteAlert(_("Textclass Loading Error!"), s,
+               Alert::alert(_("Textclass Loading Error!"), s,
                           _("When reading " + fileName()));
-       }       
+       }
+
+       if (unknown_tokens > 0) {
+               string s = _("Encountered ");
+               if (unknown_tokens == 1) {
+                       s += _("one unknown token");
+               } else {
+                       s += tostr(unknown_tokens);
+                       s += _(" unknown tokens");
+               }
+               Alert::alert(_("Textclass Loading Error!"), s,
+                          _("When reading " + fileName()));
+       }
 
        return the_end_read;
 }
@@ -536,6 +533,8 @@ Buffer::parseSingleLyXformat2Token(LyXLex & lex, Paragraph *& par,
                                        + textclasslist.NameOfLayout(params.textclass, par->layout);
                                InsetError * new_inset = new InsetError(s);
                                par->insertInset(0, new_inset);
+                               par->setFont(0, LyXFont(LyXFont::ALL_INHERIT,
+                                                       params.language));
                        }
                        // Test whether the layout is obsolete.
                        LyXLayout const & layout =
@@ -668,19 +667,19 @@ Buffer::parseSingleLyXformat2Token(LyXLex & lex, Paragraph *& par,
                if (pp.first) {
                        params.textclass = pp.second;
                } else {
-                       WriteAlert(string(_("Textclass error")), 
+                       Alert::alert(string(_("Textclass error")), 
                                string(_("The document uses an unknown textclass \"")) + 
                                lex.getString() + string("\"."),
                                string(_("LyX will not be able to produce output correctly.")));
                        params.textclass = 0;
                }
                if (!textclasslist.Load(params.textclass)) {
-                               // if the textclass wasn't loaded properly
-                               // we need to either substitute another
-                               // or stop loading the file.
-                               // I can substitute but I don't see how I can
-                               // stop loading... ideas??  ARRae980418
-                       WriteAlert(_("Textclass Loading Error!"),
+                       // if the textclass wasn't loaded properly
+                       // we need to either substitute another
+                       // or stop loading the file.
+                       // I can substitute but I don't see how I can
+                       // stop loading... ideas??  ARRae980418
+                       Alert::alert(_("Textclass Loading Error!"),
                                   string(_("Can't load textclass ")) +
                                   textclasslist.NameOfClass(params.textclass),
                                   _("-- substituting default"));
@@ -1167,14 +1166,16 @@ Buffer::parseSingleLyXformat2Token(LyXLex & lex, Paragraph *& par,
                } else {
 #endif
                // This should be insurance for the future: (Asger)
-               lex.printError("Unknown token `$$Token'. "
-                              "Inserting as text.");
-               string::const_iterator cit = token.begin();
-               string::const_iterator end = token.end();
-               for (; cit != end; ++cit) {
-                       par->insertChar(pos, (*cit), font);
-                       ++pos;
-               }
+               ++unknown_tokens;
+               lex.eatLine();
+               string const s = _("Unknown token: ") + token
+                       + " " + lex.text()  + "\n";
+
+               InsetError * new_inset = new InsetError(s);
+               par->insertInset(pos, new_inset);
+               par->setFont(pos, LyXFont(LyXFont::ALL_INHERIT,
+                                         params.language));
+
 #ifndef NO_COMPABILITY
                }
 #endif
@@ -1339,12 +1340,14 @@ Buffer::parseSingleLyXformat2Token(LyXLex & lex, Paragraph *& par,
 }
 
 // needed to insert the selection
-void Buffer::insertStringAsLines(Paragraph *& par, Paragraph::size_type & pos,
-                                LyXFont const & font, 
-                                string const & str) const
+void Buffer::insertStringAsLines(Paragraph *& par, pos_type & pos,
+                                 LyXFont const & fn,string const & str) const
 {
        LyXLayout const & layout = textclasslist.Style(params.textclass, 
-                                                    par->getLayout());
+                                                      par->getLayout());
+       LyXFont font = fn;
+       
+       (void)par->checkInsertChar(font);
        // insert the string, don't insert doublespace
        bool space_inserted = true;
        for(string::const_iterator cit = str.begin(); 
@@ -1352,7 +1355,7 @@ void Buffer::insertStringAsLines(Paragraph *& par, Paragraph::size_type & pos,
                if (*cit == '\n') {
                        if (par->size() || layout.keepempty) { 
                                par->breakParagraph(params, pos, 
-                                                   layout.isEnvironment());
+                                                   layout.isEnvironment());
                                par = par->next();
                                pos = 0;
                                space_inserted = true;
@@ -1360,8 +1363,9 @@ void Buffer::insertStringAsLines(Paragraph *& par, Paragraph::size_type & pos,
                                continue;
                        }
                        // do not insert consecutive spaces if !free_spacing
-               } else if ((*cit == ' ' || *cit == '\t')
-                          && space_inserted && !layout.free_spacing) {
+               } else if ((*cit == ' ' || *cit == '\t') &&
+                          space_inserted && !layout.free_spacing)
+               {
                        continue;
                } else if (*cit == '\t') {
                        if (!layout.free_spacing) {
@@ -1370,9 +1374,8 @@ void Buffer::insertStringAsLines(Paragraph *& par, Paragraph::size_type & pos,
                                ++pos;
                                space_inserted = true;
                        } else {
-                               const Paragraph::size_type nb = 8 - pos % 8;
-                               for (Paragraph::size_type a = 0; 
-                                    a < nb ; ++a) {
+                               const pos_type nb = 8 - pos % 8;
+                               for (pos_type a = 0; a < nb ; ++a) {
                                        par->insertChar(pos, ' ', font);
                                        ++pos;
                                }
@@ -1536,35 +1539,36 @@ bool Buffer::readFile(LyXLex & lex, Paragraph * par)
                                // current format
                        } else if (file_format > LYX_FORMAT) {
                                // future format
-                               WriteAlert(_("Warning!"),
+                               Alert::alert(_("Warning!"),
                                           _("LyX file format is newer that what"),
                                           _("is supported in this LyX version. Expect some problems."));
                                
                        } else if (file_format < LYX_FORMAT) {
                                // old formats
                                if (file_format < 200) {
-                                       WriteAlert(_("ERROR!"),
+                                       Alert::alert(_("ERROR!"),
                                                   _("Old LyX file format found. "
                                                     "Use LyX 0.10.x to read this!"));
                                        return false;
                                }
                        }
                        bool the_end = readLyXformat2(lex, par);
-                       setPaperStuff();
+                       params.setPaperStuff();
                        // the_end was added in 213
                        if (file_format < 213)
                                the_end = true;
 
-                       if (!the_end)
-                               WriteAlert(_("Warning!"),
+                       if (!the_end) {
+                               Alert::alert(_("Warning!"),
                                           _("Reading of document is not complete"),
                                           _("Maybe the document is truncated"));
+                       }
                        return true;
                } else { // "\\lyxformat" not found
-                       WriteAlert(_("ERROR!"), _("Not a LyX file!"));
+                       Alert::alert(_("ERROR!"), _("Not a LyX file!"));
                }
        } else
-               WriteAlert(_("ERROR!"), _("Unable to read file!"));
+               Alert::alert(_("ERROR!"), _("Unable to read file!"));
        return false;
 }
                    
@@ -1660,7 +1664,7 @@ bool Buffer::writeFile(string const & fname, bool flag) const
                        lyxerr << _("Error! Document is read-only: ")
                               << fname << endl;
                else
-                       WriteAlert(_("Error! Document is read-only: "),
+                       Alert::alert(_("Error! Document is read-only: "),
                                   fname);
                return false;
        }
@@ -1673,7 +1677,7 @@ bool Buffer::writeFile(string const & fname, bool flag) const
                        lyxerr << _("Error! Cannot write file: ")
                               << fname << endl;
                else
-                       WriteFSAlert(_("Error! Cannot write file: "),
+                       Alert::err_alert(_("Error! Cannot write file: "),
                                     fname);
                return false;
        }
@@ -1684,7 +1688,7 @@ bool Buffer::writeFile(string const & fname, bool flag) const
                        lyxerr << _("Error! Cannot open file: ")
                               << fname << endl;
                else
-                       WriteFSAlert(_("Error! Cannot open file: "),
+                       Alert::err_alert(_("Error! Cannot open file: "),
                                     fname);
                return false;
        }
@@ -1809,7 +1813,7 @@ string const Buffer::asciiParagraph(Paragraph const * par,
                lyxerr << "Should this ever happen?" << endl;
        }
 
-       for (Paragraph::size_type i = 0; i < par->size(); ++i) {
+       for (pos_type i = 0; i < par->size(); ++i) {
                if (!i && !noparbreak) {
                        if (linelen > 0)
                                buffer << "\n\n";
@@ -1921,7 +1925,7 @@ void Buffer::writeFileAscii(string const & fname, int linelen)
 {
        ofstream ofs(fname.c_str());
        if (!ofs) {
-               WriteFSAlert(_("Error: Cannot write file:"), fname);
+               Alert::err_alert(_("Error: Cannot write file:"), fname);
                return;
        }
        writeFileAscii(ofs, linelen);
@@ -1955,7 +1959,7 @@ void Buffer::makeLaTeXFile(string const & fname,
 
        ofstream ofs(fname.c_str());
        if (!ofs) {
-               WriteFSAlert(_("Error: Cannot open file: "), fname);
+               Alert::err_alert(_("Error: Cannot open file: "), fname);
                return;
        }
        
@@ -2070,16 +2074,13 @@ void Buffer::makeLaTeXFile(string const & fname,
                if (params.language->babel() == "hebrew"
                    && default_language->babel() != "hebrew")
                         // This seems necessary
-                       features.UsedLanguages.insert(default_language);
+                       features.useLanguage(default_language);
 
                if (lyxrc.language_use_babel ||
                    params.language->lang() != lyxrc.default_language ||
-                   !features.UsedLanguages.empty()) {
+                   !features.hasLanguages()) {
                        use_babel = true;
-                       for (LaTeXFeatures::LanguageList::const_iterator cit =
-                                    features.UsedLanguages.begin();
-                            cit != features.UsedLanguages.end(); ++cit)
-                               language_options << (*cit)->babel() << ',';
+                       language_options << features.getLanguages();
                        language_options << params.language->babel();
                        if (lyxrc.language_global_options)
                                options << language_options.str() << ',';
@@ -2126,12 +2127,7 @@ void Buffer::makeLaTeXFile(string const & fname,
 
                        // Create a list with all the input encodings used 
                        // in the document
-                       set<string> encodings;
-                       for (LaTeXFeatures::LanguageList::const_iterator it =
-                                    features.UsedLanguages.begin();
-                            it != features.UsedLanguages.end(); ++it)
-                               if ((*it)->encoding()->LatexName() != doc_encoding)
-                                       encodings.insert((*it)->encoding()->LatexName());
+                       set<string> encodings = features.getEncodingSet(doc_encoding);
 
                        ofs << "\\usepackage[";
                        std::copy(encodings.begin(), encodings.end(),
@@ -2247,12 +2243,13 @@ void Buffer::makeLaTeXFile(string const & fname,
                        ofs << "}\n";
                        texrow.newline();
                }
-               if (features.amsstyle
-                   && !tclass.provides(LyXTextClass::amsmath)) {
+
+               if (features.isRequired("amsstyle")
+                           && !tclass.provides(LyXTextClass::amsmath)) {
                        ofs << "\\usepackage{amsmath}\n";
                        texrow.newline();
                }
-
+               
                if (tokenPos(tclass.opt_pagestyle(),
                             '|', params.pagestyle) >= 0) {
                        if (params.pagestyle == "fancy") {
@@ -2263,19 +2260,6 @@ void Buffer::makeLaTeXFile(string const & fname,
                        texrow.newline();
                }
 
-               // We try to load babel late, in case it interferes
-               // with other packages.
-               if (use_babel) {
-                       string tmp = lyxrc.language_package;
-                       if (!lyxrc.language_global_options
-                           && tmp == "\\usepackage{babel}")
-                               tmp = string("\\usepackage[") +
-                                       language_options.str().c_str() +
-                                       "]{babel}";
-                       ofs << tmp << "\n";
-                       texrow.newline();
-               }
-
                if (params.secnumdepth != tclass.secnumdepth()) {
                        ofs << "\\setcounter{secnumdepth}{"
                            << params.secnumdepth
@@ -2390,6 +2374,19 @@ void Buffer::makeLaTeXFile(string const & fname,
 
                ofs << preamble;
 
+               // We try to load babel late, in case it interferes
+               // with other packages.
+               if (use_babel) {
+                       string tmp = lyxrc.language_package;
+                       if (!lyxrc.language_global_options
+                           && tmp == "\\usepackage{babel}")
+                               tmp = string("\\usepackage[") +
+                                       language_options.str().c_str() +
+                                       "]{babel}";
+                       ofs << tmp << "\n";
+                       texrow.newline();
+               }
+
                // make the body.
                ofs << "\\begin{document}\n";
                texrow.newline();
@@ -2522,8 +2519,8 @@ void Buffer::sgmlOpenTag(ostream & os, Paragraph::depth_type depth,
                         string const & latexname) const
 {
        if (!latexname.empty() && latexname != "!-- --")
-               os << "<!-- " << depth << " -->" << "<" << latexname << ">";
-       //os << string(depth, ' ') << "<" << latexname << ">\n";
+               //os << "<!-- " << depth << " -->" << "<" << latexname << ">";
+               os << string(depth, ' ') << "<" << latexname << ">\n";
 }
 
 
@@ -2531,8 +2528,8 @@ void Buffer::sgmlCloseTag(ostream & os, Paragraph::depth_type depth,
                          string const & latexname) const
 {
        if (!latexname.empty() && latexname != "!-- --")
-               os << "<!-- " << depth << " -->" << "</" << latexname << ">\n";
-       //os << string(depth, ' ') << "</" << latexname << ">\n";
+               //os << "<!-- " << depth << " -->" << "</" << latexname << ">\n";
+               os << string(depth, ' ') << "</" << latexname << ">\n";
 }
 
 
@@ -2541,7 +2538,7 @@ void Buffer::makeLinuxDocFile(string const & fname, bool nice, bool body_only)
        ofstream ofs(fname.c_str());
 
        if (!ofs) {
-               WriteAlert(_("LYX_ERROR:"), _("Cannot write file"), fname);
+               Alert::alert(_("LYX_ERROR:"), _("Cannot write file"), fname);
                return;
        }
 
@@ -2558,14 +2555,16 @@ void Buffer::makeLinuxDocFile(string const & fname, bool nice, bool body_only)
        string top_element = textclasslist.LatexnameOfClass(params.textclass);
 
        if (!body_only) {
-               string sgml_includedfiles=features.getIncludedFiles(fname);
+               ofs << "<!doctype linuxdoc system";
 
-               if (params.preamble.empty() && sgml_includedfiles.empty()) {
-                       ofs << "<!doctype linuxdoc system>\n\n";
-               } else {
-                       ofs << "<!doctype linuxdoc system [ "
-                           << params.preamble << sgml_includedfiles << " \n]>\n\n";
+               string preamble = params.preamble;
+               preamble += features.getIncludedFiles(fname);
+               preamble += features.getLyXSGMLEntities();
+
+               if (!preamble.empty()) {
+                       ofs << " [ " << preamble << " ]";
                }
+               ofs << ">\n\n";
 
                if (params.options.empty())
                        sgmlOpenTag(ofs, 0, top_element);
@@ -2592,7 +2591,7 @@ void Buffer::makeLinuxDocFile(string const & fname, bool nice, bool body_only)
                                            par->layout);
 
                // treat <toc> as a special case for compatibility with old code
-               if (par->getChar(0) == Paragraph::META_INSET) {
+               if (par->isInset(0)) {
                        Inset * inset = par->getInset(0);
                        Inset::Code lyx_code = inset->lyxCode();
                        if (lyx_code == Inset::TOC_CODE){
@@ -2627,9 +2626,9 @@ void Buffer::makeLinuxDocFile(string const & fname, bool nice, bool body_only)
 
                case LATEX_COMMAND:
                        if (depth!= 0)
-                               linuxDocError(par, 0,
-                                             _("Error : Wrong depth for"
-                                               " LatexType Command.\n"));
+                               sgmlError(par, 0,
+                                         _("Error : Wrong depth for"
+                                           " LatexType Command.\n"));
 
                        if (!environment_stack[depth].empty()){
                                sgmlCloseTag(ofs, depth,
@@ -2715,35 +2714,11 @@ void Buffer::makeLinuxDocFile(string const & fname, bool nice, bool body_only)
 }
 
 
-void Buffer::docbookHandleCaption(ostream & os, string & inner_tag,
-                                 Paragraph::depth_type depth, int desc_on,
-                                 Paragraph * & par)
-{
-       Paragraph * tpar = par;
-       while (tpar
-              && (tpar->layout != textclasslist.NumberOfLayout(params.textclass,
-                                                               "Caption").second))
-               tpar = tpar->next();
-
-       if (tpar &&
-           tpar->layout == textclasslist.NumberOfLayout(params.textclass,
-                                                        "Caption").second) {
-               sgmlOpenTag(os, depth + 1, inner_tag);
-               string extra_par;
-               simpleDocBookOnePar(os, extra_par, tpar,
-                                   desc_on, depth + 2);
-               sgmlCloseTag(os, depth+1, inner_tag);
-               if (!extra_par.empty())
-                       os << extra_par;
-       }
-}
-
-
 // checks, if newcol chars should be put into this line
 // writes newline, if necessary.
 namespace {
 
-void linux_doc_line_break(ostream & os, string::size_type & colcount,
+void sgmlLineBreak(ostream & os, string::size_type & colcount,
                          string::size_type newcol)
 {
        colcount += newcol;
@@ -2794,8 +2769,6 @@ void reset(PAR_TAG & p1, PAR_TAG const & p2)
 } // namespace anon
 
 
-
-
 // Handle internal paragraph parsing -- layout already processed.
 void Buffer::simpleLinuxDocOnePar(ostream & os,
                                  Paragraph * par, 
@@ -2823,7 +2796,7 @@ void Buffer::simpleLinuxDocOnePar(ostream & os,
 
        stack<PAR_TAG> tag_state;
        // parsing main loop
-       for (Paragraph::size_type i = 0; i < par->size(); ++i) {
+       for (pos_type i = 0; i < par->size(); ++i) {
 
                PAR_TAG tag_close = NONE;
                list < PAR_TAG > tag_open;
@@ -2953,18 +2926,18 @@ void Buffer::simpleLinuxDocOnePar(ostream & os,
                        ++char_line_count;
                } else {
                        string sgml_string;
-                       if (par->linuxDocConvertChar(c, sgml_string)
+                       if (par->sgmlConvertChar(c, sgml_string)
                            && !style.free_spacing) { 
                                // in freespacing mode, spaces are
                                // non-breaking characters
                                if (desc_on) {// if char is ' ' then...
 
                                        ++char_line_count;
-                                       linux_doc_line_break(os, char_line_count, 6);
+                                       sgmlLineBreak(os, char_line_count, 6);
                                        os << "</tag>";
                                        desc_on = false;
                                } else  {
-                                       linux_doc_line_break(os, char_line_count, 1);
+                                       sgmlLineBreak(os, char_line_count, 1);
                                        os << c;
                                }
                        } else {
@@ -2983,19 +2956,20 @@ void Buffer::simpleLinuxDocOnePar(ostream & os,
        // resets description flag correctly
        if (desc_on) {
                // <tag> not closed...
-               linux_doc_line_break(os, char_line_count, 6);
+               sgmlLineBreak(os, char_line_count, 6);
                os << "</tag>";
        }
 }
 
 
 // Print an error message.
-void Buffer::linuxDocError(Paragraph * par, int pos,
-                          string const & message) 
+void Buffer::sgmlError(Paragraph * par, int pos,
+                      string const & message) const
 {
        // insert an error marker in text
        InsetError * new_inset = new InsetError(message);
        par->insertInset(pos, new_inset);
+       par->setFont(pos, LyXFont(LyXFont::ALL_INHERIT, params.language));
 }
 
 
@@ -3003,7 +2977,7 @@ void Buffer::makeDocBookFile(string const & fname, bool nice, bool only_body)
 {
        ofstream ofs(fname.c_str());
        if (!ofs) {
-               WriteAlert(_("LYX_ERROR:"), _("Cannot write file"), fname);
+               Alert::alert(_("LYX_ERROR:"), _("Cannot write file"), fname);
                return;
        }
 
@@ -3022,16 +2996,17 @@ void Buffer::makeDocBookFile(string const & fname, bool nice, bool only_body)
        string top_element = textclasslist.LatexnameOfClass(params.textclass);
 
        if (!only_body) {
-               string sgml_includedfiles = features.getIncludedFiles(fname);
+               ofs << "<!DOCTYPE " << top_element
+                   << "  PUBLIC \"-//OASIS//DTD DocBook V4.1//EN\"";
 
-               ofs << "<!doctype " << top_element
-                   << " public \"-//OASIS//DTD DocBook V3.1//EN\"";
+               string preamble = params.preamble;
+               preamble += features.getIncludedFiles(fname);
+               preamble += features.getLyXSGMLEntities();
 
-               if (params.preamble.empty() && sgml_includedfiles.empty())
-                       ofs << ">\n\n";
-               else
-                       ofs << "\n [ " << params.preamble 
-                           << sgml_includedfiles << " \n]>\n\n";
+               if (!preamble.empty()) {
+                       ofs << "\n [ " << preamble << " ]";
+               }
+               ofs << ">\n\n";
        }
 
        string top = top_element;       
@@ -3116,9 +3091,9 @@ void Buffer::makeDocBookFile(string const & fname, bool nice, bool only_body)
 
                case LATEX_COMMAND:
                        if (depth != 0)
-                               linuxDocError(par, 0,
-                                             _("Error : Wrong depth for "
-                                               "LatexType Command.\n"));
+                               sgmlError(par, 0,
+                                         _("Error : Wrong depth for "
+                                           "LatexType Command.\n"));
                        
                        command_name = style.latexname();
                        
@@ -3148,7 +3123,7 @@ void Buffer::makeDocBookFile(string const & fname, bool nice, bool only_body)
 
                        // treat label as a special case for
                        // more WYSIWYM handling.
-                       if (par->getChar(0) == Paragraph::META_INSET) {
+                       if (par->isInset(0)) {
                                Inset * inset = par->getInset(0);
                                Inset::Code lyx_code = inset->lyxCode();
                                if (lyx_code == Inset::LABEL_CODE){
@@ -3233,9 +3208,7 @@ void Buffer::makeDocBookFile(string const & fname, bool nice, bool only_body)
                        break;
                }
 
-               string extra_par;
-               simpleDocBookOnePar(ofs, extra_par, par, desc_on,
-                                   depth + 1 + command_depth);
+               simpleDocBookOnePar(ofs, par, desc_on, depth+1+command_depth);
                par = par->next();
 
                string end_tag;
@@ -3300,7 +3273,7 @@ void Buffer::makeDocBookFile(string const & fname, bool nice, bool only_body)
 }
 
 
-void Buffer::simpleDocBookOnePar(ostream & os, string & extra,
+void Buffer::simpleDocBookOnePar(ostream & os,
                                 Paragraph * par, int & desc_on,
                                 Paragraph::depth_type depth) const
 {
@@ -3316,8 +3289,7 @@ void Buffer::simpleDocBookOnePar(ostream & os, string & extra,
        //      os << string(depth,' ');
 
        // parsing main loop
-       for (Paragraph::size_type i = 0;
-            i < par->size(); ++i) {
+       for (pos_type i = 0; i < par->size(); ++i) {
                LyXFont font = par->getFont(params, i);
 
                // handle <emphasis> tag
@@ -3335,46 +3307,21 @@ void Buffer::simpleDocBookOnePar(ostream & os, string & extra,
 
                if (c == Paragraph::META_INSET) {
                        Inset * inset = par->getInset(i);
-                       ostringstream ost;
-                       inset->docbook(this, ost);
-                       string tmp_out = ost.str().c_str();
-
-                       //
-                       // This code needs some explanation:
-                       // Two insets are treated specially
-                       //   label if it is the first element in a command paragraph
-                       //         desc_on == 3
-                       //   graphics inside tables or figure floats can't go on
-                       //   title (the equivalente in latex for this case is caption
-                       //   and title should come first
-                       //         desc_on == 4
-                       //
-                       if (desc_on!= 3 || i!= 0) {
-                               if (!tmp_out.empty() && tmp_out[0] == '@') {
-                                       if (desc_on == 4)
-                                               extra += frontStrip(tmp_out, '@');
-                                       else
-                                               os << frontStrip(tmp_out, '@');
-                               }
-                               else
-                                       os << tmp_out;
-                       }
+                       inset->docbook(this, os);
                } else {
                        string sgml_string;
-                       if (par->linuxDocConvertChar(c, sgml_string)
-                           && !style.free_spacing) { // in freespacing
-                                                    // mode, spaces are
-                                                    // non-breaking characters
-                               // char is ' '
-                               if (desc_on == 1) {
-                                       ++char_line_count;
-                                       os << "\n</term><listitem><para>";
-                                       desc_on = 2;
-                               } else {
-                                       os << c;
-                               }
+                       par->sgmlConvertChar(c, sgml_string);
+
+                       if (style.pass_thru) {
+                               os << c;
+                       } else if(style.free_spacing || c != ' ') {
+                                       os << sgml_string;
+                       } else if (desc_on ==1) {
+                               ++char_line_count;
+                               os << "\n</term><listitem><para>";
+                               desc_on = 2;
                        } else {
-                               os << sgml_string;
+                               os << ' ';
                        }
                }
                font_old = font;
@@ -3425,7 +3372,7 @@ int Buffer::runChktex()
        int res = chktex.run(terr); // run chktex
 
        if (res == -1) {
-               WriteAlert(_("chktex did not work!"),
+               Alert::alert(_("chktex did not work!"),
                           _("Could not run with file:"), name);
        } else if (res > 0) {
                // Insert all errors as errors boxes
@@ -3451,8 +3398,8 @@ void Buffer::validate(LaTeXFeatures & features) const
                textclasslist.TextClass(params.textclass);
     
         // AMS Style is at document level
-        features.amsstyle = (params.use_amsmath ||
-                            tclass.provides(LyXTextClass::amsmath));
+        if (params.use_amsmath || tclass.provides(LyXTextClass::amsmath))
+               features.require("amsstyle");
     
        while (par) {
                // We don't use "lyxerr.debug" because of speed. (Asger)
@@ -3481,12 +3428,12 @@ void Buffer::validate(LaTeXFeatures & features) const
                                   || c == 25
                                   || c == 26
                                   || c == 31) {
-                                       features.latexsym = true;
+                                       features.require("latexsym");
                                }
                        } else if (font == 1) {
-                               features.amssymb = true;
+                               features.require("amssymb");
                        } else if ((font >= 2 && font <= 5)) {
-                               features.pifont = true;
+                               features.require("pifont");
                        }
                }
        }
@@ -3497,33 +3444,6 @@ void Buffer::validate(LaTeXFeatures & features) const
 }
 
 
-void Buffer::setPaperStuff()
-{
-       params.papersize = BufferParams::PAPER_DEFAULT;
-       char const c1 = params.paperpackage;
-       if (c1 == BufferParams::PACKAGE_NONE) {
-               char const c2 = params.papersize2;
-               if (c2 == BufferParams::VM_PAPER_USLETTER)
-                       params.papersize = BufferParams::PAPER_USLETTER;
-               else if (c2 == BufferParams::VM_PAPER_USLEGAL)
-                       params.papersize = BufferParams::PAPER_LEGALPAPER;
-               else if (c2 == BufferParams::VM_PAPER_USEXECUTIVE)
-                       params.papersize = BufferParams::PAPER_EXECUTIVEPAPER;
-               else if (c2 == BufferParams::VM_PAPER_A3)
-                       params.papersize = BufferParams::PAPER_A3PAPER;
-               else if (c2 == BufferParams::VM_PAPER_A4)
-                       params.papersize = BufferParams::PAPER_A4PAPER;
-               else if (c2 == BufferParams::VM_PAPER_A5)
-                       params.papersize = BufferParams::PAPER_A5PAPER;
-               else if ((c2 == BufferParams::VM_PAPER_B3) || (c2 == BufferParams::VM_PAPER_B4) ||
-                        (c2 == BufferParams::VM_PAPER_B5))
-                       params.papersize = BufferParams::PAPER_B5PAPER;
-       } else if ((c1 == BufferParams::PACKAGE_A4) || (c1 == BufferParams::PACKAGE_A4WIDE) ||
-                  (c1 == BufferParams::PACKAGE_WIDEMARGINSA4))
-               params.papersize = BufferParams::PAPER_A4PAPER;
-}
-
-
 // This function should be in Buffer because it's a buffer's property (ale)
 string const Buffer::getIncludeonlyList(char delim)
 {
@@ -3778,8 +3698,7 @@ bool Buffer::isMultiLingual()
 }
 
 
-Buffer::inset_iterator::inset_iterator(Paragraph * paragraph,
-                                      Paragraph::size_type pos)
+Buffer::inset_iterator::inset_iterator(Paragraph * paragraph, pos_type pos)
        : par(paragraph)
 {
        it = par->InsetIterator(pos);