Updates from Bennett and myself.

[lyx.git] / src / buffer.C

diff --git a/src/buffer.C b/src/buffer.C
index ffd9fa74c0b8118386705c0802a5978ddd6ab8c3..992d61a846c9c464313472fc06a10b4b8b403b53 100644 (file)
--- a/src/buffer.C
+++ b/src/buffer.C
@@ -101,6 +101,7 @@ using support::changeExtension;
 using support::cmd_ret;
 using support::createBufferTmpDir;
 using support::destroyDir;
+using support::FileName;
 using support::getFormatFromContents;
 using support::isDirWriteable;
 using support::libFileSearch;
@@ -143,7 +144,7 @@ using std::string;
 
 namespace {
 
-int const LYX_FORMAT = 253;
+int const LYX_FORMAT = 255;
 
 } // namespace anon
 
@@ -460,7 +461,7 @@ int Buffer::readHeader(LyXLex & lex)
                                docstring const s = bformat(_("Unknown token: "
                                                                        "%1$s %2$s\n"),
                                                         from_utf8(token),
-                                                        from_utf8(lex.getString()));
+                                                        lex.getDocString());
                                errorList.push_back(ErrorItem(_("Document header error"),
                                        s, -1, 0, 0));
                        }
@@ -554,11 +555,9 @@ void Buffer::insertStringAsLines(ParagraphList & pars,
                                }
                                space_inserted = true;
                        }
-/* FIXME: not needed anymore?
                } else if (!isPrintable(*cit)) {
                        // Ignore unprintables
                        continue;
-*/
                } else {
                        // just insert the character
                        par.insertChar(pos, *cit, font, params().trackChanges);
@@ -573,7 +572,8 @@ void Buffer::insertStringAsLines(ParagraphList & pars,
 bool Buffer::readFile(string const & filename)
 {
        // Check if the file is compressed.
-       string const format = getFormatFromContents(filename);
+       FileName const name(makeAbsPath(filename));
+       string const format = getFormatFromContents(name);
        if (format == "gzip" || format == "zip" || format == "compress") {
                params().compressed = true;
        }
@@ -581,7 +581,7 @@ bool Buffer::readFile(string const & filename)
        // remove dummy empty par
        paragraphs().clear();
        LyXLex lex(0, 0);
-       lex.setFile(filename);
+       lex.setFile(name);
        if (!readFile(lex, filename))
                return false;
 
@@ -657,7 +657,7 @@ bool Buffer::readFile(LyXLex & lex, string const & filename)
                                              from_utf8(filename)));
                        return false;
                }
-               string const lyx2lyx = libFileSearch("lyx2lyx", "lyx2lyx");
+               FileName const lyx2lyx = libFileSearch("lyx2lyx", "lyx2lyx");
                if (lyx2lyx.empty()) {
                        Alert::error(_("Conversion script not found"),
                                     bformat(_("%1$s is from an earlier"
@@ -668,7 +668,7 @@ bool Buffer::readFile(LyXLex & lex, string const & filename)
                        return false;
                }
                ostringstream command;
-               command << os::python() << ' ' << quoteName(lyx2lyx)
+               command << os::python() << ' ' << quoteName(lyx2lyx.toFilesystemEncoding())
                        << " -t " << convert<string>(LYX_FORMAT)
                        << " -o " << quoteName(tmpfile) << ' '
                        << quoteName(filename);
@@ -747,7 +747,7 @@ bool Buffer::save() const
        } else {
                // Saving failed, so backup is not backup
                if (lyxrc.make_backup)
-                       rename(s, fileName());
+                       rename(FileName(s), FileName(fileName()));
                return false;
        }
        return true;
@@ -1164,9 +1164,11 @@ void Buffer::validate(LaTeXFeatures & features) const
                features.require("dvipost");
 
        // AMS Style is at document level
-       if (params().use_amsmath == BufferParams::AMS_ON
+       if (params().use_amsmath == BufferParams::package_on
            || tclass.provides(LyXTextClass::amsmath))
                features.require("amsmath");
+       if (params().use_esint == BufferParams::package_on)
+               features.require("esint");
 
        for_each(paragraphs().begin(), paragraphs().end(),
                 boost::bind(&Paragraph::validate, _1, boost::ref(features)));
@@ -1451,7 +1453,7 @@ docstring const Buffer::translateLabel(docstring const & label) const
                // Probably standard layout, try to translate
                return B_(to_ascii(label));
        else
-               // This must be a user defined layout. We can not translate
+               // This must be a user defined layout. We cannot translate
                // this, since gettext accepts only ascii keys.
                return label;
 }
@@ -1639,7 +1641,6 @@ void Buffer::changeRefsIfUnique(docstring const & from, docstring const & to,
        } else
                getLabelList(labels);
 
-       // FIXME UNICODE
        if (lyx::count(labels.begin(), labels.end(), from) > 1)
                return;