]> git.lyx.org Git - lyx.git/blobdiff - src/buffer.C
use is_writable to check if the copy_file will work
[lyx.git] / src / buffer.C
index 00fe5ef600b56d0424a3e73fbe4848381a77d599..90cc72c46fc8a4b0bfbaa43ec0b35201850b1400 100644 (file)
@@ -13,6 +13,7 @@
 #include "buffer.h"
 
 #include "author.h"
+#include "BranchList.h"
 #include "buffer_funcs.h"
 #include "bufferlist.h"
 #include "bufferparams.h"
 
 #include "graphics/Previews.h"
 
-#include "support/FileInfo.h"
 #include "support/filetools.h"
-#include "support/gzstream.h"
+#include "support/fs_extras.h"
+#ifdef USE_COMPRESSION
+# include "support/gzstream.h"
+#endif
 #include "support/lyxlib.h"
 #include "support/os.h"
 #include "support/path.h"
 #include "support/textutils.h"
-#include "support/tostr.h"
+#include "support/convert.h"
 
 #include <boost/bind.hpp>
+#include <boost/filesystem/operations.hpp>
 
-#include <utime.h>
+#if defined (HAVE_UTIME_H)
+# include <utime.h>
+#elif defined (HAVE_SYS_UTIME_H)
+# include <sys/utime.h>
+#endif
 
 #include <iomanip>
 #include <stack>
 #include <sstream>
+#include <fstream>
 
 
 using lyx::pos_type;
-using lyx::par_type;
+using lyx::pit_type;
 
 using lyx::support::AddName;
-using lyx::support::atoi;
 using lyx::support::bformat;
 using lyx::support::ChangeExtension;
 using lyx::support::cmd_ret;
 using lyx::support::createBufferTmpDir;
 using lyx::support::destroyDir;
-using lyx::support::FileInfo;
-using lyx::support::FileInfo;
-using lyx::support::getExtFromContents;
+using lyx::support::getFormatFromContents;
 using lyx::support::IsDirWriteable;
-using lyx::support::IsFileWriteable;
 using lyx::support::LibFileSearch;
+using lyx::support::latex_path;
 using lyx::support::ltrim;
 using lyx::support::MakeAbsPath;
 using lyx::support::MakeDisplayPath;
@@ -109,12 +115,12 @@ using lyx::support::removeAutosaveFile;
 using lyx::support::rename;
 using lyx::support::RunCommand;
 using lyx::support::split;
-using lyx::support::strToInt;
 using lyx::support::subst;
 using lyx::support::tempName;
 using lyx::support::trim;
 
 namespace os = lyx::support::os;
+namespace fs = boost::filesystem;
 
 using std::endl;
 using std::for_each;
@@ -137,15 +143,16 @@ extern BufferList bufferlist;
 
 namespace {
 
-const int LYX_FORMAT = 237;
+int const LYX_FORMAT = 241;
 
 } // namespace anon
 
 
 typedef std::map<string, bool> DepClean;
 
-struct Buffer::Impl
+class Buffer::Impl
 {
+public:
        Impl(Buffer & parent, string const & file, bool readonly);
 
        limited_stack<Undo> undostack;
@@ -197,6 +204,7 @@ Buffer::Impl::Impl(Buffer & parent, string const & file, bool readonly_)
          filename(file), filepath(OnlyPath(file)), file_fully_loaded(false),
                inset(params)
 {
+       inset.setAutoBreakRows(true);
        lyxvc.buffer(&parent);
        temppath = createBufferTmpDir();
        // FIXME: And now do something if temppath == string(), because we
@@ -220,7 +228,7 @@ Buffer::~Buffer()
 
        closing();
 
-       if (!temppath().empty() && destroyDir(temppath()) != 0) {
+       if (!temppath().empty() && !destroyDir(temppath())) {
                Alert::warning(_("Could not remove temporary directory"),
                        bformat(_("Could not remove the temporary directory %1$s"), temppath()));
        }
@@ -320,7 +328,7 @@ TexRow const & Buffer::texrow() const
 }
 
 
-string const Buffer::getLatexName(bool no_path) const
+string const Buffer::getLatexName(bool const no_path) const
 {
        string const name = ChangeExtension(MakeLatexName(fileName()), ".tex");
        return no_path ? OnlyFilename(name) : name;
@@ -346,11 +354,8 @@ pair<Buffer::LogType, string> const Buffer::getLogName() const
 
        // If no Latex log or Build log is newer, show Build log
 
-       FileInfo const f_fi(fname);
-       FileInfo const b_fi(bname);
-
-       if (b_fi.exist() &&
-           (!f_fi.exist() || f_fi.getModificationTime() < b_fi.getModificationTime())) {
+       if (fs::exists(bname) &&
+           (!fs::exists(fname) || fs::last_write_time(fname) < fs::last_write_time(bname))) {
                lyxerr[Debug::FILES] << "Log name calculated as: " << bname << endl;
                return make_pair(Buffer::buildlog, bname);
        }
@@ -359,7 +364,7 @@ pair<Buffer::LogType, string> const Buffer::getLogName() const
 }
 
 
-void Buffer::setReadonly(bool flag)
+void Buffer::setReadonly(bool const flag)
 {
        if (pimpl_->read_only != flag) {
                pimpl_->read_only = flag;
@@ -372,7 +377,7 @@ void Buffer::setFileName(string const & newfile)
 {
        pimpl_->filename = MakeAbsPath(newfile);
        pimpl_->filepath = OnlyPath(pimpl_->filename);
-       setReadonly(IsFileWriteable(pimpl_->filename) == 0);
+       setReadonly(fs::is_readonly(pimpl_->filename));
        updateTitles();
 }
 
@@ -396,6 +401,20 @@ int Buffer::readHeader(LyXLex & lex)
        int line = -1;
        int begin_header_line = -1;
 
+       // Initialize parameters that may be/go lacking in header:
+       params().branchlist().clear();
+       params().options.erase();
+       params().float_placement.erase();
+       params().paperwidth.erase();
+       params().paperheight.erase();
+       params().leftmargin.erase();
+       params().rightmargin.erase();
+       params().topmargin.erase();
+       params().bottommargin.erase();
+       params().headheight.erase();
+       params().headsep.erase();
+       params().footskip.erase();
+
        while (lex.isOK()) {
                lex.next();
                string const token = lex.getString();
@@ -417,7 +436,7 @@ int Buffer::readHeader(LyXLex & lex)
 
                string unknown = params().readToken(lex, token);
                if (!unknown.empty()) {
-                       if (unknown[0] != '\\' and token == "\\textclass") {
+                       if (unknown[0] != '\\' && token == "\\textclass") {
                                unknownClass(unknown);
                        } else {
                                ++unknown_tokens;
@@ -474,24 +493,22 @@ bool Buffer::readDocument(LyXLex & lex)
 
 // needed to insert the selection
 void Buffer::insertStringAsLines(ParagraphList & pars,
-       par_type & par, pos_type & pos,
-       LyXFont const & fn, string const & str)
+       pit_type & pit, pos_type & pos,
+       LyXFont const & fn, string const & str, bool autobreakrows)
 {
-       LyXLayout_ptr const & layout = pars[par].layout();
-
        LyXFont font = fn;
 
-       pars[par].checkInsertChar(font);
+       pars[pit].checkInsertChar(font);
        // insert the string, don't insert doublespace
        bool space_inserted = true;
-       bool autobreakrows = pars[par].autoBreakRows();
        for (string::const_iterator cit = str.begin();
            cit != str.end(); ++cit) {
+               Paragraph & par = pars[pit];
                if (*cit == '\n') {
-                       if (autobreakrows && (!pars[par].empty() || pars[par].allowEmpty())) {
-                               breakParagraph(params(), paragraphs(), par, pos,
-                                              layout->isEnvironment());
-                               ++par;
+                       if (autobreakrows && (!par.empty() || par.allowEmpty())) {
+                               breakParagraph(params(), pars, pit, pos,
+                                              par.layout()->isEnvironment());
+                               ++pit;
                                pos = 0;
                                space_inserted = true;
                        } else {
@@ -499,18 +516,18 @@ void Buffer::insertStringAsLines(ParagraphList & pars,
                        }
                        // do not insert consecutive spaces if !free_spacing
                } else if ((*cit == ' ' || *cit == '\t') &&
-                          space_inserted && !pars[par].isFreeSpacing()) {
+                          space_inserted && !par.isFreeSpacing()) {
                        continue;
                } else if (*cit == '\t') {
-                       if (!pars[par].isFreeSpacing()) {
+                       if (!par.isFreeSpacing()) {
                                // tabs are like spaces here
-                               pars[par].insertChar(pos, ' ', font);
+                               par.insertChar(pos, ' ', font);
                                ++pos;
                                space_inserted = true;
                        } else {
                                const pos_type n = 8 - pos % 8;
                                for (pos_type i = 0; i < n; ++i) {
-                                       pars[par].insertChar(pos, ' ', font);
+                                       par.insertChar(pos, ' ', font);
                                        ++pos;
                                }
                                space_inserted = true;
@@ -520,7 +537,7 @@ void Buffer::insertStringAsLines(ParagraphList & pars,
                        continue;
                } else {
                        // just insert the character
-                       pars[par].insertChar(pos, *cit, font);
+                       par.insertChar(pos, *cit, font);
                        ++pos;
                        space_inserted = (*cit == ' ');
                }
@@ -532,7 +549,7 @@ void Buffer::insertStringAsLines(ParagraphList & pars,
 bool Buffer::readFile(string const & filename)
 {
        // Check if the file is compressed.
-       string const format = getExtFromContents(filename);
+       string const format = getFormatFromContents(filename);
        if (format == "gzip" || format == "zip" || format == "compress") {
                params().compressed = true;
        }
@@ -550,7 +567,7 @@ bool Buffer::readFile(string const & filename)
 }
 
 
-bool Buffer::readFile(string const & filename, par_type pit)
+bool Buffer::readFile(string const & filename, pit_type const pit)
 {
        LyXLex lex(0, 0);
        lex.setFile(filename);
@@ -564,13 +581,13 @@ bool Buffer::fully_loaded() const
 }
 
 
-void Buffer::fully_loaded(bool value)
+void Buffer::fully_loaded(bool const value)
 {
        pimpl_->file_fully_loaded = value;
 }
 
 
-bool Buffer::readFile(LyXLex & lex, string const & filename, par_type pit)
+bool Buffer::readFile(LyXLex & lex, string const & filename, pit_type const pit)
 {
        BOOST_ASSERT(!filename.empty());
 
@@ -607,7 +624,7 @@ bool Buffer::readFile(LyXLex & lex, string const & filename, par_type pit)
        //lyxerr << "           dot found at " << dot << endl;
        if (dot != string::npos)
                        tmp_format.erase(dot, 1);
-       int file_format = strToInt(tmp_format);
+       int const file_format = convert<int>(tmp_format);
        //lyxerr << "format: " << file_format << endl;
 
        if (file_format != LYX_FORMAT) {
@@ -621,7 +638,8 @@ bool Buffer::readFile(LyXLex & lex, string const & filename, par_type pit)
                                              filename));
                        return false;
                }
-               string command = LibFileSearch("lyx2lyx", "lyx2lyx");
+               string command =
+                       "python " + LibFileSearch("lyx2lyx", "lyx2lyx");
                if (command.empty()) {
                        Alert::error(_("Conversion script not found"),
                                     bformat(_("%1$s is from an earlier"
@@ -632,7 +650,7 @@ bool Buffer::readFile(LyXLex & lex, string const & filename, par_type pit)
                        return false;
                }
                command += " -t"
-                       + tostr(LYX_FORMAT)
+                       + convert<string>(LYX_FORMAT)
                        + " -o " + tmpfile + ' '
                        + QuoteName(filename);
                lyxerr[Debug::INFO] << "Running '"
@@ -647,7 +665,7 @@ bool Buffer::readFile(LyXLex & lex, string const & filename, par_type pit)
                                              filename));
                        return false;
                } else {
-                       bool ret = readFile(tmpfile, pit);
+                       bool const ret = readFile(tmpfile, pit);
                        // Do stuff with tmpfile name and buffer name here.
                        return ret;
                }
@@ -683,53 +701,20 @@ bool Buffer::save() const
                s = fileName() + '~';
                if (!lyxrc.backupdir_path.empty())
                        s = AddName(lyxrc.backupdir_path,
-                                   subst(os::slashify_path(s),'/','!'));
-
-               // Rename is the wrong way of making a backup,
-               // this is the correct way.
-               /* truss cp fil fil2:
-                  lstat("LyXVC3.lyx", 0xEFFFF898)                 Err#2 ENOENT
-                  stat("LyXVC.lyx", 0xEFFFF688)                   = 0
-                  open("LyXVC.lyx", O_RDONLY)                     = 3
-                  open("LyXVC3.lyx", O_WRONLY|O_CREAT|O_TRUNC, 0600) = 4
-                  fstat(4, 0xEFFFF508)                            = 0
-                  fstat(3, 0xEFFFF508)                            = 0
-                  read(3, " # T h i s   f i l e   w".., 8192)     = 5579
-                  write(4, " # T h i s   f i l e   w".., 5579)    = 5579
-                  read(3, 0xEFFFD4A0, 8192)                       = 0
-                  close(4)                                        = 0
-                  close(3)                                        = 0
-                  chmod("LyXVC3.lyx", 0100644)                    = 0
-                  lseek(0, 0, SEEK_CUR)                           = 46440
-                  _exit(0)
-               */
-
-               // Should probably have some more error checking here.
-               // Doing it this way, also makes the inodes stay the same.
-               // This is still not a very good solution, in particular we
-               // might loose the owner of the backup.
-               FileInfo finfo(fileName());
-               if (finfo.exist()) {
-                       mode_t fmode = finfo.getMode();
-                       struct utimbuf times = {
-                               finfo.getAccessTime(),
-                               finfo.getModificationTime() };
-
-                       ifstream ifs(fileName().c_str());
-                       ofstream ofs(s.c_str(), ios::out|ios::trunc);
-                       if (ifs && ofs) {
-                               ofs << ifs.rdbuf();
-                               ifs.close();
-                               ofs.close();
-                               ::chmod(s.c_str(), fmode);
-
-                               if (::utime(s.c_str(), &times)) {
-                                       lyxerr << "utime error." << endl;
-                               }
-                       } else {
-                               lyxerr << "LyX was not able to make "
-                                       "backup copy. Beware." << endl;
-                       }
+                                   subst(os::internal_path(s),'/','!'));
+
+               // It might very well be that this variant is just
+               // good enough. (Lgb)
+               // But to use this we need fs::copy_file to actually do a copy,
+               // even when the target file exists. (Lgb)
+               if (fs::exists(fileName()) && fs::is_writable(fs::path(fileName()).branch_path())) {
+                 //try {
+                   fs::copy_file(fileName(), s, false);
+                   //}
+                   //catch (fs::filesystem_error const & fe) {
+                   //lyxerr << "LyX was not able to make backup copy. Beware.\n"
+                   //     << fe.what() << endl;
+                   //}
                }
        }
 
@@ -751,21 +736,20 @@ bool Buffer::writeFile(string const & fname) const
        if (pimpl_->read_only && fname == fileName())
                return false;
 
-       FileInfo finfo(fname);
-       if (finfo.exist() && !finfo.writable())
-               return false;
-
        bool retval = false;
 
        if (params().compressed) {
-               gz::ogzstream ofs(fname.c_str());
+#ifdef USE_COMPRESSION
+               gz::ogzstream ofs(fname.c_str(), ios::out|ios::trunc);
                if (!ofs)
                        return false;
 
                retval = do_writeFile(ofs);
-
+#else
+               return false;
+#endif
        } else {
-               ofstream ofs(fname.c_str());
+               ofstream ofs(fname.c_str(), ios::out|ios::trunc);
                if (!ofs)
                        return false;
 
@@ -848,7 +832,7 @@ void Buffer::makeLaTeXFile(string const & fname,
 void Buffer::makeLaTeXFile(ostream & os,
                           string const & original_path,
                           OutputParams const & runparams_in,
-                          bool output_preamble, bool output_body)
+                          bool const output_preamble, bool const output_body)
 {
        OutputParams runparams = runparams_in;
 
@@ -891,8 +875,7 @@ void Buffer::makeLaTeXFile(ostream & os,
                        texrow().newline();
                }
                if (!original_path.empty()) {
-                       string inputpath = os::external_path(original_path);
-                       subst(inputpath, "~", "\\string~");
+                       string const inputpath = latex_path(original_path);
                        os << "\\makeatletter\n"
                            << "\\def\\input@path{{"
                            << inputpath << "/}}\n"
@@ -1002,7 +985,7 @@ bool Buffer::isSGML() const
 
 void Buffer::makeLinuxDocFile(string const & fname,
                              OutputParams const & runparams,
-                             bool body_only)
+                             bool const body_only)
 {
        ofstream ofs;
        if (!openFileWrite(ofs, fname))
@@ -1015,7 +998,7 @@ void Buffer::makeLinuxDocFile(string const & fname,
 
        LyXTextClass const & tclass = params().getLyXTextClass();
 
-       string top_element = tclass.latexname();
+       string const & top_element = tclass.latexname();
 
        if (!body_only) {
                ofs << tclass.class_header();
@@ -1032,12 +1015,12 @@ void Buffer::makeLinuxDocFile(string const & fname,
                ofs << ">\n\n";
 
                if (params().options.empty())
-                       sgml::openTag(ofs, 0, false, top_element);
+                       sgml::openTag(ofs, top_element);
                else {
                        string top = top_element;
                        top += ' ';
                        top += params().options;
-                       sgml::openTag(ofs, 0, false, top);
+                       sgml::openTag(ofs, top);
                }
        }
 
@@ -1049,7 +1032,7 @@ void Buffer::makeLinuxDocFile(string const & fname,
 
        if (!body_only) {
                ofs << "\n\n";
-               sgml::closeTag(ofs, 0, false, top_element);
+               sgml::closeTag(ofs, top_element);
        }
 
        ofs.close();
@@ -1060,7 +1043,7 @@ void Buffer::makeLinuxDocFile(string const & fname,
 
 void Buffer::makeDocBookFile(string const & fname,
                             OutputParams const & runparams,
-                            bool only_body)
+                            bool const only_body)
 {
        ofstream ofs;
        if (!openFileWrite(ofs, fname))
@@ -1072,7 +1055,7 @@ void Buffer::makeDocBookFile(string const & fname,
        texrow().reset();
 
        LyXTextClass const & tclass = params().getLyXTextClass();
-       string top_element = tclass.latexname();
+       string const & top_element = tclass.latexname();
 
        if (!only_body) {
                if (runparams.flavor == OutputParams::XML)
@@ -1089,6 +1072,13 @@ void Buffer::makeDocBookFile(string const & fname,
                        ofs << " PUBLIC \"-//OASIS//DTD DocBook V4.2//EN\"";
 
                string preamble = params().preamble;
+               if (runparams.flavor != OutputParams::XML ) {
+                       preamble += "<!ENTITY % output.print.png \"IGNORE\">\n";
+                       preamble += "<!ENTITY % output.print.pdf \"IGNORE\">\n";
+                       preamble += "<!ENTITY % output.print.eps \"IGNORE\">\n";
+                       preamble += "<!ENTITY % output.print.bmp \"IGNORE\">\n";
+               }
+
                string const name = runparams.nice ? ChangeExtension(pimpl_->filename, ".sgml")
                         : fname;
                preamble += features.getIncludedFiles(name);
@@ -1112,17 +1102,17 @@ void Buffer::makeDocBookFile(string const & fname,
                top += ' ';
                top += params().options;
        }
-       sgml::openTag(ofs, 0, false, top);
 
        ofs << "<!-- " << ((runparams.flavor == OutputParams::XML)? "XML" : "SGML")
            << " file was created by LyX " << lyx_version
            << "\n  See http://www.lyx.org/ for more information -->\n";
 
        params().getLyXTextClass().counters().reset();
-       docbookParagraphs(*this, paragraphs(), ofs, runparams);
 
-       ofs << "\n\n";
-       sgml::closeTag(ofs, 0, false, top_element);
+       sgml::openTag(ofs, top);
+       ofs << '\n';
+       docbookParagraphs(paragraphs(), *this, ofs, runparams);
+       sgml::closeTag(ofs, top_element);
 
        ofs.close();
        if (ofs.fail())
@@ -1152,7 +1142,7 @@ int Buffer::runChktex()
 
        TeXErrors terr;
        Chktex chktex(lyxrc.chktex_command, name, filePath());
-       int res = chktex.run(terr); // run chktex
+       int const res = chktex.run(terr); // run chktex
 
        if (res == -1) {
                Alert::error(_("chktex failure"),
@@ -1172,7 +1162,8 @@ void Buffer::validate(LaTeXFeatures & features) const
 {
        LyXTextClass const & tclass = params().getLyXTextClass();
 
-       if (params().tracking_changes) {
+       if (features.isAvailable("dvipost") && params().tracking_changes
+               && params().output_changes) {
                features.require("dvipost");
                features.require("color");
        }
@@ -1215,7 +1206,7 @@ void Buffer::validate(LaTeXFeatures & features) const
 }
 
 
-void Buffer::getLabelList(std::vector<string> & list) const
+void Buffer::getLabelList(vector<string> & list) const
 {
        /// if this is a child document and the parent is already loaded
        /// Use the parent's list instead  [ale990407]
@@ -1235,7 +1226,7 @@ void Buffer::getLabelList(std::vector<string> & list) const
 
 
 // This is also a buffer property (ale)
-void Buffer::fillWithBibKeys(std::vector<std::pair<string, string> > & keys)
+void Buffer::fillWithBibKeys(vector<pair<string, string> > & keys)
        const
 {
        /// if this is a child document and the parent is already loaded
@@ -1248,15 +1239,15 @@ void Buffer::fillWithBibKeys(std::vector<std::pair<string, string> > & keys)
        }
 
        for (InsetIterator it = inset_iterator_begin(inset()); it; ++it) {
-               if (it->lyxCode() == InsetOld::BIBTEX_CODE) {
+               if (it->lyxCode() == InsetBase::BIBTEX_CODE) {
                        InsetBibtex const & inset =
                                dynamic_cast<InsetBibtex const &>(*it);
                        inset.fillWithBibKeys(*this, keys);
-               } else if (it->lyxCode() == InsetOld::INCLUDE_CODE) {
+               } else if (it->lyxCode() == InsetBase::INCLUDE_CODE) {
                        InsetInclude const & inset =
                                dynamic_cast<InsetInclude const &>(*it);
                        inset.fillWithBibKeys(*this, keys);
-               } else if (it->lyxCode() == InsetOld::BIBITEM_CODE) {
+               } else if (it->lyxCode() == InsetBase::BIBITEM_CODE) {
                        InsetBibitem const & inset =
                                dynamic_cast<InsetBibitem const &>(*it);
                        string const key = inset.getContents();
@@ -1271,7 +1262,7 @@ void Buffer::fillWithBibKeys(std::vector<std::pair<string, string> > & keys)
 
 bool Buffer::isDepClean(string const & name) const
 {
-       DepClean::const_iterator it = pimpl_->dep_clean.find(name);
+       DepClean::const_iterator const it = pimpl_->dep_clean.find(name);
        if (it == pimpl_->dep_clean.end())
                return true;
        return it->second;
@@ -1311,19 +1302,24 @@ bool Buffer::dispatch(FuncRequest const & func, bool * result)
 
 void Buffer::changeLanguage(Language const * from, Language const * to)
 {
+       BOOST_ASSERT(from);
+       BOOST_ASSERT(to);
+
        lyxerr << "Changing Language!" << endl;
 
        // Take care of l10n/i18n
        updateDocLang(to);
 
-       ParIterator end = par_iterator_end();
-       for (ParIterator it = par_iterator_begin(); it != end; ++it)
-               it->changeLanguage(params(), from, to);
+       for_each(par_iterator_begin(),
+                par_iterator_end(),
+                bind(&Paragraph::changeLanguage, _1, params(), from, to));
 }
 
 
 void Buffer::updateDocLang(Language const * nlang)
 {
+       BOOST_ASSERT(nlang);
+
        pimpl_->messages.reset(new Messages(nlang->code()));
 }
 
@@ -1339,10 +1335,10 @@ bool Buffer::isMultiLingual() const
 }
 
 
-ParIterator Buffer::getParFromID(int id) const
+ParIterator Buffer::getParFromID(int const id) const
 {
        ParConstIterator it = par_iterator_begin();
-       ParConstIterator end = par_iterator_end();
+       ParConstIterator const end = par_iterator_end();
 
        if (id < 0) {
                // John says this is called with id == -1 from undo
@@ -1358,22 +1354,10 @@ ParIterator Buffer::getParFromID(int id) const
 }
 
 
-bool Buffer::hasParWithID(int id) const
+bool Buffer::hasParWithID(int const id) const
 {
-       ParConstIterator it = par_iterator_begin();
-       ParConstIterator end = par_iterator_end();
-
-       if (id < 0) {
-               // John says this is called with id == -1 from undo
-               lyxerr << "hasParWithID(), id: " << id << endl;
-               return 0;
-       }
-
-       for (; it != end; ++it)
-               if (it->id() == id)
-                       return true;
-
-       return false;
+       ParConstIterator const it = getParFromID(id);
+       return it != par_iterator_end();
 }
 
 
@@ -1459,6 +1443,9 @@ bool Buffer::isUnnamed() const
 }
 
 
+#ifdef WITH_WARNINGS
+#warning this function should be moved to buffer_pimpl.C
+#endif
 void Buffer::markDirty()
 {
        if (pimpl_->lyx_clean) {