* This file is part of LyX, the document processor.
* Licence details can be found in the file COPYING.
*
- * \author Lars Gullik Bjønnes
+ * \author Lars Gullik Bjønnes
*
* Full author contact details are available in file CREDITS.
*/
namespace lyx {
-int VCS::doVCCommand(string const & cmd, FileName const & path)
-{
- LYXERR(Debug::LYXVC, "doVCCommand: " << cmd);
+int VCS::doVCCommandCall(string const & cmd, FileName const & path){
+ LYXERR(Debug::LYXVC, "doVCCommandCall: " << cmd);
Systemcall one;
support::PathChanger p(path);
- int const ret = one.startscript(Systemcall::Wait, cmd);
+ return one.startscript(Systemcall::Wait, cmd);
+}
+
+int VCS::doVCCommand(string const & cmd, FileName const & path)
+{
+ if (owner_)
+ owner_->setBusy(true);
+
+ int const ret = doVCCommandCall(cmd, path);
+
+ if (owner_)
+ owner_->setBusy(false);
if (ret)
frontend::Alert::error(_("Revision control error."),
bformat(_("Some problem occured while running the command:\n"
"'%1$s'."),
- from_ascii(cmd)));
+ from_utf8(cmd)));
return ret;
}
FileName tmp(file.absFilename() + ",v");
LYXERR(Debug::LYXVC, "LyXVC: Checking if file is under rcs: " << tmp);
if (tmp.isReadableFile()) {
- LYXERR(Debug::LYXVC, "Yes " << file << " is under rcs.");
+ LYXERR(Debug::LYXVC, "Yes, " << file << " is under rcs.");
return tmp;
}
tmp = FileName(addName(addPath(onlyPath(file.absFilename()), "RCS"), file.absFilename()) + ",v");
LYXERR(Debug::LYXVC, "LyXVC: Checking if file is under rcs: " << tmp);
if (tmp.isReadableFile()) {
- LYXERR(Debug::LYXVC, "Yes " << file << " it is under rcs.");
+ LYXERR(Debug::LYXVC, "Yes, " << file << " is under rcs.");
return tmp;
}
void RCS::retrieve(FileName const & file)
{
LYXERR(Debug::LYXVC, "LyXVC::RCS: retrieve.\n\t" << file);
- VCS::doVCCommand("co -q -r " + quoteName(file.toFilesystemEncoding()),
+ doVCCommandCall("co -q -r " + quoteName(file.toFilesystemEncoding()),
FileName());
}
void RCS::scanMaster()
{
- LYXERR(Debug::LYXVC, "LyXVC::RCS: scanMaster.");
+ if (master_.empty())
+ return;
+
+ LYXERR(Debug::LYXVC, "LyXVC::RCS: scanMaster: " << master_);
ifstream ifs(master_.toFilesystemEncoding().c_str());
}
-void RCS::checkIn(string const & msg)
+string RCS::checkIn(string const & msg)
{
- doVCCommand("ci -q -u -m\"" + msg + "\" "
+ int ret = doVCCommand("ci -q -u -m\"" + msg + "\" "
+ quoteName(onlyFilename(owner_->absFileName())),
FileName(owner_->filePath()));
+ return ret ? string() : "RCS: Proceeded";
}
bool RCS::checkInEnabled()
return owner_ && !owner_->isReadonly();
}
-void RCS::checkOut()
+string RCS::checkOut()
{
owner_->markClean();
- doVCCommand("co -q -l " + quoteName(onlyFilename(owner_->absFileName())),
+ int ret = doVCCommand("co -q -l " + quoteName(onlyFilename(owner_->absFileName())),
FileName(owner_->filePath()));
+ return ret ? string() : "RCS: Proceeded";
}
void RCS::getLog(FileName const & tmpf)
{
doVCCommand("rlog " + quoteName(onlyFilename(owner_->absFileName()))
- + " > " + tmpf.toFilesystemEncoding(),
+ + " > " + quoteName(tmpf.toFilesystemEncoding()),
FileName(owner_->filePath()));
}
}
-void CVS::checkIn(string const & msg)
+string CVS::checkIn(string const & msg)
{
- doVCCommand("cvs -q commit -m \"" + msg + "\" "
+ int ret = doVCCommand("cvs -q commit -m \"" + msg + "\" "
+ quoteName(onlyFilename(owner_->absFileName())),
FileName(owner_->filePath()));
+ return ret ? string() : "CVS: Proceeded";
}
}
-void CVS::checkOut()
+string CVS::checkOut()
{
// cvs update or perhaps for cvs this should be a noop
// we need to detect conflict (eg "C" in output)
// before we can do this.
- lyxerr << "Sorry not implemented." << endl;
+ lyxerr << "Sorry, not implemented." << endl;
+ return string();
}
// merge the current with the previous version
// in a reverse patch kind of way, so that the
// result is to revert the last changes.
- lyxerr << "Sorry not implemented." << endl;
+ lyxerr << "Sorry, not implemented." << endl;
}
void CVS::getLog(FileName const & tmpf)
{
doVCCommand("cvs log " + quoteName(onlyFilename(owner_->absFileName()))
- + " > " + tmpf.toFilesystemEncoding(),
+ + " > " + quoteName(tmpf.toFilesystemEncoding()),
FileName(owner_->filePath()));
}
SVN::SVN(FileName const & m, FileName const & f)
{
+ owner_ = 0;
master_ = m;
file_ = f;
+ locked_mode_ = 0;
scanMaster();
}
FileName const SVN::findFile(FileName const & file)
{
- // First we look for the CVS/Entries in the same dir
+ // First we look for the .svn/entries in the same dir
// where we have file.
FileName const entries(onlyPath(file.absFilename()) + "/.svn/entries");
string const tmpf = onlyFilename(file.absFilename());
LYXERR(Debug::LYXVC, "LyXVC: Checking if file is under svn in `" << entries
<< "' for `" << tmpf << '\'');
if (entries.isReadableFile()) {
- // Ok we are at least in a CVS dir. Parse the CVS/Entries
+ // Ok we are at least in a SVN dir. Parse the .svn/entries
// and see if we can find this file. We do a fast and
// dirty parse here.
ifstream ifs(entries.toFilesystemEncoding().c_str());
void SVN::scanMaster()
{
- // if we want some locking under svn
- // we need different infrastructure around
- locker_ = "Unlocked";
- vcstatus = UNLOCKED;
+ locker_.clear();
+ vcstatus = NOLOCKING;
+ if (checkLockMode()) {
+ if (isLocked()) {
+ locker_ = "Locked";
+ vcstatus = LOCKED;
+ } else {
+ locker_ = "Unlocked";
+ vcstatus = LOCKED;
+ }
+ }
}
-void SVN::registrer(string const & msg)
+bool SVN::checkLockMode()
+{
+ FileName tmpf = FileName::tempName("lyxvcout");
+ if (tmpf.empty()){
+ LYXERR(Debug::LYXVC, "Could not generate logfile " << tmpf);
+ return N_("Error: Could not generate logfile.");
+ }
+
+ LYXERR(Debug::LYXVC, "Detecting locking mode...");
+ if (doVCCommandCall("svn proplist " + quoteName(file_.onlyFileName())
+ + " > " + quoteName(tmpf.toFilesystemEncoding()),
+ file_.onlyPath()))
+ return false;
+
+ ifstream ifs(tmpf.toFilesystemEncoding().c_str());
+ string line;
+ bool ret = false;
+
+ while (ifs) {
+ getline(ifs, line);
+ LYXERR(Debug::LYXVC, line);
+ if (contains(line, "svn:needs-lock"))
+ ret = true;
+ }
+ LYXERR(Debug::LYXVC, "Locking enabled: " << ret);
+ ifs.close();
+ locked_mode_ = ret;
+ return ret;
+
+}
+
+
+bool SVN::isLocked() const
+{
+ //refresh file info
+ FileName file(file_.absFilename());
+ return !file.isReadOnly();
+}
+
+
+void SVN::registrer(string const & /*msg*/)
{
doVCCommand("svn add -q " + quoteName(onlyFilename(owner_->absFileName())),
FileName(owner_->filePath()));
}
-void SVN::checkIn(string const & msg)
+string SVN::checkIn(string const & msg)
{
FileName tmpf = FileName::tempName("lyxvcout");
if (tmpf.empty()){
LYXERR(Debug::LYXVC, "Could not generate logfile " << tmpf);
- return;
+ return N_("Error: Could not generate logfile.");
}
- doVCCommand("svn commit -q -m \"" + msg + "\" "
+ doVCCommand("svn commit -m \"" + msg + "\" "
+ quoteName(onlyFilename(owner_->absFileName()))
- + " 2> " + tmpf.toFilesystemEncoding(),
+ + " > " + quoteName(tmpf.toFilesystemEncoding()),
FileName(owner_->filePath()));
- string res = scanLogFile(tmpf);
+ string log;
+ string res = scanLogFile(tmpf, log);
if (!res.empty())
frontend::Alert::error(_("Revision control error."),
- _("Error when commiting to repository.\n"
+ _("Error when committing to repository.\n"
"You have to manually resolve the problem.\n"
- "After pressing OK, LyX will reopen resolved document."));
+ "After pressing OK, LyX will reopen the document."));
+ else
+ fileLock(false, tmpf, log);
+
tmpf.erase();
+ return "SVN: " + log;
}
bool SVN::checkInEnabled()
{
- return true;
+ if (locked_mode_)
+ return isLocked();
+ else
+ return true;
}
+
// FIXME Correctly return code should be checked instead of this.
// This would need another solution than just plain startscript.
-string SVN::scanLogFile(FileName const & f)
+// Hint from Andre': QProcess::readAllStandardError()...
+string SVN::scanLogFile(FileName const & f, string & status)
{
ifstream ifs(f.toFilesystemEncoding().c_str());
string line;
- while (ifs){
- getline(ifs,line);
- lyxerr<<line<<"\n";
- if (prefixIs(line, "C "))
- return line;
- if (contains(line, "Commit failed"))
+ while (ifs) {
+ getline(ifs, line);
+ lyxerr << line << "\n";
+ if (!line.empty()) status += line + "; ";
+ if (prefixIs(line, "C ") || contains(line, "Commit failed")) {
+ ifs.close();
return line;
+ }
}
+ ifs.close();
return string();
}
-void SVN::checkOut()
+void SVN::fileLock(bool lock, FileName const & tmpf, string &status)
+{
+ if (!locked_mode_ || (isLocked() == lock))
+ return;
+
+ string arg = lock ? "lock " : "unlock ";
+ doVCCommand("svn "+ arg + quoteName(onlyFilename(owner_->absFileName()))
+ + " > " + quoteName(tmpf.toFilesystemEncoding()),
+ FileName(owner_->filePath()));
+
+ ifstream ifs(tmpf.toFilesystemEncoding().c_str());
+ string line;
+ while (ifs) {
+ getline(ifs, line);
+ if (!line.empty()) status += line + "; ";
+ }
+ ifs.close();
+
+ if (!isLocked() && lock)
+ frontend::Alert::error(_("Revision control error."),
+ _("Error when acquiring write lock.\n"
+ "Most probably another user is editing\n"
+ "the current document now!\n"
+ "Also check the access to the repository."));
+ if (isLocked() && !lock)
+ frontend::Alert::error(_("Revision control error."),
+ _("Error when releasing write lock.\n"
+ "Check the access to the repository."));
+}
+
+
+string SVN::checkOut()
{
FileName tmpf = FileName::tempName("lyxvcout");
- if (tmpf.empty()){
+ if (tmpf.empty()) {
LYXERR(Debug::LYXVC, "Could not generate logfile " << tmpf);
- return;
+ return N_("Error: Could not generate logfile.");
}
doVCCommand("svn update " + quoteName(onlyFilename(owner_->absFileName()))
- + " > " + tmpf.toFilesystemEncoding(),
+ + " > " + quoteName(tmpf.toFilesystemEncoding()),
FileName(owner_->filePath()));
- string res = scanLogFile(tmpf);
+ string log;
+ string res = scanLogFile(tmpf, log);
if (!res.empty())
frontend::Alert::error(_("Revision control error."),
bformat(_("Error when updating from repository.\n"
"You have to manually resolve the conflicts NOW!\n'%1$s'.\n\n"
"After pressing OK, LyX will try to reopen resolved document."),
- from_ascii(res)));
+ from_local8bit(res)));
+
+ fileLock(true, tmpf, log);
+
tmpf.erase();
+ return "SVN: " + log;
}
bool SVN::checkOutEnabled()
{
- return true;
+ if (locked_mode_)
+ return !isLocked();
+ else
+ return true;
}
// merge the current with the previous version
// in a reverse patch kind of way, so that the
// result is to revert the last changes.
- lyxerr << "Sorry not implemented." << endl;
+ lyxerr << "Sorry, not implemented." << endl;
}
void SVN::getLog(FileName const & tmpf)
{
doVCCommand("svn log " + quoteName(onlyFilename(owner_->absFileName()))
- + " > " + tmpf.toFilesystemEncoding(),
+ + " > " + quoteName(tmpf.toFilesystemEncoding()),
FileName(owner_->filePath()));
}