]> git.lyx.org Git - lyx.git/blobdiff - src/TextMetrics.cpp
some refactoring
[lyx.git] / src / TextMetrics.cpp
index c69ab1a345b2b9e645e400c692d9fd6d5f697a92..dc47b425877ecfab87d432657ddfb3a138926fc2 100644 (file)
 
 #include "TextMetrics.h"
 
+#include "Bidi.h"
 #include "Buffer.h"
 #include "buffer_funcs.h"
 #include "BufferParams.h"
 #include "BufferView.h"
-#include "bufferview_funcs.h"
 #include "Color.h"
-#include "CoordCache.h"
 #include "CutAndPaste.h"
 #include "debug.h"
 #include "FontIterator.h"
 #include "FuncRequest.h"
+#include "Layout.h"
 #include "Length.h"
 #include "LyXRC.h"
 #include "MetricsInfo.h"
 
 #include <boost/current_function.hpp>
 
+using std::make_pair;
 using std::max;
 using std::min;
 using std::endl;
+using std::pair;
 
 namespace lyx {
 
@@ -126,19 +128,40 @@ TextMetrics::TextMetrics(BufferView * bv, Text * text)
 }
 
 
+bool TextMetrics::has(pit_type pit) const
+{
+       return par_metrics_.find(pit) != par_metrics_.end();
+}
+
+
 ParagraphMetrics const & TextMetrics::parMetrics(pit_type pit) const
 {
        return const_cast<TextMetrics *>(this)->parMetrics(pit, true);
 }
 
 
+
+pair<pit_type, ParagraphMetrics const *> TextMetrics::first() const
+{
+       ParMetricsCache::const_iterator it = par_metrics_.begin();
+       return make_pair(it->first, &it->second);
+}
+
+
+pair<pit_type, ParagraphMetrics const *> TextMetrics::last() const
+{
+       ParMetricsCache::const_reverse_iterator it = par_metrics_.rbegin();
+       return make_pair(it->first, &it->second);
+}
+
+
 ParagraphMetrics & TextMetrics::parMetrics(pit_type pit,
                bool redo)
 {
        ParMetricsCache::iterator pmc_it = par_metrics_.find(pit);
        if (pmc_it == par_metrics_.end()) {
                pmc_it = par_metrics_.insert(
-                       std::make_pair(pit, ParagraphMetrics(text_->getPar(pit)))).first;
+                       make_pair(pit, ParagraphMetrics(text_->getPar(pit)))).first;
        }
        if (pmc_it->second.rows().empty() && redo) {
                redoParagraph(pit);
@@ -147,7 +170,18 @@ ParagraphMetrics & TextMetrics::parMetrics(pit_type pit,
 }
 
 
-bool TextMetrics::metrics(MetricsInfo & mi, Dimension & dim)
+int TextMetrics::parPosition(pit_type pit) const
+{
+       if (pit < par_metrics_.begin()->first)
+               return -1000000;
+       else if (pit > par_metrics_.rbegin()->first)
+               return +1000000;
+
+       return par_metrics_[pit].position();
+}
+
+
+bool TextMetrics::metrics(MetricsInfo & mi, Dimension & dim, int min_width)
 {
        BOOST_ASSERT(mi.base.textwidth);
        max_width_ = mi.base.textwidth;
@@ -155,6 +189,7 @@ bool TextMetrics::metrics(MetricsInfo & mi, Dimension & dim)
        Dimension const old_dim = dim_;
        // reset dimension.
        dim_ = Dimension();
+       dim_.wid = min_width;
        pit_type const npar = text_->paragraphs().size();
        if (npar > 1)
                // If there is more than one row, expand the text to 
@@ -225,15 +260,11 @@ Font TextMetrics::getDisplayFont(pit_type pit, pos_type pos) const
                Font f = par.getFontSettings(params, pos);
                if (!text_->isMainText(buffer))
                        applyOuterFont(f);
-               Font lf;
-               Font rlf;
-               if (layout->labeltype == LABEL_MANUAL && pos < body_pos) {
-                       lf = layout->labelfont;
-                       rlf = layout->reslabelfont;
-               } else {
-                       lf = layout->font;
-                       rlf = layout->resfont;
-               }
+               bool lab = layout->labeltype == LABEL_MANUAL && pos < body_pos;
+
+               Font const & lf = lab ? layout->labelfont : layout->font;
+               Font rlf = lab ? layout->reslabelfont : layout->resfont;
+               
                // In case the default family has been customized
                if (lf.family() == Font::INHERIT_FAMILY)
                        rlf.setFamily(params.getFont().family());
@@ -241,11 +272,8 @@ Font TextMetrics::getDisplayFont(pit_type pit, pos_type pos) const
        }
 
        // The uncommon case need not be optimized as much
-       Font layoutfont;
-       if (pos < body_pos)
-               layoutfont = layout->labelfont;
-       else
-               layoutfont = layout->font;
+       Font const & layoutfont = pos < body_pos ? 
+               layout->labelfont : layout->font;
 
        Font font = par.getFontSettings(params, pos);
        font.realize(layoutfont);
@@ -268,7 +296,7 @@ Font TextMetrics::getDisplayFont(pit_type pit, pos_type pos) const
 
 bool TextMetrics::isRTL(CursorSlice const & sl, bool boundary) const
 {
-       if (!lyxrc.rtl_support && !sl.text())
+       if (!lyxrc.rtl_support || !sl.text())
                return false;
 
        int correction = 0;
@@ -293,7 +321,7 @@ bool TextMetrics::isRTLBoundary(pit_type pit, pos_type pos) const
        bool left = getDisplayFont(pit, pos - 1).isVisibleRightToLeft();
        bool right;
        if (pos == par.size())
-               right = par.isRightToLeftPar(bv_->buffer().params());
+               right = par.isRTL(bv_->buffer().params());
        else
                right = getDisplayFont(pit, pos).isVisibleRightToLeft();
        return left != right;
@@ -310,7 +338,7 @@ bool TextMetrics::isRTLBoundary(pit_type pit, pos_type pos,
        bool left = font.isVisibleRightToLeft();
        bool right;
        if (pos == par.size())
-               right = par.isRightToLeftPar(bv_->buffer().params());
+               right = par.isRTL(bv_->buffer().params());
        else
                right = getDisplayFont(pit, pos).isVisibleRightToLeft();
        return left != right;
@@ -357,17 +385,40 @@ bool TextMetrics::redoParagraph(pit_type const pit)
        InsetList::const_iterator ii = par.insetlist.begin();
        InsetList::const_iterator iend = par.insetlist.end();
        for (; ii != iend; ++ii) {
-               Dimension old_dim = ii->inset->dimension();
                Dimension dim;
                int const w = max_width_ - leftMargin(max_width_, pit, ii->pos)
                        - right_margin;
                Font const & font = ii->inset->noFontChange() ?
                        bufferfont : getDisplayFont(pit, ii->pos);
                MetricsInfo mi(bv_, font, w);
-               changed |= ii->inset->metrics(mi, dim);
+               ii->inset->metrics(mi, dim);
+               Dimension const old_dim = pm.insetDimension(ii->inset);
+               pm.setInsetDimension(ii->inset, dim);
                changed |= (old_dim != dim);
        }
 
+       Cursor const & cur = bv_->cursor();
+       DocIterator sel_beg = cur.selectionBegin();
+       DocIterator sel_end = cur.selectionEnd();
+       bool selection = cur.selection()
+               // This is out text.
+               && cur.text() == text_
+               // if the anchor is outside, this is not our selection 
+               && cur.anchor().text() == text_
+               && pit >= sel_beg.pit() && pit <= sel_end.pit();
+
+       // We care only about visible selection.
+       if (selection) {
+               if (pit != sel_beg.pit()) {
+                       sel_beg.pit() = pit;
+                       sel_beg.pos() = 0;
+               }
+               if (pit != sel_end.pit()) {
+                       sel_end.pit() = pit;
+                       sel_end.pos() = sel_end.lastpos();
+               }
+       }
+
        par.setBeginOfBody();
        pos_type first = 0;
        size_t row_index = 0;
@@ -379,7 +430,7 @@ bool TextMetrics::redoParagraph(pit_type const pit)
                if (row_index || end < par.size())
                        // If there is more than one row, expand the text to 
                        // the full allowable width. This setting here is needed
-                       // for the computeRowMetrics below().
+                       // for the computeRowMetrics() below.
                        dim_.wid = max_width_;
 
                dim.wid = rowWidth(right_margin, pit, first, end);
@@ -390,8 +441,13 @@ bool TextMetrics::redoParagraph(pit_type const pit)
                row.setChanged(false);
                row.pos(first);
                row.endpos(end);
+               if (selection)
+                       row.setSelection(sel_beg.pos(), sel_end.pos());
+               else
+                       row.setSelection(-1, -1);
                row.setDimension(dim);
-               computeRowMetrics(pit, row);
+               int const max_row_width = max(dim_.wid, dim.wid);
+               computeRowMetrics(pit, row, max_row_width);
                pm.computeRowSignature(row, bparams);
                first = end;
                ++row_index;
@@ -416,7 +472,8 @@ bool TextMetrics::redoParagraph(pit_type const pit)
                row.pos(first);
                row.endpos(first);
                row.setDimension(dim);
-               computeRowMetrics(pit, row);
+               int const max_row_width = max(dim_.wid, dim.wid);
+               computeRowMetrics(pit, row, max_row_width);
                pm.computeRowSignature(row, bparams);
                pm.dim().des += dim.height();
        }
@@ -431,7 +488,7 @@ bool TextMetrics::redoParagraph(pit_type const pit)
 
 
 void TextMetrics::computeRowMetrics(pit_type const pit,
-               Row & row) const
+               Row & row, int width) const
 {
 
        row.label_hfill = 0;
@@ -441,7 +498,7 @@ void TextMetrics::computeRowMetrics(pit_type const pit,
        Buffer & buffer = bv_->buffer();
        Paragraph const & par = text_->getPar(pit);
 
-       double w = dim_.wid - row.width();
+       double w = width - row.width();
        // FIXME: put back this assertion when the crash on new doc is solved.
        //BOOST_ASSERT(w >= 0);
 
@@ -806,12 +863,14 @@ boost::tuple<int, int> TextMetrics::rowHeight(pit_type const pit, pos_type const
        int maxdesc = int(fontmetrics.maxDescent() * spacing_val);
 
        // insets may be taller
+       ParagraphMetrics const & pm = par_metrics_[pit];
        InsetList::const_iterator ii = par.insetlist.begin();
        InsetList::const_iterator iend = par.insetlist.end();
        for ( ; ii != iend; ++ii) {
+               Dimension const & dim = pm.insetDimension(ii->inset);
                if (ii->pos >= first && ii->pos < end) {
-                       maxasc  = max(maxasc,  ii->inset->ascent());
-                       maxdesc = max(maxdesc, ii->inset->descent());
+                       maxasc  = max(maxasc,  dim.ascent());
+                       maxdesc = max(maxdesc, dim.descent());
                }
        }
 
@@ -968,7 +1027,7 @@ pos_type TextMetrics::getColumnNearX(pit_type const pit,
        /// For the main Text, it is possible that this pit is not
        /// yet in the CoordCache when moving cursor up.
        /// x Paragraph coordinate is always 0 for main text anyway.
-       int const xo = main_text_? 0 : bv_->coordCache().get(text_, pit).x_;
+       int const xo = origin_.x_;
        x -= xo;
        Paragraph const & par = text_->getPar(pit);
        ParagraphMetrics const & pm = par_metrics_[pit];
@@ -1101,8 +1160,12 @@ pos_type TextMetrics::getColumnNearX(pit_type const pit,
 
 pos_type TextMetrics::x2pos(pit_type pit, int row, int x) const
 {
-       ParagraphMetrics const & pm = par_metrics_[pit];
-       BOOST_ASSERT(!pm.rows().empty());
+       // We play safe and use parMetrics(pit) to make sure the
+       // ParagraphMetrics will be redone and OK to use if needed.
+       // Otherwise we would use an empty ParagraphMetrics in
+       // upDownInText() while in selection mode.
+       ParagraphMetrics const & pm = parMetrics(pit);
+
        BOOST_ASSERT(row < int(pm.rows().size()));
        bool bound = false;
        Row const & r = pm.rows()[row];
@@ -1110,30 +1173,55 @@ pos_type TextMetrics::x2pos(pit_type pit, int row, int x) const
 }
 
 
+void TextMetrics::newParMetricsDown()
+{
+       pair<pit_type, ParagraphMetrics> const & last = *par_metrics_.rbegin();
+       pit_type const pit = last.first + 1;
+       if (pit == int(text_->paragraphs().size()))
+               return;
+
+       // do it and update its position.
+       redoParagraph(pit);
+       par_metrics_[pit].setPosition(last.second.position()
+               + last.second.descent());
+}
+
+
+void TextMetrics::newParMetricsUp()
+{
+       pair<pit_type, ParagraphMetrics> const & first = *par_metrics_.begin();
+       if (first.first == 0)
+               return;
+
+       pit_type const pit = first.first - 1;
+       // do it and update its position.
+       redoParagraph(pit);
+       par_metrics_[pit].setPosition(first.second.position()
+               - first.second.ascent());
+}
+
 // y is screen coordinate
 pit_type TextMetrics::getPitNearY(int y)
 {
        BOOST_ASSERT(!text_->paragraphs().empty());
-       BOOST_ASSERT(bv_->coordCache().getParPos().find(text_) != bv_->coordCache().getParPos().end());
-       CoordCache::InnerParPosCache const & cc = bv_->coordCache().getParPos().find(text_)->second;
        LYXERR(Debug::DEBUG)
                << BOOST_CURRENT_FUNCTION
-               << ": y: " << y << " cache size: " << cc.size()
+               << ": y: " << y << " cache size: " << par_metrics_.size()
                << endl;
 
        // look for highest numbered paragraph with y coordinate less than given y
        pit_type pit = 0;
        int yy = -1;
-       CoordCache::InnerParPosCache::const_iterator it = cc.begin();
-       CoordCache::InnerParPosCache::const_iterator et = cc.end();
-       CoordCache::InnerParPosCache::const_iterator last = et; last--;
+       ParMetricsCache::const_iterator it = par_metrics_.begin();
+       ParMetricsCache::const_iterator et = par_metrics_.end();
+       ParMetricsCache::const_iterator last = et; last--;
 
-       ParagraphMetrics const & pm = par_metrics_[it->first];
+       ParagraphMetrics const & pm = it->second;
 
        // If we are off-screen (before the visible part)
        if (y < 0
                // and even before the first paragraph in the cache.
-               && y < it->second.y_ - int(pm.ascent())) {
+               && y < it->second.position() - int(pm.ascent())) {
                //  and we are not at the first paragraph in the inset.
                if (it->first == 0)
                        return 0;
@@ -1141,8 +1229,7 @@ pit_type TextMetrics::getPitNearY(int y)
                pit = it->first - 1;
                // rebreak it and update the CoordCache.
                redoParagraph(pit);
-               bv_->coordCache().parPos()[text_][pit] =
-                       Point(0, it->second.y_ - pm.descent());
+               par_metrics_[pit].setPosition(it->second.position() - pm.descent());
                return pit;
        }
 
@@ -1151,7 +1238,7 @@ pit_type TextMetrics::getPitNearY(int y)
        // If we are off-screen (after the visible part)
        if (y > bv_->workHeight()
                // and even after the first paragraph in the cache.
-               && y >= last->second.y_ + int(pm_last.descent())) {
+               && y >= last->second.position() + int(pm_last.descent())) {
                pit = last->first + 1;
                //  and we are not at the last paragraph in the inset.
                if (pit == int(text_->paragraphs().size()))
@@ -1159,8 +1246,7 @@ pit_type TextMetrics::getPitNearY(int y)
                // then this is the paragraph we are looking for.
                // rebreak it and update the CoordCache.
                redoParagraph(pit);
-               bv_->coordCache().parPos()[text_][pit] =
-                       Point(0, last->second.y_ + pm_last.ascent());
+               par_metrics_[pit].setPosition(last->second.position() + pm_last.ascent());
                return pit;
        }
 
@@ -1168,14 +1254,14 @@ pit_type TextMetrics::getPitNearY(int y)
                LYXERR(Debug::DEBUG)
                        << BOOST_CURRENT_FUNCTION
                        << "  examining: pit: " << it->first
-                       << " y: " << it->second.y_
+                       << " y: " << it->second.position()
                        << endl;
 
                ParagraphMetrics const & pm = par_metrics_[it->first];
 
-               if (it->first >= pit && int(it->second.y_) - int(pm.ascent()) <= y) {
+               if (it->first >= pit && int(it->second.position()) - int(pm.ascent()) <= y) {
                        pit = it->first;
-                       yy = it->second.y_;
+                       yy = it->second.position();
                }
        }
 
@@ -1192,10 +1278,11 @@ Row const & TextMetrics::getRowNearY(int y, pit_type pit) const
 {
        ParagraphMetrics const & pm = par_metrics_[pit];
 
-       int yy = bv_->coordCache().get(text_, pit).y_ - pm.ascent();
+       int yy = pm.position() - pm.ascent();
        BOOST_ASSERT(!pm.rows().empty());
        RowList::const_iterator rit = pm.rows().begin();
-       RowList::const_iterator const rlast = boost::prior(pm.rows().end());
+       RowList::const_iterator rlast = pm.rows().end();
+       --rlast;
        for (; rit != rlast; yy += rit->height(), ++rit)
                if (yy + rit->height() > y)
                        break;
@@ -1269,7 +1356,7 @@ void TextMetrics::setCursorFromCoordinates(Cursor & cur, int const x, int const
 
        ParagraphMetrics const & pm = par_metrics_[pit];
 
-       int yy = bv_->coordCache().get(text_, pit).y_ - pm.ascent();
+       int yy = pm.position() - pm.ascent();
        LYXERR(Debug::DEBUG)
                << BOOST_CURRENT_FUNCTION
                << ": x: " << x
@@ -1317,6 +1404,7 @@ Inset * TextMetrics::checkInsetHit(int x, int y)
        BOOST_ASSERT(pit != -1);
 
        Paragraph const & par = text_->paragraphs()[pit];
+       ParagraphMetrics const & pm = par_metrics_[pit];
 
        LYXERR(Debug::DEBUG)
                << BOOST_CURRENT_FUNCTION
@@ -1328,32 +1416,38 @@ Inset * TextMetrics::checkInsetHit(int x, int y)
        InsetList::const_iterator iend = par.insetlist.end();
        for (; iit != iend; ++iit) {
                Inset * inset = iit->inset;
-#if 1
+
                LYXERR(Debug::DEBUG)
                        << BOOST_CURRENT_FUNCTION
                        << ": examining inset " << inset << endl;
 
-               if (bv_->coordCache().getInsets().has(inset))
-                       LYXERR(Debug::DEBUG)
-                               << BOOST_CURRENT_FUNCTION
-                               << ": xo: " << inset->xo(*bv_) << "..."
-                               << inset->xo(*bv_) + inset->width()
-                               << " yo: " << inset->yo(*bv_) - inset->ascent()
-                               << "..."
-                               << inset->yo(*bv_) + inset->descent()
-                               << endl;
-               else
+               if (!bv_->coordCache().getInsets().has(inset)) {
                        LYXERR(Debug::DEBUG)
                                << BOOST_CURRENT_FUNCTION
                                << ": inset has no cached position" << endl;
-#endif
-               if (inset->covers(*bv_, x, y)) {
+                       return 0;
+               }
+
+               Dimension const & dim = pm.insetDimension(inset);
+               Point p = bv_->coordCache().getInsets().xy(inset);
+
+               LYXERR(Debug::DEBUG)
+                       << BOOST_CURRENT_FUNCTION
+                       << ": xo: " << p.x_ << "..." << p.x_ + dim.wid
+                       << " yo: " << p.y_ - dim.asc << "..." << p.y_ + dim.des
+                       << endl;
+
+               if (x >= p.x_
+                       && x <= p.x_ + dim.wid
+                       && y >= p.y_ - dim.asc
+                       && y <= p.y_ + dim.des) {
                        LYXERR(Debug::DEBUG)
                                << BOOST_CURRENT_FUNCTION
                                << ": Hit inset: " << inset << endl;
                        return inset;
                }
        }
+
        LYXERR(Debug::DEBUG)
                << BOOST_CURRENT_FUNCTION
                << ": No inset hit. " << endl;
@@ -1779,13 +1873,19 @@ void TextMetrics::draw(PainterInfo & pi, int x, int y) const
        if (par_metrics_.empty())
                return;
 
-       ParMetricsCache::const_iterator it = par_metrics_.begin();
-       ParMetricsCache::const_iterator const end = par_metrics_.end();
+       origin_.x_ = x;
+       origin_.y_ = y;
+
+       ParMetricsCache::iterator it = par_metrics_.begin();
+       ParMetricsCache::iterator const pm_end = par_metrics_.end();
        y -= it->second.ascent();
-       for (; it != end; ++it) {
+       for (; it != pm_end; ++it) {
                ParagraphMetrics const & pmi = it->second;
                y += pmi.ascent();
-               drawParagraph(pi, it->first, x, y);
+               pit_type const pit = it->first;
+               // Save the paragraph position in the cache.
+               it->second.setPosition(y);
+               drawParagraph(pi, pit, x, y);
                y += pmi.descent();
        }
 }
@@ -1796,8 +1896,6 @@ void TextMetrics::drawParagraph(PainterInfo & pi, pit_type pit, int x, int y) co
 //     lyxerr << "  paintPar: pit: " << pit << " at y: " << y << endl;
        int const ww = bv_->workHeight();
 
-       bv_->coordCache().parPos()[text_][pit] = Point(x, y);
-
        ParagraphMetrics const & pm = par_metrics_[pit];
        if (pm.rows().empty())
                return;
@@ -1820,7 +1918,9 @@ void TextMetrics::drawParagraph(PainterInfo & pi, pit_type pit, int x, int y) co
                // Row signature; has row changed since last paint?
                bool row_has_changed = rit->changed();
                
-               if (!pi.full_repaint && !row_has_changed) {
+               bool row_selection = rit->sel_beg != -1 && rit->sel_end != -1;
+
+               if (!row_selection && !pi.full_repaint && !row_has_changed) {
                        // Paint the only the insets if the text itself is
                        // unchanged.
                        rp.paintOnlyInsets();
@@ -1832,20 +1932,33 @@ void TextMetrics::drawParagraph(PainterInfo & pi, pit_type pit, int x, int y) co
                // changed.
                // Clear background of this row
                // (if paragraph background was not cleared)
-               if (!pi.full_repaint && row_has_changed) {
+               if (row_selection || (!pi.full_repaint && row_has_changed)) {
                        pi.pain.fillRectangle(x, y - rit->ascent(),
                                width(), rit->height(),
                                Color_color(Color::color(pi.background_color)));
                }
+               if (row_selection) {
+                       DocIterator beg = bv_->cursor().selectionBegin();
+                       DocIterator end = bv_->cursor().selectionEnd();
+                       beg.pit() = pit;
+                       beg.pos() = rit->sel_beg;
+                       if (pit == end.pit()) {
+                               end.pos() = rit->sel_end;
+                       } else {
+                               end.pit() = pit + 1;
+                               end.pos() = 0;
+                       }
+                       drawSelection(pi, beg, end, x);
+               }
 
                // Instrumentation for testing row cache (see also
                // 12 lines lower):
                if (lyxerr.debugging(Debug::PAINTING)) {
                        if (text_->isMainText(bv_->buffer()))
-                               LYXERR(Debug::PAINTING) << "\n{" <<
+                               LYXERR(Debug::PAINTING) << "\n{" << inside <<
                                pi.full_repaint << row_has_changed << "}";
                        else
-                               LYXERR(Debug::PAINTING) << "[" <<
+                               LYXERR(Debug::PAINTING) << "[" << inside <<
                                pi.full_repaint << row_has_changed << "]";
                }
 
@@ -1872,62 +1985,33 @@ void TextMetrics::drawParagraph(PainterInfo & pi, pit_type pit, int x, int y) co
 }
 
 
-// only used for inset right now. should also be used for main text
-void TextMetrics::drawSelection(PainterInfo & pi, int x, int) const
+// FIXME: only take care of one row!
+void TextMetrics::drawSelection(PainterInfo & pi,
+       DocIterator const & beg, DocIterator const & end, int x) const
 {
-       Cursor & cur = bv_->cursor();
-       if (!cur.selection())
-               return;
-       if (!ptr_cmp(cur.text(), text_))
-               return;
-
-       LYXERR(Debug::DEBUG)
-               << BOOST_CURRENT_FUNCTION
-               << "draw selection at " << x
-               << endl;
-
-       DocIterator beg = cur.selectionBegin();
-       DocIterator end = cur.selectionEnd();
-
-       // the selection doesn't touch the visible screen?
-       if (bv_funcs::status(bv_, beg) == bv_funcs::CUR_BELOW
-           || bv_funcs::status(bv_, end) == bv_funcs::CUR_ABOVE)
-               return;
-
-       if (beg.pit() < par_metrics_.begin()->first) {
-               beg.pit() = par_metrics_.begin()->first;
-               beg.pos() = 0;
-       }
-       if (end.pit() > par_metrics_.rbegin()->first) {
-               end.pit() = par_metrics_.rbegin()->first;
-               end.pos() = end.lastpos();
-       }
-
-       ParagraphMetrics const & pm1 = par_metrics_[beg.pit()];
-       ParagraphMetrics const & pm2 = par_metrics_[end.pit()];
+       ParagraphMetrics const & pm1 = parMetrics(beg.pit());
+       ParagraphMetrics const & pm2 = parMetrics(end.pit());
        Row const & row1 = pm1.getRow(beg.pos(), beg.boundary());
        Row const & row2 = pm2.getRow(end.pos(), end.boundary());
 
        // clip above
        int middleTop;
-       bool const clipAbove = 
-               (bv_funcs::status(bv_, beg) == bv_funcs::CUR_ABOVE);
+       bool const clipAbove = (bv_->cursorStatus(beg) == CUR_ABOVE);
        if (clipAbove)
                middleTop = 0;
        else
-               middleTop = bv_funcs::getPos(*bv_, beg, beg.boundary()).y_ + row1.descent();
+               middleTop = bv_->getPos(beg, beg.boundary()).y_ + row1.descent();
        
        // clip below
        int middleBottom;
-       bool const clipBelow = 
-               (bv_funcs::status(bv_, end) == bv_funcs::CUR_BELOW);
+       bool const clipBelow = (bv_->cursorStatus(end) == CUR_BELOW);
        if (clipBelow)
                middleBottom = bv_->workHeight();
        else
-               middleBottom = bv_funcs::getPos(*bv_, end, end.boundary()).y_ - row2.ascent();
+               middleBottom = bv_->getPos(end, end.boundary()).y_ - row2.ascent();
 
        // start and end in the same line?
-       if (!(clipAbove || clipBelow) && &row1 == &row2)
+       if (!clipAbove && !clipBelow && &row1 == &row2)
                // then only draw this row's selection
                drawRowSelection(pi, x, row1, beg, end, false, false);
        else {
@@ -1968,7 +2052,7 @@ void TextMetrics::drawRowSelection(PainterInfo & pi, int x, Row const & row,
        DocIterator cur = beg;
        int x1 = cursorX(beg.top(), beg.boundary());
        int x2 = cursorX(end.top(), end.boundary());
-       int y1 = bv_funcs::getPos(*bv_, cur, cur.boundary()).y_ - row.ascent();
+       int y1 = bv_->getPos(cur, cur.boundary()).y_ - row.ascent();
        int y2 = y1 + row.height();
        
        // draw the margins