]> git.lyx.org Git - lyx.git/blobdiff - src/TextMetrics.cpp
avoid float-conversion warning and simplify size computation
[lyx.git] / src / TextMetrics.cpp
index ca6408d2bc41add4f75e3b64f4f50053733ebc02..da9e404cb013813a1cd437f8165322426e13095b 100644 (file)
  * Full author contact details are available in file CREDITS.
  */
 
-//#define KEEP_OLD_METRICS_CODE 1
-
 #include <config.h>
 
 #include "TextMetrics.h"
 
-#ifdef KEEP_OLD_METRICS_CODE
-#include "Bidi.h"
-#endif
 #include "Buffer.h"
 #include "buffer_funcs.h"
 #include "BufferParams.h"
@@ -37,7 +32,7 @@
 #include "LyXRC.h"
 #include "MetricsInfo.h"
 #include "ParagraphParameters.h"
-#include "rowpainter.h"
+#include "RowPainter.h"
 #include "Text.h"
 #include "TextClass.h"
 #include "VSpace.h"
@@ -295,7 +290,7 @@ Font TextMetrics::displayFont(pit_type pit, pos_type pos) const
 
 bool TextMetrics::isRTL(CursorSlice const & sl, bool boundary) const
 {
-       if (!lyxrc.rtl_support || !sl.text())
+       if (!sl.text())
                return false;
 
        int correction = 0;
@@ -309,7 +304,7 @@ bool TextMetrics::isRTL(CursorSlice const & sl, bool boundary) const
 bool TextMetrics::isRTLBoundary(pit_type pit, pos_type pos) const
 {
        // no RTL boundary at paragraph start
-       if (!lyxrc.rtl_support || pos == 0)
+       if (pos == 0)
                return false;
 
        Font const & left_font = displayFont(pit, pos - 1);
@@ -324,9 +319,8 @@ bool TextMetrics::isRTLBoundary(pit_type pit, pos_type pos) const
 bool TextMetrics::isRTLBoundary(pit_type pit, pos_type pos,
                Font const & font) const
 {
-       if (!lyxrc.rtl_support
-           // no RTL boundary at paragraph start
-           || pos == 0
+       if (// no RTL boundary at paragraph start
+           pos == 0
            // if the metrics have not been calculated, then we are not
            // on screen and can safely ignore issues about boundaries.
            || !contains(pit))
@@ -351,6 +345,7 @@ bool TextMetrics::isRTLBoundary(pit_type pit, pos_type pos,
        // FED                          FED|                     FED     )
        if (startpos == pos && endpos == pos && endpos != par.size()
                && (par.isNewline(pos - 1)
+                       || par.isEnvSeparator(pos - 1)
                        || par.isLineSeparator(pos - 1)
                        || par.isSeparator(pos - 1)))
                return false;
@@ -390,7 +385,7 @@ bool TextMetrics::redoParagraph(pit_type const pit)
                Cursor & cur = const_cast<Cursor &>(bv_->cursor());
                // In some cases, we do not know how to record undo
                if (&cur.inset() == &text_->inset())
-                       cur.recordUndo(ATOMIC_UNDO, pit, pit);
+                       cur.recordUndo(pit, pit);
 
                int const moveCursor = par.fixBiblio(buffer);
 
@@ -451,7 +446,7 @@ bool TextMetrics::redoParagraph(pit_type const pit)
                MacroContext mc(&buffer, parPos);
                MetricsInfo mi(bv_, font.fontInfo(), w, mc);
                ii->inset->metrics(mi, dim);
-               Dimension const old_dim = pm.insetDimension(ii->inset);
+               Dimension const old_dim = pm.insetDimension(ii->inset);
                if (old_dim != dim) {
                        pm.setInsetDimension(ii->inset, dim);
                        changed = true;
@@ -511,11 +506,11 @@ bool TextMetrics::redoParagraph(pit_type const pit)
 }
 
 
-int TextMetrics::getAlign(Paragraph const & par, pos_type const pos) const
+LyXAlignment TextMetrics::getAlign(Paragraph const & par, pos_type const pos) const
 {
        Layout const & layout = par.layout();
 
-       int align;
+       LyXAlignment align;
        if (par.params().align() == LYX_ALIGN_LAYOUT)
                align = layout.align;
        else
@@ -570,19 +565,15 @@ void TextMetrics::computeRowMetrics(pit_type const pit,
 
        Paragraph const & par = text_->getPar(pit);
 
-       double w = width - row.width();
+       int const w = width - row.right_margin - row.width();
        // FIXME: put back this assertion when the crash on new doc is solved.
        //LASSERT(w >= 0, /**/);
 
-       //lyxerr << "\ndim_.wid " << dim_.wid << endl;
-       //lyxerr << "row.width() " << row.width() << endl;
-       //lyxerr << "w " << w << endl;
-
        bool const is_rtl = text_->isRTL(par);
        if (is_rtl)
-               row.x = rightMargin(pit);
+               row.left_margin = rightMargin(pit);
        else
-               row.x = leftMargin(max_width_, pit, row.pos());
+               row.left_margin = leftMargin(max_width_, pit, row.pos());
 
        // is there a manual margin with a manual label
        Layout const & layout = par.layout();
@@ -609,72 +600,58 @@ void TextMetrics::computeRowMetrics(pit_type const pit,
        // are there any hfills in the row?
        if (int const nh = numberOfHfills(row, par.beginOfBody())) {
                if (w > 0)
-                       hfill = w / double(nh);
+                       hfill = double(w) / nh;
        // we don't have to look at the alignment if it is ALIGN_LEFT and
        // if the row is already larger then the permitted width as then
        // we force the LEFT_ALIGN'edness!
        } else if (int(row.width()) < max_width_) {
                // is it block, flushleft or flushright?
                // set x how you need it
-               int const align = getAlign(par, row.pos());
-
-               switch (align) {
+               switch (getAlign(par, row.pos())) {
                case LYX_ALIGN_BLOCK: {
                        int const ns = numberOfSeparators(row);
                        /** If we have separators, and this row has
                         * not be broken abruptly by a display inset
                         * or newline, then stretch it */
-                       if (ns && !row.right_boundary() 
+                       if (ns && !row.right_boundary()
                            && row.endpos() != par.size()) {
-                               setSeparatorWidth(row, w / ns);
+                               setSeparatorWidth(row, double(w) / ns);
                                row.dimension().wid = width;
-                               //lyxerr << "row.separator " << row.separator << endl;
-                               //lyxerr << "ns " << ns << endl;
                        } else if (is_rtl) {
                                row.dimension().wid = width;
-                               row.x += w;
+                               row.left_margin += w;
                        }
                        break;
                }
                case LYX_ALIGN_RIGHT:
-                       row.dimension().wid = width;
-                       row.x += w;
+                       row.left_margin += w;
                        break;
                case LYX_ALIGN_CENTER:
-                       row.dimension().wid += w / 2;
-                       row.x += w / 2;
+                       row.dimension().wid = width - w / 2;
+                       row.left_margin += w / 2;
+                       break;
+               case LYX_ALIGN_LEFT:
+               case LYX_ALIGN_NONE:
+               case LYX_ALIGN_LAYOUT:
+               case LYX_ALIGN_SPECIAL:
+               case LYX_ALIGN_DECIMAL:
                        break;
                }
        }
 
-#if 0
-       if (is_rtl) {
-               pos_type body_pos = par.beginOfBody();
-               pos_type end = row.endpos();
-
-               if (body_pos > 0
-                   && (body_pos > end || !par.isLineSeparator(body_pos - 1))) {
-                       row.x += theFontMetrics(text_->labelFont(par)).
-                               width(layout.labelsep);
-                       if (body_pos <= end)
-                               row.x += row.label_hfill;
-               }
-       }
-#endif
-
+       // Finally,  handle hfill insets
        pos_type const endpos = row.endpos();
        pos_type body_pos = par.beginOfBody();
        if (body_pos > 0
            && (body_pos > endpos || !par.isLineSeparator(body_pos - 1)))
                body_pos = 0;
-
        ParagraphMetrics & pm = par_metrics_[pit];
        Row::iterator cit = row.begin();
        Row::iterator const cend = row.end();
        for ( ; cit != cend; ++cit) {
                if (row.label_hfill && cit->endpos == body_pos
                    && cit->type == Row::SPACE)
-                       cit->dim.wid -= row.label_hfill * (nlh - 1);
+                       cit->dim.wid -= int(row.label_hfill * (nlh - 1));
                if (!cit->inset || !cit->inset->isHfill())
                        continue;
                if (pm.hfillExpansion(row, cit->pos))
@@ -692,7 +669,7 @@ void TextMetrics::computeRowMetrics(pit_type const pit,
 int TextMetrics::labelFill(pit_type const pit, Row const & row) const
 {
        Paragraph const & par = text_->getPar(pit);
-       LBUFERR(par.beginOfBody() > 0);
+       LBUFERR(par.beginOfBody() > 0 || par.isEnvSeparator(0));
 
        int w = 0;
        Row::const_iterator cit = row.begin();
@@ -700,7 +677,7 @@ int TextMetrics::labelFill(pit_type const pit, Row const & row) const
        // iterate over elements before main body (except the last one,
        // which is extra space).
        while (cit!= end && cit->endpos < par.beginOfBody()) {
-               w += cit->width();
+               w += cit->dim.wid;
                ++cit;
        }
 
@@ -800,7 +777,7 @@ private:
 
 /** This is the function where the hard work is done. The code here is
  * very sensitive to small changes :) Note that part of the
- * intelligence is also in Row::shorten_if_needed
+ * intelligence is also in Row::shortenIfNeeded.
  */
 void TextMetrics::breakRow(Row & row, int const right_margin, pit_type const pit) const
 {
@@ -810,12 +787,12 @@ void TextMetrics::breakRow(Row & row, int const right_margin, pit_type const pit
        int const width = max_width_ - right_margin;
        pos_type const body_pos = par.beginOfBody();
        row.clear();
-       row.dimension().wid = leftMargin(max_width_, pit, pos);
-       row.x = row.width();
+       // This make get changed in computeRowMetrics depending on RTL
+       row.left_margin = leftMargin(max_width_, pit, pos);
+       row.dimension().wid = row.left_margin;
        row.right_margin = right_margin;
 
        if (pos >= end || row.width() > width) {
-               row.dimension().wid += right_margin;
                row.endpos(end);
                return;
        }
@@ -852,6 +829,17 @@ void TextMetrics::breakRow(Row & row, int const right_margin, pit_type const pit
                        Inset const * ins = par.getInset(i);
                        Dimension dim = pm.insetDimension(ins);
                        row.add(i, ins, dim, *fi, par.lookupChange(i));
+               } else if (c == ' ' && i + 1 == body_pos) {
+                       // There is a space at i, but it should not be
+                       // added as a separator, because it is just
+                       // before body_pos. Instead, insert some spacing to
+                       // align text
+                       FontMetrics const & fm = theFontMetrics(text_->labelFont(par));
+                       // this is needed to make sure that the row width is correct
+                       row.finalizeLast();
+                       int const add = max(fm.width(par.layout().labelsep),
+                                           labelEnd(pit) - row.width());
+                       row.addSpace(i, add, *fi, par.lookupChange(i));
                } else if (par.isLineSeparator(i)) {
                        // In theory, no inset has this property. If
                        // this is done, a new addSeparator which
@@ -865,15 +853,6 @@ void TextMetrics::breakRow(Row & row, int const right_margin, pit_type const pit
                else
                        row.add(i, c, *fi, par.lookupChange(i));
 
-               // end of paragraph marker
-               if (lyxrc.paragraph_markers
-                   && i == end - 1 && size_type(pit + 1) < pars.size()) {
-                       // enlarge the last character to hold the end-of-par marker
-                       Font f(text_->layoutFont(pit));
-                       f.fontInfo().setColor(Color_paragraphmarker);
-                       row.addVirtual(i + 1, docstring(1, char_type(0x00B6)), f, Change());
-               }
-
                // add inline completion width
                if (inlineCompletionLPos == i &&
                    !bv_->inlineCompletion().empty()) {
@@ -888,7 +867,7 @@ void TextMetrics::breakRow(Row & row, int const right_margin, pit_type const pit
                // - Before a display inset
                // - After a display inset
                Inset const * inset = 0;
-               if (par.isNewline(i)
+               if (par.isNewline(i) || par.isEnvSeparator(i)
                    || (i + 1 < end && (inset = par.getInset(i + 1))
                        && inset->display())
                    || (!row.empty() && row.back().inset
@@ -900,38 +879,29 @@ void TextMetrics::breakRow(Row & row, int const right_margin, pit_type const pit
 
                ++i;
                ++fi;
-
-               // add the auto-hfill from label end to the body
-               if (body_pos && i == body_pos) {
-                       FontMetrics const & fm = theFontMetrics(text_->labelFont(par));
-                       pos_type j = i;
-                       if (!row.empty()
-                           && row.back().type == Row::SEPARATOR) {
-                               row.pop_back();
-                               --j;
-                       }
-                       int const add = max(fm.width(par.layout().labelsep),
-                                           labelEnd(pit) - row.width());
-                       row.addSpace(j, add, *fi, par.lookupChange(i));
-               }
-
        }
-
        row.finalizeLast();
        row.endpos(i);
-       // if the row is too large, try to cut at last separator.
-       row.shorten_if_needed(body_pos, width);
 
-       // if the row ends with a separator that is not at end of
-       // paragraph, remove it
-       if (!row.empty() && row.back().type == Row::SEPARATOR
-           && row.endpos() < par.size())
-               row.pop_back();
+       // End of paragraph marker
+       if (lyxrc.paragraph_markers
+           && i == end && size_type(pit + 1) < pars.size()) {
+               // add a virtual element for the end-of-paragraph
+               // marker; it is shown on screen, but does not exist
+               // in the paragraph.
+               Font f(text_->layoutFont(pit));
+               f.fontInfo().setColor(Color_paragraphmarker);
+               BufferParams const & bparams
+                       = text_->inset().buffer().params();
+               f.setLanguage(par.getParLanguage(bparams));
+               row.addVirtual(end, docstring(1, char_type(0x00B6)), f, Change());
+       }
+
+       // if the row is too large, try to cut at last separator.
+       row.shortenIfNeeded(body_pos, width);
 
        // make sure that the RTL elements are in reverse ordering
        row.reverseRTL(text_->isRTL(par));
-
-       row.dimension().wid += right_margin;
 }
 
 
@@ -1114,46 +1084,46 @@ void TextMetrics::setRowHeight(Row & row, pit_type const pit,
 // x is an absolute screen coord
 // returns the column near the specified x-coordinate of the row
 // x is set to the real beginning of this column
-pos_type TextMetrics::getColumnNearX(pit_type const pit,
-               Row const & row, int & x, bool & boundary) const
+pos_type TextMetrics::getPosNearX(Row const & row, int & x,
+                                 bool & boundary) const
 {
-
        /// For the main Text, it is possible that this pit is not
        /// yet in the CoordCache when moving cursor up.
        /// x Paragraph coordinate is always 0 for main text anyway.
        int const xo = origin_.x_;
        x -= xo;
-#ifdef KEEP_OLD_METRICS_CODE
-       int const x_orig = x;
-#endif
 
        pos_type pos = row.pos();
        boundary = false;
-       if (row.x >= x || row.empty())
-               x = row.x;
-       else if (x >= row.width() - row.right_margin) {
-               x = row.width() - row.right_margin;
-               pos = row.back().endpos;
+       if (row.empty())
+               x = row.left_margin;
+       else if (x <= row.left_margin) {
+               pos = row.front().left_pos();
+               x = row.left_margin;
+       } else if (x >= row.width()) {
+               pos = row.back().right_pos();
+               x = row.width();
        } else {
-               double w = row.x;
+               double w = row.left_margin;
                Row::const_iterator cit = row.begin();
                Row::const_iterator cend = row.end();
                for ( ; cit != cend; ++cit) {
-                       if (w <= x &&  w + cit->width() > x) {
-                               double x_offset = x - w;
+                       if (w <= x &&  w + cit->full_width() > x) {
+                               int x_offset = int(x - w);
                                pos = cit->x2pos(x_offset);
-                               x = x_offset + w;
+                               x = int(x_offset + w);
                                break;
                        }
-                       w += cit->width();
+                       w += cit->full_width();
+               }
+               if (cit == row.end()) {
+                       pos = row.back().right_pos();
+                       x = row.width();
                }
-               if (cit == row.end())
-                       lyxerr << "NOT FOUND!! x=" << x
-                              << ", wid=" << row.width() << endl;
                /** This tests for the case where the cursor is placed
                 * just before a font direction change. See comment on
                 * the boundary_ member in DocIterator.h to understand
-                * how bounddary helps here.
+                * how boundary helps here.
                 */
                else if (pos == cit->endpos
                         && cit + 1 != row.end()
@@ -1162,146 +1132,17 @@ pos_type TextMetrics::getColumnNearX(pit_type const pit,
        }
 
        /** This tests for the case where the cursor is set at the end
-        * of a row which has been broken due to a display inset on
-        * next row. This is indicated by Row::right_boundary.
+        * of a row which has been broken due something else than a
+        * separator (a display inset or a forced breaking of the
+        * row). We know that there is a separator when the end of the
+        * row is larger than the end of its last element.
         */
        if (!row.empty() && pos == row.back().endpos
            && row.back().endpos == row.endpos())
-               boundary = row.right_boundary();
+               boundary = true;
 
        x += xo;
-#if !defined(KEEP_OLD_METRICS_CODE)
-       return pos - row.pos();
-#else
-       Buffer const & buffer = bv_->buffer();
-
-       int x2 = x_orig;
-       Paragraph const & par = text_->getPar(pit);
-       Bidi bidi;
-       bidi.computeTables(par, buffer, row);
-
-       pos_type vc = row.pos();
-       pos_type const end = row.endpos();
-       pos_type c = 0;
-       Layout const & layout = par.layout();
-
-       bool left_side = false;
-
-       pos_type body_pos = par.beginOfBody();
-
-       double tmpx = row.x;
-       double last_tmpx = tmpx;
-
-       if (body_pos > 0 &&
-           (body_pos > end || !par.isLineSeparator(body_pos - 1)))
-               body_pos = 0;
-
-       // check for empty row
-       if (vc == end) {
-               x2 = int(tmpx) + xo;
-               return 0;
-       }
-
-       // This (rtl_support test) is not needed, but gives
-       // some speedup if rtl_support == false
-       bool const lastrow = lyxrc.rtl_support && row.endpos() == par.size();
-
-       // If lastrow is false, we don't need to compute
-       // the value of rtl.
-       bool const rtl_on_lastrow = lastrow ? text_->isRTL(par) : false;
-
-       while (vc < end && tmpx <= x2) {
-               c = bidi.vis2log(vc);
-               last_tmpx = tmpx;
-               if (body_pos > 0 && c == body_pos - 1) {
-                       FontMetrics const & fm = theFontMetrics(
-                               text_->labelFont(par));
-                       tmpx += row.label_hfill + fm.width(layout.labelsep);
-                       if (par.isLineSeparator(body_pos - 1))
-                               tmpx -= singleWidth(pit, body_pos - 1);
-               }
-
-               tmpx += singleWidth(pit, c);
-               if (par.isSeparator(c) && c >= body_pos)
-                               tmpx += row.separator;
-               ++vc;
-       }
-
-       if ((tmpx + last_tmpx) / 2 > x2) {
-               tmpx = last_tmpx;
-               left_side = true;
-       }
-
-       // This shouldn't happen. But we can reset and try to continue.
-       LASSERT(vc <= end, vc = end);
-
-       bool boundary2 = false;
-
-       if (lastrow &&
-           ((rtl_on_lastrow  &&  left_side && vc == row.pos() && x2 < tmpx - 5) ||
-            (!rtl_on_lastrow && !left_side && vc == end  && x2 > tmpx + 5))) {
-               if (!par.isNewline(end - 1))
-                       c = end;
-       } else if (vc == row.pos()) {
-               c = bidi.vis2log(vc);
-               if (bidi.level(c) % 2 == 1)
-                       ++c;
-       } else {
-               c = bidi.vis2log(vc - 1);
-               bool const rtl = (bidi.level(c) % 2 == 1);
-               if (left_side == rtl) {
-                       ++c;
-                       boundary2 = isRTLBoundary(pit, c);
-               }
-       }
-
-// I believe this code is not needed anymore (Jug 20050717)
-#if 0
-       // The following code is necessary because the cursor position past
-       // the last char in a row is logically equivalent to that before
-       // the first char in the next row. That's why insets causing row
-       // divisions -- Newline and display-style insets -- must be treated
-       // specially, so cursor up/down doesn't get stuck in an air gap -- MV
-       // Newline inset, air gap below:
-       if (row.pos() < end && c >= end && par.isNewline(end - 1)) {
-               if (bidi.level(end -1) % 2 == 0)
-                       tmpx -= singleWidth(pit, end - 1);
-               else
-                       tmpx += singleWidth(pit, end - 1);
-               c = end - 1;
-       }
-
-       // Air gap above display inset:
-       if (row.pos() < end && c >= end && end < par.size()
-           && par.isInset(end) && par.getInset(end)->display()) {
-               c = end - 1;
-       }
-       // Air gap below display inset:
-       if (row.pos() < end && c >= end && par.isInset(end - 1)
-           && par.getInset(end - 1)->display()) {
-               c = end - 1;
-       }
-#endif
-
-       x2 = int(tmpx) + xo;
-       pos_type const col = c - row.pos();
-
-       if (abs(x2 - x) > 0.1 || boundary != boundary
-           || c != pos) {
-               lyxerr << "getColumnNearX: new=(x=" << x - xo << ", b=" << boundary << ", p=" << pos << "), "
-                      << "old=(x=" << x2 - xo << ", b=" << boundary2 << ", p=" << c << "), " << row;
-       }
-
-       if (!c || end == par.size())
-               return col;
-
-       if (c==end && !par.isLineSeparator(c-1) && !par.isNewline(c-1)) {
-               boundary2 = true;
-               return col;
-       }
-
-       return min(col, end - 1 - row.pos());
-#endif
+       return pos;
 }
 
 
@@ -1316,7 +1157,7 @@ pos_type TextMetrics::x2pos(pit_type pit, int row, int x) const
        LBUFERR(row < int(pm.rows().size()));
        bool bound = false;
        Row const & r = pm.rows()[row];
-       return r.pos() + getColumnNearX(pit, r, x, bound);
+       return getPosNearX(r, x, bound);
 }
 
 
@@ -1476,10 +1317,9 @@ Inset * TextMetrics::editXY(Cursor & cur, int x, int y,
 
        if (!it) {
                // No inset, set position in the text
-               bool bound = false; // is modified by getColumnNearX
-               int xx = x; // is modified by getColumnNearX
-               cur.pos() = row.pos()
-                       + getColumnNearX(pit, row, xx, bound);
+               bool bound = false; // is modified by getPosNearX
+               int xx = x; // is modified by getPosNearX
+               cur.pos() = getPosNearX(row, xx, bound);
                cur.boundary(bound);
                cur.setCurrentFont();
                cur.setTargetX(xx);
@@ -1530,7 +1370,7 @@ void TextMetrics::setCursorFromCoordinates(Cursor & cur, int const x, int const
 
        bool bound = false;
        int xx = x;
-       pos_type const pos = row.pos() + getColumnNearX(pit, row, xx, bound);
+       pos_type const pos = getPosNearX(row, xx, bound);
 
        LYXERR(Debug::DEBUG, "setting cursor pit: " << pit << " pos: " << pos);
 
@@ -1596,196 +1436,52 @@ int TextMetrics::cursorX(CursorSlice const & sl,
                bool boundary) const
 {
        LASSERT(sl.text() == text_, return 0);
-       pit_type const pit = sl.pit();
-       pos_type pos = sl.pos();
 
-       ParagraphMetrics const & pm = par_metrics_[pit];
+       ParagraphMetrics const & pm = par_metrics_[sl.pit()];
        if (pm.rows().empty())
                return 0;
        Row const & row = pm.getRow(sl.pos(), boundary);
-
-       double x = row.x;
+       pos_type const pos = sl.pos();
 
        /**
-        * When boundary is true, position is on the row element (pos, endpos)
+        * When boundary is true, position i is in the row element (pos, endpos)
         * if
-        *    pos < pos <= endpos
+        *    pos < i <= endpos
         * whereas, when boundary is false, the test is
-        *    pos <= pos < endpos
+        *    pos <= i < endpos
         * The correction below allows to handle both cases.
        */
        int const boundary_corr = (boundary && pos) ? -1 : 0;
 
+       /** Early return in trivial cases
+        * 1) the row is empty
+        * 2) the position is the left-most position of the row; there
+        * is a quirck herehowever: if the first element is virtual
+        * (end-of-par marker for example), then we have to look
+        * closer
+        */
        if (row.empty()
-           || (row.begin()->font.isRightToLeft()
-               && pos == row.begin()->endpos))
-               return int(x);
+           || (pos == row.begin()->left_pos()
+               && pos != row.begin()->right_pos()))
+               return row.left_margin;
 
        Row::const_iterator cit = row.begin();
+       double x = row.left_margin;
        for ( ; cit != row.end() ; ++cit) {
+               /** Look whether the cursor is inside the element's
+                * span. Note that it is necessary to take the
+                * boundary in account, and to accept virtual
+                * elements, which have pos == endpos.
+                */
                if (pos + boundary_corr >= cit->pos
-                   && pos + boundary_corr < cit->endpos) {
+                   && (pos + boundary_corr < cit->endpos
+                       || cit->pos == cit->endpos)) {
                                x += cit->pos2x(pos);
                                break;
                }
-               x += cit->width();
-       }
-
-       if (cit == row.end()
-           && (row.back().font.isRightToLeft() || pos != row.back().endpos))
-               lyxerr << "NOT FOUND!"
-                      << "pos=" << pos << "(" << boundary_corr << ")" << "\n"
-                      << row;
-
-#ifdef KEEP_OLD_METRICS_CODE
-       Paragraph const & par = text_->paragraphs()[pit];
-
-       // Correct position in front of big insets
-       bool const boundary_correction = pos != 0 && boundary;
-       if (boundary_correction)
-               --pos;
-
-       pos_type cursor_vpos = 0;
-
-       Buffer const & buffer = bv_->buffer();
-       double x2 = row.x;
-       Bidi bidi;
-       bidi.computeTables(par, buffer, row);
-
-       pos_type const row_pos  = row.pos();
-       pos_type const end      = row.endpos();
-       // Spaces at logical line breaks in bidi text must be skipped during
-       // cursor positioning. However, they may appear visually in the middle
-       // of a row; they must be skipped, wherever they are...
-       // * logically "abc_[HEBREW_\nHEBREW]"
-       // * visually "abc_[_WERBEH\nWERBEH]"
-       pos_type skipped_sep_vpos = -1;
-
-       if (end <= row_pos)
-               cursor_vpos = row_pos;
-       else if (pos >= end)
-               cursor_vpos = text_->isRTL(par) ? row_pos : end;
-       else if (pos > row_pos && pos >= end)
-               //FIXME: this code is never reached!
-               //       (see http://www.lyx.org/trac/changeset/8251)
-               // Place cursor after char at (logical) position pos - 1
-               cursor_vpos = (bidi.level(pos - 1) % 2 == 0)
-                       ? bidi.log2vis(pos - 1) + 1 : bidi.log2vis(pos - 1);
-       else
-               // Place cursor before char at (logical) position pos
-               cursor_vpos = (bidi.level(pos) % 2 == 0)
-                       ? bidi.log2vis(pos) : bidi.log2vis(pos) + 1;
-
-       pos_type body_pos = par.beginOfBody();
-       if (body_pos > 0 &&
-           (body_pos > end || !par.isLineSeparator(body_pos - 1)))
-               body_pos = 0;
-
-       // check for possible inline completion in this row
-       DocIterator const & inlineCompletionPos = bv_->inlineCompletionPos();
-       pos_type inlineCompletionVPos = -1;
-       if (inlineCompletionPos.inTexted()
-           && inlineCompletionPos.text() == text_
-           && inlineCompletionPos.pit() == pit
-           && inlineCompletionPos.pos() - 1 >= row_pos
-           && inlineCompletionPos.pos() - 1 < end) {
-               // draw logically behind the previous character
-               inlineCompletionVPos = bidi.log2vis(inlineCompletionPos.pos() - 1);
-       }
-
-       // Use font span to speed things up, see below
-       FontSpan font_span;
-       Font font;
-
-       // If the last logical character is a separator, skip it, unless
-       // it's in the last row of a paragraph; see skipped_sep_vpos declaration
-       if (end > 0 && end < par.size() && par.isSeparator(end - 1))
-               skipped_sep_vpos = bidi.log2vis(end - 1);
-
-       if (lyxrc.paragraph_markers && text_->isRTL(par)) {
-               ParagraphList const & pars_ = text_->paragraphs();
-               if (size_type(pit + 1) < pars_.size()) {
-                       FontInfo f(text_->layoutFont(pit));
-                       docstring const s = docstring(1, char_type(0x00B6));
-                       x2 += theFontMetrics(f).width(s);
-               }
+               x += cit->full_width();
        }
 
-       // Inline completion RTL special case row_pos == cursor_pos:
-       // "__|b" => cursor_pos is right of __
-       if (row_pos == inlineCompletionVPos && row_pos == cursor_vpos) {
-               font = displayFont(pit, row_pos + 1);
-               docstring const & completion = bv_->inlineCompletion();
-               if (font.isRightToLeft() && completion.length() > 0)
-                       x2 += theFontMetrics(font.fontInfo()).width(completion);
-       }
-
-       for (pos_type vpos = row_pos; vpos < cursor_vpos; ++vpos) {
-               // Skip the separator which is at the logical end of the row
-               if (vpos == skipped_sep_vpos)
-                       continue;
-               pos_type pos = bidi.vis2log(vpos);
-               if (body_pos > 0 && pos == body_pos - 1) {
-                       FontMetrics const & labelfm = theFontMetrics(
-                               text_->labelFont(par));
-                       x2 += row.label_hfill + labelfm.width(par.layout().labelsep);
-                       if (par.isLineSeparator(body_pos - 1))
-                               x2 -= singleWidth(pit, body_pos - 1);
-               }
-
-               // Use font span to speed things up, see above
-               if (pos < font_span.first || pos > font_span.last) {
-                       font_span = par.fontSpan(pos);
-                       font = displayFont(pit, pos);
-               }
-
-               x2 += pm.singleWidth(pos, font);
-
-               // Inline completion RTL case:
-               // "a__|b", __ of b => non-boundary a-pos is right of __
-               if (vpos + 1 == inlineCompletionVPos
-                   && (vpos + 1 < cursor_vpos || !boundary_correction)) {
-                       font = displayFont(pit, vpos + 1);
-                       docstring const & completion = bv_->inlineCompletion();
-                       if (font.isRightToLeft() && completion.length() > 0)
-                               x2 += theFontMetrics(font.fontInfo()).width(completion);
-               }
-
-               //  Inline completion LTR case:
-               // "b|__a", __ of b => non-boundary a-pos is in front of __
-               if (vpos == inlineCompletionVPos
-                   && (vpos + 1 < cursor_vpos || boundary_correction)) {
-                       font = displayFont(pit, vpos);
-                       docstring const & completion = bv_->inlineCompletion();
-                       if (!font.isRightToLeft() && completion.length() > 0)
-                               x2 += theFontMetrics(font.fontInfo()).width(completion);
-               }
-
-               if (par.isSeparator(pos) && pos >= body_pos)
-                       x2 += row.separator;
-       }
-
-       // see correction above
-       if (boundary_correction) {
-               if (isRTL(sl, boundary))
-                       x2 -= singleWidth(pit, pos);
-               else
-                       x2 += singleWidth(pit, pos);
-       }
-
-       if (abs(x2 - x) > 0.01) {
-               lyxerr << "cursorX: x2=" << x2 << ", x=" << x;
-               if (cit == row.end())
-                       lyxerr << "Element not found for "
-                              << pos - boundary_corr << "(" << boundary_corr << ")";
-               else
-                       lyxerr << " in [" << cit->pos << "/"
-                              << pos - boundary_corr << "(" << boundary_corr << ")"
-                              << "/" << cit->endpos << "] of " << *cit << "\n";
-               lyxerr << row <<endl;
-       }
-#endif
-
        return int(x);
 }
 
@@ -1838,7 +1534,8 @@ bool TextMetrics::cursorEnd(Cursor & cur)
        bool boundary = false;
        if (end != cur.lastpos()) {
                if (!cur.paragraph().isLineSeparator(end-1)
-                   && !cur.paragraph().isNewline(end-1))
+                   && !cur.paragraph().isNewline(end-1)
+                   && !cur.paragraph().isEnvSeparator(end-1))
                        boundary = true;
                else
                        --end;
@@ -1913,15 +1610,21 @@ int TextMetrics::leftMargin(int max_width,
        l_margin += theFontMetrics(buffer.params().getFont()).signedWidth(
                tclass.leftmargin());
 
-       if (par.getDepth() != 0) {
+       int depth = par.getDepth();
+       if (depth != 0) {
                // find the next level paragraph
                pit_type newpar = text_->outerHook(pit);
                if (newpar != pit_type(pars.size())) {
                        if (pars[newpar].layout().isEnvironment()) {
-                               l_margin = leftMargin(max_width, newpar);
+                               int nestmargin = depth * nestMargin();
+                               if (text_->isMainText())
+                                       nestmargin += changebarMargin();
+                               l_margin = max(leftMargin(max_width, newpar), nestmargin);
                                // Remove the parindent that has been added
                                // if the paragraph was empty.
-                               if (pars[newpar].empty()) {
+                               if (pars[newpar].empty() &&
+                                   buffer.params().paragraph_separation ==
+                                   BufferParams::ParagraphIndentSeparation) {
                                        docstring pi = pars[newpar].layout().parindent;
                                        l_margin -= theFontMetrics(
                                                buffer.params().getFont()).signedWidth(pi);
@@ -1939,10 +1642,16 @@ int TextMetrics::leftMargin(int max_width,
 
        // This happens after sections or environments in standard classes.
        // We have to check the previous layout at same depth.
-       if (tclass.isDefaultLayout(par.layout()) && pit > 0
-           && pars[pit - 1].getDepth() >= par.getDepth()) {
+       if (buffer.params().paragraph_separation ==
+                       BufferParams::ParagraphSkipSeparation)
+               parindent.erase();
+       else if (pit > 0 && pars[pit - 1].getDepth() >= par.getDepth()) {
                pit_type prev = text_->depthHook(pit, par.getDepth());
-               if (pars[prev < pit ? prev : pit - 1].layout().nextnoindent)
+               if (par.layout() == pars[prev].layout()) {
+                       if (prev != pit - 1
+                           && pars[pit - 1].layout().nextnoindent)
+                               parindent.erase();
+               } else if (pars[prev].layout().nextnoindent)
                        parindent.erase();
        }
 
@@ -2025,7 +1734,7 @@ int TextMetrics::leftMargin(int max_width,
        }
 
        if (!par.params().leftIndent().zero())
-               l_margin += par.params().leftIndent().inPixels(max_width);
+               l_margin += par.params().leftIndent().inPixels(max_width, labelfont_metrics.em());
 
        LyXAlignment align;
 
@@ -2069,15 +1778,6 @@ int TextMetrics::leftMargin(int max_width,
 }
 
 
-#ifdef KEEP_OLD_METRICS_CODE
-int TextMetrics::singleWidth(pit_type pit, pos_type pos) const
-{
-       ParagraphMetrics const & pm = par_metrics_[pit];
-
-       return pm.singleWidth(pos, displayFont(pit, pos));
-}
-#endif
-
 void TextMetrics::draw(PainterInfo & pi, int x, int y) const
 {
        if (par_metrics_.empty())
@@ -2101,7 +1801,7 @@ void TextMetrics::draw(PainterInfo & pi, int x, int y) const
 }
 
 
-void TextMetrics::drawParagraph(PainterInfo & pi, pit_type pit, int x, int y) const
+void TextMetrics::drawParagraph(PainterInfo & pi, pit_type const pit, int const x, int y) const
 {
        BufferParams const & bparams = bv_->buffer().params();
        ParagraphMetrics const & pm = par_metrics_[pit];
@@ -2141,14 +1841,25 @@ void TextMetrics::drawParagraph(PainterInfo & pi, pit_type pit, int x, int y) co
        for (size_t i = 0; i != nrows; ++i) {
 
                Row const & row = pm.rows()[i];
+               int row_x = x;
                if (i)
                        y += row.ascent();
 
+               CursorSlice rowSlice(const_cast<InsetText &>(text_->inset()));
+               rowSlice.pit() = pit;
+               rowSlice.pos() = row.pos();
+
                bool const inside = (y + row.descent() >= 0
                        && y - row.ascent() < ww);
+
+               // Adapt to cursor row scroll offset if applicable.
+               if (bv_->currentRowSlice() == rowSlice)
+                       row_x -= bv_->horizScrollOffset();
+
                // It is not needed to draw on screen if we are not inside.
                pi.pain.setDrawingEnabled(inside && original_drawing_state);
-               RowPainter rp(pi, *text_, pit, row, x, y);
+
+               RowPainter rp(pi, *text_, pit, row, row_x, y);
 
                if (selection)
                        row.setSelectionAndMargins(sel_beg_par, sel_end_par);
@@ -2165,11 +1876,13 @@ void TextMetrics::drawParagraph(PainterInfo & pi, pit_type pit, int x, int y) co
                }
 
                // Row signature; has row changed since last paint?
-               row.setCrc(pm.computeRowSignature(row, bparams));
-               bool row_has_changed = row.changed();
+               if (pi.pain.isDrawingEnabled())
+                       row.setCrc(pm.computeRowSignature(row, bparams));
+               bool row_has_changed = row.changed()
+                       || rowSlice == bv_->lastRowSlice();
 
                // Take this opportunity to spellcheck the row contents.
-               if (row_has_changed && lyxrc.spellcheck_continuously) {
+               if (row_has_changed && pi.do_spellcheck && lyxrc.spellcheck_continuously) {
                        text_->getPar(pit).spellCheck();
                }
 
@@ -2186,7 +1899,10 @@ void TextMetrics::drawParagraph(PainterInfo & pi, pit_type pit, int x, int y) co
                // Clear background of this row if paragraph background was not
                // already cleared because of a full repaint.
                if (!pi.full_repaint && row_has_changed) {
-                       pi.pain.fillRectangle(x, y - row.ascent(),
+                       LYXERR(Debug::PAINTING, "Clear rect@("
+                              << max(row_x, 0) << ", " << y - row.ascent() << ")="
+                              << width() << " x " << row.height());
+                       pi.pain.fillRectangle(max(row_x, 0), y - row.ascent(),
                                width(), row.height(), pi.background_color);
                }
 
@@ -2199,7 +1915,8 @@ void TextMetrics::drawParagraph(PainterInfo & pi, pit_type pit, int x, int y) co
                        LYXERR(Debug::PAINTING, foreword << "pit=" << pit << " row=" << i
                                << " row_selection="    << row.selection()
                                << " full_repaint="     << pi.full_repaint
-                               << " row_has_changed="  << row_has_changed);
+                               << " row_has_changed="  << row_has_changed
+                               << " drawingEnabled=" << pi.pain.isDrawingEnabled());
                }
 
                // Backup full_repaint status and force full repaint
@@ -2221,6 +1938,8 @@ void TextMetrics::drawParagraph(PainterInfo & pi, pit_type pit, int x, int y) co
                        rp.paintLast();
                if (i == 0 && is_rtl)
                        rp.paintFirst();
+               rp.paintTooLargeMarks(row_x < 0,
+                                     row_x + row.width() > bv_->workWidth());
                y += row.descent();
 
                // Restore full_repaint status.
@@ -2265,15 +1984,6 @@ void TextMetrics::completionPosAndDim(Cursor const & cur, int & x, int & y,
        //lyxerr << " wordstart=" << wordStart << " bvcur=" << bvcur << " cur=" << cur << std::endl;
 }
 
-//int TextMetrics::pos2x(pit_type pit, pos_type pos) const
-//{
-//     ParagraphMetrics const & pm = par_metrics_[pit];
-//     Row const & r = pm.rows()[row];
-//     int x = 0;
-//     pos -= r.pos();
-//}
-
-
 int defaultRowHeight()
 {
        return int(theFontMetrics(sane_font).maxHeight() *  1.2);