]> git.lyx.org Git - lyx.git/blobdiff - src/TextMetrics.cpp
Check path of Qt tools if qtchooser is detected
[lyx.git] / src / TextMetrics.cpp
index 80ee0aac7fca9c731623bb4568bca4b551391c6b..c7ccbac7fc2b9fea453c40c44f54d4ebb3a26e77 100644 (file)
@@ -48,6 +48,7 @@
 #include "support/debug.h"
 #include "support/lassert.h"
 
+#include <stdlib.h>
 #include <cmath>
 
 using namespace std;
@@ -437,6 +438,7 @@ bool TextMetrics::redoParagraph(pit_type const pit)
        par.setBeginOfBody();
        pos_type first = 0;
        size_t row_index = 0;
+       bool need_new_row = false;
        // maximum pixel width of a row
        do {
                if (row_index == pm.rows().size())
@@ -444,8 +446,9 @@ bool TextMetrics::redoParagraph(pit_type const pit)
                Row & row = pm.rows()[row_index];
                row.pit(pit);
                row.pos(first);
-               breakRow(row, right_margin, pit);
-               setRowHeight(row, pit);
+               row.pit(pit);
+               need_new_row = breakRow(row, right_margin);
+               setRowHeight(row);
                row.setChanged(false);
                if (row_index || row.endpos() < par.size()
                    || (row.right_boundary() && par.inInset().lyxCode() != CELL_CODE)) {
@@ -462,32 +465,44 @@ bool TextMetrics::redoParagraph(pit_type const pit)
                                dim_.wid = max_width_;
                }
                int const max_row_width = max(dim_.wid, row.width());
-               computeRowMetrics(pit, row, max_row_width);
+               computeRowMetrics(row, max_row_width);
                first = row.endpos();
                ++row_index;
 
                pm.dim().wid = max(pm.dim().wid, row.width());
                pm.dim().des += row.height();
-       } while (first < par.size());
+       } while (first < par.size() || need_new_row);
 
        if (row_index < pm.rows().size())
                pm.rows().resize(row_index);
 
-       // Make sure that if a par ends in newline, there is one more row
-       // under it
-       if (first > 0 && par.isNewline(first - 1)) {
-               if (row_index == pm.rows().size())
-                       pm.rows().push_back(Row());
-               Row & row = pm.rows()[row_index];
-               row.pos(first);
-               breakRow(row, right_margin, pit);
-               setRowHeight(row, pit);
-               row.setChanged(false);
-               int const max_row_width = max(dim_.wid, row.width());
-               computeRowMetrics(pit, row, max_row_width);
-               pm.dim().des += row.height();
+       // FIXME: It might be better to move this in another method
+       // specially tailored for the main text.
+       // Top and bottom margin of the document (only at top-level)
+       if (text_->isMainText()) {
+               if (pit == 0) {
+                       pm.rows().front().dimension().asc += 20;
+                       /* coverity[copy_paste_error]: coverity thinks that we
+                        * should update pm.dim().asc below, but all the rows
+                        * heights are actually counted as part of the paragraph metric
+                        * descent see loop above).
+                        */
+                       pm.dim().des += 20;
+               }
+               ParagraphList const & pars = text_->paragraphs();
+               if (pit + 1 == pit_type(pars.size())) {
+                       pm.rows().back().dimension().des += 20;
+                       pm.dim().des += 20;
+               }
        }
 
+       // The space above and below the paragraph.
+       int const top = parTopSpacing(pit);
+       pm.rows().front().dimension().asc += top;
+       int const bottom = parBottomSpacing(pit);
+       pm.rows().back().dimension().des += bottom;
+       pm.dim().des += top + bottom;
+
        pm.dim().asc += pm.rows()[0].ascent();
        pm.dim().des -= pm.rows()[0].ascent();
 
@@ -562,13 +577,12 @@ LyXAlignment TextMetrics::getAlign(Paragraph const & par, Row const & row) const
 }
 
 
-void TextMetrics::computeRowMetrics(pit_type const pit,
-               Row & row, int width) const
+void TextMetrics::computeRowMetrics(Row & row, int width) const
 {
        row.label_hfill = 0;
        row.separator = 0;
 
-       Paragraph const & par = text_->getPar(pit);
+       Paragraph const & par = text_->getPar(row.pit());
 
        int const w = width - row.right_margin - row.width();
        // FIXME: put back this assertion when the crash on new doc is solved.
@@ -592,11 +606,11 @@ void TextMetrics::computeRowMetrics(pit_type const pit,
                        ++nlh;
 
                if (nlh && !par.getLabelWidthString().empty())
-                       row.label_hfill = labelFill(pit, row) / double(nlh);
+                       row.label_hfill = labelFill(row) / double(nlh);
        }
 
        // are there any hfills in the row?
-       ParagraphMetrics & pm = par_metrics_[pit];
+       ParagraphMetrics & pm = par_metrics_[row.pit()];
        int nh = numberOfHfills(row, pm, par.beginOfBody());
        int hfill = 0;
        int hfill_rem = 0;
@@ -673,9 +687,9 @@ void TextMetrics::computeRowMetrics(pit_type const pit,
 }
 
 
-int TextMetrics::labelFill(pit_type const pit, Row const & row) const
+int TextMetrics::labelFill(Row const & row) const
 {
-       Paragraph const & par = text_->getPar(pit);
+       Paragraph const & par = text_->getPar(row.pit());
        LBUFERR(par.beginOfBody() > 0 || par.isEnvSeparator(0));
 
        int w = 0;
@@ -786,9 +800,9 @@ private:
  * very sensitive to small changes :) Note that part of the
  * intelligence is also in Row::shortenIfNeeded.
  */
-void TextMetrics::breakRow(Row & row, int const right_margin, pit_type const pit) const
+bool TextMetrics::breakRow(Row & row, int const right_margin) const
 {
-       Paragraph const & par = text_->getPar(pit);
+       Paragraph const & par = text_->getPar(row.pit());
        pos_type const end = par.size();
        pos_type const pos = row.pos();
        pos_type const body_pos = par.beginOfBody();
@@ -796,7 +810,7 @@ void TextMetrics::breakRow(Row & row, int const right_margin, pit_type const pit
        bool need_new_row = false;
 
        row.clear();
-       row.left_margin = leftMargin(max_width_, pit, pos);
+       row.left_margin = leftMargin(max_width_, row.pit(), pos);
        row.right_margin = right_margin;
        if (is_rtl)
                swap(row.left_margin, row.right_margin);
@@ -806,7 +820,10 @@ void TextMetrics::breakRow(Row & row, int const right_margin, pit_type const pit
        // the width available for the row.
        int const width = max_width_ - row.right_margin;
 
-       ParagraphList const & pars = text_->paragraphs();
+       if (pos >= end || row.width() > width) {
+               row.endpos(end);
+               return need_new_row;
+       }
 
 #if 0
        //FIXME: As long as leftMargin() is not correctly implemented for
@@ -819,13 +836,13 @@ void TextMetrics::breakRow(Row & row, int const right_margin, pit_type const pit
        // check for possible inline completion
        DocIterator const & ic_it = bv_->inlineCompletionPos();
        pos_type ic_pos = -1;
-       if (ic_it.inTexted() && ic_it.text() == text_ && ic_it.pit() == pit)
+       if (ic_it.inTexted() && ic_it.text() == text_ && ic_it.pit() == row.pit())
                ic_pos = ic_it.pos();
 
        // Now we iterate through until we reach the right margin
        // or the end of the par, then build a representation of the row.
        pos_type i = pos;
-       FontIterator fi = FontIterator(*this, par, pit, pos);
+       FontIterator fi = FontIterator(*this, par, row.pit(), pos);
        do {
                // this can happen for an empty row after a newline
                if (i >= end)
@@ -845,7 +862,7 @@ void TextMetrics::breakRow(Row & row, int const right_margin, pit_type const pit
                        // this is needed to make sure that the row width is correct
                        row.finalizeLast();
                        int const add = max(fm.width(par.layout().labelsep),
-                                           labelEnd(pit) - row.width());
+                                           labelEnd(row.pit()) - row.width());
                        row.addSpace(i, add, *fi, par.lookupChange(i));
                } else if (c == '\t')
                        row.addSpace(i, theFontMetrics(*fi).width(from_ascii("    ")),
@@ -900,12 +917,13 @@ void TextMetrics::breakRow(Row & row, int const right_margin, pit_type const pit
        row.endpos(i);
 
        // End of paragraph marker
+       ParagraphList const & pars = text_->paragraphs();
        if (lyxrc.paragraph_markers && !need_new_row
-           && i == end && size_type(pit + 1) < pars.size()) {
+           && i == end && size_type(row.pit() + 1) < pars.size()) {
                // add a virtual element for the end-of-paragraph
                // marker; it is shown on screen, but does not exist
                // in the paragraph.
-               Font f(text_->layoutFont(pit));
+               Font f(text_->layoutFont(row.pit()));
                f.fontInfo().setColor(Color_paragraphmarker);
                BufferParams const & bparams
                        = text_->inset().buffer().params();
@@ -916,187 +934,145 @@ void TextMetrics::breakRow(Row & row, int const right_margin, pit_type const pit
        // if the row is too large, try to cut at last separator. In case
        // of success, reset indication that the row was broken abruptly.
        if (row.shortenIfNeeded(body_pos, width))
-               row.right_boundary(false);
+               row.right_boundary(!row.empty() && row.back().endpos == row.endpos());
 
        // make sure that the RTL elements are in reverse ordering
        row.reverseRTL(is_rtl);
        //LYXERR0("breakrow: row is " << row);
-}
 
+       return need_new_row;
+}
 
-void TextMetrics::setRowHeight(Row & row, pit_type const pit,
-                                   bool topBottomSpace) const
+int TextMetrics::parTopSpacing(pit_type const pit) const
 {
        Paragraph const & par = text_->getPar(pit);
-       // get the maximum ascent and the maximum descent
-       double layoutasc = 0;
-       double layoutdesc = 0;
-       double const dh = defaultRowHeight();
-
-       // ok, let us initialize the maxasc and maxdesc value.
-       // Only the fontsize count. The other properties
-       // are taken from the layoutfont. Nicer on the screen :)
        Layout const & layout = par.layout();
 
-       // as max get the first character of this row then it can
-       // increase but not decrease the height. Just some point to
-       // start with so we don't have to do the assignment below too
-       // often.
-       Buffer const & buffer = bv_->buffer();
-       Font font = displayFont(pit, row.pos());
-       FontSize const tmpsize = font.fontInfo().size();
-       font.fontInfo() = text_->layoutFont(pit);
-       FontSize const size = font.fontInfo().size();
-       font.fontInfo().setSize(tmpsize);
+       int asc = 0;
+       ParagraphList const & pars = text_->paragraphs();
+       double const dh = defaultRowHeight();
 
-       FontInfo labelfont = text_->labelFont(par);
+       BufferParams const & bparams = bv_->buffer().params();
+       Inset const & inset = text_->inset();
+       // some parskips VERY EASY IMPLEMENTATION
+       if (bparams.paragraph_separation == BufferParams::ParagraphSkipSeparation
+               && !inset.getLayout().parbreakIsNewline()
+               && !par.layout().parbreak_is_newline
+               && pit > 0
+               && ((layout.isParagraph() && par.getDepth() == 0)
+                   || (pars[pit - 1].layout().isParagraph()
+                       && pars[pit - 1].getDepth() == 0))) {
+               asc += bparams.getDefSkip().inPixels(*bv_);
+       }
 
-       FontMetrics const & lfm = theFontMetrics(labelfont);
-       FontMetrics const & fm = theFontMetrics(font);
+       if (par.params().startOfAppendix())
+               asc += int(3 * dh);
+
+       // special code for the top label
+       if (layout.labelIsAbove()
+           && (!layout.isParagraphGroup() || text_->isFirstInSequence(pit))
+           && !par.labelString().empty()) {
+               FontInfo labelfont = text_->labelFont(par);
+               FontMetrics const & lfm = theFontMetrics(labelfont);
+               asc += int(lfm.maxHeight() * layout.spacing.getValue()
+                                          * text_->spacing(par)
+                          + (layout.topsep + layout.labelbottomsep) * dh);
+       }
 
-       // these are minimum values
-       double const spacing_val = layout.spacing.getValue()
-               * text_->spacing(par);
-       //lyxerr << "spacing_val = " << spacing_val << endl;
-       int maxasc  = int(fm.maxAscent()  * spacing_val);
-       int maxdesc = int(fm.maxDescent() * spacing_val);
+       // Add the layout spaces, for example before and after
+       // a section, or between the items of a itemize or enumerate
+       // environment.
 
-       // insets may be taller
-       CoordCache::Insets const & insetCache = bv_->coordCache().getInsets();
-       Row::const_iterator cit = row.begin();
-       Row::const_iterator cend = row.end();
-       for ( ; cit != cend; ++cit) {
-               if (cit->inset) {
-                       Dimension const & dim = insetCache.dim(cit->inset);
-                       maxasc  = max(maxasc,  dim.ascent());
-                       maxdesc = max(maxdesc, dim.descent());
-               }
+       pit_type prev = text_->depthHook(pit, par.getDepth());
+       Paragraph const & prevpar = pars[prev];
+       double layoutasc = 0;
+       if (prev != pit
+           && prevpar.layout() == layout
+           && prevpar.getDepth() == par.getDepth()
+           && prevpar.getLabelWidthString() == par.getLabelWidthString()) {
+               layoutasc = layout.itemsep * dh;
+       } else if (pit != 0 && layout.topsep > 0)
+               layoutasc = layout.topsep * dh;
+
+       asc += int(layoutasc * 2 / (2 + pars[pit].getDepth()));
+
+       prev = text_->outerHook(pit);
+       if (prev != pit_type(pars.size())) {
+               asc += int(pars[prev].layout().parsep * dh);
+       } else if (pit != 0) {
+               Paragraph const & prevpar = pars[pit - 1];
+               if (prevpar.getDepth() != 0 || prevpar.layout() == layout)
+                       asc += int(layout.parsep * dh);
        }
 
-       // Check if any custom fonts are larger (Asger)
-       // This is not completely correct, but we can live with the small,
-       // cosmetic error for now.
-       int labeladdon = 0;
-
-       FontSize maxsize =
-               par.highestFontInRange(row.pos(), row.endpos(), size);
-       if (maxsize > font.fontInfo().size()) {
-               // use standard paragraph font with the maximal size
-               FontInfo maxfont = font.fontInfo();
-               maxfont.setSize(maxsize);
-               FontMetrics const & maxfontmetrics = theFontMetrics(maxfont);
-               maxasc  = max(maxasc,  maxfontmetrics.maxAscent());
-               maxdesc = max(maxdesc, maxfontmetrics.maxDescent());
-       }
+       return asc;
+}
 
-       // This is nicer with box insets:
-       ++maxasc;
-       ++maxdesc;
 
+int TextMetrics::parBottomSpacing(pit_type const pit) const
+{
+       double layoutdesc = 0;
        ParagraphList const & pars = text_->paragraphs();
-       Inset const & inset = text_->inset();
+       double const dh = defaultRowHeight();
 
-       // is it a top line?
-       if (row.pos() == 0 && topBottomSpace) {
-               BufferParams const & bufparams = buffer.params();
-               // some parskips VERY EASY IMPLEMENTATION
-               if (bufparams.paragraph_separation == BufferParams::ParagraphSkipSeparation
-                   && !inset.getLayout().parbreakIsNewline()
-                   && !par.layout().parbreak_is_newline
-                   && pit > 0
-                   && ((layout.isParagraph() && par.getDepth() == 0)
-                       || (pars[pit - 1].layout().isParagraph()
-                           && pars[pit - 1].getDepth() == 0))) {
-                       maxasc += bufparams.getDefSkip().inPixels(*bv_);
+       // add the layout spaces, for example before and after
+       // a section, or between the items of a itemize or enumerate
+       // environment
+       pit_type nextpit = pit + 1;
+       if (nextpit != pit_type(pars.size())) {
+               pit_type cpit = pit;
+
+               if (pars[cpit].getDepth() > pars[nextpit].getDepth()) {
+                       double usual = pars[cpit].layout().bottomsep * dh;
+                       double unusual = 0;
+                       cpit = text_->depthHook(cpit, pars[nextpit].getDepth());
+                       if (pars[cpit].layout() != pars[nextpit].layout()
+                               || pars[nextpit].getLabelWidthString() != pars[cpit].getLabelWidthString())
+                               unusual = pars[cpit].layout().bottomsep * dh;
+                       layoutdesc = max(unusual, usual);
+               } else if (pars[cpit].getDepth() == pars[nextpit].getDepth()) {
+                       if (pars[cpit].layout() != pars[nextpit].layout()
+                               || pars[nextpit].getLabelWidthString() != pars[cpit].getLabelWidthString())
+                               layoutdesc = int(pars[cpit].layout().bottomsep * dh);
                }
+       }
 
-               if (par.params().startOfAppendix())
-                       maxasc += int(3 * dh);
-
-               // special code for the top label
-               if (layout.labelIsAbove()
-                   && (!layout.isParagraphGroup() || text_->isFirstInSequence(pit))
-                   && !par.labelString().empty()) {
-                       labeladdon = int(
-                                 lfm.maxHeight()
-                                       * layout.spacing.getValue()
-                                       * text_->spacing(par)
-                               + (layout.topsep + layout.labelbottomsep) * dh);
-               }
+       return int(layoutdesc * 2 / (2 + pars[pit].getDepth()));
+}
 
-               // Add the layout spaces, for example before and after
-               // a section, or between the items of a itemize or enumerate
-               // environment.
 
-               pit_type prev = text_->depthHook(pit, par.getDepth());
-               Paragraph const & prevpar = pars[prev];
-               if (prev != pit
-                   && prevpar.layout() == layout
-                   && prevpar.getDepth() == par.getDepth()
-                   && prevpar.getLabelWidthString()
-                                       == par.getLabelWidthString()) {
-                       layoutasc = layout.itemsep * dh;
-               } else if (pit != 0 || row.pos() != 0) {
-                       if (layout.topsep > 0)
-                               layoutasc = layout.topsep * dh;
-               }
+void TextMetrics::setRowHeight(Row & row) const
+{
+       Paragraph const & par = text_->getPar(row.pit());
+       Layout const & layout = par.layout();
+       double const spacing_val = layout.spacing.getValue() * text_->spacing(par);
 
-               prev = text_->outerHook(pit);
-               if (prev != pit_type(pars.size())) {
-                       maxasc += int(pars[prev].layout().parsep * dh);
-               } else if (pit != 0) {
-                       Paragraph const & prevpar = pars[pit - 1];
-                       if (prevpar.getDepth() != 0 ||
-                                       prevpar.layout() == layout) {
-                               maxasc += int(layout.parsep * dh);
-                       }
-               }
-       }
+       // Initial value for ascent (useful if row is empty).
+       Font const font = displayFont(row.pit(), row.pos());
+       FontMetrics const & fm = theFontMetrics(font);
+       int maxasc = int(fm.maxAscent() * spacing_val);
+       int maxdes = int(fm.maxDescent() * spacing_val);
 
-       // is it a bottom line?
-       if (row.endpos() >= par.size() && topBottomSpace) {
-               // add the layout spaces, for example before and after
-               // a section, or between the items of a itemize or enumerate
-               // environment
-               pit_type nextpit = pit + 1;
-               if (nextpit != pit_type(pars.size())) {
-                       pit_type cpit = pit;
-
-                       if (pars[cpit].getDepth() > pars[nextpit].getDepth()) {
-                               double usual = pars[cpit].layout().bottomsep * dh;
-                               double unusual = 0;
-                               cpit = text_->depthHook(cpit, pars[nextpit].getDepth());
-                               if (pars[cpit].layout() != pars[nextpit].layout()
-                                   || pars[nextpit].getLabelWidthString() != pars[cpit].getLabelWidthString())
-                                       unusual = pars[cpit].layout().bottomsep * dh;
-                               layoutdesc = max(unusual, usual);
-                       } else if (pars[cpit].getDepth() == pars[nextpit].getDepth()) {
-                               if (pars[cpit].layout() != pars[nextpit].layout()
-                                       || pars[nextpit].getLabelWidthString() != pars[cpit].getLabelWidthString())
-                                       layoutdesc = int(pars[cpit].layout().bottomsep * dh);
-                       }
+       // Find the ascent/descent of the row contents
+       Row::const_iterator cit = row.begin();
+       Row::const_iterator cend = row.end();
+       for ( ; cit != cend; ++cit) {
+               if (cit->inset) {
+                       maxasc = max(maxasc, cit->dim.ascent());
+                       maxdes = max(maxdes, cit->dim.descent());
+               } else {
+                       FontMetrics const & fm = theFontMetrics(cit->font);
+                       maxasc = max(maxasc, int(fm.maxAscent() * spacing_val));
+                       maxdes = max(maxdes, int(fm.maxDescent() * spacing_val));
                }
        }
 
-       // incalculate the layout spaces
-       maxasc  += int(layoutasc  * 2 / (2 + pars[pit].getDepth()));
-       maxdesc += int(layoutdesc * 2 / (2 + pars[pit].getDepth()));
-
-       // FIXME: the correct way is to do the following is to move the
-       // following code in another method specially tailored for the
-       // main Text. The following test is thus bogus.
-       // Top and bottom margin of the document (only at top-level)
-       if (text_->isMainText() && topBottomSpace) {
-               if (pit == 0 && row.pos() == 0)
-                       maxasc += 20;
-               if (pit + 1 == pit_type(pars.size()) &&
-                   row.endpos() == par.size() &&
-                               !(row.endpos() > 0 && par.isNewline(row.endpos() - 1)))
-                       maxdesc += 20;
-       }
+       // This is nicer with box insets
+       ++maxasc;
+       ++maxdes;
 
-       row.dimension().asc = maxasc + labeladdon;
-       row.dimension().des = maxdesc;
+       row.dimension().asc = maxasc;
+       row.dimension().des = maxdes;
 }
 
 
@@ -1629,17 +1605,17 @@ void TextMetrics::deleteLineForward(Cursor & cur)
 }
 
 
-bool TextMetrics::isLastRow(pit_type pit, Row const & row) const
+bool TextMetrics::isLastRow(Row const & row) const
 {
        ParagraphList const & pars = text_->paragraphs();
-       return row.endpos() >= pars[pit].size()
-               && pit + 1 == pit_type(pars.size());
+       return row.endpos() >= pars[row.pit()].size()
+               && row.pit() + 1 == pit_type(pars.size());
 }
 
 
-bool TextMetrics::isFirstRow(pit_type pit, Row const & row) const
+bool TextMetrics::isFirstRow(Row const & row) const
 {
-       return row.pos() == 0 && pit == 0;
+       return row.pos() == 0 && row.pit() == 0;
 }
 
 
@@ -1864,15 +1840,30 @@ void TextMetrics::draw(PainterInfo & pi, int x, int y) const
 
 void TextMetrics::drawParagraph(PainterInfo & pi, pit_type const pit, int const x, int y) const
 {
-       BufferParams const & bparams = bv_->buffer().params();
        ParagraphMetrics const & pm = par_metrics_[pit];
        if (pm.rows().empty())
                return;
-
-       bool const original_drawing_state = pi.pain.isDrawingEnabled();
-       int const ww = bv_->workHeight();
        size_t const nrows = pm.rows().size();
 
+       // Use fast lane when drawing is disabled.
+       if (!pi.pain.isDrawingEnabled()) {
+               for (size_t i = 0; i != nrows; ++i) {
+
+                       Row const & row = pm.rows()[i];
+                       // Adapt to cursor row scroll offset if applicable.
+                       int row_x = x - bv_->horizScrollOffset(text_, pit, row.pos());
+                       if (i)
+                               y += row.ascent();
+
+                       RowPainter rp(pi, *text_, row, row_x, y);
+
+                       rp.paintOnlyInsets();
+                       y += row.descent();
+               }
+               return;
+       }
+
+       int const ww = bv_->workHeight();
        Cursor const & cur = bv_->cursor();
        DocIterator sel_beg = cur.selectionBegin();
        DocIterator sel_end = cur.selectionEnd();
@@ -1907,12 +1898,20 @@ void TextMetrics::drawParagraph(PainterInfo & pi, pit_type const pit, int const
                if (i)
                        y += row.ascent();
 
-               RowPainter rp(pi, *text_, pit, row, row_x, y);
+               RowPainter rp(pi, *text_, row, row_x, y);
 
+               // It is not needed to draw on screen if we are not inside.
                bool const inside = (y + row.descent() >= 0
                        && y - row.ascent() < ww);
-               // It is not needed to draw on screen if we are not inside.
-               pi.pain.setDrawingEnabled(inside && original_drawing_state);
+               pi.pain.setDrawingEnabled(inside);
+               if (!inside) {
+                       // Paint only the insets to set inset cache correctly
+                       // FIXME: remove paintOnlyInsets when we know that positions
+                       // have already been set.
+                       rp.paintOnlyInsets();
+                       y += row.descent();
+                       continue;
+               }
 
                if (selection)
                        row.setSelectionAndMargins(sel_beg_par, sel_end_par);
@@ -1929,8 +1928,7 @@ void TextMetrics::drawParagraph(PainterInfo & pi, pit_type const pit, int const
                }
 
                // Row signature; has row changed since last paint?
-               if (pi.pain.isDrawingEnabled())
-                       row.setCrc(pm.computeRowSignature(row, bparams));
+               row.setCrc(pm.computeRowSignature(row, *bv_));
                bool row_has_changed = row.changed()
                        || bv_->hadHorizScrollOffset(text_, pit, row.pos());
 
@@ -1961,7 +1959,7 @@ void TextMetrics::drawParagraph(PainterInfo & pi, pit_type const pit, int const
 
                // Instrumentation for testing row cache (see also
                // 12 lines lower):
-               if (lyxerr.debugging(Debug::PAINTING) && inside
+               if (lyxerr.debugging(Debug::PAINTING)
                        && (row.selection() || pi.full_repaint || row_has_changed)) {
                                string const foreword = text_->isMainText() ?
                                        "main text redraw " : "inset text redraw: ";
@@ -1999,7 +1997,7 @@ void TextMetrics::drawParagraph(PainterInfo & pi, pit_type const pit, int const
                pi.full_repaint = tmp;
        }
        // Re-enable screen drawing for future use of the painter.
-       pi.pain.setDrawingEnabled(original_drawing_state);
+       pi.pain.setDrawingEnabled(true);
 
        //LYXERR(Debug::PAINTING, ".");
 }
@@ -2015,18 +2013,19 @@ void TextMetrics::completionPosAndDim(Cursor const & cur, int & x, int & y,
        DocIterator wordStart = bvcur;
        wordStart.pos() -= word.length();
 
-       // get position on screen of the word start and end
-       //FIXME: Is it necessary to explicitly set this to false?
-       wordStart.boundary(false);
-       Point lxy = cur.bv().getPos(wordStart);
-       Point rxy = cur.bv().getPos(bvcur);
-
        // calculate dimensions of the word
        Row row;
+       row.pit(bvcur.pit());
        row.pos(wordStart.pos());
        row.endpos(bvcur.pos());
-       setRowHeight(row, bvcur.pit(), false);
+       setRowHeight(row);
        dim = row.dimension();
+
+       // get position on screen of the word start and end
+       //FIXME: Is it necessary to explicitly set this to false?
+       wordStart.boundary(false);
+       Point lxy = cur.bv().getPos(wordStart);
+       Point rxy = cur.bv().getPos(bvcur);
        dim.wid = abs(rxy.x_ - lxy.x_);
 
        // calculate position of word