]> git.lyx.org Git - lyx.git/blobdiff - src/TextMetrics.cpp
Merge branch 'master' of git.lyx.org:lyx
[lyx.git] / src / TextMetrics.cpp
index 6e22bf7852cb692a7a28309145b0da6bf0530bc2..b40cb5553010a2d298a2842b5d5ae7d1236a2dad 100644 (file)
@@ -19,7 +19,6 @@
 
 #include "TextMetrics.h"
 
-#include "Bidi.h"
 #include "Buffer.h"
 #include "buffer_funcs.h"
 #include "BufferParams.h"
 #include "CoordCache.h"
 #include "Cursor.h"
 #include "CutAndPaste.h"
-#include "FuncRequest.h"
+#include "HSpace.h"
 #include "InsetList.h"
+#include "Language.h"
 #include "Layout.h"
-#include "Length.h"
 #include "LyXRC.h"
 #include "MetricsInfo.h"
-#include "paragraph_funcs.h"
 #include "ParagraphParameters.h"
-#include "ParIterator.h"
-#include "rowpainter.h"
+#include "RowPainter.h"
 #include "Text.h"
 #include "TextClass.h"
 #include "VSpace.h"
 
-#include "mathed/MacroTable.h"
+#include "insets/InsetText.h"
+
 #include "mathed/MathMacroTemplate.h"
 
 #include "frontends/FontMetrics.h"
 #include "frontends/Painter.h"
 
 #include "support/debug.h"
-#include <cstdlib>
 #include "support/lassert.h"
 
+#include <cmath>
+
 using namespace std;
 
 
@@ -58,20 +57,10 @@ namespace lyx {
 
 using frontend::FontMetrics;
 
-static int numberOfSeparators(Paragraph const & par, Row const & row)
-{
-       pos_type const first = max(row.pos(), par.beginOfBody());
-       pos_type const last = row.endpos() - 1;
-       int n = 0;
-       for (pos_type p = first; p < last; ++p) {
-               if (par.isSeparator(p))
-                       ++n;
-       }
-       return n;
-}
+namespace {
 
 
-static int numberOfLabelHfills(Paragraph const & par, Row const & row)
+int numberOfLabelHfills(Paragraph const & par, Row const & row)
 {
        pos_type last = row.endpos() - 1;
        pos_type first = row.pos();
@@ -91,29 +80,25 @@ static int numberOfLabelHfills(Paragraph const & par, Row const & row)
        return n;
 }
 
-
-static int numberOfHfills(Paragraph const & par, Row const & row)
+// FIXME: this needs to be rewritten, probably by merging it into some
+// code that, besides counting, sets the active status of the space
+// inset in the row element.
+int numberOfHfills(Row const & row, ParagraphMetrics const & pm,
+                   pos_type const body_pos)
 {
-       pos_type const last = row.endpos();
-       pos_type first = row.pos();
-
-       // hfill *DO* count at the beginning of paragraphs!
-       if (first) {
-               while (first < last && par.isHfill(first))
-                       ++first;
-       }
-
-       first = max(first, par.beginOfBody());
-
        int n = 0;
-       for (pos_type p = first; p < last; ++p) {
-               if (par.isHfill(p))
+       Row::const_iterator cit = row.begin();
+       Row::const_iterator const end = row.end();
+       for ( ; cit != end ; ++cit)
+               if (cit->pos >= body_pos
+                   && cit->inset && pm.hfillExpansion(row, cit->pos))
                        ++n;
-       }
        return n;
 }
 
 
+}
+
 /////////////////////////////////////////////////////////////////////
 //
 // TextMetrics
@@ -124,13 +109,11 @@ static int numberOfHfills(Paragraph const & par, Row const & row)
 TextMetrics::TextMetrics(BufferView * bv, Text * text)
        : bv_(bv), text_(text)
 {
-       LASSERT(bv_, /**/);
+       LBUFERR(bv_);
        max_width_ = bv_->workWidth();
        dim_.wid = max_width_;
        dim_.asc = 10;
        dim_.des = 10;
-
-       //text_->updateLabels(bv->buffer());
 }
 
 
@@ -156,6 +139,7 @@ pair<pit_type, ParagraphMetrics const *> TextMetrics::first() const
 
 pair<pit_type, ParagraphMetrics const *> TextMetrics::last() const
 {
+       LBUFERR(!par_metrics_.empty());
        ParMetricsCache::const_reverse_iterator it = par_metrics_.rbegin();
        return make_pair(it->first, &it->second);
 }
@@ -174,20 +158,9 @@ ParagraphMetrics & TextMetrics::parMetrics(pit_type pit, bool redo)
 }
 
 
-int TextMetrics::parPosition(pit_type pit) const
-{
-       if (pit < par_metrics_.begin()->first)
-               return -1000000;
-       if (pit > par_metrics_.rbegin()->first)
-               return +1000000;
-
-       return par_metrics_[pit].position();
-}
-
-
 bool TextMetrics::metrics(MetricsInfo & mi, Dimension & dim, int min_width)
 {
-       LASSERT(mi.base.textwidth, /**/);
+       LBUFERR(mi.base.textwidth > 0);
        max_width_ = mi.base.textwidth;
        // backup old dimension.
        Dimension const old_dim = dim_;
@@ -227,29 +200,27 @@ bool TextMetrics::metrics(MetricsInfo & mi, Dimension & dim, int min_width)
 
 int TextMetrics::rightMargin(ParagraphMetrics const & pm) const
 {
-       return main_text_? pm.rightMargin(*bv_) : 0;
+       return text_->isMainText() ? pm.rightMargin(*bv_) : 0;
 }
 
 
 int TextMetrics::rightMargin(pit_type const pit) const
 {
-       return main_text_? par_metrics_[pit].rightMargin(*bv_) : 0;
+       return text_->isMainText() ? par_metrics_[pit].rightMargin(*bv_) : 0;
 }
 
 
 void TextMetrics::applyOuterFont(Font & font) const
 {
-       Font lf(font_);
-       lf.fontInfo().reduce(bv_->buffer().params().getFont().fontInfo());
-       lf.fontInfo().realize(font.fontInfo());
-       lf.setLanguage(font.language());
-       font = lf;
+       FontInfo lf(font_.fontInfo());
+       lf.reduce(bv_->buffer().params().getFont().fontInfo());
+       font.fontInfo().realize(lf);
 }
 
 
 Font TextMetrics::displayFont(pit_type pit, pos_type pos) const
 {
-       LASSERT(pos >= 0, /**/);
+       LASSERT(pos >= 0, { static Font f; return f; });
 
        ParagraphList const & pars = text_->paragraphs();
        Paragraph const & par = pars[pit];
@@ -262,7 +233,7 @@ Font TextMetrics::displayFont(pit_type pit, pos_type pos) const
        // We specialize the 95% common case:
        if (!par.getDepth()) {
                Font f = par.getFontSettings(params, pos);
-               if (!text_->isMainText(buffer))
+               if (!text_->isMainText())
                        applyOuterFont(f);
                bool lab = layout.labeltype == LABEL_MANUAL && pos < body_pos;
 
@@ -283,14 +254,14 @@ Font TextMetrics::displayFont(pit_type pit, pos_type pos) const
        Font font = par.getFontSettings(params, pos);
        font.fontInfo().realize(layoutfont);
 
-       if (!text_->isMainText(buffer))
+       if (!text_->isMainText())
                applyOuterFont(font);
 
        // Realize against environment font information
        // NOTE: the cast to pit_type should be removed when pit_type
        // changes to a unsigned integer.
        if (pit < pit_type(pars.size()))
-               font.fontInfo().realize(outerFont(pit, pars).fontInfo());
+               font.fontInfo().realize(text_->outerFont(pit).fontInfo());
 
        // Realize with the fonts of lesser depth.
        font.fontInfo().realize(params.getFont().fontInfo());
@@ -301,7 +272,7 @@ Font TextMetrics::displayFont(pit_type pit, pos_type pos) const
 
 bool TextMetrics::isRTL(CursorSlice const & sl, bool boundary) const
 {
-       if (!lyxrc.rtl_support || !sl.text())
+       if (!sl.text())
                return false;
 
        int correction = 0;
@@ -314,10 +285,7 @@ bool TextMetrics::isRTL(CursorSlice const & sl, bool boundary) const
 
 bool TextMetrics::isRTLBoundary(pit_type pit, pos_type pos) const
 {
-       if (!lyxrc.rtl_support)
-               return false;
-
-       // no RTL boundary at line start
+       // no RTL boundary at paragraph start
        if (pos == 0)
                return false;
 
@@ -327,19 +295,50 @@ bool TextMetrics::isRTLBoundary(pit_type pit, pos_type pos) const
 }
 
 
+// isRTLBoundary returns false on a real end-of-line boundary,
+// because otherwise the two boundary types get mixed up.
+// This is the whole purpose of this being in TextMetrics.
 bool TextMetrics::isRTLBoundary(pit_type pit, pos_type pos,
                Font const & font) const
 {
-       if (!lyxrc.rtl_support)
+       if (// no RTL boundary at paragraph start
+           pos == 0
+           // if the metrics have not been calculated, then we are not
+           // on screen and can safely ignore issues about boundaries.
+           || !contains(pit))
+               return false;
+
+       ParagraphMetrics & pm = par_metrics_[pit];
+       // no RTL boundary in empty paragraph
+       if (pm.rows().empty())
+               return false;
+
+       pos_type endpos = pm.getRow(pos - 1, false).endpos();
+       pos_type startpos = pm.getRow(pos, false).pos();
+       // no RTL boundary at line start:
+       // abc\n   -> toggle to RTL ->    abc\n     (and not:    abc\n|
+       // |                              |                               )
+       if (pos == startpos && pos == endpos) // start of cur row, end of prev row
                return false;
 
        Paragraph const & par = text_->getPar(pit);
+       // no RTL boundary at line break:
+       // abc|\n    -> move right ->   abc\n       (and not:    abc\n|
+       // FED                          FED|                     FED     )
+       if (startpos == pos && endpos == pos && endpos != par.size()
+               && (par.isNewline(pos - 1)
+                       || par.isEnvSeparator(pos - 1)
+                       || par.isLineSeparator(pos - 1)
+                       || par.isSeparator(pos - 1)))
+               return false;
+
        bool left = font.isVisibleRightToLeft();
        bool right;
        if (pos == par.size())
                right = par.isRTL(bv_->buffer().params());
        else
                right = displayFont(pit, pos).isVisibleRightToLeft();
+
        return left != right;
 }
 
@@ -347,29 +346,37 @@ bool TextMetrics::isRTLBoundary(pit_type pit, pos_type pos,
 bool TextMetrics::redoParagraph(pit_type const pit)
 {
        Paragraph & par = text_->getPar(pit);
-       // IMPORTANT NOTE: We pass 'false' explicitely in order to not call
+       // IMPORTANT NOTE: We pass 'false' explicitly in order to not call
        // redoParagraph() recursively inside parMetrics.
        Dimension old_dim = parMetrics(pit, false).dim();
        ParagraphMetrics & pm = par_metrics_[pit];
        pm.reset(par);
 
        Buffer & buffer = bv_->buffer();
-       main_text_ = (text_ == &buffer.text());
        bool changed = false;
 
+       // Check whether there are InsetBibItems that need fixing
        // FIXME: This check ought to be done somewhere else. It is the reason
-       // why text_ is not     const. But then, where else to do it?
+       // why text_ is not const. But then, where else to do it?
        // Well, how can you end up with either (a) a biblio environment that
        // has no InsetBibitem or (b) a biblio environment with more than one
        // InsetBibitem? I think the answer is: when paragraphs are merged;
        // when layout is set; when material is pasted.
-       int const moveCursor = par.checkBiblio(buffer);
-       if (moveCursor > 0)
-               const_cast<Cursor &>(bv_->cursor()).posForward();
-       else if (moveCursor < 0) {
-               Cursor & cursor = const_cast<Cursor &>(bv_->cursor());
-               if (cursor.pos() >= -moveCursor)
-                       cursor.posBackward();
+       if (par.brokenBiblio()) {
+               Cursor & cur = const_cast<Cursor &>(bv_->cursor());
+               // In some cases, we do not know how to record undo
+               if (&cur.inset() == &text_->inset())
+                       cur.recordUndo(pit, pit);
+
+               int const moveCursor = par.fixBiblio(buffer);
+
+               // Is it necessary to update the cursor?
+               if (&cur.inset() == &text_->inset() && cur.pit() == pit) {
+                       if (moveCursor > 0)
+                               cur.posForward();
+                       else if (moveCursor < 0 && cur.pos() >= -moveCursor)
+                               cur.posBackward();
+               }
        }
 
        // Optimisation: this is used in the next two loops
@@ -384,19 +391,22 @@ bool TextMetrics::redoParagraph(pit_type const pit)
                LYXERR(Debug::INFO, "MacroContext not initialised!"
                        << " Going through the buffer again and hope"
                        << " the context is better then.");
-               bv_->buffer().updateLabels();
+               // FIXME audit updateBuffer calls
+               // This should not be here, but it is not clear yet where else it
+               // should be.
+               bv_->buffer().updateBuffer();
                parPos = text_->macrocontextPosition();
-               LASSERT(!parPos.empty(), /**/);
+               LBUFERR(!parPos.empty());
                parPos.pit() = pit;
        }
 
        // redo insets
-       // FIXME: We should always use getFont(), see documentation of
-       // noFontChange() in Inset.h.
        Font const bufferfont = buffer.params().getFont();
+       CoordCache::Insets & insetCache = bv_->coordCache().insets();
        InsetList::const_iterator ii = par.insetList().begin();
        InsetList::const_iterator iend = par.insetList().end();
        for (; ii != iend; ++ii) {
+               // FIXME Doesn't this HAVE to be non-empty?
                // position already initialized?
                if (!parPos.empty()) {
                        parPos.pos() = ii->pos;
@@ -413,14 +423,13 @@ bool TextMetrics::redoParagraph(pit_type const pit)
                Dimension dim;
                int const w = max_width_ - leftMargin(max_width_, pit, ii->pos)
                        - right_margin;
-               Font const & font = ii->inset->noFontChange() ?
-                       bufferfont : displayFont(pit, ii->pos);
-               MacroContext mc(buffer, parPos);
+               Font const & font = ii->inset->inheritFont() ?
+                       displayFont(pit, ii->pos) : bufferfont;
+               MacroContext mc(&buffer, parPos);
                MetricsInfo mi(bv_, font.fontInfo(), w, mc);
                ii->inset->metrics(mi, dim);
-               Dimension const old_dim = pm.insetDimension(ii->inset);
-               if (old_dim != dim) {
-                       pm.setInsetDimension(ii->inset, dim);
+               if (!insetCache.has(ii->inset) || insetCache.dim(ii->inset) != dim) {
+                       insetCache.add(ii->inset, dim);
                        changed = true;
                }
        }
@@ -428,55 +437,71 @@ bool TextMetrics::redoParagraph(pit_type const pit)
        par.setBeginOfBody();
        pos_type first = 0;
        size_t row_index = 0;
+       bool need_new_row = false;
        // maximum pixel width of a row
-       int width = max_width_ - right_margin; // - leftMargin(max_width_, pit, row);
        do {
-               Dimension dim;
-               pos_type end = rowBreakPoint(width, pit, first);
-               if (row_index || end < par.size())
-                       // If there is more than one row, expand the text to
-                       // the full allowable width. This setting here is needed
-                       // for the computeRowMetrics() below.
-                       dim_.wid = max_width_;
-
-               dim = rowHeight(pit, first, end);
-               dim.wid = rowWidth(right_margin, pit, first, end);
                if (row_index == pm.rows().size())
                        pm.rows().push_back(Row());
                Row & row = pm.rows()[row_index];
-               row.setChanged(false);
+               row.pit(pit);
                row.pos(first);
-               row.endpos(end);
-               row.setDimension(dim);
-               int const max_row_width = max(dim_.wid, dim.wid);
-               computeRowMetrics(pit, row, max_row_width);
-               first = end;
+               row.pit(pit);
+               need_new_row = breakRow(row, right_margin);
+               setRowHeight(row);
+               row.setChanged(false);
+               if (row_index || row.endpos() < par.size()
+                   || (row.right_boundary() && par.inInset().lyxCode() != CELL_CODE)) {
+                       /* If there is more than one row or the row has been
+                        * broken by a display inset or a newline, expand the text
+                        * to the full allowable width. This setting here is
+                        * needed for the computeRowMetrics() below. In the case
+                        * of a display inset, we do nothing when inside a table
+                        * cell, because the tabular code is not prepared for
+                        * that, and it triggers when using a caption in a
+                        * longtable (see bugs #9945 and #9757).
+                        */
+                       if (dim_.wid < max_width_)
+                               dim_.wid = max_width_;
+               }
+               int const max_row_width = max(dim_.wid, row.width());
+               computeRowMetrics(row, max_row_width);
+               first = row.endpos();
                ++row_index;
 
-               pm.dim().wid = max(pm.dim().wid, dim.wid);
-               pm.dim().des += dim.height();
-       } while (first < par.size());
+               pm.dim().wid = max(pm.dim().wid, row.width());
+               pm.dim().des += row.height();
+       } while (first < par.size() || need_new_row);
 
        if (row_index < pm.rows().size())
                pm.rows().resize(row_index);
 
-       // Make sure that if a par ends in newline, there is one more row
-       // under it
-       if (first > 0 && par.isNewline(first - 1)) {
-               Dimension dim = rowHeight(pit, first, first);
-               dim.wid = rowWidth(right_margin, pit, first, first);
-               if (row_index == pm.rows().size())
-                       pm.rows().push_back(Row());
-               Row & row = pm.rows()[row_index];
-               row.setChanged(false);
-               row.pos(first);
-               row.endpos(first);
-               row.setDimension(dim);
-               int const max_row_width = max(dim_.wid, dim.wid);
-               computeRowMetrics(pit, row, max_row_width);
-               pm.dim().des += dim.height();
+       // FIXME: It might be better to move this in another method
+       // specially tailored for the main text.
+       // Top and bottom margin of the document (only at top-level)
+       if (text_->isMainText()) {
+               if (pit == 0) {
+                       pm.rows().front().dimension().asc += 20;
+                       /* coverity[copy_paste_error]: coverity thinks that we
+                        * should update pm.dim().asc below, but all the rows
+                        * heights are actually counted as part of the paragraph metric
+                        * descent see loop above).
+                        */
+                       pm.dim().des += 20;
+               }
+               ParagraphList const & pars = text_->paragraphs();
+               if (pit + 1 == pit_type(pars.size())) {
+                       pm.rows().back().dimension().des += 20;
+                       pm.dim().des += 20;
+               }
        }
 
+       // The space above and below the paragraph.
+       int const top = parTopSpacing(pit);
+       pm.rows().front().dimension().asc += top;
+       int const bottom = parBottomSpacing(pit);
+       pm.rows().back().dimension().des += bottom;
+       pm.dim().des += top + bottom;
+
        pm.dim().asc += pm.rows()[0].ascent();
        pm.dim().des -= pm.rows()[0].ascent();
 
@@ -486,36 +511,90 @@ bool TextMetrics::redoParagraph(pit_type const pit)
 }
 
 
-void TextMetrics::computeRowMetrics(pit_type const pit,
-               Row & row, int width) const
+LyXAlignment TextMetrics::getAlign(Paragraph const & par, Row const & row) const
+{
+       Layout const & layout = par.layout();
+
+       LyXAlignment align;
+       if (par.params().align() == LYX_ALIGN_LAYOUT)
+               align = layout.align;
+       else
+               align = par.params().align();
+
+       // handle alignment inside tabular cells
+       Inset const & owner = text_->inset();
+       bool forced_block = false;
+       switch (owner.contentAlignment()) {
+       case LYX_ALIGN_BLOCK:
+               // In general block align is the default state, but here it is
+               // an explicit choice. Therefore it should not be overridden
+               // later.
+               forced_block = true;
+               // fall through
+       case LYX_ALIGN_CENTER:
+       case LYX_ALIGN_LEFT:
+       case LYX_ALIGN_RIGHT:
+               if (align == LYX_ALIGN_NONE || align == LYX_ALIGN_BLOCK)
+                       align = owner.contentAlignment();
+               break;
+       default:
+               // unchanged (use align)
+               break;
+       }
+
+       // Display-style insets should always be on a centered row
+       if (Inset const * inset = par.getInset(row.pos())) {
+               switch (inset->display()) {
+               case Inset::AlignLeft:
+                       align = LYX_ALIGN_BLOCK;
+                       break;
+               case Inset::AlignCenter:
+                       align = LYX_ALIGN_CENTER;
+                       break;
+               case Inset::Inline:
+                       // unchanged (use align)
+                       break;
+               case Inset::AlignRight:
+                       align = LYX_ALIGN_RIGHT;
+                       break;
+               }
+       }
+
+       if (align == LYX_ALIGN_BLOCK) {
+               // If this row has been broken abruptly by a display inset, or
+               // it is the end of the paragraph, or the user requested we
+               // not justify stuff, then don't stretch.
+               // A forced block alignment can only be overridden the 'no
+               // justification on screen' setting.
+               if (((row.right_boundary() || row.endpos() == par.size())
+                    && !forced_block)
+                   || !bv_->buffer().params().justification)
+                       align = text_->isRTL(par) ? LYX_ALIGN_RIGHT : LYX_ALIGN_LEFT;
+       }
+
+       return align;
+}
+
+
+void TextMetrics::computeRowMetrics(Row & row, int width) const
 {
        row.label_hfill = 0;
        row.separator = 0;
 
-       Buffer & buffer = bv_->buffer();
-       Paragraph const & par = text_->getPar(pit);
+       Paragraph const & par = text_->getPar(row.pit());
 
-       double w = width - row.width();
+       int const w = width - row.right_margin - row.width();
        // FIXME: put back this assertion when the crash on new doc is solved.
        //LASSERT(w >= 0, /**/);
 
-       //lyxerr << "\ndim_.wid " << dim_.wid << endl;
-       //lyxerr << "row.width() " << row.width() << endl;
-       //lyxerr << "w " << w << endl;
-
-       bool const is_rtl = text_->isRTL(buffer, par);
-       if (is_rtl)
-               row.x = rightMargin(pit);
-       else
-               row.x = leftMargin(max_width_, pit, row.pos());
-
        // is there a manual margin with a manual label
        Layout const & layout = par.layout();
 
+       int nlh = 0;
        if (layout.margintype == MARGIN_MANUAL
            && layout.labeltype == LABEL_MANUAL) {
                /// We might have real hfills in the label part
-               int nlh = numberOfLabelHfills(par, row);
+               nlh = numberOfLabelHfills(par, row);
 
                // A manual label par (e.g. List) has an auto-hfill
                // between the label text and the body of the
@@ -526,162 +605,115 @@ void TextMetrics::computeRowMetrics(pit_type const pit,
                        ++nlh;
 
                if (nlh && !par.getLabelWidthString().empty())
-                       row.label_hfill = labelFill(pit, row) / double(nlh);
+                       row.label_hfill = labelFill(row) / double(nlh);
        }
 
-       double hfill = 0;
        // are there any hfills in the row?
-       if (int const nh = numberOfHfills(par, row)) {
-               if (w > 0)
-                       hfill = w / double(nh);
-       // we don't have to look at the alignment if it is ALIGN_LEFT and
-       // if the row is already larger then the permitted width as then
-       // we force the LEFT_ALIGN'edness!
-       } else if (int(row.width()) < max_width_) {
-               // is it block, flushleft or flushright?
-               // set x how you need it
-               int align;
-               if (par.params().align() == LYX_ALIGN_LAYOUT)
-                       align = layout.align;
-               else
-                       align = par.params().align();
-
-               // handle alignment inside tabular cells
-               Inset const & owner = par.inInset();
-               switch (owner.contentAlignment()) {
-                       case LYX_ALIGN_CENTER:
-                       case LYX_ALIGN_LEFT:
-                       case LYX_ALIGN_RIGHT:
-                               if (align == LYX_ALIGN_NONE 
-                                   || align == LYX_ALIGN_BLOCK)
-                                       align = owner.contentAlignment();
-                               break;
-                       default:
-                               // unchanged (use align)
-                               break;
-               }
-
-               // Display-style insets should always be on a centred row
-               if (Inset const * inset = par.getInset(row.pos())) {
-                       switch (inset->display()) {
-                               case Inset::AlignLeft:
-                                       align = LYX_ALIGN_BLOCK;
-                                       break;
-                               case Inset::AlignCenter:
-                                       align = LYX_ALIGN_CENTER;
-                                       break;
-                               case Inset::Inline:
-                               case Inset::AlignRight:
-                                       // unchanged (use align)
-                                       break;
-                       }
-               }
+       ParagraphMetrics & pm = par_metrics_[row.pit()];
+       int nh = numberOfHfills(row, pm, par.beginOfBody());
+       int hfill = 0;
+       int hfill_rem = 0;
+
+       // We don't have to look at the alignment if the row is already
+       // larger then the permitted width as then we force the
+       // LEFT_ALIGN'edness!
+       if (int(row.width()) >= max_width_)
+               return;
 
-               switch (align) {
+       if (nh == 0) {
+               // Common case : there is no hfill, and the alignment will be
+               // meaningful
+               switch (getAlign(par, row)) {
                case LYX_ALIGN_BLOCK: {
-                       int const ns = numberOfSeparators(par, row);
-                       bool disp_inset = false;
-                       if (row.endpos() < par.size()) {
-                               Inset const * in = par.getInset(row.endpos());
-                               if (in)
-                                       disp_inset = in->display();
-                       }
-                       // If we have separators, this is not the last row of a
-                       // par, does not end in newline, and is not row above a
-                       // display inset... then stretch it
-                       if (ns
-                           && row.endpos() < par.size()
-                           && !par.isNewline(row.endpos() - 1)
-                           && !disp_inset
-                               ) {
-                               row.separator = w / ns;
-                               //lyxerr << "row.separator " << row.separator << endl;
-                               //lyxerr << "ns " << ns << endl;
-                       } else if (is_rtl) {
-                               row.x += w;
+                       int const ns = row.countSeparators();
+                       // If we have separators, then stretch the row
+                       if (ns) {
+                               row.setSeparatorExtraWidth(double(w) / ns);
+                               row.dimension().wid += w;
+                       } else if (text_->isRTL(par)) {
+                               row.left_margin += w;
+                               row.dimension().wid += w;
                        }
                        break;
                }
                case LYX_ALIGN_RIGHT:
-                       row.x += w;
+                       row.left_margin += w;
+                       row.dimension().wid += w;
                        break;
                case LYX_ALIGN_CENTER:
-                       row.x += w / 2;
+                       row.dimension().wid += w / 2;
+                       row.left_margin += w / 2;
+                       break;
+               case LYX_ALIGN_LEFT:
+               case LYX_ALIGN_NONE:
+               case LYX_ALIGN_LAYOUT:
+               case LYX_ALIGN_SPECIAL:
+               case LYX_ALIGN_DECIMAL:
                        break;
                }
+               return;
        }
 
-       if (is_rtl) {
-               pos_type body_pos = par.beginOfBody();
-               pos_type end = row.endpos();
-
-               if (body_pos > 0
-                   && (body_pos > end || !par.isLineSeparator(body_pos - 1)))
-               {
-                       row.x += theFontMetrics(text_->labelFont(buffer, par)).
-                               width(layout.labelsep);
-                       if (body_pos <= end)
-                               row.x += row.label_hfill;
-               }
-       }
-
+       hfill = w / nh;
+       hfill_rem = w % nh;
+       row.dimension().wid += w;
+       // Set size of hfill insets
        pos_type const endpos = row.endpos();
        pos_type body_pos = par.beginOfBody();
        if (body_pos > 0
-               && (body_pos > endpos || !par.isLineSeparator(body_pos - 1)))
+           && (body_pos > endpos || !par.isLineSeparator(body_pos - 1)))
                body_pos = 0;
 
-       ParagraphMetrics & pm = par_metrics_[pit];
-       InsetList::const_iterator ii = par.insetList().begin();
-       InsetList::const_iterator iend = par.insetList().end();
-       for ( ; ii != iend; ++ii) {
-               if (ii->pos >= endpos || ii->pos < row.pos()
-                       || (ii->inset->lyxCode() != SPACE_CODE ||
-                           !ii->inset->isStretchableSpace()))
-                       continue;
-               Dimension dim = row.dimension();
-               if (pm.hfillExpansion(row, ii->pos))
-                       dim.wid = int(ii->pos >= body_pos ?
-                               max(hfill, 5.0) : row.label_hfill);
-               else
-                       dim.wid = 5;
-               // Cache the inset dimension.
-               bv_->coordCache().insets().add(ii->inset, dim);
-               pm.setInsetDimension(ii->inset, dim);
+       CoordCache::Insets & insetCache = bv_->coordCache().insets();
+       Row::iterator cit = row.begin();
+       Row::iterator const cend = row.end();
+       for ( ; cit != cend; ++cit) {
+               if (row.label_hfill && cit->endpos == body_pos
+                   && cit->type == Row::SPACE)
+                       cit->dim.wid -= int(row.label_hfill * (nlh - 1));
+               if (cit->inset && pm.hfillExpansion(row, cit->pos)) {
+                       if (cit->pos >= body_pos) {
+                               cit->dim.wid += hfill;
+                               --nh;
+                               if (nh == 0)
+                                       cit->dim.wid += hfill_rem;
+                       } else
+                               cit->dim.wid += int(row.label_hfill);
+                       // Cache the inset dimension.
+                       insetCache.add(cit->inset, cit->dim);
+               }
        }
 }
 
 
-int TextMetrics::labelFill(pit_type const pit, Row const & row) const
+int TextMetrics::labelFill(Row const & row) const
 {
-       Buffer & buffer = bv_->buffer();
-       Paragraph const & par = text_->getPar(pit);
-
-       pos_type last = par.beginOfBody();
-       LASSERT(last > 0, /**/);
-
-       // -1 because a label ends with a space that is in the label
-       --last;
-
-       // a separator at this end does not count
-       if (par.isLineSeparator(last))
-               --last;
+       Paragraph const & par = text_->getPar(row.pit());
+       LBUFERR(par.beginOfBody() > 0 || par.isEnvSeparator(0));
 
        int w = 0;
-       for (pos_type i = row.pos(); i <= last; ++i)
-               w += singleWidth(pit, i);
+       Row::const_iterator cit = row.begin();
+       Row::const_iterator const end = row.end();
+       // iterate over elements before main body (except the last one,
+       // which is extra space).
+       while (cit!= end && cit->endpos < par.beginOfBody()) {
+               w += cit->dim.wid;
+               ++cit;
+       }
 
        docstring const & label = par.params().labelWidthString();
        if (label.empty())
                return 0;
 
        FontMetrics const & fm
-               = theFontMetrics(text_->labelFont(buffer, par));
+               = theFontMetrics(text_->labelFont(par));
 
        return max(0, fm.width(label) - w);
 }
 
 
+#if 0
+// Not used, see TextMetrics::breakRow
 // this needs special handling - only newlines count as a break point
 static pos_type addressBreakPoint(pos_type i, Paragraph const & par)
 {
@@ -693,6 +725,7 @@ static pos_type addressBreakPoint(pos_type i, Paragraph const & par)
 
        return end;
 }
+#endif
 
 
 int TextMetrics::labelEnd(pit_type const pit) const
@@ -733,7 +766,7 @@ public:
        FontIterator & operator++()
        {
                ++pos_;
-               if (pos_ > endspan_ || pos_ == bodypos_) {
+               if (pos_ < par_.size() && (pos_ > endspan_ || pos_ == bodypos_)) {
                        font_ = tm_.displayFont(pit_, pos_);
                        endspan_ = par_.fontSpan(pos_).last;
                }
@@ -762,507 +795,361 @@ private:
 
 } // anon namespace
 
-pit_type TextMetrics::rowBreakPoint(int width, pit_type const pit,
-               pit_type pos) const
+/** This is the function where the hard work is done. The code here is
+ * very sensitive to small changes :) Note that part of the
+ * intelligence is also in Row::shortenIfNeeded.
+ */
+bool TextMetrics::breakRow(Row & row, int const right_margin) const
 {
-       Buffer & buffer = bv_->buffer();
-       ParagraphMetrics const & pm = par_metrics_[pit];
-       Paragraph const & par = text_->getPar(pit);
+       Paragraph const & par = text_->getPar(row.pit());
        pos_type const end = par.size();
-       if (pos == end || width < 0)
-               return end;
+       pos_type const pos = row.pos();
+       pos_type const body_pos = par.beginOfBody();
+       bool const is_rtl = text_->isRTL(par);
+       bool need_new_row = false;
 
-       Layout const & layout = par.layout();
+       row.clear();
+       row.left_margin = leftMargin(max_width_, row.pit(), pos);
+       row.right_margin = right_margin;
+       if (is_rtl)
+               swap(row.left_margin, row.right_margin);
+       // Remember that the row width takes into account the left_margin
+       // but not the right_margin.
+       row.dimension().wid = row.left_margin;
+       // the width available for the row.
+       int const width = max_width_ - row.right_margin;
+
+       if (pos >= end || row.width() > width) {
+               row.endpos(end);
+               return need_new_row;
+       }
 
-       if (layout.margintype == MARGIN_RIGHT_ADDRESS_BOX)
+#if 0
+       //FIXME: As long as leftMargin() is not correctly implemented for
+       // MARGIN_RIGHT_ADDRESS_BOX, we should also not do this here.
+       // Otherwise, long rows will be painted off the screen.
+       if (par.layout().margintype == MARGIN_RIGHT_ADDRESS_BOX)
                return addressBreakPoint(pos, par);
-
-       pos_type const body_pos = par.beginOfBody();
+#endif
 
        // check for possible inline completion
-       DocIterator const & inlineCompletionPos = bv_->inlineCompletionPos();
-       pos_type inlineCompletionLPos = -1;
-       if (inlineCompletionPos.inTexted()
-           && inlineCompletionPos.text() == text_
-           && inlineCompletionPos.pit() == pit) {
-               // draw logically behind the previous character
-               inlineCompletionLPos = inlineCompletionPos.pos() - 1;
-       }
+       DocIterator const & ic_it = bv_->inlineCompletionPos();
+       pos_type ic_pos = -1;
+       if (ic_it.inTexted() && ic_it.text() == text_ && ic_it.pit() == row.pit())
+               ic_pos = ic_it.pos();
 
        // Now we iterate through until we reach the right margin
-       // or the end of the par, then choose the possible break
-       // nearest that.
-
-       int label_end = labelEnd(pit);
-       int const left = leftMargin(max_width_, pit, pos);
-       int x = left;
-
-       // pixel width since last breakpoint
-       int chunkwidth = 0;
-
-       FontIterator fi = FontIterator(*this, par, pit, pos);
-       pos_type point = end;
+       // or the end of the par, then build a representation of the row.
        pos_type i = pos;
-       for ( ; i < end; ++i, ++fi) {
-               int thiswidth = pm.singleWidth(i, *fi);
-
-               // add inline completion width
-               if (inlineCompletionLPos == i) {
-                       docstring const & completion = bv_->inlineCompletion();
-                       if (completion.length() > 0)
-                               thiswidth += theFontMetrics(*fi).width(completion);
-               }
-
-               // add the auto-hfill from label end to the body
-               if (body_pos && i == body_pos) {
-                       FontMetrics const & fm = theFontMetrics(
-                               text_->labelFont(buffer, par));
-                       int add = fm.width(layout.labelsep);
-                       if (par.isLineSeparator(i - 1))
-                               add -= singleWidth(pit, i - 1);
-
-                       add = max(add, label_end - x);
-                       thiswidth += add;
+       FontIterator fi = FontIterator(*this, par, row.pit(), pos);
+       do {
+               // this can happen for an empty row after a newline
+               if (i >= end)
+                       break;
+               char_type c = par.getChar(i);
+               // The most special cases are handled first.
+               if (par.isInset(i)) {
+                       Inset const * ins = par.getInset(i);
+                       Dimension dim = bv_->coordCache().insets().dim(ins);
+                       row.add(i, ins, dim, *fi, par.lookupChange(i));
+               } else if (c == ' ' && i + 1 == body_pos) {
+                       // There is a space at i, but it should not be
+                       // added as a separator, because it is just
+                       // before body_pos. Instead, insert some spacing to
+                       // align text
+                       FontMetrics const & fm = theFontMetrics(text_->labelFont(par));
+                       // this is needed to make sure that the row width is correct
+                       row.finalizeLast();
+                       int const add = max(fm.width(par.layout().labelsep),
+                                           labelEnd(row.pit()) - row.width());
+                       row.addSpace(i, add, *fi, par.lookupChange(i));
+               } else if (c == '\t')
+                       row.addSpace(i, theFontMetrics(*fi).width(from_ascii("    ")),
+                                    *fi, par.lookupChange(i));
+               else {
+                       // FIXME: please someone fix the Hebrew/Arabic parenthesis mess!
+                       // see also Paragraph::getUChar.
+                       if (fi->language()->lang() == "hebrew") {
+                               if (c == '(')
+                                       c = ')';
+                               else if (c == ')')
+                                       c = '(';
+                       }
+                       row.add(i, c, *fi, par.lookupChange(i));
                }
 
-               x += thiswidth;
-               chunkwidth += thiswidth;
-
-               // break before a character that will fall off
-               // the right of the row
-               if (x >= width) {
-                       // if no break before, break here
-                       if (point == end || chunkwidth >= width - left) {
-                               if (i > pos)
-                                       point = i;
-                               else
-                                       point = i + 1;
+               // add inline completion width
+               // draw logically behind the previous character
+               if (ic_pos == i + 1 && !bv_->inlineCompletion().empty()) {
+                       docstring const comp = bv_->inlineCompletion();
+                       size_t const uniqueTo =bv_->inlineCompletionUniqueChars();
+                       Font f = *fi;
+
+                       if (uniqueTo > 0) {
+                               f.fontInfo().setColor(Color_inlinecompletion);
+                               row.addVirtual(i + 1, comp.substr(0, uniqueTo), f, Change());
                        }
-                       // exit on last registered breakpoint:
-                       break;
+                       f.fontInfo().setColor(Color_nonunique_inlinecompletion);
+                       row.addVirtual(i + 1, comp.substr(uniqueTo), f, Change());
                }
 
-               if (par.isNewline(i)) {
-                       point = i + 1;
-                       break;
-               }
+               // Handle some situations that abruptly terminate the row
+               // - A newline inset
+               // - Before a display inset
+               // - After a display inset
                Inset const * inset = 0;
-               // Break before...
-               if (i + 1 < end) {
-                       if ((inset = par.getInset(i + 1)) && inset->display()) {
-                               point = i + 1;
-                               break;
-                       }
-                       // ...and after.
-                       if ((inset = par.getInset(i)) && inset->display()) {
-                               point = i + 1;
-                               break;
-                       }
+               if (par.isNewline(i) || par.isEnvSeparator(i)
+                   || (i + 1 < end && (inset = par.getInset(i + 1))
+                       && inset->display())
+                   || (!row.empty() && row.back().inset
+                       && row.back().inset->display())) {
+                       row.right_boundary(true);
+                       need_new_row = par.isNewline(i);
+                       ++i;
+                       break;
                }
 
-               inset = par.getInset(i);
-               if (!inset || inset->isChar()) {
-                       // some insets are line separators too
-                       if (par.isLineSeparator(i)) {
-                               // register breakpoint:
-                               point = i + 1;
-                               chunkwidth = 0;
-                       }
-               }
+               ++i;
+               ++fi;
+       } while (i < end && row.width() <= width);
+       row.finalizeLast();
+       row.endpos(i);
+
+       // End of paragraph marker
+       ParagraphList const & pars = text_->paragraphs();
+       if (lyxrc.paragraph_markers && !need_new_row
+           && i == end && size_type(row.pit() + 1) < pars.size()) {
+               // add a virtual element for the end-of-paragraph
+               // marker; it is shown on screen, but does not exist
+               // in the paragraph.
+               Font f(text_->layoutFont(row.pit()));
+               f.fontInfo().setColor(Color_paragraphmarker);
+               BufferParams const & bparams
+                       = text_->inset().buffer().params();
+               f.setLanguage(par.getParLanguage(bparams));
+               row.addVirtual(end, docstring(1, char_type(0x00B6)), f, Change());
        }
 
-       // maybe found one, but the par is short enough.
-       if (i == end && x < width)
-               point = end;
+       // if the row is too large, try to cut at last separator. In case
+       // of success, reset indication that the row was broken abruptly.
+       if (row.shortenIfNeeded(body_pos, width))
+               row.right_boundary(!row.empty() && row.back().endpos == row.endpos());
 
-       // manual labels cannot be broken in LaTeX. But we
-       // want to make our on-screen rendering of footnotes
-       // etc. still break
-       if (body_pos && point < body_pos)
-               point = body_pos;
+       // make sure that the RTL elements are in reverse ordering
+       row.reverseRTL(is_rtl);
+       //LYXERR0("breakrow: row is " << row);
 
-       return point;
+       return need_new_row;
 }
 
-
-int TextMetrics::rowWidth(int right_margin, pit_type const pit,
-               pos_type const first, pos_type const end) const
+int TextMetrics::parTopSpacing(pit_type const pit) const
 {
-       Buffer & buffer = bv_->buffer();
-       // get the pure distance
-       ParagraphMetrics const & pm = par_metrics_[pit];
        Paragraph const & par = text_->getPar(pit);
-       int w = leftMargin(max_width_, pit, first);
-       int label_end = labelEnd(pit);
+       Layout const & layout = par.layout();
 
-       // check for possible inline completion
-       DocIterator const & inlineCompletionPos = bv_->inlineCompletionPos();
-       pos_type inlineCompletionLPos = -1;
-       if (inlineCompletionPos.inTexted()
-           && inlineCompletionPos.text() == text_
-           && inlineCompletionPos.pit() == pit) {
-               // draw logically behind the previous character
-               inlineCompletionLPos = inlineCompletionPos.pos() - 1;
-       }
+       int asc = 0;
+       ParagraphList const & pars = text_->paragraphs();
+       double const dh = defaultRowHeight();
 
-       pos_type const body_pos = par.beginOfBody();
-       pos_type i = first;
-
-       if (i < end) {
-               FontIterator fi = FontIterator(*this, par, pit, i);
-               for ( ; i < end; ++i, ++fi) {
-                       if (body_pos > 0 && i == body_pos) {
-                               FontMetrics const & fm = theFontMetrics(
-                                       text_->labelFont(buffer, par));
-                               w += fm.width(par.layout().labelsep);
-                               if (par.isLineSeparator(i - 1))
-                                       w -= singleWidth(pit, i - 1);
-                               w = max(w, label_end);
-                       }
-                       w += pm.singleWidth(i, *fi);
+       BufferParams const & bparams = bv_->buffer().params();
+       Inset const & inset = text_->inset();
+       // some parskips VERY EASY IMPLEMENTATION
+       if (bparams.paragraph_separation == BufferParams::ParagraphSkipSeparation
+               && !inset.getLayout().parbreakIsNewline()
+               && !par.layout().parbreak_is_newline
+               && pit > 0
+               && ((layout.isParagraph() && par.getDepth() == 0)
+                   || (pars[pit - 1].layout().isParagraph()
+                       && pars[pit - 1].getDepth() == 0))) {
+               asc += bparams.getDefSkip().inPixels(*bv_);
+       }
 
-                       // add inline completion width
-                       if (inlineCompletionLPos == i) {
-                               docstring const & completion = bv_->inlineCompletion();
-                               if (completion.length() > 0)
-                                       w += theFontMetrics(*fi).width(completion);
-                       }
-               }
+       if (par.params().startOfAppendix())
+               asc += int(3 * dh);
+
+       // special code for the top label
+       if (layout.labelIsAbove()
+           && (!layout.isParagraphGroup() || text_->isFirstInSequence(pit))
+           && !par.labelString().empty()) {
+               FontInfo labelfont = text_->labelFont(par);
+               FontMetrics const & lfm = theFontMetrics(labelfont);
+               asc += int(lfm.maxHeight() * layout.spacing.getValue()
+                                          * text_->spacing(par)
+                          + (layout.topsep + layout.labelbottomsep) * dh);
        }
 
-       if (body_pos > 0 && body_pos >= end) {
-               FontMetrics const & fm = theFontMetrics(
-                       text_->labelFont(buffer, par));
-               w += fm.width(par.layout().labelsep);
-               if (end > 0 && par.isLineSeparator(end - 1))
-                       w -= singleWidth(pit, end - 1);
-               w = max(w, label_end);
+       // Add the layout spaces, for example before and after
+       // a section, or between the items of a itemize or enumerate
+       // environment.
+
+       pit_type prev = text_->depthHook(pit, par.getDepth());
+       Paragraph const & prevpar = pars[prev];
+       double layoutasc = 0;
+       if (prev != pit
+           && prevpar.layout() == layout
+           && prevpar.getDepth() == par.getDepth()
+           && prevpar.getLabelWidthString() == par.getLabelWidthString()) {
+               layoutasc = layout.itemsep * dh;
+       } else if (pit != 0 && layout.topsep > 0)
+               layoutasc = layout.topsep * dh;
+
+       asc += int(layoutasc * 2 / (2 + pars[pit].getDepth()));
+
+       prev = text_->outerHook(pit);
+       if (prev != pit_type(pars.size())) {
+               asc += int(pars[prev].layout().parsep * dh);
+       } else if (pit != 0) {
+               Paragraph const & prevpar = pars[pit - 1];
+               if (prevpar.getDepth() != 0 || prevpar.layout() == layout)
+                       asc += int(layout.parsep * dh);
        }
 
-       return w + right_margin;
+       return asc;
 }
 
 
-Dimension TextMetrics::rowHeight(pit_type const pit, pos_type const first,
-               pos_type const end, bool topBottomSpace) const
+int TextMetrics::parBottomSpacing(pit_type const pit) const
 {
-       Paragraph const & par = text_->getPar(pit);
-       // get the maximum ascent and the maximum descent
-       double layoutasc = 0;
        double layoutdesc = 0;
+       ParagraphList const & pars = text_->paragraphs();
        double const dh = defaultRowHeight();
 
-       // ok, let us initialize the maxasc and maxdesc value.
-       // Only the fontsize count. The other properties
-       // are taken from the layoutfont. Nicer on the screen :)
-       Layout const & layout = par.layout();
-
-       // as max get the first character of this row then it can
-       // increase but not decrease the height. Just some point to
-       // start with so we don't have to do the assignment below too
-       // often.
-       Buffer const & buffer = bv_->buffer();
-       Font font = displayFont(pit, first);
-       FontSize const tmpsize = font.fontInfo().size();
-       font.fontInfo() = text_->layoutFont(buffer, pit);
-       FontSize const size = font.fontInfo().size();
-       font.fontInfo().setSize(tmpsize);
-
-       FontInfo labelfont = text_->labelFont(buffer, par);
-
-       FontMetrics const & labelfont_metrics = theFontMetrics(labelfont);
-       FontMetrics const & fontmetrics = theFontMetrics(font);
+       // add the layout spaces, for example before and after
+       // a section, or between the items of a itemize or enumerate
+       // environment
+       pit_type nextpit = pit + 1;
+       if (nextpit != pit_type(pars.size())) {
+               pit_type cpit = pit;
 
-       // these are minimum values
-       double const spacing_val = layout.spacing.getValue()
-               * text_->spacing(buffer, par);
-       //lyxerr << "spacing_val = " << spacing_val << endl;
-       int maxasc  = int(fontmetrics.maxAscent()  * spacing_val);
-       int maxdesc = int(fontmetrics.maxDescent() * spacing_val);
-
-       // insets may be taller
-       ParagraphMetrics const & pm = par_metrics_[pit];
-       InsetList::const_iterator ii = par.insetList().begin();
-       InsetList::const_iterator iend = par.insetList().end();
-       for ( ; ii != iend; ++ii) {
-               if (ii->pos >= first && ii->pos < end) {
-                       Dimension const & dim = pm.insetDimension(ii->inset);
-                       maxasc  = max(maxasc,  dim.ascent());
-                       maxdesc = max(maxdesc, dim.descent());
+               if (pars[cpit].getDepth() > pars[nextpit].getDepth()) {
+                       double usual = pars[cpit].layout().bottomsep * dh;
+                       double unusual = 0;
+                       cpit = text_->depthHook(cpit, pars[nextpit].getDepth());
+                       if (pars[cpit].layout() != pars[nextpit].layout()
+                               || pars[nextpit].getLabelWidthString() != pars[cpit].getLabelWidthString())
+                               unusual = pars[cpit].layout().bottomsep * dh;
+                       layoutdesc = max(unusual, usual);
+               } else if (pars[cpit].getDepth() == pars[nextpit].getDepth()) {
+                       if (pars[cpit].layout() != pars[nextpit].layout()
+                               || pars[nextpit].getLabelWidthString() != pars[cpit].getLabelWidthString())
+                               layoutdesc = int(pars[cpit].layout().bottomsep * dh);
                }
        }
 
-       // Check if any custom fonts are larger (Asger)
-       // This is not completely correct, but we can live with the small,
-       // cosmetic error for now.
-       int labeladdon = 0;
-
-       FontSize maxsize =
-               par.highestFontInRange(first, end, size);
-       if (maxsize > font.fontInfo().size()) {
-               // use standard paragraph font with the maximal size
-               FontInfo maxfont = font.fontInfo();
-               maxfont.setSize(maxsize);
-               FontMetrics const & maxfontmetrics = theFontMetrics(maxfont);
-               maxasc  = max(maxasc,  maxfontmetrics.maxAscent());
-               maxdesc = max(maxdesc, maxfontmetrics.maxDescent());
-       }
-
-       // This is nicer with box insets:
-       ++maxasc;
-       ++maxdesc;
-
-       ParagraphList const & pars = text_->paragraphs();
-
-       // is it a top line?
-       if (first == 0 && topBottomSpace) {
-               BufferParams const & bufparams = buffer.params();
-               // some parskips VERY EASY IMPLEMENTATION
-               if (bufparams.paragraph_separation
-                   == BufferParams::ParagraphSkipSeparation
-                       && par.ownerCode() != ERT_CODE
-                       && par.ownerCode() != LISTINGS_CODE
-                       && pit > 0
-                       && ((layout.isParagraph() && par.getDepth() == 0)
-                           || (pars[pit - 1].layout().isParagraph()
-                               && pars[pit - 1].getDepth() == 0)))
-               {
-                               maxasc += bufparams.getDefSkip().inPixels(*bv_);
-               }
-
-               if (par.params().startOfAppendix())
-                       maxasc += int(3 * dh);
-
-               // This is special code for the chapter, since the label of this
-               // layout is printed in an extra row
-               if (layout.counter == "chapter"
-                   && !par.params().labelString().empty()) {
-                       labeladdon = int(labelfont_metrics.maxHeight()
-                                    * layout.spacing.getValue()
-                                    * text_->spacing(buffer, par));
-               }
-
-               // special code for the top label
-               if ((layout.labeltype == LABEL_TOP_ENVIRONMENT
-                    || layout.labeltype == LABEL_BIBLIO
-                    || layout.labeltype == LABEL_CENTERED_TOP_ENVIRONMENT)
-                   && isFirstInSequence(pit, pars)
-                   && !par.labelString().empty())
-               {
-                       labeladdon = int(
-                                 labelfont_metrics.maxHeight()
-                                       * layout.spacing.getValue()
-                                       * text_->spacing(buffer, par)
-                               + (layout.topsep + layout.labelbottomsep) * dh);
-               }
-
-               // Add the layout spaces, for example before and after
-               // a section, or between the items of a itemize or enumerate
-               // environment.
-
-               pit_type prev = depthHook(pit, pars, par.getDepth());
-               Paragraph const & prevpar = pars[prev];
-               if (prev != pit
-                   && prevpar.layout() == layout
-                   && prevpar.getDepth() == par.getDepth()
-                   && prevpar.getLabelWidthString()
-                                       == par.getLabelWidthString()) {
-                       layoutasc = layout.itemsep * dh;
-               } else if (pit != 0 || first != 0) {
-                       if (layout.topsep > 0)
-                               layoutasc = layout.topsep * dh;
-               }
-
-               prev = outerHook(pit, pars);
-               if (prev != pit_type(pars.size())) {
-                       maxasc += int(pars[prev].layout().parsep * dh);
-               } else if (pit != 0) {
-                       Paragraph const & prevpar = pars[pit - 1];
-                       if (prevpar.getDepth() != 0 ||
-                                       prevpar.layout() == layout) {
-                               maxasc += int(layout.parsep * dh);
-                       }
-               }
-       }
+       return int(layoutdesc * 2 / (2 + pars[pit].getDepth()));
+}
 
-       // is it a bottom line?
-       if (end >= par.size() && topBottomSpace) {
-               // add the layout spaces, for example before and after
-               // a section, or between the items of a itemize or enumerate
-               // environment
-               pit_type nextpit = pit + 1;
-               if (nextpit != pit_type(pars.size())) {
-                       pit_type cpit = pit;
-                       double usual = 0;
-                       double unusual = 0;
 
-                       if (pars[cpit].getDepth() > pars[nextpit].getDepth()) {
-                               usual = pars[cpit].layout().bottomsep * dh;
-                               cpit = depthHook(cpit, pars, pars[nextpit].getDepth());
-                               if (pars[cpit].layout() != pars[nextpit].layout()
-                                       || pars[nextpit].getLabelWidthString() != pars[cpit].getLabelWidthString())
-                               {
-                                       unusual = pars[cpit].layout().bottomsep * dh;
-                               }
-                               layoutdesc = max(unusual, usual);
-                       } else if (pars[cpit].getDepth() == pars[nextpit].getDepth()) {
-                               if (pars[cpit].layout() != pars[nextpit].layout()
-                                       || pars[nextpit].getLabelWidthString() != pars[cpit].getLabelWidthString())
-                                       layoutdesc = int(pars[cpit].layout().bottomsep * dh);
-                       }
+void TextMetrics::setRowHeight(Row & row) const
+{
+       Paragraph const & par = text_->getPar(row.pit());
+       Layout const & layout = par.layout();
+       double const spacing_val = layout.spacing.getValue() * text_->spacing(par);
+
+       // Initial value for ascent (useful if row is empty).
+       Font const font = displayFont(row.pit(), row.pos());
+       FontMetrics const & fm = theFontMetrics(font);
+       int maxasc = int(fm.maxAscent() * spacing_val);
+       int maxdes = int(fm.maxDescent() * spacing_val);
+
+       // Find the ascent/descent of the row contents
+       Row::const_iterator cit = row.begin();
+       Row::const_iterator cend = row.end();
+       for ( ; cit != cend; ++cit) {
+               if (cit->inset) {
+                       maxasc = max(maxasc, cit->dim.ascent());
+                       maxdes = max(maxdes, cit->dim.descent());
+               } else {
+                       FontMetrics const & fm = theFontMetrics(cit->font);
+                       maxasc = max(maxasc, int(fm.maxAscent() * spacing_val));
+                       maxdes = max(maxdes, int(fm.maxDescent() * spacing_val));
                }
        }
 
-       // incalculate the layout spaces
-       maxasc  += int(layoutasc  * 2 / (2 + pars[pit].getDepth()));
-       maxdesc += int(layoutdesc * 2 / (2 + pars[pit].getDepth()));
-
-       // FIXME: the correct way is to do the following is to move the
-       // following code in another method specially tailored for the
-       // main Text. The following test is thus bogus.
-       // Top and bottom margin of the document (only at top-level)
-       if (main_text_ && topBottomSpace) {
-               if (pit == 0 && first == 0)
-                       maxasc += 20;
-               if (pit + 1 == pit_type(pars.size()) &&
-                   end == par.size() &&
-                               !(end > 0 && par.isNewline(end - 1)))
-                       maxdesc += 20;
-       }
+       // This is nicer with box insets
+       ++maxasc;
+       ++maxdes;
 
-       return Dimension(0, maxasc + labeladdon, maxdesc);
+       row.dimension().asc = maxasc;
+       row.dimension().des = maxdes;
 }
 
 
 // x is an absolute screen coord
 // returns the column near the specified x-coordinate of the row
 // x is set to the real beginning of this column
-pos_type TextMetrics::getColumnNearX(pit_type const pit,
-               Row const & row, int & x, bool & boundary) const
+pos_type TextMetrics::getPosNearX(Row const & row, int & x,
+                                 bool & boundary) const
 {
-       Buffer const & buffer = bv_->buffer();
-
+       //LYXERR0("getPosNearX(" << x << ") row=" << row);
        /// For the main Text, it is possible that this pit is not
        /// yet in the CoordCache when moving cursor up.
        /// x Paragraph coordinate is always 0 for main text anyway.
        int const xo = origin_.x_;
        x -= xo;
-       Paragraph const & par = text_->getPar(pit);
-       Bidi bidi;
-       bidi.computeTables(par, buffer, row);
 
-       pos_type vc = row.pos();
-       pos_type end = row.endpos();
-       pos_type c = 0;
-       Layout const & layout = par.layout();
-
-       bool left_side = false;
-
-       pos_type body_pos = par.beginOfBody();
-
-       double tmpx = row.x;
-       double last_tmpx = tmpx;
-
-       if (body_pos > 0 &&
-           (body_pos > end || !par.isLineSeparator(body_pos - 1)))
-               body_pos = 0;
-
-       // check for empty row
-       if (vc == end) {
-               x = int(tmpx) + xo;
-               return 0;
-       }
-
-       while (vc < end && tmpx <= x) {
-               c = bidi.vis2log(vc);
-               last_tmpx = tmpx;
-               if (body_pos > 0 && c == body_pos - 1) {
-                       FontMetrics const & fm = theFontMetrics(
-                               text_->labelFont(buffer, par));
-                       tmpx += row.label_hfill + fm.width(layout.labelsep);
-                       if (par.isLineSeparator(body_pos - 1))
-                               tmpx -= singleWidth(pit, body_pos - 1);
-               }
-
-               tmpx += singleWidth(pit, c);
-               if (par.isSeparator(c) && c >= body_pos)
-                               tmpx += row.separator;
-               ++vc;
-       }
-
-       if ((tmpx + last_tmpx) / 2 > x) {
-               tmpx = last_tmpx;
-               left_side = true;
-       }
-
-       LASSERT(vc <= end, /**/);  // This shouldn't happen.
+       // Adapt to cursor row scroll offset if applicable.
+       int const offset = bv_->horizScrollOffset(text_, row.pit(), row.pos());
+       x += offset;
 
+       pos_type pos = row.pos();
        boundary = false;
-       // This (rtl_support test) is not needed, but gives
-       // some speedup if rtl_support == false
-       bool const lastrow = lyxrc.rtl_support && row.endpos() == par.size();
-
-       // If lastrow is false, we don't need to compute
-       // the value of rtl.
-       bool const rtl = lastrow ? text_->isRTL(buffer, par) : false;
-       if (lastrow &&
-           ((rtl  &&  left_side && vc == row.pos() && x < tmpx - 5) ||
-            (!rtl && !left_side && vc == end  && x > tmpx + 5))) {
-               if (!par.isNewline(end - 1))
-                       c = end;
-       } else if (vc == row.pos()) {
-               c = bidi.vis2log(vc);
-               if (bidi.level(c) % 2 == 1)
-                       ++c;
+       if (row.empty())
+               x = row.left_margin;
+       else if (x <= row.left_margin) {
+               pos = row.front().left_pos();
+               x = row.left_margin;
+       } else if (x >= row.width()) {
+               pos = row.back().right_pos();
+               x = row.width();
        } else {
-               c = bidi.vis2log(vc - 1);
-               bool const rtl = (bidi.level(c) % 2 == 1);
-               if (left_side == rtl) {
-                       ++c;
-                       boundary = isRTLBoundary(pit, c);
+               double w = row.left_margin;
+               Row::const_iterator cit = row.begin();
+               Row::const_iterator cend = row.end();
+               for ( ; cit != cend; ++cit) {
+                       if (w <= x &&  w + cit->full_width() > x) {
+                               int x_offset = int(x - w);
+                               pos = cit->x2pos(x_offset);
+                               x = int(x_offset + w);
+                               break;
+                       }
+                       w += cit->full_width();
+               }
+               if (cit == row.end()) {
+                       pos = row.back().right_pos();
+                       x = row.width();
                }
+               /** This tests for the case where the cursor is placed
+                * just before a font direction change. See comment on
+                * the boundary_ member in DocIterator.h to understand
+                * how boundary helps here.
+                */
+               else if (pos == cit->endpos
+                        && cit + 1 != row.end()
+                        && cit->isRTL() != (cit + 1)->isRTL())
+                       boundary = true;
        }
 
-// I believe this code is not needed anymore (Jug 20050717)
-#if 0
-       // The following code is necessary because the cursor position past
-       // the last char in a row is logically equivalent to that before
-       // the first char in the next row. That's why insets causing row
-       // divisions -- Newline and display-style insets -- must be treated
-       // specially, so cursor up/down doesn't get stuck in an air gap -- MV
-       // Newline inset, air gap below:
-       if (row.pos() < end && c >= end && par.isNewline(end - 1)) {
-               if (bidi.level(end -1) % 2 == 0)
-                       tmpx -= singleWidth(pit, end - 1);
+       /** This tests for the case where the cursor is set at the end
+        * of a row which has been broken due something else than a
+        * separator (a display inset or a forced breaking of the
+        * row). We know that there is a separator when the end of the
+        * row is larger than the end of its last element.
+        */
+       if (!row.empty() && pos == row.back().endpos
+           && row.back().endpos == row.endpos()) {
+               Inset const * inset = row.back().inset;
+               if (inset && (inset->lyxCode() == NEWLINE_CODE
+                             || inset->lyxCode() == SEPARATOR_CODE))
+                       pos = row.back().pos;
                else
-                       tmpx += singleWidth(pit, end - 1);
-               c = end - 1;
-       }
-
-       // Air gap above display inset:
-       if (row.pos() < end && c >= end && end < par.size()
-           && par.isInset(end) && par.getInset(end)->display()) {
-               c = end - 1;
+                       boundary = row.right_boundary();
        }
-       // Air gap below display inset:
-       if (row.pos() < end && c >= end && par.isInset(end - 1)
-           && par.getInset(end - 1)->display()) {
-               c = end - 1;
-       }
-#endif
 
-       x = int(tmpx) + xo;
-       pos_type const col = c - row.pos();
+       x += xo - offset;
+       //LYXERR0("getPosNearX ==> pos=" << pos << ", boundary=" << boundary);
 
-       if (!c || end == par.size())
-               return col;
-
-       if (c==end && !par.isLineSeparator(c-1) && !par.isNewline(c-1)) {
-               boundary = true;
-               return col;
-       }
-
-       return min(col, end - 1 - row.pos());
+       return pos;
 }
 
 
@@ -1274,10 +1161,10 @@ pos_type TextMetrics::x2pos(pit_type pit, int row, int x) const
        // upDownInText() while in selection mode.
        ParagraphMetrics const & pm = parMetrics(pit);
 
-       LASSERT(row < int(pm.rows().size()), /**/);
+       LBUFERR(row < int(pm.rows().size()));
        bool bound = false;
        Row const & r = pm.rows()[row];
-       return r.pos() + getColumnNearX(pit, r, x, bound);
+       return getPosNearX(r, x, bound);
 }
 
 
@@ -1320,7 +1207,8 @@ pit_type TextMetrics::getPitNearY(int y)
        int yy = -1;
        ParMetricsCache::const_iterator it = par_metrics_.begin();
        ParMetricsCache::const_iterator et = par_metrics_.end();
-       ParMetricsCache::const_iterator last = et; last--;
+       ParMetricsCache::const_iterator last = et;
+       --last;
 
        ParagraphMetrics const & pm = it->second;
 
@@ -1341,7 +1229,7 @@ pit_type TextMetrics::getPitNearY(int y)
 
        if (y >= last->second.position() + int(pm_last.descent())) {
                // We are looking for a position that is after the last paragraph in
-               // the cache (which is in priciple off-screen, that is before the
+               // the cache (which is in priciple off-screen), that is before the
                // visible part.
                pit = last->first + 1;
                if (pit == int(text_->paragraphs().size()))
@@ -1370,25 +1258,54 @@ pit_type TextMetrics::getPitNearY(int y)
 }
 
 
-Row const & TextMetrics::getRowNearY(int y, pit_type pit) const
+Row const & TextMetrics::getPitAndRowNearY(int & y, pit_type & pit,
+       bool assert_in_view, bool up)
 {
        ParagraphMetrics const & pm = par_metrics_[pit];
 
        int yy = pm.position() - pm.ascent();
-       LASSERT(!pm.rows().empty(), /**/);
+       LBUFERR(!pm.rows().empty());
        RowList::const_iterator rit = pm.rows().begin();
        RowList::const_iterator rlast = pm.rows().end();
        --rlast;
        for (; rit != rlast; yy += rit->height(), ++rit)
                if (yy + rit->height() > y)
                        break;
+
+       if (assert_in_view) {
+               if (!up && yy + rit->height() > y) {
+                       if (rit != pm.rows().begin()) {
+                               y = yy;
+                               --rit;
+                       } else if (pit != 0) {
+                               --pit;
+                               newParMetricsUp();
+                               ParagraphMetrics const & pm2 = par_metrics_[pit];
+                               rit = pm2.rows().end();
+                               --rit;
+                               y = yy;
+                       }
+               } else if (up && yy != y) {
+                       if (rit != rlast) {
+                               y = yy + rit->height();
+                               ++rit;
+                       } else if (pit < int(text_->paragraphs().size()) - 1) {
+                               ++pit;
+                               newParMetricsDown();
+                               ParagraphMetrics const & pm2 = par_metrics_[pit];
+                               rit = pm2.rows().begin();
+                               y = pm2.position();
+                       }
+               }
+       }
        return *rit;
 }
 
 
 // x,y are absolute screen coordinates
 // sets cursor recursively descending into nested editable insets
-Inset * TextMetrics::editXY(Cursor & cur, int x, int y)
+Inset * TextMetrics::editXY(Cursor & cur, int x, int y,
+       bool assert_in_view, bool up)
 {
        if (lyxerr.debugging(Debug::WORKAREA)) {
                LYXERR0("TextMetrics::editXY(cur, " << x << ", " << y << ")");
@@ -1397,58 +1314,63 @@ Inset * TextMetrics::editXY(Cursor & cur, int x, int y)
        pit_type pit = getPitNearY(y);
        LASSERT(pit != -1, return 0);
 
-       Row const & row = getRowNearY(y, pit);
-       bool bound = false;
+       int yy = y; // is modified by getPitAndRowNearY
+       Row const & row = getPitAndRowNearY(yy, pit, assert_in_view, up);
 
-       int xx = x; // is modified by getColumnNearX
-       pos_type const pos = row.pos()
-               + getColumnNearX(pit, row, xx, bound);
        cur.pit() = pit;
-       cur.pos() = pos;
-       cur.boundary(bound);
-       cur.setTargetX(x);
 
-       // try to descend into nested insets
-       Inset * inset = checkInsetHit(x, y);
-       //lyxerr << "inset " << inset << " hit at x: " << x << " y: " << y << endl;
-       if (!inset) {
-               // Either we deconst editXY or better we move current_font
-               // and real_current_font to Cursor
-               // FIXME: what is needed now that current_font and real_current_font
-               // are transferred?
+       // Do we cover an inset?
+       InsetList::InsetTable * it = checkInsetHit(pit, x, yy);
+
+       if (!it) {
+               // No inset, set position in the text
+               bool bound = false; // is modified by getPosNearX
+               int xx = x; // is modified by getPosNearX
+               cur.pos() = getPosNearX(row, xx, bound);
+               cur.boundary(bound);
                cur.setCurrentFont();
+               cur.setTargetX(xx);
                return 0;
        }
 
-       ParagraphList const & pars = text_->paragraphs();
-       Inset const * insetBefore = pos? pars[pit].getInset(pos - 1): 0;
-       //Inset * insetBehind = pars[pit].getInset(pos);
-
-       // This should be just before or just behind the
-       // cursor position set above.
-       LASSERT((pos != 0 && inset == insetBefore)
-               || inset == pars[pit].getInset(pos), /**/);
-
-       // Make sure the cursor points to the position before
-       // this inset.
-       if (inset == insetBefore) {
-               --cur.pos();
-               cur.boundary(false);
-       }
+       Inset * inset = it->inset;
+       //lyxerr << "inset " << inset << " hit at x: " << x << " y: " << y << endl;
+
+       // Set position in front of inset
+       cur.pos() = it->pos;
+       cur.boundary(false);
+       cur.setTargetX(x);
 
        // Try to descend recursively inside the inset.
-       inset = inset->editXY(cur, x, y);
+       Inset * edited = inset->editXY(cur, x, yy);
+       if (edited == inset && cur.pos() == it->pos) {
+               // non-editable inset, set cursor after the inset if x is
+               // nearer to that position (bug 9628)
+               CoordCache::Insets const & insetCache = bv_->coordCache().getInsets();
+               Dimension const & dim = insetCache.dim(inset);
+               Point p = insetCache.xy(inset);
+               bool const is_rtl = text_->isRTL(text_->getPar(pit));
+               if (is_rtl) {
+                       // "in front of" == "right of"
+                       if (abs(p.x_ - x) < abs(p.x_ + dim.wid - x))
+                               cur.posForward();
+               } else {
+                       // "in front of" == "left of"
+                       if (abs(p.x_ + dim.wid - x) < abs(p.x_ - x))
+                               cur.posForward();
+               }
+       }
 
        if (cur.top().text() == text_)
                cur.setCurrentFont();
-       return inset;
+       return edited;
 }
 
 
 void TextMetrics::setCursorFromCoordinates(Cursor & cur, int const x, int const y)
 {
-       LASSERT(text_ == cur.text(), /**/);
-       pit_type pit = getPitNearY(y);
+       LASSERT(text_ == cur.text(), return);
+       pit_type const pit = getPitNearY(y);
        LASSERT(pit != -1, return);
 
        ParagraphMetrics const & pm = par_metrics_[pit];
@@ -1458,7 +1380,7 @@ void TextMetrics::setCursorFromCoordinates(Cursor & cur, int const x, int const
                " pit: " << pit << " yy: " << yy);
 
        int r = 0;
-       LASSERT(pm.rows().size(), /**/);
+       LBUFERR(pm.rows().size());
        for (; r < int(pm.rows().size()) - 1; ++r) {
                Row const & row = pm.rows()[r];
                if (int(yy + row.height()) > y)
@@ -1472,7 +1394,7 @@ void TextMetrics::setCursorFromCoordinates(Cursor & cur, int const x, int const
 
        bool bound = false;
        int xx = x;
-       pos_type const pos = row.pos() + getColumnNearX(pit, row, xx, bound);
+       pos_type const pos = getPosNearX(row, xx, bound);
 
        LYXERR(Debug::DEBUG, "setting cursor pit: " << pit << " pos: " << pos);
 
@@ -1483,13 +1405,10 @@ void TextMetrics::setCursorFromCoordinates(Cursor & cur, int const x, int const
 
 
 //takes screen x,y coordinates
-Inset * TextMetrics::checkInsetHit(int x, int y)
+InsetList::InsetTable * TextMetrics::checkInsetHit(pit_type pit, int x, int y)
 {
-       pit_type pit = getPitNearY(y);
-       LASSERT(pit != -1, return 0);
-
        Paragraph const & par = text_->paragraphs()[pit];
-       ParagraphMetrics const & pm = par_metrics_[pit];
+       CoordCache::Insets const & insetCache = bv_->coordCache().getInsets();
 
        LYXERR(Debug::DEBUG, "x: " << x << " y: " << y << "  pit: " << pit);
 
@@ -1500,23 +1419,21 @@ Inset * TextMetrics::checkInsetHit(int x, int y)
 
                LYXERR(Debug::DEBUG, "examining inset " << inset);
 
-               if (!bv_->coordCache().getInsets().has(inset)) {
+               if (!insetCache.has(inset)) {
                        LYXERR(Debug::DEBUG, "inset has no cached position");
                        return 0;
                }
 
-               Dimension const & dim = pm.insetDimension(inset);
-               Point p = bv_->coordCache().getInsets().xy(inset);
+               Dimension const & dim = insetCache.dim(inset);
+               Point p = insetCache.xy(inset);
 
                LYXERR(Debug::DEBUG, "xo: " << p.x_ << "..." << p.x_ + dim.wid
                        << " yo: " << p.y_ - dim.asc << "..." << p.y_ + dim.des);
 
-               if (x >= p.x_
-                       && x <= p.x_ + dim.wid
-                       && y >= p.y_ - dim.asc
-                       && y <= p.y_ + dim.des) {
+               if (x >= p.x_ && x <= p.x_ + dim.wid
+                   && y >= p.y_ - dim.asc && y <= p.y_ + dim.des) {
                        LYXERR(Debug::DEBUG, "Hit inset: " << inset);
-                       return inset;
+                       return const_cast<InsetList::InsetTable *>(&(*iit));
                }
        }
 
@@ -1525,142 +1442,85 @@ Inset * TextMetrics::checkInsetHit(int x, int y)
 }
 
 
-int TextMetrics::cursorX(CursorSlice const & sl,
-               bool boundary) const
+//takes screen x,y coordinates
+Inset * TextMetrics::checkInsetHit(int x, int y)
 {
-       LASSERT(sl.text() == text_, /**/);
-       pit_type const pit = sl.pit();
-       Paragraph const & par = text_->paragraphs()[pit];
-       ParagraphMetrics const & pm = par_metrics_[pit];
-       if (pm.rows().empty())
-               return 0;
-
-       pos_type ppos = sl.pos();
-       // Correct position in front of big insets
-       bool const boundary_correction = ppos != 0 && boundary;
-       if (boundary_correction)
-               --ppos;
-
-       Row const & row = pm.getRow(sl.pos(), boundary);
-
-       pos_type cursor_vpos = 0;
-
-       Buffer const & buffer = bv_->buffer();
-       double x = row.x;
-       Bidi bidi;
-       bidi.computeTables(par, buffer, row);
-
-       pos_type const row_pos  = row.pos();
-       pos_type const end      = row.endpos();
-       // Spaces at logical line breaks in bidi text must be skipped during
-       // cursor positioning. However, they may appear visually in the middle
-       // of a row; they must be skipped, wherever they are...
-       // * logically "abc_[HEBREW_\nHEBREW]"
-       // * visually "abc_[_WERBEH\nWERBEH]"
-       pos_type skipped_sep_vpos = -1;
-
-       if (end <= row_pos)
-               cursor_vpos = row_pos;
-       else if (ppos >= end)
-               cursor_vpos = text_->isRTL(buffer, par) ? row_pos : end;
-       else if (ppos > row_pos && ppos >= end)
-               // Place cursor after char at (logical) position pos - 1
-               cursor_vpos = (bidi.level(ppos - 1) % 2 == 0)
-                       ? bidi.log2vis(ppos - 1) + 1 : bidi.log2vis(ppos - 1);
-       else
-               // Place cursor before char at (logical) position ppos
-               cursor_vpos = (bidi.level(ppos) % 2 == 0)
-                       ? bidi.log2vis(ppos) : bidi.log2vis(ppos) + 1;
-
-       pos_type body_pos = par.beginOfBody();
-       if (body_pos > 0 &&
-           (body_pos > end || !par.isLineSeparator(body_pos - 1)))
-               body_pos = 0;
+       pit_type const pit = getPitNearY(y);
+       LASSERT(pit != -1, return 0);
+       InsetList::InsetTable * it = checkInsetHit(pit, x, y);
 
-       // check for possible inline completion in this row
-       DocIterator const & inlineCompletionPos = bv_->inlineCompletionPos();
-       pos_type inlineCompletionVPos = -1;
-       if (inlineCompletionPos.inTexted()
-           && inlineCompletionPos.text() == text_
-           && inlineCompletionPos.pit() == pit
-           && inlineCompletionPos.pos() - 1 >= row_pos
-           && inlineCompletionPos.pos() - 1 < end) {
-               // draw logically behind the previous character
-               inlineCompletionVPos = bidi.log2vis(inlineCompletionPos.pos() - 1);
-       }
+       if (!it)
+               return 0;
 
-       // Use font span to speed things up, see below
-       FontSpan font_span;
-       Font font;
-
-       // If the last logical character is a separator, skip it, unless
-       // it's in the last row of a paragraph; see skipped_sep_vpos declaration
-       if (end > 0 && end < par.size() && par.isSeparator(end - 1))
-               skipped_sep_vpos = bidi.log2vis(end - 1);
-
-       // Inline completion RTL special case row_pos == cursor_pos:
-       // "__|b" => cursor_pos is right of __
-       if (row_pos == inlineCompletionVPos && row_pos == cursor_vpos) {
-               font = displayFont(pit, row_pos + 1);
-               docstring const & completion = bv_->inlineCompletion();
-               if (font.isRightToLeft() && completion.length() > 0)
-                       x += theFontMetrics(font.fontInfo()).width(completion);
-       }
+       return it->inset;
+}
 
-       for (pos_type vpos = row_pos; vpos < cursor_vpos; ++vpos) {
-               // Skip the separator which is at the logical end of the row
-               if (vpos == skipped_sep_vpos)
-                       continue;
-               pos_type pos = bidi.vis2log(vpos);
-               if (body_pos > 0 && pos == body_pos - 1) {
-                       FontMetrics const & labelfm = theFontMetrics(
-                               text_->labelFont(buffer, par));
-                       x += row.label_hfill + labelfm.width(par.layout().labelsep);
-                       if (par.isLineSeparator(body_pos - 1))
-                               x -= singleWidth(pit, body_pos - 1);
-               }
 
-               // Use font span to speed things up, see above
-               if (pos < font_span.first || pos > font_span.last) {
-                       font_span = par.fontSpan(pos);
-                       font = displayFont(pit, pos);
+Row::const_iterator const
+TextMetrics::findRowElement(Row const & row, pos_type const pos,
+                            bool const boundary, double & x) const
+{
+       /**
+        * When boundary is true, position i is in the row element (pos, endpos)
+        * if
+        *    pos < i <= endpos
+        * whereas, when boundary is false, the test is
+        *    pos <= i < endpos
+        * The correction below allows to handle both cases.
+       */
+       int const boundary_corr = (boundary && pos) ? -1 : 0;
+
+       x = row.left_margin;
+
+       /** Early return in trivial cases
+        * 1) the row is empty
+        * 2) the position is the left-most position of the row; there
+        * is a quirk here however: if the first element is virtual
+        * (end-of-par marker for example), then we have to look
+        * closer
+        */
+       if (row.empty()
+           || (pos == row.begin()->left_pos() && !boundary
+                       && !row.begin()->isVirtual()))
+               return row.begin();
+
+       Row::const_iterator cit = row.begin();
+       for ( ; cit != row.end() ; ++cit) {
+               /** Look whether the cursor is inside the element's
+                * span. Note that it is necessary to take the
+                * boundary into account, and to accept virtual
+                * elements, which have pos == endpos.
+                */
+               if (pos + boundary_corr >= cit->pos
+                   && (pos + boundary_corr < cit->endpos || cit->isVirtual())) {
+                               x += cit->pos2x(pos);
+                               break;
                }
+               x += cit->full_width();
+       }
 
-               x += pm.singleWidth(pos, font);
+       if (cit == row.end())
+               --cit;
 
-               // Inline completion RTL case:
-               // "a__|b", __ of b => non-boundary a-pos is right of __
-               if (vpos + 1 == inlineCompletionVPos
-                   && (vpos + 1 < cursor_vpos || !boundary_correction)) {
-                       font = displayFont(pit, vpos + 1);
-                       docstring const & completion = bv_->inlineCompletion();
-                       if (font.isRightToLeft() && completion.length() > 0)
-                               x += theFontMetrics(font.fontInfo()).width(completion);
-               }
+       return cit;
+}
 
-               //  Inline completion LTR case:
-               // "b|__a", __ of b => non-boundary a-pos is in front of __
-               if (vpos == inlineCompletionVPos
-                   && (vpos + 1 < cursor_vpos || boundary_correction)) {
-                       font = displayFont(pit, vpos);
-                       docstring const & completion = bv_->inlineCompletion();
-                       if (!font.isRightToLeft() && completion.length() > 0)
-                               x += theFontMetrics(font.fontInfo()).width(completion);
-               }
 
-               if (par.isSeparator(pos) && pos >= body_pos)
-                       x += row.separator;
-       }
+int TextMetrics::cursorX(CursorSlice const & sl,
+               bool boundary) const
+{
+       LASSERT(sl.text() == text_, return 0);
 
-       // see correction above
-       if (boundary_correction) {
-               if (isRTL(sl, boundary))
-                       x -= singleWidth(pit, ppos);
-               else
-                       x += singleWidth(pit, ppos);
-       }
+       ParagraphMetrics const & pm = par_metrics_[sl.pit()];
+       if (pm.rows().empty())
+               return 0;
+       Row const & row = pm.getRow(sl.pos(), boundary);
+       pos_type const pos = sl.pos();
 
+       double x = 0;
+       findRowElement(row, pos, boundary, x);
        return int(x);
+
 }
 
 
@@ -1692,7 +1552,7 @@ int TextMetrics::cursorY(CursorSlice const & sl, bool boundary) const
 
 bool TextMetrics::cursorHome(Cursor & cur)
 {
-       LASSERT(text_ == cur.text(), /**/);
+       LASSERT(text_ == cur.text(), return false);
        ParagraphMetrics const & pm = par_metrics_[cur.pit()];
        Row const & row = pm.getRow(cur.pos(),cur.boundary());
        return text_->setCursor(cur, cur.pit(), row.pos());
@@ -1701,7 +1561,7 @@ bool TextMetrics::cursorHome(Cursor & cur)
 
 bool TextMetrics::cursorEnd(Cursor & cur)
 {
-       LASSERT(text_ == cur.text(), /**/);
+       LASSERT(text_ == cur.text(), return false);
        // if not on the last row of the par, put the cursor before
        // the final space exept if I have a spanning inset or one string
        // is so long that we force a break.
@@ -1712,24 +1572,26 @@ bool TextMetrics::cursorEnd(Cursor & cur)
        bool boundary = false;
        if (end != cur.lastpos()) {
                if (!cur.paragraph().isLineSeparator(end-1)
-                   && !cur.paragraph().isNewline(end-1))
+                   && !cur.paragraph().isNewline(end-1)
+                   && !cur.paragraph().isEnvSeparator(end-1))
                        boundary = true;
                else
                        --end;
-       }
+       } else if (cur.paragraph().isEnvSeparator(end-1))
+               --end;
        return text_->setCursor(cur, cur.pit(), end, true, boundary);
 }
 
 
 void TextMetrics::deleteLineForward(Cursor & cur)
 {
-       LASSERT(text_ == cur.text(), /**/);
+       LASSERT(text_ == cur.text(), return);
        if (cur.lastpos() == 0) {
                // Paragraph is empty, so we just go forward
                text_->cursorForward(cur);
        } else {
                cur.resetAnchor();
-               cur.setSelection(true); // to avoid deletion
+               cur.selection(true); // to avoid deletion
                cursorEnd(cur);
                cur.setSelection();
                // What is this test for ??? (JMarc)
@@ -1742,24 +1604,22 @@ void TextMetrics::deleteLineForward(Cursor & cur)
 }
 
 
-bool TextMetrics::isLastRow(pit_type pit, Row const & row) const
+bool TextMetrics::isLastRow(Row const & row) const
 {
        ParagraphList const & pars = text_->paragraphs();
-       return row.endpos() >= pars[pit].size()
-               && pit + 1 == pit_type(pars.size());
+       return row.endpos() >= pars[row.pit()].size()
+               && row.pit() + 1 == pit_type(pars.size());
 }
 
 
-bool TextMetrics::isFirstRow(pit_type pit, Row const & row) const
+bool TextMetrics::isFirstRow(Row const & row) const
 {
-       return row.pos() == 0 && pit == 0;
+       return row.pos() == 0 && row.pit() == 0;
 }
 
 
 int TextMetrics::leftMargin(int max_width, pit_type pit) const
 {
-       LASSERT(pit >= 0, /**/);
-       LASSERT(pit < int(text_->paragraphs().size()), /**/);
        return leftMargin(max_width, pit, text_->paragraphs()[pit].size());
 }
 
@@ -1769,32 +1629,44 @@ int TextMetrics::leftMargin(int max_width,
 {
        ParagraphList const & pars = text_->paragraphs();
 
-       LASSERT(pit >= 0, /**/);
-       LASSERT(pit < int(pars.size()), /**/);
+       LASSERT(pit >= 0, return 0);
+       LASSERT(pit < int(pars.size()), return 0);
        Paragraph const & par = pars[pit];
-       LASSERT(pos >= 0, /**/);
-       LASSERT(pos <= par.size(), /**/);
+       LASSERT(pos >= 0, return 0);
+       LASSERT(pos <= par.size(), return 0);
        Buffer const & buffer = bv_->buffer();
        //lyxerr << "TextMetrics::leftMargin: pit: " << pit << " pos: " << pos << endl;
        DocumentClass const & tclass = buffer.params().documentClass();
        Layout const & layout = par.layout();
+       FontMetrics const & bfm = theFontMetrics(buffer.params().getFont());
 
        docstring parindent = layout.parindent;
 
        int l_margin = 0;
 
-       if (text_->isMainText(buffer))
+       if (text_->isMainText())
                l_margin += bv_->leftMargin();
 
-       l_margin += theFontMetrics(buffer.params().getFont()).signedWidth(
-               tclass.leftmargin());
+       l_margin += bfm.signedWidth(tclass.leftmargin());
 
-       if (par.getDepth() != 0) {
+       int depth = par.getDepth();
+       if (depth != 0) {
                // find the next level paragraph
-               pit_type newpar = outerHook(pit, pars);
+               pit_type newpar = text_->outerHook(pit);
                if (newpar != pit_type(pars.size())) {
                        if (pars[newpar].layout().isEnvironment()) {
-                               l_margin = leftMargin(max_width, newpar);
+                               int nestmargin = depth * nestMargin();
+                               if (text_->isMainText())
+                                       nestmargin += changebarMargin();
+                               l_margin = max(leftMargin(max_width, newpar), nestmargin);
+                               // Remove the parindent that has been added
+                               // if the paragraph was empty.
+                               if (pars[newpar].empty() &&
+                                   buffer.params().paragraph_separation ==
+                                   BufferParams::ParagraphIndentSeparation) {
+                                       docstring pi = pars[newpar].layout().parindent;
+                                       l_margin -= bfm.signedWidth(pi);
+                               }
                        }
                        if (tclass.isDefaultLayout(par.layout())
                            || tclass.isPlainLayout(par.layout())) {
@@ -1806,45 +1678,52 @@ int TextMetrics::leftMargin(int max_width,
                }
        }
 
-       // This happens after sections in standard classes. The 1.3.x
-       // code compared depths too, but it does not seem necessary
-       // (JMarc)
-       if (tclass.isDefaultLayout(par.layout())
-           && pit > 0 && pars[pit - 1].layout().nextnoindent)
+       // This happens after sections or environments in standard classes.
+       // We have to check the previous layout at same depth.
+       if (buffer.params().paragraph_separation ==
+                       BufferParams::ParagraphSkipSeparation)
                parindent.erase();
+       else if (pit > 0 && pars[pit - 1].getDepth() >= par.getDepth()) {
+               pit_type prev = text_->depthHook(pit, par.getDepth());
+               if (par.layout() == pars[prev].layout()) {
+                       if (prev != pit - 1
+                           && pars[pit - 1].layout().nextnoindent)
+                               parindent.erase();
+               } else if (pars[prev].layout().nextnoindent)
+                       parindent.erase();
+       }
 
-       FontInfo const labelfont = text_->labelFont(buffer, par);
-       FontMetrics const & labelfont_metrics = theFontMetrics(labelfont);
+       FontInfo const labelfont = text_->labelFont(par);
+       FontMetrics const & lfm = theFontMetrics(labelfont);
 
        switch (layout.margintype) {
        case MARGIN_DYNAMIC:
                if (!layout.leftmargin.empty()) {
-                       l_margin += theFontMetrics(buffer.params().getFont()).signedWidth(
-                               layout.leftmargin);
+                       l_margin += bfm.signedWidth(layout.leftmargin);
                }
                if (!par.labelString().empty()) {
-                       l_margin += labelfont_metrics.signedWidth(layout.labelindent);
-                       l_margin += labelfont_metrics.width(par.labelString());
-                       l_margin += labelfont_metrics.width(layout.labelsep);
+                       l_margin += lfm.signedWidth(layout.labelindent);
+                       l_margin += lfm.width(par.labelString());
+                       l_margin += lfm.width(layout.labelsep);
                }
                break;
 
        case MARGIN_MANUAL: {
-               l_margin += labelfont_metrics.signedWidth(layout.labelindent);
+               l_margin += lfm.signedWidth(layout.labelindent);
                // The width of an empty par, even with manual label, should be 0
                if (!par.empty() && pos >= par.beginOfBody()) {
                        if (!par.getLabelWidthString().empty()) {
                                docstring labstr = par.getLabelWidthString();
-                               l_margin += labelfont_metrics.width(labstr);
-                               l_margin += labelfont_metrics.width(layout.labelsep);
+                               l_margin += lfm.width(labstr);
+                               l_margin += lfm.width(layout.labelsep);
                        }
                }
                break;
        }
 
        case MARGIN_STATIC: {
-               l_margin += theFontMetrics(buffer.params().getFont()).
-                       signedWidth(layout.leftmargin) * 4      / (par.getDepth() + 4);
+               l_margin += bfm.signedWidth(layout.leftmargin) * 4
+                            / (par.getDepth() + 4);
                break;
        }
 
@@ -1852,38 +1731,37 @@ int TextMetrics::leftMargin(int max_width,
                if (layout.labeltype == LABEL_MANUAL) {
                        // if we are at position 0, we are never in the body
                        if (pos > 0 && pos >= par.beginOfBody())
-                               l_margin += labelfont_metrics.signedWidth(layout.leftmargin);
+                               l_margin += lfm.signedWidth(layout.leftmargin);
                        else
-                               l_margin += labelfont_metrics.signedWidth(layout.labelindent);
+                               l_margin += lfm.signedWidth(layout.labelindent);
                } else if (pos != 0
                           // Special case to fix problems with
                           // theorems (JMarc)
                           || (layout.labeltype == LABEL_STATIC
                               && layout.latextype == LATEX_ENVIRONMENT
-                              && !isFirstInSequence(pit, pars))) {
-                       l_margin += labelfont_metrics.signedWidth(layout.leftmargin);
-               } else if (layout.labeltype != LABEL_TOP_ENVIRONMENT
-                          && layout.labeltype != LABEL_BIBLIO
-                          && layout.labeltype !=
-                          LABEL_CENTERED_TOP_ENVIRONMENT) {
-                       l_margin += labelfont_metrics.signedWidth(layout.labelindent);
-                       l_margin += labelfont_metrics.width(layout.labelsep);
-                       l_margin += labelfont_metrics.width(par.labelString());
+                              && !text_->isFirstInSequence(pit))) {
+                       l_margin += lfm.signedWidth(layout.leftmargin);
+               } else if (!layout.labelIsAbove()) {
+                       l_margin += lfm.signedWidth(layout.labelindent);
+                       l_margin += lfm.width(layout.labelsep);
+                       l_margin += lfm.width(par.labelString());
                }
                break;
 
        case MARGIN_RIGHT_ADDRESS_BOX: {
 #if 0
-               // ok, a terrible hack. The left margin depends on the widest
-               // row in this paragraph.
-               RowList::iterator rit = par.rows().begin();
-               RowList::iterator end = par.rows().end();
-               // FIXME: This is wrong.
+               // The left margin depends on the widest row in this paragraph.
+               // This code is wrong because it depends on the rows, but at the
+               // same time this function is used in redoParagraph to construct
+               // the rows.
+               ParagraphMetrics const & pm = par_metrics_[pit];
+               RowList::const_iterator rit = pm.rows().begin();
+               RowList::const_iterator end = pm.rows().end();
                int minfill = max_width;
                for ( ; rit != end; ++rit)
                        if (rit->fill() < minfill)
                                minfill = rit->fill();
-               l_margin += theFontMetrics(params.getFont()).signedWidth(layout.leftmargin);
+               l_margin += bfm.signedWidth(layout.leftmargin);
                l_margin += minfill;
 #endif
                // also wrong, but much shorter.
@@ -1893,7 +1771,7 @@ int TextMetrics::leftMargin(int max_width,
        }
 
        if (!par.params().leftIndent().zero())
-               l_margin += par.params().leftIndent().inPixels(max_width);
+               l_margin += par.params().leftIndent().inPixels(max_width, lfm.em());
 
        LyXAlignment align;
 
@@ -1905,40 +1783,37 @@ int TextMetrics::leftMargin(int max_width,
        // set the correct parindent
        if (pos == 0
            && (layout.labeltype == LABEL_NO_LABEL
-              || layout.labeltype == LABEL_TOP_ENVIRONMENT
-              || layout.labeltype == LABEL_CENTERED_TOP_ENVIRONMENT
-              || (layout.labeltype == LABEL_STATIC
-                  && layout.latextype == LATEX_ENVIRONMENT
-                  && !isFirstInSequence(pit, pars)))
-           && align == LYX_ALIGN_BLOCK
+               || layout.labeltype == LABEL_ABOVE
+               || layout.labeltype == LABEL_CENTERED
+               || (layout.labeltype == LABEL_STATIC
+                   && layout.latextype == LATEX_ENVIRONMENT
+                   && !text_->isFirstInSequence(pit)))
+           && (align == LYX_ALIGN_BLOCK || align == LYX_ALIGN_LEFT)
            && !par.params().noindent()
            // in some insets, paragraphs are never indented
-           && !par.inInset().neverIndent()
+           && !text_->inset().neverIndent()
            // display style insets are always centered, omit indentation
            && !(!par.empty()
-                   && par.isInset(pos)
-                   && par.getInset(pos)->display())
-                       && (!(tclass.isDefaultLayout(par.layout())
-                || tclass.isPlainLayout(par.layout()))
-               || buffer.params().paragraph_separation == BufferParams::ParagraphIndentSeparation)
-           )
-       {
-               l_margin += theFontMetrics(buffer.params().getFont()).signedWidth(
-                       parindent);
-       }
+                && par.isInset(pos)
+                && par.getInset(pos)->display())
+           && (!(tclass.isDefaultLayout(par.layout())
+                 || tclass.isPlainLayout(par.layout()))
+               || buffer.params().paragraph_separation
+                               == BufferParams::ParagraphIndentSeparation)) {
+                       // use the parindent of the layout when the
+                       // default indentation is used otherwise use
+                       // the indentation set in the document
+                       // settings
+                       if (buffer.params().getIndentation().asLyXCommand() == "default")
+                               l_margin += bfm.signedWidth(parindent);
+                       else
+                               l_margin += buffer.params().getIndentation().inPixels(*bv_);
+               }
 
        return l_margin;
 }
 
 
-int TextMetrics::singleWidth(pit_type pit, pos_type pos) const
-{
-       ParagraphMetrics const & pm = par_metrics_[pit];
-
-       return pm.singleWidth(pos, displayFont(pit, pos));
-}
-
-
 void TextMetrics::draw(PainterInfo & pi, int x, int y) const
 {
        if (par_metrics_.empty())
@@ -1962,18 +1837,32 @@ void TextMetrics::draw(PainterInfo & pi, int x, int y) const
 }
 
 
-void TextMetrics::drawParagraph(PainterInfo & pi, pit_type pit, int x, int y) const
+void TextMetrics::drawParagraph(PainterInfo & pi, pit_type const pit, int const x, int y) const
 {
-       BufferParams const & bparams = bv_->buffer().params();
        ParagraphMetrics const & pm = par_metrics_[pit];
        if (pm.rows().empty())
                return;
-
-       Bidi bidi;
-       bool const original_drawing_state = pi.pain.isDrawingEnabled();
-       int const ww = bv_->workHeight();
        size_t const nrows = pm.rows().size();
 
+       // Use fast lane when drawing is disabled.
+       if (!pi.pain.isDrawingEnabled()) {
+               for (size_t i = 0; i != nrows; ++i) {
+
+                       Row const & row = pm.rows()[i];
+                       // Adapt to cursor row scroll offset if applicable.
+                       int row_x = x - bv_->horizScrollOffset(text_, pit, row.pos());
+                       if (i)
+                               y += row.ascent();
+
+                       RowPainter rp(pi, *text_, row, row_x, y);
+
+                       rp.paintOnlyInsets();
+                       y += row.descent();
+               }
+               return;
+       }
+
+       int const ww = bv_->workHeight();
        Cursor const & cur = bv_->cursor();
        DocIterator sel_beg = cur.selectionBegin();
        DocIterator sel_end = cur.selectionEnd();
@@ -1981,13 +1870,13 @@ void TextMetrics::drawParagraph(PainterInfo & pi, pit_type pit, int x, int y) co
                // This is our text.
                && cur.text() == text_
                // if the anchor is outside, this is not our selection
-               && cur.anchor().text() == text_
+               && cur.normalAnchor().text() == text_
                && pit >= sel_beg.pit() && pit <= sel_end.pit();
 
        // We store the begin and end pos of the selection relative to this par
        DocIterator sel_beg_par = cur.selectionBegin();
        DocIterator sel_end_par = cur.selectionEnd();
-       
+
        // We care only about visible selection.
        if (selection) {
                if (pit != sel_beg.pit()) {
@@ -2003,20 +1892,31 @@ void TextMetrics::drawParagraph(PainterInfo & pi, pit_type pit, int x, int y) co
        for (size_t i = 0; i != nrows; ++i) {
 
                Row const & row = pm.rows()[i];
+               // Adapt to cursor row scroll offset if applicable.
+               int row_x = x - bv_->horizScrollOffset(text_, pit, row.pos());
                if (i)
                        y += row.ascent();
 
+               RowPainter rp(pi, *text_, row, row_x, y);
+
+               // It is not needed to draw on screen if we are not inside.
                bool const inside = (y + row.descent() >= 0
                        && y - row.ascent() < ww);
-               // It is not needed to draw on screen if we are not inside.
-               pi.pain.setDrawingEnabled(inside && original_drawing_state);
-               RowPainter rp(pi, *text_, pit, row, bidi, x, y);
+               pi.pain.setDrawingEnabled(inside);
+               if (!inside) {
+                       // Paint only the insets to set inset cache correctly
+                       // FIXME: remove paintOnlyInsets when we know that positions
+                       // have already been set.
+                       rp.paintOnlyInsets();
+                       y += row.descent();
+                       continue;
+               }
 
                if (selection)
                        row.setSelectionAndMargins(sel_beg_par, sel_end_par);
                else
                        row.setSelection(-1, -1);
-               
+
                // The row knows nothing about the paragraph, so we have to check
                // whether this row is the first or last and update the margins.
                if (row.selection()) {
@@ -2027,8 +1927,14 @@ void TextMetrics::drawParagraph(PainterInfo & pi, pit_type pit, int x, int y) co
                }
 
                // Row signature; has row changed since last paint?
-               row.setCrc(pm.computeRowSignature(row, bparams));
-               bool row_has_changed = row.changed();
+               row.setCrc(pm.computeRowSignature(row, *bv_));
+               bool row_has_changed = row.changed()
+                       || bv_->hadHorizScrollOffset(text_, pit, row.pos());
+
+               // Take this opportunity to spellcheck the row contents.
+               if (row_has_changed && pi.do_spellcheck && lyxrc.spellcheck_continuously) {
+                       text_->getPar(pit).spellCheck();
+               }
 
                // Don't paint the row if a full repaint has not been requested
                // and if it has not changed.
@@ -2043,145 +1949,59 @@ void TextMetrics::drawParagraph(PainterInfo & pi, pit_type pit, int x, int y) co
                // Clear background of this row if paragraph background was not
                // already cleared because of a full repaint.
                if (!pi.full_repaint && row_has_changed) {
-                       pi.pain.fillRectangle(x, y - row.ascent(),
+                       LYXERR(Debug::PAINTING, "Clear rect@("
+                              << max(row_x, 0) << ", " << y - row.ascent() << ")="
+                              << width() << " x " << row.height());
+                       pi.pain.fillRectangle(max(row_x, 0), y - row.ascent(),
                                width(), row.height(), pi.background_color);
                }
-               
-               if (row.selection())
-                       drawRowSelection(pi, x, row, cur, pit);
 
                // Instrumentation for testing row cache (see also
                // 12 lines lower):
-               if (lyxerr.debugging(Debug::PAINTING) && inside
+               if (lyxerr.debugging(Debug::PAINTING)
                        && (row.selection() || pi.full_repaint || row_has_changed)) {
-                               string const foreword = text_->isMainText(bv_->buffer()) ?
+                               string const foreword = text_->isMainText() ?
                                        "main text redraw " : "inset text redraw: ";
                        LYXERR(Debug::PAINTING, foreword << "pit=" << pit << " row=" << i
                                << " row_selection="    << row.selection()
                                << " full_repaint="     << pi.full_repaint
-                               << " row_has_changed="  << row_has_changed);
+                               << " row_has_changed="  << row_has_changed
+                               << " drawingEnabled=" << pi.pain.isDrawingEnabled());
                }
 
                // Backup full_repaint status and force full repaint
                // for inner insets as the Row has been cleared out.
                bool tmp = pi.full_repaint;
                pi.full_repaint = true;
+
+               rp.paintSelection();
                rp.paintAppendix();
                rp.paintDepthBar();
                rp.paintChangeBar();
-               if (i == 0)
+               bool const is_rtl = text_->isRTL(text_->getPar(pit));
+               if (i == 0 && !is_rtl)
                        rp.paintFirst();
+               if (i == nrows - 1 && is_rtl)
+                       rp.paintLast();
                rp.paintText();
-               if (i == nrows - 1)
+               if (i == nrows - 1 && !is_rtl)
                        rp.paintLast();
+               if (i == 0 && is_rtl)
+                       rp.paintFirst();
+               rp.paintTooLargeMarks(row_x + row.left_x() < 0,
+                                     row_x + row.right_x() > bv_->workWidth());
                y += row.descent();
+
                // Restore full_repaint status.
                pi.full_repaint = tmp;
        }
        // Re-enable screen drawing for future use of the painter.
-       pi.pain.setDrawingEnabled(original_drawing_state);
+       pi.pain.setDrawingEnabled(true);
 
        //LYXERR(Debug::PAINTING, ".");
 }
 
 
-void TextMetrics::drawRowSelection(PainterInfo & pi, int x, Row const & row,
-               Cursor const & curs, pit_type pit) const
-{
-       DocIterator beg = curs.selectionBegin();
-       beg.pit() = pit;
-       beg.pos() = row.sel_beg;
-
-       DocIterator end = curs.selectionEnd();
-       end.pit() = pit;
-       end.pos() = row.sel_end;
-
-       bool const begin_boundary = beg.pos() >= row.endpos();
-       bool const end_boundary = row.sel_end == row.endpos();
-
-       Buffer & buffer = bv_->buffer();
-       DocIterator cur = beg;
-       cur.boundary(begin_boundary);
-       int x1 = cursorX(beg.top(), begin_boundary);
-       int x2 = cursorX(end.top(), end_boundary);
-       int const y1 = bv_->getPos(cur, cur.boundary()).y_ - row.ascent();
-       int const y2 = y1 + row.height();
-
-       int const rm = text_->isMainText(buffer) ? bv_->rightMargin() : 0;
-       int const lm = text_->isMainText(buffer) ? bv_->leftMargin() : 0;
-
-       // draw the margins
-       if (row.begin_margin_sel) {
-               if (text_->isRTL(buffer, beg.paragraph())) {
-                       pi.pain.fillRectangle(x + x1, y1,  width() - rm - x1, y2 - y1,
-                               Color_selection);
-               } else {
-                       pi.pain.fillRectangle(x + lm, y1, x1 - lm, y2 - y1,
-                               Color_selection);
-               }
-       }
-
-       if (row.end_margin_sel) {
-               if (text_->isRTL(buffer, beg.paragraph())) {
-                       pi.pain.fillRectangle(x + lm, y1, x2 - lm, y2 - y1,
-                               Color_selection);
-               } else {
-                       pi.pain.fillRectangle(x + x2, y1, width() - rm - x2, y2 - y1,
-                               Color_selection);
-               }
-       }
-
-       // if we are on a boundary from the beginning, it's probably
-       // a RTL boundary and we jump to the other side directly as this
-       // segement is 0-size and confuses the logic below
-       if (cur.boundary())
-               cur.boundary(false);
-
-       // go through row and draw from RTL boundary to RTL boundary
-       while (cur < end) {
-               bool drawNow = false;
-
-               // simplified cursorForward code below which does not
-               // descend into insets and which does not go into the
-               // next line. Compare the logic with the original cursorForward
-
-               // if left of boundary -> just jump to right side, but
-               // for RTL boundaries don't, because: abc|DDEEFFghi -> abcDDEEF|Fghi
-               if (cur.boundary()) {
-                       cur.boundary(false);
-               }       else if (isRTLBoundary(cur.pit(), cur.pos() + 1)) {
-                       // in front of RTL boundary -> Stay on this side of the boundary
-                       // because:  ab|cDDEEFFghi -> abc|DDEEFFghi
-                       ++cur.pos();
-                       cur.boundary(true);
-                       drawNow = true;
-               } else {
-                       // move right
-                       ++cur.pos();
-
-                       // line end?
-                       if (cur.pos() == row.endpos())
-                               cur.boundary(true);
-               }
-
-               if (x1 == -1) {
-                       // the previous segment was just drawn, now the next starts
-                       x1 = cursorX(cur.top(), cur.boundary());
-               }
-
-               if (!(cur < end) || drawNow) {
-                       x2 = cursorX(cur.top(), cur.boundary());
-                       pi.pain.fillRectangle(x + min(x1,x2), y1, abs(x2 - x1), y2 - y1,
-                               Color_selection);
-
-                       // reset x1, so it is set again next round (which will be on the
-                       // right side of a boundary or at the selection end)
-                       x1 = -1;
-               }
-       }
-}
-
-
 void TextMetrics::completionPosAndDim(Cursor const & cur, int & x, int & y,
        Dimension & dim) const
 {
@@ -2192,12 +2012,19 @@ void TextMetrics::completionPosAndDim(Cursor const & cur, int & x, int & y,
        DocIterator wordStart = bvcur;
        wordStart.pos() -= word.length();
 
-       // get position on screen of the word start and end
-       Point lxy = cur.bv().getPos(wordStart, false);
-       Point rxy = cur.bv().getPos(bvcur, bvcur.boundary());
-
        // calculate dimensions of the word
-       dim = rowHeight(bvcur.pit(), wordStart.pos(), bvcur.pos(), false);
+       Row row;
+       row.pit(bvcur.pit());
+       row.pos(wordStart.pos());
+       row.endpos(bvcur.pos());
+       setRowHeight(row);
+       dim = row.dimension();
+
+       // get position on screen of the word start and end
+       //FIXME: Is it necessary to explicitly set this to false?
+       wordStart.boundary(false);
+       Point lxy = cur.bv().getPos(wordStart);
+       Point rxy = cur.bv().getPos(bvcur);
        dim.wid = abs(rxy.x_ - lxy.x_);
 
        // calculate position of word
@@ -2208,15 +2035,6 @@ void TextMetrics::completionPosAndDim(Cursor const & cur, int & x, int & y,
        //lyxerr << " wordstart=" << wordStart << " bvcur=" << bvcur << " cur=" << cur << std::endl;
 }
 
-//int TextMetrics::pos2x(pit_type pit, pos_type pos) const
-//{
-//     ParagraphMetrics const & pm = par_metrics_[pit];
-//     Row const & r = pm.rows()[row];
-//     int x = 0;
-//     pos -= r.pos();
-//}
-
-
 int defaultRowHeight()
 {
        return int(theFontMetrics(sane_font).maxHeight() *  1.2);