]> git.lyx.org Git - lyx.git/blobdiff - src/TextMetrics.cpp
document my LFUN changes in the past
[lyx.git] / src / TextMetrics.cpp
index 39fddf750290c3d1b46bfe48dc17b45282bbb96a..8321b34ecadd030585ea06824e13f3dbfafbeb6b 100644 (file)
 #include "buffer_funcs.h"
 #include "BufferParams.h"
 #include "BufferView.h"
-#include "Color.h"
+#include "CoordCache.h"
+#include "Cursor.h"
 #include "CutAndPaste.h"
-#include "debug.h"
+#include "support/debug.h"
 #include "FontIterator.h"
 #include "FuncRequest.h"
 #include "InsetList.h"
 #include "ParIterator.h"
 #include "rowpainter.h"
 #include "Text.h"
+#include "TextClass.h"
 #include "VSpace.h"
 
+#include "mathed/MacroTable.h"
+#include "mathed/MathMacroTemplate.h"
+
 #include "frontends/FontMetrics.h"
 #include "frontends/Painter.h"
 
-#include <boost/current_function.hpp>
-
 using std::make_pair;
 using std::max;
 using std::min;
-using std::endl;
 using std::pair;
 
 namespace lyx {
@@ -155,17 +157,15 @@ pair<pit_type, ParagraphMetrics const *> TextMetrics::last() const
 }
 
 
-ParagraphMetrics & TextMetrics::parMetrics(pit_type pit,
-               bool redo)
+ParagraphMetrics & TextMetrics::parMetrics(pit_type pit, bool redo)
 {
        ParMetricsCache::iterator pmc_it = par_metrics_.find(pit);
        if (pmc_it == par_metrics_.end()) {
                pmc_it = par_metrics_.insert(
                        make_pair(pit, ParagraphMetrics(text_->getPar(pit)))).first;
        }
-       if (pmc_it->second.rows().empty() && redo) {
+       if (pmc_it->second.rows().empty() && redo)
                redoParagraph(pit);
-       }
        return pmc_it->second;
 }
 
@@ -174,7 +174,7 @@ int TextMetrics::parPosition(pit_type pit) const
 {
        if (pit < par_metrics_.begin()->first)
                return -1000000;
-       else if (pit > par_metrics_.rbegin()->first)
+       if (pit > par_metrics_.rbegin()->first)
                return +1000000;
 
        return par_metrics_[pit].position();
@@ -236,8 +236,8 @@ int TextMetrics::rightMargin(pit_type const pit) const
 void TextMetrics::applyOuterFont(Font & font) const
 {
        Font lf(font_);
-       lf.reduce(bv_->buffer().params().getFont());
-       lf.realize(font);
+       lf.fontInfo().reduce(bv_->buffer().params().getFont().fontInfo());
+       lf.fontInfo().realize(font.fontInfo());
        lf.setLanguage(font.language());
        font = lf;
 }
@@ -262,21 +262,22 @@ Font TextMetrics::getDisplayFont(pit_type pit, pos_type pos) const
                        applyOuterFont(f);
                bool lab = layout->labeltype == LABEL_MANUAL && pos < body_pos;
 
-               Font const & lf = lab ? layout->labelfont : layout->font;
-               Font rlf = lab ? layout->reslabelfont : layout->resfont;
+               FontInfo const & lf = lab ? layout->labelfont : layout->font;
+               FontInfo rlf = lab ? layout->reslabelfont : layout->resfont;
                
                // In case the default family has been customized
-               if (lf.family() == Font::INHERIT_FAMILY)
-                       rlf.setFamily(params.getFont().family());
-               return f.realize(rlf);
+               if (lf.family() == INHERIT_FAMILY)
+                       rlf.setFamily(params.getFont().fontInfo().family());
+               f.fontInfo().realize(rlf);
+               return f;
        }
 
        // The uncommon case need not be optimized as much
-       Font const & layoutfont = pos < body_pos ? 
+       FontInfo const & layoutfont = pos < body_pos ? 
                layout->labelfont : layout->font;
 
        Font font = par.getFontSettings(params, pos);
-       font.realize(layoutfont);
+       font.fontInfo().realize(layoutfont);
 
        if (!text_->isMainText(buffer))
                applyOuterFont(font);
@@ -285,10 +286,10 @@ Font TextMetrics::getDisplayFont(pit_type pit, pos_type pos) const
        // NOTE: the cast to pit_type should be removed when pit_type
        // changes to a unsigned integer.
        if (pit < pit_type(pars.size()))
-               font.realize(outerFont(pit, pars));
+               font.fontInfo().realize(outerFont(pit, pars).fontInfo());
 
        // Realize with the fonts of lesser depth.
-       font.realize(params.getFont());
+       font.fontInfo().realize(params.getFont().fontInfo());
 
        return font;
 }
@@ -355,7 +356,6 @@ bool TextMetrics::redoParagraph(pit_type const pit)
        pm.reset(par);
 
        Buffer & buffer = bv_->buffer();
-       BufferParams const & bparams = buffer.params();
        main_text_ = (text_ == &buffer.text());
        bool changed = false;
 
@@ -367,11 +367,11 @@ bool TextMetrics::redoParagraph(pit_type const pit)
        // when layout is set; when material is pasted.
        int const moveCursor = par.checkBiblio(buffer.params().trackChanges);
        if (moveCursor > 0)
-               const_cast<Cursor &>(bv_->cursor()).posRight();
+               const_cast<Cursor &>(bv_->cursor()).posForward();
        else if (moveCursor < 0) {
                Cursor & cursor = const_cast<Cursor &>(bv_->cursor());
                if (cursor.pos() >= -moveCursor)
-                       cursor.posLeft();
+                       cursor.posBackward();
        }
 
        // Optimisation: this is used in the next two loops
@@ -382,15 +382,40 @@ bool TextMetrics::redoParagraph(pit_type const pit)
        // FIXME: We should always use getFont(), see documentation of
        // noFontChange() in Inset.h.
        Font const bufferfont = buffer.params().getFont();
+       MacroContext mc(buffer, par);
        InsetList::const_iterator ii = par.insetList().begin();
        InsetList::const_iterator iend = par.insetList().end();
        for (; ii != iend; ++ii) {
+               // the macro must come here, _before_ the metric call, because
+               // the macro should see itself to detect recursions. To find out
+               // whether the macro definition is a redefinition it will look
+               // at the MacroData::redefinition_. So it doesn't get confused
+               // by the already existing macro definition of itself in the 
+               // macro context.
+               if (ii->inset->lyxCode() == MATHMACRO_CODE) {
+                       // get macro data
+                       MathMacroTemplate const & macroTemplate
+                       = static_cast<MathMacroTemplate const &>(*ii->inset);
+
+                       // valid?
+                       if (macroTemplate.validMacro()) {
+                               MacroData macro = macroTemplate.asMacroData();
+
+                               // redefinition?
+                               macro.setRedefinition(mc.has(macroTemplate.name()));
+
+                               // register macro (possibly overwrite the previous one of this paragraph)
+                               mc.insert(macroTemplate.name(), macro);
+                       }
+               }
+
+               // do the metric calculation
                Dimension dim;
                int const w = max_width_ - leftMargin(max_width_, pit, ii->pos)
                        - right_margin;
                Font const & font = ii->inset->noFontChange() ?
                        bufferfont : getDisplayFont(pit, ii->pos);
-               MetricsInfo mi(bv_, font, w);
+               MetricsInfo mi(bv_, font.fontInfo(), w, mc);
                ii->inset->metrics(mi, dim);
                Dimension const old_dim = pm.insetDimension(ii->inset);
                pm.setInsetDimension(ii->inset, dim);
@@ -433,8 +458,8 @@ bool TextMetrics::redoParagraph(pit_type const pit)
                        // for the computeRowMetrics() below.
                        dim_.wid = max_width_;
 
+               dim = rowHeight(pit, first, end);
                dim.wid = rowWidth(right_margin, pit, first, end);
-               boost::tie(dim.asc, dim.des) = rowHeight(pit, first, end);
                if (row_index == pm.rows().size())
                        pm.rows().push_back(Row());
                Row & row = pm.rows()[row_index];
@@ -448,7 +473,6 @@ bool TextMetrics::redoParagraph(pit_type const pit)
                row.setDimension(dim);
                int const max_row_width = max(dim_.wid, dim.wid);
                computeRowMetrics(pit, row, max_row_width);
-               pm.computeRowSignature(row, bparams);
                first = end;
                ++row_index;
 
@@ -462,9 +486,8 @@ bool TextMetrics::redoParagraph(pit_type const pit)
        // Make sure that if a par ends in newline, there is one more row
        // under it
        if (first > 0 && par.isNewline(first - 1)) {
-               Dimension dim;
+               Dimension dim = rowHeight(pit, first, first);
                dim.wid = rowWidth(right_margin, pit, first, first);
-               boost::tie(dim.asc, dim.des) = rowHeight(pit, first, first);
                if (row_index == pm.rows().size())
                        pm.rows().push_back(Row());
                Row & row = pm.rows()[row_index];
@@ -474,7 +497,6 @@ bool TextMetrics::redoParagraph(pit_type const pit)
                row.setDimension(dim);
                int const max_row_width = max(dim_.wid, dim.wid);
                computeRowMetrics(pit, row, max_row_width);
-               pm.computeRowSignature(row, bparams);
                pm.dim().des += dim.height();
        }
 
@@ -490,9 +512,7 @@ bool TextMetrics::redoParagraph(pit_type const pit)
 void TextMetrics::computeRowMetrics(pit_type const pit,
                Row & row, int width) const
 {
-
        row.label_hfill = 0;
-       row.hfill = 0;
        row.separator = 0;
 
        Buffer & buffer = bv_->buffer();
@@ -532,12 +552,11 @@ void TextMetrics::computeRowMetrics(pit_type const pit,
                        row.label_hfill = labelFill(pit, row) / double(nlh);
        }
 
-       // are there any hfills in the row?
-       int const nh = numberOfHfills(par, row);
-
-       if (nh) {
-               if (w > 0)
-                       row.hfill = w / nh;
+       double hfill = 0;
+       if (w > 0) {
+               // are there any hfills in the row?
+               if (int nh = numberOfHfills(par, row))
+                       hfill = w / double(nh);
        // we don't have to look at the alignment if it is ALIGN_LEFT and
        // if the row is already larger then the permitted width as then
        // we force the LEFT_ALIGN'edness!
@@ -554,21 +573,19 @@ void TextMetrics::computeRowMetrics(pit_type const pit,
                // The test on par.size() is to catch zero-size pars, which
                // would trigger the assert in Paragraph::getInset().
                //inset = par.size() ? par.getInset(row.pos()) : 0;
-               if (row.pos() < par.size()
-                   && par.isInset(row.pos()))
-               {
-                   switch(par.getInset(row.pos())->display()) {
-                       case Inset::AlignLeft:
-                               align = LYX_ALIGN_BLOCK;
-                               break;
-                       case Inset::AlignCenter:
-                               align = LYX_ALIGN_CENTER;
-                               break;
-                        case Inset::Inline:
-                        case Inset::AlignRight:
-                                // unchanged (use align)
-                                break;
-                    }
+               if (row.pos() < par.size() && par.isInset(row.pos())) {
+                       switch(par.getInset(row.pos())->display()) {
+                               case Inset::AlignLeft:
+                                       align = LYX_ALIGN_BLOCK;
+                                       break;
+                               case Inset::AlignCenter:
+                                       align = LYX_ALIGN_CENTER;
+                                       break;
+                               case Inset::Inline:
+                               case Inset::AlignRight:
+                                       // unchanged (use align)
+                                       break;
+                       }
                }
 
                switch (align) {
@@ -618,6 +635,30 @@ void TextMetrics::computeRowMetrics(pit_type const pit,
                                row.x += row.label_hfill;
                }
        }
+
+       pos_type const endpos = row.endpos();
+       pos_type body_pos = par.beginOfBody();
+       if (body_pos > 0
+               && (body_pos > endpos || !par.isLineSeparator(body_pos - 1)))
+               body_pos = 0;
+
+       ParagraphMetrics & pm = par_metrics_[pit];
+       InsetList::const_iterator ii = par.insetList().begin();
+       InsetList::const_iterator iend = par.insetList().end();
+       for ( ; ii != iend; ++ii) {
+               if (ii->pos >= endpos || ii->pos < row.pos()
+                       || ii->inset->lyxCode() != HFILL_CODE)
+                       continue;
+               Dimension dim = row.dimension();
+               if (pm.hfillExpansion(row, ii->pos))
+                       dim.wid = int(ii->pos >= body_pos ?
+                               max(hfill, 5.0) : row.label_hfill);
+               else
+                       dim.wid = 5;
+               // Cache the inset dimension. 
+               bv_->coordCache().insets().add(ii->inset, dim);
+               pm.setInsetDimension(ii->inset, dim);
+       }
 }
 
 
@@ -651,10 +692,8 @@ int TextMetrics::labelFill(pit_type const pit, Row const & row) const
 }
 
 
-namespace {
-
 // this needs special handling - only newlines count as a break point
-pos_type addressBreakPoint(pos_type i, Paragraph const & par)
+static pos_type addressBreakPoint(pos_type i, Paragraph const & par)
 {
        pos_type const end = par.size();
 
@@ -665,8 +704,6 @@ pos_type addressBreakPoint(pos_type i, Paragraph const & par)
        return end;
 }
 
-};
-
 
 int TextMetrics::labelEnd(pit_type const pit) const
 {
@@ -737,7 +774,6 @@ pit_type TextMetrics::rowBreakPoint(int width, pit_type const pit,
                                        point = i;
                                else
                                        point = i + 1;
-
                        }
                        // exit on last registered breakpoint:
                        break;
@@ -825,7 +861,7 @@ int TextMetrics::rowWidth(int right_margin, pit_type const pit,
 }
 
 
-boost::tuple<int, int> TextMetrics::rowHeight(pit_type const pit, pos_type const first,
+Dimension TextMetrics::rowHeight(pit_type const pit, pos_type const first,
                pos_type const end) const
 {
        Paragraph const & par = text_->getPar(pit);
@@ -845,12 +881,12 @@ boost::tuple<int, int> TextMetrics::rowHeight(pit_type const pit, pos_type const
        // often.
        Buffer const & buffer = bv_->buffer();
        Font font = getDisplayFont(pit, first);
-       Font::FONT_SIZE const tmpsize = font.size();
-       font = text_->getLayoutFont(buffer, pit);
-       Font::FONT_SIZE const size = font.size();
-       font.setSize(tmpsize);
+       FontSize const tmpsize = font.fontInfo().size();
+       font.fontInfo() = text_->getLayoutFont(buffer, pit);
+       FontSize const size = font.fontInfo().size();
+       font.fontInfo().setSize(tmpsize);
 
-       Font labelfont = text_->getLabelFont(buffer, par);
+       FontInfo labelfont = text_->getLabelFont(buffer, par);
 
        FontMetrics const & labelfont_metrics = theFontMetrics(labelfont);
        FontMetrics const & fontmetrics = theFontMetrics(font);
@@ -879,11 +915,11 @@ boost::tuple<int, int> TextMetrics::rowHeight(pit_type const pit, pos_type const
        // cosmetic error for now.
        int labeladdon = 0;
 
-       Font::FONT_SIZE maxsize =
+       FontSize maxsize =
                par.highestFontInRange(first, end, size);
-       if (maxsize > font.size()) {
+       if (maxsize > font.fontInfo().size()) {
                // use standard paragraph font with the maximal size
-               Font maxfont = font;
+               FontInfo maxfont = font.fontInfo();
                maxfont.setSize(maxsize);
                FontMetrics const & maxfontmetrics = theFontMetrics(maxfont);
                maxasc  = max(maxasc,  maxfontmetrics.maxAscent());
@@ -1012,7 +1048,7 @@ boost::tuple<int, int> TextMetrics::rowHeight(pit_type const pit, pos_type const
                        maxdesc += 20;
        }
 
-       return boost::make_tuple(maxasc + labeladdon, maxdesc);
+       return Dimension(0, maxasc + labeladdon, maxdesc);
 }
 
 
@@ -1030,7 +1066,6 @@ pos_type TextMetrics::getColumnNearX(pit_type const pit,
        int const xo = origin_.x_;
        x -= xo;
        Paragraph const & par = text_->getPar(pit);
-       ParagraphMetrics const & pm = par_metrics_[pit];
        Bidi bidi;
        bidi.computeTables(par, buffer, row);
 
@@ -1067,19 +1102,9 @@ pos_type TextMetrics::getColumnNearX(pit_type const pit,
                                tmpx -= singleWidth(pit, body_pos - 1);
                }
 
-               if (pm.hfillExpansion(row, c)) {
-                       tmpx += singleWidth(pit, c);
-                       if (c >= body_pos)
-                               tmpx += row.hfill;
-                       else
-                               tmpx += row.label_hfill;
-               } else if (par.isSeparator(c)) {
-                       tmpx += singleWidth(pit, c);
-                       if (c >= body_pos)
+               tmpx += singleWidth(pit, c);
+               if (par.isSeparator(c) && c >= body_pos)
                                tmpx += row.separator;
-               } else {
-                       tmpx += singleWidth(pit, c);
-               }
                ++vc;
        }
 
@@ -1204,13 +1229,10 @@ void TextMetrics::newParMetricsUp()
 pit_type TextMetrics::getPitNearY(int y)
 {
        BOOST_ASSERT(!text_->paragraphs().empty());
-       LYXERR(Debug::DEBUG)
-               << BOOST_CURRENT_FUNCTION
-               << ": y: " << y << " cache size: " << par_metrics_.size()
-               << endl;
+       LYXERR(Debug::DEBUG, "y: " << y << " cache size: " << par_metrics_.size());
 
        // look for highest numbered paragraph with y coordinate less than given y
-       pit_type pit = 0;
+       pit_type pit = -1;
        int yy = -1;
        ParMetricsCache::const_iterator it = par_metrics_.begin();
        ParMetricsCache::const_iterator et = par_metrics_.end();
@@ -1218,44 +1240,37 @@ pit_type TextMetrics::getPitNearY(int y)
 
        ParagraphMetrics const & pm = it->second;
 
-       // If we are off-screen (before the visible part)
-       if (y < 0
-               // and even before the first paragraph in the cache.
-               && y < it->second.position() - int(pm.ascent())) {
-               //  and we are not at the first paragraph in the inset.
+       if (y < it->second.position() - int(pm.ascent())) {
+               // We are looking for a position that is before the first paragraph in
+               // the cache (which is in priciple off-screen, that is before the
+               // visible part.
                if (it->first == 0)
+                       // We are already at the first paragraph in the inset.
                        return 0;
-               // then this is the paragraph we are looking for.
+               // OK, this is the paragraph we are looking for.
                pit = it->first - 1;
-               // rebreak it and update the CoordCache.
-               redoParagraph(pit);
-               par_metrics_[pit].setPosition(it->second.position() - pm.descent());
+               newParMetricsUp();
                return pit;
        }
 
        ParagraphMetrics const & pm_last = par_metrics_[last->first];
 
-       // If we are off-screen (after the visible part)
-       if (y > bv_->workHeight()
-               // and even after the first paragraph in the cache.
-               && y >= last->second.position() + int(pm_last.descent())) {
+       if (y >= last->second.position() + int(pm_last.descent())) {
+               // We are looking for a position that is after the last paragraph in
+               // the cache (which is in priciple off-screen, that is before the
+               // visible part.
                pit = last->first + 1;
-               //  and we are not at the last paragraph in the inset.
                if (pit == int(text_->paragraphs().size()))
+                       //  We are already at the last paragraph in the inset.
                        return last->first;
-               // then this is the paragraph we are looking for.
-               // rebreak it and update the CoordCache.
-               redoParagraph(pit);
-               par_metrics_[pit].setPosition(last->second.position() + pm_last.ascent());
+               // OK, this is the paragraph we are looking for.
+               newParMetricsDown();
                return pit;
        }
 
        for (; it != et; ++it) {
-               LYXERR(Debug::DEBUG)
-                       << BOOST_CURRENT_FUNCTION
-                       << "  examining: pit: " << it->first
-                       << " y: " << it->second.position()
-                       << endl;
+               LYXERR(Debug::DEBUG, "examining: pit: " << it->first
+                       << " y: " << it->second.position());
 
                ParagraphMetrics const & pm = par_metrics_[it->first];
 
@@ -1265,10 +1280,7 @@ pit_type TextMetrics::getPitNearY(int y)
                }
        }
 
-       LYXERR(Debug::DEBUG)
-               << BOOST_CURRENT_FUNCTION
-               << ": found best y: " << yy << " for pit: " << pit
-               << endl;
+       LYXERR(Debug::DEBUG, "found best y: " << yy << " for pit: " << pit);
 
        return pit;
 }
@@ -1295,7 +1307,7 @@ Row const & TextMetrics::getRowNearY(int y, pit_type pit) const
 Inset * TextMetrics::editXY(Cursor & cur, int x, int y)
 {
        if (lyxerr.debugging(Debug::WORKAREA)) {
-               lyxerr << "TextMetrics::editXY(cur, " << x << ", " << y << ")" << std::endl;
+               LYXERR0("TextMetrics::editXY(cur, " << x << ", " << y << ")");
                cur.bv().coordCache().dump();
        }
        pit_type pit = getPitNearY(y);
@@ -1357,12 +1369,8 @@ void TextMetrics::setCursorFromCoordinates(Cursor & cur, int const x, int const
        ParagraphMetrics const & pm = par_metrics_[pit];
 
        int yy = pm.position() - pm.ascent();
-       LYXERR(Debug::DEBUG)
-               << BOOST_CURRENT_FUNCTION
-               << ": x: " << x
-               << " y: " << y
-               << " pit: " << pit
-               << " yy: " << yy << endl;
+       LYXERR(Debug::DEBUG, "x: " << x << " y: " << y <<
+               " pit: " << pit << " yy: " << yy);
 
        int r = 0;
        BOOST_ASSERT(pm.rows().size());
@@ -1375,21 +1383,13 @@ void TextMetrics::setCursorFromCoordinates(Cursor & cur, int const x, int const
 
        Row const & row = pm.rows()[r];
 
-       LYXERR(Debug::DEBUG)
-               << BOOST_CURRENT_FUNCTION
-               << ": row " << r
-               << " from pos: " << row.pos()
-               << endl;
+       LYXERR(Debug::DEBUG, "row " << r << " from pos: " << row.pos());
 
        bool bound = false;
        int xx = x;
        pos_type const pos = row.pos() + getColumnNearX(pit, row, xx, bound);
 
-       LYXERR(Debug::DEBUG)
-               << BOOST_CURRENT_FUNCTION
-               << ": setting cursor pit: " << pit
-               << " pos: " << pos
-               << endl;
+       LYXERR(Debug::DEBUG, "setting cursor pit: " << pit << " pos: " << pos);
 
        text_->setCursor(cur, pit, pos, true, bound);
        // remember new position.
@@ -1406,51 +1406,36 @@ Inset * TextMetrics::checkInsetHit(int x, int y)
        Paragraph const & par = text_->paragraphs()[pit];
        ParagraphMetrics const & pm = par_metrics_[pit];
 
-       LYXERR(Debug::DEBUG)
-               << BOOST_CURRENT_FUNCTION
-               << ": x: " << x
-               << " y: " << y
-               << "  pit: " << pit
-               << endl;
+       LYXERR(Debug::DEBUG, "x: " << x << " y: " << y << "  pit: " << pit);
+
        InsetList::const_iterator iit = par.insetList().begin();
        InsetList::const_iterator iend = par.insetList().end();
        for (; iit != iend; ++iit) {
                Inset * inset = iit->inset;
 
-               LYXERR(Debug::DEBUG)
-                       << BOOST_CURRENT_FUNCTION
-                       << ": examining inset " << inset << endl;
+               LYXERR(Debug::DEBUG, "examining inset " << inset);
 
                if (!bv_->coordCache().getInsets().has(inset)) {
-                       LYXERR(Debug::DEBUG)
-                               << BOOST_CURRENT_FUNCTION
-                               << ": inset has no cached position" << endl;
+                       LYXERR(Debug::DEBUG, "inset has no cached position");
                        return 0;
                }
 
                Dimension const & dim = pm.insetDimension(inset);
                Point p = bv_->coordCache().getInsets().xy(inset);
 
-               LYXERR(Debug::DEBUG)
-                       << BOOST_CURRENT_FUNCTION
-                       << ": xo: " << p.x_ << "..." << p.x_ + dim.wid
-                       << " yo: " << p.y_ - dim.asc << "..." << p.y_ + dim.des
-                       << endl;
+               LYXERR(Debug::DEBUG, "xo: " << p.x_ << "..." << p.x_ + dim.wid
+                       << " yo: " << p.y_ - dim.asc << "..." << p.y_ + dim.des);
 
                if (x >= p.x_
                        && x <= p.x_ + dim.wid
                        && y >= p.y_ - dim.asc
                        && y <= p.y_ + dim.des) {
-                       LYXERR(Debug::DEBUG)
-                               << BOOST_CURRENT_FUNCTION
-                               << ": Hit inset: " << inset << endl;
+                       LYXERR(Debug::DEBUG, "Hit inset: " << inset);
                        return inset;
                }
        }
 
-       LYXERR(Debug::DEBUG)
-               << BOOST_CURRENT_FUNCTION
-               << ": No inset hit. " << endl;
+       LYXERR(Debug::DEBUG, "No inset hit. ");
        return 0;
 }
 
@@ -1537,9 +1522,7 @@ int TextMetrics::cursorX(CursorSlice const & sl,
 
                x += pm.singleWidth(pos, font);
 
-               if (pm.hfillExpansion(row, pos))
-                       x += (pos >= body_pos) ? row.hfill : row.label_hfill;
-               else if (par.isSeparator(pos) && pos >= body_pos)
+               if (par.isSeparator(pos) && pos >= body_pos)
                        x += row.separator;
        }
 
@@ -1742,7 +1725,7 @@ int TextMetrics::leftMargin(int max_width,
            && pit > 0 && pars[pit - 1].layout()->nextnoindent)
                parindent.erase();
 
-       Font const labelfont = text_->getLabelFont(buffer, par);
+       FontInfo const labelfont = text_->getLabelFont(buffer, par);
        FontMetrics const & labelfont_metrics = theFontMetrics(labelfont);
 
        switch (layout->margintype) {
@@ -1867,7 +1850,6 @@ int TextMetrics::singleWidth(pit_type pit, pos_type pos) const
 }
 
 
-// only used for inset right now. should also be used for main text
 void TextMetrics::draw(PainterInfo & pi, int x, int y) const
 {
        if (par_metrics_.empty())
@@ -1893,73 +1875,72 @@ void TextMetrics::draw(PainterInfo & pi, int x, int y) const
 
 void TextMetrics::drawParagraph(PainterInfo & pi, pit_type pit, int x, int y) const
 {
-//     lyxerr << "  paintPar: pit: " << pit << " at y: " << y << endl;
-       int const ww = bv_->workHeight();
-
+       BufferParams const & bparams = bv_->buffer().params();
        ParagraphMetrics const & pm = par_metrics_[pit];
        if (pm.rows().empty())
                return;
 
-       RowList::const_iterator const rb = pm.rows().begin();
-       RowList::const_iterator const re = pm.rows().end();
-
        Bidi bidi;
+       bool const original_drawing_state = pi.pain.isDrawingEnabled();
+       int const ww = bv_->workHeight();
+       size_t const nrows = pm.rows().size();
+
+       for (size_t i = 0; i != nrows; ++i) {
 
-       y -= rb->ascent();
-       for (RowList::const_iterator rit = rb; rit != re; ++rit) {
-               y += rit->ascent();
+               Row const & row = pm.rows()[i];
+               if (i)
+                       y += row.ascent();
 
-               bool const inside = (y + rit->descent() >= 0
-                       && y - rit->ascent() < ww);
-               // it is not needed to draw on screen if we are not inside.
-               pi.pain.setDrawingEnabled(inside);
-               RowPainter rp(pi, *text_, pit, *rit, bidi, x, y);
+               bool const inside = (y + row.descent() >= 0
+                       && y - row.ascent() < ww);
+               // It is not needed to draw on screen if we are not inside.
+               pi.pain.setDrawingEnabled(inside && original_drawing_state);
+               RowPainter rp(pi, *text_, pit, row, bidi, x, y);
 
                // Row signature; has row changed since last paint?
-               bool row_has_changed = rit->changed();
+               row.setCrc(pm.computeRowSignature(row, bparams));
+               bool row_has_changed = row.changed();
                
-               bool row_selection = rit->sel_beg != -1 && rit->sel_end != -1;
-
-               if (!row_selection && !pi.full_repaint && !row_has_changed) {
-                       // Paint the only the insets if the text itself is
+               // Don't paint the row if a full repaint has not been requested
+               // and if it has not changed.
+               if (!pi.full_repaint && !row_has_changed) {
+                       // Paint only the insets if the text itself is
                        // unchanged.
                        rp.paintOnlyInsets();
-                       y += rit->descent();
+                       y += row.descent();
                        continue;
                }
 
-               // Paint the row if a full repaint has been requested or it has
-               // changed.
-               // Clear background of this row
-               // (if paragraph background was not cleared)
-               if (row_selection || (!pi.full_repaint && row_has_changed)) {
-                       pi.pain.fillRectangle(x, y - rit->ascent(),
-                               width(), rit->height(),
-                               Color_color(Color::color(pi.background_color)));
+               // Clear background of this row if paragraph background was not
+               // already cleared because of a full repaint.
+               if (!pi.full_repaint && row_has_changed) {
+                       pi.pain.fillRectangle(x, y - row.ascent(),
+                               width(), row.height(), pi.background_color);
                }
+
+               bool row_selection = row.sel_beg != -1 && row.sel_end != -1;
                if (row_selection) {
                        DocIterator beg = bv_->cursor().selectionBegin();
                        DocIterator end = bv_->cursor().selectionEnd();
+                       bool const beg_margin = beg.pit() < pit && i == 0;
+                       bool const end_margin = end.pit() > pit && i == nrows - 1;
                        beg.pit() = pit;
-                       beg.pos() = rit->sel_beg;
-                       if (pit == end.pit()) {
-                               end.pos() = rit->sel_end;
-                       } else {
-                               end.pit() = pit + 1;
-                               end.pos() = 0;
-                       }
-                       drawSelection(pi, beg, end, x);
+                       beg.pos() = row.sel_beg;
+                       end.pit() = pit;
+                       end.pos() = row.sel_end;
+                       drawRowSelection(pi, x, row, beg, end, beg_margin, end_margin);
                }
 
                // Instrumentation for testing row cache (see also
                // 12 lines lower):
-               if (lyxerr.debugging(Debug::PAINTING)) {
-                       if (text_->isMainText(bv_->buffer()))
-                               LYXERR(Debug::PAINTING) << "\n{" << inside <<
-                               pi.full_repaint << row_has_changed << "}";
-                       else
-                               LYXERR(Debug::PAINTING) << "[" << inside <<
-                               pi.full_repaint << row_has_changed << "]";
+               if (lyxerr.debugging(Debug::PAINTING) && inside
+                       && (row_selection || pi.full_repaint || row_has_changed)) {
+                               std::string const foreword = text_->isMainText(bv_->buffer()) ?
+                                       "main text redraw " : "inset text redraw: ";
+                       LYXERR(Debug::PAINTING, foreword << "pit=" << pit << " row=" << i
+                               << " row_selection="    << row_selection
+                               << " full_repaint="     << pi.full_repaint
+                               << " row_has_changed="  << row_has_changed);
                }
 
                // Backup full_repaint status and force full repaint
@@ -1969,78 +1950,19 @@ void TextMetrics::drawParagraph(PainterInfo & pi, pit_type pit, int x, int y) co
                rp.paintAppendix();
                rp.paintDepthBar();
                rp.paintChangeBar();
-               if (rit == rb)
+               if (i == 0)
                        rp.paintFirst();
                rp.paintText();
-               if (rit + 1 == re)
+               if (i == nrows - 1)
                        rp.paintLast();
-               y += rit->descent();
+               y += row.descent();
                // Restore full_repaint status.
                pi.full_repaint = tmp;
        }
        // Re-enable screen drawing for future use of the painter.
-       pi.pain.setDrawingEnabled(true);
+       pi.pain.setDrawingEnabled(original_drawing_state);
 
-       //LYXERR(Debug::PAINTING) << "." << endl;
-}
-
-
-// FIXME: only take care of one row!
-void TextMetrics::drawSelection(PainterInfo & pi,
-       DocIterator const & beg, DocIterator const & end, int x) const
-{
-       ParagraphMetrics const & pm1 = parMetrics(beg.pit());
-       ParagraphMetrics const & pm2 = parMetrics(end.pit());
-       Row const & row1 = pm1.getRow(beg.pos(), beg.boundary());
-       Row const & row2 = pm2.getRow(end.pos(), end.boundary());
-
-       // clip above
-       int middleTop;
-       bool const clipAbove = (bv_->cursorStatus(beg) == CUR_ABOVE);
-       if (clipAbove)
-               middleTop = 0;
-       else
-               middleTop = bv_->getPos(beg, beg.boundary()).y_ + row1.descent();
-       
-       // clip below
-       int middleBottom;
-       bool const clipBelow = (bv_->cursorStatus(end) == CUR_BELOW);
-       if (clipBelow)
-               middleBottom = bv_->workHeight();
-       else
-               middleBottom = bv_->getPos(end, end.boundary()).y_ - row2.ascent();
-
-       // start and end in the same line?
-       if (!clipAbove && !clipBelow && &row1 == &row2)
-               // then only draw this row's selection
-               drawRowSelection(pi, x, row1, beg, end, false, false);
-       else {
-               if (!clipAbove) {
-                       // get row end
-                       DocIterator begRowEnd = beg;
-                       begRowEnd.pos() = row1.endpos();
-                       begRowEnd.boundary(true);
-                       
-                       // draw upper rectangle
-                       drawRowSelection(pi, x, row1, beg, begRowEnd, false, true);
-               }
-                       
-               if (middleTop < middleBottom) {
-                       // draw middle rectangle
-                       pi.pain.fillRectangle(x, middleTop, width(), middleBottom - middleTop,
-                               Color::selection);
-               }
-
-               if (!clipBelow) {
-                       // get row begin
-                       DocIterator endRowBeg = end;
-                       endRowBeg.pos() = row2.pos();
-                       endRowBeg.boundary(false);
-                       
-                       // draw low rectangle
-                       drawRowSelection(pi, x, row2, endRowBeg, end, true, false);
-               }
-       }
+       //LYXERR(Debug::PAINTING, ".");
 }
 
 
@@ -2058,16 +1980,16 @@ void TextMetrics::drawRowSelection(PainterInfo & pi, int x, Row const & row,
        // draw the margins
        if (drawOnBegMargin) {
                if (text_->isRTL(buffer, beg.paragraph()))
-                       pi.pain.fillRectangle(x + x1, y1, width() - x1, y2 - y1, Color::selection);
+                       pi.pain.fillRectangle(x + x1, y1, width() - x1, y2 - y1, Color_selection);
                else
-                       pi.pain.fillRectangle(x, y1, x1, y2 - y1, Color::selection);
+                       pi.pain.fillRectangle(x, y1, x1, y2 - y1, Color_selection);
        }
        
        if (drawOnEndMargin) {
                if (text_->isRTL(buffer, beg.paragraph()))
-                       pi.pain.fillRectangle(x, y1, x2, y2 - y1, Color::selection);
+                       pi.pain.fillRectangle(x, y1, x2, y2 - y1, Color_selection);
                else
-                       pi.pain.fillRectangle(x + x2, y1, width() - x2, y2 - y1, Color::selection);
+                       pi.pain.fillRectangle(x + x2, y1, width() - x2, y2 - y1, Color_selection);
        }
        
        // if we are on a boundary from the beginning, it's probably
@@ -2111,7 +2033,7 @@ void TextMetrics::drawRowSelection(PainterInfo & pi, int x, Row const & row,
                if (!(cur < end) || drawNow) {
                        x2 = cursorX(cur.top(), cur.boundary());
                        pi.pain.fillRectangle(x + min(x1,x2), y1, abs(x2 - x1), y2 - y1,
-                               Color::selection);
+                               Color_selection);
                        
                        // reset x1, so it is set again next round (which will be on the 
                        // right side of a boundary or at the selection end)
@@ -2131,7 +2053,7 @@ void TextMetrics::drawRowSelection(PainterInfo & pi, int x, Row const & row,
 
 int defaultRowHeight()
 {
-       return int(theFontMetrics(Font(Font::ALL_SANE)).maxHeight() *  1.2);
+       return int(theFontMetrics(sane_font).maxHeight() *  1.2);
 }
 
 } // namespace lyx