]> git.lyx.org Git - lyx.git/blobdiff - src/TextMetrics.cpp
Make the non-drawing cases faster in TextMetrics::drawParagraph
[lyx.git] / src / TextMetrics.cpp
index fdf0da692672c78798b2feb956187108df06c0b8..69ab7b5b26234ff62dfd5b8016ed7cb5ea1dfa44 100644 (file)
@@ -200,13 +200,13 @@ bool TextMetrics::metrics(MetricsInfo & mi, Dimension & dim, int min_width)
 
 int TextMetrics::rightMargin(ParagraphMetrics const & pm) const
 {
-       return main_text_? pm.rightMargin(*bv_) : 0;
+       return text_->isMainText() ? pm.rightMargin(*bv_) : 0;
 }
 
 
 int TextMetrics::rightMargin(pit_type const pit) const
 {
-       return main_text_? par_metrics_[pit].rightMargin(*bv_) : 0;
+       return text_->isMainText() ? par_metrics_[pit].rightMargin(*bv_) : 0;
 }
 
 
@@ -353,7 +353,6 @@ bool TextMetrics::redoParagraph(pit_type const pit)
        pm.reset(par);
 
        Buffer & buffer = bv_->buffer();
-       main_text_ = (text_ == &buffer.text());
        bool changed = false;
 
        // Check whether there are InsetBibItems that need fixing
@@ -952,15 +951,15 @@ void TextMetrics::setRowHeight(Row & row, pit_type const pit,
 
        FontInfo labelfont = text_->labelFont(par);
 
-       FontMetrics const & labelfont_metrics = theFontMetrics(labelfont);
-       FontMetrics const & fontmetrics = theFontMetrics(font);
+       FontMetrics const & lfm = theFontMetrics(labelfont);
+       FontMetrics const & fm = theFontMetrics(font);
 
        // these are minimum values
        double const spacing_val = layout.spacing.getValue()
                * text_->spacing(par);
        //lyxerr << "spacing_val = " << spacing_val << endl;
-       int maxasc  = int(fontmetrics.maxAscent()  * spacing_val);
-       int maxdesc = int(fontmetrics.maxDescent() * spacing_val);
+       int maxasc  = int(fm.maxAscent()  * spacing_val);
+       int maxdesc = int(fm.maxDescent() * spacing_val);
 
        // insets may be taller
        CoordCache::Insets const & insetCache = bv_->coordCache().getInsets();
@@ -1019,7 +1018,7 @@ void TextMetrics::setRowHeight(Row & row, pit_type const pit,
                    && (!layout.isParagraphGroup() || text_->isFirstInSequence(pit))
                    && !par.labelString().empty()) {
                        labeladdon = int(
-                                 labelfont_metrics.maxHeight()
+                                 lfm.maxHeight()
                                        * layout.spacing.getValue()
                                        * text_->spacing(par)
                                + (layout.topsep + layout.labelbottomsep) * dh);
@@ -1087,7 +1086,7 @@ void TextMetrics::setRowHeight(Row & row, pit_type const pit,
        // following code in another method specially tailored for the
        // main Text. The following test is thus bogus.
        // Top and bottom margin of the document (only at top-level)
-       if (main_text_ && topBottomSpace) {
+       if (text_->isMainText() && topBottomSpace) {
                if (pit == 0 && row.pos() == 0)
                        maxasc += 20;
                if (pit + 1 == pit_type(pars.size()) &&
@@ -1114,14 +1113,8 @@ pos_type TextMetrics::getPosNearX(Row const & row, int & x,
        int const xo = origin_.x_;
        x -= xo;
 
-       int offset = 0;
-       CursorSlice rowSlice(const_cast<InsetText &>(text_->inset()));
-       rowSlice.pit() = row.pit();
-       rowSlice.pos() = row.pos();
-
        // Adapt to cursor row scroll offset if applicable.
-       if (bv_->currentRowSlice() == rowSlice)
-               offset = bv_->horizScrollOffset();
+       int const offset = bv_->horizScrollOffset(text_, row.pit(), row.pos());
        x += offset;
 
        pos_type pos = row.pos();
@@ -1623,7 +1616,7 @@ void TextMetrics::deleteLineForward(Cursor & cur)
                text_->cursorForward(cur);
        } else {
                cur.resetAnchor();
-               cur.setSelection(true); // to avoid deletion
+               cur.selection(true); // to avoid deletion
                cursorEnd(cur);
                cur.setSelection();
                // What is this test for ??? (JMarc)
@@ -1670,6 +1663,7 @@ int TextMetrics::leftMargin(int max_width,
        //lyxerr << "TextMetrics::leftMargin: pit: " << pit << " pos: " << pos << endl;
        DocumentClass const & tclass = buffer.params().documentClass();
        Layout const & layout = par.layout();
+       FontMetrics const & bfm = theFontMetrics(buffer.params().getFont());
 
        docstring parindent = layout.parindent;
 
@@ -1678,8 +1672,7 @@ int TextMetrics::leftMargin(int max_width,
        if (text_->isMainText())
                l_margin += bv_->leftMargin();
 
-       l_margin += theFontMetrics(buffer.params().getFont()).signedWidth(
-               tclass.leftmargin());
+       l_margin += bfm.signedWidth(tclass.leftmargin());
 
        int depth = par.getDepth();
        if (depth != 0) {
@@ -1697,8 +1690,7 @@ int TextMetrics::leftMargin(int max_width,
                                    buffer.params().paragraph_separation ==
                                    BufferParams::ParagraphIndentSeparation) {
                                        docstring pi = pars[newpar].layout().parindent;
-                                       l_margin -= theFontMetrics(
-                                               buffer.params().getFont()).signedWidth(pi);
+                                       l_margin -= bfm.signedWidth(pi);
                                }
                        }
                        if (tclass.isDefaultLayout(par.layout())
@@ -1727,37 +1719,36 @@ int TextMetrics::leftMargin(int max_width,
        }
 
        FontInfo const labelfont = text_->labelFont(par);
-       FontMetrics const & labelfont_metrics = theFontMetrics(labelfont);
+       FontMetrics const & lfm = theFontMetrics(labelfont);
 
        switch (layout.margintype) {
        case MARGIN_DYNAMIC:
                if (!layout.leftmargin.empty()) {
-                       l_margin += theFontMetrics(buffer.params().getFont()).signedWidth(
-                               layout.leftmargin);
+                       l_margin += bfm.signedWidth(layout.leftmargin);
                }
                if (!par.labelString().empty()) {
-                       l_margin += labelfont_metrics.signedWidth(layout.labelindent);
-                       l_margin += labelfont_metrics.width(par.labelString());
-                       l_margin += labelfont_metrics.width(layout.labelsep);
+                       l_margin += lfm.signedWidth(layout.labelindent);
+                       l_margin += lfm.width(par.labelString());
+                       l_margin += lfm.width(layout.labelsep);
                }
                break;
 
        case MARGIN_MANUAL: {
-               l_margin += labelfont_metrics.signedWidth(layout.labelindent);
+               l_margin += lfm.signedWidth(layout.labelindent);
                // The width of an empty par, even with manual label, should be 0
                if (!par.empty() && pos >= par.beginOfBody()) {
                        if (!par.getLabelWidthString().empty()) {
                                docstring labstr = par.getLabelWidthString();
-                               l_margin += labelfont_metrics.width(labstr);
-                               l_margin += labelfont_metrics.width(layout.labelsep);
+                               l_margin += lfm.width(labstr);
+                               l_margin += lfm.width(layout.labelsep);
                        }
                }
                break;
        }
 
        case MARGIN_STATIC: {
-               l_margin += theFontMetrics(buffer.params().getFont()).
-                       signedWidth(layout.leftmargin) * 4      / (par.getDepth() + 4);
+               l_margin += bfm.signedWidth(layout.leftmargin) * 4
+                            / (par.getDepth() + 4);
                break;
        }
 
@@ -1765,20 +1756,20 @@ int TextMetrics::leftMargin(int max_width,
                if (layout.labeltype == LABEL_MANUAL) {
                        // if we are at position 0, we are never in the body
                        if (pos > 0 && pos >= par.beginOfBody())
-                               l_margin += labelfont_metrics.signedWidth(layout.leftmargin);
+                               l_margin += lfm.signedWidth(layout.leftmargin);
                        else
-                               l_margin += labelfont_metrics.signedWidth(layout.labelindent);
+                               l_margin += lfm.signedWidth(layout.labelindent);
                } else if (pos != 0
                           // Special case to fix problems with
                           // theorems (JMarc)
                           || (layout.labeltype == LABEL_STATIC
                               && layout.latextype == LATEX_ENVIRONMENT
                               && !text_->isFirstInSequence(pit))) {
-                       l_margin += labelfont_metrics.signedWidth(layout.leftmargin);
+                       l_margin += lfm.signedWidth(layout.leftmargin);
                } else if (!layout.labelIsAbove()) {
-                       l_margin += labelfont_metrics.signedWidth(layout.labelindent);
-                       l_margin += labelfont_metrics.width(layout.labelsep);
-                       l_margin += labelfont_metrics.width(par.labelString());
+                       l_margin += lfm.signedWidth(layout.labelindent);
+                       l_margin += lfm.width(layout.labelsep);
+                       l_margin += lfm.width(par.labelString());
                }
                break;
 
@@ -1795,7 +1786,7 @@ int TextMetrics::leftMargin(int max_width,
                for ( ; rit != end; ++rit)
                        if (rit->fill() < minfill)
                                minfill = rit->fill();
-               l_margin += theFontMetrics(buffer.params().getFont()).signedWidth(layout.leftmargin);
+               l_margin += bfm.signedWidth(layout.leftmargin);
                l_margin += minfill;
 #endif
                // also wrong, but much shorter.
@@ -1805,7 +1796,7 @@ int TextMetrics::leftMargin(int max_width,
        }
 
        if (!par.params().leftIndent().zero())
-               l_margin += par.params().leftIndent().inPixels(max_width, labelfont_metrics.em());
+               l_margin += par.params().leftIndent().inPixels(max_width, lfm.em());
 
        LyXAlignment align;
 
@@ -1839,8 +1830,7 @@ int TextMetrics::leftMargin(int max_width,
                        // the indentation set in the document
                        // settings
                        if (buffer.params().getIndentation().asLyXCommand() == "default")
-                               l_margin += theFontMetrics(
-                                       buffer.params().getFont()).signedWidth(parindent);
+                               l_margin += bfm.signedWidth(parindent);
                        else
                                l_margin += buffer.params().getIndentation().inPixels(*bv_);
                }
@@ -1874,15 +1864,31 @@ void TextMetrics::draw(PainterInfo & pi, int x, int y) const
 
 void TextMetrics::drawParagraph(PainterInfo & pi, pit_type const pit, int const x, int y) const
 {
-       BufferParams const & bparams = bv_->buffer().params();
        ParagraphMetrics const & pm = par_metrics_[pit];
        if (pm.rows().empty())
                return;
-
-       bool const original_drawing_state = pi.pain.isDrawingEnabled();
-       int const ww = bv_->workHeight();
        size_t const nrows = pm.rows().size();
 
+       // Use fast lane when drawing is disabled.
+       if (!pi.pain.isDrawingEnabled()) {
+               for (size_t i = 0; i != nrows; ++i) {
+
+                       Row const & row = pm.rows()[i];
+                       // Adapt to cursor row scroll offset if applicable.
+                       int row_x = x - bv_->horizScrollOffset(text_, pit, row.pos());
+                       if (i)
+                               y += row.ascent();
+
+                       RowPainter rp(pi, *text_, pit, row, row_x, y);
+
+                       rp.paintOnlyInsets();
+                       y += row.descent();
+               }
+               return;
+       }
+
+       BufferParams const & bparams = bv_->buffer().params();
+       int const ww = bv_->workHeight();
        Cursor const & cur = bv_->cursor();
        DocIterator sel_beg = cur.selectionBegin();
        DocIterator sel_end = cur.selectionEnd();
@@ -1912,25 +1918,25 @@ void TextMetrics::drawParagraph(PainterInfo & pi, pit_type const pit, int const
        for (size_t i = 0; i != nrows; ++i) {
 
                Row const & row = pm.rows()[i];
-               int row_x = x;
+               // Adapt to cursor row scroll offset if applicable.
+               int row_x = x - bv_->horizScrollOffset(text_, pit, row.pos());
                if (i)
                        y += row.ascent();
 
-               CursorSlice rowSlice(const_cast<InsetText &>(text_->inset()));
-               rowSlice.pit() = pit;
-               rowSlice.pos() = row.pos();
+               RowPainter rp(pi, *text_, pit, row, row_x, y);
 
+               // It is not needed to draw on screen if we are not inside.
                bool const inside = (y + row.descent() >= 0
                        && y - row.ascent() < ww);
-
-               // Adapt to cursor row scroll offset if applicable.
-               if (bv_->currentRowSlice() == rowSlice)
-                       row_x -= bv_->horizScrollOffset();
-
-               // It is not needed to draw on screen if we are not inside.
-               pi.pain.setDrawingEnabled(inside && original_drawing_state);
-
-               RowPainter rp(pi, *text_, pit, row, row_x, y);
+               pi.pain.setDrawingEnabled(inside);
+               if (!inside) {
+                       // Paint only the insets to set inset cache correctly
+                       // FIXME: remove paintOnlyInsets when we know that positions
+                       // have already been set.
+                       rp.paintOnlyInsets();
+                       y += row.descent();
+                       continue;
+               }
 
                if (selection)
                        row.setSelectionAndMargins(sel_beg_par, sel_end_par);
@@ -1947,10 +1953,9 @@ void TextMetrics::drawParagraph(PainterInfo & pi, pit_type const pit, int const
                }
 
                // Row signature; has row changed since last paint?
-               if (pi.pain.isDrawingEnabled())
-                       row.setCrc(pm.computeRowSignature(row, bparams));
+               row.setCrc(pm.computeRowSignature(row, bparams));
                bool row_has_changed = row.changed()
-                       || rowSlice == bv_->lastRowSlice();
+                       || bv_->hadHorizScrollOffset(text_, pit, row.pos());
 
                // Take this opportunity to spellcheck the row contents.
                if (row_has_changed && pi.do_spellcheck && lyxrc.spellcheck_continuously) {
@@ -1979,7 +1984,7 @@ void TextMetrics::drawParagraph(PainterInfo & pi, pit_type const pit, int const
 
                // Instrumentation for testing row cache (see also
                // 12 lines lower):
-               if (lyxerr.debugging(Debug::PAINTING) && inside
+               if (lyxerr.debugging(Debug::PAINTING)
                        && (row.selection() || pi.full_repaint || row_has_changed)) {
                                string const foreword = text_->isMainText() ?
                                        "main text redraw " : "inset text redraw: ";
@@ -2017,7 +2022,7 @@ void TextMetrics::drawParagraph(PainterInfo & pi, pit_type const pit, int const
                pi.full_repaint = tmp;
        }
        // Re-enable screen drawing for future use of the painter.
-       pi.pain.setDrawingEnabled(original_drawing_state);
+       pi.pain.setDrawingEnabled(true);
 
        //LYXERR(Debug::PAINTING, ".");
 }