]> git.lyx.org Git - lyx.git/blobdiff - src/TextMetrics.cpp
* gcc does not like missing characters in keywords
[lyx.git] / src / TextMetrics.cpp
index 3acc85ad7b4f906a358cedf3acb460318f1e57ac..5c68b70230f510a633a75bcf3e09ed5108bf9acb 100644 (file)
 
 #include "TextMetrics.h"
 
+#include "Bidi.h"
 #include "Buffer.h"
 #include "buffer_funcs.h"
 #include "BufferParams.h"
 #include "BufferView.h"
-#include "bufferview_funcs.h"
-#include "Color.h"
-#include "CoordCache.h"
 #include "CutAndPaste.h"
 #include "debug.h"
 #include "FontIterator.h"
 #include "FuncRequest.h"
+#include "InsetList.h"
+#include "Layout.h"
 #include "Length.h"
 #include "LyXRC.h"
 #include "MetricsInfo.h"
@@ -38,7 +38,6 @@
 #include "ParIterator.h"
 #include "rowpainter.h"
 #include "Text.h"
-#include "Undo.h"
 #include "VSpace.h"
 
 #include "frontends/FontMetrics.h"
 
 #include <boost/current_function.hpp>
 
+using std::make_pair;
 using std::max;
 using std::min;
 using std::endl;
+using std::pair;
 
 namespace lyx {
 
@@ -126,19 +127,40 @@ TextMetrics::TextMetrics(BufferView * bv, Text * text)
 }
 
 
+bool TextMetrics::has(pit_type pit) const
+{
+       return par_metrics_.find(pit) != par_metrics_.end();
+}
+
+
 ParagraphMetrics const & TextMetrics::parMetrics(pit_type pit) const
 {
        return const_cast<TextMetrics *>(this)->parMetrics(pit, true);
 }
 
 
+
+pair<pit_type, ParagraphMetrics const *> TextMetrics::first() const
+{
+       ParMetricsCache::const_iterator it = par_metrics_.begin();
+       return make_pair(it->first, &it->second);
+}
+
+
+pair<pit_type, ParagraphMetrics const *> TextMetrics::last() const
+{
+       ParMetricsCache::const_reverse_iterator it = par_metrics_.rbegin();
+       return make_pair(it->first, &it->second);
+}
+
+
 ParagraphMetrics & TextMetrics::parMetrics(pit_type pit,
                bool redo)
 {
        ParMetricsCache::iterator pmc_it = par_metrics_.find(pit);
        if (pmc_it == par_metrics_.end()) {
                pmc_it = par_metrics_.insert(
-                       std::make_pair(pit, ParagraphMetrics(text_->getPar(pit)))).first;
+                       make_pair(pit, ParagraphMetrics(text_->getPar(pit)))).first;
        }
        if (pmc_it->second.rows().empty() && redo) {
                redoParagraph(pit);
@@ -147,7 +169,18 @@ ParagraphMetrics & TextMetrics::parMetrics(pit_type pit,
 }
 
 
-bool TextMetrics::metrics(MetricsInfo & mi, Dimension & dim)
+int TextMetrics::parPosition(pit_type pit) const
+{
+       if (pit < par_metrics_.begin()->first)
+               return -1000000;
+       else if (pit > par_metrics_.rbegin()->first)
+               return +1000000;
+
+       return par_metrics_[pit].position();
+}
+
+
+bool TextMetrics::metrics(MetricsInfo & mi, Dimension & dim, int min_width)
 {
        BOOST_ASSERT(mi.base.textwidth);
        max_width_ = mi.base.textwidth;
@@ -155,6 +188,7 @@ bool TextMetrics::metrics(MetricsInfo & mi, Dimension & dim)
        Dimension const old_dim = dim_;
        // reset dimension.
        dim_ = Dimension();
+       dim_.wid = min_width;
        pit_type const npar = text_->paragraphs().size();
        if (npar > 1)
                // If there is more than one row, expand the text to 
@@ -201,8 +235,8 @@ int TextMetrics::rightMargin(pit_type const pit) const
 void TextMetrics::applyOuterFont(Font & font) const
 {
        Font lf(font_);
-       lf.reduce(bv_->buffer().params().getFont());
-       lf.realize(font);
+       lf.fontInfo().reduce(bv_->buffer().params().getFont().fontInfo());
+       lf.fontInfo().realize(font.fontInfo());
        lf.setLanguage(font.language());
        font = lf;
 }
@@ -227,21 +261,22 @@ Font TextMetrics::getDisplayFont(pit_type pit, pos_type pos) const
                        applyOuterFont(f);
                bool lab = layout->labeltype == LABEL_MANUAL && pos < body_pos;
 
-               Font const & lf = lab ? layout->labelfont : layout->font;
-               Font rlf = lab ? layout->reslabelfont : layout->resfont;
+               FontInfo const & lf = lab ? layout->labelfont : layout->font;
+               FontInfo rlf = lab ? layout->reslabelfont : layout->resfont;
                
                // In case the default family has been customized
-               if (lf.family() == Font::INHERIT_FAMILY)
-                       rlf.setFamily(params.getFont().family());
-               return f.realize(rlf);
+               if (lf.family() == INHERIT_FAMILY)
+                       rlf.setFamily(params.getFont().fontInfo().family());
+               f.fontInfo().realize(rlf);
+               return f;
        }
 
        // The uncommon case need not be optimized as much
-       Font const & layoutfont = pos < body_pos ? 
+       FontInfo const & layoutfont = pos < body_pos ? 
                layout->labelfont : layout->font;
 
        Font font = par.getFontSettings(params, pos);
-       font.realize(layoutfont);
+       font.fontInfo().realize(layoutfont);
 
        if (!text_->isMainText(buffer))
                applyOuterFont(font);
@@ -250,10 +285,10 @@ Font TextMetrics::getDisplayFont(pit_type pit, pos_type pos) const
        // NOTE: the cast to pit_type should be removed when pit_type
        // changes to a unsigned integer.
        if (pit < pit_type(pars.size()))
-               font.realize(outerFont(pit, pars));
+               font.fontInfo().realize(outerFont(pit, pars).fontInfo());
 
        // Realize with the fonts of lesser depth.
-       font.realize(params.getFont());
+       font.fontInfo().realize(params.getFont().fontInfo());
 
        return font;
 }
@@ -347,20 +382,43 @@ bool TextMetrics::redoParagraph(pit_type const pit)
        // FIXME: We should always use getFont(), see documentation of
        // noFontChange() in Inset.h.
        Font const bufferfont = buffer.params().getFont();
-       InsetList::const_iterator ii = par.insetlist.begin();
-       InsetList::const_iterator iend = par.insetlist.end();
+       InsetList::const_iterator ii = par.insetList().begin();
+       InsetList::const_iterator iend = par.insetList().end();
        for (; ii != iend; ++ii) {
-               Dimension old_dim = ii->inset->dimension();
                Dimension dim;
                int const w = max_width_ - leftMargin(max_width_, pit, ii->pos)
                        - right_margin;
                Font const & font = ii->inset->noFontChange() ?
                        bufferfont : getDisplayFont(pit, ii->pos);
-               MetricsInfo mi(bv_, font, w);
-               changed |= ii->inset->metrics(mi, dim);
+               MetricsInfo mi(bv_, font.fontInfo(), w);
+               ii->inset->metrics(mi, dim);
+               Dimension const old_dim = pm.insetDimension(ii->inset);
+               pm.setInsetDimension(ii->inset, dim);
                changed |= (old_dim != dim);
        }
 
+       Cursor const & cur = bv_->cursor();
+       DocIterator sel_beg = cur.selectionBegin();
+       DocIterator sel_end = cur.selectionEnd();
+       bool selection = cur.selection()
+               // This is out text.
+               && cur.text() == text_
+               // if the anchor is outside, this is not our selection 
+               && cur.anchor().text() == text_
+               && pit >= sel_beg.pit() && pit <= sel_end.pit();
+
+       // We care only about visible selection.
+       if (selection) {
+               if (pit != sel_beg.pit()) {
+                       sel_beg.pit() = pit;
+                       sel_beg.pos() = 0;
+               }
+               if (pit != sel_end.pit()) {
+                       sel_end.pit() = pit;
+                       sel_end.pos() = sel_end.lastpos();
+               }
+       }
+
        par.setBeginOfBody();
        pos_type first = 0;
        size_t row_index = 0;
@@ -372,7 +430,7 @@ bool TextMetrics::redoParagraph(pit_type const pit)
                if (row_index || end < par.size())
                        // If there is more than one row, expand the text to 
                        // the full allowable width. This setting here is needed
-                       // for the computeRowMetrics below().
+                       // for the computeRowMetrics() below.
                        dim_.wid = max_width_;
 
                dim.wid = rowWidth(right_margin, pit, first, end);
@@ -383,8 +441,13 @@ bool TextMetrics::redoParagraph(pit_type const pit)
                row.setChanged(false);
                row.pos(first);
                row.endpos(end);
+               if (selection)
+                       row.setSelection(sel_beg.pos(), sel_end.pos());
+               else
+                       row.setSelection(-1, -1);
                row.setDimension(dim);
-               computeRowMetrics(pit, row);
+               int const max_row_width = max(dim_.wid, dim.wid);
+               computeRowMetrics(pit, row, max_row_width);
                pm.computeRowSignature(row, bparams);
                first = end;
                ++row_index;
@@ -409,7 +472,8 @@ bool TextMetrics::redoParagraph(pit_type const pit)
                row.pos(first);
                row.endpos(first);
                row.setDimension(dim);
-               computeRowMetrics(pit, row);
+               int const max_row_width = max(dim_.wid, dim.wid);
+               computeRowMetrics(pit, row, max_row_width);
                pm.computeRowSignature(row, bparams);
                pm.dim().des += dim.height();
        }
@@ -424,7 +488,7 @@ bool TextMetrics::redoParagraph(pit_type const pit)
 
 
 void TextMetrics::computeRowMetrics(pit_type const pit,
-               Row & row) const
+               Row & row, int width) const
 {
 
        row.label_hfill = 0;
@@ -434,7 +498,7 @@ void TextMetrics::computeRowMetrics(pit_type const pit,
        Buffer & buffer = bv_->buffer();
        Paragraph const & par = text_->getPar(pit);
 
-       double w = dim_.wid - row.width();
+       double w = width - row.width();
        // FIXME: put back this assertion when the crash on new doc is solved.
        //BOOST_ASSERT(w >= 0);
 
@@ -781,12 +845,12 @@ boost::tuple<int, int> TextMetrics::rowHeight(pit_type const pit, pos_type const
        // often.
        Buffer const & buffer = bv_->buffer();
        Font font = getDisplayFont(pit, first);
-       Font::FONT_SIZE const tmpsize = font.size();
-       font = text_->getLayoutFont(buffer, pit);
-       Font::FONT_SIZE const size = font.size();
-       font.setSize(tmpsize);
+       FontSize const tmpsize = font.fontInfo().size();
+       font.fontInfo() = text_->getLayoutFont(buffer, pit);
+       FontSize const size = font.fontInfo().size();
+       font.fontInfo().setSize(tmpsize);
 
-       Font labelfont = text_->getLabelFont(buffer, par);
+       FontInfo labelfont = text_->getLabelFont(buffer, par);
 
        FontMetrics const & labelfont_metrics = theFontMetrics(labelfont);
        FontMetrics const & fontmetrics = theFontMetrics(font);
@@ -799,12 +863,14 @@ boost::tuple<int, int> TextMetrics::rowHeight(pit_type const pit, pos_type const
        int maxdesc = int(fontmetrics.maxDescent() * spacing_val);
 
        // insets may be taller
-       InsetList::const_iterator ii = par.insetlist.begin();
-       InsetList::const_iterator iend = par.insetlist.end();
+       ParagraphMetrics const & pm = par_metrics_[pit];
+       InsetList::const_iterator ii = par.insetList().begin();
+       InsetList::const_iterator iend = par.insetList().end();
        for ( ; ii != iend; ++ii) {
+               Dimension const & dim = pm.insetDimension(ii->inset);
                if (ii->pos >= first && ii->pos < end) {
-                       maxasc  = max(maxasc,  ii->inset->ascent());
-                       maxdesc = max(maxdesc, ii->inset->descent());
+                       maxasc  = max(maxasc,  dim.ascent());
+                       maxdesc = max(maxdesc, dim.descent());
                }
        }
 
@@ -813,11 +879,11 @@ boost::tuple<int, int> TextMetrics::rowHeight(pit_type const pit, pos_type const
        // cosmetic error for now.
        int labeladdon = 0;
 
-       Font::FONT_SIZE maxsize =
+       FontSize maxsize =
                par.highestFontInRange(first, end, size);
-       if (maxsize > font.size()) {
+       if (maxsize > font.fontInfo().size()) {
                // use standard paragraph font with the maximal size
-               Font maxfont = font;
+               FontInfo maxfont = font.fontInfo();
                maxfont.setSize(maxsize);
                FontMetrics const & maxfontmetrics = theFontMetrics(maxfont);
                maxasc  = max(maxasc,  maxfontmetrics.maxAscent());
@@ -836,8 +902,8 @@ boost::tuple<int, int> TextMetrics::rowHeight(pit_type const pit, pos_type const
                // some parskips VERY EASY IMPLEMENTATION
                if (bufparams.paragraph_separation
                    == BufferParams::PARSEP_SKIP
-                       && par.ownerCode() != Inset::ERT_CODE
-                       && par.ownerCode() != Inset::LISTINGS_CODE
+                       && par.ownerCode() != ERT_CODE
+                       && par.ownerCode() != LISTINGS_CODE
                        && pit > 0
                        && ((layout->isParagraph() && par.getDepth() == 0)
                            || (pars[pit - 1].layout()->isParagraph()
@@ -961,7 +1027,7 @@ pos_type TextMetrics::getColumnNearX(pit_type const pit,
        /// For the main Text, it is possible that this pit is not
        /// yet in the CoordCache when moving cursor up.
        /// x Paragraph coordinate is always 0 for main text anyway.
-       int const xo = main_text_? 0 : bv_->coordCache().get(text_, pit).x_;
+       int const xo = origin_.x_;
        x -= xo;
        Paragraph const & par = text_->getPar(pit);
        ParagraphMetrics const & pm = par_metrics_[pit];
@@ -1094,8 +1160,12 @@ pos_type TextMetrics::getColumnNearX(pit_type const pit,
 
 pos_type TextMetrics::x2pos(pit_type pit, int row, int x) const
 {
-       ParagraphMetrics const & pm = par_metrics_[pit];
-       BOOST_ASSERT(!pm.rows().empty());
+       // We play safe and use parMetrics(pit) to make sure the
+       // ParagraphMetrics will be redone and OK to use if needed.
+       // Otherwise we would use an empty ParagraphMetrics in
+       // upDownInText() while in selection mode.
+       ParagraphMetrics const & pm = parMetrics(pit);
+
        BOOST_ASSERT(row < int(pm.rows().size()));
        bool bound = false;
        Row const & r = pm.rows()[row];
@@ -1103,30 +1173,55 @@ pos_type TextMetrics::x2pos(pit_type pit, int row, int x) const
 }
 
 
+void TextMetrics::newParMetricsDown()
+{
+       pair<pit_type, ParagraphMetrics> const & last = *par_metrics_.rbegin();
+       pit_type const pit = last.first + 1;
+       if (pit == int(text_->paragraphs().size()))
+               return;
+
+       // do it and update its position.
+       redoParagraph(pit);
+       par_metrics_[pit].setPosition(last.second.position()
+               + last.second.descent());
+}
+
+
+void TextMetrics::newParMetricsUp()
+{
+       pair<pit_type, ParagraphMetrics> const & first = *par_metrics_.begin();
+       if (first.first == 0)
+               return;
+
+       pit_type const pit = first.first - 1;
+       // do it and update its position.
+       redoParagraph(pit);
+       par_metrics_[pit].setPosition(first.second.position()
+               - first.second.ascent());
+}
+
 // y is screen coordinate
 pit_type TextMetrics::getPitNearY(int y)
 {
        BOOST_ASSERT(!text_->paragraphs().empty());
-       BOOST_ASSERT(bv_->coordCache().getParPos().find(text_) != bv_->coordCache().getParPos().end());
-       CoordCache::InnerParPosCache const & cc = bv_->coordCache().getParPos().find(text_)->second;
        LYXERR(Debug::DEBUG)
                << BOOST_CURRENT_FUNCTION
-               << ": y: " << y << " cache size: " << cc.size()
+               << ": y: " << y << " cache size: " << par_metrics_.size()
                << endl;
 
        // look for highest numbered paragraph with y coordinate less than given y
        pit_type pit = 0;
        int yy = -1;
-       CoordCache::InnerParPosCache::const_iterator it = cc.begin();
-       CoordCache::InnerParPosCache::const_iterator et = cc.end();
-       CoordCache::InnerParPosCache::const_iterator last = et; last--;
+       ParMetricsCache::const_iterator it = par_metrics_.begin();
+       ParMetricsCache::const_iterator et = par_metrics_.end();
+       ParMetricsCache::const_iterator last = et; last--;
 
-       ParagraphMetrics const & pm = par_metrics_[it->first];
+       ParagraphMetrics const & pm = it->second;
 
        // If we are off-screen (before the visible part)
        if (y < 0
                // and even before the first paragraph in the cache.
-               && y < it->second.y_ - int(pm.ascent())) {
+               && y < it->second.position() - int(pm.ascent())) {
                //  and we are not at the first paragraph in the inset.
                if (it->first == 0)
                        return 0;
@@ -1134,8 +1229,7 @@ pit_type TextMetrics::getPitNearY(int y)
                pit = it->first - 1;
                // rebreak it and update the CoordCache.
                redoParagraph(pit);
-               bv_->coordCache().parPos()[text_][pit] =
-                       Point(0, it->second.y_ - pm.descent());
+               par_metrics_[pit].setPosition(it->second.position() - pm.descent());
                return pit;
        }
 
@@ -1144,7 +1238,7 @@ pit_type TextMetrics::getPitNearY(int y)
        // If we are off-screen (after the visible part)
        if (y > bv_->workHeight()
                // and even after the first paragraph in the cache.
-               && y >= last->second.y_ + int(pm_last.descent())) {
+               && y >= last->second.position() + int(pm_last.descent())) {
                pit = last->first + 1;
                //  and we are not at the last paragraph in the inset.
                if (pit == int(text_->paragraphs().size()))
@@ -1152,8 +1246,7 @@ pit_type TextMetrics::getPitNearY(int y)
                // then this is the paragraph we are looking for.
                // rebreak it and update the CoordCache.
                redoParagraph(pit);
-               bv_->coordCache().parPos()[text_][pit] =
-                       Point(0, last->second.y_ + pm_last.ascent());
+               par_metrics_[pit].setPosition(last->second.position() + pm_last.ascent());
                return pit;
        }
 
@@ -1161,14 +1254,14 @@ pit_type TextMetrics::getPitNearY(int y)
                LYXERR(Debug::DEBUG)
                        << BOOST_CURRENT_FUNCTION
                        << "  examining: pit: " << it->first
-                       << " y: " << it->second.y_
+                       << " y: " << it->second.position()
                        << endl;
 
                ParagraphMetrics const & pm = par_metrics_[it->first];
 
-               if (it->first >= pit && int(it->second.y_) - int(pm.ascent()) <= y) {
+               if (it->first >= pit && int(it->second.position()) - int(pm.ascent()) <= y) {
                        pit = it->first;
-                       yy = it->second.y_;
+                       yy = it->second.position();
                }
        }
 
@@ -1185,10 +1278,11 @@ Row const & TextMetrics::getRowNearY(int y, pit_type pit) const
 {
        ParagraphMetrics const & pm = par_metrics_[pit];
 
-       int yy = bv_->coordCache().get(text_, pit).y_ - pm.ascent();
+       int yy = pm.position() - pm.ascent();
        BOOST_ASSERT(!pm.rows().empty());
        RowList::const_iterator rit = pm.rows().begin();
-       RowList::const_iterator const rlast = boost::prior(pm.rows().end());
+       RowList::const_iterator rlast = pm.rows().end();
+       --rlast;
        for (; rit != rlast; yy += rit->height(), ++rit)
                if (yy + rit->height() > y)
                        break;
@@ -1262,7 +1356,7 @@ void TextMetrics::setCursorFromCoordinates(Cursor & cur, int const x, int const
 
        ParagraphMetrics const & pm = par_metrics_[pit];
 
-       int yy = bv_->coordCache().get(text_, pit).y_ - pm.ascent();
+       int yy = pm.position() - pm.ascent();
        LYXERR(Debug::DEBUG)
                << BOOST_CURRENT_FUNCTION
                << ": x: " << x
@@ -1310,6 +1404,7 @@ Inset * TextMetrics::checkInsetHit(int x, int y)
        BOOST_ASSERT(pit != -1);
 
        Paragraph const & par = text_->paragraphs()[pit];
+       ParagraphMetrics const & pm = par_metrics_[pit];
 
        LYXERR(Debug::DEBUG)
                << BOOST_CURRENT_FUNCTION
@@ -1317,36 +1412,42 @@ Inset * TextMetrics::checkInsetHit(int x, int y)
                << " y: " << y
                << "  pit: " << pit
                << endl;
-       InsetList::const_iterator iit = par.insetlist.begin();
-       InsetList::const_iterator iend = par.insetlist.end();
+       InsetList::const_iterator iit = par.insetList().begin();
+       InsetList::const_iterator iend = par.insetList().end();
        for (; iit != iend; ++iit) {
                Inset * inset = iit->inset;
-#if 1
+
                LYXERR(Debug::DEBUG)
                        << BOOST_CURRENT_FUNCTION
                        << ": examining inset " << inset << endl;
 
-               if (bv_->coordCache().getInsets().has(inset))
-                       LYXERR(Debug::DEBUG)
-                               << BOOST_CURRENT_FUNCTION
-                               << ": xo: " << inset->xo(*bv_) << "..."
-                               << inset->xo(*bv_) + inset->width()
-                               << " yo: " << inset->yo(*bv_) - inset->ascent()
-                               << "..."
-                               << inset->yo(*bv_) + inset->descent()
-                               << endl;
-               else
+               if (!bv_->coordCache().getInsets().has(inset)) {
                        LYXERR(Debug::DEBUG)
                                << BOOST_CURRENT_FUNCTION
                                << ": inset has no cached position" << endl;
-#endif
-               if (inset->covers(*bv_, x, y)) {
+                       return 0;
+               }
+
+               Dimension const & dim = pm.insetDimension(inset);
+               Point p = bv_->coordCache().getInsets().xy(inset);
+
+               LYXERR(Debug::DEBUG)
+                       << BOOST_CURRENT_FUNCTION
+                       << ": xo: " << p.x_ << "..." << p.x_ + dim.wid
+                       << " yo: " << p.y_ - dim.asc << "..." << p.y_ + dim.des
+                       << endl;
+
+               if (x >= p.x_
+                       && x <= p.x_ + dim.wid
+                       && y >= p.y_ - dim.asc
+                       && y <= p.y_ + dim.des) {
                        LYXERR(Debug::DEBUG)
                                << BOOST_CURRENT_FUNCTION
                                << ": Hit inset: " << inset << endl;
                        return inset;
                }
        }
+
        LYXERR(Debug::DEBUG)
                << BOOST_CURRENT_FUNCTION
                << ": No inset hit. " << endl;
@@ -1491,7 +1592,7 @@ void TextMetrics::cursorPrevious(Cursor & cur)
                // simplest solution is to move to the previous row instead.
                cur.dispatch(FuncRequest(cur.selection()? LFUN_UP_SELECT: LFUN_UP));
 
-       finishUndo();
+       cur.finishUndo();
        cur.updateFlags(Update::Force | Update::FitCursor);
 }
 
@@ -1511,7 +1612,7 @@ void TextMetrics::cursorNext(Cursor & cur)
                cur.dispatch(
                        FuncRequest(cur.selection()? LFUN_DOWN_SELECT: LFUN_DOWN));
 
-       finishUndo();
+       cur.finishUndo();
        cur.updateFlags(Update::Force | Update::FitCursor);
 }
 
@@ -1554,8 +1655,8 @@ void TextMetrics::deleteLineForward(Cursor & cur)
 {
        BOOST_ASSERT(text_ == cur.text());
        if (cur.lastpos() == 0) {
-               // Paragraph is empty, so we just go to the right
-               text_->cursorRight(cur);
+               // Paragraph is empty, so we just go forward
+               text_->cursorForward(cur);
        } else {
                cur.resetAnchor();
                cur.selection() = true; // to avoid deletion
@@ -1641,7 +1742,7 @@ int TextMetrics::leftMargin(int max_width,
            && pit > 0 && pars[pit - 1].layout()->nextnoindent)
                parindent.erase();
 
-       Font const labelfont = text_->getLabelFont(buffer, par);
+       FontInfo const labelfont = text_->getLabelFont(buffer, par);
        FontMetrics const & labelfont_metrics = theFontMetrics(labelfont);
 
        switch (layout->margintype) {
@@ -1772,13 +1873,19 @@ void TextMetrics::draw(PainterInfo & pi, int x, int y) const
        if (par_metrics_.empty())
                return;
 
-       ParMetricsCache::const_iterator it = par_metrics_.begin();
-       ParMetricsCache::const_iterator const end = par_metrics_.end();
+       origin_.x_ = x;
+       origin_.y_ = y;
+
+       ParMetricsCache::iterator it = par_metrics_.begin();
+       ParMetricsCache::iterator const pm_end = par_metrics_.end();
        y -= it->second.ascent();
-       for (; it != end; ++it) {
+       for (; it != pm_end; ++it) {
                ParagraphMetrics const & pmi = it->second;
                y += pmi.ascent();
-               drawParagraph(pi, it->first, x, y);
+               pit_type const pit = it->first;
+               // Save the paragraph position in the cache.
+               it->second.setPosition(y);
+               drawParagraph(pi, pit, x, y);
                y += pmi.descent();
        }
 }
@@ -1789,8 +1896,6 @@ void TextMetrics::drawParagraph(PainterInfo & pi, pit_type pit, int x, int y) co
 //     lyxerr << "  paintPar: pit: " << pit << " at y: " << y << endl;
        int const ww = bv_->workHeight();
 
-       bv_->coordCache().parPos()[text_][pit] = Point(x, y);
-
        ParagraphMetrics const & pm = par_metrics_[pit];
        if (pm.rows().empty())
                return;
@@ -1813,7 +1918,9 @@ void TextMetrics::drawParagraph(PainterInfo & pi, pit_type pit, int x, int y) co
                // Row signature; has row changed since last paint?
                bool row_has_changed = rit->changed();
                
-               if (!pi.full_repaint && !row_has_changed) {
+               bool row_selection = rit->sel_beg != -1 && rit->sel_end != -1;
+
+               if (!row_selection && !pi.full_repaint && !row_has_changed) {
                        // Paint the only the insets if the text itself is
                        // unchanged.
                        rp.paintOnlyInsets();
@@ -1825,20 +1932,32 @@ void TextMetrics::drawParagraph(PainterInfo & pi, pit_type pit, int x, int y) co
                // changed.
                // Clear background of this row
                // (if paragraph background was not cleared)
-               if (!pi.full_repaint && row_has_changed) {
+               if (row_selection || (!pi.full_repaint && row_has_changed)) {
                        pi.pain.fillRectangle(x, y - rit->ascent(),
-                               width(), rit->height(),
-                               Color_color(Color::color(pi.background_color)));
+                               width(), rit->height(), pi.background_color);
+               }
+               if (row_selection) {
+                       DocIterator beg = bv_->cursor().selectionBegin();
+                       DocIterator end = bv_->cursor().selectionEnd();
+                       beg.pit() = pit;
+                       beg.pos() = rit->sel_beg;
+                       if (pit == end.pit()) {
+                               end.pos() = rit->sel_end;
+                       } else {
+                               end.pit() = pit + 1;
+                               end.pos() = 0;
+                       }
+                       drawSelection(pi, beg, end, x);
                }
 
                // Instrumentation for testing row cache (see also
                // 12 lines lower):
                if (lyxerr.debugging(Debug::PAINTING)) {
                        if (text_->isMainText(bv_->buffer()))
-                               LYXERR(Debug::PAINTING) << "\n{" <<
+                               LYXERR(Debug::PAINTING) << "\n{" << inside <<
                                pi.full_repaint << row_has_changed << "}";
                        else
-                               LYXERR(Debug::PAINTING) << "[" <<
+                               LYXERR(Debug::PAINTING) << "[" << inside <<
                                pi.full_repaint << row_has_changed << "]";
                }
 
@@ -1865,66 +1984,33 @@ void TextMetrics::drawParagraph(PainterInfo & pi, pit_type pit, int x, int y) co
 }
 
 
-// only used for inset right now. should also be used for main text
-void TextMetrics::drawSelection(PainterInfo & pi, int x, int) const
+// FIXME: only take care of one row!
+void TextMetrics::drawSelection(PainterInfo & pi,
+       DocIterator const & beg, DocIterator const & end, int x) const
 {
-       Cursor & cur = bv_->cursor();
-       if (!cur.selection())
-               return;
-       if (!ptr_cmp(cur.text(), text_))
-               return;
-       
-       //if the anchor is outside, this is not our selection 
-       if (!ptr_cmp(cur.anchor().text(), text_))               
-               return;
-
-       LYXERR(Debug::DEBUG)
-               << BOOST_CURRENT_FUNCTION
-               << "draw selection at " << x
-               << endl;
-
-       DocIterator beg = cur.selectionBegin();
-       DocIterator end = cur.selectionEnd();
-
-       // the selection doesn't touch the visible screen?
-       if (bv_funcs::status(bv_, beg) == bv_funcs::CUR_BELOW
-           || bv_funcs::status(bv_, end) == bv_funcs::CUR_ABOVE)
-               return;
-
-       if (beg.pit() < par_metrics_.begin()->first) {
-               beg.pit() = par_metrics_.begin()->first;
-               beg.pos() = 0;
-       }
-       if (end.pit() > par_metrics_.rbegin()->first) {
-               end.pit() = par_metrics_.rbegin()->first;
-               end.pos() = end.lastpos();
-       }
-
-       ParagraphMetrics const & pm1 = par_metrics_[beg.pit()];
-       ParagraphMetrics const & pm2 = par_metrics_[end.pit()];
+       ParagraphMetrics const & pm1 = parMetrics(beg.pit());
+       ParagraphMetrics const & pm2 = parMetrics(end.pit());
        Row const & row1 = pm1.getRow(beg.pos(), beg.boundary());
        Row const & row2 = pm2.getRow(end.pos(), end.boundary());
 
        // clip above
        int middleTop;
-       bool const clipAbove = 
-               (bv_funcs::status(bv_, beg) == bv_funcs::CUR_ABOVE);
+       bool const clipAbove = (bv_->cursorStatus(beg) == CUR_ABOVE);
        if (clipAbove)
                middleTop = 0;
        else
-               middleTop = bv_funcs::getPos(*bv_, beg, beg.boundary()).y_ + row1.descent();
+               middleTop = bv_->getPos(beg, beg.boundary()).y_ + row1.descent();
        
        // clip below
        int middleBottom;
-       bool const clipBelow = 
-               (bv_funcs::status(bv_, end) == bv_funcs::CUR_BELOW);
+       bool const clipBelow = (bv_->cursorStatus(end) == CUR_BELOW);
        if (clipBelow)
                middleBottom = bv_->workHeight();
        else
-               middleBottom = bv_funcs::getPos(*bv_, end, end.boundary()).y_ - row2.ascent();
+               middleBottom = bv_->getPos(end, end.boundary()).y_ - row2.ascent();
 
        // start and end in the same line?
-       if (!(clipAbove || clipBelow) && &row1 == &row2)
+       if (!clipAbove && !clipBelow && &row1 == &row2)
                // then only draw this row's selection
                drawRowSelection(pi, x, row1, beg, end, false, false);
        else {
@@ -1941,7 +2027,7 @@ void TextMetrics::drawSelection(PainterInfo & pi, int x, int) const
                if (middleTop < middleBottom) {
                        // draw middle rectangle
                        pi.pain.fillRectangle(x, middleTop, width(), middleBottom - middleTop,
-                               Color::selection);
+                               Color_selection);
                }
 
                if (!clipBelow) {
@@ -1965,22 +2051,22 @@ void TextMetrics::drawRowSelection(PainterInfo & pi, int x, Row const & row,
        DocIterator cur = beg;
        int x1 = cursorX(beg.top(), beg.boundary());
        int x2 = cursorX(end.top(), end.boundary());
-       int y1 = bv_funcs::getPos(*bv_, cur, cur.boundary()).y_ - row.ascent();
+       int y1 = bv_->getPos(cur, cur.boundary()).y_ - row.ascent();
        int y2 = y1 + row.height();
        
        // draw the margins
        if (drawOnBegMargin) {
                if (text_->isRTL(buffer, beg.paragraph()))
-                       pi.pain.fillRectangle(x + x1, y1, width() - x1, y2 - y1, Color::selection);
+                       pi.pain.fillRectangle(x + x1, y1, width() - x1, y2 - y1, Color_selection);
                else
-                       pi.pain.fillRectangle(x, y1, x1, y2 - y1, Color::selection);
+                       pi.pain.fillRectangle(x, y1, x1, y2 - y1, Color_selection);
        }
        
        if (drawOnEndMargin) {
                if (text_->isRTL(buffer, beg.paragraph()))
-                       pi.pain.fillRectangle(x, y1, x2, y2 - y1, Color::selection);
+                       pi.pain.fillRectangle(x, y1, x2, y2 - y1, Color_selection);
                else
-                       pi.pain.fillRectangle(x + x2, y1, width() - x2, y2 - y1, Color::selection);
+                       pi.pain.fillRectangle(x + x2, y1, width() - x2, y2 - y1, Color_selection);
        }
        
        // if we are on a boundary from the beginning, it's probably
@@ -1993,9 +2079,9 @@ void TextMetrics::drawRowSelection(PainterInfo & pi, int x, Row const & row,
        while (cur < end) {
                bool drawNow = false;
                
-               // simplified cursorRight code below which does not
+               // simplified cursorForward code below which does not
                // descend into insets and which does not go into the
-               // next line. Compare the logic with the original cursorRight
+               // next line. Compare the logic with the original cursorForward
                
                // if left of boundary -> just jump to right side
                // but for RTL boundaries don't, because: abc|DDEEFFghi -> abcDDEEF|Fghi
@@ -2024,7 +2110,7 @@ void TextMetrics::drawRowSelection(PainterInfo & pi, int x, Row const & row,
                if (!(cur < end) || drawNow) {
                        x2 = cursorX(cur.top(), cur.boundary());
                        pi.pain.fillRectangle(x + min(x1,x2), y1, abs(x2 - x1), y2 - y1,
-                               Color::selection);
+                               Color_selection);
                        
                        // reset x1, so it is set again next round (which will be on the 
                        // right side of a boundary or at the selection end)
@@ -2044,7 +2130,7 @@ void TextMetrics::drawRowSelection(PainterInfo & pi, int x, Row const & row,
 
 int defaultRowHeight()
 {
-       return int(theFontMetrics(Font(Font::ALL_SANE)).maxHeight() *  1.2);
+       return int(theFontMetrics(sane_font).maxHeight() *  1.2);
 }
 
 } // namespace lyx