]> git.lyx.org Git - lyx.git/blobdiff - src/Text3.cpp
Further cleanup of InsetFlex, InsetCollapsable and InsetLayout:
[lyx.git] / src / Text3.cpp
index 77ad450d701c95708458abac69737fdd97d27a76..f51106448ff90dddbffb98f5ab579ef3e12e89ef 100644 (file)
@@ -33,6 +33,7 @@
 #include "factory.h"
 #include "FuncRequest.h"
 #include "gettext.h"
+#include "InsetList.h"
 #include "Intl.h"
 #include "Language.h"
 #include "Layout.h"
 #include "Paragraph.h"
 #include "paragraph_funcs.h"
 #include "ParagraphParameters.h"
-#include "Undo.h"
+#include "TextMetrics.h"
 #include "VSpace.h"
 #include "ParIterator.h"
 
 #include "frontends/Clipboard.h"
 #include "frontends/Selection.h"
 
+#include "insets/InsetCollapsable.h"
 #include "insets/InsetCommand.h"
 #include "insets/InsetFloatList.h"
 #include "insets/InsetNewline.h"
 #include "insets/InsetQuotes.h"
 #include "insets/InsetSpecialChar.h"
 #include "insets/InsetText.h"
+#include "insets/InsetInfo.h"
 
 #include "support/lstrings.h"
 #include "support/lyxlib.h"
@@ -86,12 +89,8 @@ using cap::replaceSelection;
 using support::isStrUnsignedInt;
 using support::token;
 
-namespace frontend {
-extern docstring current_layout;
-}
-
 // globals...
-static Font freefont(Font::ALL_IGNORE);
+static Font freefont(ignore_font);
 static bool toggleall = false;
 
 static void toggleAndShow(Cursor & cur, Text * text,
@@ -100,7 +99,7 @@ static void toggleAndShow(Cursor & cur, Text * text,
        text->toggleFree(cur, font, toggleall);
 
        if (font.language() != ignore_language ||
-                       font.number() != Font::IGNORE) {
+                       font.fontInfo().number() != FONT_IGNORE) {
                TextMetrics const & tm = cur.bv().textMetrics(text);
                if (cur.boundary() != tm.isRTLBoundary(cur.pit(),
                                                                                                                cur.pos(), cur.real_current_font))
@@ -119,14 +118,14 @@ static void moveCursor(Cursor & cur, bool selecting)
 
 static void finishChange(Cursor & cur, bool selecting)
 {
-       finishUndo();
+       cur.finishUndo();
        moveCursor(cur, selecting);
 }
 
 
 static void mathDispatch(Cursor & cur, FuncRequest const & cmd, bool display)
 {
-       recordUndo(cur);
+       cur.recordUndo();
        docstring sel = cur.selectionAsString(false);
 
        // It may happen that sel is empty but there is a selection
@@ -177,7 +176,7 @@ static void mathDispatch(Cursor & cur, FuncRequest const & cmd, bool display)
 
 static void specialChar(Cursor & cur, InsetSpecialChar::Kind kind)
 {
-       recordUndo(cur);
+       cur.recordUndo();
        cap::replaceSelection(cur);
        cur.insert(new InsetSpecialChar(kind));
        cur.posRight();
@@ -191,24 +190,51 @@ static bool doInsertInset(Cursor & cur, Text * text,
        if (!inset)
                return false;
 
-       recordUndo(cur);
-       bool gotsel = false;
-       if (cur.selection()) {
-               lyx::dispatch(FuncRequest(LFUN_CUT));
-               gotsel = true;
-       }
-       text->insertInset(cur, inset);
-
-       if (edit)
-               inset->edit(cur, true);
-
-       if (gotsel && pastesel) {
-               lyx::dispatch(FuncRequest(LFUN_PASTE, "0"));
-               // reset first par to default
-               if (cur.lastpit() != 0 || cur.lastpos() != 0) {
-                       LayoutPtr const layout =
-                               cur.buffer().params().getTextClass().defaultLayout();
-                       cur.text()->paragraphs().begin()->layout(layout);
+       if (InsetCollapsable * ci = inset->asInsetCollapsable())
+               ci->setLayout(cur.bv().buffer().params());
+
+       cur.recordUndo();
+       if (cmd.action == LFUN_INDEX_INSERT) {
+               docstring ds = support::subst(text->getStringToIndex(cur), '\n', ' ');
+               text->insertInset(cur, inset);
+               if (edit)
+                       inset->edit(cur, true);
+               // Now put this into inset
+               static_cast<InsetCollapsable *>(inset)->text_.insertStringAsParagraphs(cur, ds);
+       } else {
+               bool gotsel = false;
+               if (cur.selection()) {
+                       lyx::dispatch(FuncRequest(LFUN_CUT));
+                       gotsel = true;
+               }
+               text->insertInset(cur, inset);
+
+               if (edit)
+                       inset->edit(cur, true);
+
+               if (gotsel && pastesel) {
+                       lyx::dispatch(FuncRequest(LFUN_PASTE, "0"));
+                       InsetText * insetText = dynamic_cast<InsetText *>(inset);
+                       if (insetText && !insetText->allowMultiPar() 
+                           || cur.lastpit() == 0) {
+                               // reset first par to default
+                               LayoutPtr const layout =
+                                       cur.buffer().params().getTextClass().defaultLayout();
+                               cur.text()->paragraphs().begin()->layout(layout);
+                               cur.pos() = 0;
+                               cur.pit() = 0;
+                               // Merge multiple paragraphs -- hack
+                               while (cur.lastpit() > 0) {
+                                       mergeParagraph(cur.buffer().params(),
+                                               cur.text()->paragraphs(), 0);
+                               }
+                       } else {
+                               // reset surrounding par to default
+                               docstring const layoutname = 
+                                       cur.buffer().params().getTextClass().defaultLayoutName();
+                               cur.leaveInset(*inset);
+                               text->setLayout(cur, layoutname);
+                       }
                }
        }
        return true;
@@ -223,9 +249,9 @@ string const freefont2string()
 
 void Text::number(Cursor & cur)
 {
-       Font font(Font::ALL_IGNORE);
-       font.setNumber(Font::TOGGLE);
-       toggleAndShow(cur, this, font);
+       FontInfo font = ignore_font;
+       font.setNumber(FONT_TOGGLE);
+       toggleAndShow(cur, this, Font(font));
 }
 
 
@@ -267,7 +293,7 @@ void Text::dispatch(Cursor & cur, FuncRequest & cmd)
        case LFUN_PARAGRAPH_MOVE_DOWN: {
                pit_type const pit = cur.pit();
                recUndo(cur, pit, pit + 1);
-               finishUndo();
+               cur.finishUndo();
                std::swap(pars_[pit], pars_[pit + 1]);
                updateLabels(cur.buffer());
                needsUpdate = true;
@@ -278,7 +304,7 @@ void Text::dispatch(Cursor & cur, FuncRequest & cmd)
        case LFUN_PARAGRAPH_MOVE_UP: {
                pit_type const pit = cur.pit();
                recUndo(cur, pit - 1, pit);
-               finishUndo();
+               cur.finishUndo();
                std::swap(pars_[pit], pars_[pit - 1]);
                updateLabels(cur.buffer());
                --cur.pit();
@@ -302,7 +328,7 @@ void Text::dispatch(Cursor & cur, FuncRequest & cmd)
                        }
                }
 
-               recordUndo(cur);
+               cur.recordUndo();
                par.params().startOfAppendix(start);
 
                // we can set the refreshing parameters now
@@ -359,15 +385,12 @@ void Text::dispatch(Cursor & cur, FuncRequest & cmd)
                //lyxerr << BOOST_CURRENT_FUNCTION
                //       << " LFUN_CHAR_FORWARD[SEL]:\n" << cur << endl;
                needsUpdate |= cur.selHandle(cmd.action == LFUN_CHAR_FORWARD_SELECT);
-               if (reverseDirectionNeeded(cur))
-                       needsUpdate |= cursorLeft(cur);
-               else
-                       needsUpdate |= cursorRight(cur);
+               needsUpdate |= cursorForward(cur);
 
                if (!needsUpdate && oldTopSlice == cur.top()
                                && cur.boundary() == oldBoundary) {
                        cur.undispatched();
-                       cmd = FuncRequest(LFUN_FINISHED_RIGHT);
+                       cmd = FuncRequest(LFUN_FINISHED_FORWARD);
                }
                break;
 
@@ -375,15 +398,40 @@ void Text::dispatch(Cursor & cur, FuncRequest & cmd)
        case LFUN_CHAR_BACKWARD_SELECT:
                //lyxerr << "handle LFUN_CHAR_BACKWARD[_SELECT]:\n" << cur << endl;
                needsUpdate |= cur.selHandle(cmd.action == LFUN_CHAR_BACKWARD_SELECT);
-               if (reverseDirectionNeeded(cur))
-                       needsUpdate |= cursorRight(cur);
-               else
-                       needsUpdate |= cursorLeft(cur);
+               needsUpdate |= cursorBackward(cur);
 
                if (!needsUpdate && oldTopSlice == cur.top()
                        && cur.boundary() == oldBoundary) {
                        cur.undispatched();
-                       cmd = FuncRequest(LFUN_FINISHED_LEFT);
+                       cmd = FuncRequest(LFUN_FINISHED_BACKWARD);
+               }
+               break;
+
+       case LFUN_CHAR_LEFT:
+       case LFUN_CHAR_LEFT_SELECT:
+               //FIXME: for visual cursor, really move left
+               if (reverseDirectionNeeded(cur)) {
+                       lyx::dispatch(FuncRequest(
+                               cmd.action == LFUN_CHAR_LEFT_SELECT ? 
+                                       LFUN_CHAR_FORWARD_SELECT : LFUN_CHAR_FORWARD));
+               } else {
+                       lyx::dispatch(FuncRequest(
+                               cmd.action == LFUN_CHAR_LEFT_SELECT ? 
+                                       LFUN_CHAR_BACKWARD_SELECT : LFUN_CHAR_BACKWARD));
+               }
+               break;
+
+       case LFUN_CHAR_RIGHT:
+       case LFUN_CHAR_RIGHT_SELECT:
+               //FIXME: for visual cursor, really move right
+               if (reverseDirectionNeeded(cur)) {
+                       lyx::dispatch(FuncRequest(
+                               cmd.action == LFUN_CHAR_RIGHT_SELECT ? 
+                                       LFUN_CHAR_BACKWARD_SELECT : LFUN_CHAR_BACKWARD));
+               } else {
+                       lyx::dispatch(FuncRequest(
+                               cmd.action == LFUN_CHAR_RIGHT_SELECT ? 
+                                       LFUN_CHAR_FORWARD_SELECT : LFUN_CHAR_FORWARD));
                }
                break;
 
@@ -455,22 +503,44 @@ void Text::dispatch(Cursor & cur, FuncRequest & cmd)
                needsUpdate |= tm.cursorEnd(cur);
                break;
 
+       case LFUN_WORD_RIGHT:
+       case LFUN_WORD_RIGHT_SELECT:
+               //FIXME: for visual cursor mode, really move right
+               if (reverseDirectionNeeded(cur)) {
+                       lyx::dispatch(FuncRequest(
+                               cmd.action == LFUN_WORD_RIGHT_SELECT ?
+                                       LFUN_WORD_BACKWARD_SELECT : LFUN_WORD_BACKWARD));
+               } else {
+                       lyx::dispatch(FuncRequest(
+                               cmd.action == LFUN_WORD_RIGHT_SELECT ?
+                                       LFUN_WORD_FORWARD_SELECT : LFUN_WORD_FORWARD));
+               }
+               break;
+
        case LFUN_WORD_FORWARD:
        case LFUN_WORD_FORWARD_SELECT:
                needsUpdate |= cur.selHandle(cmd.action == LFUN_WORD_FORWARD_SELECT);
-               if (reverseDirectionNeeded(cur))
-                       needsUpdate |= cursorLeftOneWord(cur);
-               else
-                       needsUpdate |= cursorRightOneWord(cur);
+               needsUpdate |= cursorForwardOneWord(cur);
+               break;
+
+       case LFUN_WORD_LEFT:
+       case LFUN_WORD_LEFT_SELECT:
+               //FIXME: for visual cursor mode, really move left
+               if (reverseDirectionNeeded(cur)) {
+                       lyx::dispatch(FuncRequest(
+                               cmd.action == LFUN_WORD_LEFT_SELECT ?
+                                       LFUN_WORD_FORWARD_SELECT : LFUN_WORD_FORWARD));
+               } else {
+                       lyx::dispatch(FuncRequest(
+                               cmd.action == LFUN_WORD_LEFT_SELECT ?
+                                       LFUN_WORD_BACKWARD_SELECT : LFUN_WORD_BACKWARD));
+               }
                break;
 
        case LFUN_WORD_BACKWARD:
        case LFUN_WORD_BACKWARD_SELECT:
                needsUpdate |= cur.selHandle(cmd.action == LFUN_WORD_BACKWARD_SELECT);
-               if (reverseDirectionNeeded(cur))
-                       needsUpdate |= cursorRightOneWord(cur);
-               else
-                       needsUpdate |= cursorLeftOneWord(cur);
+               needsUpdate |= cursorBackwardOneWord(cur);
                break;
 
        case LFUN_WORD_SELECT: {
@@ -485,7 +555,7 @@ void Text::dispatch(Cursor & cur, FuncRequest & cmd)
                        // this avoids a double undo
                        // FIXME: should not be needed, ideally
                        if (!cur.selection())
-                               recordUndo(cur);
+                               cur.recordUndo();
                        cap::replaceSelection(cur);
                        cur.insert(new InsetNewline);
                        cur.posRight();
@@ -514,8 +584,8 @@ void Text::dispatch(Cursor & cur, FuncRequest & cmd)
                // Reverse the effect of LFUN_BREAK_PARAGRAPH_SKIP.
                if (!cur.selection()) {
                        if (cur.pos() == cur.lastpos()) {
-                               cursorRight(cur);
-                               cursorLeft(cur);
+                               cursorForward(cur);
+                               cursorBackward(cur);
                        }
                        erase(cur);
                        cur.resetAnchor();
@@ -556,13 +626,7 @@ void Text::dispatch(Cursor & cur, FuncRequest & cmd)
 
        case LFUN_BREAK_PARAGRAPH:
                cap::replaceSelection(cur);
-               breakParagraph(cur, false);
-               cur.resetAnchor();
-               break;
-
-       case LFUN_BREAK_PARAGRAPH_KEEP_LAYOUT:
-               cap::replaceSelection(cur);
-               breakParagraph(cur, true);
+               breakParagraph(cur, cmd.argument() == "inverse");
                cur.resetAnchor();
                break;
 
@@ -622,7 +686,7 @@ void Text::dispatch(Cursor & cur, FuncRequest & cmd)
        }
 
        case LFUN_INSET_INSERT: {
-               recordUndo(cur);
+               cur.recordUndo();
                Inset * inset = createInset(bv, cmd);
                if (inset) {
                        // FIXME (Abdel 01/02/2006):
@@ -636,7 +700,7 @@ void Text::dispatch(Cursor & cur, FuncRequest & cmd)
                        // other feature like "automatic labelling".
                        /*
                        Paragraph & par = pars_[cur.pit()];
-                       if (inset->lyxCode() == Inset::LABEL_CODE
+                       if (inset->lyxCode() == LABEL_CODE
                                && par.layout()->labeltype == LABEL_COUNTER) {
                                // Go to the end of the paragraph
                                // Warning: Because of Change-Tracking, the last
@@ -694,15 +758,15 @@ void Text::dispatch(Cursor & cur, FuncRequest & cmd)
                break;
 
        case LFUN_WORD_UPCASE:
-               changeCase(cur, Text::text_uppercase);
+               changeCase(cur, text_uppercase);
                break;
 
        case LFUN_WORD_LOWCASE:
-               changeCase(cur, Text::text_lowercase);
+               changeCase(cur, text_lowercase);
                break;
 
        case LFUN_WORD_CAPITALIZE:
-               changeCase(cur, Text::text_capitalization);
+               changeCase(cur, text_capitalization);
                break;
 
        case LFUN_CHARS_TRANSPOSE:
@@ -723,7 +787,7 @@ void Text::dispatch(Cursor & cur, FuncRequest & cmd)
                }
                bv->buffer().errors("Paste");
                cur.clearSelection(); // bug 393
-               finishUndo();
+               cur.finishUndo();
                break;
 
        case LFUN_CUT:
@@ -756,9 +820,9 @@ void Text::dispatch(Cursor & cur, FuncRequest & cmd)
        }
 
        case LFUN_SERVER_GET_FONT:
-               if (cur.current_font.shape() == Font::ITALIC_SHAPE)
+               if (cur.current_font.fontInfo().shape() == ITALIC_SHAPE)
                        cur.message(from_ascii("E"));
-               else if (cur.current_font.shape() == Font::SMALLCAPS_SHAPE)
+               else if (cur.current_font.fontInfo().shape() == SMALLCAPS_SHAPE)
                        cur.message(from_ascii("N"));
                else
                        cur.message(from_ascii("0"));
@@ -772,6 +836,8 @@ void Text::dispatch(Cursor & cur, FuncRequest & cmd)
                docstring layout = cmd.argument();
                LYXERR(Debug::INFO) << "LFUN_LAYOUT: (arg) " << to_utf8(layout) << endl;
 
+               docstring const old_layout = cur.paragraph().layout()->name();
+
                // Derive layout number from given argument (string)
                // and current buffer's textclass (number)
                TextClass const & tclass = bv->buffer().params().getTextClass();
@@ -792,7 +858,7 @@ void Text::dispatch(Cursor & cur, FuncRequest & cmd)
                        break;
                }
 
-               bool change_layout = (frontend::current_layout != layout);
+               bool change_layout = (old_layout != layout);
 
                if (!change_layout && cur.selection() &&
                        cur.selBegin().pit() != cur.selEnd().pit())
@@ -800,7 +866,7 @@ void Text::dispatch(Cursor & cur, FuncRequest & cmd)
                        pit_type spit = cur.selBegin().pit();
                        pit_type epit = cur.selEnd().pit() + 1;
                        while (spit != epit) {
-                               if (pars_[spit].layout()->name() != frontend::current_layout) {
+                               if (pars_[spit].layout()->name() != old_layout) {
                                        change_layout = true;
                                        break;
                                }
@@ -808,11 +874,9 @@ void Text::dispatch(Cursor & cur, FuncRequest & cmd)
                        }
                }
 
-               if (change_layout) {
+               if (change_layout)
                        setLayout(cur, layout);
-                       // inform the GUI that the layout has changed.
-                       bv->layoutChanged(layout);
-               }
+
                break;
        }
 
@@ -853,7 +917,7 @@ void Text::dispatch(Cursor & cur, FuncRequest & cmd)
                        // this avoids a double undo
                        // FIXME: should not be needed, ideally
                        if (!cur.selection())
-                               recordUndo(cur);
+                               cur.recordUndo();
                        cap::replaceSelection(cur);
                        pos = cur.pos();
                        char_type c;
@@ -907,11 +971,14 @@ void Text::dispatch(Cursor & cur, FuncRequest & cmd)
        // Single-click on work area
        case LFUN_MOUSE_PRESS: {
                // Right click on a footnote flag opens float menu
+               // FIXME: Why should we clear the selection in this case?
                if (cmd.button() == mouse_button::button3)
                        cur.clearSelection();
 
+               bool do_selection = cmd.button() == mouse_button::button1
+                       && cmd.argument() == "region-select";
                // Set the cursor
-               bool update = bv->mouseSetCursor(cur);
+               bool update = bv->mouseSetCursor(cur, do_selection);
 
                // Insert primary selection with middle mouse
                // if there is a local selection in the current buffer,
@@ -927,7 +994,7 @@ void Text::dispatch(Cursor & cur, FuncRequest & cmd)
                                                    bv->buffer().errorList("Paste"));
                                bv->buffer().errors("Paste");
                                bv->buffer().markDirty();
-                               finishUndo();
+                               bv->cursor().finishUndo();
                        } else {
                                lyx::dispatch(FuncRequest(LFUN_PRIMARY_SELECTION_PASTE, "paragraph"));
                        }
@@ -1040,8 +1107,8 @@ void Text::dispatch(Cursor & cur, FuncRequest & cmd)
                break;
        }
 
-       case LFUN_URL_INSERT: {
-               InsetCommandParams p("url");
+       case LFUN_HYPERLINK_INSERT: {
+               InsetCommandParams p(HYPERLINK_CODE);
                docstring content;
                if (cur.selection()) {
                        content = cur.selectionAsString(false);
@@ -1049,28 +1116,9 @@ void Text::dispatch(Cursor & cur, FuncRequest & cmd)
                }
                p["target"] = (cmd.argument().empty()) ?
                        content : cmd.argument();
-               string const data = InsetCommandMailer::params2string("url", p);
+               string const data = InsetCommandMailer::params2string("href", p);
                if (p["target"].empty()) {
-                       bv->showInsetDialog("url", data, 0);
-               } else {
-                       FuncRequest fr(LFUN_INSET_INSERT, data);
-                       dispatch(cur, fr);
-               }
-               break;
-       }
-
-       case LFUN_HTML_INSERT: {
-               InsetCommandParams p("htmlurl");
-               docstring content;
-               if (cur.selection()) {
-                       content = cur.selectionAsString(false);
-                       cutSelection(cur, true, false);
-               }
-               p["target"] = (cmd.argument().empty()) ?
-                       content : cmd.argument();
-               string const data = InsetCommandMailer::params2string("url", p);
-               if (p["target"].empty()) {
-                       bv->showInsetDialog("url", data, 0);
+                       bv->showInsetDialog("href", data, 0);
                } else {
                        FuncRequest fr(LFUN_INSET_INSERT, data);
                        dispatch(cur, fr);
@@ -1079,7 +1127,7 @@ void Text::dispatch(Cursor & cur, FuncRequest & cmd)
        }
 
        case LFUN_LABEL_INSERT: {
-               InsetCommandParams p("label");
+               InsetCommandParams p(LABEL_CODE);
                // Try to generate a valid label
                p["name"] = (cmd.argument().empty()) ?
                        cur.getPossibleLabel() :
@@ -1095,16 +1143,33 @@ void Text::dispatch(Cursor & cur, FuncRequest & cmd)
                break;
        }
 
-
+       case LFUN_INFO_INSERT: {
+               Inset * inset = createInset(&cur.bv(), cmd);
+               if (!inset)
+                       break;
+               // if an empty inset is created (cmd.argument() is empty)
+               // use current selection as parameter.
+               if (cmd.argument().empty() && cur.selection()) {
+                       // use selected text as info to avoid a separate UI
+                       docstring ds = cur.selectionAsString(false);
+                       cutSelection(cur, true, false);
+                       static_cast<InsetInfo *>(inset)->setInfo(to_utf8(ds));
+               }
+               insertInset(cur, inset);
+               cur.posRight();
+               break;
+       }
 #if 0
        case LFUN_LIST_INSERT:
        case LFUN_THEOREM_INSERT:
 #endif
        case LFUN_CAPTION_INSERT:
+       case LFUN_FOOTNOTE_INSERT:
                // Open the inset, and move the current selection
                // inside it.
                doInsertInset(cur, this, cmd, true, true);
                cur.posRight();
+               // These insets are numbered.
                updateLabels(bv->buffer());
                break;
        case LFUN_NOTE_INSERT:
@@ -1114,7 +1179,6 @@ void Text::dispatch(Cursor & cur, FuncRequest & cmd)
        case LFUN_BIBITEM_INSERT:
        case LFUN_ERT_INSERT:
        case LFUN_LISTING_INSERT:
-       case LFUN_FOOTNOTE_INSERT:
        case LFUN_MARGINALNOTE_INSERT:
        case LFUN_OPTIONAL_INSERT:
        case LFUN_ENVIRONMENT_INSERT:
@@ -1177,11 +1241,14 @@ void Text::dispatch(Cursor & cur, FuncRequest & cmd)
        }
 
        case LFUN_INDEX_INSERT:
+               doInsertInset(cur, this, cmd, true, true);
+               cur.posRight();
+               break;
        case LFUN_NOMENCL_INSERT: {
                Inset * inset = createInset(&cur.bv(), cmd);
                if (!inset)
                        break;
-               recordUndo(cur);
+               cur.recordUndo();
                cur.clearSelection();
                insertInset(cur, inset);
                // Show the dialog for the nomenclature entry, since the
@@ -1235,7 +1302,7 @@ void Text::dispatch(Cursor & cur, FuncRequest & cmd)
                        int const nargs = s1.empty() ? 0 : convert<int>(s1);
                        string const s2 = token(s, ' ', 2);
                        string const type = s2.empty() ? "newcommand" : s2;
-                       cur.insert(new MathMacroTemplate(from_utf8(token(s, ' ', 0)), nargs, from_utf8(type)));
+                       cur.insert(new MathMacroTemplate(from_utf8(token(s, ' ', 0)), nargs, false, from_utf8(type)));
                        //cur.nextInset()->edit(cur, true);
                }
                break;
@@ -1266,63 +1333,63 @@ void Text::dispatch(Cursor & cur, FuncRequest & cmd)
        }
 
        case LFUN_FONT_EMPH: {
-               Font font(Font::ALL_IGNORE);
-               font.setEmph(Font::TOGGLE);
+               Font font(ignore_font);
+               font.fontInfo().setEmph(FONT_TOGGLE);
                toggleAndShow(cur, this, font);
                break;
        }
 
        case LFUN_FONT_BOLD: {
-               Font font(Font::ALL_IGNORE);
-               font.setSeries(Font::BOLD_SERIES);
+               Font font(ignore_font);
+               font.fontInfo().setSeries(BOLD_SERIES);
                toggleAndShow(cur, this, font);
                break;
        }
 
        case LFUN_FONT_NOUN: {
-               Font font(Font::ALL_IGNORE);
-               font.setNoun(Font::TOGGLE);
+               Font font(ignore_font);
+               font.fontInfo().setNoun(FONT_TOGGLE);
                toggleAndShow(cur, this, font);
                break;
        }
 
        case LFUN_FONT_TYPEWRITER: {
-               Font font(Font::ALL_IGNORE);
-               font.setFamily(Font::TYPEWRITER_FAMILY); // no good
+               Font font(ignore_font);
+               font.fontInfo().setFamily(TYPEWRITER_FAMILY); // no good
                toggleAndShow(cur, this, font);
                break;
        }
 
        case LFUN_FONT_SANS: {
-               Font font(Font::ALL_IGNORE);
-               font.setFamily(Font::SANS_FAMILY);
+               Font font(ignore_font);
+               font.fontInfo().setFamily(SANS_FAMILY);
                toggleAndShow(cur, this, font);
                break;
        }
 
        case LFUN_FONT_ROMAN: {
-               Font font(Font::ALL_IGNORE);
-               font.setFamily(Font::ROMAN_FAMILY);
+               Font font(ignore_font);
+               font.fontInfo().setFamily(ROMAN_FAMILY);
                toggleAndShow(cur, this, font);
                break;
        }
 
        case LFUN_FONT_DEFAULT: {
-               Font font(Font::ALL_INHERIT, ignore_language);
+               Font font(inherit_font, ignore_language);
                toggleAndShow(cur, this, font);
                break;
        }
 
        case LFUN_FONT_UNDERLINE: {
-               Font font(Font::ALL_IGNORE);
-               font.setUnderbar(Font::TOGGLE);
+               Font font(ignore_font);
+               font.fontInfo().setUnderbar(FONT_TOGGLE);
                toggleAndShow(cur, this, font);
                break;
        }
 
        case LFUN_FONT_SIZE: {
-               Font font(Font::ALL_IGNORE);
-               font.setLyXSize(to_utf8(cmd.argument()));
+               Font font(ignore_font);
+               setLyXSize(to_utf8(cmd.argument()), font.fontInfo());
                toggleAndShow(cur, this, font);
                break;
        }
@@ -1331,7 +1398,7 @@ void Text::dispatch(Cursor & cur, FuncRequest & cmd)
                Language const * lang = languages.getLanguage(to_utf8(cmd.argument()));
                if (!lang)
                        break;
-               Font font(Font::ALL_IGNORE);
+               Font font(ignore_font);
                font.setLanguage(lang);
                toggleAndShow(cur, this, font);
                break;
@@ -1352,6 +1419,8 @@ void Text::dispatch(Cursor & cur, FuncRequest & cmd)
                        toggleall = toggle;
                        toggleAndShow(cur, this, freefont, toggleall);
                        cur.message(_("Character set"));
+               } else {
+                       lyxerr << "Argument not ok";
                }
                break;
        }
@@ -1372,6 +1441,16 @@ void Text::dispatch(Cursor & cur, FuncRequest & cmd)
                }
                break;
 
+       case LFUN_FINISHED_BACKWARD:
+               LYXERR(Debug::DEBUG) << "handle LFUN_FINISHED_BACKWARD:\n" << cur << endl;
+               break;
+
+       case LFUN_FINISHED_FORWARD:
+               LYXERR(Debug::DEBUG) << "handle LFUN_FINISHED_FORWARD:\n" << cur << endl;
+               ++cur.pos();
+               cur.setCurrentFont();
+               break;
+
        case LFUN_LAYOUT_PARAGRAPH: {
                string data;
                params2string(cur.paragraph(), data);
@@ -1418,13 +1497,13 @@ void Text::dispatch(Cursor & cur, FuncRequest & cmd)
        case LFUN_FLOAT_LIST: {
                TextClass const & tclass = bv->buffer().params().getTextClass();
                if (tclass.floats().typeExist(to_utf8(cmd.argument()))) {
-                       recordUndo(cur);
+                       cur.recordUndo();
                        if (cur.selection())
                                cutSelection(cur, true, false);
                        breakParagraph(cur);
 
                        if (cur.lastpos() != 0) {
-                               cursorLeft(cur);
+                               cursorBackward(cur);
                                breakParagraph(cur);
                        }
 
@@ -1492,7 +1571,9 @@ void Text::dispatch(Cursor & cur, FuncRequest & cmd)
                        cur.selection() = false;
                } else {
                        cur.undispatched();
-                       cmd = FuncRequest(LFUN_FINISHED_RIGHT);
+                       // This used to be LFUN_FINISHED_RIGHT, I think FORWARD is more
+                       // correct, but I'm not 100% sure -- dov, 071019
+                       cmd = FuncRequest(LFUN_FINISHED_FORWARD);
                }
                break;
 
@@ -1560,8 +1641,9 @@ bool Text::getStatus(Cursor & cur, FuncRequest const & cmd,
        BOOST_ASSERT(cur.text() == this);
 
        Font const & font = cur.real_current_font;
+       FontInfo const & fontinfo = font.fontInfo();
        bool enable = true;
-       Inset::Code code = Inset::NO_CODE;
+       InsetCode code = NO_CODE;
 
        switch (cmd.action) {
 
@@ -1584,88 +1666,88 @@ bool Text::getStatus(Cursor & cur, FuncRequest const & cmd,
 
        case LFUN_DIALOG_SHOW_NEW_INSET:
                if (cmd.argument() == "bibitem")
-                       code = Inset::BIBITEM_CODE;
+                       code = BIBITEM_CODE;
                else if (cmd.argument() == "bibtex")
-                       code = Inset::BIBTEX_CODE;
+                       code = BIBTEX_CODE;
                else if (cmd.argument() == "box")
-                       code = Inset::BOX_CODE;
+                       code = BOX_CODE;
                else if (cmd.argument() == "branch")
-                       code = Inset::BRANCH_CODE;
+                       code = BRANCH_CODE;
                else if (cmd.argument() == "citation")
-                       code = Inset::CITE_CODE;
+                       code = CITE_CODE;
                else if (cmd.argument() == "ert")
-                       code = Inset::ERT_CODE;
+                       code = ERT_CODE;
                else if (cmd.argument() == "external")
-                       code = Inset::EXTERNAL_CODE;
+                       code = EXTERNAL_CODE;
                else if (cmd.argument() == "float")
-                       code = Inset::FLOAT_CODE;
+                       code = FLOAT_CODE;
                else if (cmd.argument() == "graphics")
-                       code = Inset::GRAPHICS_CODE;
+                       code = GRAPHICS_CODE;
+               else if (cmd.argument() == "href")
+                       code = HYPERLINK_CODE;
                else if (cmd.argument() == "include")
-                       code = Inset::INCLUDE_CODE;
+                       code = INCLUDE_CODE;
                else if (cmd.argument() == "index")
-                       code = Inset::INDEX_CODE;
+                       code = INDEX_CODE;
                else if (cmd.argument() == "nomenclature")
-                       code = Inset::NOMENCL_CODE;
+                       code = NOMENCL_CODE;
                else if (cmd.argument() == "label")
-                       code = Inset::LABEL_CODE;
+                       code = LABEL_CODE;
                else if (cmd.argument() == "note")
-                       code = Inset::NOTE_CODE;
+                       code = NOTE_CODE;
                else if (cmd.argument() == "ref")
-                       code = Inset::REF_CODE;
+                       code = REF_CODE;
                else if (cmd.argument() == "toc")
-                       code = Inset::TOC_CODE;
-               else if (cmd.argument() == "url")
-                       code = Inset::URL_CODE;
+                       code = TOC_CODE;
                else if (cmd.argument() == "vspace")
-                       code = Inset::VSPACE_CODE;
+                       code = VSPACE_CODE;
                else if (cmd.argument() == "wrap")
-                       code = Inset::WRAP_CODE;
+                       code = WRAP_CODE;
                else if (cmd.argument() == "listings")
-                       code = Inset::LISTINGS_CODE;
+                       code = LISTINGS_CODE;
                break;
 
        case LFUN_ERT_INSERT:
-               code = Inset::ERT_CODE;
+               code = ERT_CODE;
                break;
        case LFUN_LISTING_INSERT:
-           code = Inset::LISTINGS_CODE;
+           code = LISTINGS_CODE;
                break;
        case LFUN_FOOTNOTE_INSERT:
-               code = Inset::FOOT_CODE;
+               code = FOOT_CODE;
                break;
        case LFUN_TABULAR_INSERT:
-               code = Inset::TABULAR_CODE;
+               code = TABULAR_CODE;
                break;
        case LFUN_MARGINALNOTE_INSERT:
-               code = Inset::MARGIN_CODE;
+               code = MARGIN_CODE;
                break;
        case LFUN_FLOAT_INSERT:
        case LFUN_FLOAT_WIDE_INSERT:
-               code = Inset::FLOAT_CODE;
+               code = FLOAT_CODE;
                break;
        case LFUN_WRAP_INSERT:
-               code = Inset::WRAP_CODE;
+               code = WRAP_CODE;
                break;
        case LFUN_FLOAT_LIST:
-               code = Inset::FLOAT_LIST_CODE;
+               code = FLOAT_LIST_CODE;
                break;
 #if 0
        case LFUN_LIST_INSERT:
-               code = Inset::LIST_CODE;
+               code = LIST_CODE;
                break;
        case LFUN_THEOREM_INSERT:
-               code = Inset::THEOREM_CODE;
+               code = THEOREM_CODE;
                break;
 #endif
        case LFUN_CAPTION_INSERT:
-               code = Inset::CAPTION_CODE;
+               code = CAPTION_CODE;
                break;
        case LFUN_NOTE_INSERT:
-               code = Inset::NOTE_CODE;
+               code = NOTE_CODE;
                break;
        case LFUN_FLEX_INSERT: {
-               code = Inset::FLEX_CODE;
+               code = FLEX_CODE;
                string s = cmd.getArg(0);
                InsetLayout il =  cur.buffer().params().getTextClass().insetlayout(from_utf8(s));
                if (il.lyxtype != "charstyle" &&
@@ -1675,42 +1757,44 @@ bool Text::getStatus(Cursor & cur, FuncRequest const & cmd,
                break;
                }
        case LFUN_BOX_INSERT:
-               code = Inset::BOX_CODE;
+               code = BOX_CODE;
                break;
        case LFUN_BRANCH_INSERT:
-               code = Inset::BRANCH_CODE;
-               if (cur.buffer().getMasterBuffer()->params().branchlist().empty())
+               code = BRANCH_CODE;
+               if (cur.buffer().masterBuffer()->params().branchlist().empty())
                        enable = false;
                break;
        case LFUN_LABEL_INSERT:
-               code = Inset::LABEL_CODE;
+               code = LABEL_CODE;
+               break;
+       case LFUN_INFO_INSERT:
+               code = INFO_CODE;
                break;
        case LFUN_OPTIONAL_INSERT:
-               code = Inset::OPTARG_CODE;
-               enable = numberOfOptArgs(cur.paragraph())
+               code = OPTARG_CODE;
+               enable = cur.paragraph().insetList().count(OPTARG_CODE)
                        < cur.paragraph().layout()->optionalargs;
                break;
        case LFUN_ENVIRONMENT_INSERT:
-               code = Inset::BOX_CODE;
+               code = BOX_CODE;
                break;
        case LFUN_INDEX_INSERT:
-               code = Inset::INDEX_CODE;
+               code = INDEX_CODE;
                break;
        case LFUN_INDEX_PRINT:
-               code = Inset::INDEX_PRINT_CODE;
+               code = INDEX_PRINT_CODE;
                break;
        case LFUN_NOMENCL_INSERT:
-               code = Inset::NOMENCL_CODE;
+               code = NOMENCL_CODE;
                break;
        case LFUN_NOMENCL_PRINT:
-               code = Inset::NOMENCL_PRINT_CODE;
+               code = NOMENCL_PRINT_CODE;
                break;
        case LFUN_TOC_INSERT:
-               code = Inset::TOC_CODE;
+               code = TOC_CODE;
                break;
-       case LFUN_HTML_INSERT:
-       case LFUN_URL_INSERT:
-               code = Inset::URL_CODE;
+       case LFUN_HYPERLINK_INSERT:
+               code = HYPERLINK_CODE;
                break;
        case LFUN_QUOTE_INSERT:
                // always allow this, since we will inset a raw quote
@@ -1722,12 +1806,12 @@ bool Text::getStatus(Cursor & cur, FuncRequest const & cmd,
        case LFUN_MENU_SEPARATOR_INSERT:
        case LFUN_DOTS_INSERT:
        case LFUN_END_OF_SENTENCE_PERIOD_INSERT:
-               code = Inset::SPECIALCHAR_CODE;
+               code = SPECIALCHAR_CODE;
                break;
        case LFUN_SPACE_INSERT:
                // slight hack: we know this is allowed in math mode
                if (cur.inTexted())
-                       code = Inset::SPACE_CODE;
+                       code = SPACE_CODE;
                break;
 
        case LFUN_INSET_MODIFY:
@@ -1739,27 +1823,27 @@ bool Text::getStatus(Cursor & cur, FuncRequest const & cmd,
                break;
 
        case LFUN_FONT_EMPH:
-               flag.setOnOff(font.emph() == Font::ON);
+               flag.setOnOff(fontinfo.emph() == FONT_ON);
                return true;
 
        case LFUN_FONT_NOUN:
-               flag.setOnOff(font.noun() == Font::ON);
+               flag.setOnOff(fontinfo.noun() == FONT_ON);
                return true;
 
        case LFUN_FONT_BOLD:
-               flag.setOnOff(font.series() == Font::BOLD_SERIES);
+               flag.setOnOff(fontinfo.series() == BOLD_SERIES);
                return true;
 
        case LFUN_FONT_SANS:
-               flag.setOnOff(font.family() == Font::SANS_FAMILY);
+               flag.setOnOff(fontinfo.family() == SANS_FAMILY);
                return true;
 
        case LFUN_FONT_ROMAN:
-               flag.setOnOff(font.family() == Font::ROMAN_FAMILY);
+               flag.setOnOff(fontinfo.family() == ROMAN_FAMILY);
                return true;
 
        case LFUN_FONT_TYPEWRITER:
-               flag.setOnOff(font.family() == Font::TYPEWRITER_FAMILY);
+               flag.setOnOff(fontinfo.family() == TYPEWRITER_FAMILY);
                return true;
 
        case LFUN_CUT:
@@ -1801,7 +1885,14 @@ bool Text::getStatus(Cursor & cur, FuncRequest const & cmd,
                break;
 
        case LFUN_INSET_DISSOLVE:
-               enable = !isMainText(cur.bv().buffer()) && cur.inset().nargs() == 1;
+               if (!cmd.argument().empty()) {
+                       InsetLayout il = cur.inset().getLayout(cur.buffer().params());
+                       enable = cur.inset().lyxCode() == FLEX_CODE
+                                && il.lyxtype == to_utf8(cmd.argument());
+               } else {
+                       enable = !isMainText(cur.bv().buffer()) 
+                                && cur.inset().nargs() == 1;
+               }
                break;
 
        case LFUN_CHANGE_ACCEPT:
@@ -1820,10 +1911,16 @@ bool Text::getStatus(Cursor & cur, FuncRequest const & cmd,
        case LFUN_LINE_DELETE:
        case LFUN_WORD_FORWARD:
        case LFUN_WORD_BACKWARD:
+       case LFUN_WORD_RIGHT:
+       case LFUN_WORD_LEFT:
        case LFUN_CHAR_FORWARD:
        case LFUN_CHAR_FORWARD_SELECT:
        case LFUN_CHAR_BACKWARD:
        case LFUN_CHAR_BACKWARD_SELECT:
+       case LFUN_CHAR_LEFT:
+       case LFUN_CHAR_LEFT_SELECT:
+       case LFUN_CHAR_RIGHT:
+       case LFUN_CHAR_RIGHT_SELECT:
        case LFUN_UP:
        case LFUN_UP_SELECT:
        case LFUN_DOWN:
@@ -1836,6 +1933,8 @@ bool Text::getStatus(Cursor & cur, FuncRequest const & cmd,
        case LFUN_LINE_END_SELECT:
        case LFUN_WORD_FORWARD_SELECT:
        case LFUN_WORD_BACKWARD_SELECT:
+       case LFUN_WORD_RIGHT_SELECT:
+       case LFUN_WORD_LEFT_SELECT:
        case LFUN_WORD_SELECT:
        case LFUN_PARAGRAPH_UP:
        case LFUN_PARAGRAPH_DOWN:
@@ -1847,7 +1946,6 @@ bool Text::getStatus(Cursor & cur, FuncRequest const & cmd,
        case LFUN_CHAR_DELETE_BACKWARD:
        case LFUN_DELETE_BACKWARD_SKIP:
        case LFUN_BREAK_PARAGRAPH:
-       case LFUN_BREAK_PARAGRAPH_KEEP_LAYOUT:
        case LFUN_BREAK_PARAGRAPH_SKIP:
        case LFUN_PARAGRAPH_SPACING:
        case LFUN_INSET_INSERT:
@@ -1918,7 +2016,7 @@ bool Text::getStatus(Cursor & cur, FuncRequest const & cmd,
                return false;
        }
 
-       if (code != Inset::NO_CODE
+       if (code != NO_CODE
            && (cur.empty() || !cur.inset().insetAllowed(code)))
                enable = false;
 
@@ -1932,7 +2030,7 @@ void Text::pasteString(Cursor & cur, docstring const & clip,
 {
        cur.clearSelection();
        if (!clip.empty()) {
-               recordUndo(cur);
+               cur.recordUndo();
                if (asParagraphs)
                        insertStringAsParagraphs(cur, clip);
                else