]> git.lyx.org Git - lyx.git/blobdiff - src/Text3.cpp
Fix text direction issue for InsetInfo in RTL context
[lyx.git] / src / Text3.cpp
index 0e8b4127be617e84a1e7331f83631eb8b054c458..c4cf664802d18e6a5c5f38a9b9cc0d426d627705 100644 (file)
@@ -53,7 +53,7 @@
 #include "frontends/Selection.h"
 
 #include "insets/InsetArgument.h"
-#include "insets/InsetCollapsable.h"
+#include "insets/InsetCollapsible.h"
 #include "insets/InsetCommand.h"
 #include "insets/InsetExternal.h"
 #include "insets/InsetFloat.h"
@@ -78,7 +78,7 @@
 #include "support/regex.h"
 
 #include "mathed/InsetMathHull.h"
-#include "mathed/MathMacroTemplate.h"
+#include "mathed/InsetMathMacroTemplate.h"
 
 #include <clocale>
 #include <sstream>
@@ -89,23 +89,27 @@ using namespace lyx::support;
 namespace lyx {
 
 using cap::copySelection;
+using cap::copySelectionToTemp;
 using cap::cutSelection;
+using cap::cutSelectionToTemp;
 using cap::pasteFromStack;
+using cap::pasteFromTemp;
 using cap::pasteClipboardText;
 using cap::pasteClipboardGraphics;
 using cap::replaceSelection;
 using cap::grabAndEraseSelection;
 using cap::selClearOrDel;
 using cap::pasteSimpleText;
+using frontend::Clipboard;
 
 // globals...
 static Font freefont(ignore_font, ignore_language);
 static bool toggleall = false;
 
 static void toggleAndShow(Cursor & cur, Text * text,
-       Font const & font, bool toggleall = true)
+       Font const & font, bool togall = true)
 {
-       text->toggleFree(cur, font, toggleall);
+       text->toggleFree(cur, font, togall);
 
        if (font.language() != ignore_language ||
            font.fontInfo().number() != FONT_IGNORE) {
@@ -242,24 +246,11 @@ static bool doInsertInset(Cursor & cur, Text * text,
        if (!inset)
                return false;
 
-       if (InsetCollapsable * ci = inset->asInsetCollapsable())
+       if (InsetCollapsible * ci = inset->asInsetCollapsible())
                ci->setButtonLabel();
 
        cur.recordUndo();
-       if (cmd.action() == LFUN_INDEX_INSERT) {
-               docstring ds = subst(text->getStringToIndex(cur), '\n', ' ');
-               text->insertInset(cur, inset);
-               if (edit)
-                       inset->edit(cur, true);
-               // Now put this into inset
-               Font const f(inherit_font, cur.current_font.language());
-               if (!ds.empty()) {
-                       cur.text()->insertStringAsLines(cur, ds, f);
-                       cur.leaveInset(*inset);
-               }
-               return true;
-       }
-       else if (cmd.action() == LFUN_ARGUMENT_INSERT) {
+       if (cmd.action() == LFUN_ARGUMENT_INSERT) {
                bool cotextinsert = false;
                InsetArgument const * const ia = static_cast<InsetArgument const *>(inset);
                Layout const & lay = cur.paragraph().layout();
@@ -298,9 +289,16 @@ static bool doInsertInset(Cursor & cur, Text * text,
 
        bool gotsel = false;
        if (cur.selection()) {
-               cutSelection(cur, false, pastesel);
+               if (cmd.action() == LFUN_INDEX_INSERT)
+                       copySelectionToTemp(cur);
+               else
+                       cutSelectionToTemp(cur, pastesel);
                cur.clearSelection();
                gotsel = true;
+       } else if (cmd.action() == LFUN_INDEX_INSERT) {
+               gotsel = text->selectWordWhenUnderCursor(cur, WHOLE_WORD);
+               copySelectionToTemp(cur);
+               cur.clearSelection();
        }
        text->insertInset(cur, inset);
 
@@ -310,7 +308,7 @@ static bool doInsertInset(Cursor & cur, Text * text,
        if (!gotsel || !pastesel)
                return true;
 
-       pasteFromStack(cur, cur.buffer()->errorList("Paste"), 0);
+       pasteFromTemp(cur, cur.buffer()->errorList("Paste"));
        cur.buffer()->errors("Paste");
        cur.clearSelection(); // bug 393
        cur.finishUndo();
@@ -348,12 +346,6 @@ static bool doInsertInset(Cursor & cur, Text * text,
 }
 
 
-string const freefont2string()
-{
-       return freefont.toString(toggleall);
-}
-
-
 /// the type of outline operation
 enum OutlineOp {
        OutlineUp, // Move this header with text down
@@ -363,7 +355,23 @@ enum OutlineOp {
 };
 
 
-static void outline(OutlineOp mode, Cursor & cur)
+static void insertSeparator(Cursor & cur, depth_type const depth)
+{
+       Buffer & buf = *cur.buffer();
+       lyx::dispatch(FuncRequest(LFUN_PARAGRAPH_BREAK));
+       DocumentClass const & tc = buf.params().documentClass();
+       lyx::dispatch(FuncRequest(LFUN_LAYOUT, from_ascii("\"") + tc.plainLayout().name()
+                                 + from_ascii("\" ignoreautonests")));
+       // FIXME: Bibitem mess!
+       if (cur.prevInset() && cur.prevInset()->lyxCode() == BIBITEM_CODE)
+               lyx::dispatch(FuncRequest(LFUN_CHAR_DELETE_BACKWARD));
+       lyx::dispatch(FuncRequest(LFUN_SEPARATOR_INSERT, "plain"));
+       while (cur.paragraph().params().depth() > depth)
+               lyx::dispatch(FuncRequest(LFUN_DEPTH_DECREMENT));
+}
+
+
+static void outline(OutlineOp mode, Cursor & cur, Text * text)
 {
        Buffer & buf = *cur.buffer();
        pit_type & pit = cur.pit();
@@ -374,6 +382,7 @@ static void outline(OutlineOp mode, Cursor & cur)
        // The final paragraph of area to be copied:
        ParagraphList::iterator finish = start;
        ParagraphList::iterator const end = pars.end();
+       depth_type const current_depth = cur.paragraph().params().depth();
 
        int const thistoclevel = buf.text().getTocLevel(distance(bgn, start));
        int toclevel;
@@ -408,10 +417,47 @@ static void outline(OutlineOp mode, Cursor & cur)
                        // Not found; do nothing
                        if (toclevel == Layout::NOT_IN_TOC || toclevel > thistoclevel)
                                return;
-                       pit_type const newpit = distance(bgn, dest);
+                       pit_type newpit = distance(bgn, dest);
                        pit_type const len = distance(start, finish);
                        pit_type const deletepit = pit + len;
                        buf.undo().recordUndo(cur, newpit, deletepit - 1);
+                       // If we move an environment upwards, make sure it is
+                       // separated from its new neighbour below:
+                       // If an environment of the same layout follows, and the moved
+                       // paragraph sequence does not end with a separator, insert one.
+                       ParagraphList::iterator lastmoved = finish;
+                       --lastmoved;
+                       if (start->layout().isEnvironment()
+                           && dest->layout() == start->layout()
+                           && !lastmoved->isEnvSeparator(lastmoved->beginOfBody())) {
+                               cur.pit() = distance(bgn, lastmoved);
+                               cur.pos() = cur.lastpos();
+                               insertSeparator(cur, current_depth);
+                               cur.pit() = pit;
+                       }
+                       // Likewise, if we moved an environment upwards, make sure it
+                       // is separated from its new neighbour above.
+                       // The paragraph before the target of movement
+                       if (dest != bgn) {
+                               ParagraphList::iterator before = dest;
+                               --before;
+                               // Get the parent paragraph (outer in nested context)
+                               pit_type const parent =
+                                       before->params().depth() > current_depth
+                                               ? text->depthHook(distance(bgn, before), current_depth)
+                                               : distance(bgn, before);
+                               // If a environment with same layout preceeds the moved one in the new
+                               // position, and there is no separator yet, insert one.
+                               if (start->layout().isEnvironment()
+                                   && pars[parent].layout() == start->layout()
+                                   && !before->isEnvSeparator(before->beginOfBody())) {
+                                       cur.pit() = distance(bgn, before);
+                                       cur.pos() = cur.lastpos();
+                                       insertSeparator(cur, current_depth);
+                                       cur.pit() = pit;
+                               }
+                       }
+                       newpit = distance(bgn, dest);
                        pars.splice(dest, start, finish);
                        cur.pit() = newpit;
                        break;
@@ -429,9 +475,45 @@ static void outline(OutlineOp mode, Cursor & cur)
                                      && toclevel <= thistoclevel)
                                        break;
                        }
-                       // One such was found:
+                       // One such was found, so go on...
+                       // If we move an environment downwards, make sure it is
+                       // separated from its new neighbour above.
                        pit_type newpit = distance(bgn, dest);
                        buf.undo().recordUndo(cur, pit, newpit - 1);
+                       // The paragraph before the target of movement
+                       ParagraphList::iterator before = dest;
+                       --before;
+                       // Get the parent paragraph (outer in nested context)
+                       pit_type const parent =
+                               before->params().depth() > current_depth
+                                       ? text->depthHook(distance(bgn, before), current_depth)
+                                       : distance(bgn, before);
+                       // If a environment with same layout preceeds the moved one in the new
+                       // position, and there is no separator yet, insert one.
+                       if (start->layout().isEnvironment()
+                           && pars[parent].layout() == start->layout()
+                           && !before->isEnvSeparator(before->beginOfBody())) {
+                               cur.pit() = distance(bgn, before);
+                               cur.pos() = cur.lastpos();
+                               insertSeparator(cur, current_depth);
+                               cur.pit() = pit;
+                       }
+                       // Likewise, make sure moved environments are separated
+                       // from their new neighbour below:
+                       // If an environment of the same layout follows, and the moved
+                       // paragraph sequence does not end with a separator, insert one.
+                       ParagraphList::iterator lastmoved = finish;
+                       --lastmoved;
+                       if (dest != end
+                           && start->layout().isEnvironment()
+                           && dest->layout() == start->layout()
+                           && !lastmoved->isEnvSeparator(lastmoved->beginOfBody())) {
+                               cur.pit() = distance(bgn, lastmoved);
+                               cur.pos() = cur.lastpos();
+                               insertSeparator(cur, current_depth);
+                               cur.pit() = pit;
+                       }
+                       newpit = distance(bgn, dest);
                        pit_type const len = distance(start, finish);
                        pars.splice(dest, start, finish);
                        cur.pit() = newpit - len;
@@ -449,7 +531,7 @@ static void outline(OutlineOp mode, Cursor & cur)
                                DocumentClass const & tc = buf.params().documentClass();
                                DocumentClass::const_iterator lit = tc.begin();
                                DocumentClass::const_iterator len = tc.end();
-                               int const newtoclevel = 
+                               int const newtoclevel =
                                        (mode == OutlineIn ? toclevel + 1 : toclevel - 1);
                                LabelType const oldlabeltype = start->layout().labeltype;
 
@@ -481,16 +563,66 @@ bool Text::isRTL(Paragraph const & par) const
        return par.isRTL(buffer.params());
 }
 
-       
+
 namespace {
-               
-       Language const * getLanguage(Cursor const & cur, string const & lang) {
-               return lang.empty() ? cur.getFont().language() : languages.getLanguage(lang);
+
+Language const * getLanguage(Cursor const & cur, string const & lang)
+{
+       return lang.empty() ? cur.getFont().language() : languages.getLanguage(lang);
+}
+
+
+docstring resolveLayout(docstring layout, DocIterator const & dit)
+{
+       Paragraph const & par = dit.paragraph();
+       docstring const old_layout = par.layout().name();
+       DocumentClass const & tclass = dit.buffer()->params().documentClass();
+
+       if (layout.empty())
+               layout = tclass.defaultLayoutName();
+
+       if (dit.inset().forcePlainLayout(dit.idx()))
+               // in this case only the empty layout is allowed
+               layout = tclass.plainLayoutName();
+       else if (par.usePlainLayout()) {
+               // in this case, default layout maps to empty layout
+               if (layout == tclass.defaultLayoutName())
+                       layout = tclass.plainLayoutName();
+       } else {
+               // otherwise, the empty layout maps to the default
+               if (layout == tclass.plainLayoutName())
+                       layout = tclass.defaultLayoutName();
+       }
+
+       // If the entry is obsolete, use the new one instead.
+       if (tclass.hasLayout(layout)) {
+               docstring const & obs = tclass[layout].obsoleted_by();
+               if (!obs.empty())
+                       layout = obs;
        }
+       if (!tclass.hasLayout(layout))
+               layout.clear();
+       return layout;
+}
+
 
+bool isAlreadyLayout(docstring const & layout, CursorData const & cur)
+{
+       ParagraphList const & pars = cur.text()->paragraphs();
+
+       pit_type pit = cur.selBegin().pit();
+       pit_type const epit = cur.selEnd().pit() + 1;
+       for ( ; pit != epit; ++pit)
+               if (pars[pit].layout().name() != layout)
+                       return false;
+
+       return true;
 }
 
 
+} // namespace
+
+
 void Text::dispatch(Cursor & cur, FuncRequest & cmd)
 {
        LYXERR(Debug::ACTION, "Text::dispatch: cmd: " << cmd);
@@ -515,7 +647,7 @@ void Text::dispatch(Cursor & cur, FuncRequest & cmd)
        cur.noScreenUpdate();
 
        LBUFERR(this == cur.text());
-       
+
        // NOTE: This should NOT be a reference. See commit 94a5481a.
        CursorSlice const oldTopSlice = cur.top();
        bool const oldBoundary = cur.boundary();
@@ -581,23 +713,23 @@ void Text::dispatch(Cursor & cur, FuncRequest & cmd)
 
        case LFUN_WORD_DELETE_FORWARD:
                if (cur.selection())
-                       cutSelection(cur, true, false);
+                       cutSelection(cur, false);
                else
-                       deleteWordForward(cur);
+                       deleteWordForward(cur, cmd.getArg(0) == "force");
                finishChange(cur, false);
                break;
 
        case LFUN_WORD_DELETE_BACKWARD:
                if (cur.selection())
-                       cutSelection(cur, true, false);
+                       cutSelection(cur, false);
                else
-                       deleteWordBackward(cur);
+                       deleteWordBackward(cur, cmd.getArg(0) == "force");
                finishChange(cur, false);
                break;
 
        case LFUN_LINE_DELETE_FORWARD:
                if (cur.selection())
-                       cutSelection(cur, true, false);
+                       cutSelection(cur, false);
                else
                        tm->deleteLineForward(cur);
                finishChange(cur, false);
@@ -767,6 +899,18 @@ void Text::dispatch(Cursor & cur, FuncRequest & cmd)
                        cur.upDownInText(up, needsUpdate);
                        needsUpdate |= cur.beforeDispatchCursor().inMathed();
                } else {
+                       pos_type newpos = up ? 0 : cur.lastpos();
+                       if (lyxrc.mac_like_cursor_movement && cur.pos() != newpos) {
+                               needsUpdate |= cur.selHandle(select);
+                               // we do not reset the targetx of the cursor
+                               cur.pos() = newpos;
+                               needsUpdate |= bv->checkDepm(cur, bv->cursor());
+                               cur.updateTextTargetOffset();
+                               if (needsUpdate)
+                                       cur.forceBufferUpdate();
+                               break;
+                       }
+
                        // if the cursor cannot be moved up or down do not remove
                        // the selection right now, but wait for the next dispatch.
                        if (select)
@@ -832,6 +976,8 @@ void Text::dispatch(Cursor & cur, FuncRequest & cmd)
                                break;
                }
                cur.pos() = cur.lastpos();
+               cur.boundary(false);
+               cur.setCurrentFont();
 
                needsUpdate |= cur != old_cur;
                break;
@@ -985,8 +1131,8 @@ void Text::dispatch(Cursor & cur, FuncRequest & cmd)
                } else {
                        // Maybe we shouldn't allow tabs within a line, because they
                        // are not (yet) aligned as one might do expect.
-                       FuncRequest cmd(LFUN_SELF_INSERT, from_ascii("\t"));
-                       dispatch(cur, cmd);
+                       FuncRequest ncmd(LFUN_SELF_INSERT, from_ascii("\t"));
+                       dispatch(cur, ncmd);
                }
                break;
        }
@@ -1051,10 +1197,17 @@ void Text::dispatch(Cursor & cur, FuncRequest & cmd)
                        if (cur.pos() == cur.paragraph().size())
                                // Par boundary, force full-screen update
                                singleParUpdate = false;
+                       else if (cmd.getArg(0) != "force" && cur.confirmDeletion()) {
+                               cur.resetAnchor();
+                               cur.selection(true);
+                               cur.posForward();
+                               cur.setSelection();
+                               break;
+                       }
                        needsUpdate |= erase(cur);
                        cur.resetAnchor();
                } else {
-                       cutSelection(cur, true, false);
+                       cutSelection(cur, false);
                        singleParUpdate = false;
                }
                moveCursor(cur, false);
@@ -1068,6 +1221,13 @@ void Text::dispatch(Cursor & cur, FuncRequest & cmd)
                                // Par boundary, full-screen update
                                if (par_boundary)
                                        singleParUpdate = false;
+                               else if (cmd.getArg(0) != "force" && cur.confirmDeletion(true)) {
+                                       cur.resetAnchor();
+                                       cur.selection(true);
+                                       cur.posBackward();
+                                       cur.setSelection();
+                                       break;
+                               }
                                needsUpdate |= backspace(cur);
                                cur.resetAnchor();
                                if (par_boundary && !first_par && cur.pos() > 0
@@ -1077,7 +1237,7 @@ void Text::dispatch(Cursor & cur, FuncRequest & cmd)
                                }
                        }
                } else {
-                       cutSelection(cur, true, false);
+                       cutSelection(cur, false);
                        singleParUpdate = false;
                }
                break;
@@ -1088,13 +1248,7 @@ void Text::dispatch(Cursor & cur, FuncRequest & cmd)
                Paragraph const & par = pars_[pit];
                bool lastpar = (pit == pit_type(pars_.size() - 1));
                Paragraph const & nextpar = lastpar ? par : pars_[pit + 1];
-               pit_type prev = pit;
-               if (pit > 0) {
-                       if (!pars_[pit - 1].layout().isEnvironment())
-                               prev = depthHook(pit, par.getDepth());
-                       else if (pars_[pit - 1].getDepth() >= par.getDepth())
-                               prev = pit - 1;
-               }
+               pit_type prev = pit > 0 ? depthHook(pit, par.getDepth()) : pit;
                if (prev < pit && cur.pos() == par.beginOfBody()
                    && !par.size() && !par.isEnvSeparator(cur.pos())
                    && !par.layout().isCommand()
@@ -1116,21 +1270,19 @@ void Text::dispatch(Cursor & cur, FuncRequest & cmd)
                        Font const f(inherit_font, cur.current_font.language());
                        pars_[cur.pit() - 1].resetFonts(f);
                } else {
-                       if (par.isEnvSeparator(cur.pos()))
+                       if (par.isEnvSeparator(cur.pos()) && cmd.getArg(1) != "ignoresep")
                                cur.posForward();
-                       breakParagraph(cur, cmd.argument() == "inverse");
+                       breakParagraph(cur, cmd.getArg(0) == "inverse");
                }
                cur.resetAnchor();
                // If we have a list and autoinsert item insets,
                // insert them now.
                Layout::LaTeXArgMap args = par.layout().args();
-               Layout::LaTeXArgMap::const_iterator lait = args.begin();
-               Layout::LaTeXArgMap::const_iterator const laend = args.end();
-               for (; lait != laend; ++lait) {
-                       Layout::latexarg arg = (*lait).second;
-                       if (arg.autoinsert && prefixIs((*lait).first, "item:")) {
-                               FuncRequest cmd(LFUN_ARGUMENT_INSERT, (*lait).first);
-                               lyx::dispatch(cmd);
+               for (auto const & thearg : args) {
+                       Layout::latexarg arg = thearg.second;
+                       if (arg.autoinsert && prefixIs(thearg.first, "item:")) {
+                               FuncRequest cmd2(LFUN_ARGUMENT_INSERT, thearg.first);
+                               lyx::dispatch(cmd2);
                        }
                }
                break;
@@ -1170,8 +1322,9 @@ void Text::dispatch(Cursor & cur, FuncRequest & cmd)
                        }
                        */
                        if (cur.selection())
-                               cutSelection(cur, true, false);
+                               cutSelection(cur, false);
                        cur.insert(inset);
+                       cur.forceBufferUpdate();
                        if (inset->editable() && inset->asInsetText())
                                inset->edit(cur, true);
                        else
@@ -1196,7 +1349,7 @@ void Text::dispatch(Cursor & cur, FuncRequest & cmd)
                break;
        }
 
-       case LFUN_SET_GRAPHICS_GROUP: {
+       case LFUN_GRAPHICS_SET_GROUP: {
                InsetGraphics * ins = graphics::getCurrentGraphicsInset(cur);
                if (!ins)
                        break;
@@ -1216,6 +1369,7 @@ void Text::dispatch(Cursor & cur, FuncRequest & cmd)
                }
 
                ins->setParams(inspar);
+               break;
        }
 
        case LFUN_SPACE_INSERT:
@@ -1232,6 +1386,8 @@ void Text::dispatch(Cursor & cur, FuncRequest & cmd)
                string const name = to_utf8(cmd.argument());
                if (name == "hyphenation")
                        specialChar(cur, InsetSpecialChar::HYPHENATION);
+               else if (name == "allowbreak")
+                       specialChar(cur, InsetSpecialChar::ALLOWBREAK);
                else if (name == "ligature-break")
                        specialChar(cur, InsetSpecialChar::LIGATURE_BREAK);
                else if (name == "slash")
@@ -1358,7 +1514,7 @@ void Text::dispatch(Cursor & cur, FuncRequest & cmd)
        }
 
        case LFUN_CUT:
-               cutSelection(cur, true, true);
+               cutSelection(cur, true);
                cur.message(_("Cut"));
                break;
 
@@ -1390,72 +1546,46 @@ void Text::dispatch(Cursor & cur, FuncRequest & cmd)
                cur.message(cur.paragraph().layout().name());
                break;
 
-       case LFUN_LAYOUT: {
-               docstring layout = cmd.argument();
-               LYXERR(Debug::INFO, "LFUN_LAYOUT: (arg) " << to_utf8(layout));
+       case LFUN_LAYOUT:
+       case LFUN_LAYOUT_TOGGLE: {
+               bool const ignoreautonests = cmd.getArg(1) == "ignoreautonests";
+               docstring req_layout = ignoreautonests ? from_utf8(cmd.getArg(0)) : cmd.argument();
+               LYXERR(Debug::INFO, "LFUN_LAYOUT: (arg) " << to_utf8(req_layout));
 
-               Paragraph const & para = cur.paragraph();
-               docstring const old_layout = para.layout().name();
-               DocumentClass const & tclass = bv->buffer().params().documentClass();
-
-               if (layout.empty())
-                       layout = tclass.defaultLayoutName();
-
-               if (owner_->forcePlainLayout())
-                       // in this case only the empty layout is allowed
-                       layout = tclass.plainLayoutName();
-               else if (para.usePlainLayout()) {
-                       // in this case, default layout maps to empty layout
-                       if (layout == tclass.defaultLayoutName())
-                               layout = tclass.plainLayoutName();
-               } else {
-                       // otherwise, the empty layout maps to the default
-                       if (layout == tclass.plainLayoutName())
-                               layout = tclass.defaultLayoutName();
-               }
-
-               bool hasLayout = tclass.hasLayout(layout);
-
-               // If the entry is obsolete, use the new one instead.
-               if (hasLayout) {
-                       docstring const & obs = tclass[layout].obsoleted_by();
-                       if (!obs.empty())
-                               layout = obs;
-               }
-
-               if (!hasLayout) {
-                       cur.errorMessage(from_utf8(N_("Layout ")) + cmd.argument() +
+               docstring layout = resolveLayout(req_layout, cur);
+               if (layout.empty()) {
+                       cur.errorMessage(from_utf8(N_("Layout ")) + req_layout +
                                from_utf8(N_(" not known")));
                        break;
                }
 
-               bool change_layout = (old_layout != layout);
+               docstring const old_layout = cur.paragraph().layout().name();
+               bool change_layout = !isAlreadyLayout(layout, cur);
 
-               if (!change_layout && cur.selection() &&
-                       cur.selBegin().pit() != cur.selEnd().pit())
-               {
-                       pit_type spit = cur.selBegin().pit();
-                       pit_type epit = cur.selEnd().pit() + 1;
-                       while (spit != epit) {
-                               if (pars_[spit].layout().name() != old_layout) {
-                                       change_layout = true;
-                                       break;
-                               }
-                               ++spit;
-                       }
+               if (cmd.action() == LFUN_LAYOUT_TOGGLE && !change_layout) {
+                       change_layout = true;
+                       layout = resolveLayout(docstring(), cur);
                }
 
-               if (change_layout)
+               if (change_layout) {
                        setLayout(cur, layout);
+                       if (cur.pit() > 0 && !ignoreautonests) {
+                               set<docstring> const & autonests =
+                                               pars_[cur.pit() - 1].layout().autonests();
+                               set<docstring> const & autonested =
+                                               pars_[cur.pit()].layout().isAutonestedBy();
+                               if (autonests.find(layout) != autonests.end()
+                                               || autonested.find(old_layout) != autonested.end())
+                                       lyx::dispatch(FuncRequest(LFUN_DEPTH_INCREMENT));
+                       }
+               }
 
-               Layout::LaTeXArgMap args = tclass[layout].args();
-               Layout::LaTeXArgMap::const_iterator lait = args.begin();
-               Layout::LaTeXArgMap::const_iterator const laend = args.end();
-               for (; lait != laend; ++lait) {
-                       Layout::latexarg arg = (*lait).second;
+               DocumentClass const & tclass = bv->buffer().params().documentClass();
+               for (auto const & la_pair : tclass[layout].args()) {
+                       Layout::latexarg const & arg = la_pair.second;
                        if (arg.autoinsert) {
-                               FuncRequest cmd(LFUN_ARGUMENT_INSERT, (*lait).first);
-                               lyx::dispatch(cmd);
+                               FuncRequest const cmd2(LFUN_ARGUMENT_INSERT, la_pair.first);
+                               lyx::dispatch(cmd2);
                        }
                }
 
@@ -1464,36 +1594,78 @@ void Text::dispatch(Cursor & cur, FuncRequest & cmd)
 
        case LFUN_ENVIRONMENT_SPLIT: {
                bool const outer = cmd.argument() == "outer";
+               bool const previous = cmd.argument() == "previous";
+               bool const before = cmd.argument() == "before";
+               bool const normal = cmd.argument().empty();
                Paragraph const & para = cur.paragraph();
-               docstring layout = para.layout().name();
+               docstring layout;
+               if (para.layout().isEnvironment())
+                       layout = para.layout().name();
                depth_type split_depth = cur.paragraph().params().depth();
-               if (outer) {
-                       // check if we have an environment in our nesting hierarchy
+               depth_type nextpar_depth = 0;
+               if (outer || previous) {
+                       // check if we have an environment in our scope
                        pit_type pit = cur.pit();
                        Paragraph cpar = pars_[pit];
                        while (true) {
-                               if (pit == 0 || cpar.params().depth() == 0)
+                               if (pit == 0)
                                        break;
                                --pit;
                                cpar = pars_[pit];
+                               if (layout.empty() && previous
+                                   && cpar.layout().isEnvironment()
+                                   && cpar.params().depth() <= split_depth)
+                                       layout = cpar.layout().name();
                                if (cpar.params().depth() < split_depth
                                    && cpar.layout().isEnvironment()) {
-                                               layout = cpar.layout().name();
+                                               if (!previous)
+                                                       layout = cpar.layout().name();
                                                split_depth = cpar.params().depth();
                                }
+                               if (cpar.params().depth() == 0)
+                                       break;
                        }
                }
-               if (cur.pos() > 0)
+               if ((outer || normal) && cur.pit() < cur.lastpit()) {
+                       // save nesting of following paragraph
+                       Paragraph cpar = pars_[cur.pit() + 1];
+                       nextpar_depth = cpar.params().depth();
+               }
+               if (before)
+                       cur.top().setPitPos(cur.pit(), 0);
+               if (before || cur.pos() > 0)
                        lyx::dispatch(FuncRequest(LFUN_PARAGRAPH_BREAK));
+               else if (previous && cur.nextInset() && cur.nextInset()->lyxCode() == SEPARATOR_CODE)
+                       lyx::dispatch(FuncRequest(LFUN_PARAGRAPH_BREAK, "inverse ignoresep"));
                if (outer) {
                        while (cur.paragraph().params().depth() > split_depth)
                                lyx::dispatch(FuncRequest(LFUN_DEPTH_DECREMENT));
                }
                DocumentClass const & tc = bv->buffer().params().documentClass();
-               lyx::dispatch(FuncRequest(LFUN_LAYOUT, tc.plainLayout().name()));
+               lyx::dispatch(FuncRequest(LFUN_LAYOUT, from_ascii("\"") + tc.plainLayout().name()
+                                         + from_ascii("\" ignoreautonests")));
+               // FIXME: Bibitem mess!
+               if (cur.prevInset() && cur.prevInset()->lyxCode() == BIBITEM_CODE)
+                       lyx::dispatch(FuncRequest(LFUN_CHAR_DELETE_BACKWARD));
                lyx::dispatch(FuncRequest(LFUN_SEPARATOR_INSERT, "plain"));
-               lyx::dispatch(FuncRequest(LFUN_PARAGRAPH_BREAK, "inverse"));
+               if (before) {
+                       cur.backwardPos();
+                       lyx::dispatch(FuncRequest(LFUN_PARAGRAPH_BREAK, "inverse ignoresep"));
+                       while (cur.paragraph().params().depth() < split_depth)
+                               lyx::dispatch(FuncRequest(LFUN_DEPTH_INCREMENT));
+               }
+               else
+                       lyx::dispatch(FuncRequest(LFUN_PARAGRAPH_BREAK, "inverse"));
                lyx::dispatch(FuncRequest(LFUN_LAYOUT, layout));
+               if ((outer || normal) && nextpar_depth > 0) {
+                       // restore nesting of following paragraph
+                       DocIterator scur = cur;
+                       depth_type const max_depth = cur.paragraph().params().depth() + 1;
+                       cur.forwardPar();
+                       while (cur.paragraph().params().depth() < min(nextpar_depth, max_depth))
+                               lyx::dispatch(FuncRequest(LFUN_DEPTH_INCREMENT));
+                       cur.setCursor(scur);
+               }
 
                break;
        }
@@ -1526,21 +1698,6 @@ void Text::dispatch(Cursor & cur, FuncRequest & cmd)
                bv->buffer().errors("Paste");
                break;
 
-       case LFUN_UNICODE_INSERT: {
-               if (cmd.argument().empty())
-                       break;
-               docstring hexstring = cmd.argument();
-               if (isHex(hexstring)) {
-                       char_type c = hexToInt(hexstring);
-                       if (c >= 32 && c < 0x10ffff) {
-                               lyxerr << "Inserting c: " << c << endl;
-                               docstring s = docstring(1, c);
-                               lyx::dispatch(FuncRequest(LFUN_SELF_INSERT, s));
-                       }
-               }
-               break;
-       }
-
        case LFUN_QUOTE_INSERT: {
                cap::replaceSelection(cur);
                cur.recordUndo();
@@ -1551,26 +1708,44 @@ void Text::dispatch(Cursor & cur, FuncRequest & cmd)
                while (pos > 0 && par.isDeleted(pos - 1))
                        --pos;
 
-               BufferParams const & bufparams = bv->buffer().params();
-               bool const hebrew =
-                       par.getFontSettings(bufparams, pos).language()->lang() == "hebrew";
-               bool const allow_inset_quote = !(par.isPassThru() || hebrew);
-
-               string const arg = to_utf8(cmd.argument());
-               if (allow_inset_quote) {
-                       char_type c = ' ';
-                       if (pos > 0 && (!cur.prevInset() || !cur.prevInset()->isSpace()))
+               bool const inner = (cmd.getArg(0) == "single" || cmd.getArg(0) == "inner");
+
+               // Guess quote side.
+               // A space triggers an opening quote. This is passed if the preceding
+               // char/inset is a space or at paragraph start.
+               char_type c = ' ';
+               if (pos > 0 && !par.isSpace(pos - 1)) {
+                       if (cur.prevInset() && cur.prevInset()->lyxCode() == QUOTE_CODE) {
+                               // If an opening double quotation mark precedes, and this
+                               // is a single quote, make it opening as well
+                               InsetQuotes & ins =
+                                       static_cast<InsetQuotes &>(*cur.prevInset());
+                               string const type = ins.getType();
+                               if (!suffixIs(type, "ld") || !inner)
+                                       c = par.getChar(pos - 1);
+                       }
+                       else if (!cur.prevInset()
+                           || (cur.prevInset() && cur.prevInset()->isChar()))
+                               // If a char precedes, pass that and let InsetQuote decide
                                c = par.getChar(pos - 1);
-                       InsetQuotes::QuoteTimes const quote_type = (arg == "single")
-                               ? InsetQuotes::SingleQuotes : InsetQuotes::DoubleQuotes;
-                       cur.insert(new InsetQuotes(cur.buffer(), c, quote_type));
-                       cur.posForward();
-               } else {
-                       // The cursor might have been invalidated by the replaceSelection.
-                       cur.buffer()->changed(true);
-                       string const quote_string = (arg == "single") ? "'" : "\"";
-                       lyx::dispatch(FuncRequest(LFUN_SELF_INSERT, quote_string));
+                       else {
+                               while (pos > 0) {
+                                       if (par.getInset(pos - 1)
+                                           && !par.getInset(pos - 1)->isPartOfTextSequence()) {
+                                               // skip "invisible" insets
+                                               --pos;
+                                               continue;
+                                       }
+                                       c = par.getChar(pos - 1);
+                                       break;
+                               }
+                       }
                }
+               InsetQuotesParams::QuoteLevel const quote_level = inner
+                               ? InsetQuotesParams::SecondaryQuotes : InsetQuotesParams::PrimaryQuotes;
+               cur.insert(new InsetQuotes(cur.buffer(), c, quote_level, cmd.getArg(1), cmd.getArg(2)));
+               cur.buffer()->updateBuffer();
+               cur.posForward();
                break;
        }
 
@@ -1606,9 +1781,11 @@ void Text::dispatch(Cursor & cur, FuncRequest & cmd)
                bvcur.setMark(false);
                switch (cmd.button()) {
                case mouse_button::button1:
-                       // Set the cursor
-                       if (!bv->mouseSetCursor(cur, cmd.argument() == "region-select"))
-                               cur.screenUpdateFlags(Update::FitCursor);
+                       if (!bvcur.selection())
+                               // Set the cursor
+                               bvcur.resetAnchor();
+                       if (!bv->mouseSetCursor(cur, cmd.modifier() == ShiftModifier))
+                               cur.screenUpdateFlags(Update::SinglePar | Update::FitCursor);
                        if (bvcur.wordSelection())
                                selectWord(bvcur, WHOLE_WORD);
                        break;
@@ -1679,6 +1856,7 @@ void Text::dispatch(Cursor & cur, FuncRequest & cmd)
                // reset the anchor.
                bvcur.setCursor(cur);
                bvcur.selection(true);
+               bvcur.setCurrentFont();
                if (cur.top() == old) {
                        // We didn't move one iota, so no need to update the screen.
                        cur.screenUpdateFlags(Update::SinglePar | Update::FitCursor);
@@ -1741,14 +1919,11 @@ void Text::dispatch(Cursor & cur, FuncRequest & cmd)
                // true (on).
 
                if (lyxrc.auto_region_delete && cur.selection())
-                       cutSelection(cur, false, false);
-
+                       cutSelection(cur, false);
                cur.clearSelection();
 
-               docstring::const_iterator cit = cmd.argument().begin();
-               docstring::const_iterator const end = cmd.argument().end();
-               for (; cit != end; ++cit)
-                       bv->translateAndInsert(*cit, this, cur);
+               for (char_type c : cmd.argument())
+                       bv->translateAndInsert(c, this, cur);
 
                cur.resetAnchor();
                moveCursor(cur, false);
@@ -1758,13 +1933,9 @@ void Text::dispatch(Cursor & cur, FuncRequest & cmd)
        }
 
        case LFUN_HREF_INSERT: {
-               // FIXME If we're actually given an argument, shouldn't
-               // we use it, whether or not we have a selection?
                docstring content = cmd.argument();
-               if (cur.selection()) {
+               if (content.empty() && cur.selection())
                        content = cur.selectionAsString(false);
-                       cutSelection(cur, true, false);
-               }
 
                InsetCommandParams p(HYPERLINK_CODE);
                if (!content.empty()){
@@ -1829,7 +2000,7 @@ void Text::dispatch(Cursor & cur, FuncRequest & cmd)
                if (cmd.argument().empty() && cur.selection()) {
                        // if command argument is empty use current selection as parameter.
                        docstring ds = cur.selectionAsString(false);
-                       cutSelection(cur, true, false);
+                       cutSelection(cur, false);
                        FuncRequest cmd0(cmd, ds);
                        inset = createInset(cur.buffer(), cmd0);
                } else {
@@ -1839,6 +2010,7 @@ void Text::dispatch(Cursor & cur, FuncRequest & cmd)
                        break;
                cur.recordUndo();
                insertInset(cur, inset);
+               cur.forceBufferUpdate();
                cur.posForward();
                break;
        }
@@ -1880,8 +2052,8 @@ void Text::dispatch(Cursor & cur, FuncRequest & cmd)
                        if (arg.autoinsert) {
                                // The cursor might have been invalidated by the replaceSelection.
                                cur.buffer()->changed(true);
-                               FuncRequest cmd(LFUN_ARGUMENT_INSERT, (*lait).first);
-                               lyx::dispatch(cmd);
+                               FuncRequest cmd2(LFUN_ARGUMENT_INSERT, (*lait).first);
+                               lyx::dispatch(cmd2);
                                autoargs = true;
                        }
                }
@@ -1960,9 +2132,11 @@ void Text::dispatch(Cursor & cur, FuncRequest & cmd)
 
        case LFUN_NOMENCL_INSERT: {
                InsetCommandParams p(NOMENCL_CODE);
-               if (cmd.argument().empty())
-                       p["symbol"] = bv->cursor().innerText()->getStringToIndex(bv->cursor());
-               else
+               if (cmd.argument().empty()) {
+                       p["symbol"] = 
+                               bv->cursor().innerText()->getStringForDialog(bv->cursor());
+                       cur.clearSelection();
+               } else
                        p["symbol"] = cmd.argument();
                string const data = InsetCommand::params2string(p);
                bv->showDialog("nomenclature", data);
@@ -2015,7 +2189,7 @@ void Text::dispatch(Cursor & cur, FuncRequest & cmd)
                        // don't pass "on" as argument
                        // (it would appear literally in the first cell)
                        docstring sel = cur.selectionAsString(false);
-                       MathMacroTemplate * macro = new MathMacroTemplate(cur.buffer());
+                       InsetMathMacroTemplate * macro = new InsetMathMacroTemplate(cur.buffer());
                        // create a macro template if we see "\\newcommand" somewhere, and
                        // an ordinary formula otherwise
                        if (!sel.empty()
@@ -2051,7 +2225,7 @@ void Text::dispatch(Cursor & cur, FuncRequest & cmd)
                        MacroType type = MacroTypeNewcommand;
                        if (s2 == "def")
                                type = MacroTypeDef;
-                       MathMacroTemplate * inset = new MathMacroTemplate(cur.buffer(),
+                       InsetMathMacroTemplate * inset = new InsetMathMacroTemplate(cur.buffer(),
                                from_utf8(token(s, ' ', 0)), nargs, false, type);
                        inset->setBuffer(bv->buffer());
                        insertInset(cur, inset);
@@ -2139,6 +2313,13 @@ void Text::dispatch(Cursor & cur, FuncRequest & cmd)
                break;
        }
 
+       case LFUN_FONT_CROSSOUT: {
+               Font font(ignore_font, ignore_language);
+               font.fontInfo().setXout(FONT_TOGGLE);
+               toggleAndShow(cur, this, font);
+               break;
+       }
+
        case LFUN_FONT_UNDERUNDERLINE: {
                Font font(ignore_font, ignore_language);
                font.fontInfo().setUuline(FONT_TOGGLE);
@@ -2288,7 +2469,7 @@ void Text::dispatch(Cursor & cur, FuncRequest & cmd)
                if (tclass.floats().typeExist(to_utf8(cmd.argument()))) {
                        cur.recordUndo();
                        if (cur.selection())
-                               cutSelection(cur, true, false);
+                               cutSelection(cur, false);
                        breakParagraph(cur);
 
                        if (cur.lastpos() != 0) {
@@ -2446,27 +2627,27 @@ void Text::dispatch(Cursor & cur, FuncRequest & cmd)
                break;
 
        case LFUN_OUTLINE_UP:
-               outline(OutlineUp, cur);
+               outline(OutlineUp, cur, this);
                setCursor(cur, cur.pit(), 0);
                cur.forceBufferUpdate();
                needsUpdate = true;
                break;
 
        case LFUN_OUTLINE_DOWN:
-               outline(OutlineDown, cur);
+               outline(OutlineDown, cur, this);
                setCursor(cur, cur.pit(), 0);
                cur.forceBufferUpdate();
                needsUpdate = true;
                break;
 
        case LFUN_OUTLINE_IN:
-               outline(OutlineIn, cur);
+               outline(OutlineIn, cur, this);
                cur.forceBufferUpdate();
                needsUpdate = true;
                break;
 
        case LFUN_OUTLINE_OUT:
-               outline(OutlineOut, cur);
+               outline(OutlineOut, cur, this);
                cur.forceBufferUpdate();
                needsUpdate = true;
                break;
@@ -2731,11 +2912,6 @@ bool Text::getStatus(Cursor & cur, FuncRequest const & cmd,
        }
        case LFUN_NOTE_INSERT:
                code = NOTE_CODE;
-               // in commands (sections etc.) and description items,
-               // only Notes are allowed
-               enable = (cmd.argument().empty() || cmd.getArg(0) == "Note" ||
-                         (!cur.paragraph().layout().isCommand()
-                          && !inDescriptionItem(cur)));
                break;
        case LFUN_FLEX_INSERT: {
                code = FLEX_CODE;
@@ -2805,19 +2981,13 @@ bool Text::getStatus(Cursor & cur, FuncRequest const & cmd,
                        for (; pit <= lastpit; ++pit) {
                                if (pars_[pit].layout() != lay)
                                        break;
-                               InsetList::const_iterator it = pars_[pit].insetList().begin();
-                               InsetList::const_iterator end = pars_[pit].insetList().end();
-                               for (; it != end; ++it) {
-                                       if (it->inset->lyxCode() == ARG_CODE) {
-                                               InsetArgument const * ins =
-                                                       static_cast<InsetArgument const *>(it->inset);
+                               for (auto const & table : pars_[pit].insetList())
+                                       if (InsetArgument const * ins = table.inset->asInsetArgument())
                                                if (ins->name() == arg) {
                                                        // we have this already
                                                        enable = false;
                                                        break;
                                                }
-                                       }
-                               }
                        }
                } else
                        enable = false;
@@ -2861,6 +3031,7 @@ bool Text::getStatus(Cursor & cur, FuncRequest const & cmd,
        case LFUN_QUOTE_INSERT:
                // always allow this, since we will inset a raw quote
                // if an inset is not allowed.
+               allow_in_passthru = true;
                break;
        case LFUN_SPECIALCHAR_INSERT:
                code = SPECIALCHAR_CODE;
@@ -3024,17 +3195,31 @@ bool Text::getStatus(Cursor & cur, FuncRequest const & cmd,
 
        case LFUN_CHANGE_ACCEPT:
        case LFUN_CHANGE_REJECT:
-               // In principle, these LFUNs should only be enabled if there
-               // is a change at the current position/in the current selection.
-               // However, without proper optimizations, this will inevitably
-               // result in unacceptable performance - just imagine a user who
-               // wants to select the complete content of a long document.
                if (!cur.selection())
                        enable = cur.paragraph().isChanged(cur.pos());
-               else
-                       // TODO: context-sensitive enabling of LFUN_CHANGE_ACCEPT/REJECT
-                       // for selections.
-                       enable = true;
+               else {
+                       // will enable if there is a change in the selection
+                       enable = false;
+
+                       // cheap improvement for efficiency: using cached
+                       // buffer variable, if there is no change in the
+                       // document, no need to check further.
+                       if (!cur.buffer()->areChangesPresent())
+                               break;
+
+                       for (DocIterator it = cur.selectionBegin(); it < cur.selectionEnd(); it.forwardPar()) {
+                               pos_type const beg = it.pos();
+                               pos_type end;
+                               if (it.paragraph().id() == cur.selectionEnd().paragraph().id())
+                                       end = cur.selectionEnd().pos();
+                               else
+                                       end = it.paragraph().size();
+                               if (beg != end && it.paragraph().isChanged(beg, end)) {
+                                       enable = true;
+                                       break;
+                               }
+                       }
+               }
                break;
 
        case LFUN_OUTLINE_UP:
@@ -3062,7 +3247,7 @@ bool Text::getStatus(Cursor & cur, FuncRequest const & cmd,
                enable = cur.paragraph().isPassThru();
                break;
 
-       case LFUN_SET_GRAPHICS_GROUP: {
+       case LFUN_GRAPHICS_SET_GROUP: {
                InsetGraphics * ins = graphics::getCurrentGraphicsInset(cur);
                if (!ins)
                        enable = false;
@@ -3104,14 +3289,14 @@ bool Text::getStatus(Cursor & cur, FuncRequest const & cmd,
                }
                break;
 
-       case LFUN_LAYOUT: {
-               DocumentClass const & tclass = cur.buffer()->params().documentClass();
-               docstring layout = cmd.argument();
-               if (layout.empty())
-                       layout = tclass.defaultLayoutName();
-               enable = !cur.inset().forcePlainLayout() && tclass.hasLayout(layout);
+       case LFUN_LAYOUT:
+       case LFUN_LAYOUT_TOGGLE: {
+               bool const ignoreautonests = cmd.getArg(1) == "ignoreautonests";
+               docstring const req_layout = ignoreautonests ? from_utf8(cmd.getArg(0)) : cmd.argument();
+               docstring const layout = resolveLayout(req_layout, cur);
 
-               flag.setOnOff(layout == cur.paragraph().layout().name());
+               enable = !owner_->forcePlainLayout() && !layout.empty();
+               flag.setOnOff(isAlreadyLayout(layout, cur));
                break;
        }
 
@@ -3133,8 +3318,22 @@ bool Text::getStatus(Cursor & cur, FuncRequest const & cmd,
                        enable = res;
                        break;
                }
+               else if (cmd.argument() == "previous") {
+                       // look if we have an environment in the previous par
+                       pit_type pit = cur.pit();
+                       Paragraph cpar = pars_[pit];
+                       if (pit > 0) {
+                               --pit;
+                               cpar = pars_[pit];
+                               enable = cpar.layout().isEnvironment();
+                               break;
+                       }
+                       enable = false;
+                       break;
+               }
                else if (cur.paragraph().layout().isEnvironment()) {
-                       enable = true;
+                       enable = cmd.argument() == "before"
+                               || cur.pos() > 0 || !isFirstInSequence(cur.pit());
                        break;
                }
                enable = false;
@@ -3145,7 +3344,7 @@ bool Text::getStatus(Cursor & cur, FuncRequest const & cmd,
        case LFUN_PARAGRAPH_PARAMS:
        case LFUN_PARAGRAPH_PARAMS_APPLY:
        case LFUN_PARAGRAPH_UPDATE:
-               enable = cur.inset().allowParagraphCustomization();
+               enable = owner_->allowParagraphCustomization();
                break;
 
        // FIXME: why are accent lfuns forbidden with pass_thru layouts?
@@ -3175,6 +3374,7 @@ bool Text::getStatus(Cursor & cur, FuncRequest const & cmd,
        case LFUN_FONT_STATE:
        case LFUN_FONT_UNDERLINE:
        case LFUN_FONT_STRIKEOUT:
+       case LFUN_FONT_CROSSOUT:
        case LFUN_FONT_UNDERUNDERLINE:
        case LFUN_FONT_UNDERWAVE:
        case LFUN_TEXTSTYLE_APPLY: