]> git.lyx.org Git - lyx.git/blobdiff - src/Text3.cpp
Keep dialog connected to cross-ref inset after Apply.
[lyx.git] / src / Text3.cpp
index f234c7cb7d027c95fd979b3cd281c0709092493a..25bc7ec24986d095d6237d5b1ebbb5cfb84383e9 100644 (file)
 #include "Text.h"
 
 #include "BranchList.h"
-#include "FloatList.h"
-#include "FuncStatus.h"
 #include "Buffer.h"
-#include "buffer_funcs.h"
 #include "BufferParams.h"
 #include "BufferView.h"
-#include "Changes.h"
 #include "Cursor.h"
 #include "CutAndPaste.h"
 #include "DispatchResult.h"
-#include "ErrorList.h"
 #include "factory.h"
+#include "FloatList.h"
+#include "FuncStatus.h"
 #include "FuncRequest.h"
 #include "InsetList.h"
 #include "Intl.h"
 #include "support/lassert.h"
 #include "support/limited_stack.h"
 #include "support/lstrings.h"
-#include "support/lyxalgo.h"
-#include "support/lyxtime.h"
-#include "support/os.h"
-#include "support/regex.h"
 
 #include "mathed/InsetMathHull.h"
 #include "mathed/InsetMathMacroTemplate.h"
 #include "lyxfind.h"
 
 #include <clocale>
+#include <regex>
 #include <sstream>
 
 using namespace std;
@@ -293,11 +287,22 @@ static bool doInsertInset(Cursor & cur, Text * text,
        }
 
        bool gotsel = false;
+       bool move_layout = false;
        if (cur.selection()) {
                if (cmd.action() == LFUN_INDEX_INSERT)
                        copySelectionToTemp(cur);
-               else
+               else {
                        cutSelectionToTemp(cur, pastesel);
+                       /* Move layout information inside the inset if the whole
+                        * paragraph and the inset allows setting layout
+                        * FIXME: this does not work as expected when change tracking is on
+                        *   However, we do not really know what to do in this case.
+                        */
+                       if (cur.paragraph().empty() && !inset->forcePlainLayout()) {
+                               cur.paragraph().setPlainOrDefaultLayout(bparams.documentClass());
+                               move_layout = true;
+                       }
+               }
                cur.clearSelection();
                gotsel = true;
        } else if (cmd.action() == LFUN_INDEX_INSERT) {
@@ -320,24 +325,22 @@ static bool doInsertInset(Cursor & cur, Text * text,
        InsetText * inset_text = inset->asInsetText();
        if (inset_text) {
                inset_text->fixParagraphsFont();
-               if (!inset_text->allowMultiPar() || cur.lastpit() == 0) {
-                       // reset first par to default
-                       cur.text()->paragraphs().begin()
-                               ->setPlainOrDefaultLayout(bparams.documentClass());
-                       cur.pos() = 0;
-                       cur.pit() = 0;
-                       // Merge multiple paragraphs -- hack
-                       while (cur.lastpit() > 0)
-                               mergeParagraph(bparams, cur.text()->paragraphs(), 0);
-                       if (cmd.action() == LFUN_FLEX_INSERT)
-                               return true;
-                       Cursor old = cur;
-                       cur.leaveInset(*inset);
-                       if (cmd.action() == LFUN_PREVIEW_INSERT
-                           || cmd.action() == LFUN_IPA_INSERT)
-                               // trigger preview
-                               notifyCursorLeavesOrEnters(old, cur);
-               }
+               cur.pos() = 0;
+               cur.pit() = 0;
+               /* If the containing paragraph has kept its layout, reset the
+                * layout of the first paragraph of the inset.
+                */
+               if (!move_layout)
+                       cur.paragraph().setPlainOrDefaultLayout(bparams.documentClass());
+               // FIXME: what does this do?
+               if (cmd.action() == LFUN_FLEX_INSERT)
+                       return true;
+               Cursor old = cur;
+               cur.leaveInset(*inset);
+               if (cmd.action() == LFUN_PREVIEW_INSERT
+                       || cmd.action() == LFUN_IPA_INSERT)
+                       // trigger preview
+                       notifyCursorLeavesOrEnters(old, cur);
        } else {
                cur.leaveInset(*inset);
                // reset surrounding par to default
@@ -360,7 +363,7 @@ enum OutlineOp {
 };
 
 
-static void insertSeparator(Cursor & cur, depth_type const depth)
+static void insertSeparator(Cursor const & cur, depth_type const depth)
 {
        Buffer & buf = *cur.buffer();
        lyx::dispatch(FuncRequest(LFUN_PARAGRAPH_BREAK));
@@ -383,7 +386,7 @@ static void outline(OutlineOp mode, Cursor & cur, Text * text)
        ParagraphList & pars = buf.text().paragraphs();
        ParagraphList::iterator const bgn = pars.begin();
        // The first paragraph of the area to be copied:
-       ParagraphList::iterator start = lyx::next(bgn, pit);
+       ParagraphList::iterator start = pars.iterator_at(pit);
        // The final paragraph of area to be copied:
        ParagraphList::iterator finish = start;
        ParagraphList::iterator const end = pars.end();
@@ -534,16 +537,14 @@ static void outline(OutlineOp mode, Cursor & cur, Text * text)
                                        continue;
 
                                DocumentClass const & tc = buf.params().documentClass();
-                               DocumentClass::const_iterator lit = tc.begin();
-                               DocumentClass::const_iterator len = tc.end();
                                int const newtoclevel =
                                        (mode == OutlineIn ? toclevel + 1 : toclevel - 1);
                                LabelType const oldlabeltype = start->layout().labeltype;
 
-                               for (; lit != len; ++lit) {
-                                       if (lit->toclevel ==  newtoclevel &&
-                                            lit->labeltype == oldlabeltype) {
-                                               start->setLayout(*lit);
+                               for (auto const & lay : tc) {
+                                       if (lay.toclevel ==  newtoclevel &&
+                                                lay.labeltype == oldlabeltype) {
+                                               start->setLayout(lay);
                                                break;
                                        }
                                }
@@ -580,7 +581,6 @@ Language const * getLanguage(Cursor const & cur, string const & lang)
 docstring resolveLayout(docstring layout, DocIterator const & dit)
 {
        Paragraph const & par = dit.paragraph();
-       docstring const old_layout = par.layout().name();
        DocumentClass const & tclass = dit.buffer()->params().documentClass();
 
        if (layout.empty())
@@ -673,7 +673,6 @@ void Text::dispatch(Cursor & cur, FuncRequest & cmd)
        case LFUN_PARAGRAPH_MOVE_DOWN: {
                pit_type const pit = cur.pit();
                cur.recordUndo(pit, pit + 1);
-               cur.finishUndo();
                pars_.swap(pit, pit + 1);
                needsUpdate = true;
                cur.forceBufferUpdate();
@@ -965,7 +964,7 @@ void Text::dispatch(Cursor & cur, FuncRequest & cmd)
                ParagraphList & pars = buf.text().paragraphs();
                ParagraphList::iterator bgn = pars.begin();
                // The first paragraph of the area to be selected:
-               ParagraphList::iterator start = lyx::next(bgn, pit);
+               ParagraphList::iterator start = pars.iterator_at(pit);
                // The final paragraph of area to be selected:
                ParagraphList::iterator finish = start;
                ParagraphList::iterator end = pars.end();
@@ -1109,7 +1108,7 @@ void Text::dispatch(Cursor & cur, FuncRequest & cmd)
 
        case LFUN_NEWLINE_INSERT: {
                InsetNewlineParams inp;
-               docstring arg = cmd.argument();
+               docstring const & arg = cmd.argument();
                if (arg == "linebreak")
                        inp.kind = InsetNewlineParams::LINEBREAK;
                else
@@ -1221,6 +1220,7 @@ void Text::dispatch(Cursor & cur, FuncRequest & cmd)
                        cur.resetAnchor();
                } else {
                        cutSelection(cur, false);
+                       cur.setCurrentFont();
                        singleParUpdate = false;
                }
                moveCursor(cur, false);
@@ -1250,7 +1250,14 @@ void Text::dispatch(Cursor & cur, FuncRequest & cmd)
                                }
                        }
                } else {
+                       DocIterator const dit = cur.selectionBegin();
                        cutSelection(cur, false);
+                       if (cur.buffer()->params().track_changes)
+                               // since we're doing backwards deletion,
+                               // and the selection is not really cut,
+                               // move cursor before selection (#11630)
+                               cur.setCursor(dit);
+                       cur.setCurrentFont();
                        singleParUpdate = false;
                }
                break;
@@ -1263,7 +1270,7 @@ void Text::dispatch(Cursor & cur, FuncRequest & cmd)
                Paragraph const & nextpar = lastpar ? par : pars_[pit + 1];
                pit_type prev = pit > 0 ? depthHook(pit, par.getDepth()) : pit;
                if (prev < pit && cur.pos() == par.beginOfBody()
-                   && !par.size() && !par.isEnvSeparator(cur.pos())
+                   && par.empty() && !par.isEnvSeparator(cur.pos())
                    && !par.layout().keepempty
                    && !par.layout().isCommand()
                    && pars_[prev].layout() != par.layout()
@@ -1363,6 +1370,14 @@ void Text::dispatch(Cursor & cur, FuncRequest & cmd)
                break;
        }
 
+       case LFUN_INSET_SPLIT: {
+               if (splitInset(cur)) {
+                       needsUpdate = true;
+                       cur.forceBufferUpdate();
+               }
+               break;
+       }
+
        case LFUN_GRAPHICS_SET_GROUP: {
                InsetGraphics * ins = graphics::getCurrentGraphicsInset(cur);
                if (!ins)
@@ -1522,6 +1537,7 @@ void Text::dispatch(Cursor & cur, FuncRequest & cmd)
                }
 
                bv->buffer().errors("Paste");
+               bv->buffer().updatePreviews(); // bug 11619
                cur.clearSelection(); // bug 393
                cur.finishUndo();
                break;
@@ -1532,11 +1548,6 @@ void Text::dispatch(Cursor & cur, FuncRequest & cmd)
                cur.message(_("Cut"));
                break;
 
-       case LFUN_COPY:
-               copySelection(cur);
-               cur.message(_("Copy"));
-               break;
-
        case LFUN_SERVER_GET_XY:
                cur.message(from_utf8(
                        convert<string>(tm->cursorX(cur.top(), cur.boundary()))
@@ -1584,8 +1595,13 @@ void Text::dispatch(Cursor & cur, FuncRequest & cmd)
                if (change_layout) {
                        setLayout(cur, layout);
                        if (cur.pit() > 0 && !ignoreautonests) {
+                               pit_type prev_pit = cur.pit() - 1;
+                               depth_type const cur_depth = pars_[cur.pit()].getDepth();
+                               // Scan for the previous par on same nesting level
+                               while (prev_pit > 0 && pars_[prev_pit].getDepth() > cur_depth)
+                                       --prev_pit;
                                set<docstring> const & autonests =
-                                               pars_[cur.pit() - 1].layout().autonests();
+                                               pars_[prev_pit].layout().autonests();
                                set<docstring> const & autonested =
                                                pars_[cur.pit()].layout().isAutonestedBy();
                                if (autonests.find(layout) != autonests.end()
@@ -1604,7 +1620,6 @@ void Text::dispatch(Cursor & cur, FuncRequest & cmd)
                                if (inautoarg) {
                                        cur.leaveInset(cur.inset());
                                        cur.posForward();
-                                       inautoarg = false;
                                }
                                FuncRequest const cmd2(LFUN_ARGUMENT_INSERT, la_pair.first);
                                lyx::dispatch(cmd2);
@@ -1625,7 +1640,7 @@ void Text::dispatch(Cursor & cur, FuncRequest & cmd)
                if (para.layout().isEnvironment())
                        layout = para.layout().name();
                depth_type split_depth = cur.paragraph().params().depth();
-               depth_type nextpar_depth = 0;
+               vector<depth_type> nextpars_depth;
                if (outer || previous) {
                        // check if we have an environment in our scope
                        pit_type pit = cur.pit();
@@ -1650,9 +1665,20 @@ void Text::dispatch(Cursor & cur, FuncRequest & cmd)
                        }
                }
                if ((outer || normal) && cur.pit() < cur.lastpit()) {
-                       // save nesting of following paragraph
-                       Paragraph cpar = pars_[cur.pit() + 1];
-                       nextpar_depth = cpar.params().depth();
+                       // save nesting of following paragraphs if they are deeper
+                       // or same depth
+                       pit_type offset = 1;
+                       depth_type cur_depth = pars_[cur.pit()].params().depth();
+                       while (cur.pit() + offset <= cur.lastpit()) {
+                               Paragraph cpar = pars_[cur.pit() + offset];
+                               depth_type nextpar_depth = cpar.params().depth();
+                               if (cur_depth <= nextpar_depth && nextpar_depth > 0) {
+                                       nextpars_depth.push_back(nextpar_depth);
+                                       cur_depth = nextpar_depth;
+                                       ++offset;
+                               } else
+                                       break;
+                       }
                }
                if (before)
                        cur.top().setPitPos(cur.pit(), 0);
@@ -1680,17 +1706,20 @@ void Text::dispatch(Cursor & cur, FuncRequest & cmd)
                else
                        lyx::dispatch(FuncRequest(LFUN_PARAGRAPH_BREAK, "inverse"));
                lyx::dispatch(FuncRequest(LFUN_LAYOUT, layout));
-               if ((outer || normal) && nextpar_depth > 0) {
-                       // restore nesting of following paragraph
+               if ((outer || normal) && !nextpars_depth.empty()) {
+                       // restore nesting of following paragraphs
                        DocIterator scur = cur;
-                       depth_type const max_depth = cur.paragraph().params().depth() + 1;
-                       cur.forwardPar();
-                       while (cur.paragraph().params().depth() < min(nextpar_depth, max_depth)) {
-                               depth_type const olddepth = cur.paragraph().params().depth();
-                               lyx::dispatch(FuncRequest(LFUN_DEPTH_INCREMENT));
-                               if (olddepth == cur.paragraph().params().depth())
-                                       // leave loop if no incrementation happens
-                                       break;
+                       depth_type max_depth = cur.paragraph().params().depth() + 1;
+                       for (auto nextpar_depth : nextpars_depth) {
+                               cur.forwardPar();
+                               while (cur.paragraph().params().depth() < min(nextpar_depth, max_depth)) {
+                                       depth_type const olddepth = cur.paragraph().params().depth();
+                                       lyx::dispatch(FuncRequest(LFUN_DEPTH_INCREMENT));
+                                       if (olddepth == cur.paragraph().params().depth())
+                                               // leave loop if no incrementation happens
+                                               break;
+                               }
+                               max_depth = cur.paragraph().params().depth() + 1;
                        }
                        cur.setCursor(scur);
                }
@@ -1769,8 +1798,8 @@ void Text::dispatch(Cursor & cur, FuncRequest & cmd)
                                }
                        }
                }
-               InsetQuotesParams::QuoteLevel const quote_level = inner
-                               ? InsetQuotesParams::SecondaryQuotes : InsetQuotesParams::PrimaryQuotes;
+               QuoteLevel const quote_level = inner
+                               ? QuoteLevel::Secondary : QuoteLevel::Primary;
                cur.insert(new InsetQuotes(cur.buffer(), c, quote_level, cmd.getArg(1), cmd.getArg(2)));
                cur.buffer()->updateBuffer();
                cur.posForward();
@@ -1941,8 +1970,10 @@ void Text::dispatch(Cursor & cur, FuncRequest & cmd)
                // "auto_region_delete", which defaults to
                // true (on).
 
-               if (lyxrc.auto_region_delete && cur.selection())
+               if (lyxrc.auto_region_delete && cur.selection()) {
                        cutSelection(cur, false);
+                       cur.setCurrentFont();
+               }
                cur.clearSelection();
 
                for (char_type c : cmd.argument())
@@ -2072,12 +2103,10 @@ void Text::dispatch(Cursor & cur, FuncRequest & cmd)
                bool const sel = cur.selection();
                doInsertInset(cur, this, cmd, true, true);
                // Insert auto-insert arguments
-               bool autoargs, inautoarg = false;
+               bool autoargs = false, inautoarg = false;
                Layout::LaTeXArgMap args = cur.inset().getLayout().args();
-               Layout::LaTeXArgMap::const_iterator lait = args.begin();
-               Layout::LaTeXArgMap::const_iterator const laend = args.end();
-               for (; lait != laend; ++lait) {
-                       Layout::latexarg arg = (*lait).second;
+               for (auto const & argt : args) {
+                       Layout::latexarg arg = argt.second;
                        if (!inautoarg && arg.insertonnewline && cur.pos() > 0) {
                                FuncRequest cmd2(LFUN_PARAGRAPH_BREAK);
                                lyx::dispatch(cmd2);
@@ -2090,13 +2119,12 @@ void Text::dispatch(Cursor & cur, FuncRequest & cmd)
                                if (inautoarg) {
                                        cur.leaveInset(cur.inset());
                                        cur.posForward();
-                                       inautoarg = false;
                                        if (arg.insertonnewline && cur.pos() > 0) {
                                                FuncRequest cmd2(LFUN_PARAGRAPH_BREAK);
                                                lyx::dispatch(cmd2);
                                        }
                                }
-                               FuncRequest cmd2(LFUN_ARGUMENT_INSERT, (*lait).first);
+                               FuncRequest cmd2(LFUN_ARGUMENT_INSERT, argt.first);
                                lyx::dispatch(cmd2);
                                autoargs = true;
                                inautoarg = true;
@@ -2132,7 +2160,6 @@ void Text::dispatch(Cursor & cur, FuncRequest & cmd)
                                // Unknown style. Report and fall back to default.
                                cur.errorMessage(from_utf8(N_("Table Style ")) + from_utf8(tabstyle) +
                                                     from_utf8(N_(" not known")));
-                       
                }
                if (doInsertInset(cur, this, cmd, false, true))
                        cur.posForward();
@@ -2148,7 +2175,7 @@ void Text::dispatch(Cursor & cur, FuncRequest & cmd)
                        break;
                int const r = convert<int>(rows);
                int const c = convert<int>(cols);
-                       
+
                string suffix;
                if (r == 1)
                        suffix = "_1x1";
@@ -2242,7 +2269,7 @@ void Text::dispatch(Cursor & cur, FuncRequest & cmd)
        case LFUN_NOMENCL_INSERT: {
                InsetCommandParams p(NOMENCL_CODE);
                if (cmd.argument().empty()) {
-                       p["symbol"] = 
+                       p["symbol"] =
                                bv->cursor().innerText()->getStringForDialog(bv->cursor());
                        cur.clearSelection();
                } else
@@ -2759,19 +2786,23 @@ void Text::dispatch(Cursor & cur, FuncRequest & cmd)
                }
                break;
 
-       case LFUN_OUTLINE_UP:
+       case LFUN_OUTLINE_UP: {
+               pos_type const opos = cur.pos();
                outline(OutlineUp, cur, this);
-               setCursor(cur, cur.pit(), 0);
+               setCursor(cur, cur.pit(), opos);
                cur.forceBufferUpdate();
                needsUpdate = true;
                break;
+       }
 
-       case LFUN_OUTLINE_DOWN:
+       case LFUN_OUTLINE_DOWN: {
+               pos_type const opos = cur.pos();
                outline(OutlineDown, cur, this);
-               setCursor(cur, cur.pit(), 0);
+               setCursor(cur, cur.pit(), opos);
                cur.forceBufferUpdate();
                needsUpdate = true;
                break;
+       }
 
        case LFUN_OUTLINE_IN:
                outline(OutlineIn, cur, this);
@@ -2875,7 +2906,7 @@ void Text::dispatch(Cursor & cur, FuncRequest & cmd)
 
 
 bool Text::getStatus(Cursor & cur, FuncRequest const & cmd,
-                       FuncStatus & flag) const
+                       FuncStatus & status) const
 {
        LBUFERR(this == cur.text());
 
@@ -2883,7 +2914,7 @@ bool Text::getStatus(Cursor & cur, FuncRequest const & cmd,
        bool enable = true;
        bool allow_in_passthru = false;
        InsetCode code = NO_CODE;
-       
+
        switch (cmd.action()) {
 
        case LFUN_DEPTH_DECREMENT:
@@ -2898,7 +2929,7 @@ bool Text::getStatus(Cursor & cur, FuncRequest const & cmd,
                // FIXME We really should not allow this to be put, e.g.,
                // in a footnote, or in ERT. But it would make sense in a
                // branch, so I'm not sure what to do.
-               flag.setOnOff(cur.paragraph().params().startOfAppendix());
+               status.setOnOff(cur.paragraph().params().startOfAppendix());
                break;
 
        case LFUN_DIALOG_SHOW_NEW_INSET:
@@ -3028,7 +3059,7 @@ bool Text::getStatus(Cursor & cur, FuncRequest const & cmd,
                        if (cit == floats.end() ||
                                        // and that we know how to generate a list of them
                            (!cit->second.usesFloatPkg() && cit->second.listCommand().empty())) {
-                               flag.setUnknown(true);
+                               status.setUnknown(true);
                                // probably not necessary, but...
                                enable = false;
                        }
@@ -3054,10 +3085,9 @@ bool Text::getStatus(Cursor & cur, FuncRequest const & cmd,
                string s = cmd.getArg(0);
                InsetLayout il =
                        cur.buffer()->params().documentClass().insetLayout(from_utf8(s));
-               if (il.lyxtype() != InsetLayout::CHARSTYLE &&
-                   il.lyxtype() != InsetLayout::CUSTOM &&
-                   il.lyxtype() != InsetLayout::ELEMENT &&
-                   il.lyxtype ()!= InsetLayout::STANDARD)
+               if (il.lyxtype() != InsetLyXType::CHARSTYLE &&
+                   il.lyxtype() != InsetLyXType::CUSTOM &&
+                   il.lyxtype ()!= InsetLyXType::STANDARD)
                        enable = false;
                break;
                }
@@ -3213,43 +3243,42 @@ bool Text::getStatus(Cursor & cur, FuncRequest const & cmd,
                break;
 
        case LFUN_FONT_EMPH:
-               flag.setOnOff(fontinfo.emph() == FONT_ON);
+               status.setOnOff(fontinfo.emph() == FONT_ON);
                enable = !cur.paragraph().isPassThru();
                break;
 
        case LFUN_FONT_ITAL:
-               flag.setOnOff(fontinfo.shape() == ITALIC_SHAPE);
+               status.setOnOff(fontinfo.shape() == ITALIC_SHAPE);
                enable = !cur.paragraph().isPassThru();
                break;
 
        case LFUN_FONT_NOUN:
-               flag.setOnOff(fontinfo.noun() == FONT_ON);
+               status.setOnOff(fontinfo.noun() == FONT_ON);
                enable = !cur.paragraph().isPassThru();
                break;
 
        case LFUN_FONT_BOLD:
        case LFUN_FONT_BOLDSYMBOL:
-               flag.setOnOff(fontinfo.series() == BOLD_SERIES);
+               status.setOnOff(fontinfo.series() == BOLD_SERIES);
                enable = !cur.paragraph().isPassThru();
                break;
 
        case LFUN_FONT_SANS:
-               flag.setOnOff(fontinfo.family() == SANS_FAMILY);
+               status.setOnOff(fontinfo.family() == SANS_FAMILY);
                enable = !cur.paragraph().isPassThru();
                break;
 
        case LFUN_FONT_ROMAN:
-               flag.setOnOff(fontinfo.family() == ROMAN_FAMILY);
+               status.setOnOff(fontinfo.family() == ROMAN_FAMILY);
                enable = !cur.paragraph().isPassThru();
                break;
 
        case LFUN_FONT_TYPEWRITER:
-               flag.setOnOff(fontinfo.family() == TYPEWRITER_FAMILY);
+               status.setOnOff(fontinfo.family() == TYPEWRITER_FAMILY);
                enable = !cur.paragraph().isPassThru();
                break;
 
        case LFUN_CUT:
-       case LFUN_COPY:
                enable = cur.selection();
                break;
 
@@ -3353,11 +3382,17 @@ bool Text::getStatus(Cursor & cur, FuncRequest const & cmd,
                                if (in_last_par)
                                        end = cur.selectionEnd().pos();
                                else
-                                       end = it.lastpos();
+                                       // the +1 is needed for cases, e.g., where there is a
+                                       // paragraph break. See #11629.
+                                       end = it.lastpos() + 1;
                                if (beg != end && it.paragraph().isChanged(beg, end)) {
                                        enable = true;
                                        break;
                                }
+                               if (beg != end && it.paragraph().hasChangedInsets(beg, end)) {
+                                       enable = true;
+                                       break;
+                               }
                                if (in_last_par)
                                        break;
                        }
@@ -3394,7 +3429,7 @@ bool Text::getStatus(Cursor & cur, FuncRequest const & cmd,
                if (!ins)
                        enable = false;
                else
-                       flag.setOnOff(to_utf8(cmd.argument()) == ins->getParams().groupId);
+                       status.setOnOff(to_utf8(cmd.argument()) == ins->getParams().groupId);
                break;
        }
 
@@ -3406,7 +3441,7 @@ bool Text::getStatus(Cursor & cur, FuncRequest const & cmd,
 
        case LFUN_LANGUAGE:
                enable = !cur.paragraph().isPassThru();
-               flag.setOnOff(cmd.getArg(0) == cur.real_current_font.language()->lang());
+               status.setOnOff(cmd.getArg(0) == cur.real_current_font.language()->lang());
                break;
 
        case LFUN_PARAGRAPH_BREAK:
@@ -3416,11 +3451,11 @@ bool Text::getStatus(Cursor & cur, FuncRequest const & cmd,
        case LFUN_SPELLING_ADD:
        case LFUN_SPELLING_IGNORE:
        case LFUN_SPELLING_REMOVE:
-               enable = theSpellChecker() != NULL;
+               enable = theSpellChecker() != nullptr;
                if (enable && !cmd.getArg(1).empty()) {
                        // validate explicitly given language
                        Language const * const lang = const_cast<Language *>(languages.getLanguage(cmd.getArg(1)));
-                       enable &= lang != NULL;
+                       enable &= lang != nullptr;
                }
                break;
 
@@ -3431,7 +3466,7 @@ bool Text::getStatus(Cursor & cur, FuncRequest const & cmd,
                docstring const layout = resolveLayout(req_layout, cur);
 
                enable = !owner_->forcePlainLayout() && !layout.empty();
-               flag.setOnOff(isAlreadyLayout(layout, cur));
+               status.setOnOff(isAlreadyLayout(layout, cur));
                break;
        }
 
@@ -3640,7 +3675,7 @@ bool Text::getStatus(Cursor & cur, FuncRequest const & cmd,
                || (cur.paragraph().layout().pass_thru && !allow_in_passthru)))
                enable = false;
 
-       flag.setEnabled(enable);
+       status.setEnabled(enable);
        return true;
 }
 
@@ -3659,9 +3694,9 @@ void Text::pasteString(Cursor & cur, docstring const & clip,
 
 
 // FIXME: an item inset would make things much easier.
-bool Text::inDescriptionItem(Cursor & cur) const
+bool Text::inDescriptionItem(Cursor const & cur) const
 {
-       Paragraph & par = cur.paragraph();
+       Paragraph const & par = cur.paragraph();
        pos_type const pos = cur.pos();
        pos_type const body_pos = par.beginOfBody();
 
@@ -3680,12 +3715,8 @@ std::vector<docstring> Text::getFreeFonts() const
 {
        vector<docstring> ffList;
 
-       FontStack::const_iterator cit = freeFonts.begin();
-       FontStack::const_iterator end = freeFonts.end();
-       for (; cit != end; ++cit)
-               // we do not use cit-> here because gcc 2.9x does not
-               // like it (JMarc)
-               ffList.push_back((*cit).first);
+       for (auto const & f : freeFonts)
+               ffList.push_back(f.first);
 
        return ffList;
 }