]> git.lyx.org Git - lyx.git/blobdiff - src/Text.cpp
I'll find a solution for the 'dirList problem', Abdel.
[lyx.git] / src / Text.cpp
index c6c1d1dc875536ebd27fa47c61feef20ca450f76..faeb92c4b40d355e6d77adfc55be8b82dd741bd4 100644 (file)
@@ -1,5 +1,5 @@
 /**
- * \file src/text.cpp
+ * \file src/Text.cpp
  * This file is part of LyX, the document processor.
  * Licence details can be found in the file COPYING.
  *
 #include "buffer_funcs.h"
 #include "BufferParams.h"
 #include "BufferView.h"
+#include "Changes.h"
 #include "Cursor.h"
 #include "ParIterator.h"
 #include "CutAndPaste.h"
-#include "debug.h"
 #include "DispatchResult.h"
 #include "Encoding.h"
 #include "ErrorList.h"
 #include "FuncRequest.h"
 #include "factory.h"
 #include "FontIterator.h"
-#include "gettext.h"
 #include "Language.h"
-#include "Color.h"
 #include "Length.h"
 #include "Lexer.h"
 #include "LyXRC.h"
 #include "Paragraph.h"
 #include "paragraph_funcs.h"
 #include "ParagraphParameters.h"
-#include "Undo.h"
+#include "TextClass.h"
 #include "TextMetrics.h"
 #include "VSpace.h"
 #include "WordLangTuple.h"
 #include "insets/InsetHFill.h"
 #include "insets/InsetLine.h"
 #include "insets/InsetNewline.h"
-#include "insets/InsetPagebreak.h"
+#include "insets/InsetNewpage.h"
 #include "insets/InsetOptArg.h"
 #include "insets/InsetSpace.h"
 #include "insets/InsetSpecialChar.h"
 #include "insets/InsetTabular.h"
 
+#include "support/convert.h"
+#include "support/debug.h"
+#include "support/docstream.h"
+#include "support/gettext.h"
 #include "support/lstrings.h"
 #include "support/textutils.h"
-#include "support/convert.h"
 
-#include <boost/current_function.hpp>
 #include <boost/next_prior.hpp>
 
 #include <sstream>
 
 using std::auto_ptr;
-using std::advance;
-using std::distance;
-using std::max;
-using std::min;
-using std::endl;
 using std::string;
 
 namespace lyx {
 
 using support::bformat;
 using support::contains;
-using support::lowercase;
 using support::split;
-using support::uppercase;
+using support::subst;
 
 using cap::cutSelection;
 using cap::pasteParagraphList;
@@ -102,22 +96,14 @@ void readParToken(Buffer const & buf, Paragraph & par, Lexer & lex,
        BufferParams const & bp = buf.params();
 
        if (token[0] != '\\') {
-#if 0
-               string::const_iterator cit = token.begin();
-               for (; cit != token.end(); ++cit)
-                       par.insertChar(par.size(), (*cit), font, change);
-#else
                docstring dstr = lex.getDocString();
-               docstring::const_iterator cit = dstr.begin();
-               docstring::const_iterator cend = dstr.end();
-               for (; cit != cend; ++cit)
-                       par.insertChar(par.size(), *cit, font, change);
-#endif
+               par.appendString(dstr, font, change);
+
        } else if (token == "\\begin_layout") {
                lex.eatLine();
                docstring layoutname = lex.getDocString();
 
-               font = Font(Font::ALL_INHERIT, bp.language);
+               font = Font(inherit_font, bp.language);
                change = Change(Change::UNCHANGED);
 
                TextClass const & tclass = bp.getTextClass();
@@ -145,15 +131,11 @@ void readParToken(Buffer const & buf, Paragraph & par, Lexer & lex,
                par.params().read(lex);
 
        } else if (token == "\\end_layout") {
-               lyxerr << BOOST_CURRENT_FUNCTION
-                      << ": Solitary \\end_layout in line "
-                      << lex.getLineNo() << "\n"
-                      << "Missing \\begin_layout?.\n";
+               LYXERR0("Solitary \\end_layout in line " << lex.getLineNo() << "\n"
+                      << "Missing \\begin_layout ?");
        } else if (token == "\\end_inset") {
-               lyxerr << BOOST_CURRENT_FUNCTION
-                      << ": Solitary \\end_inset in line "
-                      << lex.getLineNo() << "\n"
-                      << "Missing \\begin_inset?.\n";
+               LYXERR0("Solitary \\end_inset in line " << lex.getLineNo() << "\n"
+                      << "Missing \\begin_inset ?");
        } else if (token == "\\begin_inset") {
                Inset * inset = readInset(lex, buf);
                if (inset)
@@ -166,16 +148,16 @@ void readParToken(Buffer const & buf, Paragraph & par, Lexer & lex,
                }
        } else if (token == "\\family") {
                lex.next();
-               font.setLyXFamily(lex.getString());
+               setLyXFamily(lex.getString(), font.fontInfo());
        } else if (token == "\\series") {
                lex.next();
-               font.setLyXSeries(lex.getString());
+               setLyXSeries(lex.getString(), font.fontInfo());
        } else if (token == "\\shape") {
                lex.next();
-               font.setLyXShape(lex.getString());
+               setLyXShape(lex.getString(), font.fontInfo());
        } else if (token == "\\size") {
                lex.next();
-               font.setLyXSize(lex.getString());
+               setLyXSize(lex.getString(), font.fontInfo());
        } else if (token == "\\lang") {
                lex.next();
                string const tok = lex.getString();
@@ -188,40 +170,40 @@ void readParToken(Buffer const & buf, Paragraph & par, Lexer & lex,
                }
        } else if (token == "\\numeric") {
                lex.next();
-               font.setNumber(font.setLyXMisc(lex.getString()));
+               font.fontInfo().setNumber(font.setLyXMisc(lex.getString()));
        } else if (token == "\\emph") {
                lex.next();
-               font.setEmph(font.setLyXMisc(lex.getString()));
+               font.fontInfo().setEmph(font.setLyXMisc(lex.getString()));
        } else if (token == "\\bar") {
                lex.next();
                string const tok = lex.getString();
 
                if (tok == "under")
-                       font.setUnderbar(Font::ON);
+                       font.fontInfo().setUnderbar(FONT_ON);
                else if (tok == "no")
-                       font.setUnderbar(Font::OFF);
+                       font.fontInfo().setUnderbar(FONT_OFF);
                else if (tok == "default")
-                       font.setUnderbar(Font::INHERIT);
+                       font.fontInfo().setUnderbar(FONT_INHERIT);
                else
                        lex.printError("Unknown bar font flag "
                                       "`$$Token'");
        } else if (token == "\\noun") {
                lex.next();
-               font.setNoun(font.setLyXMisc(lex.getString()));
+               font.fontInfo().setNoun(font.setLyXMisc(lex.getString()));
        } else if (token == "\\color") {
                lex.next();
-               font.setLyXColor(lex.getString());
+               setLyXColor(lex.getString(), font.fontInfo());
        } else if (token == "\\InsetSpace" || token == "\\SpecialChar") {
 
                // Insets don't make sense in a free-spacing context! ---Kayvan
                if (par.isFreeSpacing()) {
                        if (token == "\\InsetSpace")
-                               par.insertChar(par.size(), ' ', font, change);
+                               par.appendChar(' ', font, change);
                        else if (lex.isOK()) {
                                lex.next();
                                string const next_token = lex.getString();
                                if (next_token == "\\-")
-                                       par.insertChar(par.size(), '-', font, change);
+                                       par.appendChar('-', font, change);
                                else {
                                        lex.printError("Token `$$Token' "
                                                       "is in free space "
@@ -239,7 +221,11 @@ void readParToken(Buffer const & buf, Paragraph & par, Lexer & lex,
                                        font, change);
                }
        } else if (token == "\\backslash") {
-               par.insertChar(par.size(), '\\', font, change);
+               par.appendChar('\\', font, change);
+       } else if (token == "\\linebreak") {
+               auto_ptr<Inset> inset(new InsetLinebreak);
+               inset->read(buf, lex);
+               par.insertInset(par.size(), inset.release(), font, change);
        } else if (token == "\\newline") {
                auto_ptr<Inset> inset(new InsetNewline);
                inset->read(buf, lex);
@@ -253,6 +239,8 @@ void readParToken(Buffer const & buf, Paragraph & par, Lexer & lex,
        } else if (token == "\\lyxline") {
                par.insertInset(par.size(), new InsetLine, font, change);
        } else if (token == "\\newpage") {
+               par.insertInset(par.size(), new InsetNewpage, font, change);
+       } else if (token == "\\pagebreak") {
                par.insertInset(par.size(), new InsetPagebreak, font, change);
        } else if (token == "\\clearpage") {
                par.insertInset(par.size(), new InsetClearPage, font, change);
@@ -264,7 +252,7 @@ void readParToken(Buffer const & buf, Paragraph & par, Lexer & lex,
                lex.eatLine();
                std::istringstream is(lex.getString());
                unsigned int aid;
-               time_type ct;
+               time_t ct;
                is >> aid >> ct;
                if (aid >= bp.author_map.size()) {
                        errorList.push_back(ErrorItem(_("Change tracking error"),
@@ -277,7 +265,7 @@ void readParToken(Buffer const & buf, Paragraph & par, Lexer & lex,
                lex.eatLine();
                std::istringstream is(lex.getString());
                unsigned int aid;
-               time_type ct;
+               time_t ct;
                is >> aid >> ct;
                if (aid >= bp.author_map.size()) {
                        errorList.push_back(ErrorItem(_("Change tracking error"),
@@ -318,8 +306,7 @@ void readParagraph(Buffer const & buf, Paragraph & par, Lexer & lex,
                        break;
                }
 
-               LYXERR(Debug::PARSER) << "Handling paragraph token: `"
-                                     << token << '\'' << endl;
+               LYXERR(Debug::PARSER, "Handling paragraph token: `" << token << '\'');
                if (token == "\\begin_layout" || token == "\\end_document"
                    || token == "\\end_inset" || token == "\\begin_deeper"
                    || token == "\\end_deeper") {
@@ -436,9 +423,8 @@ void Text::breakParagraph(Cursor & cur, bool inverse_logic)
 void Text::insertChar(Cursor & cur, char_type c)
 {
        BOOST_ASSERT(this == cur.text());
-       BOOST_ASSERT(c != Paragraph::META_INSET);
 
-       recordUndo(cur, Undo::INSERT);
+       cur.recordUndo(INSERT_UNDO);
 
        TextMetrics const & tm = cur.bv().textMetrics(this);
        Buffer const & buffer = cur.buffer();
@@ -454,13 +440,13 @@ void Text::insertChar(Cursor & cur, char_type c)
                static docstring const number_unary_operators = from_ascii("+-");
                static docstring const number_seperators = from_ascii(".,:");
 
-               if (cur.current_font.number() == Font::ON) {
+               if (cur.current_font.fontInfo().number() == FONT_ON) {
                        if (!isDigit(c) && !contains(number_operators, c) &&
                            !(contains(number_seperators, c) &&
                              cur.pos() != 0 &&
                              cur.pos() != cur.lastpos() &&
-                             tm.getDisplayFont(pit, cur.pos()).number() == Font::ON &&
-                             tm.getDisplayFont(pit, cur.pos() - 1).number() == Font::ON)
+                             tm.getDisplayFont(pit, cur.pos()).fontInfo().number() == FONT_ON &&
+                             tm.getDisplayFont(pit, cur.pos() - 1).fontInfo().number() == FONT_ON)
                           )
                                number(cur); // Set current_font.number to OFF
                } else if (isDigit(c) &&
@@ -478,7 +464,7 @@ void Text::insertChar(Cursor & cur, char_type c)
                                                tm.font_);
                                } else if (contains(number_seperators, c)
                                     && cur.pos() >= 2
-                                    && tm.getDisplayFont(pit, cur.pos() - 2).number() == Font::ON) {
+                                    && tm.getDisplayFont(pit, cur.pos() - 2).fontInfo().number() == FONT_ON) {
                                        setCharFont(buffer, pit, cur.pos() - 1, cur.current_font,
                                                tm.font_);
                                }
@@ -511,7 +497,7 @@ void Text::insertChar(Cursor & cur, char_type c)
        if ((cur.pos() >= 2) && (par.isLineSeparator(cur.pos() - 1))) {
                // get font in front and behind the space in question. But do NOT 
                // use getFont(cur.pos()) because the character c is not inserted yet
-               Font const pre_space_font  = tm.getDisplayFont(cur.pit(), cur.pos() - 2);
+               Font const pre_space_font  = tm.getDisplayFont(cur.pit(), cur.pos() - 2);
                Font const & post_space_font = cur.real_current_font;
                bool pre_space_rtl  = pre_space_font.isVisibleRightToLeft();
                bool post_space_rtl = post_space_font.isVisibleRightToLeft();
@@ -566,11 +552,11 @@ void Text::insertChar(Cursor & cur, char_type c)
 
 //             cur.updateFlags(Update::Force);
        setCursor(cur.top(), cur.pit(), cur.pos() + 1);
-       charInserted();
+       charInserted(cur);
 }
 
 
-void Text::charInserted()
+void Text::charInserted(Cursor & cur)
 {
        // Here we call finishUndo for every 20 characters inserted.
        // This is from my experience how emacs does it. (Lgb)
@@ -578,7 +564,7 @@ void Text::charInserted()
        if (counter < 20) {
                ++counter;
        } else {
-               finishUndo();
+               cur.finishUndo();
                counter = 0;
        }
 }
@@ -587,7 +573,7 @@ void Text::charInserted()
 // the cursor set functions have a special mechanism. When they
 // realize, that you left an empty paragraph, they will delete it.
 
-bool Text::cursorRightOneWord(Cursor & cur)
+bool Text::cursorForwardOneWord(Cursor & cur)
 {
        BOOST_ASSERT(this == cur.text());
 
@@ -608,7 +594,7 @@ bool Text::cursorRightOneWord(Cursor & cur)
 }
 
 
-bool Text::cursorLeftOneWord(Cursor & cur)
+bool Text::cursorBackwardOneWord(Cursor & cur)
 {
        BOOST_ASSERT(this == cur.text());
 
@@ -664,7 +650,7 @@ void Text::acceptOrRejectChanges(Cursor & cur, ChangeOp op)
        if (!cur.selection())
                return;
 
-       recordUndoSelection(cur, Undo::ATOMIC);
+       cur.recordUndoSelection();
 
        pit_type begPit = cur.selectionBegin().pit();
        pit_type endPit = cur.selectionEnd().pit();
@@ -753,7 +739,7 @@ void Text::acceptOrRejectChanges(Cursor & cur, ChangeOp op)
 
        //
 
-       finishUndo();
+       cur.finishUndo();
        cur.clearSelection();
        setCursorIntern(cur, begPit, begPos);
        cur.updateFlags(Update::Force);
@@ -807,11 +793,11 @@ void Text::deleteWordForward(Cursor & cur)
 {
        BOOST_ASSERT(this == cur.text());
        if (cur.lastpos() == 0)
-               cursorRight(cur);
+               cursorForward(cur);
        else {
                cur.resetAnchor();
                cur.selection() = true;
-               cursorRightOneWord(cur);
+               cursorForwardOneWord(cur);
                cur.setSelection();
                cutSelection(cur, true, false);
                checkBufferStructure(cur.buffer(), cur);
@@ -823,11 +809,11 @@ void Text::deleteWordBackward(Cursor & cur)
 {
        BOOST_ASSERT(this == cur.text());
        if (cur.lastpos() == 0)
-               cursorLeft(cur);
+               cursorBackward(cur);
        else {
                cur.resetAnchor();
                cur.selection() = true;
-               cursorLeftOneWord(cur);
+               cursorBackwardOneWord(cur);
                cur.setSelection();
                cutSelection(cur, true, false);
                checkBufferStructure(cur.buffer(), cur);
@@ -836,7 +822,7 @@ void Text::deleteWordBackward(Cursor & cur)
 
 
 // Kill to end of line.
-void Text::changeCase(Cursor & cur, Text::TextCase action)
+void Text::changeCase(Cursor & cur, TextCase action)
 {
        BOOST_ASSERT(this == cur.text());
        CursorSlice from;
@@ -848,10 +834,10 @@ void Text::changeCase(Cursor & cur, Text::TextCase action)
        } else {
                from = cur.top();
                getWord(from, to, PARTIAL_WORD);
-               cursorRightOneWord(cur);
+               cursorForwardOneWord(cur);
        }
 
-       recordUndoSelection(cur, Undo::ATOMIC);
+       cur.recordUndoSelection();
 
        pit_type begPit = from.pit();
        pit_type endPit = to.pit();
@@ -859,72 +845,13 @@ void Text::changeCase(Cursor & cur, Text::TextCase action)
        pos_type begPos = from.pos();
        pos_type endPos = to.pos();
 
-       bool const trackChanges = cur.buffer().params().trackChanges;
-
        pos_type right = 0; // needed after the for loop
 
        for (pit_type pit = begPit; pit <= endPit; ++pit) {
-               pos_type parSize = pars_[pit].size();
-
-               pos_type pos = (pit == begPit ? begPos : 0);
-               right = (pit == endPit ? endPos : parSize);
-
-               // process sequences of modified characters; in change
-               // tracking mode, this approach results in much better
-               // usability than changing case on a char-by-char basis
-               docstring changes;
-
-               bool capitalize = true;
-
-               for (; pos < right; ++pos) {
-                       char_type oldChar = pars_[pit].getChar(pos);
-                       char_type newChar = oldChar;
-
-                       // ignore insets and don't play with deleted text!
-                       if (oldChar != Paragraph::META_INSET && !pars_[pit].isDeleted(pos)) {
-                               switch (action) {
-                               case text_lowercase:
-                                       newChar = lowercase(oldChar);
-                                       break;
-                               case text_capitalization:
-                                       if (capitalize) {
-                                               newChar = uppercase(oldChar);
-                                               capitalize = false;
-                                       }
-                                       break;
-                               case text_uppercase:
-                                       newChar = uppercase(oldChar);
-                                       break;
-                               }
-                       }
-
-                       if (!pars_[pit].isLetter(pos) || pars_[pit].isDeleted(pos)) {
-                               capitalize = true; // permit capitalization again
-                       }
-
-                       if (oldChar != newChar) {
-                               changes += newChar;
-                       }
-
-                       if (oldChar == newChar || pos == right - 1) {
-                               if (oldChar != newChar) {
-                                       pos++; // step behind the changing area
-                               }
-                               int erasePos = pos - changes.size();
-                               for (size_t i = 0; i < changes.size(); i++) {
-                                       pars_[pit].insertChar(pos, changes[i],
-                                               pars_[pit].getFontSettings(cur.buffer().params(),
-                                                               erasePos),
-                                               trackChanges);
-                                       if (!pars_[pit].eraseChar(erasePos, trackChanges)) {
-                                               ++erasePos;
-                                               ++pos; // advance
-                                               ++right; // expand selection
-                                       }
-                               }
-                               changes.clear();
-                       }
-               }
+               Paragraph & par = pars_[pit];
+               pos_type const pos = (pit == begPit ? begPos : 0);
+               right = (pit == endPit ? endPos : par.size());
+               par.changeCase(cur.buffer().params(), pos, right, action);
        }
 
        // the selection may have changed due to logically-only deleted chars
@@ -953,7 +880,7 @@ bool Text::handleBibitems(Cursor & cur)
                }
                Paragraph const & prevpar = prevcur.paragraph();
                if (cur.pit() > 0 && par.layout() == prevpar.layout()) {
-                       recordUndo(cur, Undo::ATOMIC, prevcur.pit());
+                       cur.recordUndo(ATOMIC_UNDO, prevcur.pit());
                        mergeParagraph(bufparams, cur.text()->paragraphs(),
                                       prevcur.pit());
                        updateLabels(cur.buffer());
@@ -978,7 +905,7 @@ bool Text::erase(Cursor & cur)
        if (cur.pos() != cur.lastpos()) {
                // this is the code for a normal delete, not pasting
                // any paragraphs
-               recordUndo(cur, Undo::DELETE);
+               cur.recordUndo(DELETE_UNDO);
                if(!par.eraseChar(cur.pos(), cur.buffer().params().trackChanges)) {
                        // the character has been logically deleted only => skip it
                        cur.top().forwardPos();
@@ -1032,14 +959,14 @@ bool Text::backspacePos0(Cursor & cur)
        // is it an empty paragraph?
        if (cur.lastpos() == 0
            || (cur.lastpos() == 1 && par.isSeparator(0))) {
-               recordUndo(cur, Undo::ATOMIC, prevcur.pit(), cur.pit());
+               cur.recordUndo(ATOMIC_UNDO, prevcur.pit(), cur.pit());
                plist.erase(boost::next(plist.begin(), cur.pit()));
                needsUpdate = true;
        }
        // is previous par empty?
        else if (prevcur.lastpos() == 0
                 || (prevcur.lastpos() == 1 && prevpar.isSeparator(0))) {
-               recordUndo(cur, Undo::ATOMIC, prevcur.pit(), cur.pit());
+               cur.recordUndo(ATOMIC_UNDO, prevcur.pit(), cur.pit());
                plist.erase(boost::next(plist.begin(), prevcur.pit()));
                needsUpdate = true;
        }
@@ -1049,7 +976,7 @@ bool Text::backspacePos0(Cursor & cur)
        // Correction: Pasting is always allowed with standard-layout
        else if (par.layout() == prevpar.layout()
                 || par.layout() == tclass.defaultLayout()) {
-               recordUndo(cur, Undo::ATOMIC, prevcur.pit());
+               cur.recordUndo(ATOMIC_UNDO, prevcur.pit());
                mergeParagraph(bufparams, plist, prevcur.pit());
                needsUpdate = true;
        }
@@ -1085,10 +1012,10 @@ bool Text::backspace(Cursor & cur)
        } else {
                // this is the code for a normal backspace, not pasting
                // any paragraphs
-               recordUndo(cur, Undo::DELETE);
-               // We used to do cursorLeftIntern() here, but it is
+               cur.recordUndo(DELETE_UNDO);
+               // We used to do cursorBackwardIntern() here, but it is
                // not a good idea since it triggers the auto-delete
-               // mechanism. So we do a cursorLeftIntern()-lite,
+               // mechanism. So we do a cursorBackwardIntern()-lite,
                // without the dreaded mechanism. (JMarc)
                setCursorIntern(cur, cur.pit(), cur.pos() - 1,
                                false, cur.boundary());
@@ -1115,7 +1042,7 @@ bool Text::dissolveInset(Cursor & cur) {
        if (isMainText(cur.bv().buffer()) || cur.inset().nargs() != 1)
                return false;
 
-       recordUndoInset(cur);
+       cur.recordUndoInset();
        cur.selHandle(false);
        // save position
        pos_type spos = cur.pos();
@@ -1123,7 +1050,7 @@ bool Text::dissolveInset(Cursor & cur) {
        ParagraphList plist;
        if (cur.lastpit() != 0 || cur.lastpos() != 0)
                plist = paragraphs();
-       cur.popLeft();
+       cur.popBackward();
        // store cursor offset
        if (spit == 0)
                spos += cur.pos();
@@ -1136,10 +1063,8 @@ bool Text::dissolveInset(Cursor & cur) {
                // change it to the buffer language.
                ParagraphList::iterator it = plist.begin();
                ParagraphList::iterator it_end = plist.end();
-               for (; it != it_end; it++) {
-                       it->changeLanguage(b.params(), latex_language,
-                                       b.getLanguage());
-               }
+               for (; it != it_end; it++)
+                       it->changeLanguage(b.params(), latex_language, b.language());
 
                pasteParagraphList(cur, plist, b.params().getTextClassPtr(),
                                   b.errorList("Paste"));
@@ -1179,8 +1104,7 @@ void Text::getWord(CursorSlice & from, CursorSlice & to,
                        --from.pos();
                break;
        case NEXT_WORD:
-               lyxerr << "Text::getWord: NEXT_WORD not implemented yet"
-                      << endl;
+               LYXERR0("Text::getWord: NEXT_WORD not implemented yet");
                break;
        case PARTIAL_WORD:
                // no need to move the 'from' cursor
@@ -1235,7 +1159,7 @@ bool Text::read(Buffer const & buf, Lexer & lex, ErrorList & errorList)
 
                        Paragraph par;
                        par.params().depth(depth);
-                       par.setFont(0, Font(Font::ALL_INHERIT, buf.params().language));
+                       par.setFont(0, Font(inherit_font, buf.params().language));
                        pars_.push_back(par);
 
                        // FIXME: goddamn InsetTabular makes us pass a Buffer
@@ -1245,14 +1169,12 @@ bool Text::read(Buffer const & buf, Lexer & lex, ErrorList & errorList)
                } else if (token == "\\begin_deeper") {
                        ++depth;
                } else if (token == "\\end_deeper") {
-                       if (!depth) {
+                       if (!depth)
                                lex.printError("\\end_deeper: " "depth is already null");
-                       } else {
+                       else
                                --depth;
-                       }
                } else {
-                       lyxerr << "Handling unknown body token: `"
-                              << token << '\'' << endl;
+                       LYXERR0("Handling unknown body token: `" << token << '\'');
                }
        }
        return true;
@@ -1285,7 +1207,7 @@ docstring Text::currentState(Cursor & cur)
        // font. (Asger)
        // No, from the document font (MV)
        Font font = cur.real_current_font;
-       font.reduce(buf.params().getFont());
+       font.fontInfo().reduce(buf.params().getFont().fontInfo());
 
        os << bformat(_("Font: %1$s"), font.stateText(&buf.params()));
 
@@ -1346,6 +1268,9 @@ docstring Text::getPossibleLabel(Cursor & cur) const
 
        docstring text;
        docstring par_text = pars_[pit].asString(cur.buffer(), false);
+       string piece;
+       // the return string of math matrices might contain linebreaks
+       par_text = subst(par_text, '\n', '-');
        for (int i = 0; i < lyxrc.label_init_length; ++i) {
                if (par_text.empty())
                        break;
@@ -1456,7 +1381,7 @@ void Text::charsTranspose(Cursor & cur)
        // Track the changes if Change Tracking is enabled.
        bool const trackChanges = cur.buffer().params().trackChanges;
 
-       recordUndo(cur);
+       cur.recordUndo();
 
        par.eraseChar(pos2, trackChanges);
        par.eraseChar(pos1, trackChanges);