Natbib authoryear uses (Ref1; Ref2) by default.

[lyx.git] / src / ParagraphMetrics.cpp

diff --git a/src/ParagraphMetrics.cpp b/src/ParagraphMetrics.cpp
index 12f387d18f37e3680a15b69552387a41cee41e99..d4ff656449ace627c47a9365e8bd51bb122f6da9 100644 (file)
--- a/src/ParagraphMetrics.cpp
+++ b/src/ParagraphMetrics.cpp
@@ -4,13 +4,13 @@
  * Licence details can be found in the file COPYING.
  *
  * \author Asger Alstrup
- * \author Lars Gullik Bjønnes
+ * \author Lars Gullik Bjønnes
  * \author Jean-Marc Lasgouttes
  * \author Angus Leeming
  * \author John Levon
- * \author André Pönitz
+ * \author André Pönitz
  * \author Dekel Tsur
- * \author Jürgen Vigna
+ * \author Jürgen Vigna
  *
  * Full author contact details are available in file CREDITS.
  */
@@ -31,24 +31,23 @@
 #include "LyXRC.h"
 #include "Row.h"
 #include "OutputParams.h"
-#include "paragraph_funcs.h"
 #include "sgml.h"
 #include "TextClass.h"
 #include "TexRow.h"
-#include "VSpace.h"
 
 #include "frontends/FontMetrics.h"
 
 #include "insets/InsetBibitem.h"
-#include "insets/InsetOptArg.h"
+#include "insets/InsetArgument.h"
 
-#include "support/convert.h"
+#include "support/lassert.h"
 #include "support/debug.h"
+#include "support/ExceptionMessage.h"
 #include "support/gettext.h"
 #include "support/lstrings.h"
 #include "support/textutils.h"
 
-#include <boost/bind.hpp>
+#include "support/bind.h"
 #include <boost/crc.hpp>
 
 #include <algorithm>
@@ -95,16 +94,17 @@ size_t ParagraphMetrics::computeRowSignature(Row const & row,
                crc.process_bytes(b, sizeof(char_type));
                if (bparams.trackChanges) {
                        Change change = par_->lookupChange(i);
-                       char_type const b[] = { change.type };
+                       char_type const b[] = { static_cast<char_type>(change.type) };
                        // 1 byte is enough to encode Change::Type
                        crc.process_bytes(b, 1);
                }                       
        }
 
        Dimension const & d = row.dimension();
-       char_type const b[] = { row.sel_beg, row.sel_end, d.wid, d.asc, d.des};
-       // Each of the variable to process is 4 bytes: 4x5 = 20
-       crc.process_bytes(b, 20);
+       char_type const b[] = { static_cast<char_type>(row.sel_beg),
+                               static_cast<char_type>(row.sel_end),
+               row.begin_margin_sel, row.end_margin_sel, d.wid, d.asc, d.des};
+       crc.process_bytes(b, sizeof(b));
 
        return crc.checksum();
 }
@@ -136,7 +136,7 @@ void ParagraphMetrics::setInsetDimension(Inset const * inset,
 
 Row & ParagraphMetrics::getRow(pos_type pos, bool boundary)
 {
-       BOOST_ASSERT(!rows().empty());
+       LBUFERR(!rows().empty());
 
        // If boundary is set we should return the row on which
        // the character before is inside.
@@ -155,7 +155,7 @@ Row & ParagraphMetrics::getRow(pos_type pos, bool boundary)
 
 Row const & ParagraphMetrics::getRow(pos_type pos, bool boundary) const
 {
-       BOOST_ASSERT(!rows().empty());
+       LBUFERR(!rows().empty());
 
        // If boundary is set we should return the row on which
        // the character before is inside.
@@ -174,7 +174,7 @@ Row const & ParagraphMetrics::getRow(pos_type pos, bool boundary) const
 
 size_t ParagraphMetrics::pos2row(pos_type pos) const
 {
-       BOOST_ASSERT(!rows().empty());
+       LBUFERR(!rows().empty());
 
        RowList::const_iterator rit = rows_.end();
        RowList::const_iterator const begin = rows_.begin();
@@ -203,7 +203,7 @@ int ParagraphMetrics::rightMargin(BufferView const & bv) const
        int const r_margin =
                bv.rightMargin()
                + fm.signedWidth(tclass.rightmargin())
-               + fm.signedWidth(par_->layout()->rightmargin)
+               + fm.signedWidth(par_->layout().rightmargin)
                * 4 / (par_->getDepth() + 4);
 
        return r_margin;
@@ -218,6 +218,9 @@ int ParagraphMetrics::singleWidth(pos_type pos, Font const & font) const
 
        char_type c = par_->getChar(pos);
 
+       if (c == '\t')
+               return 4 * theFontMetrics(font).width(' ');
+       
        if (!isPrintable(c))
                return theFontMetrics(font).width(c);
 
@@ -226,12 +229,12 @@ int ParagraphMetrics::singleWidth(pos_type pos, Font const & font) const
                if (language->lang() == "arabic_arabtex" ||
                        language->lang() == "arabic_arabi" ||
                        language->lang() == "farsi") {
-                               if (Encodings::isComposeChar_arabic(c))
+                               if (Encodings::isArabicComposeChar(c))
                                        return 0;
                                c = par_->transformChar(c, pos);
                } else if (language->lang() == "hebrew" &&
-                               Encodings::isComposeChar_hebrew(c)) {
-                       return 0;       
+                               Encodings::isHebrewComposeChar(c)) {
+                       return 0;
                }
        }
        return theFontMetrics(font).width(c);
@@ -243,7 +246,7 @@ bool ParagraphMetrics::hfillExpansion(Row const & row, pos_type pos) const
        if (!par_->isHfill(pos))
                return false;
 
-       BOOST_ASSERT(pos >= row.pos() && pos < row.endpos());
+       LASSERT(pos >= row.pos() && pos < row.endpos(), return false);
 
        // expand at the end of a row only if there is another hfill on the same row
        if (pos == row.endpos() - 1) {
@@ -255,12 +258,11 @@ bool ParagraphMetrics::hfillExpansion(Row const & row, pos_type pos) const
        }
 
        // expand at the beginning of a row only if it is the first row of a paragraph
-       if (pos == row.pos()) {
+       if (pos == row.pos())
                return pos == 0;
-       }
 
        // do not expand in some labels
-       if (par_->layout()->margintype != MARGIN_MANUAL && pos < par_->beginOfBody())
+       if (par_->layout().margintype != MARGIN_MANUAL && pos < par_->beginOfBody())
                return false;
 
        // if there is anything between the first char of the row and