]> git.lyx.org Git - features.git/blobdiff - src/Paragraph.cpp
Revert "Fix a lang edgecase"
[features.git] / src / Paragraph.cpp
index 8da3d13fc1a67fd9282b07a588382476093f17a4..e81eb2fc895b99aa1ce350aeee2d8740e0cc7d13 100644 (file)
@@ -342,7 +342,10 @@ public:
                                   Change & running_change,
                                   Layout const & style,
                                   pos_type & i,
-                                  unsigned int & column);
+                                  unsigned int & column,
+                                  bool const fontswitch_inset,
+                                  bool const closeLanguage,
+                                  bool const lang_switched_at_inset);
 
        ///
        void latexSpecialChar(
@@ -957,7 +960,10 @@ void Paragraph::Private::latexInset(BufferParams const & bparams,
                                    Change & running_change,
                                    Layout const & style,
                                    pos_type & i,
-                                   unsigned int & column)
+                                   unsigned int & column,
+                                   bool const fontswitch_inset,
+                                   bool const closeLanguage,
+                                   bool const lang_switched_at_inset)
 {
        Inset * inset = owner_->getInset(i);
        LBUFERR(inset);
@@ -1027,42 +1033,55 @@ void Paragraph::Private::latexInset(BufferParams const & bparams,
                close = true;
        }
 
-       // FIXME: Bug: we can have an empty font change here!
-       // if there has just been a font change, we are going to close it
-       // right now, which means stupid latex code like \textsf{}. AFAIK,
-       // this does not harm dvi output. A minor bug, thus (JMarc)
-
-       // Some insets cannot be inside a font change command.
-       // However, even such insets *can* be placed in \L or \R
-       // or their equivalents (for RTL language switches), so we don't
-       // close the language in those cases.
-       // ArabTeX, though, cannot handle this special behavior, it seems.
-       bool arabtex = basefont.language()->lang() == "arabic_arabtex"
-               || running_font.language()->lang() == "arabic_arabtex";
-       if (open_font && !inset->inheritFont()) {
-               bool closeLanguage = arabtex
-                       || basefont.isRightToLeft() == running_font.isRightToLeft();
-               unsigned int count = running_font.latexWriteStartChanges(os, bparams,
-                                                     runparams, basefont,
-                                                     running_font, true);
-               column += count;
-               // if any font properties were closed, update the running_font,
-               // making sure, however, to leave the language as it was
-               if (count > 0) {
-                       // FIXME: probably a better way to keep track of the old
-                       // language, than copying the entire font?
-                       Font const copy_font(running_font);
-                       basefont = owner_->getLayoutFont(bparams, outerfont);
-                       running_font = basefont;
-                       if (!closeLanguage)
-                               running_font.setLanguage(copy_font.language());
-                       // For these, we use switches, so no need to close
-                       basefont.fontInfo().setSize(copy_font.fontInfo().size());
-                       basefont.fontInfo().setFamily(copy_font.fontInfo().family());
-                       basefont.fontInfo().setSeries(copy_font.fontInfo().series());
-                       if (closeLanguage)
-                               runparams.local_font = &basefont;
+       if (open_font && (!inset->inheritFont() || fontswitch_inset)) {
+               bool lang_closed = false;
+               // Close language if needed
+               if (closeLanguage) {
+                       // We need prev_font here as language changes directly at inset
+                       // will only be started inside the inset.
+                       Font const prev_font = (i > 0) ?
+                                               owner_->getFont(bparams, i - 1, outerfont)
+                                             : running_font;
+                       Font tmpfont(basefont);
+                       tmpfont.setLanguage(prev_font.language());
+                       bool needPar = false;
+                       unsigned int count = tmpfont.latexWriteEndChanges(os, bparams, runparams,
+                                                                         basefont, basefont,
+                                                                         needPar, closeLanguage);
+                       column += count;
+                       lang_closed = count > 0;
                }
+               // Update the running_font, making sure, however,
+               // to leave the language as it was.
+               // FIXME: probably a better way to keep track of the old
+               // language, than copying the entire font?
+               Font const copy_font(running_font);
+               basefont = owner_->getLayoutFont(bparams, outerfont);
+               running_font = basefont;
+               if (!closeLanguage)
+                       running_font.setLanguage(copy_font.language());
+               // For these, we use switches, so they should be taken as
+               // base inside the inset.
+               basefont.fontInfo().setSize(copy_font.fontInfo().size());
+               basefont.fontInfo().setFamily(copy_font.fontInfo().family());
+               basefont.fontInfo().setSeries(copy_font.fontInfo().series());
+               // Now re-do font changes in a way needed here
+               // (using switches with multi-par insets)
+               InsetText const * textinset = inset->asInsetText();
+               bool const cprotect = textinset
+                       ? textinset->hasCProtectContent(runparams.moving_arg)
+                         && !textinset->text().isMainText()
+                       : false;
+               unsigned int count2 = basefont.latexWriteStartChanges(os, bparams,
+                                                     runparams, running_font,
+                                                     basefont, true,
+                                                     cprotect);
+               column += count2;
+               if (count2 == 0 && (lang_closed || lang_switched_at_inset))
+                       // All fonts closed
+                       open_font = false;
+               if (closeLanguage)
+                       runparams.local_font = &basefont;
        }
 
        size_t const previous_row_count = os.texrow().rows();
@@ -2562,14 +2581,18 @@ void Paragraph::latex(BufferParams const & bparams,
                                             && runningChange == change
                                             && change.type == Change::DELETED
                                             && !os.afterParbreak());
-               bool const non_inherit_inset =
-                               (c == META_INSET && getInset(i) && !getInset(i)->inheritFont());
+               // Insets where font switches are used (rather than font commands)
+               bool const fontswitch_inset =
+                               c == META_INSET
+                               && getInset(i)
+                               && getInset(i)->allowMultiPar()
+                               && !getInset(i)->isPassThru();
 
                // Do we need to close the previous font?
                if (open_font &&
                    ((current_font != running_font
                      || current_font.language() != running_font.language())
-                    || (non_inherit_inset
+                    || (fontswitch_inset
                         && (current_font == prev_font
                             || current_font.language() == prev_font.language()))))
                {
@@ -2657,9 +2680,15 @@ void Paragraph::latex(BufferParams const & bparams,
                                column += 1;
                        }
                        otexstringstream ots;
-                       if (!non_inherit_inset) {
+                       if (!fontswitch_inset) {
+                               InsetText const * textinset = inInset().asInsetText();
+                               bool const cprotect = textinset
+                                       ? textinset->hasCProtectContent(runparams.moving_arg)
+                                         && !textinset->text().isMainText()
+                                       : false;
                                column += current_font.latexWriteStartChanges(ots, bparams,
-                                                                             runparams, basefont, last_font);
+                                                                             runparams, basefont, last_font, false,
+                                                                             cprotect);
                        }
                        // Check again for display math in ulem commands as a
                        // font change may also occur just before a math inset.
@@ -2751,16 +2780,41 @@ void Paragraph::latex(BufferParams const & bparams,
                                                incremented = true;
                                        }
                                }
-                               // We need to restore these after insets with
-                               // inheritFont() false
-                               Font const save_running_font = running_font;
+                               // We need to restore parts of this after insets with
+                               // allowMultiPar() true
                                Font const save_basefont = basefont;
+                               Font const save_runningfont = running_font;
+                               bool closeLanguage = false;
+                               bool lang_switched_at_inset = false;
+                               if (fontswitch_inset) {
+                                       // Some insets cannot be inside a font change command.
+                                       // However, even such insets *can* be placed in \L or \R
+                                       // or their equivalents (for RTL language switches),
+                                       // so we don't close the language in those cases
+                                       // (= differing isRightToLeft()).
+                                       // ArabTeX, though, doesn't seem to handle this special behavior.
+                                       closeLanguage = basefont.isRightToLeft() != running_font.isRightToLeft()
+                                                       && basefont.language()->lang() != "arabic_arabtex"
+                                                       && running_font.language()->lang() != "arabic_arabtex";
+                                       // We need to check prev_font as language changes directly at inset
+                                       // will only be started inside the inset.
+                                       lang_switched_at_inset = prev_font.language() != running_font.language();
+                               }
                                d->latexInset(bparams, os, rp, running_font,
                                                basefont, real_outerfont, open_font,
-                                               runningChange, style, i, column);
-                               if (non_inherit_inset) {
-                                       running_font = save_running_font;
-                                       basefont = save_basefont;
+                                               runningChange, style, i, column,
+                                               fontswitch_inset, closeLanguage, lang_switched_at_inset);
+                               if (fontswitch_inset) {
+                                       if (open_font) {
+                                               bool needPar = false;
+                                               column += running_font.latexWriteEndChanges(
+                                                       os, bparams, runparams,
+                                                       basefont, basefont, needPar);
+                                               open_font = false;
+                                       }
+                                       basefont.fontInfo().setSize(save_basefont.fontInfo().size());
+                                       basefont.fontInfo().setFamily(save_basefont.fontInfo().family());
+                                       basefont.fontInfo().setSeries(save_basefont.fontInfo().series());
                                }
                                if (incremented)
                                        --parInline;
@@ -4273,9 +4327,12 @@ int Paragraph::find(docstring const & str, bool cs, bool mw,
                // Ignore "invisible" letters such as ligature breaks
                // and hyphenation chars while searching
                while (pos < parsize - 1 && isInset(pos)) {
+                       Inset const * inset = getInset(pos);
+                       if (!inset->isLetter())
+                               break;
                        odocstringstream os;
-                       getInset(pos)->toString(os);
-                       if (!getInset(pos)->isLetter() || !os.str().empty())
+                       inset->toString(os);
+                       if (!os.str().empty())
                                break;
                        pos++;
                }
@@ -4469,7 +4526,18 @@ Language * Paragraph::Private::locateSpellRange(
        while (last < to && samelang && sameinset) {
                // hop to end of word
                while (last < to && !owner_->isWordSeparator(last)) {
-                       if (owner_->getInset(last)) {
+                       Inset const * inset = owner_->getInset(last);
+                       if (inset && inset->lyxCode() == SPECIALCHAR_CODE) {
+                               // check for "invisible" letters such as ligature breaks
+                               odocstringstream os;
+                               inset->toString(os);
+                               if (os.str().length() != 0) {
+                                       // avoid spell check of visible special char insets
+                                       // stop the loop in front of the special char inset
+                                       sameinset = false;
+                                       break;
+                               }
+                       } else if (inset) {
                                appendSkipPosition(skips, last);
                        } else if (owner_->isDeleted(last)) {
                                appendSkipPosition(skips, last);