]> git.lyx.org Git - lyx.git/blobdiff - src/Paragraph.cpp
adjust
[lyx.git] / src / Paragraph.cpp
index 0634bbafe54ace43be22866138a9ac591d133175..9bd4e6e0b5943f52a1d7d130a7fbcd36f82b5f39 100644 (file)
 #include "Language.h"
 #include "LaTeXFeatures.h"
 #include "Color.h"
+#include "Layout.h"
 #include "Length.h"
 #include "Font.h"
 #include "LyXRC.h"
-#include "Row.h"
 #include "Messages.h"
 #include "OutputParams.h"
 #include "output_latex.h"
 #include "paragraph_funcs.h"
 #include "ParagraphParameters.h"
-#include "rowpainter.h"
 #include "sgml.h"
 #include "TexRow.h"
 #include "VSpace.h"
 
+#include "frontends/alert.h"
 #include "frontends/FontMetrics.h"
 
 #include "insets/InsetBibitem.h"
@@ -66,7 +66,10 @@ using std::ostream;
 namespace lyx {
 
 using support::contains;
+using support::prefixIs;
+using support::suffixIs;
 using support::rsplit;
+using support::rtrim;
 
 
 /////////////////////////////////////////////////////////////////////
@@ -176,21 +179,26 @@ public:
        /// Output the surrogate pair formed by \p c and \p next to \p os.
        /// \return the number of characters written.
        int latexSurrogatePair(odocstream & os, value_type c, value_type next,
-                              Encoding const &);
+                              Encoding const &);
        /// Output a space in appropriate formatting (or a surrogate pair
        /// if the next character is a combining character).
        /// \return whether a surrogate pair was output.
        bool simpleTeXBlanks(Encoding const &,
-                            odocstream &, TexRow & texrow,
+                            odocstream &, TexRow & texrow,
                             pos_type & i,
                             unsigned int & column,
                             Font const & font,
                             Layout const & style);
+       /// Output consecutive known unicode chars, belonging to the same
+       /// language as specified by \p preamble, to \p os starting from \p c.
+       /// \return the number of characters written.
+       int knownLangChars(odocstream & os, value_type c, string & preamble,
+                          Change &, Encoding const &, pos_type &);
        ///
        void simpleTeXSpecialChars(Buffer const &, BufferParams const &,
-                                  odocstream &,
-                                  TexRow & texrow, OutputParams const &,
-                                  Font & running_font,
+                                  odocstream &,
+                                  TexRow & texrow, OutputParams &,
+                                  Font & running_font,
                                   Font & basefont,
                                   Font const & outerfont,
                                   bool & open_font,
@@ -210,7 +218,7 @@ public:
        ///
        ParagraphParameters params;
 
-private:
+//private:
        ///
        pos_type size() const { return owner_->size(); }
        /// match a string against a particular point in the paragraph
@@ -445,7 +453,7 @@ void Paragraph::Pimpl::insertChar(pos_type pos, value_type c, Change const & cha
 
        // Update the font table.
        FontTable search_font(pos, Font());
-       for (FontList::iterator it 
+       for (FontList::iterator it
              = lower_bound(fontlist.begin(), fontlist.end(), search_font, matchFT());
             it != fontlist.end(); ++it)
        {
@@ -458,7 +466,7 @@ void Paragraph::Pimpl::insertChar(pos_type pos, value_type c, Change const & cha
 
 
 void Paragraph::Pimpl::insertInset(pos_type pos, Inset * inset,
-                                   Change const & change)
+                                  Change const & change)
 {
        BOOST_ASSERT(inset);
        BOOST_ASSERT(pos >= 0 && pos <= size());
@@ -480,7 +488,7 @@ bool Paragraph::Pimpl::eraseChar(pos_type pos, bool trackChanges)
        if (trackChanges) {
                Change change = changes_.lookup(pos);
 
-               // set the character to DELETED if 
+               // set the character to DELETED if
                //  a) it was previously unchanged or
                //  b) it was inserted by a co-author
 
@@ -580,8 +588,8 @@ int Paragraph::Pimpl::latexSurrogatePair(odocstream & os, value_type c,
 
 
 bool Paragraph::Pimpl::simpleTeXBlanks(Encoding const & encoding,
-                                       odocstream & os, TexRow & texrow,
-                                       pos_type & i,
+                                      odocstream & os, TexRow & texrow,
+                                      pos_type & i,
                                       unsigned int & column,
                                       Font const & font,
                                       Layout const & style)
@@ -589,7 +597,7 @@ bool Paragraph::Pimpl::simpleTeXBlanks(Encoding const & encoding,
        if (style.pass_thru)
                return false;
 
-       if (i < size() - 1) {
+       if (i + 1 < size()) {
                char_type next = getChar(i + 1);
                if (Encodings::isCombiningChar(next)) {
                        // This space has an accent, so we must always output it.
@@ -603,7 +611,7 @@ bool Paragraph::Pimpl::simpleTeXBlanks(Encoding const & encoding,
            && column > lyxrc.plaintext_linelen
            && i
            && getChar(i - 1) != ' '
-           && (i < size() - 1)
+           && (i + 1 < size())
            // same in FreeSpacing mode
            && !owner_->isFreeSpacing()
            // In typewriter mode, we want to avoid
@@ -626,6 +634,66 @@ bool Paragraph::Pimpl::simpleTeXBlanks(Encoding const & encoding,
 }
 
 
+int Paragraph::Pimpl::knownLangChars(odocstream & os,
+                                    value_type c,
+                                    string & preamble,
+                                    Change & runningChange,
+                                    Encoding const & encoding,
+                                    pos_type & i)
+{
+       // When the character is marked by the proper language, we simply
+       // get its code point in some encoding, otherwise we get the
+       // translation specified in the unicodesymbols file, which is
+       // something like "\textLANG{<spec>}". So, we have to retain
+       // "\textLANG{<spec>" for the first char but only "<spec>" for
+       // all subsequent chars.
+       docstring const latex1 = rtrim(encoding.latexChar(c), "}");
+       int length = latex1.length();
+       os << latex1;
+       while (i + 1 < size()) {
+               char_type next = getChar(i + 1);
+               // Stop here if next character belongs to another
+               // language or there is a change tracking status.
+               if (!Encodings::isKnownLangChar(next, preamble) ||
+                   runningChange != lookupChange(i + 1))
+                       break;
+               Font prev_font;
+               bool found = false;
+               FontList::const_iterator cit = fontlist.begin();
+               FontList::const_iterator end = fontlist.end();
+               for (; cit != end; ++cit) {
+                       if (cit->pos() >= i && !found) {
+                               prev_font = cit->font();
+                               found = true;
+                       }
+                       if (cit->pos() >= i + 1)
+                               break;
+               }
+               // Stop here if there is a font attribute change.
+               if (found && cit != end && prev_font != cit->font())
+                       break;
+               docstring const latex = rtrim(encoding.latexChar(next), "}");
+               docstring::size_type const j =
+                                       latex.find_first_of(from_ascii("{"));
+               if (j == docstring::npos) {
+                       os << latex;
+                       length += latex.length();
+               } else {
+                       os << latex.substr(j + 1);
+                       length += latex.substr(j + 1).length();
+               }
+               ++i;
+       }
+       // When the proper language is set, we are simply passed a code
+       // point, so we should not try to close the \textLANG command.
+       if (prefixIs(latex1, from_ascii("\\" + preamble))) {
+               os << '}';
+               ++length;
+       }
+       return length;
+}
+
+
 bool Paragraph::Pimpl::isTextAt(string const & str, pos_type pos) const
 {
        pos_type const len = str.length();
@@ -660,7 +728,7 @@ void Paragraph::Pimpl::simpleTeXSpecialChars(Buffer const & buf,
                                             BufferParams const & bparams,
                                             odocstream & os,
                                             TexRow & texrow,
-                                            OutputParams const & runparams,
+                                            OutputParams & runparams,
                                             Font & running_font,
                                             Font & basefont,
                                             Font const & outerfont,
@@ -694,7 +762,7 @@ void Paragraph::Pimpl::simpleTeXSpecialChars(Buffer const & buf,
                        break;
 
                // FIXME: move this to InsetNewline::latex
-               if (inset->lyxCode() == Inset::NEWLINE_CODE) {
+               if (inset->lyxCode() == NEWLINE_CODE) {
                        // newlines are handled differently here than
                        // the default in simpleTeXSpecialChars().
                        if (!style.newline_allowed) {
@@ -724,6 +792,11 @@ void Paragraph::Pimpl::simpleTeXSpecialChars(Buffer const & buf,
                        break;
                }
 
+               if (lookupChange(i).type == Change::DELETED) {
+                       if( ++runparams.inDeletedInset == 1)
+                               runparams.changeOfDeletedInset = lookupChange(i);
+               }
+
                if (inset->canTrackChanges()) {
                        column += Changes::latexMarkChange(os, bparams, running_change,
                                Change(Change::UNCHANGED));
@@ -733,34 +806,60 @@ void Paragraph::Pimpl::simpleTeXSpecialChars(Buffer const & buf,
                bool close = false;
                odocstream::pos_type const len = os.tellp();
 
-               if ((inset->lyxCode() == Inset::GRAPHICS_CODE
-                    || inset->lyxCode() == Inset::MATH_CODE
-                    || inset->lyxCode() == Inset::URL_CODE)
+               if ((inset->lyxCode() == GRAPHICS_CODE
+                    || inset->lyxCode() == MATH_CODE
+                    || inset->lyxCode() == HYPERLINK_CODE)
                    && running_font.isRightToLeft()) {
-                       os << "\\L{";
+                       if (running_font.language()->lang() == "farsi")
+                               os << "\\beginL{}";
+                       else
+                               os << "\\L{";
                        close = true;
                }
 
-#ifdef WITH_WARNINGS
-#warning Bug: we can have an empty font change here!
+// FIXME: Bug: we can have an empty font change here!
 // if there has just been a font change, we are going to close it
 // right now, which means stupid latex code like \textsf{}. AFAIK,
 // this does not harm dvi output. A minor bug, thus (JMarc)
-#endif
-               // some insets cannot be inside a font change command
+               // Some insets cannot be inside a font change command.
+               // However, even such insets *can* be placed in \L or \R
+               // or their equivalents (for RTL language switches), so we don't
+               // close the language in those cases.
+               // ArabTeX, though, cannot handle this special behavior, it seems.
+               bool arabtex = basefont.language()->lang() == "arabic_arabtex" ||
+                                          running_font.language()->lang() == "arabic_arabtex";
                if (open_font && inset->noFontChange()) {
-                       column += running_font.latexWriteEndChanges(
+                       bool closeLanguage = arabtex ||
+                               basefont.isRightToLeft() == running_font.isRightToLeft();
+                       unsigned int count = running_font.latexWriteEndChanges(
                                        os, bparams, runparams,
-                                               basefont, basefont);
-                       open_font = false;
-                       basefont = owner_->getLayoutFont(bparams, outerfont);
-                       running_font = basefont;
+                                               basefont, basefont, closeLanguage);
+                       column += count;
+                       // if any font properties were closed, update the running_font, 
+                       // making sure, however, to leave the language as it was
+                       if (count > 0) {
+                               // FIXME: probably a better way to keep track of the old 
+                               // language, than copying the entire font?
+                               Font const copy_font(running_font);
+                               basefont = owner_->getLayoutFont(bparams, outerfont);
+                               running_font = basefont;
+                               if (!closeLanguage)
+                                       running_font.setLanguage(copy_font.language());
+                               // leave font open if language is still open
+                               open_font = (running_font.language() == basefont.language());
+                               if (closeLanguage)
+                                       runparams.local_font = &basefont;
+                       }
                }
 
                int tmp = inset->latex(buf, os, runparams);
 
-               if (close)
-                       os << '}';
+               if (close) {
+                       if (running_font.language()->lang() == "farsi")
+                               os << "\\endL{}";
+                       else
+                               os << '}';
+               }
 
                if (tmp) {
                        for (int j = 0; j < tmp; ++j) {
@@ -771,6 +870,10 @@ void Paragraph::Pimpl::simpleTeXSpecialChars(Buffer const & buf,
                } else {
                        column += os.tellp() - len;
                }
+
+               if (lookupChange(i).type == Change::DELETED) {
+                       --runparams.inDeletedInset;
+               }
        }
        break;
 
@@ -908,7 +1011,7 @@ void Paragraph::Pimpl::simpleTeXSpecialChars(Buffer const & buf,
 
                        if (pnr == phrases_nr && c != '\0') {
                                Encoding const & encoding = *(runparams.encoding);
-                               if (i < size() - 1) {
+                               if (i + 1 < size()) {
                                        char_type next = getChar(i + 1);
                                        if (Encodings::isCombiningChar(next)) {
                                                column += latexSurrogatePair(os, c, next, encoding) - 1;
@@ -916,6 +1019,14 @@ void Paragraph::Pimpl::simpleTeXSpecialChars(Buffer const & buf,
                                                break;
                                        }
                                }
+                               string preamble;
+                               if (Encodings::isKnownLangChar(c, preamble)) {
+                                       column +=
+                                               knownLangChars(os, c, preamble,
+                                                       running_change,
+                                                       encoding, i) - 1;
+                                       break;
+                               }
                                docstring const latex = encoding.latexChar(c);
                                if (latex.length() > 1 &&
                                    latex[latex.length() - 1] != '}') {
@@ -999,7 +1110,7 @@ void Paragraph::Pimpl::validate(LaTeXFeatures & features,
                if (icit->inset) {
                        icit->inset->validate(features);
                        if (layout.needprotect &&
-                           icit->inset->lyxCode() == Inset::FOOT_CODE)
+                           icit->inset->lyxCode() == FOOT_CODE)
                                features.require("NeedLyXFootnoteCode");
                }
        }
@@ -1047,7 +1158,7 @@ Paragraph::Paragraph(Paragraph const & par)
        InsetList::iterator it = insetlist.begin();
        InsetList::iterator end = insetlist.end();
        for (; it != end; ++it)
-               it->inset = it->inset->clone().release();
+               it->inset = it->inset->clone();
 }
 
 
@@ -1061,7 +1172,7 @@ Paragraph & Paragraph::operator=(Paragraph const & par)
                InsetList::iterator it = insetlist.begin();
                InsetList::iterator end = insetlist.end();
                for (; it != end; ++it)
-                       it->inset = it->inset->clone().release();
+                       it->inset = it->inset->clone();
 
                layout_ = par.layout();
                text_ = par.text_;
@@ -1103,7 +1214,7 @@ void Paragraph::write(Buffer const & buf, ostream & os,
        }
 
        // First write the layout
-       os << "\n\\begin_layout " << layout()->name() << '\n';
+       os << "\n\\begin_layout " << to_utf8(layout()->name()) << '\n';
 
        params().write(os);
 
@@ -1204,7 +1315,7 @@ int Paragraph::eraseChars(pos_type start, pos_type end, bool trackChanges)
 
 
 void Paragraph::insert(pos_type start, docstring const & str,
-                       Font const & font, Change const & change)
+                      Font const & font, Change const & change)
 {
        for (size_t i = 0, n = str.size(); i != n ; ++i)
                insertChar(start + i, str[i], font, change);
@@ -1212,24 +1323,24 @@ void Paragraph::insert(pos_type start, docstring const & str,
 
 
 void Paragraph::insertChar(pos_type pos, Paragraph::value_type c,
-                           bool trackChanges)
+                          bool trackChanges)
 {
        pimpl_->insertChar(pos, c, Change(trackChanges ?
-                          Change::INSERTED : Change::UNCHANGED));
+                          Change::INSERTED : Change::UNCHANGED));
 }
 
 
 void Paragraph::insertChar(pos_type pos, Paragraph::value_type c,
-                           Font const & font, bool trackChanges)
+                          Font const & font, bool trackChanges)
 {
        pimpl_->insertChar(pos, c, Change(trackChanges ?
-                          Change::INSERTED : Change::UNCHANGED));
+                          Change::INSERTED : Change::UNCHANGED));
        setFont(pos, font);
 }
 
 
 void Paragraph::insertChar(pos_type pos, Paragraph::value_type c,
-                           Font const & font, Change const & change)
+                          Font const & font, Change const & change)
 {
        pimpl_->insertChar(pos, c, change);
        setFont(pos, font);
@@ -1237,21 +1348,22 @@ void Paragraph::insertChar(pos_type pos, Paragraph::value_type c,
 
 
 void Paragraph::insertInset(pos_type pos, Inset * inset,
-                            Change const & change)
+                           Change const & change)
 {
        pimpl_->insertInset(pos, inset, change);
 }
 
 
 void Paragraph::insertInset(pos_type pos, Inset * inset,
-                            Font const & font, Change const & change)
+                           Font const & font, Change const & change)
 {
        pimpl_->insertInset(pos, inset, change);
+       // Set the font/language of the inset...
        setFont(pos, font);
 }
 
 
-bool Paragraph::insetAllowed(Inset_code code)
+bool Paragraph::insetAllowed(InsetCode code)
 {
        return !pimpl_->inset_owner || pimpl_->inset_owner->insetAllowed(code);
 }
@@ -1329,18 +1441,14 @@ Font const Paragraph::getFont(BufferParams const & bparams, pos_type pos,
 {
        BOOST_ASSERT(pos >= 0);
 
-       Layout_ptr const & lout = layout();
+       Font font = getFontSettings(bparams, pos);
 
        pos_type const body_pos = beginOfBody();
-
-       Font layoutfont;
        if (pos < body_pos)
-               layoutfont = lout->labelfont;
+               font.realize(layout_->labelfont);
        else
-               layoutfont = lout->font;
+               font.realize(layout_->font);
 
-       Font font = getFontSettings(bparams, pos);
-       font.realize(layoutfont);
        font.realize(outerfont);
        font.realize(bparams.getFont());
 
@@ -1575,7 +1683,7 @@ docstring const & Paragraph::getLabelstring() const
 // the next two functions are for the manual labels
 docstring const Paragraph::getLabelWidthString() const
 {
-       if (!params().labelWidthString().empty())
+       if (layout()->margintype == MARGIN_MANUAL)
                return params().labelWidthString();
        else
                return _("Senseless with this layout!");
@@ -1602,7 +1710,7 @@ docstring const Paragraph::translateIfPossible(docstring const & s,
 }
 
 
-docstring Paragraph::expandLabel(Layout_ptr const & layout,
+docstring Paragraph::expandLabel(LayoutPtr const & layout,
                BufferParams const & bparams, bool process_appendix) const
 {
        TextClass const & tclass = bparams.getTextClass();
@@ -1614,6 +1722,10 @@ docstring Paragraph::expandLabel(Layout_ptr const & layout,
        else
                fmt = translateIfPossible(layout->labelstring(), bparams);
 
+       if (fmt.empty() && layout->labeltype == LABEL_COUNTER 
+           && !layout->counter.empty())
+               fmt = "\\the" + layout->counter;
+
        // handle 'inherited level parts' in 'fmt',
        // i.e. the stuff between '@' in   '@Section@.\arabic{subsection}'
        size_t const i = fmt.find('@', 0);
@@ -1621,9 +1733,12 @@ docstring Paragraph::expandLabel(Layout_ptr const & layout,
                size_t const j = fmt.find('@', i + 1);
                if (j != docstring::npos) {
                        docstring parent(fmt, i + 1, j - i - 1);
-                       // FIXME UNICODE
-                       docstring label = expandLabel(tclass[to_utf8(parent)], bparams);
-                       fmt = docstring(fmt, 0, i) + label + docstring(fmt, j + 1, docstring::npos);
+                       docstring label = from_ascii("??");
+                       if (tclass.hasLayout(parent))
+                               docstring label = expandLabel(tclass[parent], bparams,
+                                                     process_appendix);
+                       fmt = docstring(fmt, 0, i) + label 
+                               + docstring(fmt, j + 1, docstring::npos);
                }
        }
 
@@ -1631,12 +1746,16 @@ docstring Paragraph::expandLabel(Layout_ptr const & layout,
 }
 
 
-void Paragraph::applyLayout(Layout_ptr const & new_layout)
+void Paragraph::applyLayout(LayoutPtr const & new_layout)
 {
        layout(new_layout);
-       params().labelWidthString(docstring());
-       params().align(LYX_ALIGN_LAYOUT);
-       params().spacing(Spacing(Spacing::Default));
+       LyXAlignment const oldAlign = params().align();
+       
+       if (!(oldAlign & layout()->alignpossible)) {
+               frontend::Alert::warning(_("Alignment not permitted"), 
+                       _("The new layout does not permit the alignment previously used.\nSetting to default."));
+               params().align(LYX_ALIGN_LAYOUT);
+       }
 }
 
 
@@ -1698,7 +1817,7 @@ InsetBibitem * Paragraph::bibitem() const
 {
        if (!insetlist.empty()) {
                Inset * inset = insetlist.begin()->inset;
-               if (inset->lyxCode() == Inset::BIBITEM_CODE)
+               if (inset->lyxCode() == BIBITEM_CODE)
                        return static_cast<InsetBibitem *>(inset);
        }
        return 0;
@@ -1716,9 +1835,9 @@ namespace {
 // paragraphs inside floats need different alignment tags to avoid
 // unwanted space
 
-bool noTrivlistCentering(Inset::Code code)
+bool noTrivlistCentering(InsetCode code)
 {
-       return code == Inset::FLOAT_CODE || code == Inset::WRAP_CODE;
+       return code == FLOAT_CODE || code == WRAP_CODE;
 }
 
 
@@ -1735,7 +1854,7 @@ string correction(string const & orig)
 
 
 string const corrected_env(string const & suffix, string const & env,
-       Inset::Code code)
+       InsetCode code)
 {
        string output = suffix + "{";
        if (noTrivlistCentering(code))
@@ -1765,7 +1884,7 @@ void adjust_row_column(string const & str, TexRow & texrow, int & column)
 
 // This could go to ParagraphParameters if we want to
 int Paragraph::startTeXParParams(BufferParams const & bparams,
-                                 odocstream & os, TexRow & texrow, 
+                                odocstream & os, TexRow & texrow,
                                 bool moving_arg) const
 {
        int column = 0;
@@ -1774,8 +1893,13 @@ int Paragraph::startTeXParParams(BufferParams const & bparams,
                os << "\\noindent ";
                column += 10;
        }
+       
+       LyXAlignment const curAlign = params().align();
 
-       switch (params().align()) {
+       if (curAlign == layout()->align)
+               return column;
+
+       switch (curAlign) {
        case LYX_ALIGN_NONE:
        case LYX_ALIGN_BLOCK:
        case LYX_ALIGN_LAYOUT:
@@ -1791,7 +1915,7 @@ int Paragraph::startTeXParParams(BufferParams const & bparams,
                break;
        }
 
-       switch (params().align()) {
+       switch (curAlign) {
        case LYX_ALIGN_NONE:
        case LYX_ALIGN_BLOCK:
        case LYX_ALIGN_LAYOUT:
@@ -1829,8 +1953,8 @@ int Paragraph::startTeXParParams(BufferParams const & bparams,
 
 
 // This could go to ParagraphParameters if we want to
-int Paragraph::endTeXParParams(BufferParams const & bparams,  
-                               odocstream & os, TexRow & texrow,
+int Paragraph::endTeXParParams(BufferParams const & bparams,
+                              odocstream & os, TexRow & texrow,
                               bool moving_arg) const
 {
        int column = 0;
@@ -1899,7 +2023,7 @@ bool Paragraph::simpleTeXOnePar(Buffer const & buf,
 
        bool return_value = false;
 
-       Layout_ptr style;
+       LayoutPtr style;
 
        // well we have to check if we are in an inset with unlimited
        // length (all in one row) if that is true then we don't allow
@@ -1982,12 +2106,13 @@ bool Paragraph::simpleTeXOnePar(Buffer const & buf,
                        }
 
                        if (!asdefault)
-                               column += startTeXParParams(bparams, os, 
+                               column += startTeXParParams(bparams, os,
                                                            texrow,
                                                            runparams.moving_arg);
                }
 
-               Change const & change = pimpl_->lookupChange(i);
+               Change const & change = runparams.inDeletedInset ? runparams.changeOfDeletedInset
+                                                                : pimpl_->lookupChange(i);
 
                if (bparams.outputChanges && runningChange != change) {
                        if (open_font) {
@@ -2009,7 +2134,7 @@ bool Paragraph::simpleTeXOnePar(Buffer const & buf,
                }
 
                ++column;
-               
+
                value_type const c = getChar(i);
 
                // Fully instantiated font
@@ -2032,11 +2157,11 @@ bool Paragraph::simpleTeXOnePar(Buffer const & buf,
                // Switch file encoding if necessary
                if (runparams.encoding->package() == Encoding::inputenc &&
                    font.language()->encoding()->package() == Encoding::inputenc) {
-                       int const count = switchEncoding(os, bparams,
+                       std::pair<bool, int> const enc_switch = switchEncoding(os, bparams,
                                        runparams.moving_arg, *(runparams.encoding),
                                        *(font.language()->encoding()));
-                       if (count > 0) {
-                               column += count;
+                       if (enc_switch.first) {
+                               column += enc_switch.second;
                                runparams.encoding = font.language()->encoding();
                        }
                }
@@ -2046,11 +2171,20 @@ bool Paragraph::simpleTeXOnePar(Buffer const & buf,
                     font.language() != running_font.language()) &&
                        i != body_pos - 1)
                {
-                       column += font.latexWriteStartChanges(os, bparams,
-                                                             runparams, basefont,
-                                                             last_font);
+                       odocstringstream ods;
+                       column += font.latexWriteStartChanges(ods, bparams,
+                                                             runparams, basefont,
+                                                             last_font);
                        running_font = font;
                        open_font = true;
+                       docstring fontchange = ods.str();
+                       // check if the fontchange ends with a trailing blank
+                       // (like "\small " (see bug 3382)
+                       if (suffixIs(fontchange, ' ') && c == ' ')
+                               os << fontchange.substr(0, fontchange.size() - 1) 
+                                  << from_ascii("{}");
+                       else
+                               os << fontchange;
                }
 
                if (c == ' ') {
@@ -2080,6 +2214,10 @@ bool Paragraph::simpleTeXOnePar(Buffer const & buf,
                                        texrow, rp, running_font,
                                        basefont, outerfont, open_font,
                                        runningChange, *style, i, column, c);
+
+               // Set the encoding to that returned from simpleTeXSpecialChars (see
+               // comment for encoding member in OutputParams.h)
+               runparams.encoding = rp.encoding;
        }
 
        // If we have an open font definition, we have to close it
@@ -2095,11 +2233,9 @@ bool Paragraph::simpleTeXOnePar(Buffer const & buf,
                                        runparams, basefont, basefont);
                }
 #else
-#ifdef WITH_WARNINGS
-//#warning For now we ALWAYS have to close the foreign font settings if they are
-//#warning there as we start another \selectlanguage with the next paragraph if
-//#warning we are in need of this. This should be fixed sometime (Jug)
-#endif
+//FIXME: For now we ALWAYS have to close the foreign font settings if they are
+//FIXME: there as we start another \selectlanguage with the next paragraph if
+//FIXME: we are in need of this. This should be fixed sometime (Jug)
                running_font.latexWriteEndChanges(os, bparams, runparams,
                                basefont, basefont);
 #endif
@@ -2114,7 +2250,7 @@ bool Paragraph::simpleTeXOnePar(Buffer const & buf,
        }
 
        if (!asdefault) {
-               column += endTeXParParams(bparams, os, texrow, 
+               column += endTeXParParams(bparams, os, texrow,
                                          runparams.moving_arg);
        }
 
@@ -2171,14 +2307,14 @@ bool Paragraph::emptyTag() const
        for (pos_type i = 0; i < size(); ++i) {
                if (isInset(i)) {
                        Inset const * inset = getInset(i);
-                       Inset::Code lyx_code = inset->lyxCode();
-                       if (lyx_code != Inset::TOC_CODE &&
-                           lyx_code != Inset::INCLUDE_CODE &&
-                           lyx_code != Inset::GRAPHICS_CODE &&
-                           lyx_code != Inset::ERT_CODE &&
-                           lyx_code != Inset::LISTINGS_CODE &&
-                           lyx_code != Inset::FLOAT_CODE &&
-                           lyx_code != Inset::TABULAR_CODE) {
+                       InsetCode lyx_code = inset->lyxCode();
+                       if (lyx_code != TOC_CODE &&
+                           lyx_code != INCLUDE_CODE &&
+                           lyx_code != GRAPHICS_CODE &&
+                           lyx_code != ERT_CODE &&
+                           lyx_code != LISTINGS_CODE &&
+                           lyx_code != FLOAT_CODE &&
+                           lyx_code != TABULAR_CODE) {
                                return false;
                        }
                } else {
@@ -2196,8 +2332,8 @@ string Paragraph::getID(Buffer const & buf, OutputParams const & runparams) cons
        for (pos_type i = 0; i < size(); ++i) {
                if (isInset(i)) {
                        Inset const * inset = getInset(i);
-                       Inset::Code lyx_code = inset->lyxCode();
-                       if (lyx_code == Inset::LABEL_CODE) {
+                       InsetCode lyx_code = inset->lyxCode();
+                       if (lyx_code == LABEL_CODE) {
                                string const id = static_cast<InsetCommand const *>(inset)->getContents();
                                return "id='" + to_utf8(sgml::cleanID(buf, runparams, from_utf8(id))) + "'";
                        }
@@ -2220,7 +2356,7 @@ pos_type Paragraph::getFirstWord(Buffer const & buf, odocstream & os, OutputPara
                        if (c == ' ')
                                break;
                        os << sgml::escapeChar(c);
-               }
+               }
        }
        return i;
 }
@@ -2251,7 +2387,7 @@ void Paragraph::simpleDocBookOnePar(Buffer const & buf,
 {
        bool emph_flag = false;
 
-       Layout_ptr const & style = layout();
+       LayoutPtr const & style = layout();
        Font font_old =
                style->labeltype == LABEL_MANUAL ? style->labelfont : style->font;
 
@@ -2280,9 +2416,9 @@ void Paragraph::simpleDocBookOnePar(Buffer const & buf,
                        value_type c = getChar(i);
 
                        if (style->pass_thru)
-                                os.put(c);
+                               os.put(c);
                        else
-                                os << sgml::escapeChar(c);
+                               os << sgml::escapeChar(c);
                }
                font_old = font;
        }
@@ -2298,10 +2434,17 @@ void Paragraph::simpleDocBookOnePar(Buffer const & buf,
 }
 
 
+bool Paragraph::isHfill(pos_type pos) const
+{
+       return isInset(pos)
+               && getInset(pos)->lyxCode() == HFILL_CODE;
+}
+
+
 bool Paragraph::isNewline(pos_type pos) const
 {
        return isInset(pos)
-               && getInset(pos)->lyxCode() == Inset::NEWLINE_CODE;
+               && getInset(pos)->lyxCode() == NEWLINE_CODE;
 }
 
 
@@ -2331,19 +2474,17 @@ Paragraph::getParLanguage(BufferParams const & bparams) const
 {
        if (!empty())
                return getFirstFontSettings(bparams).language();
-#ifdef WITH_WARNINGS
-#warning FIXME we should check the prev par as well (Lgb)
-#endif
+       // FIXME: we should check the prev par as well (Lgb)
        return bparams.language;
 }
 
 
-bool Paragraph::isRightToLeftPar(BufferParams const & bparams) const
+bool Paragraph::isRTL(BufferParams const & bparams) const
 {
        return lyxrc.rtl_support
                && getParLanguage(bparams)->rightToLeft()
-               && ownerCode() != Inset::ERT_CODE
-               && ownerCode() != Inset::LISTINGS_CODE;
+               && ownerCode() != ERT_CODE
+               && ownerCode() != LISTINGS_CODE;
 }
 
 
@@ -2460,13 +2601,13 @@ int Paragraph::id() const
 }
 
 
-Layout_ptr const & Paragraph::layout() const
+LayoutPtr const & Paragraph::layout() const
 {
        return layout_;
 }
 
 
-void Paragraph::layout(Layout_ptr const & new_layout)
+void Paragraph::layout(LayoutPtr const & new_layout)
 {
        layout_ = new_layout;
 }
@@ -2478,10 +2619,10 @@ Inset * Paragraph::inInset() const
 }
 
 
-Inset::Code Paragraph::ownerCode() const
+InsetCode Paragraph::ownerCode() const
 {
        return pimpl_->inset_owner
-               ? pimpl_->inset_owner->lyxCode() : Inset::NO_CODE;
+               ? pimpl_->inset_owner->lyxCode() : NO_CODE;
 }
 
 
@@ -2504,7 +2645,7 @@ bool Paragraph::isFreeSpacing() const
 
        // for now we just need this, later should we need this in some
        // other way we can always add a function to Inset too.
-       return ownerCode() == Inset::ERT_CODE || ownerCode() == Inset::LISTINGS_CODE;
+       return ownerCode() == ERT_CODE || ownerCode() == LISTINGS_CODE;
 }
 
 
@@ -2512,7 +2653,7 @@ bool Paragraph::allowEmpty() const
 {
        if (layout()->keepempty)
                return true;
-       return ownerCode() == Inset::ERT_CODE || ownerCode() == Inset::LISTINGS_CODE;
+       return ownerCode() == ERT_CODE || ownerCode() == LISTINGS_CODE;
 }
 
 
@@ -2556,83 +2697,76 @@ char_type Paragraph::transformChar(char_type c, pos_type pos) const
 }
 
 
-bool Paragraph::hfillExpansion(Row const & row, pos_type pos) const
+int Paragraph::checkBiblio(bool track_changes)
 {
-       if (!isHfill(pos))
-               return false;
-
-       BOOST_ASSERT(pos >= row.pos() && pos < row.endpos());
-
-       // expand at the end of a row only if there is another hfill on the same row
-       if (pos == row.endpos() - 1) {
-               for (pos_type i = row.pos(); i < pos; i++) {
-                       if (isHfill(i))
-                               return true;
-               }
-               return false;
-       }
-
-       // expand at the beginning of a row only if it is the first row of a paragraph
-       if (pos == row.pos()) {
-               return pos == 0;
-       }
-
-       // do not expand in some labels
-       if (layout()->margintype != MARGIN_MANUAL && pos < beginOfBody())
-               return false;
-
-       // if there is anything between the first char of the row and
-       // the specified position that is neither a newline nor an hfill,
-       // the hfill will be expanded, otherwise it won't
-       for (pos_type i = row.pos(); i < pos; i++) {
-               if (!isNewline(i) && !isHfill(i))
-                       return true;
-       }
-       return false;
-}
-
+       //FIXME From JS:
+       //This is getting more and more a mess. ...We really should clean
+       //up this bibitem issue for 1.6. See also bug 2743.
 
-bool Paragraph::checkBiblio(bool track_changes)
-{
        // Add bibitem insets if necessary
        if (layout()->labeltype != LABEL_BIBLIO)
-               return false;
+               return 0;
 
        bool hasbibitem = !insetlist.empty()
                // Insist on it being in pos 0
                && getChar(0) == Paragraph::META_INSET
-               && insetlist.begin()->inset->lyxCode() == Inset::BIBITEM_CODE;
+               && insetlist.begin()->inset->lyxCode() == BIBITEM_CODE;
 
        docstring oldkey;
        docstring oldlabel;
 
-       // remove bibitems in pos != 0
-       // restore them later in pos 0 if necessary
+       // remove a bibitem in pos != 0
+       // restore it later in pos 0 if necessary
        // (e.g. if a user inserts contents _before_ the item)
-       InsetList::const_iterator it = insetlist.begin();
-       InsetList::const_iterator end = insetlist.end();
+       // we're assuming there's only one of these, which there
+       // should be.
+       int erasedInsetPosition = -1;
+       InsetList::iterator it = insetlist.begin();
+       InsetList::iterator end = insetlist.end();
        for (; it != end; ++it)
-               if (it->inset->lyxCode() == Inset::BIBITEM_CODE
+               if (it->inset->lyxCode() == BIBITEM_CODE
                    && it->pos > 0) {
                        InsetBibitem * olditem = static_cast<InsetBibitem *>(it->inset);
                        oldkey = olditem->getParam("key");
                        oldlabel = olditem->getParam("label");
-                       eraseChar(it->pos, track_changes);
+                       erasedInsetPosition = it->pos;
+                       eraseChar(erasedInsetPosition, track_changes);
+                       break;
        }
 
-       if (hasbibitem)
-               return false;
+       //There was an InsetBibitem at the beginning, and we didn't
+       //have to erase one.
+       if (hasbibitem && erasedInsetPosition < 0)
+                       return 0;
+
+       //There was an InsetBibitem at the beginning and we did have to
+       //erase one. So we give its properties to the beginning inset.
+       if (hasbibitem) {
+               InsetBibitem * inset =
+                       static_cast<InsetBibitem *>(insetlist.begin()->inset);
+               if (!oldkey.empty())
+                       inset->setParam("key", oldkey);
+               inset->setParam("label", oldlabel);
+               return -erasedInsetPosition;
+       }
 
+       //There was no inset at the beginning, so we need to create one with
+       //the key and label of the one we erased.
        InsetBibitem * inset(new InsetBibitem(InsetCommandParams("bibitem")));
        // restore values of previously deleted item in this par.
        if (!oldkey.empty())
                inset->setParam("key", oldkey);
-       if (!oldlabel.empty())
-               inset->setParam("label", oldlabel);
+       inset->setParam("label", oldlabel);
        insertInset(0, static_cast<Inset *>(inset),
                    Change(track_changes ? Change::INSERTED : Change::UNCHANGED));
 
-       return true;
+       return 1;
+}
+
+
+void Paragraph::checkAuthors(AuthorList const & authorList)
+{
+       pimpl_->changes_.checkAuthors(authorList);
 }
 
 } // namespace lyx