]> git.lyx.org Git - features.git/blobdiff - src/Paragraph.cpp
DocBook: refactor font handling.
[features.git] / src / Paragraph.cpp
index 2e8847ade73eda378462cd1bee9a1645254a0bab..5cb17228793d7fc4e5343cf6ba194a6ccb24722d 100644 (file)
@@ -1069,10 +1069,15 @@ void Paragraph::Private::latexInset(BufferParams const & bparams,
                        running_font = basefont;
                        if (!closeLanguage)
                                running_font.setLanguage(copy_font.language());
+                       // For these, we use switches, so no need to close
                        basefont.fontInfo().setSize(copy_font.fontInfo().size());
-                       // leave font open if language is still open
+                       basefont.fontInfo().setFamily(copy_font.fontInfo().family());
+                       basefont.fontInfo().setSeries(copy_font.fontInfo().series());
+                       // leave font open if language or any of the switches is still open
                        open_font = (running_font.language() == basefont.language()
-                                    || running_font.fontInfo().size() == basefont.fontInfo().size());
+                                    || running_font.fontInfo().size() == basefont.fontInfo().size()
+                                    || running_font.fontInfo().family() == basefont.fontInfo().family()
+                                    || running_font.fontInfo().series() == basefont.fontInfo().series());
                        if (closeLanguage)
                                runparams.local_font = &basefont;
                }
@@ -2563,7 +2568,7 @@ void Paragraph::latex(BufferParams const & bparams,
                ++column;
 
                // Fully instantiated font
-               Font const current_font = getFont(bparams, i, outerfont);
+               Font const current_font = getFont(bparams, i, real_outerfont);
 
                Font const last_font = running_font;
                bool const in_ct_deletion = (bparams.output_changes
@@ -2659,10 +2664,11 @@ void Paragraph::latex(BufferParams const & bparams,
                                os << '}';
                                column += 1;
                        }
-                       odocstringstream ods;
-                       column += current_font.latexWriteStartChanges(ods, bparams,
+                       otexstringstream ots;
+                       bool const non_inherit_inset = (c == META_INSET && getInset(i) && !getInset(i)->inheritFont());
+                       column += current_font.latexWriteStartChanges(ots, bparams,
                                                              runparams, basefont,
-                                                             last_font);
+                                                             last_font, non_inherit_inset);
                        // Check again for display math in ulem commands as a
                        // font change may also occur just before a math inset.
                        if (runparams.inDisplayMath && !deleted_display_math
@@ -2674,19 +2680,17 @@ void Paragraph::latex(BufferParams const & bparams,
                        }
                        running_font = current_font;
                        open_font = true;
-                       docstring fontchange = ods.str();
+                       docstring fontchange = ots.str();
+                       os << fontchange;
                        // check whether the fontchange ends with a \\textcolor
-                       // modifier and the text starts with a space (bug 4473)
+                       // modifier and the text starts with a space. If so we
+                       // need to add } in order to prevent \\textcolor from gobbling
+                       // the space (bug 4473).
                        docstring const last_modifier = rsplit(fontchange, '\\');
                        if (prefixIs(last_modifier, from_ascii("textcolor")) && c == ' ')
-                               os << fontchange << from_ascii("{}");
-                       // check if the fontchange ends with a trailing blank
-                       // (like "\small " (see bug 3382)
-                       else if (suffixIs(fontchange, ' ') && c == ' ')
-                               os << fontchange.substr(0, fontchange.size() - 1)
-                                  << from_ascii("{}");
-                       else
-                               os << fontchange;
+                               os << from_ascii("{}");
+                       else if (ots.terminateCommand())
+                               os << termcmd;
                        if (in_ct_deletion) {
                                // We have to close and then reopen \lyxdeleted,
                                // as strikeout needs to be on lowest level.
@@ -3105,15 +3109,7 @@ OptionalFontType fontSizeToXml(FontSize fs)
        }
 }
 
-}// anonymous namespace
-
-
-void Paragraph::simpleDocBookOnePar(Buffer const & buf,
-                                    XMLStream & xs,
-                                    OutputParams const & runparams,
-                                    Font const & outerfont,
-                                    bool start_paragraph, bool close_paragraph,
-                                    pos_type initial) const
+struct DocBookFontState
 {
        // track whether we have opened these tags
        bool emph_flag = false;
@@ -3122,6 +3118,7 @@ void Paragraph::simpleDocBookOnePar(Buffer const & buf,
        bool ubar_flag = false;
        bool dbar_flag = false;
        bool sout_flag = false;
+       bool xout_flag = false;
        bool wave_flag = false;
        // shape tags
        bool shap_flag = false;
@@ -3130,116 +3127,103 @@ void Paragraph::simpleDocBookOnePar(Buffer const & buf,
        // size tags
        bool size_flag = false;
 
-       Layout const & style = *d->layout_;
-
-       if (start_paragraph)
-               xs.startDivision(allowEmpty());
-
-       FontInfo font_old =
-                       style.labeltype == LABEL_MANUAL ? style.labelfont : style.font;
-
        FontShape  curr_fs   = INHERIT_SHAPE;
        FontFamily curr_fam  = INHERIT_FAMILY;
        FontSize   curr_size = INHERIT_SIZE;
+};
 
-       string const default_family =
-                       buf.masterBuffer()->params().fonts_default_family;
-
+std::tuple<vector<xml::FontTag>, vector<xml::EndFontTag>> computeDocBookFontSwitch(FontInfo const & font_old,
+                                                                                          Font const & font,
+                                                                                          std::string const & default_family,
+                                                                                          DocBookFontState fs)
+{
        vector<xml::FontTag> tagsToOpen;
        vector<xml::EndFontTag> tagsToClose;
 
-       // parsing main loop
-       for (pos_type i = initial; i < size(); ++i) {
-               // let's not show deleted material in the output
-               if (isDeleted(i))
-                       continue;
-
-               Font const font = getFont(buf.masterBuffer()->params(), i, outerfont);
-
-               // emphasis
-               FontState curstate = font.fontInfo().emph();
-               if (font_old.emph() != curstate)
-                       doFontSwitchDocBook(tagsToOpen, tagsToClose, emph_flag, curstate, xml::FT_EMPH);
-
-               // noun
-               curstate = font.fontInfo().noun();
-               if (font_old.noun() != curstate)
-                       doFontSwitchDocBook(tagsToOpen, tagsToClose, noun_flag, curstate, xml::FT_NOUN);
-
-               // underbar
-               curstate = font.fontInfo().underbar();
-               if (font_old.underbar() != curstate)
-                       doFontSwitchDocBook(tagsToOpen, tagsToClose, ubar_flag, curstate, xml::FT_UBAR);
-
-               // strikeout
-               curstate = font.fontInfo().strikeout();
-               if (font_old.strikeout() != curstate)
-                       doFontSwitchDocBook(tagsToOpen, tagsToClose, sout_flag, curstate, xml::FT_SOUT);
-
-               // double underbar
-               curstate = font.fontInfo().uuline();
-               if (font_old.uuline() != curstate)
-                       doFontSwitchDocBook(tagsToOpen, tagsToClose, dbar_flag, curstate, xml::FT_DBAR);
-
-               // wavy line
-               curstate = font.fontInfo().uwave();
-               if (font_old.uwave() != curstate)
-                       doFontSwitchDocBook(tagsToOpen, tagsToClose, wave_flag, curstate, xml::FT_WAVE);
-
-               // bold
-               // a little hackish, but allows us to reuse what we have.
-               curstate = (font.fontInfo().series() == BOLD_SERIES ? FONT_ON : FONT_OFF);
-               if (font_old.series() != font.fontInfo().series())
-                       doFontSwitchDocBook(tagsToOpen, tagsToClose, bold_flag, curstate, xml::FT_BOLD);
-
-               // Font shape
-               curr_fs = font.fontInfo().shape();
-               FontShape old_fs = font_old.shape();
-               if (old_fs != curr_fs) {
-                       if (shap_flag) {
-                               OptionalFontType tag = fontShapeToXml(old_fs);
-                               if (tag.has_value) {
-                                       tagsToClose.push_back(docbookEndFontTag(tag.ft));
-                               }
-                               shap_flag = false;
-                       }
-
-                       OptionalFontType tag = fontShapeToXml(curr_fs);
+       // emphasis
+       FontState curstate = font.fontInfo().emph();
+       if (font_old.emph() != curstate)
+               doFontSwitchDocBook(tagsToOpen, tagsToClose, fs.emph_flag, curstate, xml::FT_EMPH);
+
+       // noun
+       curstate = font.fontInfo().noun();
+       if (font_old.noun() != curstate)
+               doFontSwitchDocBook(tagsToOpen, tagsToClose, fs.noun_flag, curstate, xml::FT_NOUN);
+
+       // underbar
+       curstate = font.fontInfo().underbar();
+       if (font_old.underbar() != curstate)
+               doFontSwitchDocBook(tagsToOpen, tagsToClose, fs.ubar_flag, curstate, xml::FT_UBAR);
+
+       // strikeout
+       curstate = font.fontInfo().strikeout();
+       if (font_old.strikeout() != curstate)
+               doFontSwitchDocBook(tagsToOpen, tagsToClose, fs.sout_flag, curstate, xml::FT_SOUT);
+
+       // double underbar
+       curstate = font.fontInfo().uuline();
+       if (font_old.uuline() != curstate)
+               doFontSwitchDocBook(tagsToOpen, tagsToClose, fs.dbar_flag, curstate, xml::FT_DBAR);
+
+       // wavy line
+       curstate = font.fontInfo().uwave();
+       if (font_old.uwave() != curstate)
+               doFontSwitchDocBook(tagsToOpen, tagsToClose, fs.wave_flag, curstate, xml::FT_WAVE);
+
+       // bold
+       // a little hackish, but allows us to reuse what we have.
+       curstate = (font.fontInfo().series() == BOLD_SERIES ? FONT_ON : FONT_OFF);
+       if (font_old.series() != font.fontInfo().series())
+               doFontSwitchDocBook(tagsToOpen, tagsToClose, fs.bold_flag, curstate, xml::FT_BOLD);
+
+       // Font shape
+       fs.curr_fs = font.fontInfo().shape();
+       FontShape old_fs = font_old.shape();
+       if (old_fs != fs.curr_fs) {
+               if (fs.shap_flag) {
+                       OptionalFontType tag = fontShapeToXml(old_fs);
                        if (tag.has_value) {
-                               tagsToOpen.push_back(docbookStartFontTag(tag.ft));
+                               tagsToClose.push_back(docbookEndFontTag(tag.ft));
                        }
+                       fs.shap_flag = false;
                }
 
-               // Font family
-               curr_fam = font.fontInfo().family();
-               FontFamily old_fam = font_old.family();
-               if (old_fam != curr_fam) {
-                       if (faml_flag) {
-                               OptionalFontType tag = fontFamilyToXml(old_fam);
-                               if (tag.has_value) {
-                                       tagsToClose.push_back(docbookEndFontTag(tag.ft));
-                               }
-                               faml_flag = false;
+               OptionalFontType tag = fontShapeToXml(fs.curr_fs);
+               if (tag.has_value) {
+                       tagsToOpen.push_back(docbookStartFontTag(tag.ft));
+               }
+       }
+
+       // Font family
+       fs.curr_fam = font.fontInfo().family();
+       FontFamily old_fam = font_old.family();
+       if (old_fam != fs.curr_fam) {
+               if (fs.faml_flag) {
+                       OptionalFontType tag = fontFamilyToXml(old_fam);
+                       if (tag.has_value) {
+                               tagsToClose.push_back(docbookEndFontTag(tag.ft));
                        }
-                       switch (curr_fam) {
+                       fs.faml_flag = false;
+               }
+               switch (fs.curr_fam) {
                        case ROMAN_FAMILY:
                                // we will treat a "default" font family as roman, since we have
                                // no other idea what to do.
                                if (default_family != "rmdefault" && default_family != "default") {
                                        tagsToOpen.push_back(docbookStartFontTag(xml::FT_ROMAN));
-                                       faml_flag = true;
+                                       fs.faml_flag = true;
                                }
                                break;
                        case SANS_FAMILY:
                                if (default_family != "sfdefault") {
                                        tagsToOpen.push_back(docbookStartFontTag(xml::FT_SANS));
-                                       faml_flag = true;
+                                       fs.faml_flag = true;
                                }
                                break;
                        case TYPEWRITER_FAMILY:
                                if (default_family != "ttdefault") {
                                        tagsToOpen.push_back(docbookStartFontTag(xml::FT_TYPE));
-                                       faml_flag = true;
+                                       fs.faml_flag = true;
                                }
                                break;
                        case INHERIT_FAMILY:
@@ -3248,43 +3232,85 @@ void Paragraph::simpleDocBookOnePar(Buffer const & buf,
                                // the other tags are for internal use
                                LATTEST(false);
                                break;
-                       }
                }
+       }
 
-               // Font size
-               curr_size = font.fontInfo().size();
-               FontSize old_size = font_old.size();
-               if (old_size != curr_size) {
-                       if (size_flag) {
-                               OptionalFontType tag = fontSizeToXml(old_size);
-                               if (tag.has_value) {
-                                       tagsToClose.push_back(docbookEndFontTag(tag.ft));
-                               }
-                               size_flag = false;
-                       }
-
-                       OptionalFontType tag = fontSizeToXml(curr_size);
+       // Font size
+       fs.curr_size = font.fontInfo().size();
+       FontSize old_size = font_old.size();
+       if (old_size != fs.curr_size) {
+               if (fs.size_flag) {
+                       OptionalFontType tag = fontSizeToXml(old_size);
                        if (tag.has_value) {
-                               tagsToOpen.push_back(docbookStartFontTag(tag.ft));
-                               size_flag = true;
+                               tagsToClose.push_back(docbookEndFontTag(tag.ft));
                        }
+                       fs.size_flag = false;
                }
 
-               // FIXME XHTML
-               // Other such tags? What about the other text ranges?
+               OptionalFontType tag = fontSizeToXml(fs.curr_size);
+               if (tag.has_value) {
+                       tagsToOpen.push_back(docbookStartFontTag(tag.ft));
+                       fs.size_flag = true;
+               }
+       }
 
-               vector<xml::EndFontTag>::const_iterator cit = tagsToClose.begin();
-               vector<xml::EndFontTag>::const_iterator cen = tagsToClose.end();
-               for (; cit != cen; ++cit)
-                       xs << *cit;
+       return std::tuple(tagsToOpen, tagsToClose);
+}
 
-               vector<xml::FontTag>::const_iterator sit = tagsToOpen.begin();
-               vector<xml::FontTag>::const_iterator sen = tagsToOpen.end();
-               for (; sit != sen; ++sit)
-                       xs << *sit;
+}// anonymous namespace
 
-               tagsToClose.clear();
-               tagsToOpen.clear();
+
+void Paragraph::simpleDocBookOnePar(Buffer const & buf,
+                                    XMLStream & xs,
+                                    OutputParams const & runparams,
+                                    Font const & outerfont,
+                                    bool start_paragraph, bool close_paragraph,
+                                    pos_type initial) const
+{
+       // track whether we have opened these tags
+       DocBookFontState fs;
+
+       if (start_paragraph)
+               xs.startDivision(allowEmpty());
+
+       Layout const & style = *d->layout_;
+       FontInfo font_old =
+                       style.labeltype == LABEL_MANUAL ? style.labelfont : style.font;
+
+       string const default_family =
+                       buf.masterBuffer()->params().fonts_default_family;
+
+       vector<xml::FontTag> tagsToOpen;
+       vector<xml::EndFontTag> tagsToClose;
+
+       // parsing main loop
+       for (pos_type i = initial; i < size(); ++i) {
+               // let's not show deleted material in the output
+               if (isDeleted(i))
+                       continue;
+
+               Font const font = getFont(buf.masterBuffer()->params(), i, outerfont);
+
+               if (start_paragraph) {
+                       // Determine which tags should be opened or closed.
+                       tie(tagsToOpen, tagsToClose) = computeDocBookFontSwitch(font_old, font, default_family, fs);
+
+                       // FIXME XHTML
+                       // Other such tags? What about the other text ranges?
+
+                       vector<xml::EndFontTag>::const_iterator cit = tagsToClose.begin();
+                       vector<xml::EndFontTag>::const_iterator cen = tagsToClose.end();
+                       for (; cit != cen; ++cit)
+                               xs << *cit;
+
+                       vector<xml::FontTag>::const_iterator sit = tagsToOpen.begin();
+                       vector<xml::FontTag>::const_iterator sen = tagsToOpen.end();
+                       for (; sit != sen; ++sit)
+                               xs << *sit;
+
+                       tagsToClose.clear();
+                       tagsToOpen.clear();
+               }
 
                if (Inset const * inset = getInset(i)) {
                        if (!runparams.for_toc || inset->isInToc()) {
@@ -3292,6 +3318,8 @@ void Paragraph::simpleDocBookOnePar(Buffer const & buf,
                                np.local_font = &font;
                                // If the paragraph has size 1, then we are in the "special
                                // case" where we do not output the containing paragraph info.
+                               // This "special case" is defined in more details in output_docbook.cpp, makeParagraphs. The results
+                               // of that brittle logic is passed to this function through open_par.
                                if (!inset->getLayout().htmlisblock() && size() != 1) // TODO: htmlisblock here too!
                                        np.docbook_in_par = true;
                                inset->docbook(xs, np);