Fix memory leak.

[lyx.git] / src / PDFOptions.cpp

diff --git a/src/PDFOptions.cpp b/src/PDFOptions.cpp
index 1ec7aa436cf5d8e96fb8301b5fcd98f4b4d0f04e..bff976f39d4ff6741093dd538be0e78c90ddd230 100644 (file)
--- a/src/PDFOptions.cpp
+++ b/src/PDFOptions.cpp
@@ -31,13 +31,23 @@ const string PDFOptions::pagemode_fullscreen("FullScreen");
 
 bool PDFOptions::empty() const
 {
-       return author.empty()
-               && title.empty()
-               && subject.empty()
-               && keywords.empty()
-               && pagemode.empty()
-               && bookmarksopenlevel.empty()
-               && quoted_options.empty();
+       PDFOptions x; //implicit hyperref settings
+
+       return  author == x.author
+               && title == x.title
+               && subject == x.subject
+               && keywords == x.keywords
+               && pagemode == x.pagemode
+               && quoted_options == x.quoted_options
+               && bookmarks == x.bookmarks
+               && bookmarksnumbered == x.bookmarksnumbered
+               && bookmarksopen == x.bookmarksopen
+               && bookmarksopenlevel == x.bookmarksopenlevel
+               && breaklinks == x.breaklinks
+               && pdfborder == x.pdfborder
+               && colorlinks == x.colorlinks
+               && backref == x.backref
+               && pagebackref == x.pagebackref ;
 }
 
 void PDFOptions::writeFile(ostream & os) const
@@ -60,8 +70,7 @@ void PDFOptions::writeFile(ostream & os) const
        os << "\\pdf_bookmarks " << convert<string>(bookmarks) << '\n';
        os << "\\pdf_bookmarksnumbered " << convert<string>(bookmarksnumbered) << '\n';
        os << "\\pdf_bookmarksopen " << convert<string>(bookmarksopen) << '\n';
-       if (bookmarksopenlevel.empty())
-               os << "\\pdf_bookmarksopenlevel \"" << bookmarksopenlevel << "\"\n";
+       os << "\\pdf_bookmarksopenlevel \"" << bookmarksopenlevel << "\"\n";
        
        os << "\\pdf_breaklinks "  << convert<string>(breaklinks)  << '\n';
        os << "\\pdf_pdfborder "   << convert<string>(pdfborder)   << '\n';
@@ -84,40 +93,58 @@ void PDFOptions::writeLaTeX(odocstringstream &os) const
        string opt;
        
        opt = "\\usepackage[";
-       if (!title.empty())
-               opt += "pdftitle={"   + title + "},\n";
-       if (!author.empty())
-               opt += "pdfauthor={"  + author + "},\n";
-       if (!subject.empty())
-               opt += "pdfsubject={" + subject + "},\n";
-       if (!keywords.empty())
-               opt += "pdfkeywords={" + keywords + "},\n";
-       
+       // since LyX uses unicode, also set the PDF strings to unicode strings with the
+       // hyperref option "unicode"
+       opt += "unicode=true, ";
+       
+       // try to extract author and title from document when none is
+       // explicitely given
+       if (title.empty() && author.empty())
+               opt += "pdfusetitle,\n ";
+       else
+               opt += "\n ";
        opt += "bookmarks=" + convert<string>(bookmarks) + ',';
        if (bookmarks) {
                opt += "bookmarksnumbered=" + convert<string>(bookmarksnumbered) + ',';
                opt += "bookmarksopen=" + convert<string>(bookmarksopen) + ',';
-       
-               if (bookmarksopen && !bookmarksopenlevel.empty())
-                       opt += "bookmarksopenlevel=" + bookmarksopenlevel + ',';
+               if (bookmarksopen)
+                       opt += "bookmarksopenlevel=" + convert<string>(bookmarksopenlevel) + ',';
        }
-       
+       opt += "\n ";
        opt += "breaklinks="     + convert<string>(breaklinks) + ',';
-       
+
        opt += "pdfborder={0 0 " ;
        opt += (pdfborder ?'0':'1');
-       opt += "},\n";
-       
-       opt += "colorlinks="     + convert<string>(colorlinks) + ',';
+       opt += "},";
+
        opt += "backref="        + convert<string>(backref) + ',';
        opt += "pagebackref="    + convert<string>(pagebackref) + ',';
-       
+       opt += "\n ";
+       opt += "colorlinks="     + convert<string>(colorlinks) + ',';
        if (!pagemode.empty())
                opt += "pdfpagemode=" + pagemode + ',';
-       opt += quoted_options_get();
        
        opt = support::rtrim(opt,",");
-       opt += "]{hyperref}\n";
+       opt += "]\n {hyperref}\n";
+
+       // load the pdftitle etc. as hypersetup, otherwise you'll get
+       // LaTeX-errors when using non-latin characters
+       string hyperset;
+       if (!title.empty())
+               hyperset += "pdftitle={"   + title + "},";
+       if (!author.empty())
+               hyperset += "\n pdfauthor={"  + author + "},";
+       if (!subject.empty())
+               hyperset += "\n pdfsubject={" + subject + "},";
+       if (!keywords.empty())
+               hyperset += "\n pdfkeywords={" + keywords + "},";
+       if (!quoted_options.empty()){
+               hyperset += "\n ";
+               hyperset += quoted_options_get();
+       }
+       hyperset = support::rtrim(hyperset,",");
+       if (!hyperset.empty())
+               opt += "\\hypersetup{" + hyperset + "}\n ";
        
        // FIXME UNICODE
        os << from_utf8(opt);
@@ -141,7 +168,7 @@ string PDFOptions::readToken(Lexer &lex, string const & token)
        } else if (token == "\\pdf_bookmarksnumbered") {
                lex >> bookmarksnumbered;
        } else if (token == "\\pdf_bookmarksopen") {
-               lex >> bookmarksopenlevel;
+               lex >> bookmarksopen;
        } else if (token == "\\pdf_bookmarksopenlevel") {
                lex >> bookmarksopenlevel;
        } else if (token == "\\pdf_breaklinks") {
@@ -173,7 +200,6 @@ string PDFOptions::quoted_options_get() const
        return quoted_options;
 }
 
-
 // Keep implicit hyperref settings
 void PDFOptions::clear()
 {
@@ -185,7 +211,7 @@ void PDFOptions::clear()
        bookmarks               = true;
        bookmarksnumbered       = false;
        bookmarksopen           = false;
-       bookmarksopenlevel.clear();
+       bookmarksopenlevel      = 1;
        breaklinks              = false;
        pdfborder               = false;
        colorlinks              = false;