]> git.lyx.org Git - lyx.git/blobdiff - src/LyXFunc.cpp
cleanup and reorder initialisation code of GuiView and GuiToolbars. Move some things...
[lyx.git] / src / LyXFunc.cpp
index 1bf8931031df5d0a2fa6e4bc034953c904eec80a..ca9428fc26b070749b5aca48399b1800ce9b8820 100644 (file)
@@ -29,6 +29,7 @@
 #include "BufferParams.h"
 #include "BufferView.h"
 #include "CmdDef.h"
+#include "Color.h"
 #include "Converter.h"
 #include "Cursor.h"
 #include "CutAndPaste.h"
 #include "insets/InsetVSpace.h"
 #include "insets/InsetWrap.h"
 
-#include "frontends/Application.h"
 #include "frontends/alert.h"
-#include "frontends/Dialogs.h"
+#include "frontends/Application.h"
 #include "frontends/FileDialog.h"
 #include "frontends/FontLoader.h"
-#include "frontends/Gui.h"
 #include "frontends/KeySymbol.h"
 #include "frontends/LyXView.h"
 #include "frontends/Selection.h"
-#include "frontends/WorkArea.h"
 
 #include "support/environment.h"
 #include "support/FileFilterList.h"
 #include "support/filetools.h"
-#include "support/fs_extras.h"
 #include "support/lstrings.h"
 #include "support/Path.h"
 #include "support/Package.h"
@@ -96,7 +93,6 @@
 #include "support/os.h"
 
 #include <boost/current_function.hpp>
-#include <boost/filesystem/operations.hpp>
 
 #include <sstream>
 
@@ -109,8 +105,6 @@ using std::ostringstream;
 using std::find;
 using std::vector;
 
-namespace fs = boost::filesystem;
-
 namespace lyx {
 
 using frontend::LyXView;
@@ -141,6 +135,7 @@ using support::prefixIs;
 namespace Alert = frontend::Alert;
 
 extern bool quitting;
+extern bool use_gui;
 
 namespace {
 
@@ -189,7 +184,7 @@ bool import(LyXView * lv, FileName const & filename,
                }
                updateLabels(*buf);
                lv->setBuffer(buf);
-               lv->showErrorList("Parse");
+               lv->errors("Parse");
        } else {
                Buffer * const b = newFile(lyxfile.absFilename(), string(), true);
                if (b)
@@ -219,7 +214,7 @@ void reconfigure(LyXView & lv, string const & option)
        lv.message(_("Running configure..."));
 
        // Run configure in user lyx directory
-       support::Path p(package().user_support());
+       support::PathChanger p(package().user_support());
        string configure_command = package().configure_command();
        configure_command += option;
        Systemcall one;
@@ -387,32 +382,20 @@ void LyXFunc::gotoBookmark(unsigned int idx, bool openFile, bool switchToBuffer)
 }
 
 
-namespace {
-void restartCursor(LyXView * lv)
-{
-       /* When we move around, or type, it's nice to be able to see
-        * the cursor immediately after the keypress.
-        */
-       if (lv && lv->currentWorkArea())
-               lv->currentWorkArea()->startBlinkingCursor();
-}
-}
-
 void LyXFunc::processKeySym(KeySymbol const & keysym, KeyModifier state)
 {
-       LYXERR(Debug::KEY) << "KeySym is " << keysym.getSymbolName() << endl;
+       LYXERR(Debug::KEY, "KeySym is " << keysym.getSymbolName());
 
        // Do nothing if we have nothing (JMarc)
        if (!keysym.isOK()) {
-               LYXERR(Debug::KEY) << "Empty kbd action (probably composing)"
-                                  << endl;
-               restartCursor(lyx_view_);
+               LYXERR(Debug::KEY, "Empty kbd action (probably composing)");
+               lyx_view_->restartCursor();
                return;
        }
 
        if (keysym.isModifier()) {
-               LYXERR(Debug::KEY) << "isModifier true" << endl;
-               restartCursor(lyx_view_);
+               LYXERR(Debug::KEY, "isModifier true");
+               lyx_view_->restartCursor();
                return;
        }
 
@@ -427,9 +410,8 @@ void LyXFunc::processKeySym(KeySymbol const & keysym, KeyModifier state)
        cancel_meta_seq.reset();
 
        FuncRequest func = cancel_meta_seq.addkey(keysym, state);
-       LYXERR(Debug::KEY) << BOOST_CURRENT_FUNCTION
-                          << " action first set to [" << func.action << ']'
-                          << endl;
+       LYXERR(Debug::KEY, BOOST_CURRENT_FUNCTION
+                          << " action first set to [" << func.action << ']');
 
        // When not cancel or meta-fake, do the normal lookup.
        // Note how the meta_fake Mod1 bit is OR-ed in and reset afterwards.
@@ -437,9 +419,8 @@ void LyXFunc::processKeySym(KeySymbol const & keysym, KeyModifier state)
        if ((func.action != LFUN_CANCEL) && (func.action != LFUN_META_PREFIX)) {
                // remove Caps Lock and Mod2 as a modifiers
                func = keyseq.addkey(keysym, (state | meta_fake_bit));
-               LYXERR(Debug::KEY) << BOOST_CURRENT_FUNCTION
-                                  << "action now set to ["
-                                  << func.action << ']' << endl;
+               LYXERR(Debug::KEY, BOOST_CURRENT_FUNCTION
+                       << "action now set to [" << func.action << ']');
        }
 
        // Dont remove this unless you know what you are doing.
@@ -449,11 +430,9 @@ void LyXFunc::processKeySym(KeySymbol const & keysym, KeyModifier state)
        if (func.action == LFUN_NOACTION)
                func = FuncRequest(LFUN_COMMAND_PREFIX);
 
-       LYXERR(Debug::KEY) << BOOST_CURRENT_FUNCTION
-              << " Key [action="
-              << func.action << "]["
-              << to_utf8(keyseq.print(KeySequence::Portable)) << ']'
-              << endl;
+       LYXERR(Debug::KEY, BOOST_CURRENT_FUNCTION
+               << " Key [action=" << func.action << "]["
+               << to_utf8(keyseq.print(KeySequence::Portable)) << ']');
 
        // already here we know if it any point in going further
        // why not return already here if action == -1 and
@@ -466,9 +445,9 @@ void LyXFunc::processKeySym(KeySymbol const & keysym, KeyModifier state)
        // Maybe user can only reach the key via holding down shift.
        // Let's see. But only if shift is the only modifier
        if (func.action == LFUN_UNKNOWN_ACTION && state == ShiftModifier) {
-               LYXERR(Debug::KEY) << "Trying without shift" << endl;
+               LYXERR(Debug::KEY, "Trying without shift");
                func = keyseq.addkey(keysym, NoModifier);
-               LYXERR(Debug::KEY) << "Action now " << func.action << endl;
+               LYXERR(Debug::KEY, "Action now " << func.action);
        }
 
        if (func.action == LFUN_UNKNOWN_ACTION) {
@@ -476,13 +455,13 @@ void LyXFunc::processKeySym(KeySymbol const & keysym, KeyModifier state)
                // if it's normal insertable text not already covered
                // by a binding
                if (keysym.isText() && keyseq.length() == 1) {
-                       LYXERR(Debug::KEY) << "isText() is true, inserting." << endl;
+                       LYXERR(Debug::KEY, "isText() is true, inserting.");
                        func = FuncRequest(LFUN_SELF_INSERT,
                                           FuncRequest::KEYBOARD);
                } else {
-                       LYXERR(Debug::KEY) << "Unknown, !isText() - giving up" << endl;
+                       LYXERR(Debug::KEY, "Unknown, !isText() - giving up");
                        lyx_view_->message(_("Unknown function."));
-                       restartCursor(lyx_view_);
+                       lyx_view_->restartCursor();
                        return;
                }
        }
@@ -492,14 +471,13 @@ void LyXFunc::processKeySym(KeySymbol const & keysym, KeyModifier state)
                        docstring const arg(1, encoded_last_key);
                        dispatch(FuncRequest(LFUN_SELF_INSERT, arg,
                                             FuncRequest::KEYBOARD));
-                       LYXERR(Debug::KEY)
-                               << "SelfInsert arg[`" << to_utf8(arg) << "']" << endl;
+                       LYXERR(Debug::KEY, "SelfInsert arg[`" << to_utf8(arg) << "']");
                }
        } else {
                dispatch(func);
        }
 
-       restartCursor(lyx_view_);
+       lyx_view_->restartCursor();
 }
 
 
@@ -603,7 +581,7 @@ FuncStatus LyXFunc::getStatus(FuncRequest const & cmd) const
                enable = buf->lyxvc().inUse();
                break;
        case LFUN_BUFFER_RELOAD:
-               enable = !buf->isUnnamed() && fs::exists(buf->absFileName())
+               enable = !buf->isUnnamed() && buf->fileName().exists()
                        && (!buf->isClean() || buf->isExternallyModified(Buffer::timestamp_method));
                break;
 
@@ -613,7 +591,7 @@ FuncStatus LyXFunc::getStatus(FuncRequest const & cmd) const
                        break;
                }
                string const name = cmd.getArg(0);
-               Inset * inset = lyx_view_->getDialogs().getOpenInset(name);
+               Inset * inset = lyx_view_->getOpenInset(name);
                if (inset) {
                        FuncRequest fr(LFUN_INSET_MODIFY, cmd.argument());
                        FuncStatus fs;
@@ -631,7 +609,8 @@ FuncStatus LyXFunc::getStatus(FuncRequest const & cmd) const
        }
 
        case LFUN_DIALOG_TOGGLE:
-               flag.setOnOff(lyx_view_->getDialogs().visible(cmd.getArg(0)));
+               flag.setOnOff(lyx_view_?
+                       lyx_view_->isDialogVisible(cmd.getArg(0)) : false);
                // fall through to set "enable"
        case LFUN_DIALOG_SHOW: {
                string const name = cmd.getArg(0);
@@ -652,7 +631,7 @@ FuncStatus LyXFunc::getStatus(FuncRequest const & cmd) const
                        }
                }
                else if (name == "latexlog")
-                       enable = FileName(buf->logName().second).isFileReadable();
+                       enable = FileName(buf->logName()).isFileReadable();
                else if (name == "spellchecker")
 #if defined (USE_ASPELL) || defined (USE_ISPELL) || defined (USE_PSPELL)
                        enable = !buf->isReadonly();
@@ -717,12 +696,13 @@ FuncStatus LyXFunc::getStatus(FuncRequest const & cmd) const
                break;
 
        case LFUN_TOOLBAR_TOGGLE: {
-               bool const current = lyx_view_->isToolbarVisible(cmd.getArg(0));
+               bool const current = lyx_view_?
+                       lyx_view_->isToolbarVisible(cmd.getArg(0)) : false;
                flag.setOnOff(current);
                break;
        }
        case LFUN_WINDOW_CLOSE: {
-               enable = (theApp()->gui().viewIds().size() > 1);
+               enable = theApp()->viewCount() > 0;
                break;
        }
 
@@ -739,7 +719,7 @@ FuncStatus LyXFunc::getStatus(FuncRequest const & cmd) const
 
        case LFUN_CALL: {
                FuncRequest func;
-               std::string name(to_utf8(cmd.argument()));
+               std::string name = to_utf8(cmd.argument());
                if (LyX::ref().topLevelCmdDef().lock(name, func)) {
                        func.origin = cmd.origin;
                        flag = getStatus(func);
@@ -855,7 +835,7 @@ bool LyXFunc::ensureBufferClean(BufferView * bv)
        if (buf.isClean())
                return true;
 
-       docstring const file = makeDisplayPath(buf.absFileName(), 30);
+       docstring const file = buf.fileName().displayName(30);
        docstring text = bformat(_("The document %1$s has unsaved "
                                             "changes.\n\nDo you want to save "
                                             "the document?"), file);
@@ -914,7 +894,7 @@ void LyXFunc::dispatch(FuncRequest const & cmd)
        string const argument = to_utf8(cmd.argument());
        kb_action const action = cmd.action;
 
-       LYXERR(Debug::ACTION) << endl << "LyXFunc::dispatch: cmd: " << cmd << endl;
+       LYXERR(Debug::ACTION, "\nLyXFunc::dispatch: cmd: " << cmd);
        //lyxerr << "LyXFunc::dispatch: cmd: " << cmd << endl;
 
        // we have not done anything wrong yet.
@@ -928,13 +908,20 @@ void LyXFunc::dispatch(FuncRequest const & cmd)
        FuncStatus const flag = getStatus(cmd);
        if (!flag.enabled()) {
                // We cannot use this function here
-               LYXERR(Debug::ACTION) << "LyXFunc::dispatch: "
+               LYXERR(Debug::ACTION, "LyXFunc::dispatch: "
                       << lyxaction.getActionName(action)
-                      << " [" << action << "] is disabled at this location"
-                      << endl;
+                      << " [" << action << "] is disabled at this location");
                setErrorMessage(flag.message());
        } else {
                switch (action) {
+               // Let lyx_view_ dispatch its own actions.
+               case LFUN_COMMAND_EXECUTE:
+               case LFUN_DROP_LAYOUTS_CHOICE:
+               case LFUN_MENU_OPEN:
+               case LFUN_TOOLBAR_TOGGLE:
+                       BOOST_ASSERT(lyx_view_);
+                       lyx_view_->dispatch(cmd);
+                       break;
 
                case LFUN_WORD_FIND_FORWARD:
                case LFUN_WORD_FIND_BACKWARD: {
@@ -964,11 +951,6 @@ void LyXFunc::dispatch(FuncRequest const & cmd)
                        lyx_view_->message(keyseq.printOptions(true));
                        break;
 
-               case LFUN_COMMAND_EXECUTE:
-                       BOOST_ASSERT(lyx_view_);
-                       lyx_view_->showMiniBuffer(true);
-                       break;
-
                case LFUN_CANCEL:
                        BOOST_ASSERT(lyx_view_ && lyx_view_->view());
                        keyseq.reset();
@@ -1100,7 +1082,7 @@ void LyXFunc::dispatch(FuncRequest const & cmd)
                case LFUN_BUFFER_EXPORT:
                        BOOST_ASSERT(lyx_view_ && lyx_view_->buffer());
                        if (argument == "custom")
-                               lyx_view_->getDialogs().show("sendto");
+                               lyx_view_->showDialog("sendto", string());
                        else
                                lyx_view_->buffer()->doExport(argument, false);
                        break;
@@ -1179,7 +1161,7 @@ void LyXFunc::dispatch(FuncRequest const & cmd)
                        string const path = buffer->temppath();
                        // Prevent the compiler from optimizing away p
                        FileName pp(path);
-                       support::Path p(pp);
+                       support::PathChanger p(pp);
 
                        // there are three cases here:
                        // 1. we print to a file
@@ -1263,7 +1245,7 @@ void LyXFunc::dispatch(FuncRequest const & cmd)
                        // (leaving the event loop).
                        lyx_view_->message(from_utf8(N_("Exiting.")));
                        if (theBufferList().quitWriteAll())
-                               theApp()->gui().closeAllViews();
+                               theApp()->closeAllViews();
                        break;
 
                case LFUN_BUFFER_AUTO_SAVE:
@@ -1295,7 +1277,7 @@ void LyXFunc::dispatch(FuncRequest const & cmd)
                        if (buf) {
                                updateLabels(*buf);
                                lyx_view_->setBuffer(buf);
-                               lyx_view_->showErrorList("Parse");
+                               lyx_view_->errors("Parse");
                        }
                        updateFlags = Update::None;
                        break;
@@ -1383,23 +1365,12 @@ void LyXFunc::dispatch(FuncRequest const & cmd)
                        updateFlags = Update::None;
                        break;
 
-               case LFUN_DROP_LAYOUTS_CHOICE:
-                       BOOST_ASSERT(lyx_view_);
-                       lyx_view_->openLayoutList();
-                       break;
-
-               case LFUN_MENU_OPEN:
-                       BOOST_ASSERT(lyx_view_);
-                       lyx_view_->openMenu(from_utf8(argument));
-                       break;
-
                // --- lyxserver commands ----------------------------
                case LFUN_SERVER_GET_NAME:
                        BOOST_ASSERT(lyx_view_ && lyx_view_->buffer());
                        setMessage(from_utf8(lyx_view_->buffer()->absFileName()));
-                       LYXERR(Debug::INFO) << "FNAME["
-                                                        << lyx_view_->buffer()->absFileName()
-                                                        << "] " << endl;
+                       LYXERR(Debug::INFO, "FNAME["
+                               << lyx_view_->buffer()->absFileName() << ']');
                        break;
 
                case LFUN_SERVER_NOTIFY:
@@ -1441,7 +1412,7 @@ void LyXFunc::dispatch(FuncRequest const & cmd)
                        lyx_view_->setBuffer(buf);
                        view()->setCursorFromRow(row);
                        if (loaded)
-                               lyx_view_->showErrorList("Parse");
+                               lyx_view_->errors("Parse");
                        updateFlags = Update::FitCursor;
                        break;
                }
@@ -1454,11 +1425,11 @@ void LyXFunc::dispatch(FuncRequest const & cmd)
                        if (name == "character") {
                                data = freefont2string();
                                if (!data.empty())
-                                       lyx_view_->getDialogs().show("character", data);
+                                       lyx_view_->showDialog("character", data);
                        } else if (name == "latexlog") {
-                               pair<Buffer::LogType, string> const logfile =
-                                       lyx_view_->buffer()->logName();
-                               switch (logfile.first) {
+                               Buffer::LogType type; 
+                               string const logfile = lyx_view_->buffer()->logName(&type);
+                               switch (type) {
                                case Buffer::latexlog:
                                        data = "latex ";
                                        break;
@@ -1466,14 +1437,14 @@ void LyXFunc::dispatch(FuncRequest const & cmd)
                                        data = "literate ";
                                        break;
                                }
-                               data += Lexer::quoteString(logfile.second);
-                               lyx_view_->getDialogs().show("log", data);
+                               data += Lexer::quoteString(logfile);
+                               lyx_view_->showDialog("log", data);
                        } else if (name == "vclog") {
                                string const data = "vc " +
                                        Lexer::quoteString(lyx_view_->buffer()->lyxvc().getLogFile());
-                               lyx_view_->getDialogs().show("log", data);
+                               lyx_view_->showDialog("log", data);
                        } else
-                               lyx_view_->getDialogs().show(name, data);
+                               lyx_view_->showDialog(name, data);
                        break;
                }
 
@@ -1570,7 +1541,7 @@ void LyXFunc::dispatch(FuncRequest const & cmd)
                                break;
                        } // end switch(code)
                        if (insetCodeOK)
-                               lyx_view_->getDialogs().show(name, data, 0);
+                               lyx_view_->showDialog(name, data, 0);
                        break;
                }
 
@@ -1578,25 +1549,28 @@ void LyXFunc::dispatch(FuncRequest const & cmd)
                        BOOST_ASSERT(lyx_view_);
                        string const & name = argument;
                        // Can only update a dialog connected to an existing inset
-                       Inset * inset = lyx_view_->getDialogs().getOpenInset(name);
+                       Inset * inset = lyx_view_->getOpenInset(name);
                        if (inset) {
                                FuncRequest fr(LFUN_INSET_DIALOG_UPDATE, cmd.argument());
                                inset->dispatch(view()->cursor(), fr);
                        } else if (name == "paragraph") {
                                dispatch(FuncRequest(LFUN_PARAGRAPH_UPDATE));
                        } else if (name == "prefs") {
-                               lyx_view_->getDialogs().update(name, string());
+                               lyx_view_->updateDialog(name, string());
                        }
                        break;
                }
 
-               case LFUN_DIALOG_HIDE:
-                       LyX::cref().hideDialogs(argument, 0);
+               case LFUN_DIALOG_HIDE: {
+                       if (quitting || !use_gui)
+                               break;
+                       theApp()->hideDialogs(argument, 0);
                        break;
+               }
 
                case LFUN_DIALOG_TOGGLE: {
                        BOOST_ASSERT(lyx_view_);
-                       if (lyx_view_->getDialogs().visible(cmd.getArg(0)))
+                       if (lyx_view_->isDialogVisible(cmd.getArg(0)))
                                dispatch(FuncRequest(LFUN_DIALOG_HIDE, argument));
                        else
                                dispatch(FuncRequest(LFUN_DIALOG_SHOW, argument));
@@ -1605,7 +1579,7 @@ void LyXFunc::dispatch(FuncRequest const & cmd)
 
                case LFUN_DIALOG_DISCONNECT_INSET:
                        BOOST_ASSERT(lyx_view_);
-                       lyx_view_->getDialogs().disconnect(argument);
+                       lyx_view_->disconnectDialog(argument);
                        break;
 
 
@@ -1657,7 +1631,7 @@ void LyXFunc::dispatch(FuncRequest const & cmd)
                                updateLabels(*child->masterBuffer());
                                lyx_view_->setBuffer(child);
                                if (parsed)
-                                       lyx_view_->showErrorList("Parse");
+                                       lyx_view_->errors("Parse");
                        }
 
                        // If a screen update is required (in case where auto_open is false), 
@@ -1812,7 +1786,7 @@ void LyXFunc::dispatch(FuncRequest const & cmd)
                case LFUN_INSET_APPLY: {
                        BOOST_ASSERT(lyx_view_);
                        string const name = cmd.getArg(0);
-                       Inset * inset = lyx_view_->getDialogs().getOpenInset(name);
+                       Inset * inset = lyx_view_->getOpenInset(name);
                        if (inset) {
                                FuncRequest fr(LFUN_INSET_MODIFY, argument);
                                inset->dispatch(view()->cursor(), fr);
@@ -1843,7 +1817,7 @@ void LyXFunc::dispatch(FuncRequest const & cmd)
                                    && (inset_code == NO_CODE
                                    || inset_code == it->lyxCode())) {
                                        Cursor tmpcur = cur;
-                                       tmpcur.pushLeft(*it);
+                                       tmpcur.pushBackward(*it);
                                        it->dispatch(tmpcur, fr);
                                }
                        }
@@ -2016,6 +1990,9 @@ void LyXFunc::dispatch(FuncRequest const & cmd)
 
                        actOnUpdatedPrefs(lyxrc_orig, lyxrc);
 
+                       if (lyx_view_ && lyx_view_->buffer())
+                               lyx_view_->updateLayoutChoice(true);
+
                        /// We force the redraw in any case because there might be
                        /// some screen font changes.
                        /// FIXME: only the current view will be updated. the Gui
@@ -2049,30 +2026,6 @@ void LyXFunc::dispatch(FuncRequest const & cmd)
                        LyX::ref().session().bookmarks().clear();
                        break;
 
-               case LFUN_TOOLBAR_TOGGLE: {
-                       BOOST_ASSERT(lyx_view_);
-                       string const name = cmd.getArg(0);
-                       bool const allowauto = cmd.getArg(1) == "allowauto";
-                       lyx_view_->toggleToolbarState(name, allowauto);
-                       ToolbarInfo * tbi = lyx_view_->getToolbarInfo(name);
-                       if (!tbi) {
-                               setMessage(bformat(_("Unknown toolbar \"%1$s\""),
-                                                  from_utf8(name)));
-                               break;
-                       }
-                       docstring state;
-                       if (tbi->flags & ToolbarInfo::ON)
-                               state = _("on");
-                       else if (tbi->flags & ToolbarInfo::OFF)
-                               state = _("off");
-                       else if (tbi->flags & ToolbarInfo::AUTO)
-                               state = _("auto");
-
-                       setMessage(bformat(_("Toolbar \"%1$s\" state set to %2$s"), 
-                                          _(tbi->gui_name), state));
-                       break;
-               }
-
                default: {
                        BOOST_ASSERT(lyx_view_);
                        view()->cursor().dispatch(cmd);
@@ -2101,7 +2054,7 @@ void LyXFunc::dispatch(FuncRequest const & cmd)
                        theSelection().haveSelection(view()->cursor().selection());
 
                        if (view()->cursor().inTexted()) {
-                               lyx_view_->updateLayoutChoice();
+                               lyx_view_->updateLayoutChoice(false);
                        }
                }
        }
@@ -2120,7 +2073,7 @@ void LyXFunc::sendDispatchMessage(docstring const & msg, FuncRequest const & cmd
                              || cmd.origin == FuncRequest::COMMANDBUFFER);
 
        if (cmd.action == LFUN_SELF_INSERT || !verbose) {
-               LYXERR(Debug::ACTION) << "dispatch msg is " << to_utf8(msg) << endl;
+               LYXERR(Debug::ACTION, "dispatch msg is " << to_utf8(msg));
                if (!msg.empty())
                        lyx_view_->message(msg);
                return;
@@ -2141,7 +2094,7 @@ void LyXFunc::sendDispatchMessage(docstring const & msg, FuncRequest const & cmd
                }
        }
 
-       docstring const shortcuts = theTopLevelKeymap().printbindings(cmd);
+       docstring const shortcuts = theTopLevelKeymap().printBindings(cmd);
 
        if (!shortcuts.empty())
                comname += ": " + shortcuts;
@@ -2153,8 +2106,7 @@ void LyXFunc::sendDispatchMessage(docstring const & msg, FuncRequest const & cmd
                dispatch_msg += '(' + rtrim(comname) + ')';
        }
 
-       LYXERR(Debug::ACTION) << "verbose dispatch msg "
-               << to_utf8(dispatch_msg) << endl;
+       LYXERR(Debug::ACTION, "verbose dispatch msg " << to_utf8(dispatch_msg));
        if (!dispatch_msg.empty())
                lyx_view_->message(dispatch_msg);
 }
@@ -2272,7 +2224,7 @@ void LyXFunc::open(string const & fname)
        if (buf) {
                updateLabels(*buf);
                lyx_view_->setBuffer(buf);
-               lyx_view_->showErrorList("Parse");
+               lyx_view_->errors("Parse");
                str2 = bformat(_("Document %1$s opened."), disp_fn);
        } else {
                str2 = bformat(_("Could not open document %1$s"), disp_fn);
@@ -2286,8 +2238,8 @@ void LyXFunc::doImport(string const & argument)
        string format;
        string filename = split(argument, format, ' ');
 
-       LYXERR(Debug::INFO) << "LyXFunc::doImport: " << format
-                           << " file: " << filename << endl;
+       LYXERR(Debug::INFO, "LyXFunc::doImport: " << format
+                           << " file: " << filename);
 
        // need user interaction
        if (filename.empty()) {
@@ -2387,7 +2339,7 @@ void LyXFunc::reloadBuffer()
        if (buf) {
                updateLabels(*buf);
                lyx_view_->setBuffer(buf);
-               lyx_view_->showErrorList("Parse");
+               lyx_view_->errors("Parse");
                str = bformat(_("Document %1$s reloaded."), disp_fn);
        } else {
                str = bformat(_("Could not reload document %1$s"), disp_fn);
@@ -2499,6 +2451,7 @@ void actOnUpdatedPrefs(LyXRC const & lyxrc_orig, LyXRC const & lyxrc_new)
        case LyXRC::RC_DATE_INSERT_FORMAT:
        case LyXRC::RC_DEFAULT_LANGUAGE:
        case LyXRC::RC_DEFAULT_PAPERSIZE:
+       case LyXRC::RC_DEFFILE:
        case LyXRC::RC_DIALOGS_ICONIFY_WITH_MAIN:
        case LyXRC::RC_DISPLAY_GRAPHICS:
        case LyXRC::RC_DOCUMENTPATH:
@@ -2563,9 +2516,7 @@ void actOnUpdatedPrefs(LyXRC const & lyxrc_orig, LyXRC const & lyxrc_new)
        case LyXRC::RC_SCREEN_FONT_SIZES:
        case LyXRC::RC_SCREEN_FONT_TYPEWRITER:
        case LyXRC::RC_SCREEN_FONT_TYPEWRITER_FOUNDRY:
-       case LyXRC::RC_SCREEN_GEOMETRY_HEIGHT:
-       case LyXRC::RC_SCREEN_GEOMETRY_WIDTH:
-       case LyXRC::RC_SCREEN_GEOMETRY_XYSAVED:
+       case LyXRC::RC_GEOMETRY_SESSION:
        case LyXRC::RC_SCREEN_ZOOM:
        case LyXRC::RC_SERVERPIPE:
        case LyXRC::RC_SET_COLOR:
@@ -2587,8 +2538,10 @@ void actOnUpdatedPrefs(LyXRC const & lyxrc_orig, LyXRC const & lyxrc_new)
        case LyXRC::RC_USE_ESC_CHARS:
        case LyXRC::RC_USE_INP_ENC:
        case LyXRC::RC_USE_PERS_DICT:
+       case LyXRC::RC_USE_PIXMAP_CACHE:
        case LyXRC::RC_USE_SPELL_LIB:
        case LyXRC::RC_VIEWDVI_PAPEROPTION:
+       case LyXRC::RC_SORT_LAYOUTS:
        case LyXRC::RC_VIEWER:
        case LyXRC::RC_LAST:
                break;