Fix calls to find_default_layout (guarentee arguments consistency)

[features.git] / src / EmbeddedFiles.cpp

diff --git a/src/EmbeddedFiles.cpp b/src/EmbeddedFiles.cpp
index a6450073cffd0812c48e5b2f12e56c307e07e57b..0caebe0dbd0828e518fe75b5327ea295f1d5c516 100644 (file)
--- a/src/EmbeddedFiles.cpp
+++ b/src/EmbeddedFiles.cpp
@@ -34,7 +34,7 @@
 #include "support/ExceptionMessage.h"
 #include "support/FileZipListDir.h"
 
-#include <boost/assert.hpp>
+#include "support/assert.h"
 
 #include <sstream>
 #include <fstream>
@@ -71,7 +71,7 @@ void EmbeddedFile::setInzipName(std::string const & name)
                return;
 
        // an enabled EmbeededFile should have this problem handled
-       BOOST_ASSERT(!enabled());
+       LASSERT(!isEnabled(), /**/);
        // file will be synced when it is enabled
        inzip_name_ = name;
 }
@@ -79,29 +79,28 @@ void EmbeddedFile::setInzipName(std::string const & name)
 
 string EmbeddedFile::embeddedFile() const
 {
-       BOOST_ASSERT(enabled());
+       LASSERT(isEnabled(), /**/);
        return temp_path_ + inzip_name_;
 }
 
 
 FileName EmbeddedFile::availableFile() const
 {
-       if (enabled() && embedded())
+       if (isEnabled() && embedded())
                return FileName(embeddedFile());
-       else
-               return *this;
+       return *this;
 }
 
 
 string EmbeddedFile::latexFilename(std::string const & buffer_path) const
 {
-       return (enabled() && embedded()) ? inzip_name_ : relFilename(buffer_path);
+       return (isEnabled() && embedded()) ? inzip_name_ : relFilename(buffer_path);
 }
 
 
 void EmbeddedFile::addInset(Inset const * inset)
 {
-       if (inset != NULL)
+       if (inset)
                inset_list_.push_back(inset);
 }
 
@@ -112,7 +111,7 @@ void EmbeddedFile::setEmbed(bool embed)
 }
 
 
-void EmbeddedFile::enable(bool flag, Buffer const * buf, bool updateFile)
+void EmbeddedFile::enable(bool enabled, Buffer const & buf, bool updateFile)
 {
        // This function will be called when
        // 1. through EmbeddedFiles::enable() when a file is read. Files
@@ -121,12 +120,12 @@ void EmbeddedFile::enable(bool flag, Buffer const * buf, bool updateFile)
        // 2. through menu item enable/disable. updateFile should be true.
        // 3. A single embedded file is added or modified. updateFile
        //    can be true or false.
-       LYXERR(Debug::FILES, (flag ? "Enable" : "Disable") 
+       LYXERR(Debug::FILES, (enabled ? "Enable" : "Disable") 
                << " " << absFilename() 
                << (updateFile ? " (update file)." : " (no update)."));
 
-       if (flag) {
-               temp_path_ = buf->temppath();
+       if (enabled) {
+               temp_path_ = buf.temppath();
                if (!suffixIs(temp_path_, '/'))
                        temp_path_ += '/';
                if (embedded() && updateFile)
@@ -134,7 +133,7 @@ void EmbeddedFile::enable(bool flag, Buffer const * buf, bool updateFile)
        } else {
                // when a new embeddeed file is created, it is not enabled, and 
                // there is no need to extract.
-               if (enabled() && embedded() && updateFile)
+               if (isEnabled() && embedded() && updateFile)
                        extract();
                temp_path_ = "";
        }
@@ -143,7 +142,7 @@ void EmbeddedFile::enable(bool flag, Buffer const * buf, bool updateFile)
 
 bool EmbeddedFile::extract() const
 {
-       BOOST_ASSERT(enabled());
+       LASSERT(isEnabled(), /**/);
 
        string ext_file = absFilename();
        string emb_file = embeddedFile();
@@ -202,7 +201,7 @@ bool EmbeddedFile::extract() const
 
 bool EmbeddedFile::updateFromExternalFile() const
 {
-       BOOST_ASSERT(enabled());
+       LASSERT(isEnabled(), /**/);
 
        string ext_file = absFilename();
        string emb_file = embeddedFile();
@@ -254,11 +253,11 @@ bool EmbeddedFile::updateFromExternalFile() const
 }
 
 
-EmbeddedFile EmbeddedFile::copyTo(Buffer const * buf)
+EmbeddedFile EmbeddedFile::copyTo(Buffer const & buf)
 {
-       EmbeddedFile file = EmbeddedFile(absFilename(), buf->filePath());
+       EmbeddedFile file = EmbeddedFile(absFilename(), buf.filePath());
        file.setEmbed(embedded());
-       file.enable(buf->embedded(), buf, false);
+       file.enable(buf.embedded(), buf, false);
        
        // use external file.
        if (!embedded())
@@ -392,7 +391,7 @@ std::string EmbeddedFile::calcInzipName(std::string const & buffer_path)
 
 void EmbeddedFile::syncInzipFile(std::string const & buffer_path)
 {
-       BOOST_ASSERT(enabled());
+       LASSERT(isEnabled(), /**/);
        string old_emb_file = temp_path_ + '/' + inzip_name_;
        FileName old_emb(old_emb_file);
 
@@ -448,7 +447,7 @@ bool operator!=(EmbeddedFile const & lhs, EmbeddedFile const & rhs)
 }
 
 
-void EmbeddedFileList::enable(bool flag, Buffer & buffer, bool updateFile)
+void EmbeddedFileList::enable(bool enabled, Buffer & buffer, bool updateFile)
 {
        // update embedded file list
        update(buffer);
@@ -459,14 +458,14 @@ void EmbeddedFileList::enable(bool flag, Buffer & buffer, bool updateFile)
        iterator it_end = end();
        // an exception may be thrown
        for (; it != it_end; ++it) {
-               it->enable(flag, &buffer, updateFile);
+               it->enable(enabled, buffer, updateFile);
                if (it->embedded())
                        ++count_embedded;
                else
                        ++count_external;
        }
        // if operation is successful (no exception is thrown)
-       buffer.params().embedded = flag;
+       buffer.params().embedded = enabled;
 
        // if the operation is successful, update insets
        for (it = begin(); it != it_end; ++it)
@@ -476,7 +475,7 @@ void EmbeddedFileList::enable(bool flag, Buffer & buffer, bool updateFile)
                return;
 
        // show result
-       if (flag) {
+       if (enabled) {
                docstring const msg = bformat(_("%1$d external files are ignored.\n"
                        "%2$d embeddable files are embedded.\n"), count_external, count_embedded);
                Alert::information(_("Packing all files"), msg);
@@ -491,7 +490,7 @@ void EmbeddedFileList::enable(bool flag, Buffer & buffer, bool updateFile)
 void EmbeddedFileList::registerFile(EmbeddedFile const & file,
        Inset const * inset, Buffer const & buffer)
 {
-       BOOST_ASSERT(!buffer.embedded() || file.enabled());
+       LASSERT(!buffer.embedded() || file.isEnabled(), /**/);
 
        string newfile = file.absFilename();
        iterator efp = findFile(newfile);
@@ -570,7 +569,7 @@ void EmbeddedFileList::validate(Buffer const & buffer)
        for (; e_it != e_end; ++e_it) {
                EmbeddedFile file = EmbeddedFile(*e_it, buffer.filePath());
                // do not update from external file
-               file.enable(true, &buffer, false);
+               file.enable(true, buffer, false);
                // but we do need to check file existence.
                if (!FileName(file.embeddedFile()).exists())
                        throw ExceptionMessage(ErrorException, _("Failed to open file"),
@@ -594,7 +593,7 @@ void EmbeddedFileList::update(Buffer const & buffer)
        for (; it != it_end; ++it) {
                EmbeddedFile file = EmbeddedFile(*it, buffer.filePath());
                file.setEmbed(true);
-               file.enable(buffer.embedded(), &buffer, false);
+               file.enable(buffer.embedded(), buffer, false);
                insert(end(), file);
        }
 }