#include "CursorSlice.h"
#include <vector>
-#include <algorithm>
+#include <algorithm> // std::min in MSVC 2017
namespace lyx {
class Paragraph;
class Text;
-DocIterator doc_iterator_begin(Buffer const * buf, Inset const * inset = 0);
-DocIterator doc_iterator_end(Buffer const * buf, Inset const * inset = 0);
+DocIterator doc_iterator_begin(Buffer const * buf, Inset const * inset = nullptr);
+DocIterator doc_iterator_end(Buffer const * buf, Inset const * inset = nullptr);
class DocIterator
{
-public:
- /// type for cell number in inset
- typedef CursorSlice::idx_type idx_type;
- /// type for row indices
- typedef CursorSlice::row_type row_type;
- /// type for col indices
- typedef CursorSlice::col_type col_type;
-
public:
///
- DocIterator();
- ///
- explicit DocIterator(Buffer *buf);
+ DocIterator() = default;
+
+ // We could be able to get rid of this if only every BufferView were
+ // associated to a buffer on construction.
+ explicit DocIterator(Buffer *buf)
+ : buffer_(buf)
+ {}
/// access to owning buffer
Buffer * buffer() const { return buffer_; }
/// move backward one paragraph
void backwardPar();
/// move backward one inset
- /// not used currently, uncomment if you need it
- //void backwardInset();
+ void backwardInset();
/// are we some 'extension' (i.e. deeper nested) of the given iterator
bool hasPart(DocIterator const & it) const;
friend DocIterator doc_iterator_begin(Buffer const * buf, Inset const * inset);
friend DocIterator doc_iterator_end(Buffer const * buf, Inset const * inset);
///
- explicit DocIterator(Buffer * buf, Inset * inset);
+ explicit DocIterator(Buffer * buf, Inset * inset)
+ : inset_(inset), buffer_(buf)
+ {}
+
/**
* Normally, when the cursor is at position i, it is painted *before*
* the character at position i. However, what if we want the cursor
* happen *before* i. If the cursor, however, were painted *after* i, that
* would be very unnatural...
*/
- bool boundary_;
+ bool boundary_ = false;
///
std::vector<CursorSlice> const & internalData() const { return slices_; }
///
std::vector<CursorSlice> slices_;
///
- Inset * inset_;
+ Inset * inset_ = nullptr;
///
- Buffer * buffer_;
+ Buffer * buffer_ = nullptr;
};