]> git.lyx.org Git - lyx.git/blobdiff - src/CutAndPaste.cpp
Fix text direction issue for InsetInfo in RTL context
[lyx.git] / src / CutAndPaste.cpp
index d79ef5a655defd744cc98ac6adf26c561194d143..0f269b27e49e7423238fed5d614f4cb6f62e08d6 100644 (file)
@@ -40,6 +40,7 @@
 
 #include "insets/InsetBibitem.h"
 #include "insets/InsetBranch.h"
+#include "insets/InsetCitation.h"
 #include "insets/InsetCommand.h"
 #include "insets/InsetFlex.h"
 #include "insets/InsetGraphics.h"
@@ -141,6 +142,14 @@ pasteSelectionHelper(DocIterator const & cur, ParagraphList const & parlist,
        // Now remove all out of the pars which is NOT allowed in the
        // new environment and set also another font if that is required.
 
+       // Merge paragraphs that are to be pasted into a text inset
+       // that does not allow multiple pars.
+       InsetText * inset_text = target_inset->asInsetText();
+       if (inset_text && !inset_text->allowMultiPar()) {
+               while (insertion.size() > 1)
+                       mergeParagraph(buffer.params(), insertion, 0);
+       }
+
        // Convert newline to paragraph break in ParbreakIsNewline
        if (target_inset->getLayout().parbreakIsNewline()
            || pars[pit].layout().parbreak_is_newline) {
@@ -159,6 +168,41 @@ pasteSelectionHelper(DocIterator const & cur, ParagraphList const & parlist,
                }
        }
 
+       // Prevent to paste uncodable characters in verbatim and ERT.
+       // The encoding is inherited from the context here.
+       docstring uncodable_content;
+       if (target_inset->getLayout().isPassThru() && cur.getEncoding()) {
+               odocstringstream res;
+               Encoding const * e = cur.getEncoding();
+               for (size_t i = 0; i != insertion.size(); ++i) {
+                       pos_type end = insertion[i].size();
+                       for (pos_type j = 0; j != end; ++j) {
+                               // skip insets
+                               if (insertion[i].isInset(j))
+                                       continue;
+                               char_type const c = insertion[i].getChar(j);
+                               if (!e->encodable(c)) {
+                                       // do not track deletion
+                                       res.put(c);
+                                       insertion[i].eraseChar(j, false);
+                                       --end;
+                                       --j;
+                               }
+                       }
+               }
+               docstring const uncodable = res.str();
+               if (!uncodable.empty()) {
+                       if (uncodable.size() == 1)
+                               uncodable_content = bformat(_("The character \"%1$s\" is uncodable in this verbatim context "
+                                                     "and thus has not been pasted."),
+                                                   uncodable);
+                       else
+                               uncodable_content = bformat(_("The characters \"%1$s\" are uncodable in this verbatim context "
+                                                     "and thus have not been pasted."),
+                                                   uncodable);
+               }
+       }
+
        // set the paragraphs to plain layout if necessary
        DocumentClassConstPtr newDocClass = buffer.params().documentClassPtr();
        if (cur.inset().usePlainLayout()) {
@@ -194,6 +238,9 @@ pasteSelectionHelper(DocIterator const & cur, ParagraphList const & parlist,
        // want to invalidate them.
        insertion.swap(in.paragraphs());
        cap::switchBetweenClasses(oldDocClass, newDocClass, in, errorlist);
+       // Do this here since switchBetweenClasses clears the errorlist
+       if (!uncodable_content.empty())
+               errorlist.push_back(ErrorItem(_("Uncodable content"), uncodable_content));
        insertion.swap(in.paragraphs());
 
        ParagraphList::iterator tmpbuf = insertion.begin();
@@ -322,6 +369,16 @@ pasteSelectionHelper(DocIterator const & cur, ParagraphList const & parlist,
                        break;
                }
 
+               case CITE_CODE: {
+                       InsetCitation & cit = static_cast<InsetCitation &>(*it);
+                       // This actually only needs to be done if the cite engine
+                       // differs, but we do it in general.
+                       cit.redoLabel();
+                       // We need to update the list of citations.
+                       need_update = true;
+                       break;
+               }
+
                case BIBITEM_CODE: {
                        // check for duplicates
                        InsetBibitem & bib = static_cast<InsetBibitem &>(*it);
@@ -422,7 +479,7 @@ pasteSelectionHelper(DocIterator const & cur, ParagraphList const & parlist,
        // Set paragraph buffers. It's important to do this right away
        // before something calls Inset::buffer() and causes a crash.
        for (pit_type p = startpit; p <= pit; ++p)
-               pars[p].setBuffer(const_cast<Buffer &>(buffer));
+               pars[p].setInsetBuffers(const_cast<Buffer &>(buffer));
 
        // Join (conditionally) last pasted paragraph with next one, i.e.,
        // the tail of the spliced document paragraph
@@ -631,7 +688,7 @@ void copySelectionHelper(Buffer const & buf, Text const & text,
                // do not have a proper buffer reference. It makes
                // sense to add them temporarily, because the
                // operations below depend on that (acceptChanges included).
-               it->setBuffer(const_cast<Buffer &>(buf));
+               it->setInsetBuffers(const_cast<Buffer &>(buf));
                // PassThru paragraphs have the Language
                // latex_language. This is invalid for others, so we
                // need to change it to the buffer language.
@@ -690,7 +747,7 @@ docstring grabAndEraseSelection(Cursor & cur)
 }
 
 
-bool reduceSelectionToOneCell(Cursor & cur)
+bool reduceSelectionToOneCell(CursorData & cur)
 {
        if (!cur.selection() || !cur.inMathed())
                return false;
@@ -712,7 +769,7 @@ bool reduceSelectionToOneCell(Cursor & cur)
 }
 
 
-bool multipleCellsSelected(Cursor const & cur)
+bool multipleCellsSelected(CursorData const & cur)
 {
        if (!cur.selection() || !cur.inMathed())
                return false;
@@ -770,11 +827,11 @@ void switchBetweenClasses(DocumentClassConstPtr oldone,
 
        // character styles and hidden table cells
        InsetIterator const i_end = inset_iterator_end(in);
-       for (InsetIterator it = inset_iterator_begin(in); it != i_end; ++it) {
-               InsetCode const code = it->lyxCode();
+       for (InsetIterator iit = inset_iterator_begin(in); iit != i_end; ++iit) {
+               InsetCode const code = iit->lyxCode();
                if (code == FLEX_CODE) {
                        // FIXME: Should we verify all InsetCollapsible?
-                       docstring const layoutName = it->layoutName();
+                       docstring const layoutName = iit->layoutName();
                        docstring const & n = newone->insetLayout(layoutName).name();
                        bool const is_undefined = n.empty() ||
                                n == DocumentClass::plainInsetLayout().name();
@@ -795,14 +852,14 @@ void switchBetweenClasses(DocumentClassConstPtr oldone,
                        // To warn the user that something had to be done.
                        errorlist.push_back(ErrorItem(
                                                      _("Undefined flex inset"), s,
-                                                     {it.paragraph().id(), it.pos()},
-                                                     {it.paragraph().id(), it.pos()+1}));
+                                                     {iit.paragraph().id(), iit.pos()},
+                                                     {iit.paragraph().id(), iit.pos() + 1}));
                } else if (code == TABULAR_CODE) {
                        // The recursion above does not catch paragraphs in "hidden" cells,
                        // i.e., ones that are part of a multirow or multicolum. So we need
                        // to handle those separately.
                        // This is the cause of bug #9049.
-                       InsetTabular * table = it->asInsetTabular();
+                       InsetTabular * table = iit->asInsetTabular();
                        table->setLayoutForHiddenCells(newtc);
                }
        }
@@ -827,7 +884,7 @@ vector<docstring> availableSelections(Buffer const * buf)
                for (; pit != pend; ++pit) {
                        Paragraph par(*pit, 0, 46);
                        // adapt paragraph to current buffer.
-                       par.setBuffer(const_cast<Buffer &>(*buf));
+                       par.setInsetBuffers(const_cast<Buffer &>(*buf));
                        textSel += par.asString(AS_STR_INSETS);
                        if (textSel.size() > 45) {
                                support::truncateWithEllipsis(textSel,45);
@@ -848,7 +905,7 @@ size_type numberOfSelections()
 
 namespace {
 
-void cutSelectionHelper(Cursor & cur, CutStack & cuts, bool doclear, bool realcut, bool putclip)
+void cutSelectionHelper(Cursor & cur, CutStack & cuts, bool realcut, bool putclip)
 {
        // This doesn't make sense, if there is no selection
        if (!cur.selection())
@@ -897,11 +954,6 @@ void cutSelectionHelper(Cursor & cur, CutStack & cuts, bool doclear, bool realcu
                cur.pos() = endpos;
                cur.pit() = endpit;
 
-               // sometimes necessary
-               if (doclear
-                       && text->paragraphs()[begpit].stripLeadingSpaces(bp.track_changes))
-                       cur.fixIfBroken();
-
                // need a valid cursor. (Lgb)
                cur.clearSelection();
 
@@ -933,15 +985,15 @@ void cutSelectionHelper(Cursor & cur, CutStack & cuts, bool doclear, bool realcu
 
 } // namespace
 
-void cutSelection(Cursor & cur, bool doclear, bool realcut)
+void cutSelection(Cursor & cur, bool realcut)
 {
-       cutSelectionHelper(cur, theCuts, doclear, realcut, true);
+       cutSelectionHelper(cur, theCuts, realcut, true);
 }
 
 
-void cutSelectionToTemp(Cursor & cur, bool doclear, bool realcut)
+void cutSelectionToTemp(Cursor & cur, bool realcut)
 {
-       cutSelectionHelper(cur, tempCut, doclear, realcut, false);
+       cutSelectionHelper(cur, tempCut, realcut, false);
 }
 
 
@@ -969,7 +1021,7 @@ void copyInset(Cursor const & cur, Inset * inset, docstring const & plaintext)
 
 namespace {
 
-void copySelectionToStack(Cursor const & cur, CutStack & cutstack)
+void copySelectionToStack(CursorData const & cur, CutStack & cutstack)
 {
        // this doesn't make sense, if there is no selection
        if (!cur.selection())
@@ -1002,7 +1054,10 @@ void copySelectionToStack(Cursor const & cur, CutStack & cutstack)
                BufferParams const & bp = cur.buffer()->params();
                // FIXME This should be the plain layout...right?
                par.setLayout(bp.documentClass().plainLayout());
-               par.insert(0, grabSelection(cur), Font(), Change(Change::UNCHANGED));
+               // For pasting into text, we set the language to the paragraph language
+               // (rather than the default_language which is always English; see #2596)
+               par.insert(0, grabSelection(cur), Font(sane_font, par.getParLanguage(bp)),
+                          Change(Change::UNCHANGED));
                pars.push_back(par);
                cutstack.push(make_pair(pars, bp.documentClassPtr()));
        }
@@ -1018,6 +1073,12 @@ void copySelectionToStack()
 }
 
 
+void copySelectionToTemp(Cursor & cur)
+{
+       copySelectionToStack(cur, tempCut);
+}
+
+
 void copySelection(Cursor const & cur, docstring const & plaintext)
 {
        // In tablemode, because copy and paste actually use special table stack
@@ -1190,6 +1251,10 @@ bool pasteClipboardText(Cursor & cur, ErrorList & errorList, bool asParagraphs,
                                if (available)
                                        available = !buffer.paragraphs().empty();
                                if (available && !buffer.paragraphs()[0].empty()) {
+                                       // TeX2lyx (also used in the HTML chain) assumes English as document language
+                                       // if no language is explicitly set (as is the case here).
+                                       // We thus reset the temp buffer's language to the context language
+                                       buffer.changeLanguage(buffer.language(), cur.getFont().language());
                                        cur.recordUndo();
                                        pasteParagraphList(cur, buffer.paragraphs(),
                                                buffer.params().documentClassPtr(), errorList);
@@ -1238,7 +1303,7 @@ void pasteSimpleText(Cursor & cur, bool asParagraphs)
                return;
 
        cur.recordUndo();
-       cutSelection(cur, true, false);
+       cutSelection(cur, false);
        if (asParagraphs)
                cur.text()->insertStringAsParagraphs(cur, text, cur.current_font);
        else
@@ -1294,14 +1359,14 @@ void replaceSelectionWithString(Cursor & cur, docstring const & str)
                par.insertChar(pos, *cit, font, cur.buffer()->params().track_changes);
 
        // Cut the selection
-       cutSelection(cur, true, false);
+       cutSelection(cur, false);
 }
 
 
 void replaceSelection(Cursor & cur)
 {
        if (cur.selection())
-               cutSelection(cur, true, false);
+               cutSelection(cur, false);
 }
 
 
@@ -1369,7 +1434,7 @@ void selClearOrDel(Cursor & cur)
 }
 
 
-docstring grabSelection(Cursor const & cur)
+docstring grabSelection(CursorData const & cur)
 {
        if (!cur.selection())
                return docstring();