]> git.lyx.org Git - lyx.git/blobdiff - src/CutAndPaste.C
bug 2298: cursorTop/Bottom/Home/End does not redraw after dEPM
[lyx.git] / src / CutAndPaste.C
index 25193a4a07cf335c0d43d47c853b38d2bc3c957a..9c78a841ed2ba841a508062847410dc1a5e01f89 100644 (file)
@@ -105,18 +105,19 @@ bool checkPastePossible(int index)
 
 
 pair<PitPosPair, pit_type>
-pasteSelectionHelper(Buffer const & buffer, ParagraphList & pars,
-       pit_type pit, int pos,
-       textclass_type tc, size_t cut_index, ErrorList & errorlist)
+pasteSelectionHelper(Buffer const & buffer, 
+                    ParagraphList & pars, pit_type pit, int pos,
+                    ParagraphList const & parlist, textclass_type textclass, 
+                    ErrorList & errorlist)
 {
-       if (!checkPastePossible(cut_index))
+       if (parlist.empty())
                return make_pair(PitPosPair(pit, pos), pit);
 
        BOOST_ASSERT (pos <= pars[pit].size());
 
        // Make a copy of the CaP paragraphs.
-       ParagraphList insertion = theCuts[cut_index].first;
-       textclass_type const textclass = theCuts[cut_index].second;
+       ParagraphList insertion = parlist;
+       textclass_type const tc = buffer.params().textclass;
 
        // Now remove all out of the pars which is NOT allowed in the
        // new environment and set also another font if that is required.
@@ -233,7 +234,8 @@ pasteSelectionHelper(Buffer const & buffer, ParagraphList & pars,
        pit = last_paste;
        pos = pars[last_paste].size();
 
-       // Maybe some pasting.
+       // Join (conditionally) last pasted paragraph with next one, i.e.,
+       // the tail of the spliced document paragraph
        if (!empty && last_paste + 1 != pit_type(pars.size())) {
                if (pars[last_paste + 1].hasSameLayout(pars[last_paste])) {
                        mergeParagraph(buffer.params(), pars, last_paste);
@@ -270,64 +272,35 @@ PitPosPair eraseSelectionHelper(BufferParams const & params,
                return PitPosPair(endpit, endpos);
        }
 
-       bool all_erased = true;
-
-        // Clear fragments of the first par in selection
-       pars[startpit].erase(startpos, pars[startpit].size());
-       if (pars[startpit].size() != startpos)
-               all_erased = false;
-
-        // Clear fragments of the last par in selection
-       endpos -= pars[endpit].erase(0, endpos);
-       if (endpos != 0)
-               all_erased = false;
-
-        // Erase all the "middle" paragraphs.
-       if (params.tracking_changes) {
-               // Look through the deleted pars if any, erasing as needed
-               for (pit_type pit = startpit + 1; pit != endpit;) {
-                       // "erase" the contents of the par
-                       pars[pit].erase(0, pars[pit].size());
-                       if (pars[pit].empty()) {
-                               // remove the par if it's now empty
-                               pars.erase(pars.begin() + pit);
-                               --endpit;
-                       } else {
-                               ++pit;
-                               all_erased = false;
-                       }
-               }
-       } else {
-               pars.erase(pars.begin() + startpit + 1, pars.begin() + endpit);
-               endpit = startpit + 1;
-       }
-       
-#if 0 // FIXME: why for cut but not copy ?
-       // the cut selection should begin with standard layout
-       if (realcut) {
-               buf->params().clear();
-               buf->bibkey = 0;
-               buf->layout(textclasslist[buffer->params.textclass].defaultLayoutName());
-       }
-#endif
-
-       if (startpit + 1 == pit_type(pars.size()))
-               return PitPosPair(endpit, endpos);
-
-       if (doclear) {
-               pars[startpit + 1].stripLeadingSpaces();
-       }
-
-       // Merge first and last paragraph, if possible
-       if (all_erased &&
-           (pars[startpit].hasSameLayout(pars[startpit + 1]) ||
-            pars[startpit + 1].empty())) {
-               mergeParagraph(params, pars, startpit);
-               // This because endpar gets deleted here!
-               endpit = startpit;
-               endpos = startpos;
+       // A paragraph break has to be physically removed by merging, but
+       // only if either (1) change tracking is off, or (2) the para break
+       // is "blue"
+       for (pit_type pit = startpit; pit != endpit + 1;) {
+               bool const merge = !params.tracking_changes ||
+                       pars[pit].lookupChange(pars[pit].size()) ==
+                       Change::INSERTED;
+               pos_type const left  = ( pit == startpit ? startpos : 0 );
+               pos_type const right = ( pit == endpit ? endpos :
+                               pars[pit].size() + 1 );
+               // Logical erase only:
+               pars[pit].erase(left, right);
+               // Separate handling of para break:
+               if (merge && pit != endpit &&
+                  pars[pit].hasSameLayout(pars[pit + 1])) {
+                       pos_type const thissize = pars[pit].size();
+                       if (doclear)
+                               pars[pit + 1].stripLeadingSpaces();
+                       mergeParagraph(params, pars, pit);
+                       --endpit;
+                       if (pit == endpit)
+                               endpos += thissize;
+               } else 
+                       ++pit;
        }
 
+       // Ensure legal cursor pos:
+       endpit = startpit;
+       endpos = startpos;
        return PitPosPair(endpit, endpos);
 }
 
@@ -370,7 +343,6 @@ string grabAndEraseSelection(LCursor & cur)
                return string();
        string res = grabSelection(cur);
        eraseSelection(cur);
-       cur.selection() = false;
        return res;
 }
 
@@ -473,14 +445,21 @@ std::vector<string> const availableSelections(Buffer const & buffer)
 }
 
 
-int nrOfParagraphs()
+lyx::size_type numberOfSelections()
 {
-       return theCuts.empty() ? 0 : theCuts[0].first.size();
+       return theCuts.size();
 }
 
 
 void cutSelection(LCursor & cur, bool doclear, bool realcut)
 {
+       // This doesn't make sense, if there is no selection
+       if (!cur.selection())
+               return;
+
+       // OK, we have a selection. This is always between cur.selBegin()
+       // and cur.selEnd()
+
        if (cur.inTexted()) {
                LyXText * text = cur.text();
                BOOST_ASSERT(text);
@@ -494,13 +473,6 @@ void cutSelection(LCursor & cur, bool doclear, bool realcut)
                // calls to stuffClipboard. (Lgb)
 //             cur.bv().stuffClipboard(cur.selectionAsString(true));
 
-               // This doesn't make sense, if there is no selection
-               if (!cur.selection())
-                       return;
-
-               // OK, we have a selection. This is always between cur.selBegin()
-               // and cur.selEnd()
-
                // make sure that the depth behind the selection are restored, too
                recordUndoSelection(cur);
                pit_type begpit = cur.selBegin().pit();
@@ -542,11 +514,18 @@ void cutSelection(LCursor & cur, bool doclear, bool realcut)
        }
 
        if (cur.inMathed()) {
-               lyxerr << "cutSelection in mathed" << endl;
-               LCursor tmp = cur;
-               copySelection(cur);
-               cur.selection() = false;
-               eraseSelection(tmp);
+               if (cur.selBegin().idx() != cur.selEnd().idx()) {
+                       // The current selection spans more than one cell.
+                       // Record all cells
+                       recordUndoInset(cur);
+               } else {
+                       // Record only the current cell to avoid a jumping
+                       // cursor after undo
+                       recordUndo(cur);
+               }
+               if (realcut)
+                       copySelection(cur);
+               eraseSelection(cur);
        }
 }
 
@@ -602,13 +581,9 @@ std::string getSelection(Buffer const & buf, size_t sel_index)
 }
 
 
-void pasteSelection(LCursor & cur, size_t sel_index)
+void pasteParagraphList(LCursor & cur, ParagraphList const & parlist, 
+                        textclass_type textclass)
 {
-       // this does not make sense, if there is nothing to paste
-       lyxerr << "#### pasteSelection " << sel_index << endl;
-       if (!checkPastePossible(sel_index))
-               return;
-
        if (cur.inTexted()) {
                LyXText * text = cur.text();
                BOOST_ASSERT(text);
@@ -617,28 +592,35 @@ void pasteSelection(LCursor & cur, size_t sel_index)
 
                pit_type endpit;
                PitPosPair ppp;
-
                ErrorList el;
 
                boost::tie(ppp, endpit) =
                        pasteSelectionHelper(cur.buffer(),
                                              text->paragraphs(),
                                              cur.pit(), cur.pos(),
-                                             cur.buffer().params().textclass,
-                                             sel_index, el);
+                                             parlist, textclass,
+                                             el);
                bufferErrors(cur.buffer(), el);
-               cur.bv().showErrorList(_("Paste"));
-
+               updateCounters(cur.buffer());
                cur.clearSelection();
-               cur.resetAnchor();
                text->setCursor(cur, ppp.first, ppp.second);
-               cur.setSelection();
-               updateCounters(cur.buffer());
        }
 
-       if (cur.inMathed()) {
-               lyxerr << "### should be handled in MathNest/GridInset" << endl;
-       }
+       // mathed is handled in MathNestInset/MathGridInset
+       BOOST_ASSERT(!cur.inMathed());
+}
+
+
+void pasteSelection(LCursor & cur, size_t sel_index)
+{
+       // this does not make sense, if there is nothing to paste
+       if (!checkPastePossible(sel_index))
+               return;
+
+       pasteParagraphList(cur, theCuts[sel_index].first,
+                          theCuts[sel_index].second);
+       cur.bv().showErrorList(_("Paste"));
+       cur.setSelection();
 }
 
 
@@ -710,6 +692,10 @@ void eraseSelection(LCursor & cur)
                cur.top() = i1;
                if (i1.idx() == i2.idx()) {
                        i1.cell().erase(i1.pos(), i2.pos());
+                       // We may have deleted i1.cell(cur.pos()).
+                       // Make sure that pos is valid.
+                       if (cur.pos() > cur.lastpos())
+                               cur.pos() = cur.lastpos();
                } else {
                        MathInset * p = i1.asMathInset();
                        InsetBase::row_type r1, r2;
@@ -721,7 +707,8 @@ void eraseSelection(LCursor & cur)
                        // We've deleted the whole cell. Only pos 0 is valid.
                        cur.pos() = 0;
                }
-               cur.resetAnchor();
+               // need a valid cursor. (Lgb)
+               cur.clearSelection();
        } else {
                lyxerr << "can't erase this selection 1" << endl;
        }
@@ -732,10 +719,8 @@ void eraseSelection(LCursor & cur)
 void selDel(LCursor & cur)
 {
        //lyxerr << "LCursor::selDel" << endl;
-       if (cur.selection()) {
+       if (cur.selection())
                eraseSelection(cur);
-               cur.selection() = false;
-       }
 }
 
 
@@ -749,11 +734,20 @@ void selClearOrDel(LCursor & cur)
 }
 
 
-string grabSelection(LCursor & cur)
+string grabSelection(LCursor const & cur)
 {
        if (!cur.selection())
                return string();
 
+       // FIXME: What is wrong with the following?
+#if 0
+       std::ostringstream os;
+       for (DocIterator dit = cur.selectionBegin();
+            dit != cur.selectionEnd(); dit.forwardPos())
+               os << asString(dit.cell());
+       return os.str();
+#endif
+
        CursorSlice i1 = cur.selBegin();
        CursorSlice i2 = cur.selEnd();