]> git.lyx.org Git - lyx.git/blobdiff - src/BufferView_pimpl.C
cosmetic fix
[lyx.git] / src / BufferView_pimpl.C
index 24d47839f5f6113ca442f435654fbc82fad74183..e1ccdc8b05c7e73281363937bfcdd6d8be598993 100644 (file)
@@ -3,6 +3,7 @@
  * Copyright 2002 the LyX Team
  * Read the file COPYING
  *
+ * \author Lars Gullik Bjønnes
  * \author various
  */
 
@@ -10,6 +11,8 @@
 
 #include "BufferView_pimpl.h"
 #include "bufferlist.h"
+#include "buffer.h"
+#include "buffer_funcs.h"
 #include "bufferview_funcs.h"
 #include "lfuns.h"
 #include "debug.h"
@@ -19,6 +22,7 @@
 #include "gettext.h"
 #include "intl.h"
 #include "iterators.h"
+#include "Lsstream.h"
 #include "lyx_cb.h" // added for Dispatch functions
 #include "lyx_main.h"
 #include "lyxfind.h"
@@ -26,6 +30,7 @@
 #include "lyxtext.h"
 #include "lyxrc.h"
 #include "lyxrow.h"
+#include "lastfiles.h"
 #include "paragraph.h"
 #include "ParagraphParameters.h"
 #include "TextCache.h"
 #include "graphics/Previews.h"
 
 #include "support/LAssert.h"
-#include "support/lstrings.h"
+#include "support/tostr.h"
 #include "support/filetools.h"
 
 #include <boost/bind.hpp>
 #include <boost/signals/connection.hpp>
-#include "support/BoostFormat.h"
 
 #include <unistd.h>
 #include <sys/wait.h>
@@ -72,6 +76,8 @@ using std::make_pair;
 using std::min;
 
 using lyx::pos_type;
+using namespace lyx::support;
+using namespace bv_funcs;
 
 extern BufferList bufferlist;
 
@@ -126,6 +132,111 @@ BufferView::Pimpl::Pimpl(BufferView * bv, LyXView * owner,
 }
 
 
+void BufferView::Pimpl::addError(ErrorItem const & ei)
+{
+       errorlist_.push_back(ei);
+}
+
+
+void BufferView::Pimpl::showReadonly(bool)
+{
+       owner_->updateWindowTitle();
+       owner_->getDialogs().updateBufferDependent(false);
+}
+
+
+void BufferView::Pimpl::connectBuffer(Buffer & buf)
+{
+       if (errorConnection_.connected())
+               disconnectBuffer();
+
+       errorConnection_ = buf.error.connect(boost::bind(&BufferView::Pimpl::addError, this, _1));
+       messageConnection_ = buf.message.connect(boost::bind(&LyXView::message, owner_, _1));
+       busyConnection_ = buf.busy.connect(boost::bind(&LyXView::busy, owner_, _1));
+       titleConnection_ = buf.updateTitles.connect(boost::bind(&LyXView::updateWindowTitle, owner_));
+       timerConnection_ = buf.resetAutosaveTimers.connect(boost::bind(&LyXView::resetAutosaveTimer, owner_));
+       readonlyConnection_ = buf.readonly.connect(boost::bind(&BufferView::Pimpl::showReadonly, this, _1));
+       closingConnection_ = buf.closing.connect(boost::bind(&BufferView::Pimpl::buffer, this, (Buffer *)0));
+}
+
+
+void BufferView::Pimpl::disconnectBuffer()
+{
+       errorConnection_.disconnect();
+       messageConnection_.disconnect();
+       busyConnection_.disconnect();
+       titleConnection_.disconnect();
+       timerConnection_.disconnect();
+       readonlyConnection_.disconnect();
+       closingConnection_.disconnect();
+}
+
+
+bool BufferView::Pimpl::newFile(string const & filename,
+                               string const & tname,
+                               bool isNamed)
+{
+       Buffer * b = ::newFile(filename, tname, isNamed);
+       buffer(b);
+       return true;
+}
+
+
+bool BufferView::Pimpl::loadLyXFile(string const & filename, bool tolastfiles)
+{
+       // get absolute path of file and add ".lyx" to the filename if
+       // necessary
+       string s = FileSearch(string(), filename, "lyx");
+       if (s.empty()) {
+               s = filename;
+       }
+
+       // file already open?
+       if (bufferlist.exists(s)) {
+               string const file = MakeDisplayPath(s, 20);
+               string text = bformat(_("The document %1$s is already "
+                                       "loaded.\n\nDo you want to revert "
+                                       "to the saved version?"), file);
+               int const ret = Alert::prompt(_("Revert to saved document?"),
+                       text, 0, 1,  _("&Revert"), _("&Switch to document"));
+
+               if (ret != 0) {
+                       buffer(bufferlist.getBuffer(s));
+                       return true;
+               } else {
+                       // FIXME: should be LFUN_REVERT
+                       if (!bufferlist.close(bufferlist.getBuffer(s), false))
+                               return false;
+                       // Fall through to new load. (Asger)
+               }
+       }
+       Buffer * b = bufferlist.newBuffer(s);
+
+       connectBuffer(*b);
+
+       if (! ::loadLyXFile(b, s)) {
+               bufferlist.release(b);
+               string text = bformat(_("The document %1$s does not yet "
+                                       "exist.\n\nDo you want to create "
+                                       "a new document?"), s);
+               int const ret = Alert::prompt(_("Create new document?"),
+                        text, 0, 1, _("&Create"), _("Cancel"));
+
+               if (ret != 0)
+                       return false;
+       }
+
+       buffer(b);
+
+       if (tolastfiles)
+               lastfiles->newFile(b->fileName());
+
+       bv_->showErrorList(_("Parse"));
+
+       return true;
+}
+
+
 WorkArea & BufferView::Pimpl::workarea() const
 {
        return *workarea_.get();
@@ -149,8 +260,7 @@ void BufferView::Pimpl::buffer(Buffer * b)
        lyxerr[Debug::INFO] << "Setting buffer in BufferView ("
                            << b << ')' << endl;
        if (buffer_) {
-               buffer_->delUser(bv_);
-
+               disconnectBuffer();
                // Put the old text into the TextCache, but
                // only if the buffer is still loaded.
                // Also set the owner of the test to 0
@@ -176,7 +286,7 @@ void BufferView::Pimpl::buffer(Buffer * b)
 
        if (buffer_) {
                lyxerr[Debug::INFO] << "Buffer addr: " << buffer_ << endl;
-               buffer_->addUser(bv_);
+               connectBuffer(*buffer_);
 
                // If we don't have a text object for this, we make one
                if (bv_->text == 0) {
@@ -184,9 +294,9 @@ void BufferView::Pimpl::buffer(Buffer * b)
                }
 
                // FIXME: needed when ?
-               bv_->text->top_y(screen().topCursorVisible(bv_->text->cursor, bv_->text->top_y()));
+               bv_->text->top_y(screen().topCursorVisible(bv_->text));
 
-               // Similarly, buffer-dependent dialogs should be updated or
+               // Buffer-dependent dialogs should be updated or
                // hidden. This should go here because some dialogs (eg ToC)
                // require bv_->text.
                owner_->getDialogs().updateBufferDependent(true);
@@ -209,8 +319,15 @@ void BufferView::Pimpl::buffer(Buffer * b)
        owner_->updateLayoutChoice();
        owner_->updateWindowTitle();
 
-       if (grfx::Previews::activated() && buffer_)
-               grfx::Previews::get().generateBufferPreviews(*buffer_);
+       if (buffer_) {
+               // Don't forget to update the Layout
+               string const layoutname =
+                       bv_->text->cursor.par()->layout()->name();
+               owner_->setLayout(layoutname);
+       }
+
+       if (lyx::graphics::Previews::activated() && buffer_)
+               lyx::graphics::Previews::get().generateBufferPreviews(*buffer_);
 }
 
 
@@ -227,7 +344,7 @@ bool BufferView::Pimpl::fitCursor()
 
        dispatch(FuncRequest(LFUN_PARAGRAPH_UPDATE));
 
-       // We need to always update, in case we did a 
+       // We need to always update, in case we did a
        // paste and we stayed anchored to a row, but
        // the actual height of the doc changed ...
        updateScrollbar();
@@ -251,9 +368,9 @@ int BufferView::Pimpl::resizeCurrentBuffer()
 {
        lyxerr[Debug::INFO] << "resizeCurrentBuffer" << endl;
 
-       Paragraph * par = 0;
-       Paragraph * selstartpar = 0;
-       Paragraph * selendpar = 0;
+       ParagraphList::iterator par;
+       ParagraphList::iterator selstartpar;
+       ParagraphList::iterator selendpar;
        UpdatableInset * the_locking_inset = 0;
 
        pos_type pos = 0;
@@ -276,17 +393,16 @@ int BufferView::Pimpl::resizeCurrentBuffer()
                selection = bv_->text->selection.set();
                mark_set = bv_->text->selection.mark();
                the_locking_inset = bv_->theLockingInset();
-               buffer_->resizeInsets(bv_);
-               // I don't think the delete and new are necessary here we just could
-               // call only init! (Jug 20020419)
-               delete bv_->text;
-               bv_->text = new LyXText(bv_);
-               bv_->text->init(bv_);
+               resizeInsets(bv_);
+               bv_->text->fullRebreak();
+               update();
        } else {
+               lyxerr << "text not available!\n";
                // See if we have a text in TextCache that fits
                // the new buffer_ with the correct width.
                bv_->text = textcache.findFit(buffer_, workarea().workWidth());
                if (bv_->text) {
+                       lyxerr << "text in cache!\n";
                        if (lyxerr.debugging()) {
                                lyxerr << "Found a LyXText that fits:\n";
                                textcache.show(lyxerr, make_pair(buffer_, make_pair(workarea().workWidth(), bv_->text)));
@@ -296,15 +412,20 @@ int BufferView::Pimpl::resizeCurrentBuffer()
                        if (lyxerr.debugging())
                                textcache.show(lyxerr, "resizeCurrentBuffer");
 
-                       buffer_->resizeInsets(bv_);
+                       resizeInsets(bv_);
                } else {
+                       lyxerr << "no text in cache!\n";
                        bv_->text = new LyXText(bv_);
+                       resizeInsets(bv_);
                        bv_->text->init(bv_);
-                       //buffer_->resizeInsets(bv_);
                }
+
+               par = bv_->text->ownerParagraphs().end();
+               selstartpar = bv_->text->ownerParagraphs().end();
+               selendpar = bv_->text->ownerParagraphs().end();
        }
 
-       if (par) {
+       if (par != bv_->text->ownerParagraphs().end()) {
                bv_->text->selection.set(true);
                // At this point just to avoid the Delete-Empty-Paragraph-
                // Mechanism when setting the cursor.
@@ -324,11 +445,14 @@ int BufferView::Pimpl::resizeCurrentBuffer()
                bv_->theLockingInset(the_locking_inset);
        }
 
-       bv_->text->top_y(screen().topCursorVisible(bv_->text->cursor, bv_->text->top_y()));
+       bv_->text->top_y(screen().topCursorVisible(bv_->text));
 
        switchKeyMap();
        owner_->busy(false);
 
+       // reset the "Formatting..." message
+       owner_->clearMessage();
+
        updateScrollbar();
 
        return 0;
@@ -366,6 +490,8 @@ void BufferView::Pimpl::scrollDocView(int value)
        if (!buffer_)
                return;
 
+       screen().hideCursor();
+
        screen().draw(bv_->text, bv_, value);
 
        if (!lyxrc.cursor_follows_scrollbar)
@@ -413,6 +539,18 @@ void BufferView::Pimpl::workAreaKeyPress(LyXKeySymPtr key,
                                         key_modifier::state state)
 {
        bv_->owner()->getLyXFunc().processKeySym(key, state);
+
+       /* This is perhaps a bit of a hack. When we move
+        * around, or type, it's nice to be able to see
+        * the cursor immediately after the keypress. So
+        * we reset the toggle timeout and force the visibility
+        * of the cursor. Note we cannot do this inside
+        * dispatch() itself, because that's called recursively.
+        */
+       if (available()) {
+               cursor_timeout.restart();
+               screen().showCursor(*bv_);
+       }
 }
 
 
@@ -445,10 +583,9 @@ void BufferView::Pimpl::selectionRequested()
 void BufferView::Pimpl::selectionLost()
 {
        if (available()) {
-               hideCursor();
+               screen().hideCursor();
                toggleSelection();
                bv_->getLyXText()->clearSelection();
-               showCursor();
                bv_->text->xsel_cache.set(false);
        }
 }
@@ -481,7 +618,7 @@ void BufferView::Pimpl::workAreaResize()
                                textcache.show(lyxerr, "Expose delete all");
                        textcache.clear();
                        // FIXME: this is already done in resizeCurrentBuffer() ??
-                       buffer_->resizeInsets(bv_);
+                       resizeInsets(bv_);
                } else if (heightChange) {
                        // fitCursor() ensures we don't jump back
                        // to the start of the document on vertical
@@ -516,10 +653,10 @@ void BufferView::Pimpl::update(LyXText * text, BufferView::UpdateCodes f)
                text->selection.cursor = text->cursor;
        }
 
-       text->fullRebreak();
+       text->partialRebreak();
 
        if (text->inset_owner) {
-               text->inset_owner->setUpdateStatus(bv_, InsetText::NONE);
+               text->inset_owner->setUpdateStatus(InsetText::NONE);
                updateInset(text->inset_owner);
        } else {
                update();
@@ -535,10 +672,10 @@ void BufferView::Pimpl::update(BufferView::UpdateCodes f)
                text->selection.cursor = text->cursor;
        }
 
-       text->fullRebreak();
+       text->partialRebreak();
 
        if (text->inset_owner) {
-               text->inset_owner->setUpdateStatus(bv_, InsetText::NONE);
+               text->inset_owner->setUpdateStatus(InsetText::NONE);
                updateInset(text->inset_owner);
        } else {
                update();
@@ -554,11 +691,7 @@ void BufferView::Pimpl::cursorToggle()
                return;
        }
 
-       if (!bv_->theLockingInset()) {
-               screen().cursorToggle(bv_);
-       } else {
-               bv_->theLockingInset()->toggleInsetCursor(bv_);
-       }
+       screen().toggleCursor(*bv_);
 
        cursor_timeout.restart();
 }
@@ -601,15 +734,8 @@ void BufferView::Pimpl::savePosition(unsigned int i)
        saved_positions[i] = Position(buffer_->fileName(),
                                      bv_->text->cursor.par()->id(),
                                      bv_->text->cursor.pos());
-       if (i > 0) {
-               ostringstream str;
-#if USE_BOOST_FORMAT
-               str << boost::format(_("Saved bookmark %1$d")) % i;
-#else
-               str << _("Saved bookmark ") << i;
-#endif
-               owner_->message(STRCONV(str.str()));
-       }
+       if (i > 0)
+               owner_->message(bformat(_("Saved bookmark %1$s"), tostr(i)));
 }
 
 
@@ -623,29 +749,27 @@ void BufferView::Pimpl::restorePosition(unsigned int i)
        beforeChange(bv_->text);
 
        if (fname != buffer_->fileName()) {
-               Buffer * b = bufferlist.exists(fname) ?
-                       bufferlist.getBuffer(fname) :
-                       bufferlist.loadLyXFile(fname); // don't ask, just load it
-               if (b != 0) buffer(b);
+               Buffer * b;
+               if (bufferlist.exists(fname))
+                       b = bufferlist.getBuffer(fname);
+               else {
+                       b = bufferlist.newBuffer(fname);
+                       ::loadLyXFile(b, fname); // don't ask, just load it
+               }
+               if (b != 0)
+                       buffer(b);
        }
 
-       Paragraph * par = buffer_->getParFromID(saved_positions[i].par_id);
-       if (!par)
+       ParIterator par = buffer_->getParFromID(saved_positions[i].par_id);
+       if (par == buffer_->par_iterator_end())
                return;
 
-       bv_->text->setCursor(par,
+       bv_->text->setCursor(par.pit(),
                             min(par->size(), saved_positions[i].par_pos));
 
        update(BufferView::SELECT);
-       if (i > 0) {
-               ostringstream str;
-#if USE_BOOST_FORMAT
-               str << boost::format(_("Moved to bookmark %1$d")) % i;
-#else
-               str << _("Moved to bookmark ") << i;
-#endif
-               owner_->message(STRCONV(str.str()));
-       }
+       if (i > 0)
+               owner_->message(bformat(_("Moved to bookmark %1$s"), tostr(i)));
 }
 
 
@@ -666,7 +790,7 @@ void BufferView::Pimpl::switchKeyMap()
        LyXText * text = bv_->getLyXText();
        if (text->real_current_font.isRightToLeft()
            && !(bv_->theLockingInset()
-                && bv_->theLockingInset()->lyxCode() == Inset::ERT_CODE))
+                && bv_->theLockingInset()->lyxCode() == InsetOld::ERT_CODE))
        {
                if (owner_->getIntl().keymap == Intl::PRIMARY)
                        owner_->getIntl().KeyMapSec();
@@ -687,22 +811,6 @@ void BufferView::Pimpl::insetUnlock()
 }
 
 
-void BufferView::Pimpl::showCursor()
-{
-       if (bv_->theLockingInset())
-               bv_->theLockingInset()->showInsetCursor(bv_);
-       else
-               screen().showCursor(bv_->text, bv_);
-}
-
-
-void BufferView::Pimpl::hideCursor()
-{
-       if (!bv_->theLockingInset())
-               screen().hideCursor();
-}
-
-
 void BufferView::Pimpl::toggleSelection(bool b)
 {
        if (bv_->theLockingInset())
@@ -758,7 +866,7 @@ void BufferView::Pimpl::stuffClipboard(string const & stuff) const
  */
 
 
-Inset * BufferView::Pimpl::getInsetByCode(Inset::Code code)
+InsetOld * BufferView::Pimpl::getInsetByCode(InsetOld::Code code)
 {
 #if 0
        LyXCursor cursor = bv_->getLyXText()->cursor;
@@ -849,33 +957,14 @@ void BufferView::Pimpl::MenuInsertLyXFile(string const & filen)
        // necessary
        filename = FileSearch(string(), filename, "lyx");
 
-       string const disp_fn(MakeDisplayPath(filename));
-
-       ostringstream s1;
-#if USE_BOOST_FORMAT
-       s1 << boost::format(_("Inserting document %1$s...")) % disp_fn;
-#else
-       s1 << _("Inserting document ") << disp_fn << _("...");
-#endif
-       owner_->message(STRCONV(s1.str()));
-       bool const res = bv_->insertLyXFile(filename);
-       if (res) {
-               ostringstream str;
-#if USE_BOOST_FORMAT
-               str << boost::format(_("Document %1$s inserted.")) % disp_fn;
-#else
-               str << _("Document ") << disp_fn << _(" inserted.");
-#endif
-               owner_->message(STRCONV(str.str()));
-       } else {
-               ostringstream str;
-#if USE_BOOST_FORMAT
-               str << boost::format(_("Could not insert document %1$s")) % disp_fn;
-#else
-               str << _("Could not insert document ") << disp_fn;
-#endif
-               owner_->message(STRCONV(str.str()));
-       }
+       string const disp_fn = MakeDisplayPath(filename);
+       owner_->message(bformat(_("Inserting document %1$s..."), disp_fn));
+       if (bv_->insertLyXFile(filename))
+               owner_->message(bformat(_("Document %1$s inserted."),
+                                       disp_fn));
+       else
+               owner_->message(bformat(_("Could not insert document %1$s"),
+                                       disp_fn));
 }
 
 
@@ -886,29 +975,27 @@ void BufferView::Pimpl::trackChanges()
 
        if (!tracking) {
                ParIterator const end = buf->par_iterator_end();
-               for (ParIterator it = buf->par_iterator_begin(); it != end; ++it) {
-                       (*it)->trackChanges();
-               }
+               for (ParIterator it = buf->par_iterator_begin(); it != end; ++it)
+                       it->trackChanges();
                buf->params.tracking_changes = true;
 
                // we cannot allow undos beyond the freeze point
                buf->undostack.clear();
        } else {
                update(BufferView::SELECT);
-               bv_->text->setCursor(&(*buf->paragraphs.begin()), 0);
+               bv_->text->setCursor(buf->paragraphs.begin(), 0);
 #warning changes FIXME
                //moveCursorUpdate(false);
 
-               bool found = lyxfind::findNextChange(bv_);
+               bool found = lyx::find::findNextChange(bv_);
                if (found) {
                        owner_->getDialogs().show("changes");
                        return;
                }
 
                ParIterator const end = buf->par_iterator_end();
-               for (ParIterator it = buf->par_iterator_begin(); it != end; ++it) {
-                       (*it)->untrackChanges();
-               }
+               for (ParIterator it = buf->par_iterator_begin(); it != end; ++it)
+                       it->untrackChanges();
                buf->params.tracking_changes = false;
        }
 
@@ -924,11 +1011,28 @@ bool BufferView::Pimpl::workAreaDispatch(FuncRequest const & ev_in)
        if (!available())
                return false;
 
-       bool const res = dispatch(ev_in);
+       screen().hideCursor();
 
+       // Make sure that the cached BufferView is correct.
+       FuncRequest ev = ev_in;
+       ev.setView(bv_);
+
+       bool const res = dispatch(ev);
+
+       // see workAreaKeyPress
+       cursor_timeout.restart();
+       screen().showCursor(*bv_);
+
+       // FIXME: we should skip these when selecting
        bv_->owner()->updateLayoutChoice();
+       bv_->owner()->updateToolbar();
        bv_->fitCursor();
 
+       // slight hack: this is only called currently when
+       // we clicked somewhere, so we force through the display
+       // of the new status here.
+       bv_->owner()->clearMessage();
+
        return res;
 }
 
@@ -957,15 +1061,6 @@ bool BufferView::Pimpl::dispatch(FuncRequest const & ev_in)
                // a tabular-inset
                break;
 
-       case LFUN_LAYOUT_COPY:
-               bv_->copyEnvironment();
-               break;
-
-       case LFUN_LAYOUT_PASTE:
-               bv_->pasteEnvironment();
-               switchKeyMap();
-               break;
-
        case LFUN_FILE_INSERT:
                MenuInsertLyXFile(ev.argument);
                break;
@@ -1055,7 +1150,7 @@ bool BufferView::Pimpl::dispatch(FuncRequest const & ev_in)
                string label = ev.argument;
                if (label.empty()) {
                        InsetRef * inset =
-                               static_cast<InsetRef*>(getInsetByCode(Inset::REF_CODE));
+                               static_cast<InsetRef*>(getInsetByCode(InsetOld::REF_CODE));
                        if (inset) {
                                label = inset->getContents();
                                savePosition(0);
@@ -1125,7 +1220,7 @@ bool BufferView::Pimpl::dispatch(FuncRequest const & ev_in)
        break;
 
        case LFUN_INSET_INSERT: {
-               Inset * inset = createInset(ev);
+               InsetOld * inset = createInset(ev);
                if (inset && insertInset(inset)) {
                        updateInset(inset);
 
@@ -1143,10 +1238,10 @@ bool BufferView::Pimpl::dispatch(FuncRequest const & ev_in)
                }
        }
        break;
-       
+
        case LFUN_FLOAT_LIST:
                if (tclass.floats().typeExist(ev.argument)) {
-                       Inset * inset = new InsetFloatList(ev.argument);
+                       InsetOld * inset = new InsetFloatList(ev.argument);
                        if (!insertInset(inset, tclass.defaultLayoutName()))
                                delete inset;
                } else {
@@ -1156,7 +1251,7 @@ bool BufferView::Pimpl::dispatch(FuncRequest const & ev_in)
                break;
 
        case LFUN_LAYOUT_PARAGRAPH: {
-               Paragraph const * par = bv_->getLyXText()->cursor.par();
+               Paragraph const * par = &*bv_->getLyXText()->cursor.par();
                if (!par)
                        break;
 
@@ -1169,7 +1264,9 @@ bool BufferView::Pimpl::dispatch(FuncRequest const & ev_in)
        }
 
        case LFUN_PARAGRAPH_UPDATE: {
-               Paragraph const * par = bv_->getLyXText()->cursor.par();
+               if (!bv_->owner()->getDialogs().visible("paragraph"))
+                       break;
+               Paragraph const * par = &*bv_->getLyXText()->cursor.par();
                if (!par)
                        break;
 
@@ -1177,7 +1274,7 @@ bool BufferView::Pimpl::dispatch(FuncRequest const & ev_in)
                params2string(*par, data);
 
                // Will the paragraph accept changes from the dialog?
-               Inset * const inset = par->inInset();
+               InsetOld * const inset = par->inInset();
                bool const accept =
                        !(inset && inset->forceDefaultParagraphs(inset));
 
@@ -1201,7 +1298,7 @@ bool BufferView::Pimpl::dispatch(FuncRequest const & ev_in)
                        // FIXME
                        if (arg.size() > 100 || arg.empty()) {
                                // Get word or selection
-                               bv_->getLyXText()->selectWordWhenUnderCursor(LyXText::WHOLE_WORD);
+                               bv_->getLyXText()->selectWordWhenUnderCursor(lyx::WHOLE_WORD);
                                arg = bv_->getLyXText()->selectionAsString(buffer_, false);
                                // FIXME: where is getLyXText()->unselect(bv_) ?
                        }
@@ -1221,11 +1318,11 @@ bool BufferView::Pimpl::dispatch(FuncRequest const & ev_in)
 
        case LFUN_ACCEPT_ALL_CHANGES: {
                update(BufferView::SELECT);
-               bv_->text->setCursor(&(*bv_->buffer()->paragraphs.begin()), 0);
+               bv_->text->setCursor(bv_->buffer()->paragraphs.begin(), 0);
 #warning FIXME changes
                //moveCursorUpdate(false);
 
-               while (lyxfind::findNextChange(bv_)) {
+               while (lyx::find::findNextChange(bv_)) {
                        bv_->getLyXText()->acceptChange();
                }
                update(BufferView::SELECT);
@@ -1234,11 +1331,11 @@ bool BufferView::Pimpl::dispatch(FuncRequest const & ev_in)
 
        case LFUN_REJECT_ALL_CHANGES: {
                update(BufferView::SELECT);
-               bv_->text->setCursor(&(*bv_->buffer()->paragraphs.begin()), 0);
+               bv_->text->setCursor(bv_->buffer()->paragraphs.begin(), 0);
 #warning FIXME changes
                //moveCursorUpdate(false);
 
-               while (lyxfind::findNextChange(bv_)) {
+               while (lyx::find::findNextChange(bv_)) {
                        bv_->getLyXText()->rejectChange();
                }
                update(BufferView::SELECT);
@@ -1269,7 +1366,7 @@ bool BufferView::Pimpl::dispatch(FuncRequest const & ev_in)
 }
 
 
-bool BufferView::Pimpl::insertInset(Inset * inset, string const & lout)
+bool BufferView::Pimpl::insertInset(InsetOld * inset, string const & lout)
 {
        // if we are in a locking inset we should try to insert the
        // inset there otherwise this is a illegal function now
@@ -1280,7 +1377,7 @@ bool BufferView::Pimpl::insertInset(Inset * inset, string const & lout)
        }
 
        // not quite sure if we want this...
-       setCursorParUndo(bv_);
+       recordUndo(bv_, Undo::ATOMIC);
        freezeUndo();
 
        beforeChange(bv_->text);
@@ -1330,7 +1427,7 @@ bool BufferView::Pimpl::insertInset(Inset * inset, string const & lout)
 }
 
 
-void BufferView::Pimpl::updateInset(Inset * inset)
+void BufferView::Pimpl::updateInset(InsetOld * inset)
 {
        if (!inset || !available())
                return;
@@ -1355,10 +1452,9 @@ void BufferView::Pimpl::updateInset(Inset * inset)
        // then check if the inset is a top_level inset (has no owner)
        // if yes do the update as always otherwise we have to update the
        // toplevel inset where this inset is inside
-       Inset * tl_inset = inset;
+       InsetOld * tl_inset = inset;
        while (tl_inset->owner())
                tl_inset = tl_inset->owner();
-       hideCursor();
        if (tl_inset == inset) {
                update(BufferView::UPDATE);
                if (bv_->text->updateInset(inset)) {